8 hours ago[GDI32] master trunk
tkreuzer [Thu, 18 Dec 2014 08:13:14 +0000 (08:13 +0000)]
- Rename SetRectRgnEx to IntSetRectRgn and make it usermode only
- Implement IntSetNullRgn
- Improve SetRectRgn code and enable the usermode part

git-svn-id: file:///srv/svn/reactos/trunk@65739 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[GDI32]
tkreuzer [Thu, 18 Dec 2014 08:13:10 +0000 (08:13 +0000)]
Rewrite CombineRgn, enabling full handling in usermode if the resulting region is either a rectangular or a NULL region.

git-svn-id: file:///srv/svn/reactos/trunk@65738 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:13:06 +0000 (08:13 +0000)]
Fix REGION_vSyncRegion and RGNOBJAPI_Unlock to actually make sense

git-svn-id: file:///srv/svn/reactos/trunk@65737 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[USER32]
tkreuzer [Thu, 18 Dec 2014 08:13:01 +0000 (08:13 +0000)]
Fix copy-paste-bug in SubtractRect

git-svn-id: file:///srv/svn/reactos/trunk@65736 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:55 +0000 (08:12 +0000)]
- Rename xmemcheck to REGION_bGrowBufferSize
- Implement REGION_bEnsureBufferSize and REGION_vAddRect helper functions
- Replace MERGERECT macro with REGION_bMergeRect inline function

git-svn-id: file:///srv/svn/reactos/trunk@65735 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:51 +0000 (08:12 +0000)]
Improve REGION_bMakeFrameRegion and REGION_bMakeSimpleFrameRgn

git-svn-id: file:///srv/svn/reactos/trunk@65734 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:41 +0000 (08:12 +0000)]
- Make REGION_iOffsetRgn check the region for coordinate space overflow and fail, if the region cannot be moved
- Rename REGION_iOffsetRgn to REGION_bOffsetRgn and make it return BOOL instead of the complexity, since the majority of callers are not interested in the complexity. It's also more obvious that we need to check for an error.

git-svn-id: file:///srv/svn/reactos/trunk@65733 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:34 +0000 (08:12 +0000)]
- Rename IntGdiOffsetRgn to REGION_iOffsetRgn

git-svn-id: file:///srv/svn/reactos/trunk@65732 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:28 +0000 (08:12 +0000)]
Implement exclusive lock order checks for GDI objects in debug builds

git-svn-id: file:///srv/svn/reactos/trunk@65731 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:23 +0000 (08:12 +0000)]
- Rewrite NtGdiFillRgn and IntGdiPaintRgn
We now properly support painting regions on DCs with arbitrary world transforms, with pattern brushes and we respect the foreground ROP and mode of the DC. And we don't run into deadlocks due to having an exclusive region lock while trying to lock a DC. LOCKING MUST BE DONE IN PROPER ORDER!

git-svn-id: file:///srv/svn/reactos/trunk@65730 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:19 +0000 (08:12 +0000)]
Properly implement EngPaint, calling IntEngBitBlt, instead of doing a manual single color fill.

git-svn-id: file:///srv/svn/reactos/trunk@65729 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:06 +0000 (08:12 +0000)]
- Implement REGION_bXformRgn
- Move IntGdiPaintRgn ro bitblt.c

git-svn-id: file:///srv/svn/reactos/trunk@65728 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:12:01 +0000 (08:12 +0000)]
- Move IntGdiReleaseRaoRgn and IntGdiReleaseVisRgn to cliprgn.c
- Remove unused IntUpdateVisRectRgn

git-svn-id: file:///srv/svn/reactos/trunk@65727 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:56 +0000 (08:11 +0000)]
- Rename IntSetPolyPolygonRgn to REGION_SetPolyPolygonRgn
- Implement GreCreatePolyPolygonRgn wrapper around it
- Fix iMode usage in NtGdiPolyPolyDraw
- Improve some variable naming

git-svn-id: file:///srv/svn/reactos/trunk@65726 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:50 +0000 (08:11 +0000)]
Rework GreCreateFrameRgn to return the new region. Implement the internal function REGION_bMakeFrameRegion doing the actual work. Fix frame calculation by moving the source region diagonal instead of only horizontal and vertical, use IntGdiOffsetRgn instead of manually fiddling with the rectangles.

git-svn-id: file:///srv/svn/reactos/trunk@65725 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:42 +0000 (08:11 +0000)]
- Move NtGdiFillRgn and NtGdiFrameRgn to bitblt.c
- Remove unused NtGdiUnionRectWithRgn
- Rename REGION_CreateFrameRgn to GreCreateFrameRgn

git-svn-id: file:///srv/svn/reactos/trunk@65724 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:36 +0000 (08:11 +0000)]
Move NtGdiInvertRgn to bitblt.c

git-svn-id: file:///srv/svn/reactos/trunk@65723 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:31 +0000 (08:11 +0000)]
- Remove useless offset part in REGION_CropAndOffsetRegion

git-svn-id: file:///srv/svn/reactos/trunk@65722 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:25 +0000 (08:11 +0000)]
Fix MSVC warnings

git-svn-id: file:///srv/svn/reactos/trunk@65721 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K]
tkreuzer [Thu, 18 Dec 2014 08:11:19 +0000 (08:11 +0000)]
More improvements to region.c:
- PROSRGNDATA -> REGION, void -> VOID, int -> INT, uppercase struct names
- do not put assignments into if statements
- !x -> x == NULL for pointers
- Add additional parentheses / curly braces
- rename RGN_ATTR::Flags to iComplexity

git-svn-id: file:///srv/svn/reactos/trunk@65720 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[WIN32K/FORMATTING]
tkreuzer [Thu, 18 Dec 2014 08:11:13 +0000 (08:11 +0000)]
- Tabs -> spaces
- Fix indentation
- Improve comment formating
- No code change

git-svn-id: file:///srv/svn/reactos/trunk@65719 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[GDI32]
tkreuzer [Thu, 18 Dec 2014 08:11:09 +0000 (08:11 +0000)]
Avoid casting RECT and POINT to RECTL and POINTL by adding a define

git-svn-id: file:///srv/svn/reactos/trunk@65718 97493ccd-5924-5043-b1f5-66cb403b36ce

8 hours ago[GDI32]
tkreuzer [Thu, 18 Dec 2014 08:11:04 +0000 (08:11 +0000)]
Implement GdiGetRgnAttr

git-svn-id: file:///srv/svn/reactos/trunk@65717 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[USER32][USERSRV]
hbelusca [Thu, 18 Dec 2014 01:53:08 +0000 (01:53 +0000)]
Temporarily disable UserClientConnect (in server side) and CSR client to server call (in client side), always set gfServerProcess to FALSE (that is normally almost true but when CSR itself does USER32 operations...), and comment again GetConnect() call in ClientThreadSetup, in an attempt to "fix" 3rd stage for bots (so that we don't assert in DesktopPtrToUser because some pdi is NULL...)

git-svn-id: file:///srv/svn/reactos/trunk@65716 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[CONSRV]: Explicitely use UNICODE SetWindowText API.
hbelusca [Thu, 18 Dec 2014 01:35:55 +0000 (01:35 +0000)]
[CONSRV]: Explicitely use UNICODE SetWindowText API.

git-svn-id: file:///srv/svn/reactos/trunk@65715 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[WIN32K]
hbelusca [Thu, 18 Dec 2014 00:30:27 +0000 (00:30 +0000)]
- Code formatting for NtUserProcessConnect.
- Hack a call to GetConnected in ClientThreadSetup in an attempt to temporarily "fix" a bug that makes the bots fail. Now we really need to fix user32 init!

git-svn-id: file:///srv/svn/reactos/trunk@65714 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[NtUser]
jimtabor [Thu, 18 Dec 2014 00:19:33 +0000 (00:19 +0000)]
- Cleanup status and update header.

git-svn-id: file:///srv/svn/reactos/trunk@65713 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[USERSRV]
hbelusca [Wed, 17 Dec 2014 23:03:36 +0000 (23:03 +0000)]
- Set the process creation notify routine for BASE that needs to be called when a process is created.
Patch by Timo, see CORE-7505.

- Implement BaseSetProcessCreateNotify that just saves internally the notification function to be called when a process is created.
- Call the notification function where it should be.


git-svn-id: file:///srv/svn/reactos/trunk@65712 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[USERSRV]: usersrv needs static-link to basesrv because it'll use an API in the next...
hbelusca [Wed, 17 Dec 2014 22:34:13 +0000 (22:34 +0000)]
[USERSRV]: usersrv needs static-link to basesrv because it'll use an API in the next commit :p (hint: process creation notification). For Timo's patch CORE-7505

git-svn-id: file:///srv/svn/reactos/trunk@65711 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[HEADERS]
hbelusca [Wed, 17 Dec 2014 22:22:05 +0000 (22:22 +0000)]
- Play around and declare USERSRV_API_CONNECTINFO (CSR-style-name connect info structure type) as an alias to USERCONNECT (win32k-style-name) structure that is used to perform... "connections" between user32 and winsrv/win32k subsystem.

- Make UserThreadCsrApiPort case of NtUserSetInformationThread return success to make usersrv happy (while saving CSR port handle in win32k is still not implemented).

- Clean up "a bit" DllMain, call CsrClientConnectToServer to connect to usersrv (copy-paste of what we do in kernel32 for base and console connection) and now determine properly whether we are doing server-to-server calls (i.e. properly set gfServerProcess).
- Reorganize GdiDllInitialize calls and put them all to the end of DllMain instead.
- No need to support DLL_THREAD_ATTACH/DETACH so call the magic DisableThreadLibraryCalls function.

- Implement UserClientConnect with the patch of Timo CORE-7505: it gives a CSR port handle to win32k (if not already done), then do process connection.


git-svn-id: file:///srv/svn/reactos/trunk@65710 97493ccd-5924-5043-b1f5-66cb403b36ce

18 hours ago[KERNEL32]: Minor code formatting.
hbelusca [Wed, 17 Dec 2014 22:07:41 +0000 (22:07 +0000)]
[KERNEL32]: Minor code formatting.

git-svn-id: file:///srv/svn/reactos/trunk@65709 97493ccd-5924-5043-b1f5-66cb403b36ce

18 hours agoDelete unuseful file...
hbelusca [Wed, 17 Dec 2014 22:06:36 +0000 (22:06 +0000)]
Delete unuseful file...

git-svn-id: file:///srv/svn/reactos/trunk@65708 97493ccd-5924-5043-b1f5-66cb403b36ce

19 hours ago[SHELL32]
dreimer [Wed, 17 Dec 2014 21:09:30 +0000 (21:09 +0000)]
German translation update

git-svn-id: file:///srv/svn/reactos/trunk@65707 97493ccd-5924-5043-b1f5-66cb403b36ce

22 hours ago[USRMGR] Italian translation update by Nicolò Altamura. CORE-8857
akhaldi [Wed, 17 Dec 2014 17:59:02 +0000 (17:59 +0000)]
[USRMGR] Italian translation update by Nicolò Altamura. CORE-8857

git-svn-id: file:///srv/svn/reactos/trunk@65706 97493ccd-5924-5043-b1f5-66cb403b36ce

22 hours ago[MPLAY32] Update Chinese (zh-CN) translation. By Henry Tang Ih.
akhaldi [Wed, 17 Dec 2014 17:51:10 +0000 (17:51 +0000)]
[MPLAY32] Update Chinese (zh-CN) translation. By Henry Tang Ih.

git-svn-id: file:///srv/svn/reactos/trunk@65705 97493ccd-5924-5043-b1f5-66cb403b36ce

22 hours ago[SYSDM] Minor changes to the Startup and Recovery options dialog resource. Brought...
akhaldi [Wed, 17 Dec 2014 17:47:54 +0000 (17:47 +0000)]
[SYSDM] Minor changes to the Startup and Recovery options dialog resource. Brought to you by Ricardo Hanke.

git-svn-id: file:///srv/svn/reactos/trunk@65704 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[EXPLORER]
gadamopoulos [Wed, 17 Dec 2014 12:44:58 +0000 (12:44 +0000)]
* Remove internal IStartMenuSite interface that didn't serve any purpose.
* Stop using global instances of some core classes.

git-svn-id: file:///srv/svn/reactos/trunk@65703 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[RSHELL]
gadamopoulos [Wed, 17 Dec 2014 12:38:19 +0000 (12:38 +0000)]
* Disable themes for the toolbars used for shell menus
* See issue CORE-8922 for details

git-svn-id: file:///srv/svn/reactos/trunk@65702 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[RSHELL]
gadamopoulos [Wed, 17 Dec 2014 12:28:35 +0000 (12:28 +0000)]
- Remove definition for an undocumented function that already exists in our headers
- See issue CORE-8920

git-svn-id: file:///srv/svn/reactos/trunk@65701 97493ccd-5924-5043-b1f5-66cb403b36ce

28 hours ago[RSHELL]
gadamopoulos [Wed, 17 Dec 2014 12:11:31 +0000 (12:11 +0000)]
- Simplify some code by using shlwapi helpers
- See issue CORE-8919

git-svn-id: file:///srv/svn/reactos/trunk@65700 97493ccd-5924-5043-b1f5-66cb403b36ce

28 hours agoTry to fix build
gadamopoulos [Wed, 17 Dec 2014 11:46:19 +0000 (11:46 +0000)]
Try to fix build

git-svn-id: file:///srv/svn/reactos/trunk@65699 97493ccd-5924-5043-b1f5-66cb403b36ce

28 hours ago[BROWSEUI]
gadamopoulos [Wed, 17 Dec 2014 11:35:07 +0000 (11:35 +0000)]
* Simplify a lot of methods my using helpers from shlwapi.
* Remove declarations for undocumented functions that are already declared in our headers.
* Move definitions of IID_IAugmentedShellFolder and CLSID_MergedFolder to our headers.
* Remove definitions of functions that are already implemented in shlwapi.
* Add CreateMergedFolder and CreateMenuBand functions in precomp.h in order to simplify creating these objects when using rshell.

git-svn-id: file:///srv/svn/reactos/trunk@65698 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[SEHLL32]
dquintana [Wed, 17 Dec 2014 00:46:30 +0000 (00:46 +0000)]
* Implement handling of file associations marked as "NoOpen". Patch by Lee Schroeder, with a few tweaks.
CORE-8855 #resolve #comment Commited in trunk r65697. Thanks.

git-svn-id: file:///srv/svn/reactos/trunk@65697 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[WIN32K]
hbelusca [Wed, 17 Dec 2014 00:33:40 +0000 (00:33 +0000)]
- Simplify NtUserInitialize: we can check whether gpepCSRSS is != NULL to see if we are initialized or not (instead of using gbInitialized).
- The UserInitialize helper doesn't need to take parameters. The two event handles (power and media, used when we receive a power event -- for sleep, etc... -- and a media event -- like USB key insertion and such --) just need to be used in the not-yet-implemented "Initialize Power Request List" and "Initialize Media Change" steps.
- Something that should be done is to bugcheck if the USER version reported is != 5.0 (as windows does).

- Collapse common inclusions from usersrv and consrv into the common header winsrv.h.

- _UserSoundSentry is NTAPI
- Stub UserClientConnect (Timo's patch contains more involved code. I will commit it later).
- Our NtUserInitialize(0, NULL, NULL); call (that made Windows BSOD) is wrong. It should be done with its first parameter correctly set to the USER version (5.0) and the two other parameters are handles to power and media events (see above). We should create them before.
This is part of patch by Timo Kreuzer.
CORE-7505 #comment UserClientConnect stubbed (it should be better implemented, I will commit the code from the patch later on); power&media events initialized; NtUserInitialize corrected.

git-svn-id: file:///srv/svn/reactos/trunk@65696 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[SHELL32]
dquintana [Wed, 17 Dec 2014 00:32:34 +0000 (00:32 +0000)]
* Revert r65589, since it breaks tray icons.

git-svn-id: file:///srv/svn/reactos/trunk@65695 97493ccd-5924-5043-b1f5-66cb403b36ce

40 hours ago[WIN32K]: Some code formatting in csr.c before revampering it.
hbelusca [Wed, 17 Dec 2014 00:17:44 +0000 (00:17 +0000)]
[WIN32K]: Some code formatting in csr.c before revampering it.

git-svn-id: file:///srv/svn/reactos/trunk@65694 97493ccd-5924-5043-b1f5-66cb403b36ce

41 hours ago[WIN32K]
hbelusca [Tue, 16 Dec 2014 23:09:29 +0000 (23:09 +0000)]
Stubplement NtUserQueryInformationThread and NtUserSetInformationThread that will be used for:
- shutdown support: CORE-8322
- communicating a CSR Port handle to win32k: CORE-7505
CORE-7505 CORE-8322

git-svn-id: file:///srv/svn/reactos/trunk@65693 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago... And as a result of the previous commit, finally get rid of the "deprecated" direc...
hbelusca [Tue, 16 Dec 2014 21:59:50 +0000 (21:59 +0000)]
... And as a result of the previous commit, finally get rid of the "deprecated" directory!

git-svn-id: file:///srv/svn/reactos/trunk@65692 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[WIN32SS]: Push back csr code into win32k (not compiled yet). The thing is that win32...
hbelusca [Tue, 16 Dec 2014 21:58:18 +0000 (21:58 +0000)]
[WIN32SS]: Push back csr code into win32k (not compiled yet). The thing is that win32k uses a LPC port to communicate with winsrv.dll . But it's winsrv.dll that gives a handle of the CSR port to win32k via a call to NtUserSetInformationThread with the UserThreadCsrApiPort information class. See part of Timo's patch in CORE-7505 that will be submitted later on. Also I need to somewhat stub the UserThreadCsrApiPort info class in NtUserSetInformationThread :)

git-svn-id: file:///srv/svn/reactos/trunk@65691 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[KERNEL32][BASESRV]
hbelusca [Tue, 16 Dec 2014 21:48:23 +0000 (21:48 +0000)]
On Windows 2k3, BASESRV_API_CONNECTINFO went under a slimming treatment and now is only 4 bytes. In fact all its information was already existing in the static base data structure (BaseStaticServerData). We should now be more 2k3-compatible :)
Fix also the testbots.

git-svn-id: file:///srv/svn/reactos/trunk@65690 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[SPEC2DEF]
tkreuzer [Tue, 16 Dec 2014 21:21:14 +0000 (21:21 +0000)]
Improve error output

git-svn-id: file:///srv/svn/reactos/trunk@65689 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours ago[NTOSKRNL]
tkreuzer [Tue, 16 Dec 2014 21:15:57 +0000 (21:15 +0000)]
Hey Arch, using uninitialized variables is bad, mkay?

git-svn-id: file:///srv/svn/reactos/trunk@65688 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours ago[EVENTVWR]
tkreuzer [Tue, 16 Dec 2014 21:03:24 +0000 (21:03 +0000)]
Fix MSVC build and x64 warnings

git-svn-id: file:///srv/svn/reactos/trunk@65687 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours ago[BASESRV]: Use BaseSrvCleanupVDMResources taking a CSR_PROCESS structure instead...
hbelusca [Tue, 16 Dec 2014 20:28:44 +0000 (20:28 +0000)]
[BASESRV]: Use BaseSrvCleanupVDMResources taking a CSR_PROCESS structure instead of just its PID to be able to possibly use more things to do VDM cleanup (in the future).

git-svn-id: file:///srv/svn/reactos/trunk@65686 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours ago[BASESRV]: basesrv exports few APIs used in winsrv, so declare basesrv as IMPORTLIB.
hbelusca [Tue, 16 Dec 2014 20:26:02 +0000 (20:26 +0000)]
[BASESRV]: basesrv exports few APIs used in winsrv, so declare basesrv as IMPORTLIB.

git-svn-id: file:///srv/svn/reactos/trunk@65685 97493ccd-5924-5043-b1f5-66cb403b36ce

44 hours ago[BASESRV]
hbelusca [Tue, 16 Dec 2014 20:15:35 +0000 (20:15 +0000)]
- Introduce BaseClientConnectRoutine and BaseClientDisconnectRoutine functions that do basesrv (de)initialization, and BaseSrvNlsConnect that may potentially init further NLS support in the future.
- BaseSrvDebugProcess is deprecated in Windows 2k3+.
- Few whitespace fixes.
Piece of patch by Timo Kreuzer.
CORE-7505 #comment Basesrv (dis)connect routines committed in r65684.

git-svn-id: file:///srv/svn/reactos/trunk@65684 97493ccd-5924-5043-b1f5-66cb403b36ce

45 hours ago[SHELL32]
dquintana [Tue, 16 Dec 2014 18:21:48 +0000 (18:21 +0000)]
* Use PrivateExtractIconsW instead of PrivateExtractIconExW to obtain the icons for caching. Fixes small shell icons using large icons scaled down instead of the proper 16px icons. Patch by Ismael Ferreras Morezuelas (swyter).
CORE-8404 #resolve #comment Commited in r65683. Thanks.

git-svn-id: file:///srv/svn/reactos/trunk@65683 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[CSR]
hbelusca [Mon, 15 Dec 2014 23:35:32 +0000 (23:35 +0000)]
- Cleanup a bit csrmsg.h (by me), the ObjectDirectory member of the CSR_API_CONNECTINFO structure becomes unused starting Windows 2k3 (add an informative comment about that fact).
- Remove now unneeded ObjectDirectory duplication code (by Timo).
- Fix some whitespace.
CORE-7505 #comment ObjectDirectory duplication code removed in r65682.

git-svn-id: file:///srv/svn/reactos/trunk@65682 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[BASESRV]
hbelusca [Mon, 15 Dec 2014 22:48:38 +0000 (22:48 +0000)]
- Whitespace fixes.
- Stub AppCompat module.
Patch by Timo Kreuzer.
CORE-7505 #comment AppCompat committed in r65681.

git-svn-id: file:///srv/svn/reactos/trunk@65681 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[NTFS]
pschweitzer [Mon, 15 Dec 2014 21:44:52 +0000 (21:44 +0000)]
Return the MFT index in FileFullDirectoryInformation and NtfsGetBothDirectoryInformation queries

git-svn-id: file:///srv/svn/reactos/trunk@65680 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[NTFS]
pschweitzer [Mon, 15 Dec 2014 21:28:06 +0000 (21:28 +0000)]
- Store the link count in FCB and return it in FileStandardInformation query
- Return the MFT index in NtfsGetInternalInformation query

git-svn-id: file:///srv/svn/reactos/trunk@65679 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[MSGINA]: Update the function names of stubs, with (in comments) the number of parame...
hbelusca [Mon, 15 Dec 2014 21:07:23 +0000 (21:07 +0000)]
[MSGINA]: Update the function names of stubs, with (in comments) the number of parameters they take.
See CORE-8459 for more information.
CORE-8459 #resolve #comment Fixed in r65678.

git-svn-id: file:///srv/svn/reactos/trunk@65678 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[TASKMGR]: Disable the "End task" button if no item is selected.
hbelusca [Mon, 15 Dec 2014 20:45:38 +0000 (20:45 +0000)]
[TASKMGR]: Disable the "End task" button if no item is selected.
Part 2 of a patch by Edijs.
CORE-5655 #comment Patch committed. When one of you will have a patch for the Windows-menu items disabled bug, please reopen the report. #resolve

git-svn-id: file:///srv/svn/reactos/trunk@65677 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[TASKMGR]: Disable the "End process" button if no item is selected.
hbelusca [Mon, 15 Dec 2014 20:33:26 +0000 (20:33 +0000)]
[TASKMGR]: Disable the "End process" button if no item is selected.
Part 1 of a patch by Edijs.
CORE-5655 #comment procpage.c fix committed.

git-svn-id: file:///srv/svn/reactos/trunk@65676 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[TREE]
hbelusca [Mon, 15 Dec 2014 20:17:17 +0000 (20:17 +0000)]
- Use #pragma once in resource.h
- put windows.h after CRT includes.
- Convert the main .rc back to ANSI otherwise rc.exe complains, see for more details.

git-svn-id: file:///srv/svn/reactos/trunk@65675 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago- Fix build.
jimtabor [Mon, 15 Dec 2014 01:41:57 +0000 (01:41 +0000)]
- Fix build.

git-svn-id: file:///srv/svn/reactos/trunk@65674 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago- Fix build.
jimtabor [Mon, 15 Dec 2014 01:40:58 +0000 (01:40 +0000)]
- Fix build.

git-svn-id: file:///srv/svn/reactos/trunk@65673 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NtUser]
jimtabor [Mon, 15 Dec 2014 01:38:27 +0000 (01:38 +0000)]
- Finaly fix CORE-6129 leaving CORE-6651 to fix.

git-svn-id: file:///srv/svn/reactos/trunk@65672 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[RAPPS]
dreimer [Mon, 15 Dec 2014 01:01:58 +0000 (01:01 +0000)]
Extend Turkish translation for rapps database by Erdem Ersoy
CORE-8874 #resolve #comment Committed, thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65671 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[SYSDM]
dreimer [Mon, 15 Dec 2014 01:00:07 +0000 (01:00 +0000)]
Fix some misaligned button and text fields.
CORE-7338 #resolve #comment Should be fixed.

git-svn-id: file:///srv/svn/reactos/trunk@65670 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[RAPPS]
dreimer [Mon, 15 Dec 2014 00:23:41 +0000 (00:23 +0000)]
rosapps maintenance of Romanian parts by Ștefan Fulea
CORE-8520 #resolve #comment Committed, thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65669 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[TRANSLATION]
dreimer [Mon, 15 Dec 2014 00:12:56 +0000 (00:12 +0000)]
Turkish Translation Update by Erdem Ersoy
CORE-7861 #resolve #comment Committed, thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65668 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[USER32]
dreimer [Sun, 14 Dec 2014 23:58:12 +0000 (23:58 +0000)]
TRANSLATION: Ukrainian translation update for User32 by Yaroslav Fedoryako
CORE-8596 #resolve #comment Committed. Thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65667 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[INPUT]
dreimer [Sun, 14 Dec 2014 23:57:11 +0000 (23:57 +0000)]
TRANSLATION: Ukrainian translation update for input.dll by Yaroslav Fedoryako
CORE-8616 #resolve #comment Committed. Thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65666 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[USRMGR]
dreimer [Sun, 14 Dec 2014 23:52:49 +0000 (23:52 +0000)]
Italian translation of user accounts (control panel) by nicoalta01 (Marco Maria Emanuele Bartucci as I hope his name is)
While I was at it... convert the rest to UTF8
CORE-8857 #resolve #comment Committed, thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65665 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[URLMON]
dreimer [Sun, 14 Dec 2014 23:38:05 +0000 (23:38 +0000)]
TRANSLATION: Czech translation update
CORE-8499 #comment INF is UCS2 LE now and the Lang ID is corrected. Can you confirm that this is fixed now?

git-svn-id: file:///srv/svn/reactos/trunk@65663 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days agoPartial merge of condrv_restructure branch r65657.
hbelusca [Sun, 14 Dec 2014 22:57:49 +0000 (22:57 +0000)]
Partial merge of condrv_restructure branch r65657.

git-svn-id: file:///srv/svn/reactos/trunk@65660 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[SHELL32]
dreimer [Sun, 14 Dec 2014 22:56:10 +0000 (22:56 +0000)]
Update German translation by Robert Naumann
CORE-8912 #resolve #comment Committed Thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65659 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[BROWSEUI]
dreimer [Sun, 14 Dec 2014 22:55:08 +0000 (22:55 +0000)]
Update German translation by Robert Naumann
CORE-8913 #resolve #comment Committed Thx for help.

git-svn-id: file:///srv/svn/reactos/trunk@65658 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[DESK.CPL]
zguo [Sun, 14 Dec 2014 22:38:45 +0000 (22:38 +0000)]
Check for the correct registry value for the wallpaper. Patch by Ricardo Hanke.

git-svn-id: file:///srv/svn/reactos/trunk@65656 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[MSPAINT]: Remove trailing whitespace.
hbelusca [Sun, 14 Dec 2014 21:56:21 +0000 (21:56 +0000)]
[MSPAINT]: Remove trailing whitespace.

git-svn-id: file:///srv/svn/reactos/trunk@65654 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 14 Dec 2014 21:18:47 +0000 (21:18 +0000)]
- Implement NtfsGrabFCBFromTableById() and NtfsGetFCBForFileById(). These two are responsible for opening and retrieving a file open by ID.
- Modified NtfsMakeFCBFromDirEntry() so that it supports openings by ID which come with less information than normal openings.
- Modified NtfsGrabFCBFromTable() so that it doesn't return a FCB which would have been opened by ID.
- Modified NtfsOpenFile() so that it allows opening a file by ID using the two FCB helpers functions defined upper.
- Modified NtfsCreateFile() so that it can validate input in case of opening by ID.

To make it short, all this implements file opening by ID in NTFS driver. I made the choice to separate FCB which are coming from "normal" opening and these from ID opening.
The reason is that a file opening with ID has less information than a normal opening, and may fail on these information retreival. This is due to the fact that if opening by ID can virtual open all the files, because it ignores authorizations, traverses checks, in the end for retrieving the information, such checks can be done and fail.

I also left all this disabled so far, because it appears to regress NFI. I will investigate this.


git-svn-id: file:///srv/svn/reactos/trunk@65652 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 14 Dec 2014 21:09:29 +0000 (21:09 +0000)]
Make the NTFS driver more verbose in file information requests

git-svn-id: file:///srv/svn/reactos/trunk@65650 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[TREE]
dreimer [Sun, 14 Dec 2014 18:58:51 +0000 (18:58 +0000)]
German translation for tree utility.

git-svn-id: file:///srv/svn/reactos/trunk@65648 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[SETUP]
zguo [Sun, 14 Dec 2014 18:39:24 +0000 (18:39 +0000)]
Add registry value for wallpaper directory. Patch by Ricardo Hanke.

git-svn-id: file:///srv/svn/reactos/trunk@65647 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[TREE]
zguo [Sun, 14 Dec 2014 18:30:14 +0000 (18:30 +0000)]
Cleanup of Tree utility by Lee Schroeder.

git-svn-id: file:///srv/svn/reactos/trunk@65646 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 14 Dec 2014 18:13:57 +0000 (18:13 +0000)]
Implement GetVolumeBitmap().

This allows NFI to find which file is at which LCN:

So far, NFI is not as verbose as it is on Windows in such cases, because FILE_OPEN_BY_FILE_ID is *still* unimplemented (you should consider implementing it Pierre ;-)).
I checked with Windows, the correct file is found though!


git-svn-id: file:///srv/svn/reactos/trunk@65645 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[SACDRV]: Code formatting.
hbelusca [Sun, 14 Dec 2014 16:54:14 +0000 (16:54 +0000)]
[SACDRV]: Code formatting.

git-svn-id: file:///srv/svn/reactos/trunk@65641 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTFS]
pschweitzer [Sun, 14 Dec 2014 14:38:44 +0000 (14:38 +0000)]
- In the VCB, directly store the total number of clusters available in the volume, this will save a few recurrent divisions
- Use this everywhere it is possible
- Validate input in GetVolumeBitmap(): make sure we don't want bitmap beyond end of the volume


git-svn-id: file:///srv/svn/reactos/trunk@65639 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTFS]
pschweitzer [Sun, 14 Dec 2014 12:24:18 +0000 (12:24 +0000)]
- Implement NtfsGetUserBuffer() that will (attempt to) return the user output buffer for METHOD_NEITHER IOCTL.
- Implement parameters checking GetVolumeBitmap()


git-svn-id: file:///srv/svn/reactos/trunk@65638 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[COMP]: Minor code style changes + whitespace fixes.
hbelusca [Sun, 14 Dec 2014 12:04:45 +0000 (12:04 +0000)]
[COMP]: Minor code style changes + whitespace fixes.

git-svn-id: file:///srv/svn/reactos/trunk@65637 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTFS]
pschweitzer [Sun, 14 Dec 2014 10:54:20 +0000 (10:54 +0000)]
Stub FSCTL_GET_VOLUME_BITMAP which is required by NFI.


git-svn-id: file:///srv/svn/reactos/trunk@65636 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CDFS]
cgutman [Sun, 14 Dec 2014 09:27:11 +0000 (09:27 +0000)]
- Fix CD-ROM disc change handling
- Fixes CORE-6119

git-svn-id: file:///srv/svn/reactos/trunk@65635 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CALC]
pschweitzer [Sun, 14 Dec 2014 09:18:47 +0000 (09:18 +0000)]
Apply r65633 to all the language files.


git-svn-id: file:///srv/svn/reactos/trunk@65634 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CALC]
zguo [Sun, 14 Dec 2014 05:48:05 +0000 (05:48 +0000)]
Switch calc to using the registry for storing configuration values. Remove 9x codepath. Patch by Lee Schroeder. Cleaning up Ziliang Guo.

git-svn-id: file:///srv/svn/reactos/trunk@65633 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[TREE]
zguo [Sun, 14 Dec 2014 00:09:51 +0000 (00:09 +0000)]
Fix build.

git-svn-id: file:///srv/svn/reactos/trunk@65632 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[TREE]
zguo [Sun, 14 Dec 2014 00:00:54 +0000 (00:00 +0000)]
Implement directory tree commandline utility. Code by Asif Bahrainwala. Cleanup by Ziliang Guo.

git-svn-id: file:///srv/svn/reactos/trunk@65631 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[EVENTVWR]
ekohl [Sat, 13 Dec 2014 22:35:48 +0000 (22:35 +0000)]
Clean up the resource IDs.
Fix small icon loading.

git-svn-id: file:///srv/svn/reactos/trunk@65630 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[COMP]
zguo [Sat, 13 Dec 2014 21:17:59 +0000 (21:17 +0000)]
Incorporate fixes provided by a patch from over three years ago that adds support for the additional compare options. Patch provided by kruntuid. Slight cleanup and reshuffling of some code to make it cleaner.

git-svn-id: file:///srv/svn/reactos/trunk@65629 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[EVENTVWR]
ekohl [Sat, 13 Dec 2014 20:53:06 +0000 (20:53 +0000)]
Update the Event Detail Dialog to better match XP/2K3
Patch by Lee Schroeder.
I updated the remaining dialogs.
Translators: Please check the dialogs!

CORE_8904 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@65628 97493ccd-5924-5043-b1f5-66cb403b36ce