reactos.git
10 min ago[BOOTDATA] master trunk
akhaldi [Thu, 30 Oct 2014 13:29:44 +0000 (13:29 +0000)]
[BOOTDATA]
* Romanian translation update by È˜tefan Fulea.
CORE-8630 #resolve #comment Committed in r65123. Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@65123 97493ccd-5924-5043-b1f5-66cb403b36ce

84 min ago[INTL]
khornicek [Thu, 30 Oct 2014 12:15:11 +0000 (12:15 +0000)]
[INTL]
- don't display garbage in the location combo box

git-svn-id: file:///srv/svn/reactos/trunk@65122 97493ccd-5924-5043-b1f5-66cb403b36ce

5 hours ago[NTOSKRNL]
pschweitzer [Thu, 30 Oct 2014 08:39:03 +0000 (08:39 +0000)]
[NTOSKRNL]
Actually enable again the hack...
For whatever reason, it works with my WC but not with clean trunk...
Where are the you, magic and silent patch that fixes it? :-(

git-svn-id: file:///srv/svn/reactos/trunk@65120 97493ccd-5924-5043-b1f5-66cb403b36ce

5 hours ago[NTOSKRNL]
pschweitzer [Thu, 30 Oct 2014 07:49:37 +0000 (07:49 +0000)]
[NTOSKRNL]
Finally, disable again the IopParseDevice hack.
Just for the record, opening a volume with FILE_READ_EA or FILE_READ_DATA is legal and works in Windows (NTFS Info for instance opens it with GENERIC_READ).

Let's hope we can rid of this hack forever now... It's been with us since 2006!

git-svn-id: file:///srv/svn/reactos/trunk@65119 97493ccd-5924-5043-b1f5-66cb403b36ce

5 hours ago[FASTFAT]
pschweitzer [Thu, 30 Oct 2014 07:46:25 +0000 (07:46 +0000)]
[FASTFAT]
Don't over-reference our FCB in case of volume opening (vfatAttachFCBToFileObject() already references it).

This fixes 1st stage and beyond with IopParseDevice hack off

git-svn-id: file:///srv/svn/reactos/trunk@65118 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[NTOSKRNL]
pschweitzer [Wed, 29 Oct 2014 23:28:15 +0000 (23:28 +0000)]
[NTOSKRNL]
Reenable IopParseDevice hack for now.
Out of fixes for tonight.

git-svn-id: file:///srv/svn/reactos/trunk@65117 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[FASTFAT]
pschweitzer [Wed, 29 Oct 2014 23:10:31 +0000 (23:10 +0000)]
[FASTFAT]
Now that we start to honor the storage stack (ie, without the IopParseDevice hack ;-)), we have to let FSDs forward device IOCTLs.
This allows back copying files on 1st stage

git-svn-id: file:///srv/svn/reactos/trunk@65116 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[FASTFAT]
pschweitzer [Wed, 29 Oct 2014 22:51:16 +0000 (22:51 +0000)]
[FASTFAT]
Don't attempt to mount any partition just because we have a valid partition table...
Restrict this to them being marked as FAT or compatible.

git-svn-id: file:///srv/svn/reactos/trunk@65115 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[NTFS]
pschweitzer [Wed, 29 Oct 2014 22:40:16 +0000 (22:40 +0000)]
[NTFS]
Addendum to r65112

git-svn-id: file:///srv/svn/reactos/trunk@65113 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[NTFS]
pschweitzer [Wed, 29 Oct 2014 22:36:55 +0000 (22:36 +0000)]
[NTFS]
Implement support for the FSCTL_GET_NTFS_VOLUME_DATA user request in NtfsUserFsRequest().

This makes NTFSInfo capable of working in ReactOS :-). A picture to show it: http://www.heisspiter.net/~Pierre/rostests/NTFS_info.png
Yes, NTFS Zone isn't computed yet. I'll have a look at it later on.

This doesn't fix nfi.exe though. If it can get its data, it cannot continue. It loops forever on a FSCTL we don't handle yet.

CORE-8725

git-svn-id: file:///srv/svn/reactos/trunk@65112 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[NTOSKRNL]
spetreolle [Wed, 29 Oct 2014 22:22:24 +0000 (22:22 +0000)]
[NTOSKRNL]
Reapply r65107.
We need fixes, not hacks.
Sorry for being popular^W pressure ;)

git-svn-id: file:///srv/svn/reactos/trunk@65110 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[NETAPI32]
ekohl [Wed, 29 Oct 2014 22:17:23 +0000 (22:17 +0000)]
[NETAPI32]
NetUserModalsGet:
- Return the proper maximum password age.
- Remove dead code.

git-svn-id: file:///srv/svn/reactos/trunk@65109 97493ccd-5924-5043-b1f5-66cb403b36ce

16 hours ago[UNIATA]
spetreolle [Wed, 29 Oct 2014 21:34:01 +0000 (21:34 +0000)]
[UNIATA]
Update to 0.45c1.

git-svn-id: file:///srv/svn/reactos/trunk@65108 97493ccd-5924-5043-b1f5-66cb403b36ce

16 hours ago[NTOSKRNL]
pschweitzer [Wed, 29 Oct 2014 21:22:36 +0000 (21:22 +0000)]
[NTOSKRNL]
Reenable hack due to popular pressure.
Still better than fixing it, it seems...
So, break again volume opening.

git-svn-id: file:///srv/svn/reactos/trunk@65107 97493ccd-5924-5043-b1f5-66cb403b36ce

18 hours ago[NTFS]
pschweitzer [Wed, 29 Oct 2014 18:42:05 +0000 (18:42 +0000)]
[NTFS]
Finally, move old stuff back from disk.sys to ntfs.sys now it can be properly reached on volume opening:
- Halfplement NtfsUserFsRequest() and add support for IRP_MN_USER_FS_REQUEST in NtfsFsdFileSystemControl()
- Also, use the proper FSCTL code: FSCTL_GET_NTFS_VOLUME_DATA which exists and is documented instead of FSCTL_GET_NTFS_VOLUME_DATA. Spotted by Christoph.

CORE-8725

git-svn-id: file:///srv/svn/reactos/trunk@65106 97493ccd-5924-5043-b1f5-66cb403b36ce

19 hours ago[DISK]
pschweitzer [Wed, 29 Oct 2014 18:25:30 +0000 (18:25 +0000)]
[DISK]
Revert r65097 and r65090.
Thanks to r65104, now the FSCTLs go to the right place: the FSDs!

Thanks to Thomas for pointing out that NTFSinfo was really talking with the FSD on Windows and not to disk.sys

CORE-8725

git-svn-id: file:///srv/svn/reactos/trunk@65105 97493ccd-5924-5043-b1f5-66cb403b36ce

19 hours ago[NTOSKRNL]
pschweitzer [Wed, 29 Oct 2014 18:20:43 +0000 (18:20 +0000)]
[NTOSKRNL]
Disable the IopParseDevice hack. It appears it was triggered on volume opening and thus was breaking volume opening which were then forwarded down to disk.sys.
Not sure how legit it is to have it anylonger.

At least, disabling it reenables volume opening in ReactOS and associated FSCTL!

Alex & Aleksey, can you review please?

CORE-8725

git-svn-id: file:///srv/svn/reactos/trunk@65104 97493ccd-5924-5043-b1f5-66cb403b36ce

19 hours ago[NLS]
khornicek [Wed, 29 Oct 2014 18:20:03 +0000 (18:20 +0000)]
[NLS]
- fix the code page value
- also fixes intl.cpl showing date format string in the code page list

git-svn-id: file:///srv/svn/reactos/trunk@65103 97493ccd-5924-5043-b1f5-66cb403b36ce

20 hours ago[KERNEL32]
khornicek [Wed, 29 Oct 2014 16:59:44 +0000 (16:59 +0000)]
[KERNEL32]
- remove bunch of stray pragmas
- add a czech translation to stop debug spam reported in CORE-8720

git-svn-id: file:///srv/svn/reactos/trunk@65102 97493ccd-5924-5043-b1f5-66cb403b36ce

23 hours ago[BOOTDATA]
khornicek [Wed, 29 Oct 2014 14:27:09 +0000 (14:27 +0000)]
[BOOTDATA]
- add metrics to classic themes (the flag 0xb0001 will result in a kinda esoteric value of type REG_QWORD)
- fixes switching from Lautus back to a classic theme
CORE-8718

git-svn-id: file:///srv/svn/reactos/trunk@65100 97493ccd-5924-5043-b1f5-66cb403b36ce

26 hours ago[DISK]
pschweitzer [Wed, 29 Oct 2014 11:31:19 +0000 (11:31 +0000)]
[DISK]
Actually, sysinternals used to release the source code of NTFSInfo (thanks Christoph!), so we know a bit more about the interface of the user FS request.
So, implement a bit more of the interface to validate it properly works (and so far, it does!)

CORE-8725

git-svn-id: file:///srv/svn/reactos/trunk@65097 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[GDI32]
tkreuzer [Tue, 28 Oct 2014 22:16:24 +0000 (22:16 +0000)]
[GDI32]
Improve functions in coord.c:
- Use GdiGetDcAttr() where appropriate
- Fix SetLastError() usage
- Add annotations
- improve variable naming
- Add some comments

git-svn-id: file:///srv/svn/reactos/trunk@65093 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[DISK]
pschweitzer [Tue, 28 Oct 2014 21:59:57 +0000 (21:59 +0000)]
[DISK]
Get ready to enter into the 10th dimension... So:
- Implement support for IRP_MJ_FILE_SYSTEM_CONTROL. Yes... You read well! So, implemented a ScsiDiskFileSystemControl() function. The way it is added to the DriverObject is a big hack, class2 is not supposed to have such requests, so, we do it in its back. Fear!
- Stubplement the NtfsRussinovichism() function. This is the only function we're supposed to call with IRP MJ FSCTRL and with IRP MN USRFSRQST. Its purpose (when its implemented) is to reply back to the M. Russinovich tools (NFI & NTFSInfo) so that they can directly dump NTFS information without going into NTFS driver. They kind of bypass it.
We do all agree this is a ugly hack. But it exists in Windows, as these tools work in Windows. And it would be useful they actually work in ReactOS.
Soon, we'll be able to publish a book "ReactOS Internals" where we speak about undocumented FS controls to dump NTFS information to show how well our NTFS works ;-).

git-svn-id: file:///srv/svn/reactos/trunk@65090 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[NET]
ekohl [Tue, 28 Oct 2014 21:57:41 +0000 (21:57 +0000)]
[NET]
Display more password information in the NET USER command.

git-svn-id: file:///srv/svn/reactos/trunk@65089 97493ccd-5924-5043-b1f5-66cb403b36ce

40 hours ago[WIN32K]
khornicek [Tue, 28 Oct 2014 21:38:26 +0000 (21:38 +0000)]
[WIN32K]
- addendum to revision 64877 which slightly changed UserDrawCaption's logic
- fixes window title being drawn over the icon

git-svn-id: file:///srv/svn/reactos/trunk@65087 97493ccd-5924-5043-b1f5-66cb403b36ce

40 hours ago[GDI32]
tkreuzer [Tue, 28 Oct 2014 21:09:01 +0000 (21:09 +0000)]
[GDI32]
- Move functions to the appropriate source files, zap hacks.c, stubs.c, stubsa.c and stubsw.c (sorry for the noise, but this mess had to be cleaned up)

git-svn-id: file:///srv/svn/reactos/trunk@65086 97493ccd-5924-5043-b1f5-66cb403b36ce

41 hours ago[FASTFAT]
pschweitzer [Tue, 28 Oct 2014 20:39:42 +0000 (20:39 +0000)]
[FASTFAT]
For now, disable the VfatSetRenameInformation() asserts in trunk.
They can be reenabled for testing by commenting "#define NASSERTS_RENAME" out.

CORE-8721 #resolve #comment Fixed with r65085

git-svn-id: file:///srv/svn/reactos/trunk@65085 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[NTFS]
pschweitzer [Tue, 28 Oct 2014 19:17:59 +0000 (19:17 +0000)]
[NTFS]
Finally, implement NtfsGetFreeClusters() which will just read the $Data stream from $BITMAP file record to get the amount of free clusters to allow estimating the free space on a volume.
The implementation is likely under-optimized... But wwell, the rest of the FSD is not better. Who talked about caching?! ;-)

Because pictures are more relevant than words in such case: http://www.heisspiter.net/~Pierre/rostests/NTFS_disksize.png

git-svn-id: file:///srv/svn/reactos/trunk@65082 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours agoAddendum to r65077 (svn merge info).
gadamopoulos [Tue, 28 Oct 2014 17:40:49 +0000 (17:40 +0000)]
Addendum to r65077 (svn merge info).

git-svn-id: file:///srv/svn/reactos/trunk@65079 97493ccd-5924-5043-b1f5-66cb403b36ce

44 hours agoMerge r65001 from shell-experiments branch:
gadamopoulos [Tue, 28 Oct 2014 17:32:01 +0000 (17:32 +0000)]
Merge r65001 from shell-experiments branch:
[user32]
- Properly notify the theme engine that the caption needs to be repainted on WM_SETICON
- Fixes a classic frame appearing when themes are enabled and we navigate to a different folder

git-svn-id: file:///srv/svn/reactos/trunk@65077 97493ccd-5924-5043-b1f5-66cb403b36ce

44 hours ago[WINLOGON]
gedmurphy [Tue, 28 Oct 2014 17:07:47 +0000 (17:07 +0000)]
[WINLOGON]
- Stop the log from being spammed when the session is idle and no screensaver is set
- Also checking if my login still works :)

git-svn-id: file:///srv/svn/reactos/trunk@65076 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[NTFS]
pschweitzer [Tue, 28 Oct 2014 10:26:47 +0000 (10:26 +0000)]
[NTFS]
ReleaseAttributeContext() is to be used out of mft.c
I believe that at some point, we're leaking memory...

git-svn-id: file:///srv/svn/reactos/trunk@65068 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32]
tkreuzer [Tue, 28 Oct 2014 09:06:33 +0000 (09:06 +0000)]
[GDI32]
Implement separate functions for all SelectObject cases.

git-svn-id: file:///srv/svn/reactos/trunk@65067 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DRIVERS]
cwittich [Tue, 28 Oct 2014 08:15:49 +0000 (08:15 +0000)]
[DRIVERS]
don't use uninitialized variables

git-svn-id: file:///srv/svn/reactos/trunk@65066 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32]
tkreuzer [Tue, 28 Oct 2014 00:55:22 +0000 (00:55 +0000)]
[GDI32]
- Use GdiGetDcAttr instead of GdiGetHandleUserData where appropriate
- Add a few missing SetLastError()
- Fix return failure return value of GetBkColor()
- Improve order of operations in SelectObject (needs more fixing)

git-svn-id: file:///srv/svn/reactos/trunk@65063 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[FAST486]
aandrejevic [Tue, 28 Oct 2014 00:53:02 +0000 (00:53 +0000)]
[FAST486]
Fix a typo in r65061.

git-svn-id: file:///srv/svn/reactos/trunk@65062 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[FAST486][NTVDM]
aandrejevic [Tue, 28 Oct 2014 00:33:03 +0000 (00:33 +0000)]
[FAST486][NTVDM]
Get rid of Fast486Interrupt, since it's not used anywhere. Also we can now remove
workarounds for all of the bugs that it caused.
Implement the "single-instruction interrupt delay" for instructions that load the
stack segment only.

git-svn-id: file:///srv/svn/reactos/trunk@65061 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[NtUser]
jimtabor [Tue, 28 Oct 2014 00:26:22 +0000 (00:26 +0000)]
[NtUser]
- Revert 64363. See CORE-7797.

git-svn-id: file:///srv/svn/reactos/trunk@65060 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[FAST486]: We should invalidate the prefetch buffer *after* having fetched the BOP...
hbelusca [Tue, 28 Oct 2014 00:19:48 +0000 (00:19 +0000)]
[FAST486]: We should invalidate the prefetch buffer *after* having fetched the BOP byte (but before calling its handler), not before fetching the byte :)

git-svn-id: file:///srv/svn/reactos/trunk@65059 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32]
tkreuzer [Tue, 28 Oct 2014 00:16:18 +0000 (00:16 +0000)]
[GDI32]
- Handle GDILoObjType_LO_ALTDC_TYPE in GdiGetDcAttr
- Rewrite GdiGetLDC using GdiGetDcAttr
- Implement GdiSetLDC

git-svn-id: file:///srv/svn/reactos/trunk@65058 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32]
tkreuzer [Mon, 27 Oct 2014 23:39:21 +0000 (23:39 +0000)]
[GDI32]
Forgot to commit this...

git-svn-id: file:///srv/svn/reactos/trunk@65056 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32]
tkreuzer [Mon, 27 Oct 2014 23:37:05 +0000 (23:37 +0000)]
[GDI32]
- Improve formatting
- Use more consistent variable names
- Remove unnecessary casts
- Add some annotations
- No intended code changes

git-svn-id: file:///srv/svn/reactos/trunk@65055 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[KERNEL32]
jgardou [Mon, 27 Oct 2014 22:05:51 +0000 (22:05 +0000)]
[KERNEL32]
 - Do not try to open memory events under the process object root directory.
CORE-8600 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@65054 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[GDI32]
tkreuzer [Mon, 27 Oct 2014 20:53:59 +0000 (20:53 +0000)]
[GDI32]
Add Support routines for client objects. Will be used later. You might wonder why the code uses a lame hash table to link the client object handles to the user mode pointer, when it should be clear that a *client* object should have a user mode attribute, like other objects, that we can use, especially since that is the only real purpose of that object. Well, tell that the MS developer, who implemented client objects without a user mode attribute...

git-svn-id: file:///srv/svn/reactos/trunk@65053 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WIN32K]
tkreuzer [Mon, 27 Oct 2014 20:40:11 +0000 (20:40 +0000)]
[WIN32K]
- Fail in NtGdiCreateClientObj, when the object type is not valid.
This is based on Windows behavior, only more strict. Windows allows to set the stock bit and reuse count, which is probably not what we want.

git-svn-id: file:///srv/svn/reactos/trunk@65052 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[ADVAPI32]
akhaldi [Mon, 27 Oct 2014 17:23:05 +0000 (17:23 +0000)]
[ADVAPI32]
* Update GetTrusteeForm{A,W}().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65050 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[ADVAPI32]
akhaldi [Mon, 27 Oct 2014 17:00:41 +0000 (17:00 +0000)]
[ADVAPI32]
* Remove unused MAX_GUID_STRING_LEN and RECORD.
* Remove some unneeded forward declarations.
* Reorder ACEFLAG to reduce difference to Wine.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65045 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[ADVAPI32]
akhaldi [Mon, 27 Oct 2014 16:30:45 +0000 (16:30 +0000)]
[ADVAPI32]
* Zap SidTable.

git-svn-id: file:///srv/svn/reactos/trunk@65044 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Mon, 27 Oct 2014 13:39:03 +0000 (13:39 +0000)]
[FASTFAT]
Don't leak reference in case of share access failure.

git-svn-id: file:///srv/svn/reactos/trunk@65043 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Mon, 27 Oct 2014 13:38:14 +0000 (13:38 +0000)]
[FASTFAT]
Add sanity checks in VfatSetRenameInformation() to make sure we don't leak any FCB reference

git-svn-id: file:///srv/svn/reactos/trunk@65042 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Mon, 27 Oct 2014 12:35:58 +0000 (12:35 +0000)]
[NTFS]
Bugfixing... Part 10/X:
- Properly compute entry name length in CompareFileName()
- Also, in CompareFileName() properly handle the return of RtlCompareUnicodeString(); this is not RtlEqualUnicodeString()!
- In NtfsLookupFileAt(), don't return an error when we're done walking the path, it's a normal behavior

All these fixes allow our NTFS to go one step farther: it can open directory/files (reading files data remains untested so far) in root and in its subdirs. Which was broken previously.
The said bugfixes in action (and in image): http://www.heisspiter.net/~Pierre/rostests/NTFS_listing_subdir.png

git-svn-id: file:///srv/svn/reactos/trunk@65041 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVAPI32]
tfaber [Mon, 27 Oct 2014 11:52:44 +0000 (11:52 +0000)]
[ADVAPI32]
- Hackfix CORE-8717 to stop 2nd stage from failing. Proper fix will be submitted to Wine.

git-svn-id: file:///srv/svn/reactos/trunk@65040 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NtUser]
jimtabor [Mon, 27 Oct 2014 02:11:08 +0000 (02:11 +0000)]
[NtUser]
- Fix default sizes for desktop resources. See CORE-8659.

git-svn-id: file:///srv/svn/reactos/trunk@65039 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FAST486]
aandrejevic [Mon, 27 Oct 2014 00:21:06 +0000 (00:21 +0000)]
[FAST486]
Don't leave the prefetch cache in a possibly invalid state if Fast486ReadLinearMemory
returns FALSE.

git-svn-id: file:///srv/svn/reactos/trunk@65037 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FAST486]
aandrejevic [Sun, 26 Oct 2014 23:37:54 +0000 (23:37 +0000)]
[FAST486]
Implement an (optional) instruction prefetch cache.
Implement the INVLPG instruction.

git-svn-id: file:///srv/svn/reactos/trunk@65035 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[KERNEL32]
pschweitzer [Sun, 26 Oct 2014 21:09:07 +0000 (21:09 +0000)]
[KERNEL32]
Prevent a use-after-free issue in GetVolumeNameForVolumeMountPointW()

git-svn-id: file:///srv/svn/reactos/trunk@65034 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 26 Oct 2014 20:29:00 +0000 (20:29 +0000)]
[FASTFAT]
Make sure the appropriate resource is exclusively acquired when playing with FCB references

git-svn-id: file:///srv/svn/reactos/trunk@65033 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 26 Oct 2014 20:23:07 +0000 (20:23 +0000)]
[FASTFAT]
s/DeviceObject/DeviceExt/g

git-svn-id: file:///srv/svn/reactos/trunk@65032 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 26 Oct 2014 20:20:42 +0000 (20:20 +0000)]
[FASTFAT]
Implement vfatGrabFCB() (which was defined but never implemented) for increasing the reference count on a FCB.
This will make debugging easier.

Dedicated to Thomas :-).

git-svn-id: file:///srv/svn/reactos/trunk@65031 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 19:56:15 +0000 (19:56 +0000)]
[ADVAPI32]
* Update ConvertStringSidToSid{A,W}().
* Fixes some advapi32:security tests.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65030 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[RASDLG]
akhaldi [Sun, 26 Oct 2014 19:43:01 +0000 (19:43 +0000)]
[RASDLG]
* Turkish translation update by Erdem Ersoy.
CORE-7861

git-svn-id: file:///srv/svn/reactos/trunk@65029 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS] Also return the short file name to caller if available
hpoussin [Sun, 26 Oct 2014 19:10:39 +0000 (19:10 +0000)]
[NTFS] Also return the short file name to caller if available

git-svn-id: file:///srv/svn/reactos/trunk@65028 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS] Prefer long file name when naming objects
hpoussin [Sun, 26 Oct 2014 19:10:17 +0000 (19:10 +0000)]
[NTFS] Prefer long file name when naming objects

We now always see the long file name of an object when browsing NTFS partitions.

git-svn-id: file:///srv/svn/reactos/trunk@65027 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS] Correctly read indexes
hpoussin [Sun, 26 Oct 2014 19:10:04 +0000 (19:10 +0000)]
[NTFS] Correctly read indexes

This fixes (at least) an infinite loop when trying to mount some partitions.

git-svn-id: file:///srv/svn/reactos/trunk@65026 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS] Fix some debug prints
hpoussin [Sun, 26 Oct 2014 19:09:52 +0000 (19:09 +0000)]
[NTFS] Fix some debug prints

git-svn-id: file:///srv/svn/reactos/trunk@65025 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 26 Oct 2014 18:48:30 +0000 (18:48 +0000)]
[FASTFAT]
Acquire DirResource in DoQuery() before attempting to play with FCBs.

This is dedicated to Thomas ;-)

git-svn-id: file:///srv/svn/reactos/trunk@65024 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTOS:SE]
ekohl [Sun, 26 Oct 2014 18:39:58 +0000 (18:39 +0000)]
[NTOS:SE]
Remove the old access check code in SepAccessCheckEx and use the new code instead. The new access check code is a lot better than the old code, but it makes the boot and install fail. This is caused by some kernel objects which are accessed using insufficient access rights. Therefore I added a little hack that shows a warning when insufficient rights are granted for an object and access is granted anyway.

git-svn-id: file:///srv/svn/reactos/trunk@65023 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 17:51:59 +0000 (17:51 +0000)]
[ADVAPI32]
* Update GetAclInformation().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65022 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[CRT]
tfaber [Sun, 26 Oct 2014 17:32:00 +0000 (17:32 +0000)]
[CRT]
- Fix strlen/wcslen FPO specification. Spotted by Timo.
- Also add FPO info for memset, memchr, memmove/memcpy

git-svn-id: file:///srv/svn/reactos/trunk@65021 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]: Temporarily fix for r65015 before a proper fix.
hbelusca [Sun, 26 Oct 2014 16:56:14 +0000 (16:56 +0000)]
[NTVDM]: Temporarily fix for r65015 before a proper fix.

git-svn-id: file:///srv/svn/reactos/trunk@65018 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 16:48:36 +0000 (16:48 +0000)]
[ADVAPI32]
* Update GetAce().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65017 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 15:59:57 +0000 (15:59 +0000)]
[ADVAPI32]
* Update DeleteAce().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65016 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]: No need to re-change to a given video mode when it is already set. Fixes...
hbelusca [Sun, 26 Oct 2014 15:57:21 +0000 (15:57 +0000)]
[NTVDM]: No need to re-change to a given video mode when it is already set. Fixes strange changes for e.g. some apps that find intelligent to switch 256 times to mode 13h (for example) before continuing to run.

git-svn-id: file:///srv/svn/reactos/trunk@65015 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 26 Oct 2014 15:56:20 +0000 (15:56 +0000)]
[FASTFAT]
Make FATGetNextDirEntry() and vfatFindDirSpace() complain when they are given a cleaned up FCB (which shouldn't happen!).
They'll display full path, references count, open handles count.

Where are you little reference leak?

git-svn-id: file:///srv/svn/reactos/trunk@65014 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 26 Oct 2014 15:35:18 +0000 (15:35 +0000)]
[FASTFAT]
Don't leak reference on failure in vfatPrepareTargetForRename().

git-svn-id: file:///srv/svn/reactos/trunk@65013 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]: Return the latched data for keyboard ps/2 port only. Also when starting...
hbelusca [Sun, 26 Oct 2014 15:01:14 +0000 (15:01 +0000)]
[NTVDM]: Return the latched data for keyboard ps/2 port only. Also when starting an app put a ENTER key release into the keyboard buffer because some apps expect it.

git-svn-id: file:///srv/svn/reactos/trunk@65012 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]
aandrejevic [Sun, 26 Oct 2014 14:57:44 +0000 (14:57 +0000)]
[NTVDM]
Signal the next IRQ on EOI.

git-svn-id: file:///srv/svn/reactos/trunk@65011 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 11:55:05 +0000 (11:55 +0000)]
[ADVAPI32]
* Import ADVAPI_GetComputerSid from Wine 1.7.27.
* Apply Wine commit f7a6c4c3 by Detlef Riekenberg: Allow string alias for common RID in sid strings.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65010 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FAST486][NTVDM]: Do not compile some FPU functions when FAST486_NO_FPU is defined...
hbelusca [Sun, 26 Oct 2014 11:50:14 +0000 (11:50 +0000)]
[FAST486][NTVDM]: Do not compile some FPU functions when FAST486_NO_FPU is defined (fixes build).

git-svn-id: file:///srv/svn/reactos/trunk@65009 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 11:47:29 +0000 (11:47 +0000)]
[ADVAPI32]
* Reorder AceRights to reduce difference to Wine.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65008 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 10:59:11 +0000 (10:59 +0000)]
[ADVAPI32]
* Apply Wine commit e57edfea by Paul Vriens: Skip leading spaces when parsing.
* Update the related functions with Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65007 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sun, 26 Oct 2014 10:34:40 +0000 (10:34 +0000)]
[ADVAPI32]
* Update CopySid().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65006 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTVDM]: Addendum to r64985: correctly display the IPS and the TimerTicks (both of...
hbelusca [Sun, 26 Oct 2014 02:38:07 +0000 (02:38 +0000)]
[NTVDM]: Addendum to r64985: correctly display the IPS and the TimerTicks (both of them are *LONGLONG).

git-svn-id: file:///srv/svn/reactos/trunk@65005 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTVDM]
aandrejevic [Sun, 26 Oct 2014 02:29:31 +0000 (02:29 +0000)]
[NTVDM]
Make sure the offset doesn't exceed the VGA bank size.
Load the latch registers after the loop (optimization).

git-svn-id: file:///srv/svn/reactos/trunk@65004 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTVDM]: Fix the validity check of the hVdd handle in the port structure so that...
hbelusca [Sun, 26 Oct 2014 02:27:11 +0000 (02:27 +0000)]
[NTVDM]: Fix the validity check of the hVdd handle in the port structure so that we don't try to call an invalid VDD IO handler. That fixes stack corruption for example in the case of OUTSB/W operations, where we could call an invalid VDD handler taking 3 parameters that in fact calls (because VDD handlers and our internal ones are stored in a union, the choice of the handler is done via the hVdd value) an internal handler taking only 2 parameters... Bug triggered when testing MSVC-compiled NTVDM in speed-optimized mode. Diagnosed by V. and I, thanks V!

git-svn-id: file:///srv/svn/reactos/trunk@65003 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[DDK]: VDD IO handlers are WINAPI and not something undefined (CDECL ... ?). Double...
hbelusca [Sun, 26 Oct 2014 01:28:32 +0000 (01:28 +0000)]
[DDK]: VDD IO handlers are WINAPI and not something undefined (CDECL ... ?). Double-checked by V.

git-svn-id: file:///srv/svn/reactos/trunk@65002 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sat, 25 Oct 2014 22:37:02 +0000 (22:37 +0000)]
[ADVAPI32]
* Update OpenThreadToken().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@65000 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NtUser]
jimtabor [Sat, 25 Oct 2014 22:06:13 +0000 (22:06 +0000)]
[NtUser]
- Do not block sending messages from a dying thread. See CORE-7447.

git-svn-id: file:///srv/svn/reactos/trunk@64999 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NET]
ekohl [Sat, 25 Oct 2014 21:27:05 +0000 (21:27 +0000)]
[NET]
Implement and use console-aware print functions to print strings and resources.

git-svn-id: file:///srv/svn/reactos/trunk@64998 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WIN32k]
tkreuzer [Sat, 25 Oct 2014 21:16:17 +0000 (21:16 +0000)]
[WIN32k]
Stop ASSERTing, that we always have all the resources we need in IntCreateCompatibleBitmap

git-svn-id: file:///srv/svn/reactos/trunk@64997 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WININET_WINETEST]
akhaldi [Sat, 25 Oct 2014 18:35:58 +0000 (18:35 +0000)]
[WININET_WINETEST]
* ROSTESTS-73 is not fixed yet.

git-svn-id: file:///srv/svn/reactos/trunk@64995 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sat, 25 Oct 2014 18:30:05 +0000 (18:30 +0000)]
[ADVAPI32]
* Update ImpersonateNamedPipeClient().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64994 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WIN32K]
jgardou [Sat, 25 Oct 2014 18:11:36 +0000 (18:11 +0000)]
[WIN32K]
 - Use a palette created from the DIB infos for surface created through CreateDIBitmap(CBM_CREATEDIB)
CORE-8695 #comment Booting in 16bpp mode is now OK, but some problems remain when switching mode from 16bpp to 32bpp

git-svn-id: file:///srv/svn/reactos/trunk@64993 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WIN32K]
jgardou [Sat, 25 Oct 2014 18:11:31 +0000 (18:11 +0000)]
[WIN32K]
 - Always store alpha-aware cursors in a 32bpp RGB surface.
CORE-8695

git-svn-id: file:///srv/svn/reactos/trunk@64992 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[WIN32K]
jgardou [Sat, 25 Oct 2014 18:11:27 +0000 (18:11 +0000)]
[WIN32K]
 - Avoid leaking handles when loading animated cursors.

git-svn-id: file:///srv/svn/reactos/trunk@64991 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[USER32]
jgardou [Sat, 25 Oct 2014 18:11:11 +0000 (18:11 +0000)]
[USER32]
 - Fix a stupid buffer overflow I introduced in r64967.
 - Take BITMAPCOREINFO into account when loading a cursor from file.

git-svn-id: file:///srv/svn/reactos/trunk@64990 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sat, 25 Oct 2014 17:46:33 +0000 (17:46 +0000)]
[ADVAPI32]
* Move a couple functions from sec.c to security.c.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64989 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FAST486]
aandrejevic [Sat, 25 Oct 2014 17:16:37 +0000 (17:16 +0000)]
[FAST486]
The opcode handlers don't need a return value, it's not used anywhere.

git-svn-id: file:///srv/svn/reactos/trunk@64988 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ADVAPI32]
akhaldi [Sat, 25 Oct 2014 16:08:39 +0000 (16:08 +0000)]
[ADVAPI32]
* Update GetKernelObjectSecurity().
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64987 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTVDM]: So..... do not overflow the Cycles count, i.e. better estimate the number...
hbelusca [Sat, 25 Oct 2014 15:36:11 +0000 (15:36 +0000)]
[NTVDM]: So..... do not overflow the Cycles count, i.e. better estimate the number of instructions per second :)

git-svn-id: file:///srv/svn/reactos/trunk@64985 97493ccd-5924-5043-b1f5-66cb403b36ce