30 min ago[WIN32K]: Remove those unneeded #defines, they are already declared in include/reacto... master trunk
hbelusca [Fri, 28 Nov 2014 21:59:32 +0000 (21:59 +0000)]
[WIN32K]: Remove those unneeded #defines, they are already declared in include/reactos/undocuser.h

git-svn-id: file:///srv/svn/reactos/trunk@65518 97493ccd-5924-5043-b1f5-66cb403b36ce

41 min ago[WIN32K]: Move IntClientShutdown function to a dedicated file (that will contain...
hbelusca [Fri, 28 Nov 2014 21:48:44 +0000 (21:48 +0000)]
[WIN32K]: Move IntClientShutdown function to a dedicated file (that will contain other shutdown helper functions in the future). Part 3/X

git-svn-id: file:///srv/svn/reactos/trunk@65517 97493ccd-5924-5043-b1f5-66cb403b36ce

80 min ago[USERSRV]: Use UlongToHandle and make ServicesProcessId global (will be used later...
hbelusca [Fri, 28 Nov 2014 21:08:57 +0000 (21:08 +0000)]
[USERSRV]: Use UlongToHandle and make ServicesProcessId global (will be used later on, for shutdown). Part 2/X

git-svn-id: file:///srv/svn/reactos/trunk@65516 97493ccd-5924-5043-b1f5-66cb403b36ce

90 min ago[USER32]: Move some logon-related functions to an appropriate file.
hbelusca [Fri, 28 Nov 2014 20:58:50 +0000 (20:58 +0000)]
[USER32]: Move some logon-related functions to an appropriate file.

git-svn-id: file:///srv/svn/reactos/trunk@65515 97493ccd-5924-5043-b1f5-66cb403b36ce

105 min ago[NtUser]
jimtabor [Fri, 28 Nov 2014 20:44:04 +0000 (20:44 +0000)]
- Revert 65431, it seems to be breaking more than it fixes. Process Explorer will break again, working on a better way to fix this. See CORE-7447.

git-svn-id: file:///srv/svn/reactos/trunk@65514 97493ccd-5924-5043-b1f5-66cb403b36ce

115 min ago[USER32]
hbelusca [Fri, 28 Nov 2014 20:34:16 +0000 (20:34 +0000)]
- Call GetThreadConsoleDesktop of CONSRV if needed, in GetThreadDesktop (in case the process is a console app).
- Introduce two last-error helpers UserSetLast(NT)Error which work the same as the (Base)SetLast(NT)Error of kernel32, needed for CSR status errors etc...

- Improve the stub of SrvGetThreadConsoleDesktop (it needs to success, and atm. it always zeroes-out the returned console desktop handle).

git-svn-id: file:///srv/svn/reactos/trunk@65513 97493ccd-5924-5043-b1f5-66cb403b36ce

3 hours ago[KERNEL32_WINETEST] Addendum to r65511.
akhaldi [Fri, 28 Nov 2014 19:22:34 +0000 (19:22 +0000)]
[KERNEL32_WINETEST] Addendum to r65511.

git-svn-id: file:///srv/svn/reactos/trunk@65512 97493ccd-5924-5043-b1f5-66cb403b36ce

3 hours ago[RTL] Import Wine commit f87767b by Piotr Caban: Handle ACTCTX_FLAG_ASSEMBLY_DIRECTOR...
akhaldi [Fri, 28 Nov 2014 19:20:39 +0000 (19:20 +0000)]
[RTL] Import Wine commit f87767b by Piotr Caban: Handle ACTCTX_FLAG_ASSEMBLY_DIRECTORY_VALID flag when opening manifest in RtlCreateActivationContext.

git-svn-id: file:///srv/svn/reactos/trunk@65511 97493ccd-5924-5043-b1f5-66cb403b36ce

25 hours ago[EXPLORER]
gadamopoulos [Thu, 27 Nov 2014 21:11:29 +0000 (21:11 +0000)]
* Move some definitions in precomp.h

git-svn-id: file:///srv/svn/reactos/trunk@65510 97493ccd-5924-5043-b1f5-66cb403b36ce

25 hours agoAttempt to fix build.
gadamopoulos [Thu, 27 Nov 2014 20:32:38 +0000 (20:32 +0000)]
Attempt to fix build.

git-svn-id: file:///srv/svn/reactos/trunk@65509 97493ccd-5924-5043-b1f5-66cb403b36ce

26 hours ago[FASTFAT]
pschweitzer [Thu, 27 Nov 2014 20:28:50 +0000 (20:28 +0000)]
Properly handle shared accesses on volume open.
No need to add the support for this in cleanup, it was already there.

git-svn-id: file:///srv/svn/reactos/trunk@65508 97493ccd-5924-5043-b1f5-66cb403b36ce

26 hours ago[HEADERS]
gadamopoulos [Thu, 27 Nov 2014 20:27:19 +0000 (20:27 +0000)]
- Move definitions for DrawCaptionTemp to userundoc.h as it shouldn't be defined in the psdk
- Add browseui_undoc.h and move there the undocumented definitions for browseui
- Add comctl32_undoc.h and move there the undocumented definitions for comctl32
- Move undocumented definitions for shlwapi to shlwapi_undoc.h
- Add shellutils.h to contain helper macros and definitions that are nor per se undocumented.
- Cleanup internal definitions of explorer. Remove several temporary hacks. They were added at a time that these features were not implemented at all.

git-svn-id: file:///srv/svn/reactos/trunk@65507 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[CMAKE]
akhaldi [Thu, 27 Nov 2014 19:09:07 +0000 (19:09 +0000)]
* Simplify compiling some single-source-file tools.

git-svn-id: file:///srv/svn/reactos/trunk@65506 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago* Addendum to r65503 (consistent formatting).
akhaldi [Thu, 27 Nov 2014 18:59:19 +0000 (18:59 +0000)]
* Addendum to r65503 (consistent formatting).

git-svn-id: file:///srv/svn/reactos/trunk@65505 97493ccd-5924-5043-b1f5-66cb403b36ce

27 hours ago[NtUser]
jimtabor [Thu, 27 Nov 2014 18:35:57 +0000 (18:35 +0000)]
- Fix code duplication.

git-svn-id: file:///srv/svn/reactos/trunk@65504 97493ccd-5924-5043-b1f5-66cb403b36ce

32 hours ago[ADVAPI32]
gadamopoulos [Thu, 27 Nov 2014 14:21:43 +0000 (14:21 +0000)]
- Stub ElfRegisterEventSourceW, ElfReportEventW and ElfDeregisterEventSource. These are needed by windows sxs.dll, and sxs.dll is needed by windows basesrv.dll.

git-svn-id: file:///srv/svn/reactos/trunk@65503 97493ccd-5924-5043-b1f5-66cb403b36ce

32 hours ago[DEVICE_MANAGER]
gedmurphy [Thu, 27 Nov 2014 13:47:49 +0000 (13:47 +0000)]
- Test whether a driver is hidden or not by checking its status instead of the old hack of hiding certain classes which we deemed should be hidden.
- Add support for hiding devices and problem overlays when showing by connection.
- We now show and hide identical devices when run alongside the Win8 MS device manager in both by type and by connection.
- Update the radio buttons when selecting the menu type.
- Add a manifest and use Win7 arrows on the TreeView.

git-svn-id: file:///srv/svn/reactos/trunk@65502 97493ccd-5924-5043-b1f5-66cb403b36ce

40 hours ago[FASTFAT]
pschweitzer [Thu, 27 Nov 2014 06:16:21 +0000 (06:16 +0000)]
Set clean shutdown bit on dismount

git-svn-id: file:///srv/svn/reactos/trunk@65501 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[SHELL] Reapply r65477 (rename explorer-new to explorer).
akhaldi [Wed, 26 Nov 2014 23:24:26 +0000 (23:24 +0000)]
[SHELL] Reapply r65477 (rename explorer-new to explorer).

git-svn-id: file:///srv/svn/reactos/trunk@65500 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[SHELL] Reapply r65476 (rename explorer to explorer-old).
akhaldi [Wed, 26 Nov 2014 23:22:44 +0000 (23:22 +0000)]
[SHELL] Reapply r65476 (rename explorer to explorer-old).

git-svn-id: file:///srv/svn/reactos/trunk@65499 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[SETUP]
akhaldi [Wed, 26 Nov 2014 23:17:02 +0000 (23:17 +0000)]
* Set 32bpp as default bit depth instead of 16bpp. Suggestion and patch provided by Ismael Ferreras Morezuelas (swyter).
CORE-8826 #resolve #comment Committed in r65498. Gracias!

git-svn-id: file:///srv/svn/reactos/trunk@65498 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[SHELL] Move shlguid_undoc.h, shlobj_undoc.h and shlwapi_undoc.h to our includes...
akhaldi [Wed, 26 Nov 2014 23:03:06 +0000 (23:03 +0000)]
[SHELL] Move shlguid_undoc.h, shlobj_undoc.h and shlwapi_undoc.h to our includes folder instead of the PSDK one.

git-svn-id: file:///srv/svn/reactos/trunk@65497 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago* The Shell.. for a long time we dreamed of having a compatible, properly working...
akhaldi [Wed, 26 Nov 2014 19:49:18 +0000 (19:49 +0000)]
* The Shell.. for a long time we dreamed of having a compatible, properly working rewrite, but it's easier said than done. Over the years this effort has been split into tasks, and this branch was the biggest overall. Now it's time to merge it back to trunk!
* This merge is also a chance to thank every single person involved directly and indirectly in this epic work, among them: Martin Fuchs for ReactOS explorer which we are respectfully retiring now, as it served the project so well over all these years. Thomas Bluemel (Thomas Weidenmueller aka w3seek) for his brave work on the shell, mainly his explorer_new. Andrew Hill for advancing the shell bringup with some impressive work. David Quintana, Giannis Adamopoulos and Huw Campbell for working as a solid team on making this branch a huge success, allowing the shell rewrite dream to finally become a reality. Again, thank you all!
* Merging this branch is not the end.. it's the beginning of some serious bug fixing based hopefully on the Community's continuous feedback.
* Finally, here are *some* of the highlights of this branch (simply put):

[BROWSEUI] Halfplement the address bar. Mostly implement the Favorites menu. Implement handling most hotkeys that should be handled by CShellBrowser. Fix various bugs.

[EXPLORER_NEW] Convert to C++ and use several wtl-like classes to simplify it. Fix several bugs and implement misc missing features.

[FILEBROWSER] A small exe file that opens a new file browser window in its own process. Tested to work in windows. It can be used to test our browseui.dll in windows.

[FONTS] A new marlett font.

[MSGINA] Add a proper shutdown dialog that's used when the user selects shutdown from the start menu (this is how it's done in Windows).

[RSHELL] A temporary module that hosts the implementation of the following classes needed for the shell: CMenuBand, CMenuDeskBar, CMenuSite, CMergedFolder, CStartMenu. These were implemented and tested in windows and for that reason they are still there. Should be moved in shell32 in the future.

[SHELL32] Reorganize files to isolate the ones that are not yet forked from wine. Fix various problems. Simplify the implementation of some shell folders. Implement filling in the file menu in the file browser.

[STOBJECT] A shell extension responsible for misc taskbar notification icons. So far only the sound icon is implemented. Adding this is necessary as the old explorer had the sound icon built in and deprecating it needs a proper solution for these notification icons.

[WIN32K] Fix several bugs that prevented the new start menu (that was implemented and tested in Windows) from functioning properly in ReactOS, mostly due to focus issues. Fix several shell notifications to behave more like in Windows.

* Tonight! We shall feast!
* And tomorrow the US guys shall feast again, on turkey! :p


git-svn-id: file:///srv/svn/reactos/trunk@65496 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DEVICE_MANAGER]
gedmurphy [Wed, 26 Nov 2014 19:46:26 +0000 (19:46 +0000)]
- On refresh, recurse the tree and delete all the Device Ids attached to each node
- Fix SAL and a few missing comments

git-svn-id: file:///srv/svn/reactos/trunk@65495 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[DEVICE_MANAGER]
gedmurphy [Wed, 26 Nov 2014 17:21:45 +0000 (17:21 +0000)]
- Add a class for managing the device view, and a class for managing the device objects.
- Implement listing devices by type and by connection.
- Add support for showing hidden devices
- Add support for showing unknown devices with overlay icons.
- implement showing the device properties via dounle click or hitting enter
- Add support for both Win7/8 as well as XP
- Make the code much more readable and maintainable. and easier to move to an mmc snapin if we ever get one.

I forgot this existed until today. I had some spare time so I decided to have a quick go at finishing it. Stick with the original one for now though, I ran out of time....

git-svn-id: file:///srv/svn/reactos/trunk@65493 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[Explorer]
jimtabor [Wed, 26 Nov 2014 15:29:51 +0000 (15:29 +0000)]
- Restore the original four virtual window support. See CORE-6151.

git-svn-id: file:///srv/svn/reactos/trunk@65491 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WIN32K]
tkreuzer [Tue, 25 Nov 2014 23:44:59 +0000 (23:44 +0000)]
- Implement FLOATOBJ_bConvertToLong inline function that converts a FLOATOBJ to a long or returns FALSE if the value would overflow a LONG
- Remove underscore prefixes from inline FLOATOBJ functions and use it only on those that already exist as non-inline versions.
- Remove duplicated FLOATOBJ defines for non-x86
- Fail on integer overflow in XFORMOBJ_bXformFixPoints to avoid creating bogus coordinates.

git-svn-id: file:///srv/svn/reactos/trunk@65490 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days agoForgot this include...
hbelusca [Tue, 25 Nov 2014 23:36:56 +0000 (23:36 +0000)]
Forgot this include...

git-svn-id: file:///srv/svn/reactos/trunk@65489 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[LSASS][SERVICES][WINLOGON]: As CSRSS and SMSS already, those apps should be marked...
hbelusca [Tue, 25 Nov 2014 23:34:14 +0000 (23:34 +0000)]
[LSASS][SERVICES][WINLOGON]: As CSRSS and SMSS already, those apps should be marked as critical for the system. See for more details.

git-svn-id: file:///srv/svn/reactos/trunk@65488 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[Win32k]
jimtabor [Tue, 25 Nov 2014 23:03:43 +0000 (23:03 +0000)]
- Fixes wine win.c:test_SetParent last ShowWindow test after popup dies.

git-svn-id: file:///srv/svn/reactos/trunk@65487 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Tue, 25 Nov 2014 21:03:17 +0000 (21:03 +0000)]
Make the bound check more consistent and more accurate

git-svn-id: file:///srv/svn/reactos/trunk@65486 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FREELDR]
tkreuzer [Tue, 25 Nov 2014 20:21:16 +0000 (20:21 +0000)]
Move down MEMORY_MARGIN to 0x9A00 to fix boot on BIOSes with even larger EBDAs (see also r64945 and r65127), still leaving 48KB for the DISKREADBUFFER
CORE-8830 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@65485 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[Win32k]
jimtabor [Tue, 25 Nov 2014 19:56:40 +0000 (19:56 +0000)]
- Fix wine win.c:test_mouse_input:WM_COMMAND tests.

git-svn-id: file:///srv/svn/reactos/trunk@65484 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[PSDK/XDK]
tkreuzer [Tue, 25 Nov 2014 09:46:18 +0000 (09:46 +0000)]
Add back definitions that go lost in the last commit.
winnt.h is autogenerated, please do not modify it directly, but instead modify the related file in XDK and regenerate the headers from XDK.

git-svn-id: file:///srv/svn/reactos/trunk@65481 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[PSDK]
tkreuzer [Tue, 25 Nov 2014 09:08:34 +0000 (09:08 +0000)]
When I wrote "the compiler can optimize this better" I was obviously referring to a sane compiler like MSVC. Optimize (U)Int32x32To64 on x86 GCC builds by using __emul(u), since the native math results in horribly inefficient code doing 3 multiplications and some shifts.

git-svn-id: file:///srv/svn/reactos/trunk@65480 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTFS]
pschweitzer [Mon, 24 Nov 2014 20:02:40 +0000 (20:02 +0000)]
Add the reparse point attribute definition

git-svn-id: file:///srv/svn/reactos/trunk@65475 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTFS]
pschweitzer [Mon, 24 Nov 2014 20:01:34 +0000 (20:01 +0000)]
Warn about unimplemented sub-node browsing while looking into a MFT directory stream.
Might likely explain why we cannnot enumerate all the files on a Win7 volume.

git-svn-id: file:///srv/svn/reactos/trunk@65474 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NTFS]
pschweitzer [Mon, 24 Nov 2014 19:54:22 +0000 (19:54 +0000)]

Spotted by Thomas. Thanks :-)

git-svn-id: file:///srv/svn/reactos/trunk@65473 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[NtUser]
jimtabor [Mon, 24 Nov 2014 02:50:18 +0000 (02:50 +0000)]
- Synchronize mouse messages. Part II
- Dedicated to Giannis Adamopoulos and Amine Khaldi.
- Additional fixes are added.
- This should be more accurate, based on "Hit Testing: Which HWND is the mouse over?":
- Note: Older FireFox menu item hilite select seem to work now, do not need to keep moving the mouse to keep it hilited to be selected.
- Test results:,33710,33713

git-svn-id: file:///srv/svn/reactos/trunk@65472 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CONSRV]: Implement CREATE_NO_WINDOW support.
hbelusca [Sun, 23 Nov 2014 23:04:45 +0000 (23:04 +0000)]
[CONSRV]: Implement CREATE_NO_WINDOW support.

git-svn-id: file:///srv/svn/reactos/trunk@65471 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTFS]
pschweitzer [Sun, 23 Nov 2014 20:52:59 +0000 (20:52 +0000)]
- Fix $FILENAME_ATTRIBUTE definition to allow reading reparse points tag
- Add missing file attribute (reparse point)

git-svn-id: file:///srv/svn/reactos/trunk@65470 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[TASKMGR]
hbelusca [Sun, 23 Nov 2014 20:10:15 +0000 (20:10 +0000)]
- Show programs command line in taskmgr.
  Patch by Ismael Ferreras Morezuelas with minor modifications by me.
- int nMaxCount --> ULONG nMaxCount (that makes everything clearer and removes MSVC warnings).
CORE-5467 #resolve #comment Feature committed in revision 65469, cheers ;)

git-svn-id: file:///srv/svn/reactos/trunk@65469 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTFS]
pschweitzer [Sun, 23 Nov 2014 19:53:16 +0000 (19:53 +0000)]
- Implement NtfsGetPositionInformation(), NtfsGetBasicInformation()
- Add a fixme in NtfsGetStandardInformation() regarding the number of links

git-svn-id: file:///srv/svn/reactos/trunk@65468 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days agoFixup a potential division by zero (that happens anyway in my tests).
hbelusca [Sun, 23 Nov 2014 19:16:41 +0000 (19:16 +0000)]
Fixup a potential division by zero (that happens anyway in my tests).

git-svn-id: file:///srv/svn/reactos/trunk@65467 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[TASKMGR]
hbelusca [Sun, 23 Nov 2014 18:36:25 +0000 (18:36 +0000)]
Improve formatting memory size usage in the status bar of Task Manager.
Patch by Ismael Ferreras Morezuelas (swyter).
CORE-8810 #resolve #comment Committed in r65466, thanks d:^D

git-svn-id: file:///srv/svn/reactos/trunk@65466 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[WIN32K]: Use the logon process ID instead of a full win32k process object, it simpli...
hbelusca [Sun, 23 Nov 2014 16:09:00 +0000 (16:09 +0000)]
[WIN32K]: Use the logon process ID instead of a full win32k process object, it simplifies code in some parts.

git-svn-id: file:///srv/svn/reactos/trunk@65465 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days agoWhitespace fixes.
hbelusca [Sun, 23 Nov 2014 15:57:13 +0000 (15:57 +0000)]
Whitespace fixes.

git-svn-id: file:///srv/svn/reactos/trunk@65464 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[WINSRV]: Pave the way for proper ReactOS shutdown. Part 1/X
hbelusca [Sun, 23 Nov 2014 15:50:49 +0000 (15:50 +0000)]
[WINSRV]: Pave the way for proper ReactOS shutdown. Part 1/X

git-svn-id: file:///srv/svn/reactos/trunk@65463 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTFS]
pschweitzer [Sun, 23 Nov 2014 15:49:24 +0000 (15:49 +0000)]
- In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names.
- In CompareFileName(), handle the fact that for Win32 & DOS we do case insensitive comparisons by upcasing name before match. Don't do it for POSIX names!

This fixes name completion in cmd for POSIX. And doesn't break it for Win32 :-).

git-svn-id: file:///srv/svn/reactos/trunk@65462 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days agoResuscitate VMS subsystem (yeah, you've correctly read: VMS!!) from revision 24496.
hbelusca [Sun, 23 Nov 2014 15:24:49 +0000 (15:24 +0000)]
Resuscitate VMS subsystem (yeah, you've correctly read: VMS!!) from revision 24496.

git-svn-id: file:///srv/svn/reactos/trunk@65461 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days agoResuscitate POSIX subsystem from revision 21378.
hbelusca [Sun, 23 Nov 2014 15:23:36 +0000 (15:23 +0000)]
Resuscitate POSIX subsystem from revision 21378.

git-svn-id: file:///srv/svn/reactos/trunk@65460 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days agoResuscitate OS/2 subsystem from revision 24496.
hbelusca [Sun, 23 Nov 2014 15:22:07 +0000 (15:22 +0000)]
Resuscitate OS/2 subsystem from revision 24496.

git-svn-id: file:///srv/svn/reactos/trunk@65459 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days agoCreate a repository to ressuscitate our verrrrry old subsystems.
hbelusca [Sun, 23 Nov 2014 14:50:34 +0000 (14:50 +0000)]
Create a repository to ressuscitate our verrrrry old subsystems.

git-svn-id: file:///srv/svn/reactos/trunk@65458 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[CONSRV]: Reduce code duplication and remove unused InputWaitHandle member.
hbelusca [Sun, 23 Nov 2014 14:26:37 +0000 (14:26 +0000)]
[CONSRV]: Reduce code duplication and remove unused InputWaitHandle member.

git-svn-id: file:///srv/svn/reactos/trunk@65457 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTFS]
pschweitzer [Sun, 23 Nov 2014 14:07:08 +0000 (14:07 +0000)]
- Implement GetBestFileNameFromRecord() which will select the higher subsystem name available (POSIX -> Win32 -> DOS) and return it
- Replace the hand-made implementation of it in dirctl functions relying on it (NtfsGetDirectoryInformation(), NtfsGetFullDirectoryInformation(), NtfsGetBothDirectoryInformation())
- Use it in NtfsMakeFCBFromDirEntry()

This fixes browsing POSIX volume (and opening file) in cmd. Even though, explorer doesn't seem to be happy with such change...
This doesn't fix yet the autocompletion in cmd either.

git-svn-id: file:///srv/svn/reactos/trunk@65456 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[PSDK] Add some missing setupapi-related functions
hpoussin [Sun, 23 Nov 2014 13:48:20 +0000 (13:48 +0000)]
[PSDK] Add some missing setupapi-related functions

git-svn-id: file:///srv/svn/reactos/trunk@65455 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[SCSIPORT] Better error messages when receiving unexpected IOCTLs of mount manager
hpoussin [Sun, 23 Nov 2014 13:48:12 +0000 (13:48 +0000)]
[SCSIPORT] Better error messages when receiving unexpected IOCTLs of mount manager

git-svn-id: file:///srv/svn/reactos/trunk@65454 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTOS:CC] Fix bug in CcPinRead
hpoussin [Sun, 23 Nov 2014 13:48:06 +0000 (13:48 +0000)]
[NTOS:CC] Fix bug in CcPinRead

In fact, this bug is never exposed because CcPinMappedData always returns TRUE.

git-svn-id: file:///srv/svn/reactos/trunk@65453 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTOS:MM] Fix warnings when NEWCC is enabled
hpoussin [Sun, 23 Nov 2014 13:48:01 +0000 (13:48 +0000)]
[NTOS:MM] Fix warnings when NEWCC is enabled

git-svn-id: file:///srv/svn/reactos/trunk@65452 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[NTVDM]: Rewrite video window scrolling code more efficiently (i.e. getting rid of...
hbelusca [Sun, 23 Nov 2014 12:03:55 +0000 (12:03 +0000)]
[NTVDM]: Rewrite video window scrolling code more efficiently (i.e. getting rid of HeapAlloc/Free calls). As a bonus, implement scrolling horizontally.

git-svn-id: file:///srv/svn/reactos/trunk@65451 97493ccd-5924-5043-b1f5-66cb403b36ce

5 days ago[KERNEL32]
hbelusca [Sat, 22 Nov 2014 23:13:41 +0000 (23:13 +0000)]
- Fix a misspelling.

- Fix the prototypes of RtlFormatMessageEx(Ex), this fixes strange apps kills when they use FormatMessage[A/W] with win2k3 kernel32 (that uses internally RtlFormatMessage to do the job).

git-svn-id: file:///srv/svn/reactos/trunk@65450 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[KERNEL32][CONSRV]
hbelusca [Sat, 22 Nov 2014 22:13:08 +0000 (22:13 +0000)]
- Remove the USE_CONSOLE_INIT_HANDLES define since now we "support" the console initialization events.
- The events in the CONSOLE_START_INFO structure are console initialization events used for asynchronous console creation, that are set whenever console creation succeeds, or fails.
- Stubplement their usage in CONSRV.

Now we are able to fully use Windows 2k3 kernel32.dll and be able to run console programs with it.

git-svn-id: file:///srv/svn/reactos/trunk@65449 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[NTVDM]:
hbelusca [Sat, 22 Nov 2014 19:18:23 +0000 (19:18 +0000)]
- INT 15h offers some "OS hooks" that do nothing normally but return success.
- Stub "Switch to protected mode" INT 15h AH=89h function.

git-svn-id: file:///srv/svn/reactos/trunk@65448 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[FAST486]
aandrejevic [Sat, 22 Nov 2014 16:33:47 +0000 (16:33 +0000)]
- Fix interrupts in V86 mode.
- CLI and STI should call Fast486GetCurrentPrivLevel in their IOPL check, since it
  always returns 3 if the VM flag is set.

git-svn-id: file:///srv/svn/reactos/trunk@65447 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[FAST486]: Fix a comment and use the TOGGLE_OPSIZE macro.
hbelusca [Sat, 22 Nov 2014 16:23:59 +0000 (16:23 +0000)]
[FAST486]: Fix a comment and use the TOGGLE_OPSIZE macro.

git-svn-id: file:///srv/svn/reactos/trunk@65446 97493ccd-5924-5043-b1f5-66cb403b36ce

6 days ago[WIN32K]
tkreuzer [Sat, 22 Nov 2014 09:07:33 +0000 (09:07 +0000)]
- In XFORMOBJ_bApplyXform do not overwrite the data in the input buffer
- Make XFORMOBJ_bXformFixPoints return VOID instead of BOOL

git-svn-id: file:///srv/svn/reactos/trunk@65445 97493ccd-5924-5043-b1f5-66cb403b36ce

akhaldi [Fri, 21 Nov 2014 18:57:46 +0000 (18:57 +0000)]
* Reactos/ReactOs => ReactOS.

git-svn-id: file:///srv/svn/reactos/trunk@65444 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTOS:PNPMGR]
akhaldi [Fri, 21 Nov 2014 18:45:18 +0000 (18:45 +0000)]
* Attempt to address Timo's review about coding style changes.

git-svn-id: file:///srv/svn/reactos/trunk@65443 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM:DOS]: Don't forget to update CommandInfo.Env otherwise we would use the old...
hbelusca [Fri, 21 Nov 2014 15:55:39 +0000 (15:55 +0000)]
[NTVDM:DOS]: Don't forget to update CommandInfo.Env otherwise we would use the old environment buffer that is now invalid, hence corrupting the heap and doing other nasty things :P Debugged by V.

git-svn-id: file:///srv/svn/reactos/trunk@65442 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[FAST486]
aandrejevic [Fri, 21 Nov 2014 09:46:57 +0000 (09:46 +0000)]
Attempt to write the value to the stack before subtracting from the actual ESP register
in Fast486StackPush.

git-svn-id: file:///srv/svn/reactos/trunk@65441 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NtUser]
jimtabor [Fri, 21 Nov 2014 03:15:27 +0000 (03:15 +0000)]
- Synchronize mouse messages. Best way to do this, just post the move message while it occurs and just update it with recurrent information. The other way was to check time stamps and that was a hackish headache. Then the scorn and reticule would erupt. So it was easier to just post to the queue, update and if a mouse down up was captured than it would be in the order as it was received.
- See CORE-8779 #resolve, CORE-8394, CORE-7797, CORE-7447.

git-svn-id: file:///srv/svn/reactos/trunk@65440 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[URTL]: Fix whitespace plus misspelling.
hbelusca [Fri, 21 Nov 2014 02:35:38 +0000 (02:35 +0000)]
[URTL]: Fix whitespace plus misspelling.

git-svn-id: file:///srv/svn/reactos/trunk@65439 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM]: Make the environment strings list optional for some Dos app start functions.
hbelusca [Fri, 21 Nov 2014 02:26:53 +0000 (02:26 +0000)]
[NTVDM]: Make the environment strings list optional for some Dos app start functions.

git-svn-id: file:///srv/svn/reactos/trunk@65438 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM]
hbelusca [Fri, 21 Nov 2014 00:22:48 +0000 (00:22 +0000)]
- Add stubs for VDDReserve/ReleaseIrqLine;
- Add stub implementation for Direct Memory Access;
- Add corresponding exports.

git-svn-id: file:///srv/svn/reactos/trunk@65437 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[DDK]
hbelusca [Fri, 21 Nov 2014 00:13:51 +0000 (00:13 +0000)]
Add few VDD API prototypes:
- VDDReserve/ReleaseIrqLine to get a "lock" on an IRQ line (so that VDDs can check whether some IRQs are free or not).
- Add DMA services.

git-svn-id: file:///srv/svn/reactos/trunk@65436 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM]: Temporarily disable the mouse driver since mouse still doesn't fully work.
hbelusca [Fri, 21 Nov 2014 00:11:53 +0000 (00:11 +0000)]
[NTVDM]: Temporarily disable the mouse driver since mouse still doesn't fully work.

git-svn-id: file:///srv/svn/reactos/trunk@65435 97493ccd-5924-5043-b1f5-66cb403b36ce

7 days ago[NTVDM]: Static'ify some local vars & functions.
hbelusca [Fri, 21 Nov 2014 00:11:11 +0000 (00:11 +0000)]
[NTVDM]: Static'ify some local vars & functions.

git-svn-id: file:///srv/svn/reactos/trunk@65434 97493ccd-5924-5043-b1f5-66cb403b36ce

8 days ago[NET]
spetreolle [Thu, 20 Nov 2014 22:05:58 +0000 (22:05 +0000)]
Update spanish localization.
Patch by swyter.
CORE-8817 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@65433 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[NtUser]
jimtabor [Wed, 19 Nov 2014 06:05:39 +0000 (06:05 +0000)]
- Remove over compensating code. See CORE-7447.

git-svn-id: file:///srv/svn/reactos/trunk@65432 97493ccd-5924-5043-b1f5-66cb403b36ce

9 days ago[NtUser]
jimtabor [Wed, 19 Nov 2014 05:35:33 +0000 (05:35 +0000)]
- Fix Process Explorer crash in Win32k. See CORE-8779 and CORE-7447.

git-svn-id: file:///srv/svn/reactos/trunk@65431 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[NTVDM]
hbelusca [Tue, 18 Nov 2014 02:18:18 +0000 (02:18 +0000)]
Code organization:
- Create directory hardware/video where to put all video emulation (VGA currently, and maybe other things in the future);
- Create directory hardware/sound where to put all sound emulation (PC speaker currently, and maybe other things in the future);
- timer.c/h --> pit.c/h;
- Adjust the necessary includes and the cmakefiles;
- Remove unneeded includes;
- NTVDM is allowed to have its own VS project ^^

git-svn-id: file:///srv/svn/reactos/trunk@65430 97493ccd-5924-5043-b1f5-66cb403b36ce

10 days ago[NTVDM]: Inline a function and fix spelling.
hbelusca [Tue, 18 Nov 2014 00:44:24 +0000 (00:44 +0000)]
[NTVDM]: Inline a function and fix spelling.

git-svn-id: file:///srv/svn/reactos/trunk@65429 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[RAPPS]
akhaldi [Mon, 17 Nov 2014 16:33:45 +0000 (16:33 +0000)]
* Licence => License.
CORE-8804 #resolve #comment Committed in r65428. Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@65428 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[NTVDM]
hbelusca [Mon, 17 Nov 2014 02:08:12 +0000 (02:08 +0000)]
- Remove unneeded commented code;
- Fix few things related to committing the reserved low-memory VDM page by kernel32;
- Decommit this memory when we terminate NTVDM.

git-svn-id: file:///srv/svn/reactos/trunk@65426 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[NTVDM]: Use the ScreenMode variable in other places too...
hbelusca [Mon, 17 Nov 2014 00:34:29 +0000 (00:34 +0000)]
[NTVDM]: Use the ScreenMode variable in other places too...

git-svn-id: file:///srv/svn/reactos/trunk@65425 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[NTVDM]
hbelusca [Mon, 17 Nov 2014 00:12:20 +0000 (00:12 +0000)]
- Do not recalculate at each refresh the new resolution that usually does not change (if it changes because of a modification of some VGA register, we detect that, and we change the vga mode). So keep the current resolution and use it in paint functions.
- Really reenter a new text/graphic mode when needed (ie. when alphanumeric bit and computed resolution change), this avoids useless console screenbuffers recreations (and flickering), things go faster, yet the VGA registers are still updated (as expected). See r65379, r65018 and r65015 for more details.

git-svn-id: file:///srv/svn/reactos/trunk@65424 97493ccd-5924-5043-b1f5-66cb403b36ce

11 days ago[NTVDM]: Code formatting only!
hbelusca [Sun, 16 Nov 2014 23:15:12 +0000 (23:15 +0000)]
[NTVDM]: Code formatting only!

git-svn-id: file:///srv/svn/reactos/trunk@65423 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NTVDM]
hbelusca [Sun, 16 Nov 2014 22:19:32 +0000 (22:19 +0000)]
- Rename flags;
- Improve VgaUpdateTextCursor a bit (and fix a bug);
- Improve a DPRINT and monitor CGA ports (for debugging purposes);
- Code styling.

git-svn-id: file:///srv/svn/reactos/trunk@65422 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NTVDM]
hbelusca [Sun, 16 Nov 2014 16:01:09 +0000 (16:01 +0000)]
- Remove some old comments (and commented DPRINTs);
- More support for Bda->VGAOptions;
- Improve implementation of VidBiosSetCursorShape (start some cursor emulation, and add a note about it);
- Implement few "Alternate Function Select" subfunctions.

git-svn-id: file:///srv/svn/reactos/trunk@65421 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[WIN32K]
tkreuzer [Sun, 16 Nov 2014 14:22:54 +0000 (14:22 +0000)]
Copy only the actual size of the BITMAPINFO back to usermode in NtGdiGetDIBitsInternal.

git-svn-id: file:///srv/svn/reactos/trunk@65420 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[LIBS]
tkreuzer [Sun, 16 Nov 2014 14:07:37 +0000 (14:07 +0000)]
Remove some explicit comparisons with TRUE and make desired explicit comparison more obvious.
Patch by Love Nystrom, modified by me. Fixes a bug in RtlUpcaseUnicodeString. Not committed: modifications to freetype, since this is 3rd party code.

git-svn-id: file:///srv/svn/reactos/trunk@65419 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NET]
ekohl [Sun, 16 Nov 2014 10:34:49 +0000 (10:34 +0000)]
Replace remaining hard coded 'padding' strings.

git-svn-id: file:///srv/svn/reactos/trunk@65418 97493ccd-5924-5043-b1f5-66cb403b36ce

12 days ago[NTOSKRNL]
tkreuzer [Sat, 15 Nov 2014 22:47:51 +0000 (22:47 +0000)]
Remove explicit comparisons with TRUE
Patch by Love Nystrom, adjusted by me

git-svn-id: file:///srv/svn/reactos/trunk@65416 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[NTVDM]: Fix various little things in the video BIOS (and fix some video mode registers).
hbelusca [Sat, 15 Nov 2014 16:14:04 +0000 (16:14 +0000)]
[NTVDM]: Fix various little things in the video BIOS (and fix some video mode registers).

git-svn-id: file:///srv/svn/reactos/trunk@65414 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days agoDeleting Old RAPPS's Readme Files And Adding New README File by Erdem Ersoy
dreimer [Sat, 15 Nov 2014 15:58:43 +0000 (15:58 +0000)]
Deleting Old RAPPS's Readme Files And Adding New README File by Erdem Ersoy
CORE-8503 #resolve #comment I have no problems with a translated readme file, but the line to the Wiki was added.

git-svn-id: file:///srv/svn/reactos/trunk@65413 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days agorapps: (for database) Many Improvements and Many Fixes by Erdem Ersoy
dreimer [Sat, 15 Nov 2014 15:46:30 +0000 (15:46 +0000)]
rapps: (for database) Many Improvements and Many Fixes by Erdem Ersoy
CORE-7710 #resolve #comment Committed again from the same CORE report. Note to my self, next time this thing is being reopened, I will set it to WONTFIX! Open a NEW REPORT!

git-svn-id: file:///srv/svn/reactos/trunk@65412 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days agoAdding New Apps for Rapps by Erdem Ersoy
dreimer [Sat, 15 Nov 2014 15:35:40 +0000 (15:35 +0000)]
Adding New Apps for Rapps by Erdem Ersoy
CORE-7493 #resolve #comment Added, but the more recent versions + changed the SF mirror to the generic one + skipped the translating of a application's english name. Thx

git-svn-id: file:///srv/svn/reactos/trunk@65411 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days agoAdd Inkscape to rapps by Ricardo Hanke
dreimer [Sat, 15 Nov 2014 15:33:13 +0000 (15:33 +0000)]
Add Inkscape to rapps by Ricardo Hanke
CORE-8604 #resolve #comment Added to rapps, thx for the prove that it works ^^

git-svn-id: file:///srv/svn/reactos/trunk@65410 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[ADVAPI32]
akhaldi [Sat, 15 Nov 2014 15:12:24 +0000 (15:12 +0000)]
* Update ConvertSecurityDescriptorToStringSecurityDescriptor{A,W}().

git-svn-id: file:///srv/svn/reactos/trunk@65409 97493ccd-5924-5043-b1f5-66cb403b36ce

13 days ago[MOUHID]
pschweitzer [Sat, 15 Nov 2014 13:41:24 +0000 (13:41 +0000)]
Remove redundant code in DriverEntry()

git-svn-id: file:///srv/svn/reactos/trunk@65408 97493ccd-5924-5043-b1f5-66cb403b36ce