reactos.git
13 min ago[WIN32K] master trunk
jgardou [Thu, 23 Oct 2014 09:52:57 +0000 (09:52 +0000)]
[WIN32K]
 - Call IntDestroyCurIconObject instead of explicitly destroying the handle.
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64915 97493ccd-5924-5043-b1f5-66cb403b36ce

33 min ago[WIN32K]
jgardou [Thu, 23 Oct 2014 09:32:46 +0000 (09:32 +0000)]
[WIN32K]
 - Reference cursor and icon objects when copying a class from one heap to another.
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64914 97493ccd-5924-5043-b1f5-66cb403b36ce

33 min ago[USER32]
jgardou [Thu, 23 Oct 2014 09:32:43 +0000 (09:32 +0000)]
[USER32]
 - Return the right value in CopyImage when copying cursors/icons
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64913 97493ccd-5924-5043-b1f5-66cb403b36ce

33 min ago[WIN32K]
jgardou [Thu, 23 Oct 2014 09:32:39 +0000 (09:32 +0000)]
[WIN32K]
 - Remove the cursor from the process cache when its handle is deleted, not after.
 - Do not return an invalid handle in NtUserSetCursor.
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64912 97493ccd-5924-5043-b1f5-66cb403b36ce

33 min ago[USER32]
jgardou [Thu, 23 Oct 2014 09:32:21 +0000 (09:32 +0000)]
[USER32]
 - Fix LookupIconIdFromDirectoryEx, returning 0 when no matching entry is found.
 - Fix error handling when opening a cursor file.
 - Various code beautification here and there
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64911 97493ccd-5924-5043-b1f5-66cb403b36ce

43 min ago[CRT/OLDNAMES]
tkreuzer [Thu, 23 Oct 2014 09:22:45 +0000 (09:22 +0000)]
[CRT/OLDNAMES]
Fix ARM build, patch by Yuntian Zhang with minor adjustment by me.
CORE-8666 #resolve #comment Committed in r64910, thanks!

git-svn-id: file:///srv/svn/reactos/trunk@64910 97493ccd-5924-5043-b1f5-66cb403b36ce

60 min ago[CRT]
tkreuzer [Thu, 23 Oct 2014 09:05:32 +0000 (09:05 +0000)]
[CRT]
Do not raise an exception in _invalid_parameter, which is only done in later MSVCRTs. Wine uses a symbolic constant (_MSVCR_VER) to handle this and other things and compiles their CRT code multiple times. As an alternative we could use a global version variable to avoid recompiling, once we implement other CRT dlls.
CORE-8670 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64909 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[I8042PRT]
khornicek [Wed, 22 Oct 2014 20:05:32 +0000 (20:05 +0000)]
[I8042PRT]
- check the right buffer's length
[WIN32K]
- simplify IntKeyboardUpdateLeds a bit and mind previous mode
- fixes keyboard indicators
CORE-8547

git-svn-id: file:///srv/svn/reactos/trunk@64908 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[RTL]
tfaber [Wed, 22 Oct 2014 19:40:13 +0000 (19:40 +0000)]
[RTL]
- Address a review comment by Timo -- use more explicit comparison

git-svn-id: file:///srv/svn/reactos/trunk@64907 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[NTOS:FORMATTING]
tfaber [Wed, 22 Oct 2014 19:34:46 +0000 (19:34 +0000)]
[NTOS:FORMATTING]
- Trip trailing whitespace in Io/Pnp

git-svn-id: file:///srv/svn/reactos/trunk@64906 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[XDK/DDK]
tkreuzer [Wed, 22 Oct 2014 19:30:27 +0000 (19:30 +0000)]
[XDK/DDK]
Improve debugprint in __assert_annotationA/W

git-svn-id: file:///srv/svn/reactos/trunk@64905 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[SERVMAN]
khornicek [Wed, 22 Oct 2014 19:28:33 +0000 (19:28 +0000)]
[SERVMAN]
- better fix for CDI 513719, LVText might not be null terminated - spotted by Timo

git-svn-id: file:///srv/svn/reactos/trunk@64904 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[NTOSKRNL]
tkreuzer [Wed, 22 Oct 2014 19:20:03 +0000 (19:20 +0000)]
[NTOSKRNL]
- Fix potential use-after-free CID 732509
- Fix buffer size in call to ObQueryNameString

git-svn-id: file:///srv/svn/reactos/trunk@64903 97493ccd-5924-5043-b1f5-66cb403b36ce

14 hours ago[NTOS:IO] Replace an error message by an assert
hpoussin [Wed, 22 Oct 2014 19:17:13 +0000 (19:17 +0000)]
[NTOS:IO] Replace an error message by an assert

This was expected to be done soon after r32518.

git-svn-id: file:///srv/svn/reactos/trunk@64902 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[ADVAPI32/CRED]
akhaldi [Wed, 22 Oct 2014 18:41:40 +0000 (18:41 +0000)]
[ADVAPI32/CRED]
* Sync with Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64901 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[ADVAPI32/CRYPT]
akhaldi [Wed, 22 Oct 2014 18:29:59 +0000 (18:29 +0000)]
[ADVAPI32/CRYPT]
* Sync with Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64900 97493ccd-5924-5043-b1f5-66cb403b36ce

15 hours ago[PSDK]
akhaldi [Wed, 22 Oct 2014 18:26:47 +0000 (18:26 +0000)]
[PSDK]
* Add missing PFE_IMPORT_FUNC and WriteEncryptedFileRaw.

git-svn-id: file:///srv/svn/reactos/trunk@64899 97493ccd-5924-5043-b1f5-66cb403b36ce

16 hours ago[KERNEL32]
akhaldi [Wed, 22 Oct 2014 18:05:36 +0000 (18:05 +0000)]
[KERNEL32]
* Zap szCountryListName.
* Comment out unused charset_names and strcpynAtoW.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64898 97493ccd-5924-5043-b1f5-66cb403b36ce

16 hours ago[KERNEL32]
akhaldi [Wed, 22 Oct 2014 17:58:58 +0000 (17:58 +0000)]
[KERNEL32]
* Sync GetStringTypeW with Wine 1.7.27.
* Allows more kernel32:locale tests to run.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64897 97493ccd-5924-5043-b1f5-66cb403b36ce

16 hours ago[KERNEL32]
akhaldi [Wed, 22 Oct 2014 17:52:18 +0000 (17:52 +0000)]
[KERNEL32]
* Sync LCMapString{A,W} with Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64896 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[CMAKE]
akhaldi [Wed, 22 Oct 2014 16:56:56 +0000 (16:56 +0000)]
[CMAKE]
* Allow the use of the LOCATION property with new CMake versions.

git-svn-id: file:///srv/svn/reactos/trunk@64894 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[TASKMGR]
akhaldi [Wed, 22 Oct 2014 16:51:25 +0000 (16:51 +0000)]
[TASKMGR]
* Minor style changes in wWinMain.

git-svn-id: file:///srv/svn/reactos/trunk@64893 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[KERNEL32]
akhaldi [Wed, 22 Oct 2014 16:43:19 +0000 (16:43 +0000)]
[KERNEL32]
* Zap NLS_RegEnumSubKey.

git-svn-id: file:///srv/svn/reactos/trunk@64892 97493ccd-5924-5043-b1f5-66cb403b36ce

17 hours ago[KERNEL32]
akhaldi [Wed, 22 Oct 2014 16:40:54 +0000 (16:40 +0000)]
[KERNEL32]
* Replace EnumSystemGeoID with the one from Wine 1.7.27.
* Fixes some kernel32:locale tests.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64891 97493ccd-5924-5043-b1f5-66cb403b36ce

18 hours ago[TASKMGR]
khornicek [Wed, 22 Oct 2014 16:01:24 +0000 (16:01 +0000)]
[TASKMGR]
- fix CIDs 731628 (unlikely buffer overrun), 500038 (dead code), 1101977 (unchecked return value)

git-svn-id: file:///srv/svn/reactos/trunk@64890 97493ccd-5924-5043-b1f5-66cb403b36ce

20 hours ago[NTOS:MM]
tfaber [Wed, 22 Oct 2014 13:26:50 +0000 (13:26 +0000)]
[NTOS:MM]
- Add a way to generate a pool tag from the calling driver name if none is specified. Disabled by default.

git-svn-id: file:///srv/svn/reactos/trunk@64889 97493ccd-5924-5043-b1f5-66cb403b36ce

20 hours ago[NTOS:MM]
tfaber [Wed, 22 Oct 2014 13:18:10 +0000 (13:18 +0000)]
[NTOS:MM]
- Add missing call to ExpSeedHotTags

git-svn-id: file:///srv/svn/reactos/trunk@64888 97493ccd-5924-5043-b1f5-66cb403b36ce

20 hours ago[NTOS:KE]
tfaber [Wed, 22 Oct 2014 13:13:31 +0000 (13:13 +0000)]
[NTOS:KE]
- Issue the appropriate bug check codes when faulting in special pool
CORE-8680

git-svn-id: file:///srv/svn/reactos/trunk@64887 97493ccd-5924-5043-b1f5-66cb403b36ce

21 hours ago[NTOS:MM]
tfaber [Wed, 22 Oct 2014 13:04:57 +0000 (13:04 +0000)]
[NTOS:MM]
Make special pool usable:
- Invalidate PTEs on free to catch use-after-free situations (and not confuse Mm)
- Fix pattern check not to look for more than 8 bits in a byte
- Enable POOL_FLAG_SPECIAL_POOL if special pool has been initialized
- Implement MmExpandSpecialPool
- Issue the correct SPECIAL_POOL_DETECTED_MEMORY_CORRUPTION bugcheck when problems are detected
- Magic values--
To enable special pool for a single tag, set a value for MmSpecialPoolTag in ntoskrnl/mm/ARM3/pool.c.
To enable it for more than one tag, set MmSpecialPoolTag and modify MmUseSpecialPool in ntoskrnl/mm/ARM3/special.c (e.g. to return TRUE independent of Tag).
CORE-8680 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64886 97493ccd-5924-5043-b1f5-66cb403b36ce

21 hours ago[NTOS:MM]
tfaber [Wed, 22 Oct 2014 12:29:31 +0000 (12:29 +0000)]
[NTOS:MM]
- Generate PAGE_FAULT_IN_NONPAGED_AREA bugcheck for PTEs that have their protection set to zero. This gives a more useful error description than the infamous 'TempPte.u.Long != 0' assertion*.
CORE-8679 #resolve

* and is also What Windows Does(TM)

git-svn-id: file:///srv/svn/reactos/trunk@64885 97493ccd-5924-5043-b1f5-66cb403b36ce

21 hours ago[MSCONFIG]
khornicek [Wed, 22 Oct 2014 12:13:40 +0000 (12:13 +0000)]
[MSCONFIG]
- fix CID 503793 (unlikely NULL pointer dereference), 514558 (check return value)

git-svn-id: file:///srv/svn/reactos/trunk@64884 97493ccd-5924-5043-b1f5-66cb403b36ce

35 hours ago[KERNEL32]
akhaldi [Tue, 21 Oct 2014 23:02:21 +0000 (23:02 +0000)]
[KERNEL32]
* Replace GetGeoInfo{A,W} with the ones from Wine 1.7.27.
* Fixes many kernel32:locale tests.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64883 97493ccd-5924-5043-b1f5-66cb403b36ce

35 hours ago[SERVMAN]
khornicek [Tue, 21 Oct 2014 22:58:23 +0000 (22:58 +0000)]
[SERVMAN]
- fix resource leaks CID 716292, 716293, 716294
- fix CID 716772 (double free), 513719 (wrong NULL check), 1206739 (cosmetic)
- make line endings CR LF when exporting the services list

git-svn-id: file:///srv/svn/reactos/trunk@64882 97493ccd-5924-5043-b1f5-66cb403b36ce

36 hours ago[FAST486]: Rename some 0F0x opcodes to "ExtOpcode..." to clarify what they are and...
hbelusca [Tue, 21 Oct 2014 21:18:23 +0000 (21:18 +0000)]
[FAST486]: Rename some 0F0x opcodes to "ExtOpcode..." to clarify what they are and where they are used.

git-svn-id: file:///srv/svn/reactos/trunk@64881 97493ccd-5924-5043-b1f5-66cb403b36ce

36 hours ago[USER32]
khornicek [Tue, 21 Oct 2014 21:08:51 +0000 (21:08 +0000)]
[USER32]
- fix CID 514402 (by Christoph)
[MMIXER]
- fix CID 503774, 715945, 511119
[WS2_32_NEW]
- fix a debug print

git-svn-id: file:///srv/svn/reactos/trunk@64880 97493ccd-5924-5043-b1f5-66cb403b36ce

38 hours ago[WIN32K]
jgardou [Tue, 21 Oct 2014 19:57:03 +0000 (19:57 +0000)]
[WIN32K]
 - Fix a few usages of UserSetCursor
 - Defer the actual freeing of cursor resources to when the object is freed for real.
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64879 97493ccd-5924-5043-b1f5-66cb403b36ce

38 hours ago[I_KNEW_IT]
jgardou [Tue, 21 Oct 2014 19:14:47 +0000 (19:14 +0000)]
[I_KNEW_IT]
 - InterlockedDecrement(JeromesBuildFailures)

git-svn-id: file:///srv/svn/reactos/trunk@64878 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[WIN32K]
jgardou [Tue, 21 Oct 2014 18:59:44 +0000 (18:59 +0000)]
[WIN32K]
 - "Convert" new cursor & icons implementation to the new user object handle manager.
 - Fix a few idiosyncracies in the way cursor handles are used (only with USE_NEW_CURSORICON_ENABLED)
[WIN32SS]
 - Storm out the flowers out of how classes use icon and cursor objects, with proper refcounting and all those joyous things.
Handles are for the powerless, kernel mode use pointers.
Only with USE_NEW_CURSORICON enabled (soon!)
CORE-7575

git-svn-id: file:///srv/svn/reactos/trunk@64877 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[WIN32K]
jgardou [Tue, 21 Oct 2014 18:59:39 +0000 (18:59 +0000)]
[WIN32K]
 - Use the first frame of an animated cursor in case we're trying to use one.

git-svn-id: file:///srv/svn/reactos/trunk@64876 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[WIN32K]
jgardou [Tue, 21 Oct 2014 18:59:34 +0000 (18:59 +0000)]
[WIN32K]
 - Refcount++ the process info when we're adding it to a cursor process list.
CORE-8661

git-svn-id: file:///srv/svn/reactos/trunk@64875 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[KERNEL32]
akhaldi [Tue, 21 Oct 2014 18:42:12 +0000 (18:42 +0000)]
[KERNEL32]
* Sync casemap.c with Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64874 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[IP]
akhaldi [Tue, 21 Oct 2014 18:39:22 +0000 (18:39 +0000)]
[IP]
* Zap tcp_state_str.

git-svn-id: file:///srv/svn/reactos/trunk@64873 97493ccd-5924-5043-b1f5-66cb403b36ce

39 hours ago[KERNEL32]
akhaldi [Tue, 21 Oct 2014 18:25:34 +0000 (18:25 +0000)]
[KERNEL32]
* Sync format_msg.c with Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64872 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[CMD]
khornicek [Tue, 21 Oct 2014 16:05:54 +0000 (16:05 +0000)]
[CMD]
- fix resource leaks CID 716324, 716323, 716322, 716321, 716320, 716319, 716318

git-svn-id: file:///srv/svn/reactos/trunk@64871 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[STRMBASE]
akhaldi [Tue, 21 Oct 2014 15:52:51 +0000 (15:52 +0000)]
[STRMBASE]
* Zap InputPin_Vtbl, OutputPin_Vtbl and impl_BaseInputPin_from_BasePin(). Already accepted upstream.

git-svn-id: file:///srv/svn/reactos/trunk@64870 97493ccd-5924-5043-b1f5-66cb403b36ce

42 hours ago[XCOPY_WINETEST]
akhaldi [Tue, 21 Oct 2014 15:50:16 +0000 (15:50 +0000)]
[XCOPY_WINETEST]
* Import from Wine 1.7.27.
CORE-8540

git-svn-id: file:///srv/svn/reactos/trunk@64869 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours ago[WIN32K]
tfaber [Tue, 21 Oct 2014 14:28:16 +0000 (14:28 +0000)]
[WIN32K]
- Fix DCE list entry handling
CORE-8669 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64868 97493ccd-5924-5043-b1f5-66cb403b36ce

43 hours ago[RTL]
tfaber [Tue, 21 Oct 2014 14:22:28 +0000 (14:22 +0000)]
[RTL]
- Fix a buffer overflow in RtlSetBits/RtlClearBits

git-svn-id: file:///srv/svn/reactos/trunk@64867 97493ccd-5924-5043-b1f5-66cb403b36ce

45 hours ago[WIN32K]
tfaber [Tue, 21 Oct 2014 12:43:15 +0000 (12:43 +0000)]
[WIN32K]
- Remove bug-hiding list macros that accept NULL in LIST_ENTRYs.
CORE-8668 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64865 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[WIN32K]
jgardou [Tue, 21 Oct 2014 10:45:55 +0000 (10:45 +0000)]
[WIN32K]
 - reference the current process info structure while we're leaving win32k.
The process can die anytime while we're not looking.
CORE-8663 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64863 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[WIN32K]
jgardou [Tue, 21 Oct 2014 10:45:49 +0000 (10:45 +0000)]
[WIN32K]
 - Avoid use after free in debug configuration
CORE-8661 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64862 97493ccd-5924-5043-b1f5-66cb403b36ce

47 hours ago[CMAKE]
jgardou [Tue, 21 Oct 2014 10:45:36 +0000 (10:45 +0000)]
[CMAKE]
 - link keyboard layout modules to gcc_ssp if the stack protector is enabled.

git-svn-id: file:///srv/svn/reactos/trunk@64861 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[User32]
jimtabor [Tue, 21 Oct 2014 03:13:21 +0000 (03:13 +0000)]
[User32]
- Remove code that breaks wine release 1.7.29 user32 input tests. Code was there since r2505.
- So due to this commit, over compensating hacks can break.

git-svn-id: file:///srv/svn/reactos/trunk@64860 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[Win32k]
jimtabor [Tue, 21 Oct 2014 03:02:07 +0000 (03:02 +0000)]
[Win32k]
- rpdeskParent can be NULL and should not be depended on! Fixes CORE-8665.

git-svn-id: file:///srv/svn/reactos/trunk@64859 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[UNIATA]
spetreolle [Mon, 20 Oct 2014 21:21:43 +0000 (21:21 +0000)]
[UNIATA]
Update to 0.45b1.
CORE-8280 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64856 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[UNIATA]
spetreolle [Mon, 20 Oct 2014 21:20:35 +0000 (21:20 +0000)]
[UNIATA]
Update to 0.45b.
CORE-8280

git-svn-id: file:///srv/svn/reactos/trunk@64855 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[KERNEL32]
pschweitzer [Mon, 20 Oct 2014 20:26:07 +0000 (20:26 +0000)]
[KERNEL32]
Don't care for the return value (yet?) of StringCbPrintfW. This fixes release build.

git-svn-id: file:///srv/svn/reactos/trunk@64853 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[NTVDM]: Now that HLT is implemented, use it in the INT32 handlers.
hbelusca [Mon, 20 Oct 2014 19:45:37 +0000 (19:45 +0000)]
[NTVDM]: Now that HLT is implemented, use it in the INT32 handlers.

git-svn-id: file:///srv/svn/reactos/trunk@64852 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[FAST486]
hbelusca [Mon, 20 Oct 2014 19:42:52 +0000 (19:42 +0000)]
[FAST486]
- Control register 0 is CR0: use FAST486_REG_CR0 instead of 0, as it is done in the rest of the code.
- Improve a if/else if control.
- Don't halt the processor in the middle of prefixes processing.

git-svn-id: file:///srv/svn/reactos/trunk@64851 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[STRMBASE]
akhaldi [Mon, 20 Oct 2014 17:38:06 +0000 (17:38 +0000)]
[STRMBASE]
* Zap TransformFilter_Vtbl. Already accepted upstream.

git-svn-id: file:///srv/svn/reactos/trunk@64850 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[CMAKE]
akhaldi [Mon, 20 Oct 2014 17:35:22 +0000 (17:35 +0000)]
[CMAKE]
* Use the x86 toolchain for host tools if the targeting platform is ARM. Brought to you by Yuntian Zhang.
CORE-7407 #resolve #comment Committed in r64849. Thanks!

git-svn-id: file:///srv/svn/reactos/trunk@64849 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[WIN32K]
khornicek [Mon, 20 Oct 2014 14:26:47 +0000 (14:26 +0000)]
[WIN32K]
- add a missing break and reshuffle the code a tiny bit to fix CIDs 514466 and 513487
- don't skip the terminating debug print for ft_glyph_format_bitmap

git-svn-id: file:///srv/svn/reactos/trunk@64847 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[devmgr]
cwittich [Mon, 20 Oct 2014 13:32:33 +0000 (13:32 +0000)]
[devmgr]
don't free stack memory with LocalFree
CID 1101901

git-svn-id: file:///srv/svn/reactos/trunk@64846 97493ccd-5924-5043-b1f5-66cb403b36ce

2 days ago[SETUPAPI]
khornicek [Mon, 20 Oct 2014 13:08:42 +0000 (13:08 +0000)]
[SETUPAPI]
- actually use the icon source we get from registry instead of loading all icons from setupapi itself
CORE-8614

git-svn-id: file:///srv/svn/reactos/trunk@64845 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[explorer]
cwittich [Mon, 20 Oct 2014 10:05:30 +0000 (10:05 +0000)]
[explorer]
DragQueryFile expects size in characters

git-svn-id: file:///srv/svn/reactos/trunk@64844 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
tfaber [Mon, 20 Oct 2014 09:31:50 +0000 (09:31 +0000)]
[FASTFAT]
- Move FCB list removal to vfatDelFCBFromTable, since vfatAddFCBToTable does the insert. Fixes list corruption in vfatUpdateFCB.

git-svn-id: file:///srv/svn/reactos/trunk@64843 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[cmd/help]
cwittich [Mon, 20 Oct 2014 09:21:08 +0000 (09:21 +0000)]
[cmd/help]
do not call wcslen on uninitialized variable

git-svn-id: file:///srv/svn/reactos/trunk@64842 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[cmd]
cwittich [Mon, 20 Oct 2014 08:47:57 +0000 (08:47 +0000)]
[cmd]
GetDateFormat expects size in characters

git-svn-id: file:///srv/svn/reactos/trunk@64841 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[KERNEL32]
tfaber [Mon, 20 Oct 2014 08:30:55 +0000 (08:30 +0000)]
[KERNEL32]
- Fix MSVC build

git-svn-id: file:///srv/svn/reactos/trunk@64840 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NPFS]
tfaber [Mon, 20 Oct 2014 08:08:50 +0000 (08:08 +0000)]
[NPFS]
- Correctly interpret SeCreateClientSecurity return value in NpInitializeSecurity
- Always charge quota when allocating client context
- Specify explicit 0 tag when freeing allocations with unknown pool tag
- Misc readability fixes

git-svn-id: file:///srv/svn/reactos/trunk@64839 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[AFD]
tfaber [Sun, 19 Oct 2014 22:12:06 +0000 (22:12 +0000)]
[AFD]
- Do not pass IO_STATUS_BLOCKs when creating IRPs for asynchronous use. Fixes a use-after-free where AfdCloseSocket would cancel IRPs without actually waiting for their completion, and proceed to free the FCB, which contained these IO_STATUS_BLOCKs.
Note that using TdiBuildInternalDeviceControlIrp for these requests is broken in the first place, since it is intended for synchronous requests and requires a guarantee about the calling thread's lifetime. These functions (and their completion routines) should use IoAllocateIrp/IoReuseIrp/IoFreeIrp instead. However this can be fixed later; the incredibly annoying nonpaged pool corruption due to this that has been around for 10 years should be fixed with this commit.
CORE-8640 #resolve

git-svn-id: file:///srv/svn/reactos/trunk@64838 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[videoprt]
cwittich [Sun, 19 Oct 2014 21:57:29 +0000 (21:57 +0000)]
[videoprt]
fix uninitialized variable usage in error case

git-svn-id: file:///srv/svn/reactos/trunk@64837 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FASTFAT]
pschweitzer [Sun, 19 Oct 2014 21:38:32 +0000 (21:38 +0000)]
[FASTFAT]
- Implement vfatPrepareTargetForRename() that prepares for renaming. It tries to open target and deletes it if it exists and if allowed. And then, it opens the parent directory.
- Implement VfatSetRenameInformation() that actually does the renaming (call as SetInformationFile). It handles cases we we have (or we don't have) TargetDirectory provided. It sends notifications as appropriated on demands.
- Implement vfatRenameEntry() that renames an entry in place. So far, it only supports FATX entries renaming. FAT entries are a bit more complex. It falls back to vfatMoveEntry() in later cases.
- Implement VfatMoveEntry() that will move an entry accross directories (or in place for FAT). Its principles are simple: it deletes the entry in old parent, and recreate it in new parent, keeping file metadata & data.
- Modify VfatDelEntry() and VfatAddEntry() so that they can handle deleting an entry without touching its data and adding an entry with an already provided FCB and thus use the given metadata.
- Implement vfatDelFCBFromTable() which is just old code moved to new routine to allow reuse. It deletes a FCB entry from hash table. Doesn't deal with references!
- Implement vfatMakeFullName() which is mostly old code moved to new routine to allow reuse. It allocates buffer and copy data for FCB full name.
- Implement vfatUpdateFCB() that will update a FCB with new names and parent. It will remove anything related to old name and will recreate using new data. It will adjust references count.
- Modify vfatMakeFCBFromDirEntry() so that it calls vfatMakeFullName().
- Modify vfatReleaseFCB() so that it calls vfatDelFCBFromTable().
- Revert VfatOpenFile() to its previous features.
- Modify VfatCreateFile() to reimplement support for SL_OPEN_TARGET_DIRECTORY. It is way less hackish than previously. It also properly opens parent now, by incrementing its handle count and by setting appropriate access rights.

[KERNEL32]
- Rewritten MoveFileWithProgressW() to implement all the missing features that are used in Windows 2k3 including links and reparse points.
- Implemented BasepMoveFileDelayed() to replace deprecated add_boot_rename_entry(). This functions is matching the features implemented in SMSS.
- Implemented BasepMoveFileCopyProgress() which is used in MoveFileWithProgressW().
- Stubbed BasepNotifyTrackingService() which is not use at the moment (FastFAT, even in Windows doesn't provide such feature).
- Reimplemented ReplaceFileA(), MoveFileWithProgressA() to quit Winisms and use our internal helpers.
- Make MoveFileX() use MoveFileWithProgressX() directly.
- Fixed a few prototypes.

TL;DR:
This (huge) commit implements file and directory renaming in FastFAT driver. This allows getting rid of old implementation in kernel32 where files were force copied.

A feature is still missing, but Jérôme should implement it anytime soon (he prototyped it already): moving directories across volumes. This requires some work in BasepCopyFileExW().

Kudos to all the devs who helped me on this: Christoph, Hervé, Jérôme, Thomas.
This finally allows killing CR-52... It was about time!

git-svn-id: file:///srv/svn/reactos/trunk@64836 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[regsrv32]
cwittich [Sun, 19 Oct 2014 21:30:26 +0000 (21:30 +0000)]
[regsrv32]
don't free hDll twice

git-svn-id: file:///srv/svn/reactos/trunk@64835 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NET]
ekohl [Sun, 19 Oct 2014 20:12:19 +0000 (20:12 +0000)]
[NET]
- Add the localgroup command. It does not work properly on ReactOS yet.
- Print a warning when the domain option of the accounts command is used.

git-svn-id: file:///srv/svn/reactos/trunk@64834 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 19 Oct 2014 20:12:14 +0000 (20:12 +0000)]
[NTFS]
Bugfixing... Part 9/X:
- Return the appropriate size for file size.
- Round the allocation to cluster size (as requested by the API).

This fixes metadata display when enumerating a directory in CMD.
What you get now: http://www.heisspiter.net/~Pierre/rostests/NTFS_listing_fixed.png

Time to fix all the rest!
D'oh!

git-svn-id: file:///srv/svn/reactos/trunk@64833 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 19 Oct 2014 19:48:52 +0000 (19:48 +0000)]
[NTFS]
Bugfixing... Part 8/X:
- Actually, the files timestamp are already stored in the correct format on-disk... I should have listened to Thomas...

This fixes incorrect dates display when enumerating a directory contents. My apologies Thomas :-(.
Last to fix: the file size which is broken.

git-svn-id: file:///srv/svn/reactos/trunk@64832 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTDLL_APITEST] Disable NtContinue test when runtime checks are enabled
tkreuzer [Sun, 19 Oct 2014 19:37:55 +0000 (19:37 +0000)]
[NTDLL_APITEST] Disable NtContinue test when runtime checks are enabled
[USER32_APITEST] Disable WndProc test when runtime checks are enabled
[KERNEL32_WINETEST] Zero initialize a buffer. This is necessary, since we fail all calls to GetVolumePathNamesForVolumeNameW and thus never get any data into the buffer, which can later result in a buffer-overrun, when doing a lstrlenW on it.

git-svn-id: file:///srv/svn/reactos/trunk@64831 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 19 Oct 2014 17:43:37 +0000 (17:43 +0000)]
[NTFS]
Bugfixing... Part 6/X:
- Properly return the size of the NTFS volume (and not a buggy size)
- Properly return the characteristics of the NTFS volume

git-svn-id: file:///srv/svn/reactos/trunk@64829 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTVDM]: fix MIPS count in cases display delays get longer than 1 sec...
hbelusca [Sun, 19 Oct 2014 17:24:57 +0000 (17:24 +0000)]
[NTVDM]: fix MIPS count in cases display delays get longer than 1 sec...

git-svn-id: file:///srv/svn/reactos/trunk@64828 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[USER32]
akhaldi [Sun, 19 Oct 2014 17:24:43 +0000 (17:24 +0000)]
[USER32]
* We're not using any debugging routines here.

git-svn-id: file:///srv/svn/reactos/trunk@64827 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[WIN32K]
tkreuzer [Sun, 19 Oct 2014 16:37:27 +0000 (16:37 +0000)]
[WIN32K]
Fix uninitialized variable use.

git-svn-id: file:///srv/svn/reactos/trunk@64826 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[NTFS]
pschweitzer [Sun, 19 Oct 2014 16:29:38 +0000 (16:29 +0000)]
[NTFS]
Bugfixing... Part 6/X:
- Properly compute file name length.

This makes directory enumeration return complete file/directory names.
Note that it's also possible to enumerate the files in open dialog of notepad (for instance :-))

Opening a subdirectory/file is broken though. To be investigated.

git-svn-id: file:///srv/svn/reactos/trunk@64825 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FAST486]
aandrejevic [Sun, 19 Oct 2014 15:02:37 +0000 (15:02 +0000)]
[FAST486]
The r64823 patch was not properly merged.

git-svn-id: file:///srv/svn/reactos/trunk@64824 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[FAST486]
aandrejevic [Sun, 19 Oct 2014 14:46:02 +0000 (14:46 +0000)]
[FAST486]
Implement the HLT instruction.
Remove the IdleCallback, since it's unused and probably won't be used.
(The load reduction will be implemented in NTVDM instead.)

git-svn-id: file:///srv/svn/reactos/trunk@64823 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[USER32]
tkreuzer [Sun, 19 Oct 2014 13:17:49 +0000 (13:17 +0000)]
[USER32]
Fix uninitialized variable use/warnings in
- RegisterClassExWOWW (found by MSVC runtime checks)
- IntDrawState (CID-514399)
- IntCallWindowProcA (CID-514389)
- IntCallWindowProcW (CID-414390)
- SendMessageA (CID-514392)
- SendMessageW (CID-514393)
- SendMessageTimeoutA (CID-514441)
- SendMessageCallbackA (CID-514442)
- SendNotifyMessageW (CID-514443)
- SendNotifyMessageA (CID-514444)
- User32CallWindowProcFromKernel (CID-514445)
- DesktopWndProcA (CID-716765)

git-svn-id: file:///srv/svn/reactos/trunk@64822 97493ccd-5924-5043-b1f5-66cb403b36ce

3 days ago[CRT]
tkreuzer [Sun, 19 Oct 2014 10:27:22 +0000 (10:27 +0000)]
[CRT]
Fix MSVC global constructor initialization.

git-svn-id: file:///srv/svn/reactos/trunk@64821 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days agoOk Arch, it's good to remove unuseful brackets, but don't exaggerate too much. Also...
hbelusca [Sun, 19 Oct 2014 00:05:18 +0000 (00:05 +0000)]
Ok Arch, it's good to remove unuseful brackets, but don't exaggerate too much. Also check how the RtlInsertAsLeft/RightChild macros are defined. Since MS don't use the nice do { ... } while(0) for them, you cannot just use the if (blah) foo(); else bar(); to do the job, but you need the extra-brackets. And you cannot just change the macros definitions to not "break" headers compatibility (or... idiocies).

git-svn-id: file:///srv/svn/reactos/trunk@64820 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days agoFix whitespace, and get rid of that sh*tty K&R style.
hbelusca [Sat, 18 Oct 2014 23:59:25 +0000 (23:59 +0000)]
Fix whitespace, and get rid of that sh*tty K&R style.

git-svn-id: file:///srv/svn/reactos/trunk@64819 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[RTL]
hbelusca [Sat, 18 Oct 2014 23:51:35 +0000 (23:51 +0000)]
[RTL]
Implement RtlDeleteNoSplay which is really just a copy/paste of RtlDelete, but without splaying the tree after deletion of the node. Needed by the filter driver fltmgr.sys. Dedicated to Mr. V ;)

git-svn-id: file:///srv/svn/reactos/trunk@64818 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CRT]
tkreuzer [Sat, 18 Oct 2014 21:38:07 +0000 (21:38 +0000)]
[CRT]
Implement __do_global_ctors for MSVC

git-svn-id: file:///srv/svn/reactos/trunk@64817 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[RunTmChk]
tkreuzer [Sat, 18 Oct 2014 21:22:52 +0000 (21:22 +0000)]
[RunTmChk]
- Implement _RTC_GetErrDesc, _RTC_SetErrorFuncW, add stubs for _RTC_NumErrors, _RTC_SetErrorType, _RTC_SetErrorFunc
- Implement _RTC_DefaultErrorFuncW which will be used, when no other error func was set
- Implement _RTC_InitBase, which will be called from _RTC_Initialize, and which in turn calls either _CRT_RTC_INITW, if CRT was linked, or a local _CRT_RTC_INITW0, which in turn will return the error function to use. This allows us to use a custom error function for all modules that link to (MSV)CRT. Only user32 does not really fit into here, since it uses the same startup code but does not link to MSVCRT.

[CRT]
- Call _RTC_Initialize from __main before initializing the global constructors, but fall back to a dummy _RTC_NoInitialize(), when RunTmChk.lib was not linked. Now we properly initialize both our own as well as MS RunTmChk lib.

git-svn-id: file:///srv/svn/reactos/trunk@64816 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FREELDR]
tkreuzer [Sat, 18 Oct 2014 21:12:12 +0000 (21:12 +0000)]
[FREELDR]
- Improve memory layout by moving the 32/64 bit stack to 0x7000-0xF000 and moving the BIOSCALLBUFFER up a bit. This gives us 56 KB additional space for freeldr itself. This allows to compile freeldr with /RTC1 (x86 only, the x64 version would get too big). And yes, it works.
- Implement FrLdrBugCheckWithMessage to get some useful messages on the screen and use it in MmCheckFreeldrImageFile
- Merge the .rtc section into the .text section, when we use RTC1
- Check the location of the Extended BIOS Data Area, add it to the memory descriptors and make sure we have enough space to put freeldr in. If the location of the EBDA is too low, print out a nice message on a blue screen :)

git-svn-id: file:///srv/svn/reactos/trunk@64815 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[ACPI] Fix some traces
hpoussin [Sat, 18 Oct 2014 21:09:31 +0000 (21:09 +0000)]
[ACPI] Fix some traces

git-svn-id: file:///srv/svn/reactos/trunk@64814 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CMLIB] Add an assert to track potential registry corruptions
hpoussin [Sat, 18 Oct 2014 21:08:40 +0000 (21:08 +0000)]
[CMLIB] Add an assert to track potential registry corruptions

git-svn-id: file:///srv/svn/reactos/trunk@64813 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[AMD64]
tkreuzer [Sat, 18 Oct 2014 21:01:17 +0000 (21:01 +0000)]
[AMD64]
Fix build

git-svn-id: file:///srv/svn/reactos/trunk@64812 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[FREELDR]
tkreuzer [Sat, 18 Oct 2014 19:01:53 +0000 (19:01 +0000)]
[FREELDR]
Apply proper indentation, no code change.

git-svn-id: file:///srv/svn/reactos/trunk@64811 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[USER32]
akhaldi [Sat, 18 Oct 2014 18:41:15 +0000 (18:41 +0000)]
[USER32]
* WINEMessageTypeNames is only used in a case wrapped inside #ifndef __REACTOS__.

git-svn-id: file:///srv/svn/reactos/trunk@64810 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[USER32]
akhaldi [Sat, 18 Oct 2014 18:37:28 +0000 (18:37 +0000)]
[USER32]
* We're not using any debugging routines here.

git-svn-id: file:///srv/svn/reactos/trunk@64809 97493ccd-5924-5043-b1f5-66cb403b36ce

4 days ago[CMAKE/MSVC]
akhaldi [Sat, 18 Oct 2014 14:45:02 +0000 (14:45 +0000)]
[CMAKE/MSVC]
* Rename the lib to runtmchk. Really.
CORE-8626

git-svn-id: file:///srv/svn/reactos/trunk@64808 97493ccd-5924-5043-b1f5-66cb403b36ce