[CMAKE] Elimitate the use of GCC and CLANG variables
Apply suggestions from code review Beautification and clarity Co-authored-by: Victor Perevertkin <victor@perevertkin.ru> Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
[CMAKE] Get rid of add_compile_flags Use add_compile_options and the like instead
[CMAKE] Remove obsolete 'CMAKE_CXX_COMPILER_VERSION' checks (#2981) Following upgrade to RosBE 2.2.0 support and GCC 8.4.
[CMAKE] Replace custom functions to built-in ones add_target_compile_definitions -> target_compile_definitions add_target_compile_flags -> target_compile_options add_target_include_directories -> target_include_directories
[LIBXSLT] Disable misleading-indentation warnings Fixes GCC 8 warning: dll/3rdparty/libxslt/security.c:358:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation] else ^~~~ dll/3rdparty/libxslt/security.c:365:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else' if (ret <= 0) { ^~
[CMAKE] Use modules instead of shared libraries There is no need to compile our DLLs as shared libraries since we are managing symbols exports and imports through spec files. On my system, this reduces the configure-time by a factor of two.
[LIBXSLT] Better highlight some ROS diffs. CORE-14291
[CMAKE/CLANG-CL] Silence some clang-cl warnings in consistency with our gcc build.
Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.