[NTOS:KD] Remove an unreachable "break;"
[reactos.git] / PULL_REQUEST_MANAGEMENT.md
1 # Rules for managing Pull Requests
3 For the sake of trying to maintain an acceptable number of open but idle PRs, the following rules should be considered:
4 - If a PR has at least one approval, it can be merged after 1 week of waiting for additional comments.
5 - If the change has at least 3 approvals or you consider it trivial enough, it may be merged right away.
6 - If a PR stays in "changes requested" for too long, and there is no indication from the author that they are working on it, it shall be closed.
7 - Rule of thumb: 2 weeks for a small PR. Can be longer if the PR is large.
8 - The PR can be reopened at any point, if you have additional comments, or new changes have been done.
9 - If you require a review from a particular person, assign the PR to that person. Don't just rely on the "review requested" feature of GitHub.
10 - Remember that PR labels exist. You can assign an appropriate label to a pull request to designate it's scope, grab additional attention or just for extra navigation possibilities.
11 - Don't feel obliged to comment everything you see, just for the sake of commenting. Be it on JIRA, GitHub, or even on IRC.
13 In addition, in order to avoid coming off as rude to helpful contributors, please refrain from:
14 - Asking the contributor to do unrelated work
15 - Closing without providing a reason
16 - Merging with the intention to rewrite that code soon after