/*
* PROJECT: ReactOS Kernel
* LICENSE: GPL - See COPYING in the top level directory
- * FILE: ntoskrnl/config/cmapi.c
+ * FILE: ntoskrnl/config/cmlazy.c
* PURPOSE: Configuration Manager - Internal Registry APIs
* PROGRAMMERS: Alex Ionescu (alex.ionescu@reactos.org)
*/
else
{
/* Do the sync */
- DPRINT1("Flushing: %wZ\n", &CmHive->FileFullPath);
- DPRINT1("Handle: %p\n", CmHive->FileHandles[HFILE_TYPE_PRIMARY]);
+ DPRINT("Flushing: %wZ\n", &CmHive->FileFullPath);
+ DPRINT("Handle: %p\n", CmHive->FileHandles[HFILE_TYPE_PRIMARY]);
Status = HvSyncHive(&CmHive->Hive);
if(!NT_SUCCESS(Status))
{
/* Let them know we failed */
+ DPRINT1("Failed to flush %wZ on handle %p (status 0x%08lx)\n",
+ &CmHive->FileFullPath, CmHive->FileHandles[HFILE_TYPE_PRIMARY], Status);
*Error = TRUE;
Result = FALSE;
break;
/* Testing: Force Lazy Flushing */
CmpHoldLazyFlush = FALSE;
- /* Setup the hive list */
- CmpInitializeHiveList(SetupBoot);
+ /* Setup the hive list if this is not a Setup boot */
+ if (!SetupBoot)
+ CmpInitializeHiveList();
}
NTSTATUS
OUT PCMHIVE *NewHive,
IN ULONG CheckFlags)
{
- PUNICODE_STRING FileName;
NTSTATUS Status;
+ UNICODE_STRING FileName;
+ PWCHAR FilePath;
+ UCHAR Buffer[sizeof(OBJECT_NAME_INFORMATION) + MAX_PATH * sizeof(WCHAR)];
+ ULONG Length = sizeof(Buffer);
+ POBJECT_NAME_INFORMATION FileNameInfo = (POBJECT_NAME_INFORMATION)Buffer;
+
PAGED_CODE();
+ if (FileAttributes->RootDirectory)
+ {
+ /*
+ * Validity check: The ObjectName is relative to RootDirectory,
+ * therefore it must not start with a path separator.
+ */
+ if (FileAttributes->ObjectName && FileAttributes->ObjectName->Buffer &&
+ FileAttributes->ObjectName->Length >= sizeof(WCHAR) &&
+ *FileAttributes->ObjectName->Buffer == OBJ_NAME_PATH_SEPARATOR)
+ {
+ return STATUS_OBJECT_PATH_SYNTAX_BAD;
+ }
+
+ /* Try to get the value */
+ Status = ZwQueryObject(FileAttributes->RootDirectory,
+ ObjectNameInformation,
+ FileNameInfo,
+ Length,
+ &Length);
+ if (!NT_SUCCESS(Status))
+ {
+ /* Fail */
+ DPRINT1("CmpCmdHiveOpen(): Root directory handle object name query failed, Status = 0x%08lx\n", Status);
+ return Status;
+ }
+
+ /* Null-terminate and add the length of the terminator */
+ Length -= sizeof(OBJECT_NAME_INFORMATION);
+ FilePath = FileNameInfo->Name.Buffer;
+ FilePath[Length / sizeof(WCHAR)] = UNICODE_NULL;
+ Length += sizeof(UNICODE_NULL);
+
+ /* Compute the size of the full path; Length already counts the terminating NULL */
+ Length = Length + sizeof(WCHAR) + FileAttributes->ObjectName->Length;
+ if (Length > MAXUSHORT)
+ {
+ /* Name size too long, bail out */
+ return STATUS_OBJECT_PATH_INVALID;
+ }
+
+ /* Build the full path */
+ RtlInitEmptyUnicodeString(&FileName, NULL, 0);
+ FileName.Buffer = ExAllocatePoolWithTag(PagedPool, Length, TAG_CM);
+ if (!FileName.Buffer)
+ {
+ /* Fail */
+ DPRINT1("CmpCmdHiveOpen(): Unable to allocate memory\n");
+ return STATUS_INSUFFICIENT_RESOURCES;
+ }
+ FileName.MaximumLength = Length;
+ RtlCopyUnicodeString(&FileName, &FileNameInfo->Name);
+
+ /*
+ * Append a path terminator if needed (we have already accounted
+ * for a possible extra one when allocating the buffer).
+ */
+ if (/* FileAttributes->ObjectName->Buffer[0] != OBJ_NAME_PATH_SEPARATOR && */ // We excluded ObjectName starting with a path separator above.
+ FileName.Length > 0 && FileName.Buffer[FileName.Length / sizeof(WCHAR) - 1] != OBJ_NAME_PATH_SEPARATOR)
+ {
+ /* ObjectName does not start with '\' and PathBuffer does not end with '\' */
+ FileName.Buffer[FileName.Length / sizeof(WCHAR)] = OBJ_NAME_PATH_SEPARATOR;
+ FileName.Length += sizeof(WCHAR);
+ FileName.Buffer[FileName.Length / sizeof(WCHAR)] = UNICODE_NULL;
+ }
+
+ /* Append the object name */
+ Status = RtlAppendUnicodeStringToString(&FileName, FileAttributes->ObjectName);
+ if (!NT_SUCCESS(Status))
+ {
+ /* Fail */
+ DPRINT1("CmpCmdHiveOpen(): RtlAppendUnicodeStringToString() failed, Status = 0x%08lx\n", Status);
+ ExFreePoolWithTag(FileName.Buffer, TAG_CM);
+ return Status;
+ }
+ }
+ else
+ {
+ FileName = *FileAttributes->ObjectName;
+ }
+
/* Open the file in the current security context */
- FileName = FileAttributes->ObjectName;
- Status = CmpInitHiveFromFile(FileName,
+ Status = CmpInitHiveFromFile(&FileName,
0,
NewHive,
Allocate,
if (NT_SUCCESS(Status))
{
/* Now try again */
- Status = CmpInitHiveFromFile(FileName,
+ Status = CmpInitHiveFromFile(&FileName,
0,
NewHive,
Allocate,
}
}
+ if (FileAttributes->RootDirectory)
+ {
+ ExFreePoolWithTag(FileName.Buffer, TAG_CM);
+ }
+
/* Return status of open attempt */
return Status;
}