# Show a note about ccache build
if(ENABLE_CCACHE)
message("-- Enabling ccache build - done")
+ set(CMAKE_C_USE_RESPONSE_FILE_FOR_INCLUDES OFF)
+ set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_INCLUDES OFF)
endif()
# PDB style debug info
set(SEPARATE_DBG FALSE)
endif()
+# Dwarf based builds (no rsym)
+if(CMAKE_BUILD_TYPE STREQUAL "Release")
+ set(NO_ROSSYM TRUE)
+elseif(NOT DEFINED NO_ROSSYM)
+ set(NO_ROSSYM FALSE)
+endif()
+
if(NOT DEFINED USE_PSEH3)
set(USE_PSEH3 1)
endif()
add_definitions(-D_USE_DUMMY_PSEH=1)
endif()
+if(STACK_PROTECTOR)
+ add_compile_flags(${MODULE} "-fstack-protector-all")
+endif()
+
# Compiler Core
add_compile_flags("-pipe -fms-extensions -fno-strict-aliasing")
+
+# Prevent GCC from searching any of the default directories
+add_compile_flags("-nostdinc")
+
if(GCC_VERSION VERSION_GREATER 4.7)
add_compile_flags("-mstackrealign")
endif()
if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
- add_compile_flags_language("-std=gnu89" "C")
- add_compile_flags("-Wno-microsoft")
+ add_compile_flags_language("-std=gnu89 -Wno-microsoft" "C")
+ set(CMAKE_LINK_DEF_FILE_FLAG "")
+ set(CMAKE_STATIC_LIBRARY_SUFFIX ".a")
+ set(CMAKE_LINK_LIBRARY_SUFFIX "")
+ set(CMAKE_CREATE_WIN32_EXE "")
+ set(CMAKE_C_COMPILE_OPTIONS_PIC "")
+ set(CMAKE_CXX_COMPILE_OPTIONS_PIC "")
+ set(CMAKE_C_COMPILE_OPTIONS_PIE "")
+ set(CMAKE_CXX_COMPILE_OPTIONS_PIE "")
+ set(CMAKE_SHARED_LIBRARY_C_FLAGS "")
+ set(CMAKE_SHARED_LIBRARY_CXX_FLAGS "")
+ set(CMAKE_ASM_FLAGS_DEBUG "")
+ set(CMAKE_C_FLAGS_DEBUG "")
+ set(CMAKE_CXX_FLAGS_DEBUG "")
+endif()
+
+if(DBG)
+ if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+ add_compile_flags_language("-Wold-style-declaration" "C")
+ endif()
+ add_compile_flags_language("-Wdeclaration-after-statement" "C")
endif()
add_compile_flags_language("-fno-rtti -fno-exceptions" "CXX")
string(REPLACE "/" "\\" REACTOS_SOURCE_DIR_NATIVE ${REACTOS_SOURCE_DIR})
endif()
-if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+if((NOT CMAKE_C_COMPILER_ID STREQUAL "Clang") AND (NOT SEPARATE_DBG))
add_compile_flags("-fdebug-prefix-map=\"${REACTOS_SOURCE_DIR_NATIVE}\"=ReactOS")
endif()
# Debugging
-if(SEPARATE_DBG)
- add_compile_flags("-gdwarf-2 -g2")
-else()
- add_compile_flags("-gdwarf-2 -gstrict-dwarf")
- if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
- add_compile_flags("-femit-struct-debug-detailed=none -feliminate-unused-debug-symbols")
+if(NOT CMAKE_BUILD_TYPE STREQUAL "Release")
+ if(SEPARATE_DBG)
+ add_compile_flags("-gdwarf-2 -ggdb")
+ else()
+ add_compile_flags("-gdwarf-2 -gstrict-dwarf")
+ if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+ add_compile_flags("-femit-struct-debug-detailed=none -feliminate-unused-debug-symbols")
+ endif()
endif()
endif()
endif()
# Warnings, errors
-add_compile_flags("-Werror -Wall -Wpointer-arith")
+if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
+ add_compile_flags("-Werror")
+endif()
+
+add_compile_flags("-Wall -Wpointer-arith")
add_compile_flags("-Wno-char-subscripts -Wno-multichar -Wno-unused-value")
if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
add_compile_flags("-Wno-maybe-uninitialized")
- add_compile_flags("-Wno-error=unused-but-set-variable")
endif()
-add_compile_flags("-Wno-error=narrowing")
-add_compile_flags("-Wtype-limits -Wno-error=type-limits")
-
if(ARCH STREQUAL "amd64")
add_compile_flags("-Wno-format")
elseif(ARCH STREQUAL "arm")
# Link-time code generation
if(LTCG)
- add_compile_flags("-flto -ffat-lto-objects")
+ add_compile_flags("-flto -fno-fat-lto-objects")
endif()
if(ARCH STREQUAL "i386")
add_definitions(-D_inline=__inline)
-# alternative arch name
+# Alternative arch name
if(ARCH STREQUAL "amd64")
set(ARCH2 x86_64)
else()
"<CMAKE_C_COMPILER> <CMAKE_SHARED_LIBRARY_C_FLAGS> <LINK_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS> -o <TARGET> <OBJECTS> <LINK_LIBRARIES>"
"${OBJCOPY} --only-keep-debug <TARGET> ${REACTOS_BINARY_DIR}/symbols/${SYMBOL_FILE}"
"${OBJCOPY} --strip-debug <TARGET>")
+elseif(NO_ROSSYM)
+ # Dwarf-based build
+ message(STATUS "Generating a dwarf-based build (no rsym)")
+ set(CMAKE_C_LINK_EXECUTABLE "<CMAKE_C_COMPILER> ${CMAKE_C_FLAGS} <CMAKE_C_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES>")
+ set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> ${CMAKE_CXX_FLAGS} <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES>")
+ set(CMAKE_C_CREATE_SHARED_LIBRARY "<CMAKE_C_COMPILER> ${CMAKE_C_FLAGS} <CMAKE_SHARED_LIBRARY_C_FLAGS> <LINK_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS> -o <TARGET> <OBJECTS> <LINK_LIBRARIES>")
+ set(CMAKE_CXX_CREATE_SHARED_LIBRARY "<CMAKE_CXX_COMPILER> ${CMAKE_CXX_FLAGS} <CMAKE_SHARED_LIBRARY_CXX_FLAGS> <LINK_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS> -o <TARGET> <OBJECTS> <LINK_LIBRARIES>")
+ set(CMAKE_RC_CREATE_SHARED_LIBRARY "<CMAKE_C_COMPILER> ${CMAKE_C_FLAGS} <CMAKE_SHARED_LIBRARY_C_FLAGS> <LINK_FLAGS> <CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS> -o <TARGET> <OBJECTS> <LINK_LIBRARIES>")
else()
# Normal rsym build
get_target_property(RSYM native-rsym IMPORTED_LOCATION_NOCONFIG)
add_target_link_flags(${MODULE} "-Wl,--wdmdriver")
endif()
endif()
+
+ if(STACK_PROTECTOR)
+ target_link_libraries(${MODULE} gcc_ssp)
+ endif()
endfunction()
function(add_delay_importlibs _module)
endif()
function(generate_import_lib _libname _dllname _spec_file)
- # generate the def for the import lib
+ # Generate the def for the import lib
add_custom_command(
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def
- COMMAND native-spec2def -n=${_dllname} -a=${ARCH2} --implib -d=${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file}
+ COMMAND native-spec2def -n=${_dllname} -a=${ARCH2} ${ARGN} --implib -d=${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file}
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} native-spec2def)
set_source_files_properties(${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def PROPERTIES EXTERNAL_OBJECT TRUE)
- #create normal importlib
+ # Create normal importlib
_add_library(${_libname} STATIC EXCLUDE_FROM_ALL ${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def)
set_target_properties(${_libname} PROPERTIES LINKER_LANGUAGE "IMPLIB" PREFIX "")
- #create delayed importlib
+ # Create delayed importlib
_add_library(${_libname}_delayed STATIC EXCLUDE_FROM_ALL ${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def)
set_target_properties(${_libname}_delayed PROPERTIES LINKER_LANGUAGE "IMPLIB_DELAYED" PREFIX "")
endfunction()
set(CMAKE_IMPLIB_CREATE_STATIC_LIBRARY "${CMAKE_DLLTOOL} --def <OBJECTS> --kill-at --output-lib=<TARGET>")
set(CMAKE_IMPLIB_DELAYED_CREATE_STATIC_LIBRARY "${CMAKE_DLLTOOL} --def <OBJECTS> --kill-at --output-delaylib=<TARGET>")
function(spec2def _dllname _spec_file)
- # do we also want to add importlib targets?
- if(${ARGC} GREATER 2)
- if(${ARGN} STREQUAL "ADD_IMPORTLIB")
- set(__add_importlib TRUE)
- else()
- message(FATAL_ERROR "Wrong argument passed to spec2def, ${ARGN}")
- endif()
- endif()
+
+ cmake_parse_arguments(__spec2def "ADD_IMPORTLIB;NO_PRIVATE_WARNINGS;WITH_RELAY" "" "" ${ARGN})
- # get library basename
+ # Get library basename
get_filename_component(_file ${_dllname} NAME_WE)
- # error out on anything else than spec
+ # Error out on anything else than spec
if(NOT ${_spec_file} MATCHES ".*\\.spec")
message(FATAL_ERROR "spec2def only takes spec files as input.")
endif()
- # generate exports def and stubs C file for the module
+ if (__spec2def_WITH_RELAY)
+ set(__with_relay_arg "--with-tracing")
+ endif()
+
+ # Generate exports def and C stubs file for the DLL
add_custom_command(
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_file}.def ${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c
- COMMAND native-spec2def -n=${_dllname} -a=${ARCH2} -d=${CMAKE_CURRENT_BINARY_DIR}/${_file}.def -s=${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file}
+ COMMAND native-spec2def -n=${_dllname} -a=${ARCH2} -d=${CMAKE_CURRENT_BINARY_DIR}/${_file}.def -s=${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c ${__with_relay_arg} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file}
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} native-spec2def)
- if(__add_importlib)
- generate_import_lib(lib${_file} ${_dllname} ${_spec_file})
+ if(__spec2def_ADD_IMPORTLIB)
+ set(_extraflags)
+ if(__spec2def_NO_PRIVATE_WARNINGS)
+ set(_extraflags --no-private-warnings)
+ endif()
+
+ generate_import_lib(lib${_file} ${_dllname} ${_spec_file} ${_extraflags})
endif()
endfunction()
set(COMMAND_MC ${CMAKE_MC_COMPILER} ${FLAG} -b ${CMAKE_CURRENT_SOURCE_DIR}/${FILE}.mc -r ${REACTOS_BINARY_DIR}/include/reactos -h ${REACTOS_BINARY_DIR}/include/reactos)
endmacro()
-#pseh lib, needed with mingw
+# PSEH lib, needed with mingw
set(PSEH_LIB "pseh")
# Macros
-if(PCH)
+if(PCH AND (NOT ENABLE_CCACHE) AND (NOT CMAKE_HOST_APPLE))
+ add_compile_flags("-Winvalid-pch -Werror=invalid-pch")
macro(add_pch _target _pch _sources)
# When including x.h GCC looks for x.h.gch first
set(_pch_final_name "${_target}_pch.h")
EXTERNAL_SOURCE TRUE
OBJECT_LOCATION ${_gch})
- if(ENABLE_CCACHE)
- set(_ccache_flag "-fpch-preprocess")
- endif()
-
# Include the gch in the specified source files, skipping the pch file itself
list(REMOVE_ITEM ${_sources} ${_pch})
foreach(_src ${${_sources}})
- set_property(SOURCE ${_src} APPEND_STRING PROPERTY COMPILE_FLAGS " ${_ccache_flag} -Winvalid-pch -Werror=invalid-pch -include ${_pch_final_name}")
+ set_property(SOURCE ${_src} APPEND_STRING PROPERTY COMPILE_FLAGS " ${_ccache_flag} -include ${CMAKE_CURRENT_BINARY_DIR}/${_pch_final_name}")
set_property(SOURCE ${_src} APPEND PROPERTY OBJECT_DEPENDS ${_gch})
endforeach()
endmacro()
add_custom_command(
OUTPUT ${_object_file}
- COMMAND ${CMAKE_ASM_COMPILER} -x assembler-with-cpp -o ${_object_file} -I${REACTOS_SOURCE_DIR}/include/asm -I${REACTOS_BINARY_DIR}/include/asm -D__ASM__ -c ${_asm_file}
+ COMMAND ${CMAKE_ASM_COMPILER} -x assembler-with-cpp -o ${_object_file} -I${REACTOS_SOURCE_DIR}/include/asm -I${REACTOS_BINARY_DIR}/include/asm -I${REACTOS_SOURCE_DIR}/boot/freeldr -D__ASM__ -c ${_asm_file}
DEPENDS ${_asm_file})
add_custom_command(
endfunction()
function(allow_warnings __module)
- add_target_compile_flags(${__module} "-Wno-error")
+ # We don't allow warnings in trunk, this needs to be reworked. See CORE-6959.
+ #add_target_compile_flags(${__module} "-Wno-error")
endfunction()
macro(add_asm_files _target)
list(APPEND ${_target} ${ARGN})
endmacro()
-