TRACE("SVCCTL_HANDLEA_bind() called\n");
- status = RpcStringBindingComposeA((UCHAR *)szMachineName,
+ status = RpcStringBindingComposeA(NULL,
(UCHAR *)"ncacn_np",
- NULL,
+ (UCHAR *)szMachineName,
(UCHAR *)"\\pipe\\ntsvcs",
NULL,
(UCHAR **)&pszStringBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcStringBindingCompose returned 0x%x\n", status);
return NULL;
/* Set the binding handle that will be used to bind to the server. */
status = RpcBindingFromStringBindingA(pszStringBinding,
&hBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcBindingFromStringBinding returned 0x%x\n", status);
}
status = RpcStringFreeA(&pszStringBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcStringFree returned 0x%x\n", status);
}
TRACE("SVCCTL_HANDLEA_unbind() called\n");
status = RpcBindingFree(&hBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcBindingFree returned 0x%x\n", status);
}
TRACE("SVCCTL_HANDLEW_bind() called\n");
- status = RpcStringBindingComposeW(szMachineName,
+ status = RpcStringBindingComposeW(NULL,
L"ncacn_np",
- NULL,
+ szMachineName,
L"\\pipe\\ntsvcs",
NULL,
&pszStringBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcStringBindingCompose returned 0x%x\n", status);
return NULL;
/* Set the binding handle that will be used to bind to the server. */
status = RpcBindingFromStringBindingW(pszStringBinding,
&hBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcBindingFromStringBinding returned 0x%x\n", status);
}
status = RpcStringFreeW(&pszStringBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcStringFree returned 0x%x\n", status);
}
TRACE("SVCCTL_HANDLEW_unbind() called\n");
status = RpcBindingFree(&hBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcBindingFree returned 0x%x\n", status);
}
L"\\pipe\\ntsvcs",
NULL,
&pszStringBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcStringBindingCompose returned 0x%x\n", status);
return NULL;
/* Set the binding handle that will be used to bind to the server. */
status = RpcBindingFromStringBindingW(pszStringBinding,
&hBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcBindingFromStringBinding returned 0x%x\n", status);
}
status = RpcStringFreeW(&pszStringBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcStringFree returned 0x%x\n", status);
}
TRACE("RPC_SERVICE_STATUS_HANDLE_unbind() called\n");
status = RpcBindingFree(&hBinding);
- if (status)
+ if (status != RPC_S_OK)
{
ERR("RpcBindingFree returned 0x%x\n", status);
}
{
switch (Status)
{
+ case RPC_S_INVALID_BINDING:
case RPC_X_SS_IN_NULL_CONTEXT:
return ERROR_INVALID_HANDLE;
- case RPC_X_NULL_REF_POINTER:
+ case RPC_X_ENUM_VALUE_OUT_OF_RANGE:
+ case RPC_X_BYTE_COUNT_TOO_SMALL:
return ERROR_INVALID_PARAMETER;
- case STATUS_ACCESS_VIOLATION:
+ case RPC_X_NULL_REF_POINTER:
return ERROR_INVALID_ADDRESS;
default:
{
case SERVICE_CONFIG_DESCRIPTION:
Info.psd = (LPSERVICE_DESCRIPTIONA)&lpInfo;
+ Info.lpDescription = ((LPSERVICE_DESCRIPTIONA)lpInfo)->lpDescription; //HACK
break;
case SERVICE_CONFIG_FAILURE_ACTIONS:
- Info.psfa = (LPSERVICE_FAILURE_ACTIONSA)&lpInfo;
+ Info.psfa = (LPSERVICE_FAILURE_ACTIONSA)lpInfo;
break;
default:
if (lpInfo == NULL)
return TRUE;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RChangeServiceConfig2A((SC_RPC_HANDLE)hService,
Info);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
switch (dwInfoLevel)
{
case SERVICE_CONFIG_DESCRIPTION:
- {
Info.psd = (LPSERVICE_DESCRIPTIONW)&lpInfo;
break;
- }
case SERVICE_CONFIG_FAILURE_ACTIONS:
Info.psfa = (LPSERVICE_FAILURE_ACTIONSW)&lpInfo;
if (lpInfo == NULL)
return TRUE;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RChangeServiceConfig2W((SC_RPC_HANDLE)hService,
Info);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
ChangeServiceConfigA(SC_HANDLE hService,
DWORD dwServiceType,
DWORD dwStartType,
/* FIXME: Encrypt the password */
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RChangeServiceConfigA((SC_RPC_HANDLE)hService,
0, /* FIXME: dwPasswordLength */
(LPSTR)lpDisplayName);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
ChangeServiceConfigW(SC_HANDLE hService,
DWORD dwServiceType,
DWORD dwStartType,
/* FIXME: Encrypt the password */
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RChangeServiceConfigW((SC_RPC_HANDLE)hService,
0, /* FIXME: dwPasswordLength */
(LPWSTR)lpDisplayName);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
CloseServiceHandle(SC_HANDLE hSCObject)
{
DWORD dwError;
TRACE("CloseServiceHandle() called\n");
- _SEH_TRY
+ if (!hSCObject)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RCloseServiceHandle((LPSC_RPC_HANDLE)&hSCObject);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
ControlService(SC_HANDLE hService,
DWORD dwControl,
LPSERVICE_STATUS lpServiceStatus)
TRACE("ControlService(%x, %x, %p)\n",
hService, dwControl, lpServiceStatus);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RControlService((SC_RPC_HANDLE)hService,
dwControl,
lpServiceStatus);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @unimplemented
*/
-BOOL STDCALL
+BOOL WINAPI
ControlServiceEx(IN SC_HANDLE hService,
IN DWORD dwControl,
IN DWORD dwInfoLevel,
*
* @implemented
*/
-SC_HANDLE STDCALL
+SC_HANDLE WINAPI
CreateServiceA(SC_HANDLE hSCManager,
LPCSTR lpServiceName,
LPCSTR lpDisplayName,
LPCSTR lpServiceStartName,
LPCSTR lpPassword)
{
- SC_HANDLE RetVal = NULL;
- LPWSTR lpServiceNameW = NULL;
- LPWSTR lpDisplayNameW = NULL;
- LPWSTR lpBinaryPathNameW = NULL;
- LPWSTR lpLoadOrderGroupW = NULL;
- LPWSTR lpDependenciesW = NULL;
- LPWSTR lpServiceStartNameW = NULL;
- LPWSTR lpPasswordW = NULL;
+ SC_HANDLE hService = NULL;
DWORD dwDependenciesLength = 0;
+ DWORD dwError;
DWORD dwLength;
- int len;
LPSTR lpStr;
- if (lpServiceName)
- {
- len = MultiByteToWideChar(CP_ACP, 0, lpServiceName, -1, NULL, 0);
- lpServiceNameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
- if (!lpServiceNameW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpServiceName, -1, lpServiceNameW, len);
- }
-
- if (lpDisplayName)
- {
- len = MultiByteToWideChar(CP_ACP, 0, lpDisplayName, -1, NULL, 0);
- lpDisplayNameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
- if (!lpDisplayNameW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpDisplayName, -1, lpDisplayNameW, len);
- }
-
- if (lpBinaryPathName)
- {
- len = MultiByteToWideChar(CP_ACP, 0, lpBinaryPathName, -1, NULL, 0);
- lpBinaryPathNameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
- if (!lpBinaryPathNameW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpBinaryPathName, -1, lpBinaryPathNameW, len);
- }
+ TRACE("CreateServiceA() called\n");
+ TRACE("%p %s %s\n", hSCManager,
+ lpServiceName, lpDisplayName);
- if (lpLoadOrderGroup)
+ if (!hSCManager)
{
- len = MultiByteToWideChar(CP_ACP, 0, lpLoadOrderGroup, -1, NULL, 0);
- lpLoadOrderGroupW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
- if (!lpLoadOrderGroupW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpLoadOrderGroup, -1, lpLoadOrderGroupW, len);
+ SetLastError(ERROR_INVALID_HANDLE);
+ return NULL;
}
- if (lpDependencies)
+ /* Calculate the Dependencies length*/
+ if (lpDependencies != NULL)
{
lpStr = (LPSTR)lpDependencies;
while (*lpStr)
lpStr = lpStr + dwLength;
}
dwDependenciesLength++;
-
- lpDependenciesW = HeapAlloc(GetProcessHeap(), 0, dwDependenciesLength * sizeof(WCHAR));
- if (!lpDependenciesW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpDependencies, dwDependenciesLength, lpDependenciesW, dwDependenciesLength);
}
- if (lpServiceStartName)
+ /* FIXME: Encrypt the password */
+
+ RpcTryExcept
{
- len = MultiByteToWideChar(CP_ACP, 0, lpServiceStartName, -1, NULL, 0);
- lpServiceStartNameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
- if (!lpServiceStartNameW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpServiceStartName, -1, lpServiceStartNameW, len);
+ /* Call to services.exe using RPC */
+ dwError = RCreateServiceA((SC_RPC_HANDLE)hSCManager,
+ (LPSTR)lpServiceName,
+ (LPSTR)lpDisplayName,
+ dwDesiredAccess,
+ dwServiceType,
+ dwStartType,
+ dwErrorControl,
+ (LPSTR)lpBinaryPathName,
+ (LPSTR)lpLoadOrderGroup,
+ lpdwTagId,
+ (LPBYTE)lpDependencies,
+ dwDependenciesLength,
+ (LPSTR)lpServiceStartName,
+ NULL, /* FIXME: lpPassword */
+ 0, /* FIXME: dwPasswordLength */
+ (SC_RPC_HANDLE *)&hService);
}
-
- if (lpPassword)
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
- len = MultiByteToWideChar(CP_ACP, 0, lpPassword, -1, NULL, 0);
- lpPasswordW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR));
- if (!lpPasswordW)
- {
- SetLastError(ERROR_NOT_ENOUGH_MEMORY);
- goto cleanup;
- }
- MultiByteToWideChar(CP_ACP, 0, lpPassword, -1, lpPasswordW, len);
+ dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
+ RpcEndExcept;
- RetVal = CreateServiceW(hSCManager,
- lpServiceNameW,
- lpDisplayNameW,
- dwDesiredAccess,
- dwServiceType,
- dwStartType,
- dwErrorControl,
- lpBinaryPathNameW,
- lpLoadOrderGroupW,
- lpdwTagId,
- lpDependenciesW,
- lpServiceStartNameW,
- lpPasswordW);
-
-cleanup:
- if (lpServiceNameW !=NULL)
- HeapFree(GetProcessHeap(), 0, lpServiceNameW);
-
- if (lpDisplayNameW != NULL)
- HeapFree(GetProcessHeap(), 0, lpDisplayNameW);
-
- if (lpBinaryPathNameW != NULL)
- HeapFree(GetProcessHeap(), 0, lpBinaryPathNameW);
-
- if (lpLoadOrderGroupW != NULL)
- HeapFree(GetProcessHeap(), 0, lpLoadOrderGroupW);
-
- if (lpDependenciesW != NULL)
- HeapFree(GetProcessHeap(), 0, lpDependenciesW);
-
- if (lpServiceStartNameW != NULL)
- HeapFree(GetProcessHeap(), 0, lpServiceStartNameW);
-
- if (lpPasswordW != NULL)
- HeapFree(GetProcessHeap(), 0, lpPasswordW);
+ if (dwError != ERROR_SUCCESS)
+ {
+ ERR("RCreateServiceA() failed (Error %lu)\n", dwError);
+ SetLastError(dwError);
+ return NULL;
+ }
- return RetVal;
+ return hService;
}
*
* @implemented
*/
-SC_HANDLE STDCALL
+SC_HANDLE WINAPI
CreateServiceW(SC_HANDLE hSCManager,
LPCWSTR lpServiceName,
LPCWSTR lpDisplayName,
LPWSTR lpStr;
TRACE("CreateServiceW() called\n");
+ TRACE("%p %S %S\n", hSCManager,
+ lpServiceName, lpDisplayName);
+
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return NULL;
+ }
/* Calculate the Dependencies length*/
if (lpDependencies != NULL)
/* FIXME: Encrypt the password */
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RCreateServiceW((SC_RPC_HANDLE)hSCManager,
- (LPWSTR)lpServiceName,
- (LPWSTR)lpDisplayName,
+ lpServiceName,
+ lpDisplayName,
dwDesiredAccess,
dwServiceType,
dwStartType,
dwErrorControl,
- (LPWSTR)lpBinaryPathName,
- (LPWSTR)lpLoadOrderGroup,
+ lpBinaryPathName,
+ lpLoadOrderGroup,
lpdwTagId,
(LPBYTE)lpDependencies,
dwDependenciesLength,
- (LPWSTR)lpServiceStartName,
+ lpServiceStartName,
NULL, /* FIXME: lpPassword */
0, /* FIXME: dwPasswordLength */
(SC_RPC_HANDLE *)&hService);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
DeleteService(SC_HANDLE hService)
{
DWORD dwError;
TRACE("DeleteService(%x)\n", hService);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RDeleteService((SC_RPC_HANDLE)hService);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
EnumDependentServicesA(SC_HANDLE hService,
DWORD dwServiceState,
LPENUM_SERVICE_STATUSA lpServices,
TRACE("EnumServicesStatusA() called\n");
- _SEH_TRY
+ RpcTryExcept
{
dwError = REnumDependentServicesA((SC_RPC_HANDLE)hService,
dwServiceState,
pcbBytesNeeded,
lpServicesReturned);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
EnumDependentServicesW(SC_HANDLE hService,
DWORD dwServiceState,
LPENUM_SERVICE_STATUSW lpServices,
TRACE("EnumServicesStatusW() called\n");
- _SEH_TRY
+ RpcTryExcept
{
dwError = REnumDependentServicesW((SC_RPC_HANDLE)hService,
dwServiceState,
pcbBytesNeeded,
lpServicesReturned);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
* @unimplemented
*/
BOOL
-STDCALL
+WINAPI
EnumServiceGroupW(
SC_HANDLE hSCManager,
DWORD dwServiceType,
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
EnumServicesStatusA(SC_HANDLE hSCManager,
DWORD dwServiceType,
DWORD dwServiceState,
TRACE("EnumServicesStatusA() called\n");
- _SEH_TRY
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
+ if (dwServiceType != SERVICE_DRIVER && dwServiceType != SERVICE_WIN32)
+ {
+ if (pcbBytesNeeded && lpServicesReturned)
+ {
+ *pcbBytesNeeded = 0;
+ *lpServicesReturned = 0;
+ }
+
+ SetLastError(ERROR_INVALID_PARAMETER);
+ return FALSE;
+ }
+
+ if (dwServiceState != SERVICE_ACTIVE && dwServiceState != SERVICE_INACTIVE && dwServiceState != SERVICE_STATE_ALL)
+ {
+ if (pcbBytesNeeded)
+ *pcbBytesNeeded = 0;
+
+ if (lpServicesReturned)
+ *lpServicesReturned = 0;
+
+ SetLastError(ERROR_INVALID_PARAMETER);
+ return FALSE;
+ }
+
+ if (!pcbBytesNeeded || !lpServicesReturned)
+ {
+ SetLastError(ERROR_INVALID_ADDRESS);
+ return FALSE;
+ }
+
+ if (!lpServices && cbBufSize != 0)
+ {
+ SetLastError(ERROR_INVALID_ADDRESS);
+ return FALSE;
+ }
+
+ RpcTryExcept
{
dwError = REnumServicesStatusA((SC_RPC_HANDLE)hSCManager,
dwServiceType,
lpServicesReturned,
lpResumeHandle);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
EnumServicesStatusW(SC_HANDLE hSCManager,
DWORD dwServiceType,
DWORD dwServiceState,
TRACE("EnumServicesStatusW() called\n");
- _SEH_TRY
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
+ RpcTryExcept
{
dwError = REnumServicesStatusW((SC_RPC_HANDLE)hSCManager,
dwServiceType,
lpServicesReturned,
lpResumeHandle);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
EnumServicesStatusExA(SC_HANDLE hSCManager,
SC_ENUM_TYPE InfoLevel,
DWORD dwServiceType,
TRACE("EnumServicesStatusExA() called\n");
- _SEH_TRY
+ if (InfoLevel != SC_ENUM_PROCESS_INFO)
+ {
+ SetLastError(ERROR_INVALID_LEVEL);
+ return FALSE;
+ }
+
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
+
+ RpcTryExcept
{
dwError = REnumServicesStatusExA((SC_RPC_HANDLE)hSCManager,
InfoLevel,
lpResumeHandle,
(LPSTR)pszGroupName);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError == ERROR_MORE_DATA)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
EnumServicesStatusExW(SC_HANDLE hSCManager,
SC_ENUM_TYPE InfoLevel,
DWORD dwServiceType,
TRACE("EnumServicesStatusExW() called\n");
- _SEH_TRY
+ RpcTryExcept
{
dwError = REnumServicesStatusExW((SC_RPC_HANDLE)hSCManager,
InfoLevel,
lpResumeHandle,
(LPWSTR)pszGroupName);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError == ERROR_MORE_DATA)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
GetServiceDisplayNameA(SC_HANDLE hSCManager,
LPCSTR lpServiceName,
LPSTR lpDisplayName,
DWORD dwError;
TRACE("GetServiceDisplayNameA() called\n");
+ TRACE("%p %s %p %p\n", hSCManager,
+ debugstr_a(lpServiceName), lpDisplayName, lpcchBuffer);
+
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
if (!lpDisplayName)
*lpcchBuffer = 0;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RGetServiceDisplayNameA((SC_RPC_HANDLE)hSCManager,
- (LPSTR)lpServiceName,
+ lpServiceName,
lpDisplayName,
lpcchBuffer);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
/* HACK: because of a problem with rpcrt4, rpcserver is hacked to return 6 for ERROR_SERVICE_DOES_NOT_EXIST */
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
GetServiceDisplayNameW(SC_HANDLE hSCManager,
LPCWSTR lpServiceName,
LPWSTR lpDisplayName,
TRACE("GetServiceDisplayNameW() called\n");
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
if (!lpDisplayName)
*lpcchBuffer = 0;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RGetServiceDisplayNameW((SC_RPC_HANDLE)hSCManager,
- (LPWSTR)lpServiceName,
+ lpServiceName,
lpDisplayName,
lpcchBuffer);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
GetServiceKeyNameA(SC_HANDLE hSCManager,
LPCSTR lpDisplayName,
LPSTR lpServiceName,
TRACE("GetServiceKeyNameA() called\n");
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
+ if (!lpDisplayName)
+ {
+ SetLastError(ERROR_INVALID_ADDRESS);
+
+ if (!lpServiceName)
+ *lpcchBuffer = 1;
+ return FALSE;
+ }
+
if (!lpServiceName)
*lpcchBuffer = 0;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RGetServiceKeyNameA((SC_RPC_HANDLE)hSCManager,
- (LPSTR)lpDisplayName,
+ lpDisplayName,
lpServiceName,
lpcchBuffer);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
GetServiceKeyNameW(SC_HANDLE hSCManager,
LPCWSTR lpDisplayName,
LPWSTR lpServiceName,
TRACE("GetServiceKeyNameW() called\n");
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
if (!lpDisplayName)
+ {
+ SetLastError(ERROR_INVALID_ADDRESS);
+
+ if (!lpServiceName)
+ *lpcchBuffer = 1;
+ return FALSE;
+ }
+
+ if (!lpServiceName)
*lpcchBuffer = 0;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RGetServiceKeyNameW((SC_RPC_HANDLE)hSCManager,
- (LPWSTR)lpDisplayName,
+ lpDisplayName,
lpServiceName,
lpcchBuffer);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-SC_LOCK STDCALL
+SC_LOCK WINAPI
LockServiceDatabase(SC_HANDLE hSCManager)
{
SC_LOCK hLock;
TRACE("LockServiceDatabase(%x)\n", hSCManager);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RLockServiceDatabase((SC_RPC_HANDLE)hSCManager,
(SC_RPC_LOCK *)&hLock);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-SC_HANDLE STDCALL
+SC_HANDLE WINAPI
OpenSCManagerA(LPCSTR lpMachineName,
LPCSTR lpDatabaseName,
DWORD dwDesiredAccess)
WaitForSCManager();
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = ROpenSCManagerA((LPSTR)lpMachineName,
dwDesiredAccess,
(SC_RPC_HANDLE *)&hScm);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-SC_HANDLE STDCALL
+SC_HANDLE WINAPI
OpenSCManagerW(LPCWSTR lpMachineName,
LPCWSTR lpDatabaseName,
DWORD dwDesiredAccess)
WaitForSCManager();
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = ROpenSCManagerW((LPWSTR)lpMachineName,
dwDesiredAccess,
(SC_RPC_HANDLE *)&hScm);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-SC_HANDLE STDCALL
+SC_HANDLE WINAPI
OpenServiceA(SC_HANDLE hSCManager,
LPCSTR lpServiceName,
DWORD dwDesiredAccess)
TRACE("OpenServiceA(%p, %s, %lx)\n",
hSCManager, lpServiceName, dwDesiredAccess);
- _SEH_TRY
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return NULL;
+ }
+
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = ROpenServiceA((SC_RPC_HANDLE)hSCManager,
dwDesiredAccess,
(SC_RPC_HANDLE *)&hService);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-SC_HANDLE STDCALL
+SC_HANDLE WINAPI
OpenServiceW(SC_HANDLE hSCManager,
LPCWSTR lpServiceName,
DWORD dwDesiredAccess)
TRACE("OpenServiceW(%p, %S, %lx)\n",
hSCManager, lpServiceName, dwDesiredAccess);
- _SEH_TRY
+ if (!hSCManager)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return NULL;
+ }
+
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = ROpenServiceW((SC_RPC_HANDLE)hSCManager,
dwDesiredAccess,
(SC_RPC_HANDLE *)&hService);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceConfigA(SC_HANDLE hService,
LPQUERY_SERVICE_CONFIGA lpServiceConfig,
DWORD cbBufSize,
TRACE("QueryServiceConfigA(%p, %p, %lu, %p)\n",
hService, lpServiceConfig, cbBufSize, pcbBytesNeeded);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceConfigA((SC_RPC_HANDLE)hService,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceConfigW(SC_HANDLE hService,
LPQUERY_SERVICE_CONFIGW lpServiceConfig,
DWORD cbBufSize,
TRACE("QueryServiceConfigW(%p, %p, %lu, %p)\n",
hService, lpServiceConfig, cbBufSize, pcbBytesNeeded);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceConfigW((SC_RPC_HANDLE)hService,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceConfig2A(SC_HANDLE hService,
DWORD dwInfoLevel,
LPBYTE lpBuffer,
{
DWORD dwError;
- TRACE("QueryServiceConfig2A(%p, %lu, %p, %lu, %p)\n",
+ DbgPrint("QueryServiceConfig2A(hService %p, dwInfoLevel %lu, lpBuffer %p, cbBufSize %lu, pcbBytesNeeded %p)\n",
hService, dwInfoLevel, lpBuffer, cbBufSize, pcbBytesNeeded);
if (dwInfoLevel != SERVICE_CONFIG_DESCRIPTION &&
return FALSE;
}
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceConfig2A((SC_RPC_HANDLE)hService,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceConfig2W(SC_HANDLE hService,
DWORD dwInfoLevel,
LPBYTE lpBuffer,
return FALSE;
}
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceConfig2W((SC_RPC_HANDLE)hService,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceLockStatusA(SC_HANDLE hSCManager,
LPQUERY_SERVICE_LOCK_STATUSA lpLockStatus,
DWORD cbBufSize,
TRACE("QueryServiceLockStatusA() called\n");
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceLockStatusA((SC_RPC_HANDLE)hSCManager,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceLockStatusW(SC_HANDLE hSCManager,
LPQUERY_SERVICE_LOCK_STATUSW lpLockStatus,
DWORD cbBufSize,
TRACE("QueryServiceLockStatusW() called\n");
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceLockStatusW((SC_RPC_HANDLE)hSCManager,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceObjectSecurity(SC_HANDLE hService,
SECURITY_INFORMATION dwSecurityInformation,
PSECURITY_DESCRIPTOR lpSecurityDescriptor,
TRACE("QueryServiceObjectSecurity(%p, %lu, %p)\n",
hService, dwSecurityInformation, lpSecurityDescriptor);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceObjectSecurity((SC_RPC_HANDLE)hService,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
SetServiceObjectSecurity(SC_HANDLE hService,
SECURITY_INFORMATION dwSecurityInformation,
PSECURITY_DESCRIPTOR lpSecurityDescriptor)
return FALSE;
}
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RSetServiceObjectSecurity((SC_RPC_HANDLE)hService,
(LPBYTE)SelfRelativeSD,
Length);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
HeapFree(GetProcessHeap(), 0, SelfRelativeSD);
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceStatus(SC_HANDLE hService,
LPSERVICE_STATUS lpServiceStatus)
{
TRACE("QueryServiceStatus(%p, %p)\n",
hService, lpServiceStatus);
- _SEH_TRY
+ if (!hService)
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return FALSE;
+ }
+
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceStatus((SC_RPC_HANDLE)hService,
lpServiceStatus);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
QueryServiceStatusEx(SC_HANDLE hService,
SC_STATUS_TYPE InfoLevel,
LPBYTE lpBuffer,
TRACE("QueryServiceStatusEx() called\n");
- _SEH_TRY
+ if (InfoLevel != SC_STATUS_PROCESS_INFO)
+ {
+ SetLastError(ERROR_INVALID_LEVEL);
+ return FALSE;
+ }
+
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RQueryServiceStatusEx((SC_RPC_HANDLE)hService,
cbBufSize,
pcbBytesNeeded);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
StartServiceA(SC_HANDLE hService,
DWORD dwNumServiceArgs,
LPCSTR *lpServiceArgVectors)
{
DWORD dwError;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RStartServiceA((SC_RPC_HANDLE)hService,
dwNumServiceArgs,
(LPSTRING_PTRSA)lpServiceArgVectors);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
StartServiceW(SC_HANDLE hService,
DWORD dwNumServiceArgs,
LPCWSTR *lpServiceArgVectors)
{
DWORD dwError;
- _SEH_TRY
+ RpcTryExcept
{
dwError = RStartServiceW((SC_RPC_HANDLE)hService,
dwNumServiceArgs,
(LPSTRING_PTRSW)lpServiceArgVectors);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
UnlockServiceDatabase(SC_LOCK ScLock)
{
DWORD dwError;
TRACE("UnlockServiceDatabase(%x)\n", ScLock);
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RUnlockServiceDatabase((LPSC_RPC_LOCK)&ScLock);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{
*
* @implemented
*/
-BOOL STDCALL
+BOOL WINAPI
NotifyBootConfigStatus(BOOL BootAcceptable)
{
DWORD dwError;
TRACE("NotifyBootConfigStatus()\n");
- _SEH_TRY
+ RpcTryExcept
{
/* Call to services.exe using RPC */
dwError = RNotifyBootConfigStatus(NULL,
BootAcceptable);
}
- _SEH_HANDLE
+ RpcExcept(EXCEPTION_EXECUTE_HANDLER)
{
dwError = ScmRpcStatusToWinError(RpcExceptionCode());
}
- _SEH_END;
+ RpcEndExcept;
if (dwError != ERROR_SUCCESS)
{