Patch by hardon. Properly handle 0 timeouts. Fixes bug 857.
[reactos.git] / reactos / drivers / net / afd / afd / select.c
index a0f0506..212afc3 100644 (file)
@@ -1,4 +1,4 @@
-/* $Id: select.c,v 1.9 2004/12/25 21:30:17 arty Exp $
+/* $Id$
  * COPYRIGHT:        See COPYING in the top level directory
  * PROJECT:          ReactOS kernel
  * FILE:             drivers/net/afd/afd/select.c
 #include "tdiconn.h"
 #include "debug.h"
 
-VOID CopyBackStatus( PAFD_HANDLE HandleArray,
+static VOID PrintEvents( ULONG Events ) {
+#if DBG
+    char *events_list[] = { "AFD_EVENT_RECEIVE",
+                            "AFD_EVENT_OOB_RECEIVE",
+                            "AFD_EVENT_SEND",
+                            "AFD_EVENT_DISCONNECT",
+                            "AFD_EVENT_ABORT",
+                            "AFD_EVENT_CLOSE",
+                            "AFD_EVENT_CONNECT",
+                            "AFD_EVENT_ACCEPT",
+                            "AFD_EVENT_CONNECT_FAIL",
+                            "AFD_EVENT_QOS",
+                            "AFD_EVENT_GROUP_QOS",
+                            NULL };
+    int i;
+
+    for( i = 0; events_list[i]; i++ )
+        if( Events & (1 << i) ) AFD_DbgPrint(MID_TRACE,("%s ", events_list[i] ));
+#endif
+}
+
+static VOID CopyBackStatus( PAFD_HANDLE HandleArray,
                     UINT HandleCount ) {
     UINT i;
-    
+
     for( i = 0; i < HandleCount; i++ ) {
        HandleArray[i].Events = HandleArray[i].Status;
        HandleArray[i].Status = 0;
     }
 }
 
-VOID ZeroEvents( PAFD_HANDLE HandleArray,
+static VOID ZeroEvents( PAFD_HANDLE HandleArray,
                 UINT HandleCount ) {
     UINT i;
-    
+
     for( i = 0; i < HandleCount; i++ )
        HandleArray[i].Status = 0;
 }
 
-VOID RemoveSelect( PAFD_ACTIVE_POLL Poll ) {
-    AFD_DbgPrint(MID_TRACE,("Called\n"));
-
-    RemoveEntryList( &Poll->ListEntry );
-    KeCancelTimer( &Poll->Timer );
-
-    ExFreePool( Poll );
-
-    AFD_DbgPrint(MID_TRACE,("Done\n"));
-}
 
-VOID SignalSocket( PAFD_ACTIVE_POLL Poll, PAFD_POLL_INFO PollReq, 
-                  NTSTATUS Status ) {
-    PIRP Irp = Poll->Irp;
+/* you must pass either Poll OR Irp */
+static VOID SignalSocket( 
+   PAFD_ACTIVE_POLL Poll OPTIONAL, 
+   PIRP _Irp OPTIONAL, 
+   PAFD_POLL_INFO PollReq,
+       NTSTATUS Status 
+   ) 
+{
+    UINT i;
+    PIRP Irp = _Irp ? _Irp : Poll->Irp;
     AFD_DbgPrint(MID_TRACE,("Called (Status %x)\n", Status));
-    Poll->Irp->IoStatus.Status = Status;
-    Poll->Irp->IoStatus.Information =
+    
+    if (Poll)
+    {
+       KeCancelTimer( &Poll->Timer );
+      RemoveEntryList( &Poll->ListEntry );
+      ExFreePool( Poll );
+   }
+    
+    Irp->IoStatus.Status = Status;
+    Irp->IoStatus.Information =
         FIELD_OFFSET(AFD_POLL_INFO, Handles) + sizeof(AFD_HANDLE) * PollReq->HandleCount;
     CopyBackStatus( PollReq->Handles,
                    PollReq->HandleCount );
+    for( i = 0; i < PollReq->HandleCount; i++ ) {
+        AFD_DbgPrint
+            (MAX_TRACE,
+             ("Handle(%x): Got %x,%x\n",
+              PollReq->Handles[i].Handle,
+              PollReq->Handles[i].Events,
+              PollReq->Handles[i].Status));
+    }
     UnlockHandles( AFD_HANDLES(PollReq), PollReq->HandleCount );
     AFD_DbgPrint(MID_TRACE,("Completing\n"));
     IoCompleteRequest( Irp, IO_NETWORK_INCREMENT );
-    RemoveEntryList( &Poll->ListEntry );
-    RemoveSelect( Poll );
     AFD_DbgPrint(MID_TRACE,("Done\n"));
 }
 
-VOID SelectTimeout( PKDPC Dpc,
+static VOID SelectTimeout( PKDPC Dpc,
                    PVOID DeferredContext,
                    PVOID SystemArgument1,
                    PVOID SystemArgument2 ) {
@@ -77,62 +109,73 @@ VOID SelectTimeout( PKDPC Dpc,
     ZeroEvents( PollReq->Handles, PollReq->HandleCount );
 
     KeAcquireSpinLock( &DeviceExt->Lock, &OldIrql );
-    SignalSocket( Poll, PollReq, STATUS_TIMEOUT );
+    SignalSocket( Poll, NULL, PollReq, STATUS_TIMEOUT );
     KeReleaseSpinLock( &DeviceExt->Lock, OldIrql );
 
     AFD_DbgPrint(MID_TRACE,("Timeout\n"));
 }
 
-VOID KillExclusiveSelects( PAFD_DEVICE_EXTENSION DeviceExt ) {
+VOID KillSelectsForFCB( PAFD_DEVICE_EXTENSION DeviceExt,
+                        PFILE_OBJECT FileObject,
+                        BOOLEAN OnlyExclusive ) {
     KIRQL OldIrql;
     PLIST_ENTRY ListEntry;
     PAFD_ACTIVE_POLL Poll;
     PIRP Irp;
     PAFD_POLL_INFO PollReq;
+    PAFD_HANDLE HandleArray;
+    UINT i;
+
+    AFD_DbgPrint(MID_TRACE,("Killing selects that refer to %x\n", FileObject));
 
     KeAcquireSpinLock( &DeviceExt->Lock, &OldIrql );
-    
-    for( ListEntry = DeviceExt->Polls.Flink;
-        ListEntry != &DeviceExt->Polls;
-        ListEntry = ListEntry->Flink ) {
+
+    ListEntry = DeviceExt->Polls.Flink;
+    while ( ListEntry != &DeviceExt->Polls ) {
        Poll = CONTAINING_RECORD(ListEntry, AFD_ACTIVE_POLL, ListEntry);
-       if( Poll->Exclusive ) {
-           Irp = Poll->Irp;
-           PollReq = Irp->AssociatedIrp.SystemBuffer;
-           ZeroEvents( PollReq->Handles, PollReq->HandleCount );
-           SignalSocket( Poll, PollReq, STATUS_CANCELLED );
+       ListEntry = ListEntry->Flink;
+        Irp = Poll->Irp;
+        PollReq = Irp->AssociatedIrp.SystemBuffer;
+        HandleArray = AFD_HANDLES(PollReq);
+
+        for( i = 0; i < PollReq->HandleCount; i++ ) {
+            AFD_DbgPrint(MAX_TRACE,("Req: %x, This %x\n",
+                                    HandleArray[i].Handle, FileObject));
+            if( (PVOID)HandleArray[i].Handle == FileObject &&
+                (!OnlyExclusive || (OnlyExclusive && Poll->Exclusive)) ) {
+                ZeroEvents( PollReq->Handles, PollReq->HandleCount );
+                SignalSocket( Poll, NULL, PollReq, STATUS_SUCCESS );
+            }
        }
     }
 
     KeReleaseSpinLock( &DeviceExt->Lock, OldIrql );
+
+    AFD_DbgPrint(MID_TRACE,("Done\n"));
 }
 
 NTSTATUS STDCALL
-AfdSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp, 
+AfdSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
           PIO_STACK_LOCATION IrpSp ) {
     NTSTATUS Status = STATUS_NO_MEMORY;
     PAFD_FCB FCB;
     PFILE_OBJECT FileObject;
     PAFD_POLL_INFO PollReq = Irp->AssociatedIrp.SystemBuffer;
     PAFD_DEVICE_EXTENSION DeviceExt = DeviceObject->DeviceExtension;
-    PAFD_ACTIVE_POLL Poll = NULL;
     UINT CopySize = IrpSp->Parameters.DeviceIoControl.InputBufferLength;
-    UINT AllocSize = 
+    UINT AllocSize =
        CopySize + sizeof(AFD_ACTIVE_POLL) - sizeof(AFD_POLL_INFO);
     KIRQL OldIrql;
     UINT i, Signalled = 0;
     ULONG Exclusive = PollReq->Exclusive;
 
-    AFD_DbgPrint(MID_TRACE,("Called (HandleCount %d Timeout %d)\n", 
+    AFD_DbgPrint(MID_TRACE,("Called (HandleCount %d Timeout %d)\n",
                            PollReq->HandleCount,
                            (INT)(PollReq->Timeout.QuadPart)));
 
     SET_AFD_HANDLES(PollReq,
                    LockHandles( PollReq->Handles, PollReq->HandleCount ));
 
-    if( Exclusive ) KillExclusiveSelects( DeviceExt );
-       
-
     if( !AFD_HANDLES(PollReq) ) {
        Irp->IoStatus.Status = STATUS_NO_MEMORY;
        Irp->IoStatus.Information = 0;
@@ -140,32 +183,27 @@ AfdSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
        return Irp->IoStatus.Status;
     }
 
+    if( Exclusive ) {
+        for( i = 0; i < PollReq->HandleCount; i++ ) {
+            if( !AFD_HANDLES(PollReq)[i].Handle ) continue;
+
+            KillSelectsForFCB( DeviceExt,
+                               (PFILE_OBJECT)AFD_HANDLES(PollReq)[i].Handle,
+                               TRUE );
+        }
+    }
+
     ZeroEvents( PollReq->Handles,
                PollReq->HandleCount );
 
-    Poll = ExAllocatePool( NonPagedPool, AllocSize );
-    
-    if( Poll ) {
-       Poll->Irp = Irp;
-       Poll->DeviceExt = DeviceExt;
-       Poll->Exclusive = Exclusive;
-
-       KeInitializeTimerEx( &Poll->Timer, NotificationTimer );
-       KeSetTimer( &Poll->Timer, PollReq->Timeout, &Poll->TimeoutDpc );
-
-       KeInitializeDpc( (PRKDPC)&Poll->TimeoutDpc, 
-                        (PKDEFERRED_ROUTINE)SelectTimeout,
-                        Poll );
-       
        KeAcquireSpinLock( &DeviceExt->Lock, &OldIrql );
-       InsertTailList( &DeviceExt->Polls, &Poll->ListEntry );
 
        for( i = 0; i < PollReq->HandleCount; i++ ) {
            if( !AFD_HANDLES(PollReq)[i].Handle ) continue;
-           
+
            FileObject = (PFILE_OBJECT)AFD_HANDLES(PollReq)[i].Handle;
            FCB = FileObject->FsContext;
-           
+
            if( (FCB->PollState & AFD_EVENT_CLOSE) ||
                (PollReq->Handles[i].Status & AFD_EVENT_CLOSE) ) {
                AFD_HANDLES(PollReq)[i].Handle = 0;
@@ -173,10 +211,14 @@ AfdSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
                PollReq->Handles[i].Status = AFD_EVENT_CLOSE;
                Signalled++;
            } else {
-               PollReq->Handles[i].Status = 
+                AFD_DbgPrint(MID_TRACE, ("AFD: Select Events: "));
+                PrintEvents( PollReq->Handles[i].Events );
+                AFD_DbgPrint(MID_TRACE,("\n"));
+
+               PollReq->Handles[i].Status =
                    PollReq->Handles[i].Events & FCB->PollState;
                if( PollReq->Handles[i].Status ) {
-                   AFD_DbgPrint(MID_TRACE,("Signalling %x with %x\n", 
+                   AFD_DbgPrint(MID_TRACE,("Signalling %x with %x\n",
                                            FCB, FCB->PollState));
                    Signalled++;
                }
@@ -186,14 +228,37 @@ AfdSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
        if( Signalled ) {
            Status = STATUS_SUCCESS;
            Irp->IoStatus.Status = Status;
-           SignalSocket( Poll, PollReq, Status );
+           SignalSocket( NULL, Irp, PollReq, Status );
        } else {
-           Status = STATUS_PENDING;
-           IoMarkIrpPending( Irp );
+      
+       PAFD_ACTIVE_POLL Poll = NULL;
+       
+       Poll = ExAllocatePool( NonPagedPool, AllocSize );
+       if (Poll){
+          Poll->Irp = Irp;
+          Poll->DeviceExt = DeviceExt;
+          Poll->Exclusive = Exclusive;
+
+          KeInitializeTimerEx( &Poll->Timer, NotificationTimer );
+
+          KeInitializeDpc( (PRKDPC)&Poll->TimeoutDpc,
+             (PKDEFERRED_ROUTINE)SelectTimeout,
+             Poll );
+          
+          InsertTailList( &DeviceExt->Polls, &Poll->ListEntry );
+
+          KeSetTimer( &Poll->Timer, PollReq->Timeout, &Poll->TimeoutDpc );
+
+          Status = STATUS_PENDING;
+          IoMarkIrpPending( Irp );
+       } else {
+          AFD_DbgPrint(MAX_TRACE, ("FIXME: do something with the IRP!\n"));
+          Status = STATUS_NO_MEMORY;
+       }
        }
 
        KeReleaseSpinLock( &DeviceExt->Lock, OldIrql );
-    } else Status = STATUS_NO_MEMORY;
 
     AFD_DbgPrint(MID_TRACE,("Returning %x\n", Status));
 
@@ -201,18 +266,18 @@ AfdSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
 }
 
 NTSTATUS STDCALL
-AfdEventSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp, 
+AfdEventSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
                PIO_STACK_LOCATION IrpSp ) {
     PFILE_OBJECT FileObject = IrpSp->FileObject;
     NTSTATUS Status = STATUS_NO_MEMORY;
-    PAFD_EVENT_SELECT_INFO EventSelectInfo = 
+    PAFD_EVENT_SELECT_INFO EventSelectInfo =
        (PAFD_EVENT_SELECT_INFO)LockRequest( Irp, IrpSp );
     PAFD_FCB FCB = FileObject->FsContext;
 
-    AFD_DbgPrint(MID_TRACE,("Called (Event %x Triggers %x)\n", 
+    AFD_DbgPrint(MID_TRACE,("Called (Event %x Triggers %x)\n",
                            EventSelectInfo->EventObject,
                            EventSelectInfo->Events));
-    
+
     if( !SocketAcquireStateLock( FCB ) ) {
        UnlockRequest( Irp, IrpSp );
        return LostSocket( Irp, FALSE );
@@ -230,14 +295,14 @@ AfdEventSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
                                            KernelMode,
                                            (PVOID *)&FCB->EventSelect,
                                            NULL );
-       
+
        if( !NT_SUCCESS(Status) )
            FCB->EventSelect = NULL;
        else
            FCB->EventSelectTriggers = EventSelectInfo->Events;
     } else /* Work done, cancelling select */
        Status = STATUS_SUCCESS;
-    
+
     AFD_DbgPrint(MID_TRACE,("Returning %x\n", Status));
 
     return UnlockAndMaybeComplete( FCB, STATUS_SUCCESS, Irp,
@@ -245,15 +310,15 @@ AfdEventSelect( PDEVICE_OBJECT DeviceObject, PIRP Irp,
 }
 
 NTSTATUS STDCALL
-AfdEnumEvents( PDEVICE_OBJECT DeviceObject, PIRP Irp, 
+AfdEnumEvents( PDEVICE_OBJECT DeviceObject, PIRP Irp,
               PIO_STACK_LOCATION IrpSp ) {
     PFILE_OBJECT FileObject = IrpSp->FileObject;
-    PAFD_ENUM_NETWORK_EVENTS_INFO EnumReq = 
+    PAFD_ENUM_NETWORK_EVENTS_INFO EnumReq =
        (PAFD_ENUM_NETWORK_EVENTS_INFO)LockRequest( Irp, IrpSp );
     PAFD_FCB FCB = FileObject->FsContext;
 
     AFD_DbgPrint(MID_TRACE,("Called (FCB %x)\n", FCB));
-    
+
     if( !SocketAcquireStateLock( FCB ) ) {
        UnlockRequest( Irp, IrpSp );
        return LostSocket( Irp, FALSE );
@@ -261,13 +326,13 @@ AfdEnumEvents( PDEVICE_OBJECT DeviceObject, PIRP Irp,
 
     EnumReq->PollEvents = FCB->PollState;
     RtlZeroMemory( EnumReq->EventStatus, sizeof(EnumReq->EventStatus) );
-    
+
     return UnlockAndMaybeComplete( FCB, STATUS_SUCCESS, Irp,
                                   0, NULL, TRUE );
 }
 
 /* * * NOTE ALWAYS CALLED AT DISPATCH_LEVEL * * */
-BOOLEAN UpdatePollWithFCB( PAFD_ACTIVE_POLL Poll, PFILE_OBJECT FileObject ) {
+static BOOLEAN UpdatePollWithFCB( PAFD_ACTIVE_POLL Poll, PFILE_OBJECT FileObject ) {
     UINT i;
     PAFD_FCB FCB;
     UINT Signalled = 0;
@@ -288,10 +353,10 @@ BOOLEAN UpdatePollWithFCB( PAFD_ACTIVE_POLL Poll, PFILE_OBJECT FileObject ) {
            PollReq->Handles[i].Status = AFD_EVENT_CLOSE;
            Signalled++;
        } else {
-           PollReq->Handles[i].Status = 
+           PollReq->Handles[i].Status =
                PollReq->Handles[i].Events & FCB->PollState;
            if( PollReq->Handles[i].Status ) {
-               AFD_DbgPrint(MID_TRACE,("Signalling %x with %x\n", 
+               AFD_DbgPrint(MID_TRACE,("Signalling %x with %x\n",
                                        FCB, FCB->PollState));
                Signalled++;
            }
@@ -309,9 +374,9 @@ VOID PollReeval( PAFD_DEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject ) {
     PAFD_POLL_INFO PollReq;
     PKEVENT EventSelect = NULL;
 
-    AFD_DbgPrint(MID_TRACE,("Called: DeviceExt %x FileObject %x\n", 
+    AFD_DbgPrint(MID_TRACE,("Called: DeviceExt %x FileObject %x\n",
                            DeviceExt, FileObject));
-    
+
     KeAcquireSpinLock( &DeviceExt->Lock, &OldIrql );
 
     /* Take care of any event select signalling */
@@ -320,7 +385,7 @@ VOID PollReeval( PAFD_DEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject ) {
     /* Not sure if i can do this at DISPATCH_LEVEL ... try it at passive */
     AFD_DbgPrint(MID_TRACE,("Current State: %x, Events Fired: %x, "
                            "Select Triggers %x\n",
-                           FCB->PollState, FCB->EventsFired, 
+                           FCB->PollState, FCB->EventsFired,
                            FCB->EventSelectTriggers));
     if( FCB->PollState & ~FCB->EventsFired & FCB->EventSelectTriggers ) {
        FCB->EventsFired |= FCB->PollState;
@@ -343,8 +408,8 @@ VOID PollReeval( PAFD_DEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject ) {
        if( UpdatePollWithFCB( Poll, FileObject ) ) {
            ThePollEnt = ThePollEnt->Flink;
            AFD_DbgPrint(MID_TRACE,("Signalling socket\n"));
-           SignalSocket( Poll, PollReq, STATUS_SUCCESS );
-       } else 
+           SignalSocket( Poll, NULL, PollReq, STATUS_SUCCESS );
+       } else
            ThePollEnt = ThePollEnt->Flink;
     }