/* Required for ERR_T to NTSTATUS translation in receive error handling */
NTSTATUS TCPTranslateError(const err_t err);
+void
+LibTCPDumpPcb(PVOID SocketContext)
+{
+ struct tcp_pcb *pcb = (struct tcp_pcb*)SocketContext;
+ unsigned int addr = ntohl(pcb->remote_ip.addr);
+
+ DbgPrint("\tState: %s\n", tcp_state_str[pcb->state]);
+ DbgPrint("\tRemote: (%d.%d.%d.%d, %d)\n",
+ (addr >> 24) & 0xFF,
+ (addr >> 16) & 0xFF,
+ (addr >> 8) & 0xFF,
+ addr & 0xFF,
+ pcb->remote_port);
+}
+
static
void
LibTCPEmptyQueue(PCONNECTION_ENDPOINT Connection)
Connection->ReceiveShutdown = TRUE;
Connection->ReceiveShutdownStatus = STATUS_SUCCESS;
- /* This code path executes for both remotely and locally initiated closures,
- * and we need to distinguish between them */
- if (Connection->SocketContext)
+ /* If we already did a send shutdown, we're in TIME_WAIT so we can't use this PCB anymore */
+ if (Connection->SendShutdown)
{
- /* Remotely initiated close */
- TCPRecvEventHandler(arg);
+ Connection->SocketContext = NULL;
+ tcp_arg(pcb, NULL);
}
- else
+
+ /* Indicate the graceful close event */
+ TCPRecvEventHandler(arg);
+
+ /* If the PCB is gone, clean up the connection */
+ if (Connection->SendShutdown)
{
- /* Locally initated close */
- TCPFinEventHandler(arg, ERR_CLSD);
+ TCPFinEventHandler(Connection, ERR_CLSD);
}
}
return ERR_OK;
}
+/* This function MUST return an error value that is not ERR_ABRT or ERR_OK if the connection
+ * is not accepted to avoid leaking the new PCB */
static
err_t
InternalAcceptEventHandler(void *arg, PTCP_PCB newpcb, const err_t err)
{
/* Make sure the socket didn't get closed */
if (!arg)
- return ERR_ABRT;
+ return ERR_CLSD;
TCPAcceptEventHandler(arg, newpcb);
if (newpcb->callback_arg)
return ERR_OK;
else
- return ERR_ABRT;
+ return ERR_CLSD;
}
static
InternalErrorEventHandler(void *arg, const err_t err)
{
PCONNECTION_ENDPOINT Connection = arg;
- KIRQL OldIrql;
/* Make sure the socket didn't get closed */
- if (!arg) return;
+ if (!arg || Connection->SocketContext == NULL) return;
- /* Check if data is left to be read */
- LockObject(Connection, &OldIrql);
- if (IsListEmpty(&Connection->PacketQueue))
- {
- UnlockObject(Connection, OldIrql);
-
- /* Deliver the error now */
- TCPFinEventHandler(arg, err);
- }
- else
- {
- UnlockObject(Connection, OldIrql);
+ /* The PCB is dead now */
+ Connection->SocketContext = NULL;
- /* Defer the error delivery until all data is gone */
- Connection->ReceiveShutdown = TRUE;
- Connection->ReceiveShutdownStatus = TCPTranslateError(err);
+ /* Give them one shot to receive the remaining data */
+ Connection->ReceiveShutdown = TRUE;
+ Connection->ReceiveShutdownStatus = TCPTranslateError(err);
+ TCPRecvEventHandler(Connection);
- TCPRecvEventHandler(arg);
- }
+ /* Terminate the connection */
+ TCPFinEventHandler(Connection, err);
}
static
goto done;
}
- if (pcb->state == CLOSE_WAIT)
- {
- /* This case actually results in a socket closure later (lwIP bug?) */
- msg->Input.Shutdown.Connection->SocketContext = NULL;
+ /* LwIP makes the (questionable) assumption that SHUTDOWN_RDWR is equivalent to tcp_close().
+ * This assumption holds even if the shutdown calls are done separately (even through multiple
+ * WinSock shutdown() calls). This assumption means that lwIP has the right to deallocate our
+ * PCB without telling us if we shutdown TX and RX. To avoid these problems, we'll clear the
+ * socket context if we have called shutdown for TX and RX.
+ */
+ if (msg->Input.Shutdown.shut_rx) {
+ msg->Output.Shutdown.Error = tcp_shutdown(pcb, TRUE, FALSE);
}
-
- msg->Output.Shutdown.Error = tcp_shutdown(pcb, msg->Input.Shutdown.shut_rx, msg->Input.Shutdown.shut_tx);
- if (msg->Output.Shutdown.Error)
- {
- msg->Input.Shutdown.Connection->SocketContext = pcb;
+ if (msg->Input.Shutdown.shut_tx) {
+ msg->Output.Shutdown.Error = tcp_shutdown(pcb, FALSE, TRUE);
}
- else
+
+ if (!msg->Output.Shutdown.Error)
{
if (msg->Input.Shutdown.shut_rx)
{
if (msg->Input.Shutdown.shut_tx)
msg->Input.Shutdown.Connection->SendShutdown = TRUE;
+
+ if (msg->Input.Shutdown.Connection->ReceiveShutdown &&
+ msg->Input.Shutdown.Connection->SendShutdown)
+ {
+ /* The PCB is not ours anymore */
+ msg->Input.Shutdown.Connection->SocketContext = NULL;
+ tcp_arg(pcb, NULL);
+ TCPFinEventHandler(msg->Input.Shutdown.Connection, ERR_CLSD);
+ }
}
done:
/* Empty the queue even if we're already "closed" */
LibTCPEmptyQueue(msg->Input.Close.Connection);
- if (!msg->Input.Close.Connection->SocketContext)
+ /* Check if we've already been closed */
+ if (msg->Input.Close.Connection->Closing)
{
msg->Output.Close.Error = ERR_OK;
goto done;
}
- /* Clear the PCB pointer */
- msg->Input.Close.Connection->SocketContext = NULL;
+ /* Enter "closing" mode if we're doing a normal close */
+ if (msg->Input.Close.Callback)
+ msg->Input.Close.Connection->Closing = TRUE;
- switch (pcb->state)
+ /* Check if the PCB was already "closed" but the client doesn't know it yet */
+ if (!msg->Input.Close.Connection->SocketContext)
{
- case CLOSED:
- case LISTEN:
- case SYN_SENT:
- msg->Output.Close.Error = tcp_close(pcb);
-
- if (!msg->Output.Close.Error && msg->Input.Close.Callback)
- TCPFinEventHandler(msg->Input.Close.Connection, ERR_CLSD);
- break;
+ msg->Output.Close.Error = ERR_OK;
+ goto done;
+ }
- default:
- if (msg->Input.Close.Connection->SendShutdown &&
- msg->Input.Close.Connection->ReceiveShutdown)
- {
- /* Abort the connection */
- tcp_abort(pcb);
+ /* Clear the PCB pointer and stop callbacks */
+ msg->Input.Close.Connection->SocketContext = NULL;
+ tcp_arg(pcb, NULL);
- /* Aborts always succeed */
- msg->Output.Close.Error = ERR_OK;
- }
- else
- {
- /* Start the graceful close process (or send RST for pending data) */
- msg->Output.Close.Error = tcp_close(pcb);
- }
- break;
- }
+ /* This may generate additional callbacks but we don't care,
+ * because they're too inconsistent to rely on */
+ msg->Output.Close.Error = tcp_close(pcb);
if (msg->Output.Close.Error)
{
/* Restore the PCB pointer */
msg->Input.Close.Connection->SocketContext = pcb;
+ msg->Input.Close.Connection->Closing = FALSE;
+ }
+ else if (msg->Input.Close.Callback)
+ {
+ TCPFinEventHandler(msg->Input.Close.Connection, ERR_CLSD);
}
done:
projects / reactos.git / blobdiff