- Fix error spotted by winetest: some status codes need to be normalized in CreateNam...

[reactos.git] / reactos / lib / kernel32 / file / pipe.c

diff --git a/reactos/lib/kernel32/file/pipe.c b/reactos/lib/kernel32/file/pipe.c
index 75e7f2e..fac8693 100644 (file)
--- a/reactos/lib/kernel32/file/pipe.c
+++ b/reactos/lib/kernel32/file/pipe.c
@@ -1,4 +1,4 @@
-/* $Id: pipe.c,v 1.5 2002/05/07 22:22:28 hbirr Exp $
+/* $Id$
  *
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
@@ -10,97 +10,118 @@
 
 /* INCLUDES *****************************************************************/
 
-#include <ddk/ntddk.h>
-#include <kernel32/error.h>
+#include <k32.h>
 
-#include <kernel32/kernel32.h>
+#define NDEBUG
+#include "../include/debug.h"
 
 /* GLOBALS ******************************************************************/
 
-ULONG ProcessPipeId = 0;
+LONG ProcessPipeId = 0;
 
 /* FUNCTIONS ****************************************************************/
 
-BOOL STDCALL CreatePipe(PHANDLE hReadPipe,
-                       PHANDLE hWritePipe,
-                       LPSECURITY_ATTRIBUTES lpPipeAttributes,
-                       DWORD nSize)
+/*
+ * @implemented
+ */
+BOOL
+STDCALL
+CreatePipe(PHANDLE hReadPipe,
+           PHANDLE hWritePipe,
+           LPSECURITY_ATTRIBUTES lpPipeAttributes,
+           DWORD nSize)
 {
-   WCHAR Buffer[64];
-   UNICODE_STRING PipeName;
-   OBJECT_ATTRIBUTES ObjectAttributes;
-   IO_STATUS_BLOCK StatusBlock;
-   LARGE_INTEGER DefaultTimeout;
-   NTSTATUS Status;
-   HANDLE ReadPipeHandle;
-   HANDLE WritePipeHandle;
-   PSECURITY_DESCRIPTOR SecurityDescriptor = NULL;
-
-   DefaultTimeout.QuadPart = 300000000; /* 30 seconds */
-
-   ProcessPipeId++;
-   swprintf(Buffer,
-           L"\\Device\\NamedPipe\\Win32Pipes.%08x.%08x",
-           NtCurrentTeb()->Cid.UniqueProcess,
-           ProcessPipeId);
-   RtlInitUnicodeString (&PipeName,
-                        Buffer);
-
-   if (lpPipeAttributes)
-     {
-       SecurityDescriptor = lpPipeAttributes->lpSecurityDescriptor;
-     }
-
-   InitializeObjectAttributes(&ObjectAttributes,
-                             &PipeName,
-                             OBJ_CASE_INSENSITIVE,
-                             NULL,
-                             SecurityDescriptor);
-   if (lpPipeAttributes)
-   {
-      if(lpPipeAttributes->bInheritHandle)
-         ObjectAttributes.Attributes |= OBJ_INHERIT;
-      if (lpPipeAttributes->lpSecurityDescriptor)
-        ObjectAttributes.SecurityDescriptor = lpPipeAttributes->lpSecurityDescriptor;
-   }
-
-   Status = NtCreateNamedPipeFile(&ReadPipeHandle,
-                                 FILE_GENERIC_READ,
-                                 &ObjectAttributes,
-                                 &StatusBlock,
-                                 FILE_SHARE_READ | FILE_SHARE_WRITE,
-                                 FILE_CREATE,
-                                 FILE_SYNCHRONOUS_IO_NONALERT,
-                                 FALSE,
-                                 FALSE,
-                                 FALSE,
-                                 1,
-                                 nSize,
-                                 nSize,
-                                 &DefaultTimeout);
-   if (!NT_SUCCESS(Status))
-     {
-       SetLastErrorByStatus(Status);
-       return FALSE;
-     }
-
-   Status = NtOpenFile(&WritePipeHandle,
-                      FILE_GENERIC_WRITE,
-                      &ObjectAttributes,
-                      &StatusBlock,
-                      FILE_SHARE_READ | FILE_SHARE_WRITE,
-                      FILE_SYNCHRONOUS_IO_NONALERT | FILE_NON_DIRECTORY_FILE);
-   if (!NT_SUCCESS(Status))
-     {
-       NtClose(ReadPipeHandle);
-       SetLastErrorByStatus(Status);
-       return FALSE;
-     }
-
-   *hReadPipe = ReadPipeHandle;
-   *hWritePipe = WritePipeHandle;
-
-   return TRUE;
+    WCHAR Buffer[64];
+    UNICODE_STRING PipeName;
+    OBJECT_ATTRIBUTES ObjectAttributes;
+    IO_STATUS_BLOCK StatusBlock;
+    LARGE_INTEGER DefaultTimeout;
+    NTSTATUS Status;
+    HANDLE ReadPipeHandle;
+    HANDLE WritePipeHandle;
+    LONG PipeId;
+    ULONG Attributes;
+    PSECURITY_DESCRIPTOR SecurityDescriptor = NULL;
+
+    /* Set the timeout to 120 seconds */
+    DefaultTimeout.QuadPart = -1200000000;
+
+    /* Use default buffer size if desired */
+    if (!nSize) nSize = 0x1000;
+
+    /* Increase the Pipe ID */
+    PipeId = InterlockedIncrement(&ProcessPipeId);
+
+    /* Create the pipe name */
+    swprintf(Buffer,
+             L"\\Device\\NamedPipe\\Win32Pipes.%08x.%08x",
+             NtCurrentTeb()->Cid.UniqueProcess,
+             PipeId);
+    RtlInitUnicodeString(&PipeName, Buffer);
+
+    /* Always use case insensitive */
+    Attributes = OBJ_CASE_INSENSITIVE;
+
+    /* Check if we got attributes */
+    if (lpPipeAttributes)
+    {
+        /* Use the attributes' SD instead */
+        SecurityDescriptor = lpPipeAttributes->lpSecurityDescriptor;
+
+        /* Set OBJ_INHERIT if requested */
+        if (lpPipeAttributes->bInheritHandle) Attributes |= OBJ_INHERIT;
+    }
+
+    /* Initialize the attributes */
+    InitializeObjectAttributes(&ObjectAttributes,
+                               &PipeName,
+                               Attributes,
+                               NULL,
+                               SecurityDescriptor);
+
+    /* Create the named pipe */
+    Status = NtCreateNamedPipeFile(&ReadPipeHandle,
+                                   GENERIC_READ |FILE_WRITE_ATTRIBUTES | SYNCHRONIZE,
+                                   &ObjectAttributes,
+                                   &StatusBlock,
+                                   FILE_SHARE_READ | FILE_SHARE_WRITE,
+                                   FILE_CREATE,
+                                   FILE_SYNCHRONOUS_IO_NONALERT,
+                                   FILE_PIPE_BYTE_STREAM_TYPE,
+                                   FILE_PIPE_BYTE_STREAM_MODE,
+                                   FILE_PIPE_QUEUE_OPERATION,
+                                   1,
+                                   nSize,
+                                   nSize,
+                                   &DefaultTimeout);
+    if (!NT_SUCCESS(Status))
+    {
+        /* Convert error and fail */
+        DPRINT1("Status: %lx\n", Status);
+        SetLastErrorByStatus(Status);
+        return FALSE;
+    }
+
+    /* Now try opening it for write access */
+    Status = NtOpenFile(&WritePipeHandle,
+                        FILE_GENERIC_WRITE | SYNCHRONIZE,
+                        &ObjectAttributes,
+                        &StatusBlock,
+                        FILE_SHARE_READ,
+                        FILE_SYNCHRONOUS_IO_NONALERT | FILE_NON_DIRECTORY_FILE);
+    if (!NT_SUCCESS(Status))
+    {
+        /* Convert error and fail */
+        DPRINT1("Status: %lx\n", Status);
+        NtClose(ReadPipeHandle);
+        SetLastErrorByStatus(Status);
+        return FALSE;
+    }
+
+    /* Return both handles */
+    *hReadPipe = ReadPipeHandle;
+    *hWritePipe = WritePipeHandle;
+    return TRUE;
 }
 
 /* EOF */