* UPDATE HISTORY:
*/
-#include <ddk/ntddk.h>
-#include <roscfg.h>
-#include <internal/ob.h>
-#include <limits.h>
-#include <string.h>
-#include <internal/registry.h>
-#include <ntos/minmax.h>
-#include <reactos/bugcodes.h>
-
+#include <ntoskrnl.h>
#define NDEBUG
#include <internal/debug.h>
/* LOCAL MACROS *************************************************************/
-#define ROUND_UP(N, S) ((((N) + (S) - 1) / (S)) * (S))
#define ROUND_DOWN(N, S) ((N) - ((N) % (S)))
#define ABS_VALUE(V) (((V) < 0) ? -(V) : (V))
Header->BlockId = REG_HIVE_ID;
Header->UpdateCounter1 = 0;
Header->UpdateCounter2 = 0;
- Header->DateModified.dwLowDateTime = 0;
- Header->DateModified.dwHighDateTime = 0;
+ Header->DateModified.u.LowPart = 0;
+ Header->DateModified.u.HighPart = 0;
Header->Unused3 = 1;
Header->Unused4 = 3;
Header->Unused5 = 0;
Header->Unused6 = 1;
Header->Unused7 = 1;
- Header->RootKeyCell = 0;
+ Header->RootKeyOffset = (BLOCK_OFFSET)-1;
Header->BlockSize = REG_BLOCK_SIZE;
Header->Unused6 = 1;
Header->Checksum = 0;
VOID
-CmiCreateDefaultBinCell(PHBIN BinCell)
+CmiCreateDefaultBinHeader(PHBIN BinHeader)
{
- assert(BinCell);
- RtlZeroMemory(BinCell, sizeof(HBIN));
- BinCell->BlockId = REG_BIN_ID;
- BinCell->DateModified.dwLowDateTime = 0;
- BinCell->DateModified.dwHighDateTime = 0;
- BinCell->BlockSize = REG_BLOCK_SIZE;
+ assert(BinHeader);
+ RtlZeroMemory(BinHeader, sizeof(HBIN));
+ BinHeader->HeaderId = REG_BIN_ID;
+ BinHeader->DateModified.u.LowPart = 0;
+ BinHeader->DateModified.u.HighPart = 0;
+ BinHeader->BinSize = REG_BLOCK_SIZE;
}
RootKeyCell->CellSize = -sizeof(KEY_CELL);
RootKeyCell->Id = REG_KEY_CELL_ID;
RootKeyCell->Flags = REG_KEY_ROOT_CELL | REG_KEY_NAME_PACKED;
- NtQuerySystemTime((PTIME) &RootKeyCell->LastWriteTime);
+ NtQuerySystemTime(&RootKeyCell->LastWriteTime);
RootKeyCell->ParentKeyOffset = 0;
RootKeyCell->NumberOfSubKeys = 0;
RootKeyCell->HashTableOffset = -1;
RootKeyCell->NumberOfValues = 0;
- RootKeyCell->ValuesOffset = -1;
+ RootKeyCell->ValueListOffset = -1;
RootKeyCell->SecurityKeyOffset = 0;
RootKeyCell->ClassNameOffset = -1;
RootKeyCell->NameSize = 0;
VOID
-CmiVerifyBinCell(PHBIN BinCell)
+CmiVerifyBinHeader(PHBIN BinHeader)
{
if (CmiDoVerify)
{
- assert(BinCell);
+ assert(BinHeader);
- if (BinCell->BlockId != REG_BIN_ID)
+ if (BinHeader->HeaderId != REG_BIN_ID)
{
- DbgPrint("BlockId is %.08x (should be %.08x)\n",
- BinCell->BlockId, REG_BIN_ID);
- assert(BinCell->BlockId == REG_BIN_ID);
+ DbgPrint("Bin header ID is %.08x (should be %.08x)\n",
+ BinHeader->HeaderId, REG_BIN_ID);
+ assert(BinHeader->HeaderId == REG_BIN_ID);
}
- //BinCell->DateModified.dwLowDateTime
+ //BinHeader->DateModified.dwLowDateTime
- //BinCell->DateModified.dwHighDateTime
+ //BinHeader->DateModified.dwHighDateTime
- if (BinCell->BlockSize != REG_BLOCK_SIZE)
+ if (BinHeader->BinSize != REG_BLOCK_SIZE)
{
- DbgPrint("BlockSize is %.08x (should be %.08x)\n",
- BinCell->BlockSize, REG_BLOCK_SIZE);
- assert(BinCell->BlockSize == REG_BLOCK_SIZE);
+ DbgPrint("BinSize is %.08x (should be a multiple of %.08x)\n",
+ BinHeader->BinSize, REG_BLOCK_SIZE);
+ assert(BinHeader->BinSize % REG_BLOCK_SIZE == 0);
}
}
PHIVE_HEADER HiveHeader;
PKEY_CELL RootKeyCell;
NTSTATUS Status;
- PHBIN BinCell;
+ PHBIN BinHeader;
PCHAR Buffer;
Buffer = (PCHAR) ExAllocatePool(NonPagedPool, 2 * REG_BLOCK_SIZE);
if (Buffer == NULL)
return STATUS_INSUFFICIENT_RESOURCES;
+ RtlZeroMemory (Buffer,
+ 2 * REG_BLOCK_SIZE);
+
HiveHeader = (PHIVE_HEADER)Buffer;
- BinCell = (PHBIN)((ULONG_PTR)Buffer + REG_BLOCK_SIZE);
+ BinHeader = (PHBIN)((ULONG_PTR)Buffer + REG_BLOCK_SIZE);
RootKeyCell = (PKEY_CELL)((ULONG_PTR)Buffer + REG_BLOCK_SIZE + REG_HBIN_DATA_OFFSET);
FreeCell = (PCELL_HEADER)((ULONG_PTR)Buffer + REG_BLOCK_SIZE + REG_HBIN_DATA_OFFSET + sizeof(KEY_CELL));
CmiCreateDefaultHiveHeader(HiveHeader);
- CmiCreateDefaultBinCell(BinCell);
+ CmiCreateDefaultBinHeader(BinHeader);
CmiCreateDefaultRootKeyCell(RootKeyCell);
/* First block */
- BinCell->BlockOffset = 0;
+ BinHeader->BinOffset = 0;
/* Offset to root key block */
- HiveHeader->RootKeyCell = REG_HBIN_DATA_OFFSET;
+ HiveHeader->RootKeyOffset = REG_HBIN_DATA_OFFSET;
/* The rest of the block is free */
FreeCell->CellSize = REG_BLOCK_SIZE - (REG_HBIN_DATA_OFFSET + sizeof(KEY_CELL));
/* Try to open the hive file */
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->HiveFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
/* Try to open the log file */
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->LogFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
{
/* There is no way to fix the hive without log file - BSOD! */
DPRINT("Hive header inconsistent and no log file available!\n");
- KeBugCheck(CONFIG_LIST_FAILED);
+ KEBUGCHECK(CONFIG_LIST_FAILED);
}
Status = STATUS_SUCCESS;
HiveHeader->UpdateCounter1 != HiveHeader->UpdateCounter2)
{
DPRINT("Hive file and log file are inconsistent!\n");
- KeBugCheck(CONFIG_LIST_FAILED);
+ KEBUGCHECK(CONFIG_LIST_FAILED);
}
/* Log file damaged but hive is okay */
FileSize = fsi.EndOfFile.u.LowPart;
/* Calculate bitmap and block size */
- BitmapSize = ROUND_UP((FileSize / 4096) - 1, sizeof(ULONG) * 8) / 8;
+ BitmapSize = ROUND_UP((FileSize / REG_BLOCK_SIZE) - 1, sizeof(ULONG) * 8) / 8;
BufferSize = sizeof(HIVE_HEADER) +
sizeof(ULONG) +
BitmapSize;
- BufferSize = ROUND_UP(BufferSize, 4096);
+ BufferSize = ROUND_UP(BufferSize, REG_BLOCK_SIZE);
/* Reallocate log header block */
ExFreePool(LogHeader);
/* Initialize bitmap */
RtlInitializeBitMap(&BlockBitMap,
- (PVOID)((ULONG)LogHeader + 4096 + sizeof(ULONG)),
+ (PVOID)((ULONG_PTR)LogHeader + REG_BLOCK_SIZE + sizeof(ULONG)),
BitmapSize * 8);
/* FIXME: Update dirty blocks */
{
Bin = (PHBIN)((ULONG_PTR)ChunkPtr + BlockOffset);
- if (Bin->BlockId != REG_BIN_ID)
+ if (Bin->HeaderId != REG_BIN_ID)
{
- DPRINT1 ("Bad BlockId %x, offset %x\n", Bin->BlockId, BlockOffset);
+ DPRINT1 ("Bad bin header id %x, offset %x\n", Bin->HeaderId, BlockOffset);
return STATUS_REGISTRY_CORRUPT;
}
- assertmsg((Bin->BlockSize % 4096) == 0,
- ("BlockSize (0x%.08x) must be multiple of 4K\n",
- Bin->BlockSize));
+ assertmsg((Bin->BinSize % REG_BLOCK_SIZE) == 0,
+ ("Bin size (0x%.08x) must be multiple of 4K\n",
+ Bin->BinSize));
/* Allocate the hive block */
- Hive->BlockList[BlockIndex] = ExAllocatePool (PagedPool,
- Bin->BlockSize);
- if (Hive->BlockList[BlockIndex] == NULL)
+ Hive->BlockList[BlockIndex].Bin = ExAllocatePool (PagedPool,
+ Bin->BinSize);
+ if (Hive->BlockList[BlockIndex].Bin == NULL)
{
DPRINT1 ("ExAllocatePool() failed\n");
return STATUS_INSUFFICIENT_RESOURCES;
}
+ Hive->BlockList[BlockIndex].Block = (PVOID)Hive->BlockList[BlockIndex].Bin;
/* Import the Bin */
- RtlCopyMemory (Hive->BlockList[BlockIndex],
+ RtlCopyMemory (Hive->BlockList[BlockIndex].Bin,
Bin,
- Bin->BlockSize);
+ Bin->BinSize);
- if (Bin->BlockSize > 4096)
+ if (Bin->BinSize > REG_BLOCK_SIZE)
{
- for (j = 1; j < Bin->BlockSize / 4096; j++)
+ for (j = 1; j < Bin->BinSize / REG_BLOCK_SIZE; j++)
{
- Hive->BlockList[BlockIndex + j] = Hive->BlockList[BlockIndex];
+ Hive->BlockList[BlockIndex + j].Bin = Hive->BlockList[BlockIndex].Bin;
+ Hive->BlockList[BlockIndex + j].Block =
+ (PVOID)((ULONG_PTR)Hive->BlockList[BlockIndex].Bin + (j * REG_BLOCK_SIZE));
}
}
- BlockIndex += Bin->BlockSize / 4096;
- BlockOffset += Bin->BlockSize;
+ BlockIndex += Bin->BinSize / REG_BLOCK_SIZE;
+ BlockOffset += Bin->BinSize;
}
return STATUS_SUCCESS;
Bin = NULL;
for (i = 0; i < Hive->BlockListSize; i++)
{
- if (Hive->BlockList[i] == NULL)
+ if (Hive->BlockList[i].Bin == NULL)
continue;
- if (Hive->BlockList[i] != Bin)
+ if (Hive->BlockList[i].Bin != Bin)
{
- Bin = Hive->BlockList[i];
- ExFreePool (Hive->BlockList[i]);
+ Bin = Hive->BlockList[i].Bin;
+ ExFreePool (Hive->BlockList[i].Bin);
}
- Hive->BlockList[i] = NULL;
+ Hive->BlockList[i].Bin = NULL;
+ Hive->BlockList[i].Block = NULL;
}
}
BlockIndex = 0;
while (BlockIndex < Hive->BlockListSize)
{
- Bin = Hive->BlockList[BlockIndex];
+ Bin = Hive->BlockList[BlockIndex].Bin;
/* Search free blocks and add to list */
FreeOffset = REG_HBIN_DATA_OFFSET;
- while (FreeOffset < Bin->BlockSize)
+ while (FreeOffset < Bin->BinSize)
{
FreeBlock = (PCELL_HEADER) ((ULONG_PTR) Bin + FreeOffset);
if (FreeBlock->CellSize > 0)
{
Status = CmiAddFree(Hive,
FreeBlock,
- Bin->BlockOffset + FreeOffset,
+ Bin->BinOffset + FreeOffset,
FALSE);
if (!NT_SUCCESS(Status))
}
}
- BlockIndex += Bin->BlockSize / 4096;
- BlockOffset += Bin->BlockSize;
+ BlockIndex += Bin->BinSize / REG_BLOCK_SIZE;
+ BlockOffset += Bin->BinSize;
}
return STATUS_SUCCESS;
ULONG CreateDisposition;
IO_STATUS_BLOCK IoSB;
HANDLE FileHandle;
- HANDLE SectionHandle;
+ PSECTION_OBJECT SectionObject;
PUCHAR ViewBase;
ULONG ViewSize;
NTSTATUS Status;
- DPRINT("CmiInitNonVolatileRegistryHive(%p, %S, %d) called\n",
- RegistryHive, Filename, CreateNew);
+ DPRINT("CmiInitNonVolatileRegistryHive(%p, %S) called\n",
+ RegistryHive, Filename);
/* Duplicate Filename */
Status = RtlCreateUnicodeString(&RegistryHive->HiveFileName,
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->HiveFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
}
/* Create the hive section */
- Status = NtCreateSection(&SectionHandle,
+ Status = MmCreateSection(&SectionObject,
SECTION_ALL_ACCESS,
NULL,
NULL,
PAGE_READWRITE,
SEC_COMMIT,
- FileHandle);
- NtClose(FileHandle);
+ FileHandle,
+ NULL);
if (!NT_SUCCESS(Status))
{
- DPRINT1("NtCreateSection() failed (Status %lx)\n", Status);
+ DPRINT1("MmCreateSection() failed (Status %lx)\n", Status);
RtlFreeUnicodeString(&RegistryHive->HiveFileName);
RtlFreeUnicodeString(&RegistryHive->LogFileName);
return(Status);
/* Map the hive file */
ViewBase = NULL;
ViewSize = 0;
- Status = NtMapViewOfSection(SectionHandle,
- NtCurrentProcess(),
+ Status = MmMapViewOfSection(SectionObject,
+ PsGetCurrentProcess(),
(PVOID*)&ViewBase,
0,
ViewSize,
PAGE_READWRITE);
if (!NT_SUCCESS(Status))
{
- DPRINT1("MmMapViewInSystemSpace() failed (Status %lx)\n", Status);
- NtClose(SectionHandle);
+ DPRINT1("MmMapViewOfSection() failed (Status %lx)\n", Status);
+ ObDereferenceObject(SectionObject);
RtlFreeUnicodeString(&RegistryHive->HiveFileName);
RtlFreeUnicodeString(&RegistryHive->LogFileName);
+ NtClose(FileHandle);
return(Status);
}
DPRINT("ViewBase %p ViewSize %lx\n", ViewBase, ViewSize);
ViewBase,
sizeof(HIVE_HEADER));
RegistryHive->FileSize = ViewSize;
- RegistryHive->BlockListSize = (RegistryHive->FileSize / 4096) - 1;
+ RegistryHive->BlockListSize = (RegistryHive->FileSize / REG_BLOCK_SIZE) - 1;
RegistryHive->UpdateCounter = RegistryHive->HiveHeader->UpdateCounter1;
/* Allocate hive block list */
RegistryHive->BlockList = ExAllocatePool(NonPagedPool,
- sizeof(PHBIN *) * RegistryHive->BlockListSize);
+ RegistryHive->BlockListSize * sizeof(BLOCK_LIST_ENTRY));
if (RegistryHive->BlockList == NULL)
{
DPRINT1("Failed to allocate the hive block list\n");
- NtUnmapViewOfSection(NtCurrentProcess(),
+ MmUnmapViewOfSection(PsGetCurrentProcess(),
ViewBase);
- NtClose(SectionHandle);
+ ObDereferenceObject(SectionObject);
RtlFreeUnicodeString(&RegistryHive->HiveFileName);
RtlFreeUnicodeString(&RegistryHive->LogFileName);
+ NtClose(FileHandle);
return STATUS_INSUFFICIENT_RESOURCES;
}
+ RtlZeroMemory (RegistryHive->BlockList,
+ RegistryHive->BlockListSize * sizeof(BLOCK_LIST_ENTRY));
/* Import the hive bins */
Status = CmiImportHiveBins (RegistryHive,
- ViewBase + 4096);
+ ViewBase + REG_BLOCK_SIZE);
if (!NT_SUCCESS(Status))
{
ExFreePool(RegistryHive->BlockList);
- NtUnmapViewOfSection(NtCurrentProcess(),
+ MmUnmapViewOfSection(PsGetCurrentProcess(),
ViewBase);
- NtClose(SectionHandle);
+ ObDereferenceObject(SectionObject);
RtlFreeUnicodeString(&RegistryHive->HiveFileName);
RtlFreeUnicodeString(&RegistryHive->LogFileName);
+ NtClose(FileHandle);
return Status;
}
/* Unmap and dereference the hive section */
- NtUnmapViewOfSection(NtCurrentProcess(),
- ViewBase);
- NtClose(SectionHandle);
+ MmUnmapViewOfSection(PsGetCurrentProcess(),
+ ViewBase);
+ ObDereferenceObject(SectionObject);
+
+ /* Close the hive file */
+ NtClose(FileHandle);
/* Initialize the free cell list */
Status = CmiCreateHiveFreeCellList (RegistryHive);
return Status;
}
- DPRINT("CmiInitNonVolatileRegistryHive(%p, %S, %d) - Finished.\n",
- RegistryHive, Filename, CreateNew);
+ DPRINT("CmiInitNonVolatileRegistryHive(%p, %S) - Finished.\n",
+ RegistryHive, Filename);
- return(STATUS_SUCCESS);
+ return STATUS_SUCCESS;
}
ExFreePool (Hive);
return STATUS_INSUFFICIENT_RESOURCES;
}
+ RtlZeroMemory (Hive->HiveHeader,
+ sizeof(HIVE_HEADER));
Hive->Flags = (HIVE_NO_FILE | HIVE_POINTER);
}
CmiCreateDefaultRootKeyCell (RootKeyCell);
- Hive->HiveHeader->RootKeyCell = (BLOCK_OFFSET)RootKeyCell;
+ Hive->HiveHeader->RootKeyOffset = (BLOCK_OFFSET)RootKeyCell;
ExInitializeResourceLite (&Hive->HiveResource);
/* Acquire hive list lock exclusively */
+ KeEnterCriticalRegion();
ExAcquireResourceExclusiveLite (&CmiHiveListLock,
TRUE);
/* Release hive list lock */
ExReleaseResourceLite (&CmiHiveListLock);
+ KeLeaveCriticalRegion();
VERIFY_REGISTRY_HIVE (Hive);
NTSTATUS
CmiCreateTempHive(PREGISTRY_HIVE *RegistryHive)
{
- PHBIN BinCell;
+ PHBIN BinHeader;
PCELL_HEADER FreeCell;
PREGISTRY_HIVE Hive;
NTSTATUS Status;
- DPRINT1 ("CmiCreateTempHive() called\n");
+ DPRINT ("CmiCreateTempHive() called\n");
*RegistryHive = NULL;
RtlZeroMemory (Hive->HiveHeader,
REG_BLOCK_SIZE);
- DPRINT1 ("HiveHeader %x\n", Hive->HiveHeader);
+ DPRINT ("HiveHeader %x\n", Hive->HiveHeader);
Hive->Flags = HIVE_NO_FILE;
/* Allocate hive block list */
Hive->BlockList = ExAllocatePool (NonPagedPool,
- sizeof(PHBIN *));
+ sizeof(PBLOCK_LIST_ENTRY));
if (Hive->BlockList == NULL)
{
DPRINT1 ("Failed to allocate hive block list\n");
}
/* Allocate first Bin */
- Hive->BlockList[0] = ExAllocatePool (NonPagedPool,
- REG_BLOCK_SIZE);
- if (Hive->BlockList[0] == NULL)
+ Hive->BlockList[0].Bin = ExAllocatePool (NonPagedPool,
+ REG_BLOCK_SIZE);
+ if (Hive->BlockList[0].Bin == NULL)
{
DPRINT1 ("Failed to allocate first bin\n");
ExFreePool(Hive->BlockList);
ExFreePool(Hive);
return STATUS_INSUFFICIENT_RESOURCES;
}
+ Hive->BlockList[0].Block = (PVOID)Hive->BlockList[0].Bin;
Hive->FileSize = 2* REG_BLOCK_SIZE;
Hive->BlockListSize = 1;
Hive->UpdateCounter = Hive->HiveHeader->UpdateCounter1;
- BinCell = (PHBIN)Hive->BlockList[0];
- FreeCell = (PCELL_HEADER)((ULONG_PTR)BinCell + REG_HBIN_DATA_OFFSET);
+ BinHeader = Hive->BlockList[0].Bin;
+ FreeCell = (PCELL_HEADER)((ULONG_PTR)BinHeader + REG_HBIN_DATA_OFFSET);
- CmiCreateDefaultBinCell (BinCell);
+ CmiCreateDefaultBinHeader (BinHeader);
/* First block */
- BinCell->BlockOffset = 0;
+ BinHeader->BinOffset = 0;
/* Offset to root key block */
- Hive->HiveHeader->RootKeyCell = -1;
+ Hive->HiveHeader->RootKeyOffset = (BLOCK_OFFSET)-1;
/* The rest of the block is free */
FreeCell->CellSize = REG_BLOCK_SIZE - REG_HBIN_DATA_OFFSET;
/* Create the free cell list */
Status = CmiCreateHiveFreeCellList (Hive);
- if (Hive->BlockList[0] == NULL)
+ if (Hive->BlockList[0].Bin == NULL)
{
DPRINT1 ("CmiCreateHiveFreeCellList() failed (Status %lx)\n", Status);
- ExFreePool(Hive->BlockList[0]);
+ ExFreePool(Hive->BlockList[0].Bin);
ExFreePool(Hive->BlockList);
ExFreePool(Hive->HiveHeader);
ExFreePool(Hive);
ExInitializeResourceLite (&Hive->HiveResource);
/* Acquire hive list lock exclusively */
+ KeEnterCriticalRegion();
ExAcquireResourceExclusiveLite (&CmiHiveListLock,
TRUE);
/* Release hive list lock */
ExReleaseResourceLite (&CmiHiveListLock);
+ KeLeaveCriticalRegion();
VERIFY_REGISTRY_HIVE (Hive);
return STATUS_INSUFFICIENT_RESOURCES;
}
+ RtlZeroMemory (Hive->HiveHeader,
+ sizeof(HIVE_HEADER));
+
Status = CmiInitNonVolatileRegistryHive (Hive,
FileName->Buffer);
if (!NT_SUCCESS (Status))
ExInitializeResourceLite (&Hive->HiveResource);
/* Add the new hive to the hive list */
+ KeEnterCriticalRegion();
ExAcquireResourceExclusiveLite (&CmiHiveListLock,
TRUE);
InsertTailList (&CmiHiveListHead,
&Hive->HiveList);
ExReleaseResourceLite (&CmiHiveListLock);
+ KeLeaveCriticalRegion();
VERIFY_REGISTRY_HIVE(Hive);
return STATUS_UNSUCCESSFUL;
/* Acquire hive list lock exclusively */
+ KeEnterCriticalRegion();
ExAcquireResourceExclusiveLite (&CmiHiveListLock,
TRUE);
/* Release hive list lock */
ExReleaseResourceLite (&CmiHiveListLock);
+ KeLeaveCriticalRegion();
/* Release file names */
RtlFreeUnicodeString (&RegistryHive->HiveFileName);
BufferSize = sizeof(HIVE_HEADER) +
sizeof(ULONG) +
BitmapSize;
- BufferSize = ROUND_UP(BufferSize, 4096);
+ BufferSize = ROUND_UP(BufferSize, REG_BLOCK_SIZE);
DPRINT("Bitmap size %lu buffer size: %lu\n", BitmapSize, BufferSize);
- Buffer = (PUCHAR)ExAllocatePool(NonPagedPool, BufferSize);
+ Buffer = (PUCHAR)ExAllocatePool(NonPagedPool,
+ BufferSize);
if (Buffer == NULL)
{
DPRINT("ExAllocatePool() failed\n");
return(STATUS_INSUFFICIENT_RESOURCES);
}
+ RtlZeroMemory (Buffer,
+ BufferSize);
/* Open log file for writing */
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->LogFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
BitmapSize);
/* Write hive block and block bitmap */
- FileOffset.QuadPart = 0ULL;
+ FileOffset.QuadPart = (ULONGLONG)0;
Status = NtWriteFile(FileHandle,
NULL,
NULL,
DPRINT("Block %lu is dirty\n", BlockIndex);
- BlockPtr = RegistryHive->BlockList[BlockIndex];
+ BlockPtr = RegistryHive->BlockList[BlockIndex].Block;
DPRINT("BlockPtr %p\n", BlockPtr);
DPRINT("File offset %I64x\n", FileOffset.QuadPart);
}
BlockIndex++;
- FileOffset.QuadPart += 4096ULL;
+ FileOffset.QuadPart += (ULONGLONG)REG_BLOCK_SIZE;
}
/* Truncate log file */
BufferSize = sizeof(HIVE_HEADER) +
sizeof(ULONG) +
BitmapSize;
- BufferSize = ROUND_UP(BufferSize, 4096);
+ BufferSize = ROUND_UP(BufferSize, REG_BLOCK_SIZE);
DPRINT("Bitmap size %lu buffer size: %lu\n", BitmapSize, BufferSize);
/* Open log file for writing */
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->LogFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
BitmapSize);
/* Write hive block and block bitmap */
- FileOffset.QuadPart = 0ULL;
+ FileOffset.QuadPart = (ULONGLONG)0;
Status = NtWriteFile(FileHandle,
NULL,
NULL,
BufferSize = sizeof(HIVE_HEADER) +
sizeof(ULONG) +
BitmapSize;
- BufferSize = ROUND_UP(BufferSize, 4096);
+ BufferSize = ROUND_UP(BufferSize, REG_BLOCK_SIZE);
DPRINT("Bitmap size %lu buffer size: %lu\n", BitmapSize, BufferSize);
/* Open log file for writing */
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->LogFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
/* Open hive for writing */
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->HiveFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
RegistryHive->HiveHeader->Checksum = CmiCalcChecksum((PULONG)RegistryHive->HiveHeader);
/* Write hive block */
- FileOffset.QuadPart = 0ULL;
+ FileOffset.QuadPart = (ULONGLONG)0;
Status = NtWriteFile(FileHandle,
NULL,
NULL,
DPRINT("Block %lu is dirty\n", BlockIndex);
- BlockPtr = RegistryHive->BlockList[BlockIndex];
- DPRINT("BlockPtr %p\n", BlockPtr);
+ BlockPtr = RegistryHive->BlockList[BlockIndex].Block;
+ DPRINT(" BlockPtr %p\n", BlockPtr);
- FileOffset.QuadPart = (ULONGLONG)(BlockIndex + 1) * 4096ULL;
- DPRINT("File offset %I64x\n", FileOffset.QuadPart);
+ FileOffset.QuadPart = (ULONGLONG)(BlockIndex + 1) * (ULONGLONG)REG_BLOCK_SIZE;
+ DPRINT(" File offset %I64x\n", FileOffset.QuadPart);
/* Write hive block */
Status = NtWriteFile(FileHandle,
InitializeObjectAttributes(&ObjectAttributes,
&RegistryHive->HiveFileName,
- 0,
+ OBJ_CASE_INSENSITIVE,
NULL,
NULL);
RegistryHive->HiveHeader->Checksum = CmiCalcChecksum((PULONG)RegistryHive->HiveHeader);
/* Write hive block */
- FileOffset.QuadPart = 0ULL;
+ FileOffset.QuadPart = (ULONGLONG)0;
Status = NtWriteFile(FileHandle,
NULL,
NULL,
&RegistryHive->LogFileName);
/* Update hive header modification time */
- NtQuerySystemTime((PTIME)&RegistryHive->HiveHeader->DateModified);
+ NtQuerySystemTime(&RegistryHive->HiveHeader->DateModified);
/* Start log update */
Status = CmiStartLogUpdate(RegistryHive);
ULONG
-CmiGetMaxNameLength(PREGISTRY_HIVE RegistryHive,
- PKEY_CELL KeyCell)
+CmiGetNumberOfSubKeys(PKEY_OBJECT KeyObject)
+{
+ PKEY_OBJECT CurKey;
+ PKEY_CELL KeyCell;
+ ULONG SubKeyCount;
+ ULONG i;
+
+ VERIFY_KEY_OBJECT(KeyObject);
+
+ KeyCell = KeyObject->KeyCell;
+ VERIFY_KEY_CELL(KeyCell);
+
+ SubKeyCount = (KeyCell == NULL) ? 0 : KeyCell->NumberOfSubKeys;
+
+ /* Search for volatile or 'foreign' keys */
+ for (i = 0; i < KeyObject->NumberOfSubKeys; i++)
+ {
+ CurKey = KeyObject->SubKeys[i];
+ if (CurKey->RegistryHive == CmiVolatileHive ||
+ CurKey->RegistryHive != KeyObject->RegistryHive)
+ {
+ SubKeyCount++;
+ }
+ }
+
+ return SubKeyCount;
+}
+
+
+ULONG
+CmiGetMaxNameLength(PKEY_OBJECT KeyObject)
{
PHASH_TABLE_CELL HashBlock;
+ PKEY_OBJECT CurKey;
PKEY_CELL CurSubKeyCell;
+ PKEY_CELL KeyCell;
ULONG MaxName;
+ ULONG NameSize;
ULONG i;
+ VERIFY_KEY_OBJECT(KeyObject);
+
+ KeyCell = KeyObject->KeyCell;
VERIFY_KEY_CELL(KeyCell);
MaxName = 0;
- HashBlock = CmiGetBlock(RegistryHive, KeyCell->HashTableOffset, NULL);
+ HashBlock = CmiGetCell (KeyObject->RegistryHive,
+ KeyCell->HashTableOffset,
+ NULL);
if (HashBlock == NULL)
{
DPRINT("CmiGetBlock() failed\n");
- return 0;
+ }
+ else
+ {
+ for (i = 0; i < HashBlock->HashTableSize; i++)
+ {
+ if (HashBlock->Table[i].KeyOffset != 0)
+ {
+ CurSubKeyCell = CmiGetCell (KeyObject->RegistryHive,
+ HashBlock->Table[i].KeyOffset,
+ NULL);
+ if (CurSubKeyCell == NULL)
+ {
+ DPRINT("CmiGetBlock() failed\n");
+ continue;
+ }
+
+ NameSize = CurSubKeyCell->NameSize;
+ if (CurSubKeyCell->Flags & REG_KEY_NAME_PACKED)
+ {
+ NameSize *= sizeof(WCHAR);
+ }
+
+ if (NameSize > MaxName)
+ {
+ MaxName = NameSize;
+ }
+ }
+ }
}
- for (i = 0; i < HashBlock->HashTableSize; i++)
+ DPRINT ("KeyObject->NumberOfSubKeys %d\n", KeyObject->NumberOfSubKeys);
+ for (i = 0; i < KeyObject->NumberOfSubKeys; i++)
{
- if (HashBlock->Table[i].KeyOffset != 0)
+ CurKey = KeyObject->SubKeys[i];
+ if (CurKey->RegistryHive == CmiVolatileHive ||
+ CurKey->RegistryHive != KeyObject->RegistryHive)
{
- CurSubKeyCell = CmiGetBlock(RegistryHive,
- HashBlock->Table[i].KeyOffset,
- NULL);
+ CurSubKeyCell = CurKey->KeyCell;
if (CurSubKeyCell == NULL)
{
DPRINT("CmiGetBlock() failed\n");
- return 0;
+ continue;
+ }
+
+ if ((CurSubKeyCell->Flags & REG_KEY_ROOT_CELL) == REG_KEY_ROOT_CELL)
+ {
+ /* Use name of the key object */
+ NameSize = CurKey->Name.Length;
+ }
+ else
+ {
+ /* Use name of the key cell */
+ NameSize = CurSubKeyCell->NameSize;
+ if (CurSubKeyCell->Flags & REG_KEY_NAME_PACKED)
+ {
+ NameSize *= sizeof(WCHAR);
+ }
}
+ DPRINT ("NameSize %lu\n", NameSize);
- if (MaxName < CurSubKeyCell->NameSize)
+ if (NameSize > MaxName)
{
- MaxName = CurSubKeyCell->NameSize;
+ MaxName = NameSize;
}
}
}
+ DPRINT ("MaxName %lu\n", MaxName);
+
return MaxName;
}
ULONG
-CmiGetMaxClassLength(PREGISTRY_HIVE RegistryHive,
- PKEY_CELL KeyCell)
+CmiGetMaxClassLength(PKEY_OBJECT KeyObject)
{
PHASH_TABLE_CELL HashBlock;
+ PKEY_OBJECT CurKey;
PKEY_CELL CurSubKeyCell;
+ PKEY_CELL KeyCell;
ULONG MaxClass;
ULONG i;
+ VERIFY_KEY_OBJECT(KeyObject);
+
+ KeyCell = KeyObject->KeyCell;
VERIFY_KEY_CELL(KeyCell);
MaxClass = 0;
- HashBlock = CmiGetBlock(RegistryHive, KeyCell->HashTableOffset, NULL);
+ HashBlock = CmiGetCell (KeyObject->RegistryHive,
+ KeyCell->HashTableOffset,
+ NULL);
if (HashBlock == NULL)
{
DPRINT("CmiGetBlock() failed\n");
- return 0;
+ }
+ else
+ {
+ for (i = 0; i < HashBlock->HashTableSize; i++)
+ {
+ if (HashBlock->Table[i].KeyOffset != 0)
+ {
+ CurSubKeyCell = CmiGetCell (KeyObject->RegistryHive,
+ HashBlock->Table[i].KeyOffset,
+ NULL);
+ if (CurSubKeyCell == NULL)
+ {
+ DPRINT("CmiGetBlock() failed\n");
+ continue;
+ }
+
+ if (MaxClass < CurSubKeyCell->ClassSize)
+ {
+ MaxClass = CurSubKeyCell->ClassSize;
+ }
+ }
+ }
}
- for (i = 0; i < HashBlock->HashTableSize; i++)
+ DPRINT("KeyObject->NumberOfSubKeys %d\n", KeyObject->NumberOfSubKeys);
+ for (i = 0; i < KeyObject->NumberOfSubKeys; i++)
{
- if (HashBlock->Table[i].KeyOffset != 0)
+ CurKey = KeyObject->SubKeys[i];
+ if (CurKey->RegistryHive == CmiVolatileHive ||
+ CurKey->RegistryHive != KeyObject->RegistryHive)
{
- CurSubKeyCell = CmiGetBlock(RegistryHive,
- HashBlock->Table[i].KeyOffset,
- NULL);
+ CurSubKeyCell = CurKey->KeyCell;
if (CurSubKeyCell == NULL)
{
DPRINT("CmiGetBlock() failed\n");
- return 0;
+ continue;
}
if (MaxClass < CurSubKeyCell->ClassSize)
PVALUE_LIST_CELL ValueListCell;
PVALUE_CELL CurValueCell;
ULONG MaxValueName;
+ ULONG Size;
ULONG i;
VERIFY_KEY_CELL(KeyCell);
MaxValueName = 0;
- ValueListCell = CmiGetBlock(RegistryHive,
- KeyCell->ValuesOffset,
+ ValueListCell = CmiGetCell (RegistryHive,
+ KeyCell->ValueListOffset,
NULL);
if (ValueListCell == NULL)
{
for (i = 0; i < KeyCell->NumberOfValues; i++)
{
- CurValueCell = CmiGetBlock (RegistryHive,
- ValueListCell->Values[i],
- NULL);
+ CurValueCell = CmiGetCell (RegistryHive,
+ ValueListCell->ValueOffset[i],
+ NULL);
if (CurValueCell == NULL)
{
DPRINT("CmiGetBlock() failed\n");
}
- if (CurValueCell != NULL &&
- MaxValueName < CurValueCell->NameSize)
- {
- MaxValueName = CurValueCell->NameSize;
+ if (CurValueCell != NULL)
+ {
+ Size = CurValueCell->NameSize;
+ if (CurValueCell->Flags & REG_VALUE_NAME_PACKED)
+ {
+ Size *= sizeof(WCHAR);
+ }
+ if (MaxValueName < Size)
+ {
+ MaxValueName = Size;
+ }
}
}
VERIFY_KEY_CELL(KeyCell);
MaxValueData = 0;
- ValueListCell = CmiGetBlock(RegistryHive, KeyCell->ValuesOffset, NULL);
+ ValueListCell = CmiGetCell (RegistryHive, KeyCell->ValueListOffset, NULL);
if (ValueListCell == NULL)
{
return 0;
for (i = 0; i < KeyCell->NumberOfValues; i++)
{
- CurValueCell = CmiGetBlock(RegistryHive,
- ValueListCell->Values[i],NULL);
+ CurValueCell = CmiGetCell (RegistryHive,
+ ValueListCell->ValueOffset[i],NULL);
if ((CurValueCell != NULL) &&
- (MaxValueData < (CurValueCell->DataSize & LONG_MAX)))
+ (MaxValueData < (LONG)(CurValueCell->DataSize & REG_DATA_SIZE_MASK)))
{
- MaxValueData = CurValueCell->DataSize & LONG_MAX;
+ MaxValueData = CurValueCell->DataSize & REG_DATA_SIZE_MASK;
}
}
}
/* Get hash table */
- HashBlock = CmiGetBlock(RegistryHive, KeyCell->HashTableOffset, NULL);
+ HashBlock = CmiGetCell (RegistryHive, KeyCell->HashTableOffset, NULL);
if (HashBlock == NULL)
{
DPRINT("CmiGetBlock() failed\n");
(HashBlock->Table[i].HashValue == 0 ||
CmiCompareHashI(KeyName, (PCHAR)&HashBlock->Table[i].HashValue)))
{
- CurSubKeyCell = CmiGetBlock(RegistryHive,
+ CurSubKeyCell = CmiGetCell (RegistryHive,
HashBlock->Table[i].KeyOffset,
NULL);
if (CurSubKeyCell == NULL)
(HashBlock->Table[i].HashValue == 0 ||
CmiCompareHash(KeyName, (PCHAR)&HashBlock->Table[i].HashValue)))
{
- CurSubKeyCell = CmiGetBlock(RegistryHive,
+ CurSubKeyCell = CmiGetCell (RegistryHive,
HashBlock->Table[i].KeyOffset,
NULL);
if (CurSubKeyCell == NULL)
NTSTATUS
CmiAddSubKey(PREGISTRY_HIVE RegistryHive,
- PKEY_OBJECT Parent,
+ PKEY_OBJECT ParentKey,
PKEY_OBJECT SubKey,
PUNICODE_STRING SubKeyName,
ULONG TitleIndex,
PUNICODE_STRING Class,
ULONG CreateOptions)
{
- PHASH_TABLE_CELL NewHashBlock;
PHASH_TABLE_CELL HashBlock;
BLOCK_OFFSET NKBOffset;
PKEY_CELL NewKeyCell;
ULONG NewBlockSize;
- PKEY_CELL KeyCell;
+ PKEY_CELL ParentKeyCell;
+ PDATA_CELL ClassCell;
NTSTATUS Status;
USHORT NameSize;
PWSTR NamePtr;
BOOLEAN Packable;
ULONG i;
- KeyCell = Parent->KeyCell;
+ ParentKeyCell = ParentKey->KeyCell;
- VERIFY_KEY_CELL(KeyCell);
+ VERIFY_KEY_CELL(ParentKeyCell);
/* Skip leading backslash */
if (SubKeyName->Buffer[0] == L'\\')
Status = STATUS_SUCCESS;
NewBlockSize = sizeof(KEY_CELL) + NameSize;
- Status = CmiAllocateBlock(RegistryHive,
- (PVOID) &NewKeyCell,
+ Status = CmiAllocateCell (RegistryHive,
NewBlockSize,
+ (PVOID) &NewKeyCell,
&NKBOffset);
if (NewKeyCell == NULL)
{
{
NewKeyCell->Id = REG_KEY_CELL_ID;
NewKeyCell->Flags = 0;
- NtQuerySystemTime((PTIME) &NewKeyCell->LastWriteTime);
+ NtQuerySystemTime(&NewKeyCell->LastWriteTime);
NewKeyCell->ParentKeyOffset = -1;
NewKeyCell->NumberOfSubKeys = 0;
NewKeyCell->HashTableOffset = -1;
NewKeyCell->NumberOfValues = 0;
- NewKeyCell->ValuesOffset = -1;
+ NewKeyCell->ValueListOffset = -1;
NewKeyCell->SecurityKeyOffset = -1;
NewKeyCell->ClassNameOffset = -1;
VERIFY_KEY_CELL(NewKeyCell);
- if (Class)
+ if (Class != NULL)
{
- PDATA_CELL pClass;
-
- NewKeyCell->ClassSize = Class->Length + sizeof(WCHAR);
- Status = CmiAllocateBlock(RegistryHive,
- (PVOID)&pClass,
- NewKeyCell->ClassSize,
+ NewKeyCell->ClassSize = Class->Length;
+ Status = CmiAllocateCell (RegistryHive,
+ sizeof(CELL_HEADER) + NewKeyCell->ClassSize,
+ (PVOID)&ClassCell,
&NewKeyCell->ClassNameOffset);
- wcsncpy((PWSTR)pClass->Data,
- Class->Buffer,
- Class->Length);
- ((PWSTR) (pClass->Data))[Class->Length] = 0;
+ RtlCopyMemory (ClassCell->Data,
+ Class->Buffer,
+ Class->Length);
}
}
}
SubKey->KeyCell = NewKeyCell;
- SubKey->BlockOffset = NKBOffset;
+ SubKey->KeyCellOffset = NKBOffset;
/* Don't modify hash table if key is located in a pointer-based hive and parent key is not */
- if (IsPointerHive(RegistryHive) && (!IsPointerHive(Parent->RegistryHive)))
+ if (IsPointerHive(RegistryHive) && (!IsPointerHive(ParentKey->RegistryHive)))
{
return(Status);
}
- if (KeyCell->HashTableOffset == (ULONG_PTR) -1)
+ if (ParentKeyCell->HashTableOffset == (ULONG_PTR) -1)
{
- Status = CmiAllocateHashTableBlock(RegistryHive,
+ Status = CmiAllocateHashTableCell (RegistryHive,
&HashBlock,
- &KeyCell->HashTableOffset,
+ &ParentKeyCell->HashTableOffset,
REG_INIT_HASH_TABLE_SIZE);
if (!NT_SUCCESS(Status))
{
}
else
{
- HashBlock = CmiGetBlock(RegistryHive,
- KeyCell->HashTableOffset,
+ HashBlock = CmiGetCell (RegistryHive,
+ ParentKeyCell->HashTableOffset,
NULL);
if (HashBlock == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT("CmiGetCell() failed\n");
return STATUS_UNSUCCESSFUL;
}
- if (((KeyCell->NumberOfSubKeys + 1) >= HashBlock->HashTableSize))
+ if (((ParentKeyCell->NumberOfSubKeys + 1) >= HashBlock->HashTableSize))
{
+ PHASH_TABLE_CELL NewHashBlock;
BLOCK_OFFSET HTOffset;
- /* Reallocate the hash table block */
- Status = CmiAllocateHashTableBlock(RegistryHive,
+ /* Reallocate the hash table cell */
+ Status = CmiAllocateHashTableCell (RegistryHive,
&NewHashBlock,
&HTOffset,
HashBlock->HashTableSize +
RtlCopyMemory(&NewHashBlock->Table[0],
&HashBlock->Table[0],
sizeof(NewHashBlock->Table[0]) * HashBlock->HashTableSize);
- CmiDestroyBlock(RegistryHive,
+ CmiDestroyCell (RegistryHive,
HashBlock,
- KeyCell->HashTableOffset);
- KeyCell->HashTableOffset = HTOffset;
+ ParentKeyCell->HashTableOffset);
+ ParentKeyCell->HashTableOffset = HTOffset;
HashBlock = NewHashBlock;
}
}
Status = CmiAddKeyToHashTable(RegistryHive,
HashBlock,
+ ParentKeyCell->HashTableOffset,
NewKeyCell,
NKBOffset);
if (NT_SUCCESS(Status))
{
- KeyCell->NumberOfSubKeys++;
+ ParentKeyCell->NumberOfSubKeys++;
}
+ NtQuerySystemTime (&ParentKeyCell->LastWriteTime);
+ CmiMarkBlockDirty (RegistryHive, ParentKey->KeyCellOffset);
+
return(Status);
}
if (SubKey->KeyCell->NumberOfValues != 0)
{
/* Get pointer to the value list cell */
- ValueList = CmiGetBlock(RegistryHive,
- SubKey->KeyCell->ValuesOffset,
+ ValueList = CmiGetCell (RegistryHive,
+ SubKey->KeyCell->ValueListOffset,
NULL);
if (ValueList == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT("CmiGetCell() failed\n");
return STATUS_UNSUCCESSFUL;
}
- if (ValueList != NULL)
+ /* Enumerate all values */
+ for (i = 0; i < SubKey->KeyCell->NumberOfValues; i++)
{
- /* Enumerate all values */
- for (i = 0; i < SubKey->KeyCell->NumberOfValues; i++)
+ /* Get pointer to value cell */
+ ValueCell = CmiGetCell(RegistryHive,
+ ValueList->ValueOffset[i],
+ NULL);
+ if (ValueCell == NULL)
+ {
+ DPRINT("CmiGetCell() failed\n");
+ return STATUS_UNSUCCESSFUL;
+ }
+
+ if (ValueCell->DataSize > sizeof(BLOCK_OFFSET))
{
- /* Get pointer to value cell */
- ValueCell = CmiGetBlock(RegistryHive,
- ValueList->Values[i],
- NULL);
- if (ValueCell != NULL)
+ DataCell = CmiGetCell (RegistryHive,
+ ValueCell->DataOffset,
+ NULL);
+ if (DataCell == NULL)
+ {
+ DPRINT("CmiGetCell() failed\n");
+ return STATUS_UNSUCCESSFUL;
+ }
+
+ if (DataCell != NULL)
{
- if (ValueCell->DataSize > 4)
- {
- DataCell = CmiGetBlock(RegistryHive,
- ValueCell->DataOffset,
- NULL);
- if (DataCell == NULL)
- {
- DPRINT("CmiGetBlock() failed\n");
- return STATUS_UNSUCCESSFUL;
- }
-
- if (DataCell != NULL)
- {
- /* Destroy data cell */
- CmiDestroyBlock(RegistryHive,
- DataCell,
- ValueCell->DataOffset);
- }
- }
-
- /* Destroy value cell */
- CmiDestroyBlock(RegistryHive,
- ValueCell,
- ValueList->Values[i]);
+ /* Destroy data cell */
+ CmiDestroyCell (RegistryHive,
+ DataCell,
+ ValueCell->DataOffset);
}
}
+
+ /* Destroy value cell */
+ CmiDestroyCell (RegistryHive,
+ ValueCell,
+ ValueList->ValueOffset[i]);
}
/* Destroy value list cell */
- CmiDestroyBlock(RegistryHive,
+ CmiDestroyCell (RegistryHive,
ValueList,
- SubKey->KeyCell->ValuesOffset);
+ SubKey->KeyCell->ValueListOffset);
SubKey->KeyCell->NumberOfValues = 0;
- SubKey->KeyCell->ValuesOffset = -1;
+ SubKey->KeyCell->ValueListOffset = (BLOCK_OFFSET)-1;
+
+ CmiMarkBlockDirty(RegistryHive,
+ SubKey->KeyCellOffset);
}
/* Remove the key from the parent key's hash block */
if (ParentKey->KeyCell->HashTableOffset != (BLOCK_OFFSET) -1)
{
- DPRINT("ParentKey HashTableOffset %lx\n", ParentKey->KeyCell->HashTableOffset)
- HashBlock = CmiGetBlock(RegistryHive,
+ DPRINT("ParentKey HashTableOffset %lx\n", ParentKey->KeyCell->HashTableOffset);
+ HashBlock = CmiGetCell (ParentKey->RegistryHive,
ParentKey->KeyCell->HashTableOffset,
NULL);
if (HashBlock == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT("CmiGetCell() failed\n");
return STATUS_UNSUCCESSFUL;
}
- DPRINT("ParentKey HashBlock %p\n", HashBlock)
+ DPRINT("ParentKey HashBlock %p\n", HashBlock);
if (HashBlock != NULL)
{
- CmiRemoveKeyFromHashTable(RegistryHive,
+ CmiRemoveKeyFromHashTable(ParentKey->RegistryHive,
HashBlock,
- SubKey->BlockOffset);
- CmiMarkBlockDirty(RegistryHive,
+ SubKey->KeyCellOffset);
+ CmiMarkBlockDirty(ParentKey->RegistryHive,
ParentKey->KeyCell->HashTableOffset);
}
}
/* Remove the key's hash block */
if (SubKey->KeyCell->HashTableOffset != (BLOCK_OFFSET) -1)
{
- DPRINT("SubKey HashTableOffset %lx\n", SubKey->KeyCell->HashTableOffset)
- HashBlock = CmiGetBlock(RegistryHive,
+ DPRINT("SubKey HashTableOffset %lx\n", SubKey->KeyCell->HashTableOffset);
+ HashBlock = CmiGetCell (RegistryHive,
SubKey->KeyCell->HashTableOffset,
NULL);
if (HashBlock == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT("CmiGetCell() failed\n");
return STATUS_UNSUCCESSFUL;
}
- DPRINT("SubKey HashBlock %p\n", HashBlock)
+ DPRINT("SubKey HashBlock %p\n", HashBlock);
if (HashBlock != NULL)
{
- CmiDestroyBlock(RegistryHive,
+ CmiDestroyCell (RegistryHive,
HashBlock,
SubKey->KeyCell->HashTableOffset);
SubKey->KeyCell->HashTableOffset = -1;
/* Decrement the number of the parent key's sub keys */
if (ParentKey != NULL)
{
- DPRINT("ParentKey %p\n", ParentKey)
+ DPRINT("ParentKey %p\n", ParentKey);
ParentKey->KeyCell->NumberOfSubKeys--;
/* Remove the parent key's hash table */
if (ParentKey->KeyCell->NumberOfSubKeys == 0)
{
- DPRINT("ParentKey HashTableOffset %lx\n", ParentKey->KeyCell->HashTableOffset)
- HashBlock = CmiGetBlock(RegistryHive,
+ DPRINT("ParentKey HashTableOffset %lx\n", ParentKey->KeyCell->HashTableOffset);
+ HashBlock = CmiGetCell (ParentKey->RegistryHive,
ParentKey->KeyCell->HashTableOffset,
NULL);
if (HashBlock == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT("CmiGetCell() failed\n");
return STATUS_UNSUCCESSFUL;
}
- DPRINT("ParentKey HashBlock %p\n", HashBlock)
+ DPRINT("ParentKey HashBlock %p\n", HashBlock);
if (HashBlock != NULL)
{
- CmiDestroyBlock(RegistryHive,
+ CmiDestroyCell (ParentKey->RegistryHive,
HashBlock,
ParentKey->KeyCell->HashTableOffset);
- ParentKey->KeyCell->HashTableOffset = -1;
+ ParentKey->KeyCell->HashTableOffset = (BLOCK_OFFSET)-1;
}
}
- NtQuerySystemTime((PTIME)&ParentKey->KeyCell->LastWriteTime);
- CmiMarkBlockDirty(RegistryHive,
- ParentKey->BlockOffset);
+ NtQuerySystemTime(&ParentKey->KeyCell->LastWriteTime);
+ CmiMarkBlockDirty(ParentKey->RegistryHive,
+ ParentKey->KeyCellOffset);
}
/* Destroy key cell */
- CmiDestroyBlock(RegistryHive,
+ CmiDestroyCell (RegistryHive,
SubKey->KeyCell,
- SubKey->BlockOffset);
- SubKey->BlockOffset = -1;
+ SubKey->KeyCellOffset);
SubKey->KeyCell = NULL;
+ SubKey->KeyCellOffset = (BLOCK_OFFSET)-1;
- return(STATUS_SUCCESS);
+ DPRINT("CmiRemoveSubKey() done\n");
+
+ return STATUS_SUCCESS;
}
IN PKEY_CELL KeyCell,
IN PUNICODE_STRING ValueName,
OUT PVALUE_CELL *ValueCell,
- OUT BLOCK_OFFSET *VBOffset)
+ OUT BLOCK_OFFSET *ValueCellOffset)
{
PVALUE_LIST_CELL ValueListCell;
PVALUE_CELL CurValueCell;
ULONG i;
*ValueCell = NULL;
+ if (ValueCellOffset != NULL)
+ *ValueCellOffset = (BLOCK_OFFSET)-1;
/* The key does not have any values */
- if (KeyCell->ValuesOffset == (BLOCK_OFFSET)-1)
+ if (KeyCell->ValueListOffset == (BLOCK_OFFSET)-1)
{
- return STATUS_SUCCESS;
+ return STATUS_OBJECT_NAME_NOT_FOUND;
}
- ValueListCell = CmiGetBlock(RegistryHive, KeyCell->ValuesOffset, NULL);
+ ValueListCell = CmiGetCell (RegistryHive, KeyCell->ValueListOffset, NULL);
if (ValueListCell == NULL)
{
DPRINT("ValueListCell is NULL\n");
for (i = 0; i < KeyCell->NumberOfValues; i++)
{
- CurValueCell = CmiGetBlock(RegistryHive,
- ValueListCell->Values[i],
+ CurValueCell = CmiGetCell (RegistryHive,
+ ValueListCell->ValueOffset[i],
NULL);
if (CurValueCell == NULL)
{
CmiComparePackedNames(ValueName,
CurValueCell->Name,
CurValueCell->NameSize,
- CurValueCell->Flags & REG_VALUE_NAME_PACKED))
+ (BOOLEAN)((CurValueCell->Flags & REG_VALUE_NAME_PACKED) ? TRUE : FALSE)))
{
*ValueCell = CurValueCell;
- if (VBOffset)
- *VBOffset = ValueListCell->Values[i];
+ if (ValueCellOffset != NULL)
+ *ValueCellOffset = ValueListCell->ValueOffset[i];
//DPRINT("Found value %s\n", ValueName);
- break;
+ return STATUS_SUCCESS;
}
}
- return STATUS_SUCCESS;
+ return STATUS_OBJECT_NAME_NOT_FOUND;
}
*ValueCell = NULL;
- if (KeyCell->ValuesOffset == (BLOCK_OFFSET)-1)
+ if (KeyCell->ValueListOffset == (BLOCK_OFFSET)-1)
{
return STATUS_NO_MORE_ENTRIES;
}
}
- ValueListCell = CmiGetBlock(RegistryHive, KeyCell->ValuesOffset, NULL);
+ ValueListCell = CmiGetCell (RegistryHive, KeyCell->ValueListOffset, NULL);
if (ValueListCell == NULL)
{
DPRINT("CmiGetBlock() failed\n");
VERIFY_VALUE_LIST_CELL(ValueListCell);
- CurValueCell = CmiGetBlock(RegistryHive,
- ValueListCell->Values[Index],
+ CurValueCell = CmiGetCell (RegistryHive,
+ ValueListCell->ValueOffset[Index],
NULL);
if (CurValueCell == NULL)
{
NTSTATUS
CmiAddValueToKey(IN PREGISTRY_HIVE RegistryHive,
IN PKEY_CELL KeyCell,
+ IN BLOCK_OFFSET KeyCellOffset,
IN PUNICODE_STRING ValueName,
OUT PVALUE_CELL *pValueCell,
- OUT BLOCK_OFFSET *pVBOffset)
+ OUT BLOCK_OFFSET *pValueCellOffset)
{
PVALUE_LIST_CELL NewValueListCell;
PVALUE_LIST_CELL ValueListCell;
PVALUE_CELL NewValueCell;
- BLOCK_OFFSET VLBOffset;
- BLOCK_OFFSET VBOffset;
+ BLOCK_OFFSET NewValueListCellOffset;
+ BLOCK_OFFSET ValueListCellOffset;
+ BLOCK_OFFSET NewValueCellOffset;
+ ULONG CellSize;
NTSTATUS Status;
- Status = CmiAllocateValueCell(RegistryHive,
- &NewValueCell,
- &VBOffset,
- ValueName);
- if (!NT_SUCCESS(Status))
- {
- return Status;
- }
-
- DPRINT("KeyCell->ValuesOffset %lu\n", (ULONG)KeyCell->ValuesOffset);
-
- ValueListCell = CmiGetBlock(RegistryHive, KeyCell->ValuesOffset, NULL);
+ DPRINT("KeyCell->ValuesOffset %lu\n", (ULONG)KeyCell->ValueListOffset);
+ ValueListCell = CmiGetCell (RegistryHive, KeyCell->ValueListOffset, NULL);
if (ValueListCell == NULL)
{
- Status = CmiAllocateBlock(RegistryHive,
- (PVOID) &ValueListCell,
- sizeof(BLOCK_OFFSET) * 3,
- &VLBOffset);
-
+ CellSize = sizeof(VALUE_LIST_CELL) +
+ (3 * sizeof(BLOCK_OFFSET));
+ Status = CmiAllocateCell (RegistryHive,
+ CellSize,
+ (PVOID) &ValueListCell,
+ &ValueListCellOffset);
if (!NT_SUCCESS(Status))
{
- CmiDestroyValueCell(RegistryHive, NewValueCell, VBOffset);
return Status;
}
- KeyCell->ValuesOffset = VLBOffset;
+
+ KeyCell->ValueListOffset = ValueListCellOffset;
+ CmiMarkBlockDirty(RegistryHive, KeyCellOffset);
+ CmiMarkBlockDirty(RegistryHive, ValueListCellOffset);
}
else if (KeyCell->NumberOfValues >=
- (((ULONG)ABS_VALUE(ValueListCell->CellSize) - 4) / sizeof(BLOCK_OFFSET)))
+ (((ULONG)ABS_VALUE(ValueListCell->CellSize) - sizeof(VALUE_LIST_CELL)) / sizeof(BLOCK_OFFSET)))
{
- Status = CmiAllocateBlock(RegistryHive,
+#if 0
+ CellSize = sizeof(VALUE_LIST_CELL) +
+ ((KeyCell->NumberOfValues + REG_VALUE_LIST_CELL_MULTIPLE) * sizeof(BLOCK_OFFSET));
+#endif
+ CellSize = 2 * (ULONG)ABS_VALUE(ValueListCell->CellSize);
+ Status = CmiAllocateCell (RegistryHive,
+ CellSize,
(PVOID) &NewValueListCell,
- (KeyCell->NumberOfValues + REG_VALUE_LIST_CELL_MULTIPLE) *
- sizeof(BLOCK_OFFSET),
- &VLBOffset);
+ &NewValueListCellOffset);
if (!NT_SUCCESS(Status))
{
- CmiDestroyValueCell(RegistryHive, NewValueCell, VBOffset);
return Status;
}
- RtlCopyMemory(&NewValueListCell->Values[0],
- &ValueListCell->Values[0],
+ RtlCopyMemory(&NewValueListCell->ValueOffset[0],
+ &ValueListCell->ValueOffset[0],
sizeof(BLOCK_OFFSET) * KeyCell->NumberOfValues);
- CmiDestroyBlock(RegistryHive, ValueListCell, KeyCell->ValuesOffset);
- KeyCell->ValuesOffset = VLBOffset;
+ CmiDestroyCell (RegistryHive, ValueListCell, KeyCell->ValueListOffset);
+ CmiMarkBlockDirty (RegistryHive, KeyCell->ValueListOffset);
+
+ KeyCell->ValueListOffset = NewValueListCellOffset;
ValueListCell = NewValueListCell;
+ CmiMarkBlockDirty (RegistryHive, KeyCellOffset);
+ CmiMarkBlockDirty (RegistryHive, NewValueListCellOffset);
}
DPRINT("KeyCell->NumberOfValues %lu, ValueListCell->CellSize %lu (%lu %lx)\n",
KeyCell->NumberOfValues,
(ULONG)ABS_VALUE(ValueListCell->CellSize),
- ((ULONG)ABS_VALUE(ValueListCell->CellSize) - 4) / sizeof(BLOCK_OFFSET),
- ((ULONG)ABS_VALUE(ValueListCell->CellSize) - 4) / sizeof(BLOCK_OFFSET));
+ ((ULONG)ABS_VALUE(ValueListCell->CellSize) - sizeof(VALUE_LIST_CELL)) / sizeof(BLOCK_OFFSET),
+ ((ULONG)ABS_VALUE(ValueListCell->CellSize) - sizeof(VALUE_LIST_CELL)) / sizeof(BLOCK_OFFSET));
+
+ Status = CmiAllocateValueCell(RegistryHive,
+ &NewValueCell,
+ &NewValueCellOffset,
+ ValueName);
+ if (!NT_SUCCESS(Status))
+ {
+ return Status;
+ }
- ValueListCell->Values[KeyCell->NumberOfValues] = VBOffset;
+ ValueListCell->ValueOffset[KeyCell->NumberOfValues] = NewValueCellOffset;
KeyCell->NumberOfValues++;
+ CmiMarkBlockDirty(RegistryHive, KeyCellOffset);
+ CmiMarkBlockDirty(RegistryHive, KeyCell->ValueListOffset);
+ CmiMarkBlockDirty(RegistryHive, NewValueCellOffset);
+
*pValueCell = NewValueCell;
- *pVBOffset = VBOffset;
+ *pValueCellOffset = NewValueCellOffset;
return STATUS_SUCCESS;
}
{
PVALUE_LIST_CELL ValueListCell;
PVALUE_CELL CurValueCell;
- ULONG i;
-
- ValueListCell = CmiGetBlock(RegistryHive, KeyCell->ValuesOffset, NULL);
+ ULONG i;
+ NTSTATUS Status;
+ ValueListCell = CmiGetCell (RegistryHive, KeyCell->ValueListOffset, NULL);
if (ValueListCell == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT1("CmiGetBlock() failed\n");
return STATUS_SUCCESS;
}
for (i = 0; i < KeyCell->NumberOfValues; i++)
{
- CurValueCell = CmiGetBlock(RegistryHive, ValueListCell->Values[i], NULL);
+ CurValueCell = CmiGetCell (RegistryHive, ValueListCell->ValueOffset[i], NULL);
if (CurValueCell == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT1("CmiGetBlock() failed\n");
return STATUS_UNSUCCESSFUL;
}
- if ((CurValueCell != NULL) &&
- CmiComparePackedNames(ValueName,
+ if (CmiComparePackedNames(ValueName,
CurValueCell->Name,
CurValueCell->NameSize,
- CurValueCell->Flags & REG_VALUE_NAME_PACKED))
+ (BOOLEAN)((CurValueCell->Flags & REG_VALUE_NAME_PACKED) ? TRUE : FALSE)))
{
- CmiDestroyValueCell(RegistryHive, CurValueCell, ValueListCell->Values[i]);
+ Status = CmiDestroyValueCell(RegistryHive,
+ CurValueCell,
+ ValueListCell->ValueOffset[i]);
+ if (CurValueCell == NULL)
+ {
+ DPRINT1("CmiDestroyValueCell() failed\n");
+ return Status;
+ }
- if ((KeyCell->NumberOfValues - 1) < i)
+ if (i < (KeyCell->NumberOfValues - 1))
{
- RtlCopyMemory(&ValueListCell->Values[i],
- &ValueListCell->Values[i + 1],
+ RtlMoveMemory(&ValueListCell->ValueOffset[i],
+ &ValueListCell->ValueOffset[i + 1],
sizeof(BLOCK_OFFSET) * (KeyCell->NumberOfValues - 1 - i));
}
+ ValueListCell->ValueOffset[KeyCell->NumberOfValues - 1] = 0;
+
+
+ KeyCell->NumberOfValues--;
+
+ if (KeyCell->NumberOfValues == 0)
+ {
+ CmiDestroyCell(RegistryHive,
+ ValueListCell,
+ KeyCell->ValueListOffset);
+ KeyCell->ValueListOffset = -1;
+ }
else
{
- RtlZeroMemory(&ValueListCell->Values[i], sizeof(BLOCK_OFFSET));
+ CmiMarkBlockDirty(RegistryHive,
+ KeyCell->ValueListOffset);
}
- KeyCell->NumberOfValues -= 1;
- break;
- }
- }
+ CmiMarkBlockDirty(RegistryHive,
+ KeyCellOffset);
- if (KeyCell->NumberOfValues == 0)
- {
- CmiDestroyBlock(RegistryHive,
- ValueListCell,
- KeyCell->ValuesOffset);
- }
- else
- {
- CmiMarkBlockDirty(RegistryHive,
- KeyCell->ValuesOffset);
+ return STATUS_SUCCESS;
+ }
}
- CmiMarkBlockDirty(RegistryHive,
- KeyCellOffset);
+ DPRINT("Couldn't find the desired value\n");
- return STATUS_SUCCESS;
+ return STATUS_OBJECT_NAME_NOT_FOUND;
}
NTSTATUS
-CmiAllocateHashTableBlock(IN PREGISTRY_HIVE RegistryHive,
+CmiAllocateHashTableCell (IN PREGISTRY_HIVE RegistryHive,
OUT PHASH_TABLE_CELL *HashBlock,
OUT BLOCK_OFFSET *HBOffset,
- IN ULONG HashTableSize)
+ IN ULONG SubKeyCount)
{
PHASH_TABLE_CELL NewHashBlock;
ULONG NewHashSize;
Status = STATUS_SUCCESS;
*HashBlock = NULL;
NewHashSize = sizeof(HASH_TABLE_CELL) +
- (HashTableSize - 1) * sizeof(HASH_RECORD);
- Status = CmiAllocateBlock(RegistryHive,
- (PVOID*) &NewHashBlock,
+ (SubKeyCount * sizeof(HASH_RECORD));
+ Status = CmiAllocateCell (RegistryHive,
NewHashSize,
+ (PVOID*) &NewHashBlock,
HBOffset);
if ((NewHashBlock == NULL) || (!NT_SUCCESS(Status)))
}
else
{
- NewHashBlock->Id = REG_HASH_TABLE_BLOCK_ID;
- NewHashBlock->HashTableSize = HashTableSize;
+ assert(SubKeyCount <= 0xffff); /* should really be USHORT_MAX or similar */
+ NewHashBlock->Id = REG_HASH_TABLE_CELL_ID;
+ NewHashBlock->HashTableSize = (USHORT)SubKeyCount;
*HashBlock = NewHashBlock;
}
else
{
KeyOffset = HashBlock->Table[Index].KeyOffset;
- KeyCell = CmiGetBlock(RegistryHive, KeyOffset, NULL);
+ KeyCell = CmiGetCell (RegistryHive, KeyOffset, NULL);
}
return KeyCell;
NTSTATUS
CmiAddKeyToHashTable(PREGISTRY_HIVE RegistryHive,
- PHASH_TABLE_CELL HashBlock,
+ PHASH_TABLE_CELL HashCell,
+ BLOCK_OFFSET HashCellOffset,
PKEY_CELL NewKeyCell,
BLOCK_OFFSET NKBOffset)
{
ULONG i;
- for (i = 0; i < HashBlock->HashTableSize; i++)
+ for (i = 0; i < HashCell->HashTableSize; i++)
{
- if (HashBlock->Table[i].KeyOffset == 0)
+ if (HashCell->Table[i].KeyOffset == 0)
{
- HashBlock->Table[i].KeyOffset = NKBOffset;
- HashBlock->Table[i].HashValue = 0;
+ HashCell->Table[i].KeyOffset = NKBOffset;
+ HashCell->Table[i].HashValue = 0;
if (NewKeyCell->Flags & REG_KEY_NAME_PACKED)
{
- RtlCopyMemory(&HashBlock->Table[i].HashValue,
+ RtlCopyMemory(&HashCell->Table[i].HashValue,
NewKeyCell->Name,
- min(NewKeyCell->NameSize, 4));
+ min(NewKeyCell->NameSize, sizeof(ULONG)));
}
+ CmiMarkBlockDirty(RegistryHive, HashCellOffset);
return STATUS_SUCCESS;
}
}
DPRINT("ValueName->Length %lu NameSize %lu\n", ValueName->Length, NameSize);
- Status = CmiAllocateBlock(RegistryHive,
- (PVOID*) &NewValueCell,
+ Status = CmiAllocateCell (RegistryHive,
sizeof(VALUE_CELL) + NameSize,
+ (PVOID*) &NewValueCell,
VBOffset);
if ((NewValueCell == NULL) || (!NT_SUCCESS(Status)))
{
}
else
{
+ assert(NameSize <= 0xffff); /* should really be USHORT_MAX or similar */
NewValueCell->Id = REG_VALUE_CELL_ID;
- NewValueCell->NameSize = NameSize;
+ NewValueCell->NameSize = (USHORT)NameSize;
if (Packable)
{
/* Pack the value name */
}
NewValueCell->DataType = 0;
NewValueCell->DataSize = 0;
- NewValueCell->DataOffset = 0xffffffff;
+ NewValueCell->DataOffset = (BLOCK_OFFSET)-1;
*ValueCell = NewValueCell;
}
NTSTATUS
CmiDestroyValueCell(PREGISTRY_HIVE RegistryHive,
PVALUE_CELL ValueCell,
- BLOCK_OFFSET VBOffset)
+ BLOCK_OFFSET ValueCellOffset)
{
NTSTATUS Status;
- PVOID pBlock;
- PHBIN pBin;
+ PVOID DataCell;
+ PHBIN Bin;
- DPRINT("CmiDestroyValueCell(Cell %p Offset %lx)\n", ValueCell, VBOffset);
+ DPRINT("CmiDestroyValueCell(Cell %p Offset %lx)\n",
+ ValueCell, ValueCellOffset);
VERIFY_VALUE_CELL(ValueCell);
/* Destroy the data cell */
- if (ValueCell->DataSize > 4)
+ if (ValueCell->DataSize > sizeof(BLOCK_OFFSET))
{
- pBlock = CmiGetBlock(RegistryHive, ValueCell->DataOffset, &pBin);
- if (pBlock == NULL)
+ DataCell = CmiGetCell (RegistryHive, ValueCell->DataOffset, &Bin);
+ if (DataCell == NULL)
{
- DPRINT("CmiGetBlock() failed\n");
+ DPRINT("CmiGetCell() failed\n");
return STATUS_UNSUCCESSFUL;
}
- Status = CmiDestroyBlock(RegistryHive, pBlock, ValueCell->DataOffset);
+ Status = CmiDestroyCell (RegistryHive, DataCell, ValueCell->DataOffset);
if (!NT_SUCCESS(Status))
{
- return Status;
+ return Status;
}
/* Update time of heap */
if (!IsNoFileHive(RegistryHive))
- NtQuerySystemTime((PTIME) &pBin->DateModified);
+ NtQuerySystemTime(&Bin->DateModified);
}
/* Destroy the value cell */
- Status = CmiDestroyBlock(RegistryHive, ValueCell, VBOffset);
+ Status = CmiDestroyCell (RegistryHive, ValueCell, ValueCellOffset);
/* Update time of heap */
- if (!IsNoFileHive(RegistryHive) && CmiGetBlock(RegistryHive, VBOffset, &pBin))
+ if (!IsNoFileHive(RegistryHive) && CmiGetCell (RegistryHive, ValueCellOffset, &Bin))
{
- NtQuerySystemTime((PTIME) &pBin->DateModified);
+ NtQuerySystemTime(&Bin->DateModified);
}
return Status;
NTSTATUS
CmiAddBin(PREGISTRY_HIVE RegistryHive,
+ ULONG BlockCount,
PVOID *NewBlock,
BLOCK_OFFSET *NewBlockOffset)
{
+ PBLOCK_LIST_ENTRY BlockList;
PCELL_HEADER tmpBlock;
- PHBIN * tmpBlockList;
PHBIN tmpBin;
+ ULONG BinSize;
+ ULONG i;
- tmpBin = ExAllocatePool(PagedPool, REG_BLOCK_SIZE);
+ DPRINT ("CmiAddBin (BlockCount %lu)\n", BlockCount);
+
+ BinSize = BlockCount * REG_BLOCK_SIZE;
+ tmpBin = ExAllocatePool(PagedPool, BinSize);
if (tmpBin == NULL)
{
return STATUS_INSUFFICIENT_RESOURCES;
}
+ RtlZeroMemory (tmpBin,
+ BinSize);
- tmpBin->BlockId = REG_BIN_ID;
- tmpBin->BlockOffset = RegistryHive->FileSize - REG_BLOCK_SIZE;
- RegistryHive->FileSize += REG_BLOCK_SIZE;
- tmpBin->BlockSize = REG_BLOCK_SIZE;
+ tmpBin->HeaderId = REG_BIN_ID;
+ tmpBin->BinOffset = RegistryHive->FileSize - REG_BLOCK_SIZE;
+ RegistryHive->FileSize += BinSize;
+ tmpBin->BinSize = BinSize;
tmpBin->Unused1 = 0;
- ZwQuerySystemTime((PTIME) &tmpBin->DateModified);
+ NtQuerySystemTime(&tmpBin->DateModified);
tmpBin->Unused2 = 0;
- /* Increase size of list of blocks */
- tmpBlockList = ExAllocatePool(NonPagedPool,
- sizeof(PHBIN *) * (RegistryHive->BlockListSize + 1));
- if (tmpBlockList == NULL)
+ DPRINT (" BinOffset %lx BinSize %lx\n", tmpBin->BinOffset,tmpBin->BinSize);
+
+ /* Allocate new block list */
+ BlockList = ExAllocatePool(NonPagedPool,
+ sizeof(BLOCK_LIST_ENTRY) * (RegistryHive->BlockListSize + BlockCount));
+ if (BlockList == NULL)
{
ExFreePool(tmpBin);
return STATUS_INSUFFICIENT_RESOURCES;
if (RegistryHive->BlockListSize > 0)
{
- RtlCopyMemory (tmpBlockList,
+ RtlCopyMemory (BlockList,
RegistryHive->BlockList,
- sizeof(PHBIN *)*(RegistryHive->BlockListSize));
+ sizeof(BLOCK_LIST_ENTRY) * RegistryHive->BlockListSize);
ExFreePool(RegistryHive->BlockList);
}
- RegistryHive->BlockList = tmpBlockList;
- RegistryHive->BlockList[RegistryHive->BlockListSize] = tmpBin;
- RegistryHive->BlockListSize++;
+ RegistryHive->BlockList = BlockList;
+ for (i = 0; i < BlockCount; i++)
+ {
+ RegistryHive->BlockList[RegistryHive->BlockListSize + i].Block =
+ (PVOID)((ULONG_PTR)tmpBin + (i * REG_BLOCK_SIZE));
+ RegistryHive->BlockList[RegistryHive->BlockListSize + i].Bin = tmpBin;
+ }
+ RegistryHive->BlockListSize += BlockCount;
/* Initialize a free block in this heap : */
tmpBlock = (PCELL_HEADER)((ULONG_PTR) tmpBin + REG_HBIN_DATA_OFFSET);
- tmpBlock->CellSize = (REG_BLOCK_SIZE - REG_HBIN_DATA_OFFSET);
+ tmpBlock->CellSize = (BinSize - REG_HBIN_DATA_OFFSET);
/* Grow bitmap if necessary */
if (IsNoFileHive(RegistryHive) &&
*NewBlock = (PVOID) tmpBlock;
if (NewBlockOffset)
- *NewBlockOffset = tmpBin->BlockOffset + REG_HBIN_DATA_OFFSET;
+ *NewBlockOffset = tmpBin->BinOffset + REG_HBIN_DATA_OFFSET;
/* Mark new bin dirty */
CmiMarkBinDirty(RegistryHive,
- tmpBin->BlockOffset);
+ tmpBin->BinOffset);
return STATUS_SUCCESS;
}
NTSTATUS
-CmiAllocateBlock(PREGISTRY_HIVE RegistryHive,
- PVOID *Block,
- LONG BlockSize,
- BLOCK_OFFSET * pBlockOffset)
+CmiAllocateCell (PREGISTRY_HIVE RegistryHive,
+ LONG CellSize,
+ PVOID *Cell,
+ BLOCK_OFFSET *CellOffset)
{
- PCELL_HEADER NewBlock;
- NTSTATUS Status;
- PHBIN pBin;
+ PCELL_HEADER NewCell;
+ PHBIN Bin;
ULONG i;
PVOID Temp;
-
- Status = STATUS_SUCCESS;
+ NTSTATUS Status;
/* Round to 16 bytes multiple */
- BlockSize = (BlockSize + sizeof(DWORD) + 15) & 0xfffffff0;
+ CellSize = ROUND_UP(CellSize, 16);
/* Handle volatile hives first */
if (IsPointerHive(RegistryHive))
{
- NewBlock = ExAllocatePool(NonPagedPool, BlockSize);
-
- if (NewBlock == NULL)
- {
- Status = STATUS_INSUFFICIENT_RESOURCES;
- }
- else
+ NewCell = ExAllocatePool(NonPagedPool, CellSize);
+ if (NewCell == NULL)
{
- RtlZeroMemory(NewBlock, BlockSize);
- NewBlock->CellSize = BlockSize;
- *Block = NewBlock;
- if (pBlockOffset)
- *pBlockOffset = (BLOCK_OFFSET) NewBlock;
+ return STATUS_INSUFFICIENT_RESOURCES;
}
+
+ RtlZeroMemory (NewCell,
+ CellSize);
+ NewCell->CellSize = -CellSize;
+
+ *Cell = NewCell;
+ if (CellOffset != NULL)
+ *CellOffset = (BLOCK_OFFSET) NewCell;
}
else
{
/* first search in free blocks */
- NewBlock = NULL;
+ NewCell = NULL;
for (i = 0; i < RegistryHive->FreeListSize; i++)
{
- if (RegistryHive->FreeList[i]->CellSize >= BlockSize)
+ if (RegistryHive->FreeList[i]->CellSize >= CellSize)
{
- NewBlock = RegistryHive->FreeList[i];
- if (pBlockOffset)
- *pBlockOffset = RegistryHive->FreeListOffset[i];
+ NewCell = RegistryHive->FreeList[i];
+ if (CellOffset != NULL)
+ *CellOffset = RegistryHive->FreeListOffset[i];
/* Update time of heap */
- Temp = CmiGetBlock(RegistryHive, RegistryHive->FreeListOffset[i], &pBin);
+ Temp = CmiGetCell (RegistryHive,
+ RegistryHive->FreeListOffset[i],
+ &Bin);
if (Temp == NULL)
{
DPRINT("CmiGetBlock() failed\n");
return STATUS_UNSUCCESSFUL;
}
- if (Temp)
- {
- NtQuerySystemTime((PTIME) &pBin->DateModified);
- CmiMarkBlockDirty(RegistryHive, RegistryHive->FreeListOffset[i]);
- }
+ NtQuerySystemTime(&Bin->DateModified);
+ CmiMarkBlockDirty(RegistryHive, RegistryHive->FreeListOffset[i]);
if ((i + 1) < RegistryHive->FreeListSize)
{
}
/* Need to extend hive file : */
- if (NewBlock == NULL)
+ if (NewCell == NULL)
{
- /* Add a new block */
- Status = CmiAddBin(RegistryHive, (PVOID *) &NewBlock , pBlockOffset);
+ /* Add a new bin */
+ Status = CmiAddBin(RegistryHive,
+ ((CellSize + sizeof(HBIN) - 1) / REG_BLOCK_SIZE) + 1,
+ (PVOID *)&NewCell,
+ CellOffset);
+ if (!NT_SUCCESS(Status))
+ return Status;
}
- if (NT_SUCCESS(Status))
- {
- *Block = NewBlock;
+ *Cell = NewCell;
- /* Split the block in two parts */
- if (NewBlock->CellSize > BlockSize)
- {
- NewBlock = (PCELL_HEADER) ((ULONG_PTR) NewBlock+BlockSize);
- NewBlock->CellSize = ((PCELL_HEADER) (*Block))->CellSize - BlockSize;
- CmiAddFree(RegistryHive,
- NewBlock,
- *pBlockOffset + BlockSize,
- TRUE);
- CmiMarkBlockDirty(RegistryHive,
- *pBlockOffset + BlockSize);
- }
- else if (NewBlock->CellSize < BlockSize)
- {
- return(STATUS_UNSUCCESSFUL);
- }
-
- RtlZeroMemory(*Block, BlockSize);
- ((PCELL_HEADER) (*Block))->CellSize = -BlockSize;
+ /* Split the block in two parts */
+ if (NewCell->CellSize > CellSize)
+ {
+ NewCell = (PCELL_HEADER) ((ULONG_PTR) NewCell + CellSize);
+ NewCell->CellSize = ((PCELL_HEADER) (*Cell))->CellSize - CellSize;
+ CmiAddFree(RegistryHive,
+ NewCell,
+ *CellOffset + CellSize,
+ TRUE);
+ CmiMarkBlockDirty(RegistryHive,
+ *CellOffset + CellSize);
+ }
+ else if (NewCell->CellSize < CellSize)
+ {
+ return STATUS_UNSUCCESSFUL;
}
+
+ RtlZeroMemory(*Cell,
+ CellSize);
+ ((PCELL_HEADER) (*Cell))->CellSize = -CellSize;
}
- return(Status);
+ return STATUS_SUCCESS;
}
NTSTATUS
-CmiDestroyBlock(PREGISTRY_HIVE RegistryHive,
- PVOID Block,
- BLOCK_OFFSET Offset)
+CmiDestroyCell (PREGISTRY_HIVE RegistryHive,
+ PVOID Cell,
+ BLOCK_OFFSET CellOffset)
{
NTSTATUS Status;
PHBIN pBin;
if (IsPointerHive(RegistryHive))
{
- ExFreePool(Block);
+ ExFreePool(Cell);
}
else
{
- PCELL_HEADER pFree = Block;
+ PCELL_HEADER pFree = Cell;
if (pFree->CellSize < 0)
pFree->CellSize = -pFree->CellSize;
/* Clear block (except the block size) */
- RtlZeroMemory(((PVOID)pFree) + sizeof(ULONG),
+ RtlZeroMemory(((char*)pFree) + sizeof(ULONG),
pFree->CellSize - sizeof(ULONG));
/* Add block to the list of free blocks */
- CmiAddFree(RegistryHive, Block, Offset, TRUE);
+ CmiAddFree(RegistryHive, Cell, CellOffset, TRUE);
/* Update time of heap */
- if (!IsNoFileHive(RegistryHive) && CmiGetBlock(RegistryHive, Offset,&pBin))
- NtQuerySystemTime((PTIME) &pBin->DateModified);
+ if (!IsNoFileHive(RegistryHive) && CmiGetCell (RegistryHive, CellOffset,&pBin))
+ NtQuerySystemTime(&pBin->DateModified);
- CmiMarkBlockDirty(RegistryHive, Offset);
+ CmiMarkBlockDirty(RegistryHive, CellOffset);
}
return Status;
}
+PVOID
+CmiGetCell (PREGISTRY_HIVE RegistryHive,
+ BLOCK_OFFSET CellOffset,
+ PHBIN *Bin)
+{
+ PHBIN pBin;
+
+ if (Bin != NULL)
+ {
+ *Bin = NULL;
+ }
+
+ if (CellOffset == (BLOCK_OFFSET)-1)
+ {
+ return NULL;
+ }
+
+ if (IsPointerHive (RegistryHive))
+ {
+ return (PVOID)CellOffset;
+ }
+
+ if (CellOffset > RegistryHive->BlockListSize * REG_BLOCK_SIZE)
+ {
+ DPRINT1("CellOffset exceeds valid range (%lu > %lu)\n",
+ CellOffset, RegistryHive->BlockListSize * REG_BLOCK_SIZE);
+ return NULL;
+ }
+
+ pBin = RegistryHive->BlockList[CellOffset / REG_BLOCK_SIZE].Bin;
+ if (pBin == NULL)
+ {
+ return NULL;
+ }
+
+ if (Bin != NULL)
+ {
+ *Bin = pBin;
+ }
+
+ return((PVOID)((ULONG_PTR)pBin + (CellOffset - pBin->BinOffset)));
+}
+
+
static BOOLEAN
CmiMergeFree(PREGISTRY_HIVE RegistryHive,
PCELL_HEADER FreeBlock,
DPRINT("CmiMergeFree(Block %lx Offset %lx Size %lx) called\n",
FreeBlock, FreeOffset, FreeBlock->CellSize);
- CmiGetBlock(RegistryHive,
+ CmiGetCell (RegistryHive,
FreeOffset,
&Bin);
DPRINT("Bin %p\n", Bin);
if (Bin == NULL)
return(FALSE);
- BinOffset = Bin->BlockOffset;
- BinSize = Bin->BlockSize;
+ BinOffset = Bin->BinOffset;
+ BinSize = Bin->BinSize;
DPRINT("Bin %p Offset %lx Size %lx\n", Bin, BinOffset, BinSize);
for (i = 0; i < RegistryHive->FreeListSize; i++)
}
-PVOID
-CmiGetBlock(PREGISTRY_HIVE RegistryHive,
- BLOCK_OFFSET BlockOffset,
- PHBIN * ppBin)
-{
- PHBIN pBin;
-
- if (ppBin)
- *ppBin = NULL;
-
- if (BlockOffset == (BLOCK_OFFSET)-1)
- {
- return NULL;
- }
-
- if (IsPointerHive (RegistryHive))
- {
- return (PVOID)BlockOffset;
- }
- else
- {
- if (BlockOffset > RegistryHive->BlockListSize * 4096)
- {
- DPRINT1("BlockOffset exceeds valid range (%lu > %lu)\n",
- BlockOffset, RegistryHive->BlockListSize * 4096);
- return NULL;
- }
- pBin = RegistryHive->BlockList[BlockOffset / 4096];
- if (ppBin)
- *ppBin = pBin;
- return((PVOID)((ULONG_PTR)pBin + (BlockOffset - pBin->BlockOffset)));
- }
-}
-
-
VOID
CmiMarkBlockDirty(PREGISTRY_HIVE RegistryHive,
BLOCK_OFFSET BlockOffset)
DPRINT("CmiMarkBlockDirty(Offset 0x%lx)\n", (ULONG)BlockOffset);
- BlockNumber = (ULONG)BlockOffset / 4096;
+ BlockNumber = (ULONG)BlockOffset / REG_BLOCK_SIZE;
- Cell = CmiGetBlock(RegistryHive,
+ Cell = CmiGetCell (RegistryHive,
BlockOffset,
NULL);
if (CellSize < 0)
CellSize = -CellSize;
- BlockCount = (ROUND_UP(BlockOffset + CellSize, 4096) - ROUND_DOWN(BlockOffset, 4096)) / 4096;
+ BlockCount = (ROUND_UP(BlockOffset + CellSize, REG_BLOCK_SIZE) -
+ ROUND_DOWN(BlockOffset, REG_BLOCK_SIZE)) / REG_BLOCK_SIZE;
DPRINT(" BlockNumber %lu Size %lu (%s) BlockCount %lu\n",
BlockNumber,
DPRINT("CmiMarkBinDirty(Offset 0x%lx)\n", (ULONG)BinOffset);
- BlockNumber = (ULONG)BinOffset / 4096;
+ BlockNumber = (ULONG)BinOffset / REG_BLOCK_SIZE;
- Bin = RegistryHive->BlockList[BlockNumber];
+ Bin = RegistryHive->BlockList[BlockNumber].Bin;
- BlockCount = Bin->BlockSize / 4096;
+ BlockCount = Bin->BinSize / REG_BLOCK_SIZE;
- DPRINT(" BlockNumber %lu Size %lu BlockCount %lu\n",
+ DPRINT(" BlockNumber %lu BinSize %lu BlockCount %lu\n",
BlockNumber,
- Bin->BlockSize,
+ Bin->BinSize,
BlockCount);
RegistryHive->HiveDirty = TRUE;
ULONG i;
NTSTATUS Status;
- DPRINT1 ("CmiCopyKey() called\n");
+ DPRINT ("CmiCopyKey() called\n");
if (DstKeyCell == NULL)
{
/* Allocate and copy key cell */
NewKeyCellSize = sizeof(KEY_CELL) + SrcKeyCell->NameSize;
- Status = CmiAllocateBlock (DstHive,
- (PVOID) &NewKeyCell,
- NewKeyCellSize,
- &NewKeyCellOffset);
+ Status = CmiAllocateCell (DstHive,
+ NewKeyCellSize,
+ (PVOID) &NewKeyCell,
+ &NewKeyCellOffset);
if (!NT_SUCCESS(Status))
{
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
if (NewKeyCell == NULL)
{
+ DPRINT1 ("Failed to allocate a key cell\n");
return STATUS_INSUFFICIENT_RESOURCES;
}
SrcKeyCell,
NewKeyCellSize);
- DstHive->HiveHeader->RootKeyCell = NewKeyCellOffset;
+ DstHive->HiveHeader->RootKeyOffset = NewKeyCellOffset;
/* Copy class name */
- if (SrcKeyCell->ClassNameOffset != -1)
+ if (SrcKeyCell->ClassNameOffset != (BLOCK_OFFSET) -1)
{
PDATA_CELL SrcClassNameCell;
PDATA_CELL NewClassNameCell;
BLOCK_OFFSET NewClassNameOffset;
- SrcClassNameCell = CmiGetBlock (SrcHive, SrcKeyCell->ClassNameOffset, NULL),
+ SrcClassNameCell = CmiGetCell (SrcHive, SrcKeyCell->ClassNameOffset, NULL),
NewKeyCell->ClassSize = SrcKeyCell->ClassSize;
- Status = CmiAllocateBlock (DstHive,
- (PVOID)&NewClassNameCell,
- NewKeyCell->ClassSize,
- &NewClassNameOffset);
+ Status = CmiAllocateCell (DstHive,
+ sizeof(CELL_HEADER) + NewKeyCell->ClassSize,
+ (PVOID)&NewClassNameCell,
+ &NewClassNameOffset);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
if (SrcKeyCell->NumberOfSubKeys > 0)
{
NewHashTableSize = ROUND_UP(SrcKeyCell->NumberOfSubKeys + 1, 4) - 1;
- Status = CmiAllocateHashTableBlock (DstHive,
- &NewHashTableCell,
- &NewHashTableOffset,
- NewHashTableSize);
+ Status = CmiAllocateHashTableCell (DstHive,
+ &NewHashTableCell,
+ &NewHashTableOffset,
+ NewHashTableSize);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateHashTableBlock() failed (Status %lx)\n", Status);
return Status;
}
NewKeyCell->HashTableOffset = NewHashTableOffset;
NewValueListCellSize =
ROUND_UP(SrcKeyCell->NumberOfValues, 4) * sizeof(BLOCK_OFFSET);
- Status = CmiAllocateBlock (DstHive,
- (PVOID)&NewValueListCell,
- NewValueListCellSize,
- &NewKeyCell->ValuesOffset);
+ Status = CmiAllocateCell (DstHive,
+ NewValueListCellSize,
+ (PVOID)&NewValueListCell,
+ &NewKeyCell->ValueListOffset);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
NewValueListCellSize);
/* Copy values */
- SrcValueListCell = CmiGetBlock (SrcHive, SrcKeyCell->ValuesOffset, NULL);
+ SrcValueListCell = CmiGetCell (SrcHive, SrcKeyCell->ValueListOffset, NULL);
for (i = 0; i < SrcKeyCell->NumberOfValues; i++)
{
/* Copy value cell */
- SrcValueCell = CmiGetBlock (SrcHive, SrcValueListCell->Values[i], NULL);
+ SrcValueCell = CmiGetCell (SrcHive, SrcValueListCell->ValueOffset[i], NULL);
NewValueCellSize = sizeof(VALUE_CELL) + SrcValueCell->NameSize;
- Status = CmiAllocateBlock (DstHive,
- (PVOID*) &NewValueCell,
- NewValueCellSize,
- &ValueCellOffset);
+ Status = CmiAllocateCell (DstHive,
+ NewValueCellSize,
+ (PVOID*) &NewValueCell,
+ &ValueCellOffset);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
- NewValueListCell->Values[i] = ValueCellOffset;
+ NewValueListCell->ValueOffset[i] = ValueCellOffset;
RtlCopyMemory (NewValueCell,
SrcValueCell,
NewValueCellSize);
/* Copy value data cell */
- if (SrcValueCell->DataSize > sizeof(PVOID))
+ if (SrcValueCell->DataSize > (LONG) sizeof(PVOID))
{
- SrcValueDataCell = CmiGetBlock (SrcHive, SrcValueCell->DataOffset, NULL);
+ SrcValueDataCell = CmiGetCell (SrcHive, SrcValueCell->DataOffset, NULL);
- Status = CmiAllocateBlock (DstHive,
- (PVOID*) &NewValueDataCell,
- SrcValueCell->DataSize,
- &ValueDataCellOffset);
+ Status = CmiAllocateCell (DstHive,
+ sizeof(CELL_HEADER) + SrcValueCell->DataSize,
+ (PVOID*) &NewValueDataCell,
+ &ValueDataCellOffset);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
RtlCopyMemory (NewValueDataCell,
BLOCK_OFFSET NewSubKeyCellOffset;
PHASH_RECORD SrcHashRecord;
- SrcHashTableCell = CmiGetBlock (SrcHive,
- SrcKeyCell->HashTableOffset,
- NULL);
+ SrcHashTableCell = CmiGetCell (SrcHive,
+ SrcKeyCell->HashTableOffset,
+ NULL);
for (i = 0; i < SrcKeyCell->NumberOfSubKeys; i++)
{
SrcHashRecord = &SrcHashTableCell->Table[i];
- SrcSubKeyCell = CmiGetBlock (SrcHive, SrcHashRecord->KeyOffset, NULL);
+ SrcSubKeyCell = CmiGetCell (SrcHive, SrcHashRecord->KeyOffset, NULL);
/* Allocate and copy key cell */
NewSubKeyCellSize = sizeof(KEY_CELL) + SrcSubKeyCell->NameSize;
- Status = CmiAllocateBlock (DstHive,
- (PVOID)&NewSubKeyCell,
- NewSubKeyCellSize,
- &NewSubKeyCellOffset);
+ Status = CmiAllocateCell (DstHive,
+ NewSubKeyCellSize,
+ (PVOID)&NewSubKeyCell,
+ &NewSubKeyCellOffset);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
if (NewKeyCell == NULL)
{
-CHECKPOINT1;
+ DPRINT1 ("Failed to allocate a sub key cell\n");
return STATUS_INSUFFICIENT_RESOURCES;
}
NewSubKeyCellSize);
/* Copy class name */
- if (SrcSubKeyCell->ClassNameOffset != -1)
+ if (SrcSubKeyCell->ClassNameOffset != (BLOCK_OFFSET) -1)
{
PDATA_CELL SrcClassNameCell;
PDATA_CELL NewClassNameCell;
BLOCK_OFFSET NewClassNameOffset;
- SrcClassNameCell = CmiGetBlock (SrcHive,
- SrcSubKeyCell->ClassNameOffset,
- NULL),
+ SrcClassNameCell = CmiGetCell (SrcHive,
+ SrcSubKeyCell->ClassNameOffset,
+ NULL),
NewSubKeyCell->ClassSize = SrcSubKeyCell->ClassSize;
- Status = CmiAllocateBlock (DstHive,
- (PVOID)&NewClassNameCell,
- NewSubKeyCell->ClassSize,
- &NewClassNameOffset);
+ Status = CmiAllocateCell (DstHive,
+ sizeof(CELL_HEADER) + NewSubKeyCell->ClassSize,
+ (PVOID)&NewClassNameCell,
+ &NewClassNameOffset);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
SrcSubKeyCell);
if (!NT_SUCCESS(Status))
{
-CHECKPOINT1;
+ DPRINT1 ("CmiAllocateBlock() failed (Status %lx)\n", Status);
return Status;
}
}
Hive->HiveHeader->Checksum = CmiCalcChecksum ((PULONG)Hive->HiveHeader);
/* Write hive block */
- FileOffset.QuadPart = 0ULL;
+ FileOffset.QuadPart = (ULONGLONG)0;
Status = NtWriteFile (FileHandle,
NULL,
NULL,
DPRINT ("Saving %lu blocks\n", Hive->BlockListSize);
for (BlockIndex = 0; BlockIndex < Hive->BlockListSize; BlockIndex++)
{
- BlockPtr = Hive->BlockList[BlockIndex];
+ BlockPtr = Hive->BlockList[BlockIndex].Block;
DPRINT ("BlockPtr %p\n", BlockPtr);
- FileOffset.QuadPart = (ULONGLONG)(BlockIndex + 1) * 4096ULL;
+ FileOffset.QuadPart = (ULONGLONG)(BlockIndex + 1) * (ULONGLONG)REG_BLOCK_SIZE;
DPRINT ("File offset %I64x\n", FileOffset.QuadPart);
/* Write hive block */