* COPYRIGHT: See COPYING in the top level directory
* PROJECT: ReactOS Win32k subsystem
* PURPOSE: Windows
- * FILE: subsystems/win32/win32k/ntuser/window.c
+ * FILE: win32ss/user/ntuser/window.c
* PROGRAMER: Casper S. Hornstrup (chorns@users.sourceforge.net)
*/
{
HWND hWnd;
UINT State, State2;
+ ULONG Error;
if (!pWnd) return NULL;
+ Error = EngGetLastError();
+
_SEH2_TRY
{
hWnd = UserHMGetHandle(pWnd);
}
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
{
+ EngSetLastError(Error);
_SEH2_YIELD(return NULL);
}
_SEH2_END
if ( UserObjectInDestroy(hWnd) ||
State & WNDS_DESTROYED ||
State2 & WNDS2_INDESTROY )
- return NULL;
+ pWnd = NULL;
+ EngSetLastError(Error);
return pWnd;
}
pwnd->style = styleNew;
if ((styleOld ^ styleNew) & WS_VISIBLE) // State Change.
{
- if (styleOld & WS_VISIBLE) pwnd->head.pti->cVisWindows--;
+ if (styleOld & WS_VISIBLE) pwnd->head.pti->cVisWindows--;
if (styleNew & WS_VISIBLE) pwnd->head.pti->cVisWindows++;
DceResetActiveDCEs( pwnd );
}
if (Wnd->spwndPrev != NULL)
FoundWnd = Wnd->spwndPrev;
break;
-
+
case GW_CHILD:
if (Wnd->spwndChild != NULL)
FoundWnd = Wnd->spwndChild;
return Ret;
}
+DWORD FASTCALL IntGetWindowContextHelpId( PWND pWnd )
+{
+ DWORD HelpId;
+
+ do
+ {
+ HelpId = (DWORD)(DWORD_PTR)UserGetProp(pWnd, gpsi->atomContextHelpIdProp, TRUE);
+ if (!HelpId) break;
+ pWnd = IntGetParent(pWnd);
+ }
+ while (pWnd && pWnd->fnid != FNID_DESKTOP);
+ return HelpId;
+}
+
/***********************************************************************
* IntSendDestroyMsg
*/
static void IntSendDestroyMsg(HWND hWnd)
{
-
+ PTHREADINFO ti;
PWND Window;
-#if 0 /* FIXME */
- GUITHREADINFO info;
+ ti = PsGetCurrentThreadWin32Thread();
+ Window = UserGetWindowObject(hWnd);
- if (GetGUIThreadInfo(GetCurrentThreadId(), &info))
+ if (Window)
{
- if (hWnd == info.hwndCaret)
+ /* Look whether the focus is within the tree of windows we will
+ * be destroying.
+ */
+ // Rule #1
+ if ( ti->MessageQueue->spwndActive == Window || // Fixes CORE-106 RegSvr32 exit and return focus to CMD.
+ (ti->MessageQueue->spwndActive == NULL && ti->MessageQueue == IntGetFocusMessageQueue()) )
{
- DestroyCaret();
+ co_WinPosActivateOtherWindow(Window);
}
- }
-#endif
- Window = UserGetWindowObject(hWnd);
- if (Window)
- {
-// USER_REFERENCE_ENTRY Ref;
-// UserRefObjectCo(Window, &Ref);
-
- if (!Window->spwndOwner && !IntGetParent(Window))
+ /* Fixes CMD properties closing and returning focus to CMD */
+ if (ti->MessageQueue->spwndFocus == Window)
{
- co_IntShellHookNotify(HSHELL_WINDOWDESTROYED, (WPARAM) hWnd, 0);
+ if ((Window->style & (WS_CHILD | WS_POPUP)) == WS_CHILD)
+ {
+ co_UserSetFocus(Window->spwndParent);
+ }
+ else
+ {
+ co_UserSetFocus(NULL);
+ }
}
-// UserDerefObjectCo(Window);
+ if (ti->MessageQueue->CaretInfo.hWnd == UserHMGetHandle(Window))
+ {
+ co_IntDestroyCaret(ti);
+ }
}
- /* The window could already be destroyed here */
-
/*
* Send the WM_DESTROY to the window.
*/
* This WM_DESTROY message can trigger re-entrant calls to DestroyWindow
* make sure that the window still exists when we come back.
*/
-#if 0 /* FIXME */
- if (IsWindow(Wnd))
+ if (IntIsWindow(hWnd))
{
HWND* pWndArray;
int i;
- if (!(pWndArray = WIN_ListChildren( hwnd )))
- return;
+ if (!(pWndArray = IntWinListChildren( Window ))) return;
- /* start from the end (FIXME: is this needed?) */
for (i = 0; pWndArray[i]; i++)
- ;
-
- while (--i >= 0)
{
- if (IsWindow( pWndArray[i] ))
- WIN_SendDestroyMsg( pWndArray[i] );
+ if (IntIsWindow( pWndArray[i] )) IntSendDestroyMsg( pWndArray[i] );
}
- HeapFree(GetProcessHeap(), 0, pWndArray);
+ ExFreePoolWithTag(pWndArray, USERTAG_WINDOWLIST);
}
else
{
TRACE("destroyed itself while in WM_DESTROY!\n");
}
-#endif
}
static VOID
* done in CreateWindow is undone here and not in DestroyWindow:-P
*/
-static LRESULT co_UserFreeWindow(PWND Window,
- PPROCESSINFO ProcessData,
- PTHREADINFO ThreadData,
- BOOLEAN SendMessages)
+LRESULT co_UserFreeWindow(PWND Window,
+ PPROCESSINFO ProcessData,
+ PTHREADINFO ThreadData,
+ BOOLEAN SendMessages)
{
HWND *Children;
HWND *ChildHandle;
Window->style &= ~WS_VISIBLE;
Window->head.pti->cVisWindows--;
- IntNotifyWinEvent(EVENT_OBJECT_DESTROY, Window, OBJID_WINDOW, CHILDID_SELF, 0);
/* remove the window already at this point from the thread window list so we
don't get into trouble when destroying the thread windows while we're still
BelongsToThreadData = IntWndBelongsToThread(Window, ThreadData);
- IntDeRegisterShellHookWindow(Window->head.h);
-
- if(SendMessages)
- {
- /* Send destroy messages */
- IntSendDestroyMsg(Window->head.h);
- }
+ IntDeRegisterShellHookWindow(UserHMGetHandle(Window));
/* free child windows */
Children = IntWinListChildren(Window);
if(!IntWndBelongsToThread(Child, ThreadData))
{
/* send WM_DESTROY messages to windows not belonging to the same thread */
- IntSendDestroyMsg(Child->head.h);
+ co_IntSendMessage( UserHMGetHandle(Child), WM_ASYNC_DESTROYWINDOW, 0, 0 );
}
else
co_UserFreeWindow(Child, ProcessData, ThreadData, SendMessages);
RDW_VALIDATE | RDW_NOFRAME | RDW_NOERASE |
RDW_NOINTERNALPAINT | RDW_NOCHILDREN);
if(BelongsToThreadData)
- co_IntSendMessage(Window->head.h, WM_NCDESTROY, 0, 0);
+ co_IntSendMessage(UserHMGetHandle(Window), WM_NCDESTROY, 0, 0);
}
DestroyTimersForWindow(ThreadData, Window);
/* Unregister hot keys */
- UnregisterWindowHotKeys (Window);
+ UnregisterWindowHotKeys(Window);
/* flush the message queue */
MsqRemoveWindowMessagesFromQueue(Window);
ThreadData->rpdesk->rpwinstaParent->ShellListView = NULL;
}
- /* FIXME: do we need to fake QS_MOUSEMOVE wakebit? */
+ /* Fixes dialog test_focus breakage due to r66237. */
+ if (ThreadData->MessageQueue->spwndFocus == Window)
+ ThreadData->MessageQueue->spwndFocus = NULL;
-#if 0 /* FIXME */
+ if (ThreadData->MessageQueue->spwndActive == Window)
+ ThreadData->MessageQueue->spwndActive = NULL;
- WinPosCheckInternalPos(Window->head.h);
- if (Window->head.h == GetCapture())
+ if (ThreadData->MessageQueue->spwndCapture == Window)
{
- ReleaseCapture();
+ IntReleaseCapture();
}
- /* free resources associated with the window */
- TIMER_RemoveWindowTimers(Window->head.h);
-#endif
+ //// Now kill those remaining "PAINTING BUG: Thread marked as containing dirty windows" spam!!!
+ if ( Window->hrgnUpdate != NULL || Window->state & WNDS_INTERNALPAINT )
+ {
+ MsqDecPaintCountQueue(Window->head.pti);
+ if (Window->hrgnUpdate > HRGN_WINDOW && GreIsHandleValid(Window->hrgnUpdate))
+ {
+ GreDeleteObject(Window->hrgnUpdate);
+ }
+ Window->hrgnUpdate = NULL;
+ Window->state &= ~WNDS_INTERNALPAINT;
+ }
+
+ if (Window->state & (WNDS_SENDERASEBACKGROUND|WNDS_SENDNCPAINT))
+ {
+ Window->state &= ~(WNDS_SENDERASEBACKGROUND|WNDS_SENDNCPAINT);
+ }
if ( ((Window->style & (WS_CHILD|WS_POPUP)) != WS_CHILD) &&
Window->IDMenu &&
(Menu = UserGetMenuObject((HMENU)Window->IDMenu)))
{
- IntDestroyMenuObject(Menu, TRUE, TRUE);
+ TRACE("UFW: IDMenu %p\n",Window->IDMenu);
+ IntDestroyMenuObject(Menu, TRUE);
Window->IDMenu = 0;
}
if(Window->SystemMenu
&& (Menu = UserGetMenuObject(Window->SystemMenu)))
{
- IntDestroyMenuObject(Menu, TRUE, TRUE);
+ IntDestroyMenuObject(Menu, TRUE);
Window->SystemMenu = (HMENU)0;
}
DceFreeWindowDCE(Window); /* Always do this to catch orphaned DCs */
-#if 0 /* FIXME */
-
- WINPROC_FreeProc(Window->winproc, WIN_PROC_WINDOW);
- CLASS_RemoveWindow(Window->Class);
-#endif
IntUnlinkWindow(Window);
if (Window->PropListItems)
{
- IntRemoveWindowProp(Window);
- TRACE("Window->PropListItems %d\n",Window->PropListItems);
+ UserRemoveWindowProps(Window);
+ TRACE("Window->PropListItems %lu\n",Window->PropListItems);
ASSERT(Window->PropListItems==0);
}
UserReferenceObject(Window);
- UserDeleteObject(Window->head.h, TYPE_WINDOW);
+ UserDeleteObject(UserHMGetHandle(Window), TYPE_WINDOW);
IntDestroyScrollBars(Window);
+ if (Window->pcls->atomClassName == gaGuiConsoleWndClass)
+ {
+ /* Count only console windows manually */
+ co_IntUserManualGuiCheck(FALSE);
+ }
+
/* dereference the class */
+ NT_ASSERT(Window->head.pti != NULL);
IntDereferenceClass(Window->pcls,
Window->head.pti->pDeskInfo,
Window->head.pti->ppi);
return Ret;
}
-static BOOL FASTCALL
-IntSetMenu(
- PWND Wnd,
- HMENU Menu,
- BOOL *Changed)
-{
- PMENU OldMenu, NewMenu = NULL;
-
- if ((Wnd->style & (WS_CHILD | WS_POPUP)) == WS_CHILD)
- {
- ERR("SetMenu: Invalid handle 0x%p!\n",UserHMGetHandle(Wnd));
- EngSetLastError(ERROR_INVALID_WINDOW_HANDLE);
- return FALSE;
- }
-
- *Changed = (Wnd->IDMenu != (UINT) Menu);
- if (! *Changed)
- {
- return TRUE;
- }
-
- if (Wnd->IDMenu)
- {
- OldMenu = IntGetMenuObject((HMENU) Wnd->IDMenu);
- ASSERT(NULL == OldMenu || OldMenu->hWnd == Wnd->head.h);
- }
- else
- {
- OldMenu = NULL;
- }
-
- if (NULL != Menu)
- {
- NewMenu = IntGetMenuObject(Menu);
- if (NULL == NewMenu)
- {
- if (NULL != OldMenu)
- {
- IntReleaseMenuObject(OldMenu);
- }
- EngSetLastError(ERROR_INVALID_MENU_HANDLE);
- return FALSE;
- }
- if (NULL != NewMenu->hWnd)
- {
- /* Can't use the same menu for two windows */
- if (NULL != OldMenu)
- {
- IntReleaseMenuObject(OldMenu);
- }
- EngSetLastError(ERROR_INVALID_MENU_HANDLE);
- return FALSE;
- }
-
- }
-
- Wnd->IDMenu = (UINT) Menu;
- if (NULL != NewMenu)
- {
- NewMenu->hWnd = Wnd->head.h;
- IntReleaseMenuObject(NewMenu);
- }
- if (NULL != OldMenu)
- {
- OldMenu->hWnd = NULL;
- IntReleaseMenuObject(OldMenu);
- }
-
- return TRUE;
-}
-
/* INTERNAL ******************************************************************/
-
-VOID FASTCALL
-co_DestroyThreadWindows(struct _ETHREAD *Thread)
-{
- PTHREADINFO WThread;
- PLIST_ENTRY Current;
- PWND Wnd;
- USER_REFERENCE_ENTRY Ref;
- WThread = (PTHREADINFO)Thread->Tcb.Win32Thread;
-
- while (!IsListEmpty(&WThread->WindowListHead))
- {
- Current = WThread->WindowListHead.Flink;
- Wnd = CONTAINING_RECORD(Current, WND, ThreadListEntry);
-
- TRACE("thread cleanup: while destroy wnds, wnd=%p\n", Wnd);
-
- /* Window removes itself from the list */
-
- /*
- * FIXME: It is critical that the window removes itself! If now, we will loop
- * here forever...
- */
-
- //ASSERT(co_UserDestroyWindow(Wnd));
-
- UserRefObjectCo(Wnd, &Ref); // FIXME: Temp HACK??
- if (!co_UserDestroyWindow(Wnd))
- {
- ERR("Unable to destroy window %p at thread cleanup... This is _VERY_ bad!\n", Wnd);
- }
- UserDerefObjectCo(Wnd); // FIXME: Temp HACK??
- }
-}
-
+////
+// This fixes a check for children messages that need paint while searching the parents messages!
+// Fixes wine msg:test_paint_messages:WmParentErasePaint ..
+////
BOOL FASTCALL
IntIsChildWindow(PWND Parent, PWND BaseWindow)
{
- PWND Window;
-
- Window = BaseWindow;
- while (Window && ((Window->style & (WS_POPUP|WS_CHILD)) == WS_CHILD))
+ PWND Window = BaseWindow;
+ do
{
- if (Window == Parent)
- {
- return(TRUE);
- }
+ if ( Window == NULL || (Window->style & (WS_POPUP|WS_CHILD)) != WS_CHILD )
+ return FALSE;
- Window = Window->spwndParent;
+ Window = Window->spwndParent;
}
-
- return(FALSE);
+ while(Parent != Window);
+ return TRUE;
}
+////
/*
Link the window into siblings list
{
if ( Wnd->spwndParent != co_GetDesktopWindow(Wnd))
{
- if (Wnd->head.pti != WndOldParent->head.pti)
+ if (WndOldParent && (Wnd->head.pti != WndOldParent->head.pti))
{
//ERR("SetParent Old out.\n");
UserAttachThreadInput(Wnd->head.pti, WndOldParent->head.pti, FALSE);
{
PETHREAD Thread;
PTHREADINFO W32Thread;
- PLIST_ENTRY Current;
PWND Window;
+ HWND *List = NULL;
Status = PsLookupThreadByThreadId((HANDLE)dwThreadId, &Thread);
if (!NT_SUCCESS(Status))
if (!(W32Thread = (PTHREADINFO)Thread->Tcb.Win32Thread))
{
ObDereferenceObject(Thread);
- ERR("Thread is not initialized!\n");
+ TRACE("Tried to enumerate windows of a non gui thread\n");
return ERROR_INVALID_PARAMETER;
}
- Current = W32Thread->WindowListHead.Flink;
- while (Current != &(W32Thread->WindowListHead))
+ // Do not use Thread link list due to co_UserFreeWindow!!!
+ // Current = W32Thread->WindowListHead.Flink;
+ // Fixes Api:CreateWindowEx tests!!!
+ List = IntWinListChildren(UserGetDesktopWindow());
+ if (List)
{
- Window = CONTAINING_RECORD(Current, WND, ThreadListEntry);
- ASSERT(Window);
-
- if (dwCount < *pBufSize && pWnd)
+ int i;
+ for (i = 0; List[i]; i++)
{
- _SEH2_TRY
+ Window = ValidateHwndNoErr(List[i]);
+ if (Window && Window->head.pti == W32Thread)
{
- ProbeForWrite(pWnd, sizeof(HWND), 1);
- *pWnd = Window->head.h;
- pWnd++;
- }
- _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
- {
- Status = _SEH2_GetExceptionCode();
- }
- _SEH2_END
- if (!NT_SUCCESS(Status))
- {
- ERR("Failure to build window list!\n");
- SetLastNtError(Status);
- break;
+ if (dwCount < *pBufSize && pWnd)
+ {
+ _SEH2_TRY
+ {
+ ProbeForWrite(pWnd, sizeof(HWND), 1);
+ *pWnd = Window->head.h;
+ pWnd++;
+ }
+ _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
+ {
+ Status = _SEH2_GetExceptionCode();
+ }
+ _SEH2_END
+ if (!NT_SUCCESS(Status))
+ {
+ ERR("Failure to build window list!\n");
+ SetLastNtError(Status);
+ break;
+ }
+ }
+ dwCount++;
}
}
- dwCount++;
- Current = Window->ThreadListEntry.Flink;
+ ExFreePoolWithTag(List, USERTAG_WINDOWLIST);
}
ObDereferenceObject(Thread);
static void IntSendParentNotify( PWND pWindow, UINT msg )
{
if ( (pWindow->style & (WS_CHILD | WS_POPUP)) == WS_CHILD &&
- !(pWindow->style & WS_EX_NOPARENTNOTIFY))
+ !(pWindow->ExStyle & WS_EX_NOPARENTNOTIFY))
{
- if (pWindow->spwndParent && pWindow->spwndParent != UserGetDesktopWindow())
+ if (VerifyWnd(pWindow->spwndParent) && pWindow->spwndParent != UserGetDesktopWindow())
{
USER_REFERENCE_ENTRY Ref;
UserRefObjectCo(pWindow->spwndParent, &Ref);
pWnd->head.pti->cWindows++;
- if (Class->hIcon && !Class->hIconSm)
+ if (Class->spicn && !Class->spicnSm)
{
- Class->hIconSmIntern = co_IntCopyImage( Class->hIcon, IMAGE_ICON,
- UserGetSystemMetrics( SM_CXSMICON ),
- UserGetSystemMetrics( SM_CYSMICON ), 0 );
- TRACE("IntCreateWindow hIconSmIntern %p\n",Class->hIconSmIntern);
- Class->CSF_flags |= CSF_CACHEDSMICON;
+ HICON IconSmHandle = NULL;
+ if((Class->spicn->CURSORF_flags & (CURSORF_LRSHARED | CURSORF_FROMRESOURCE))
+ == (CURSORF_LRSHARED | CURSORF_FROMRESOURCE))
+ {
+ IconSmHandle = co_IntCopyImage(
+ UserHMGetHandle(Class->spicn),
+ IMAGE_ICON,
+ UserGetSystemMetrics( SM_CXSMICON ),
+ UserGetSystemMetrics( SM_CYSMICON ),
+ LR_COPYFROMRESOURCE);
+ }
+ if (!IconSmHandle)
+ {
+ /* Retry without copying from resource */
+ IconSmHandle = co_IntCopyImage(
+ UserHMGetHandle(Class->spicn),
+ IMAGE_ICON,
+ UserGetSystemMetrics( SM_CXSMICON ),
+ UserGetSystemMetrics( SM_CYSMICON ),
+ 0);
+ }
+
+ if (IconSmHandle)
+ {
+ Class->spicnSm = UserGetCurIconObject(IconSmHandle);
+ Class->CSF_flags |= CSF_CACHEDSMICON;
+ }
}
if (pWnd->pcls->CSF_flags & CSF_SERVERSIDEPROC)
if (Class->atomClassName == gpsi->atomSysClass[ICLS_EDIT])
{
PCALLPROCDATA CallProc;
- CallProc = CreateCallProc(NULL, pWnd->lpfnWndProc, pWnd->Unicode , pWnd->head.pti->ppi);
+ CallProc = CreateCallProc(pWnd->head.rpdesk, pWnd->lpfnWndProc, pWnd->Unicode , pWnd->head.pti->ppi);
if (!CallProc)
{
}
InitializeListHead(&pWnd->PropListHead);
+ pWnd->PropListItems = 0;
if ( WindowName->Buffer != NULL && WindowName->Length > 0 )
{
if (ParentWindow != co_GetDesktopWindow(Window))
{
Cs->x += ParentWindow->rcClient.left;
- Cs->y += ParentWindow->rcClient.top;
+ Cs->y += ParentWindow->rcClient.top;
}
}
/* correct child window coordinates if mirroring on parent is enabled */
if (ParentWindow != NULL)
{
- if ( ((Cs->style & WS_CHILD) == WS_CHILD) &&
+ if ( ((Cs->style & WS_CHILD) == WS_CHILD) &&
((ParentWindow->ExStyle & WS_EX_LAYOUTRTL) == WS_EX_LAYOUTRTL))
{
Window->rcWindow.right = ParentWindow->rcClient.right - (Window->rcWindow.left - ParentWindow->rcClient.left);
IntSendParentNotify(Window, WM_CREATE);
/* Notify the shell that a new window was created */
- if ((!hWndParent) && (!hWndOwner))
+ if (Window->spwndParent == UserGetDesktopWindow() &&
+ Window->spwndOwner == NULL &&
+ (Window->style & WS_VISIBLE) &&
+ (!(Window->ExStyle & WS_EX_TOOLWINDOW) ||
+ (Window->ExStyle & WS_EX_APPWINDOW)))
{
co_IntShellHookNotify(HSHELL_WINDOWCREATED, (WPARAM)hWnd, 0);
}
}
}
+ if (Class->atomClassName == gaGuiConsoleWndClass)
+ {
+ /* Count only console windows manually */
+ co_IntUserManualGuiCheck(TRUE);
+ }
+
TRACE("co_UserCreateWindowEx(): Created window %p\n", hWnd);
ret = Window;
ASSERT(plstrWindowName);
- if ( (dwStyle & (WS_POPUP|WS_CHILD)) != WS_CHILD)
+ if ( (dwStyle & (WS_POPUP|WS_CHILD)) != WS_CHILD)
{
/* check hMenu is valid handle */
- if (hMenu && !ValidateHandle(hMenu, TYPE_MENU))
+ if (hMenu && !UserGetMenuObject(hMenu))
{
- /* error is set in ValidateHandle */
+ ERR("NtUserCreateWindowEx: Got an invalid menu handle!\n");
+ EngSetLastError(ERROR_INVALID_MENU_HANDLE);
return NULL;
}
- }
+ }
/* Copy the window name to kernel mode */
Status = ProbeAndCaptureLargeString(&lstrWindowName, plstrWindowName);
Cs.x = x;
Cs.y = y;
Cs.lpszName = (LPCWSTR) plstrWindowName->Buffer;
- if (IS_ATOM(plstrClassName))
- Cs.lpszClass = (LPCWSTR) plstrClassName;
- else
- Cs.lpszClass = (LPCWSTR) plstrClassName->Buffer;
+ Cs.lpszClass = ustrClassName.Buffer;
Cs.dwExStyle = dwExStyle;
UserEnterExclusive();
}
-BOOLEAN FASTCALL co_UserDestroyWindow(PWND Window)
+BOOLEAN co_UserDestroyWindow(PVOID Object)
{
HWND hWnd;
PWND pwndTemp;
PTHREADINFO ti;
MSG msg;
+ PWND Window = Object;
ASSERT_REFS_CO(Window); // FIXME: Temp HACK?
IntSendParentNotify(Window, WM_DESTROY);
}
- /* Look whether the focus is within the tree of windows we will
- * be destroying.
- */
- if (!co_WinPosShowWindow(Window, SW_HIDE))
- { // Rule #1.
- if (ti->MessageQueue->spwndActive == Window && ti->MessageQueue == IntGetFocusMessageQueue())
+ if (!Window->spwndOwner && !IntGetParent(Window))
+ {
+ co_IntShellHookNotify(HSHELL_WINDOWDESTROYED, (WPARAM) hWnd, 0);
+ }
+
+ /* Hide the window */
+ if (Window->style & WS_VISIBLE)
+ {
+ if (Window->style & WS_CHILD)
{
- co_WinPosActivateOtherWindow(Window);
+ /* Only child windows receive WM_SHOWWINDOW in DestroyWindow() */
+ co_WinPosShowWindow(Window, SW_HIDE);
+ }
+ else
+ {
+ co_WinPosSetWindowPos(Window, 0, 0, 0, 0, 0, SWP_NOMOVE|SWP_NOSIZE|SWP_NOZORDER|SWP_NOACTIVATE|SWP_HIDEWINDOW );
}
}
pwndTemp->spwndLastActive = Window->spwndOwner;
}
- if (Window->spwndParent && IntIsWindow(Window->head.h))
+ if (Window->spwndParent && IntIsWindow(UserHMGetHandle(Window)))
{
if ((Window->style & (WS_POPUP | WS_CHILD)) == WS_CHILD)
{
IntEngWindowChanged(Window, WOC_DELETE);
- if (!IntIsWindow(Window->head.h))
+ if (!IntIsWindow(UserHMGetHandle(Window)))
{
return TRUE;
}
msg.pt = gpsi->ptCursor;
co_MsqInsertMouseMessage(&msg, 0, 0, TRUE);
- if (!IntIsWindow(Window->head.h))
+ IntNotifyWinEvent(EVENT_OBJECT_DESTROY, Window, OBJID_WINDOW, CHILDID_SELF, 0);
+
+ /* Send destroy messages */
+
+ IntSendDestroyMsg(UserHMGetHandle(Window));
+
+ if (!IntIsWindow(UserHMGetHandle(Window)))
{
return TRUE;
}
(Child->strName.Length < 0xFFFF &&
!RtlCompareUnicodeString(WindowName, &CurrentWindowName, TRUE)))
{
- Ret = Child->head.h;
- break;
+ Ret = Child->head.h;
+ break;
+ }
}
}
- }
ExFreePoolWithTag(List, USERTAG_WINDOWLIST);
}
}
_SEH2_TRY
{
- if(pcbi)
- {
- ProbeForWrite(pcbi,
- sizeof(COMBOBOXINFO),
- 1);
- }
+ ProbeForWrite(pcbi, sizeof(COMBOBOXINFO), 1);
}
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
{
SetLastNtError(_SEH2_GetExceptionCode());
}
_SEH2_END;
-
+
RETURN( Ret);
CLEANUP:
SetLastNtError(_SEH2_GetExceptionCode());
}
_SEH2_END;
-
+
RETURN( Ret);
CLEANUP:
NTSTATUS Status = IntValidateWindowStationHandle(PsGetCurrentProcess()->Win32WindowStation,
KernelMode,
0,
- &WinStaObject);
+ &WinStaObject,
+ 0);
if (!NT_SUCCESS(Status))
{
Status = IntValidateWindowStationHandle(PsGetCurrentProcess()->Win32WindowStation,
KernelMode,
0,
- &WinStaObject);
+ &WinStaObject,
+ 0);
if (!NT_SUCCESS(Status))
{
return FALSE;
}
-LONG FASTCALL
-co_UserSetWindowLong(HWND hWnd, DWORD Index, LONG NewValue, BOOL Ansi)
+static LONG
+co_IntSetWindowLong(HWND hWnd, DWORD Index, LONG NewValue, BOOL Ansi, BOOL bAlter)
{
PWND Window, Parent;
PWINSTATION_OBJECT WindowStation;
Ansi);
if (!OldValue) return 0;
}
-*/
+ */
*((LONG *)((PCHAR)(Window + 1) + Index)) = NewValue;
}
else
else
Style.styleNew &= ~WS_EX_WINDOWEDGE;
+ if (!(Window->ExStyle & WS_EX_LAYERED))
+ {
+ SetLayeredStatus(Window, 0);
+ }
+
Window->ExStyle = (DWORD)Style.styleNew;
+
co_IntSendMessage(hWnd, WM_STYLECHANGED, GWL_EXSTYLE, (LPARAM) &Style);
break;
OldValue = (LONG) Window->style;
Style.styleOld = OldValue;
Style.styleNew = NewValue;
- co_IntSendMessage(hWnd, WM_STYLECHANGING, GWL_STYLE, (LPARAM) &Style);
+
+ if (!bAlter)
+ co_IntSendMessage(hWnd, WM_STYLECHANGING, GWL_STYLE, (LPARAM) &Style);
/* WS_CLIPSIBLINGS can't be reset on top-level windows */
if (Window->spwndParent == UserGetDesktopWindow()) Style.styleNew |= WS_CLIPSIBLINGS;
DceResetActiveDCEs( Window );
}
Window->style = (DWORD)Style.styleNew;
- co_IntSendMessage(hWnd, WM_STYLECHANGED, GWL_STYLE, (LPARAM) &Style);
+
+ if (!bAlter)
+ co_IntSendMessage(hWnd, WM_STYLECHANGED, GWL_STYLE, (LPARAM) &Style);
break;
case GWL_WNDPROC:
return( OldValue);
}
+
+LONG FASTCALL
+co_UserSetWindowLong(HWND hWnd, DWORD Index, LONG NewValue, BOOL Ansi)
+{
+ return co_IntSetWindowLong(hWnd, Index, NewValue, Ansi, FALSE);
+}
+
/*
* NtUserSetWindowLong
*
LONG APIENTRY
NtUserSetWindowLong(HWND hWnd, DWORD Index, LONG NewValue, BOOL Ansi)
{
- DECLARE_RETURN(LONG);
+ LONG ret;
- TRACE("Enter NtUserSetWindowLong\n");
UserEnterExclusive();
if (hWnd == IntGetDesktopWindow())
{
EngSetLastError(STATUS_ACCESS_DENIED);
- RETURN( 0);
+ UserLeave();
+ return 0;
}
- RETURN( co_UserSetWindowLong(hWnd, Index, NewValue, Ansi));
+ ret = co_IntSetWindowLong(hWnd, Index, NewValue, Ansi, FALSE);
-CLEANUP:
- TRACE("Leave NtUserSetWindowLong, ret=%i\n",_ret_);
UserLeave();
- END_CLEANUP;
+
+ return ret;
}
+DWORD APIENTRY
+NtUserAlterWindowStyle(HWND hWnd, DWORD Index, LONG NewValue)
+{
+ LONG ret;
+
+ UserEnterExclusive();
+
+ if (hWnd == IntGetDesktopWindow())
+ {
+ EngSetLastError(STATUS_ACCESS_DENIED);
+ UserLeave();
+ return 0;
+ }
+
+ ret = co_IntSetWindowLong(hWnd, Index, NewValue, FALSE, TRUE);
+
+ UserLeave();
+
+ return ret;
+}
+
+
/*
* NtUserSetWindowWord
*
END_CLEANUP;
}
-
/*
* @implemented
*/
END_CLEANUP;
}
-
-/*
- * @implemented
- */
-BOOL APIENTRY
-NtUserSetMenu(
- HWND hWnd,
- HMENU Menu,
- BOOL Repaint)
-{
- PWND Window;
- BOOL Changed;
- DECLARE_RETURN(BOOL);
-
- TRACE("Enter NtUserSetMenu\n");
- UserEnterExclusive();
-
- if (!(Window = UserGetWindowObject(hWnd)))
- {
- RETURN( FALSE);
- }
-
- if (! IntSetMenu(Window, Menu, &Changed))
- {
- RETURN( FALSE);
- }
-
- if (Changed && Repaint)
- {
- USER_REFERENCE_ENTRY Ref;
-
- UserRefObjectCo(Window, &Ref);
- co_WinPosSetWindowPos(Window, 0, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE |
- SWP_NOACTIVATE | SWP_NOZORDER | SWP_FRAMECHANGED);
-
- UserDerefObjectCo(Window);
- }
-
- RETURN( TRUE);
-
-CLEANUP:
- TRACE("Leave NtUserSetMenu, ret=%i\n",_ret_);
- UserLeave();
- END_CLEANUP;
-}
-
/*
* @implemented
*/
// From user land we only set these.
if (fnID != FNID_DESTROY)
- { // Hacked so we can mark desktop~!
- if ( (/*(fnID < FNID_BUTTON)*/ (fnID < FNID_FIRST) && (fnID > FNID_GHOST)) ||
- Wnd->fnid != 0 )
+ {
+ /* HACK: The minimum should be FNID_BUTTON, but menu code relies on this */
+ if (fnID < FNID_FIRST || fnID > FNID_GHOST ||
+ Wnd->fnid != 0)
{
EngSetLastError(ERROR_INVALID_PARAMETER);
RETURN( FALSE);
END_CLEANUP;
}
+BOOL APIENTRY
+DefSetText(PWND Wnd, PCWSTR WindowText)
+{
+ UNICODE_STRING UnicodeString;
+ BOOL Ret = FALSE;
+
+ RtlInitUnicodeString(&UnicodeString, WindowText);
+
+ if (UnicodeString.Length != 0)
+ {
+ if (Wnd->strName.MaximumLength > 0 &&
+ UnicodeString.Length <= Wnd->strName.MaximumLength - sizeof(UNICODE_NULL))
+ {
+ ASSERT(Wnd->strName.Buffer != NULL);
+
+ Wnd->strName.Length = UnicodeString.Length;
+ Wnd->strName.Buffer[UnicodeString.Length / sizeof(WCHAR)] = L'\0';
+ RtlCopyMemory(Wnd->strName.Buffer,
+ UnicodeString.Buffer,
+ UnicodeString.Length);
+ }
+ else
+ {
+ PWCHAR buf;
+ Wnd->strName.MaximumLength = Wnd->strName.Length = 0;
+ buf = Wnd->strName.Buffer;
+ Wnd->strName.Buffer = NULL;
+ if (buf != NULL)
+ {
+ DesktopHeapFree(Wnd->head.rpdesk, buf);
+ }
+
+ Wnd->strName.Buffer = DesktopHeapAlloc(Wnd->head.rpdesk,
+ UnicodeString.Length + sizeof(UNICODE_NULL));
+ if (Wnd->strName.Buffer != NULL)
+ {
+ Wnd->strName.Buffer[UnicodeString.Length / sizeof(WCHAR)] = L'\0';
+ RtlCopyMemory(Wnd->strName.Buffer,
+ UnicodeString.Buffer,
+ UnicodeString.Length);
+ Wnd->strName.MaximumLength = UnicodeString.Length + sizeof(UNICODE_NULL);
+ Wnd->strName.Length = UnicodeString.Length;
+ }
+ else
+ {
+ EngSetLastError(ERROR_NOT_ENOUGH_MEMORY);
+ goto Exit;
+ }
+ }
+ }
+ else
+ {
+ Wnd->strName.Length = 0;
+ if (Wnd->strName.Buffer != NULL)
+ Wnd->strName.Buffer[0] = L'\0';
+ }
+
+ // FIXME: HAX! Windows does not do this in here!
+ // In User32, these are called after: NotifyWinEvent EVENT_OBJECT_NAMECHANGE than
+ // RepaintButton, StaticRepaint, NtUserCallHwndLock HWNDLOCK_ROUTINE_REDRAWFRAMEANDHOOK, etc.
+ /* Send shell notifications */
+ if (!Wnd->spwndOwner && !IntGetParent(Wnd))
+ {
+ co_IntShellHookNotify(HSHELL_REDRAW, (WPARAM) UserHMGetHandle(Wnd), FALSE); // FIXME Flashing?
+ }
+
+ Ret = TRUE;
+Exit:
+ if (UnicodeString.Buffer) RtlFreeUnicodeString(&UnicodeString);
+ return Ret;
+}
+
/*
* NtUserDefSetText
*
projects / reactos.git / blobdiff