[COMCTL32_APITEST} -Add some more tests and fix build.

[reactos.git] / rostests / apitests / comctl32 / button.c

diff --git a/rostests/apitests/comctl32/button.c b/rostests/apitests/comctl32/button.c
index 99c0841..275589f 100644 (file)
--- a/rostests/apitests/comctl32/button.c
+++ b/rostests/apitests/comctl32/button.c
@@ -21,7 +21,8 @@ void Test_TextMargin()
     
     hwnd1 = CreateWindowW(L"Button", L"Test1", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
     
     hwnd1 = CreateWindowW(L"Button", L"Test1", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");

-    
+    SetWindowTheme(hwnd1, L"", L"");
+

     ret = SendMessageW(hwnd1, BCM_GETTEXTMARGIN, 0, (LPARAM)&rc);
     ok (ret == TRUE, "Expected BCM_GETTEXTMARGIN to succeed\n");
     ok_rect(rc, 1, 1, 1, 1);
     ret = SendMessageW(hwnd1, BCM_GETTEXTMARGIN, 0, (LPARAM)&rc);
     ok (ret == TRUE, "Expected BCM_GETTEXTMARGIN to succeed\n");
     ok_rect(rc, 1, 1, 1, 1);


@@ -96,11 +97,11 @@ void Test_GetIdealSizeNoThemes()
     SIZE s, textent;
     HFONT font;
     HDC hdc;
     SIZE s, textent;
     HFONT font;
     HDC hdc;

-    WINDOWINFO wi;

     HANDLE hbmp;
     HIMAGELIST himl;
     BUTTON_IMAGELIST imlData;
     RECT rc;
     HANDLE hbmp;
     HIMAGELIST himl;
     BUTTON_IMAGELIST imlData;
     RECT rc;

+    LOGFONTW lf;

 
     hwnd1 = CreateWindowW(L"Button", L" ", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
 
     hwnd1 = CreateWindowW(L"Button", L" ", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");


@@ -111,17 +112,17 @@ void Test_GetIdealSizeNoThemes()
     SelectObject(hdc, font);
     GetTextExtentPoint32W(hdc, L" ", 1, &textent);
 
     SelectObject(hdc, font);
     GetTextExtentPoint32W(hdc, L" ", 1, &textent);
 

-    memset(&wi, 0, sizeof(wi));
-    GetWindowInfo(hwnd1, &wi);
-

     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders - 1 + 2, 
-               textent.cy + 2 * wi.cyWindowBorders + 1 + 2); /* the last +2 is the text margin */
+    ok_size(s, textent.cx + 5 + 2, 
+               textent.cy + 7 + 2); /* the last +2 is the text margin */

 
     DestroyWindow(hwnd1);
 
 
     DestroyWindow(hwnd1);
 

+
+
+

     hwnd1 = CreateWindowW(L"Button", L"", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
     SetWindowTheme(hwnd1, L"", L"");
     hwnd1 = CreateWindowW(L"Button", L"", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
     SetWindowTheme(hwnd1, L"", L"");


@@ -166,6 +167,27 @@ void Test_GetIdealSizeNoThemes()
 
     DestroyWindow(hwnd1);
 
 
     DestroyWindow(hwnd1);
 

+
+
+
+    hwnd1 = CreateWindowW(L"Button", L" ", BS_BITMAP , 10, 10, 100, 100, 0, NULL, NULL, NULL);
+    ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
+    SetWindowTheme(hwnd1, L"", L"");
+
+    SendMessageW(hwnd1, BM_SETIMAGE, IMAGE_BITMAP, (LPARAM)hbmp);
+
+    memset(&s, 0, sizeof(s));
+    ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
+    ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
+
+    /* In xp and 2k3 the image is ignored, in vista+ its width is added to the text width */
+    ok_size(s, textent.cx + 5 + 2, 
+               textent.cy + 7 + 2); /* the last +2 is the text margin */
+
+    DestroyWindow(hwnd1);
+
+
+

     hwnd1 = CreateWindowW(L"Button", L" ", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
     SetWindowTheme(hwnd1, L"", L"");
     hwnd1 = CreateWindowW(L"Button", L" ", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
     SetWindowTheme(hwnd1, L"", L"");


@@ -177,8 +199,8 @@ void Test_GetIdealSizeNoThemes()
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders - 1, 
-               textent.cy + 2 * wi.cyWindowBorders + 1);
+    ok_size(s, textent.cx + 5, 
+               textent.cy + 7);

 
     SetRect(&rc, 50,50,50,50);
     ret = SendMessageW(hwnd1, BCM_SETTEXTMARGIN, 0, (LPARAM)&rc);
 
     SetRect(&rc, 50,50,50,50);
     ret = SendMessageW(hwnd1, BCM_SETTEXTMARGIN, 0, (LPARAM)&rc);


@@ -187,38 +209,87 @@ void Test_GetIdealSizeNoThemes()
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders - 1 + 100, 
-               textent.cy + 2 * wi.cyWindowBorders + 1 + 100);
+    ok_size(s, textent.cx + 5 + 100, 
+               textent.cy + 7 + 100);

 
 

-    SetRect(&rc, 0,0,0,0);
+    SetRect(&rc, 1,1,1,1);

     ret = SendMessageW(hwnd1, BCM_SETTEXTMARGIN, 0, (LPARAM)&rc);
     ok (ret == TRUE, "Expected BCM_SETTEXTMARGIN to succeed\n");
 
     ret = SendMessageW(hwnd1, BCM_SETIMAGELIST, 0, (LPARAM)&imlData);
     ret = SendMessageW(hwnd1, BCM_SETTEXTMARGIN, 0, (LPARAM)&rc);
     ok (ret == TRUE, "Expected BCM_SETTEXTMARGIN to succeed\n");
 
     ret = SendMessageW(hwnd1, BCM_SETIMAGELIST, 0, (LPARAM)&imlData);

-    ok (ret == TRUE, "Expected BCM_SETIMAGELIST to fail\n"); /* This works in win10 */
+    ok (ret == TRUE, "Expected BCM_SETIMAGELIST to fail\n");

 
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
 
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders, /* we get an extra pixel due to the iml */
-               textent.cy + 2 * wi.cyWindowBorders + 1);
+    ok_size(s, textent.cx + 5 + 2 + 1, /* we get an extra pixel due to the iml */
+               textent.cy + 7 + 2);

 
     s.cx = 1;
     s.cy = 1;
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
 
     s.cx = 1;
     s.cy = 1;
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders,
-               textent.cy + 2 * wi.cyWindowBorders + 1);
+    ok_size(s, textent.cx + 5 + 2 + 1,
+               textent.cy + 7 + 2);

 
     s.cx = 100;
     s.cy = 100;
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
 
     s.cx = 100;
     s.cy = 100;
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders,
-               textent.cy + 2 * wi.cyWindowBorders + 1);
+    ok_size(s, textent.cx + 5 + 2 + 1,
+               textent.cy + 7 + 2);
+
+    SetRect(&imlData.margin, 1,1,1,1);
+    ret = SendMessageW(hwnd1, BCM_SETIMAGELIST, 0, (LPARAM)&imlData);
+    ok (ret == TRUE, "Expected BCM_SETIMAGELIST to fail\n");
+
+    memset(&s, 0, sizeof(s));
+    ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
+    ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
+    /* expected width = text width + hardcoded value + text margins + image width + image margins */
+    ok_size(s, textent.cx + 5 + 2 + 1 + 2,
+               textent.cy + 7 + 2);
+
+    SetRect(&imlData.margin, 50,50,50,50);
+    ret = SendMessageW(hwnd1, BCM_SETIMAGELIST, 0, (LPARAM)&imlData);
+    ok (ret == TRUE, "Expected BCM_SETIMAGELIST to fail\n");
+
+    memset(&s, 0, sizeof(s));
+    ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
+    ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
+    /* image + its margins is so big that the height is dictated by them */
+    ok_size(s, textent.cx + 5 + 2 + 1 + 100, (LONG)101);
+
+    DestroyWindow(hwnd1);
+
+
+
+
+
+
+    hwnd1 = CreateWindowW(L"Button", L"Start", BS_VCENTER, 0, 0, 0, 0, 0, NULL, NULL, NULL);
+    ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
+    SetWindowTheme(hwnd1, L"", L"");
+
+    font = (HFONT)SendMessageW(hwnd1, WM_GETFONT, 0, 0);
+    hdc = GetDC(hwnd1);
+    SelectObject(hdc, font);
+    GetTextExtentPoint32W(hdc, L"Start", 5, &textent);
+
+    SetRect(&rc, 0,0,0,0);
+    ret = SendMessageW(hwnd1, BCM_SETTEXTMARGIN, 0, (LPARAM)&rc);
+    ok (ret == TRUE, "Expected BCM_SETTEXTMARGIN to succeed\n");
+
+    memset(&s, 0, sizeof(s));
+    ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
+    ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
+    ok_size(s, textent.cx + 5, textent.cy + 7);

 
     DestroyWindow(hwnd1);
 
 
     DestroyWindow(hwnd1);
 

+
+
+

     /* Test again with some real text to see if the formula is correct */
     hwnd1 = CreateWindowW(L"Button", L"Some test text", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");
     /* Test again with some real text to see if the formula is correct */
     hwnd1 = CreateWindowW(L"Button", L"Some test text", 0, 10, 10, 100, 100, 0, NULL, NULL, NULL);
     ok (hwnd1 != NULL, "Expected CreateWindowW to succeed\n");


@@ -232,10 +303,32 @@ void Test_GetIdealSizeNoThemes()
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
     memset(&s, 0, sizeof(s));
     ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
     ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");

-    ok_size(s, textent.cx + 2 * wi.cxWindowBorders - 1 + 2,  /* the last +2 is the text margin */
-               textent.cy + 2 * wi.cyWindowBorders + 1 + 2);
+    ok_size(s, textent.cx + 5 + 2,  /* the last +2 is the text margin */
+               textent.cy + 7 + 2);
+
+    /* The hardcoded values are independent of the margin */
+    lf.lfHeight = 200;
+    lf.lfWidth = 200;
+    lf.lfWeight = FW_BOLD;
+    wcscpy(lf.lfFaceName, L"Arial");
+    font = CreateFontIndirectW(&lf);
+    ok(font != NULL, "\n");
+    SendMessageW(hwnd1, WM_SETFONT, (WPARAM)font, FALSE);
+
+    SelectObject(hdc, font);
+    GetTextExtentPoint32W(hdc, L"Some test text", 14, &textent);
+
+    memset(&s, 0, sizeof(s));
+    ret = SendMessageW(hwnd1, BCM_GETIDEALSIZE, 0, (LPARAM)&s);
+    ok (ret == TRUE, "Expected BCM_GETIDEALSIZE to succeed\n");
+    ok_size(s, textent.cx + 5 + 2,  /* the last +2 is the text margin */
+               textent.cy + 7 + 2);

 
     DestroyWindow(hwnd1);
 
     DestroyWindow(hwnd1);

+
+
+
+

 }
 
 START_TEST(button)
 }
 
 START_TEST(button)