* TODO:
* Add W-function tests.
* Add missing function tests:
- * FtpFindFirstFile
* FtpGetFileSize
* FtpSetCurrentDirectory
*/
* anonymous : NULL
* NULL : IEUser@
* NULL : NULL
+ * "" : IEUser@
+ * "" : NULL
*/
SetLastError(0xdeadbeef);
ok ( GetLastError() == ERROR_INVALID_PARAMETER,
"Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
+ SetLastError(0xdeadbeef);
+ hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "", "IEUser@",
+ INTERNET_SERVICE_FTP, INTERNET_FLAG_PASSIVE, 0);
+ ok(!hFtp, "Expected InternetConnect to fail\n");
+ ok(GetLastError() == ERROR_INVALID_PARAMETER,
+ "Expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
+
/* Using a NULL username and password will be interpreted as anonymous ftp. The username will be 'anonymous' the password
* is created via some simple heuristics (see dlls/wininet/ftp.c).
* On Wine this registry key is not set by default so (NULL, NULL) will result in anonymous ftp with an (most likely) not
ok ( hFtp != NULL, "InternetConnect failed : %d\n", GetLastError());
ok ( GetLastError() == ERROR_SUCCESS,
"ERROR_SUCCESS, got %d\n", GetLastError());
+
+ SetLastError(0xdeadbeef);
+ hFtp = InternetConnect(hInternet, "ftp.winehq.org", INTERNET_DEFAULT_FTP_PORT, "", NULL,
+ INTERNET_SERVICE_FTP, INTERNET_FLAG_PASSIVE, 0);
+ if (!hFtp)
+ {
+ ok(GetLastError() == ERROR_INTERNET_LOGIN_FAILURE,
+ "Expected ERROR_INTERNET_LOGIN_FAILURE, got %d\n", GetLastError());
+}
+ else
+ {
+ ok(GetLastError() == ERROR_SUCCESS,
+ "Expected ERROR_SUCCESS, got %d\n", GetLastError());
+ }
}
static void test_createdir(HINTERNET hFtp, HINTERNET hConnect)
ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR,
"Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError());
/* Currently Wine always creates the local file (even on failure) which is not correct, hence the test */
- todo_wine
ok (GetFileAttributesA("should_also_be_non_existing_deadbeef") == INVALID_FILE_ATTRIBUTES,
"Local file should not have been created\n");
ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR,
"Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError());
/* Currently Wine always creates the local file (even on failure) which is not correct, hence the test */
- todo_wine
ok (GetFileAttributesA("should_also_be_non_existing_deadbeef") == INVALID_FILE_ATTRIBUTES,
"Local file should not have been created\n");
SetLastError(0xdeadbeef);
hOpenFile = FtpOpenFileA(hFtp, "welcome.msg", GENERIC_READ, FTP_TRANSFER_TYPE_ASCII, 0);
ok ( hOpenFile != NULL, "Expected FtpOpenFileA to succeed\n");
- ok ( GetLastError() == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", GetLastError());
+ ok ( GetLastError() == ERROR_SUCCESS ||
+ broken(GetLastError() == ERROR_FILE_NOT_FOUND), /* Win98 */
+ "Expected ERROR_SUCCESS, got %u\n", GetLastError());
if (hOpenFile)
{
if (!pFtpCommandA)
{
- skip("FtpCommandA() is not available. Skipping the Ftp command tests\n");
+ win_skip("FtpCommandA() is not available. Skipping the Ftp command tests\n");
return;
}
}
}
+static void test_find_first_file(HINTERNET hFtp, HINTERNET hConnect)
+{
+ WIN32_FIND_DATA findData;
+ HINTERNET hSearch;
+ HINTERNET hSearch2;
+ HINTERNET hOpenFile;
+
+ /* NULL as the search file ought to return the first file in the directory */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, NULL, &findData, 0, 0);
+ ok ( hSearch != NULL, "Expected FtpFindFirstFileA to pass\n" );
+
+ /* This should fail as the previous handle wasn't closed */
+ SetLastError(0xdeadbeef);
+ hSearch2 = FtpFindFirstFileA(hFtp, "welcome.msg", &findData, 0, 0);
+ todo_wine ok ( hSearch2 == NULL, "Expected FtpFindFirstFileA to fail\n" );
+ todo_wine ok ( GetLastError() == ERROR_FTP_TRANSFER_IN_PROGRESS,
+ "Expected ERROR_FTP_TRANSFER_IN_PROGRESS, got %d\n", GetLastError() );
+ InternetCloseHandle(hSearch2); /* Just in case */
+
+ InternetCloseHandle(hSearch);
+
+ /* Try a valid filename in a subdirectory search */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, "pub/wine", &findData, 0, 0);
+ todo_wine ok ( hSearch != NULL, "Expected FtpFindFirstFileA to pass\n" );
+ InternetCloseHandle(hSearch);
+
+ /* Try a valid filename in a subdirectory wildcard search */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, "pub/w*", &findData, 0, 0);
+ todo_wine ok ( hSearch != NULL, "Expected FtpFindFirstFileA to pass\n" );
+ InternetCloseHandle(hSearch);
+
+ /* Try an invalid wildcard search */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, "*/w*", &findData, 0, 0);
+ ok ( hSearch == NULL, "Expected FtpFindFirstFileA to fail\n" );
+ InternetCloseHandle(hSearch); /* Just in case */
+
+ /* Try FindFirstFile between FtpOpenFile and InternetCloseHandle */
+ SetLastError(0xdeadbeef);
+ hOpenFile = FtpOpenFileA(hFtp, "welcome.msg", GENERIC_READ, FTP_TRANSFER_TYPE_ASCII, 0);
+ ok ( hOpenFile != NULL, "Expected FtpOpenFileA to succeed\n" );
+ ok ( GetLastError() == ERROR_SUCCESS ||
+ broken(GetLastError() == ERROR_FILE_NOT_FOUND), /* Win98 */
+ "Expected ERROR_SUCCESS, got %u\n", GetLastError() );
+
+ /* This should fail as the OpenFile handle wasn't closed */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, "welcome.msg", &findData, 0, 0);
+ ok ( hSearch == NULL, "Expected FtpFindFirstFileA to fail\n" );
+ ok ( GetLastError() == ERROR_FTP_TRANSFER_IN_PROGRESS,
+ "Expected ERROR_FTP_TRANSFER_IN_PROGRESS, got %d\n", GetLastError() );
+ InternetCloseHandle(hSearch); /* Just in case */
+
+ InternetCloseHandle(hOpenFile);
+
+ /* Test using a nonexistent filename */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, "this_file_should_not_exist", &findData, 0, 0);
+ ok ( hSearch == NULL, "Expected FtpFindFirstFileA to fail\n" );
+ todo_wine ok ( GetLastError() == ERROR_INTERNET_EXTENDED_ERROR,
+ "Expected ERROR_INTERNET_EXTENDED_ERROR, got %d\n", GetLastError() );
+ InternetCloseHandle(hSearch); /* Just in case */
+
+ /* Test using a nonexistent filename and a wildcard */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hFtp, "this_file_should_not_exist*", &findData, 0, 0);
+ ok ( hSearch == NULL, "Expected FtpFindFirstFileA to fail\n" );
+ todo_wine ok ( GetLastError() == ERROR_NO_MORE_FILES,
+ "Expected ERROR_NO_MORE_FILES, got %d\n", GetLastError() );
+ InternetCloseHandle(hSearch); /* Just in case */
+
+ /* Test using an invalid handle type */
+ SetLastError(0xdeadbeef);
+ hSearch = FtpFindFirstFileA(hConnect, "welcome.msg", &findData, 0, 0);
+ ok ( hSearch == NULL, "Expected FtpFindFirstFileA to fail\n" );
+ ok ( GetLastError() == ERROR_INTERNET_INCORRECT_HANDLE_TYPE,
+ "Expected ERROR_INTERNET_INCORRECT_HANDLE_TYPE, got %d\n", GetLastError() );
+ InternetCloseHandle(hSearch); /* Just in case */
+}
+
static void test_get_current_dir(HINTERNET hFtp, HINTERNET hConnect)
{
BOOL bRet;
if (!pFtpCommandA)
{
- skip("FtpCommandA() is not available. Skipping the Ftp get_current_dir tests\n");
+ win_skip("FtpCommandA() is not available. Skipping the Ftp get_current_dir tests\n");
return;
}
test_removedir(hFtp, hHttp);
test_renamefile(hFtp, hHttp);
test_command(hFtp, hHttp);
+ test_find_first_file(hFtp, hHttp);
test_get_current_dir(hFtp, hHttp);
InternetCloseHandle(hHttp);
projects / reactos.git / blobdiff