X-Git-Url: https://git.reactos.org/?p=reactos.git;a=blobdiff_plain;f=CONTRIBUTING.md;h=fc1f21b1883c556e3f14f730e4cbbf6679bdf596;hp=3cbab7b9f778b3ea3a8c2b80b17fee3ac1286c87;hb=2949b2f08b57d0ae6105fdeae72f865152d91f5f;hpb=f50f983f451e3df2e9bab55853f089755164c92b diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3cbab7b9f77..fc1f21b1883 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,12 +65,14 @@ Our commit style is defined in a __[commit template]__. Use it as a reference or - *Use your __real name__ and __real email__.* We do not accept anonymous contributions! - *Ensure your contribution is properly described.* Include the relevant issue number if applicable. -- *Put only related changes.* It will make reviewing easier as the reviewer needs to recall less information about the existing source code that is changed./rapps-db/commit/7737182148cde7c559fb21170d3e5c3acf42648c.patch +- *Put only related changes.* It will make reviewing easier as the reviewer needs to recall less information about the existing source code that is changed. - *Search for similar pull requests/patches before submitting.* It may be that a similar pull request or issue was opened previously. Comment and review on that one instead. - *Keep your contribution small and focused on the topic.* It can be tempting to fix existing issues as you come across them while reading the source code. Resist the temptation and put in a note in the source code instead, or (even better) put the issue in the issue tracking system. - *Respect our __[Coding Style]__ and __[Programming Guidelines]__.* - *Do not be afraid to ask questions.* Ask our developers on JIRA or [IRC] channel. +To amend your commit with your name and e-mail (in any case you've forgot to set your name/e-mail) please take a look at this [guide](https://reactos.org/wiki/ReactOS_Git_For_Dummies#Amending_your_commit_with_name.2FE-mail). To set your name/e-mail globally for future commits that you push, [read this](https://reactos.org/wiki/ReactOS_Git_For_Dummies#Assign_commits_with_your_name_.26_E-mail_automatically). + ## Where To Start? Finding a good project to start with can be a challenge, because when starting out you are (usually) not aware of all the possibilities. To help you find a project, here are some ideas to try: @@ -101,3 +103,7 @@ Finding a good project to start with can be a challenge, because when starting o [Coverity]: https://scan.coverity.com/projects/reactos [request-coverity]: https://scan.coverity.com/memberships/new?project_id=reactos [commit template]: .gitmessage + +# See Also + +- [Rules for managing Pull Requests](PULL_REQUEST_MANAGEMENT.md)