[0.4.14][KERNEL32][TCPIP] A big squashed fix for CORE-16757 CORE-17596 CORE-17647...
authorJoachim Henze <Joachim.Henze@reactos.org>
Sat, 20 Nov 2021 04:09:54 +0000 (05:09 +0100)
committerJoachim Henze <Joachim.Henze@reactos.org>
Sat, 20 Nov 2021 04:09:54 +0000 (05:09 +0100)
commite7cfa907e9da9048f75809519688753b0cf5eb30
treea7cc59d0ffbd1ee0dcbb97beb4c202a5b816d5bb
parent5917fa575b95f27943d98824b227ab79f5c97a7d
[0.4.14][KERNEL32][TCPIP] A big squashed fix for CORE-16757 CORE-17596 CORE-17647 CORE-6473 (#3170)

The interesting kernel32 part is a port of
0.4.15-dev-2069-g fd8080b0942e88502ca1735a0590f31e6d072e32
CORE-16757 'Task Manager failed to show process's priority'
which I actually wanted to improve for 0.4.14.

But if we took that on its own, then it would unhide
CORE-17596 'Google Earth 7.1.8 regressed AGAIN by the same work'
That's why we take with us:
0.4.15-dev-2766-g 27fcfe66a2a7a8beb4b29eee18bb251a3a9aae22 (is also part of CORE-6473, I left the 2nd commit out that added an assert in NTOSKRNL)

Small hack: this backport required me to define _Unreferenced_parameter_ myself in tcp.c
stolen from newer sdk/include/psdk/specstrings.h. I didn't want to port back that entire file as well.

In combination those two fixes allow both 'Google Earth and to change process priority' to be fixed within the same build.

But I felt a bit more safe then by taking
0.4.15-dev-2793-g 979b7d4d8e6ca8e80ea5b30c70f17a7c868b060f
with me as well, because I was too afraid, that I might otherwise introduce
CORE-17647 'BSOD 0xc2 BAD_POOL_CALLER induced by networking, triggered by using KeePass 2.23'
although I could not trigger that in practice when leaving that third commit out as an experiment.

And since it was a safe no-brainer-fix, I couldn't resist to also pick
0.4.15-dev-764-g 4aeb45ce0ce9d674bc40b3ac3fc98bbf3eb7c157 (#3170)
16 files changed:
dll/win32/kernel32/client/proc.c
drivers/network/tcpip/include/tcp.h
drivers/network/tcpip/include/titypes.h
drivers/network/tcpip/tcpip/ainfo.c
drivers/network/tcpip/tcpip/dispatch.c
drivers/network/tcpip/tcpip/fileobjs.c
drivers/network/tcpip/tcpip/icmp.c
sdk/lib/drivers/ip/network/receive.c
sdk/lib/drivers/ip/transport/datagram/datagram.c
sdk/lib/drivers/ip/transport/rawip/rawip.c
sdk/lib/drivers/ip/transport/tcp/accept.c
sdk/lib/drivers/ip/transport/tcp/event.c
sdk/lib/drivers/ip/transport/tcp/tcp.c
sdk/lib/drivers/ip/transport/udp/udp.c
sdk/lib/drivers/lwip/src/include/rosip.h
sdk/lib/drivers/lwip/src/rostcp.c