[BASESRV] Re-enable and actually fix the CsrValidateMessageBuffer() checks in BaseSrv... 3304/head
authorHermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Sat, 17 Oct 2020 14:40:50 +0000 (16:40 +0200)
committerHermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Fri, 30 Oct 2020 00:58:16 +0000 (01:58 +0100)
commit731eddfe40a0ae641a6a4b99273a9564a5b4ddc0
tree448370025b51e4712b30464cf7695490b6731f08
parentf4279fc356df67bce5cfefa7b29fb05e722e5b00
[BASESRV] Re-enable and actually fix the CsrValidateMessageBuffer() checks in BaseSrvDefineDosDevice(). (#3304)

Addendum to commit 0a392b18.

The actual problem that existed all along was that the buffers being
validated with CsrValidateMessageBuffer() were not the correct ones!

What had to be checked is the string buffer **INSIDE** the UNICODE_STRING
structures! Indeed, it is these buffers that we are allocating on client side,
see https://github.com/reactos/reactos/blob/9b421af1/dll/win32/kernel32/client/dosdev.c#L324-L336

Dedicated to Pierre Schweitzer.
subsystems/win/basesrv/dosdev.c