[OSK] fix resource leak in error case CID 1322148
authorChristoph von Wittich <christoph_vw@reactos.org>
Thu, 3 Sep 2015 09:33:58 +0000 (09:33 +0000)
committerChristoph von Wittich <christoph_vw@reactos.org>
Thu, 3 Sep 2015 09:33:58 +0000 (09:33 +0000)
svn path=/trunk/; revision=68931

reactos/base/applications/osk/main.c

index 2ea3156..9932f79 100644 (file)
@@ -40,10 +40,15 @@ int OSK_SetImage(int IdDlgItem, int IdResource)
 
     hIcon = (HICON)LoadImage(Globals.hInstance, MAKEINTRESOURCE(IdResource),
                              IMAGE_ICON, 16, 16, LR_DEFAULTCOLOR);
-    if (hIcon == NULL) return FALSE;
+    if (hIcon == NULL)
+        return FALSE;
 
     hWndItem = GetDlgItem(Globals.hMainWnd, IdDlgItem);
-    if (hWndItem == NULL) return FALSE;
+    if (hWndItem == NULL)
+    {
+        DestroyIcon(hIcon);
+        return FALSE;
+    }
 
     SendMessage(hWndItem, BM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)hIcon);