[0.4.11][NETCFGX] Fix 1 MSVC2010SP1 x86 dbg warning C4553 CORE-18104
authorJoachim Henze <Joachim.Henze@reactos.org>
Sat, 17 Sep 2022 22:10:17 +0000 (00:10 +0200)
committerJoachim Henze <Joachim.Henze@reactos.org>
Sat, 17 Sep 2022 22:10:17 +0000 (00:10 +0200)
the warning could be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration:

[10847/12816] Building C object dll\win32\netcfgx\CMakeFiles\netcfgx.dir\propertypage.c.obj
C:\0411rls\reactos\dll\win32\netcfgx\propertypage.c(319) : warning C4553: '==' : operator has no effect; did you intend '='?

Fix picked from 0.4.12-dev-656-g c0d97cec8884fde689c145c7d50ef944d378f666

The bug was introduced by 0.4.11-dev-308-g 91ba4e73508a0168796af9fed67557ade3a6f792

dll/win32/netcfgx/propertypage.c

index abf44da..87be836 100644 (file)
@@ -316,7 +316,7 @@ GetEnumOptions(
                                 &dwValueLength);
         if (dwError == ERROR_NO_MORE_ITEMS)
         {
-            dwError == ERROR_SUCCESS;
+            dwError = ERROR_SUCCESS;
             goto done;
         }
         else if (dwError != ERROR_SUCCESS)