Status = STATUS_INVALID_PARAMETER;
else
{
- /* FIXME: Race condition here:
- * If an interrupt comes before we can mark the Irp
- * as pending, it might be possible to complete the
- * Irp before pending it, leading to a crash! */
+ IoMarkIrpPending(Irp);
+
WaitingIrp = InterlockedCompareExchangePointer(
- (PVOID)&DeviceExtension->WaitOnMaskIrp,
+ &DeviceExtension->WaitOnMaskIrp,
Irp,
NULL);
{
/* Unable to have a 2nd pending IRP for this IOCTL */
WARN_(SERIAL, "Unable to pend a second IRP for IOCTL_SERIAL_WAIT_ON_MASK\n");
- Status = STATUS_INVALID_PARAMETER;
- }
- else
- {
- Status = STATUS_PENDING;
- /* FIXME: immediately return if a wait event already occurred */
+ Irp->IoStatus.Information = 0;
+ Irp->IoStatus.Status = STATUS_INVALID_PARAMETER;
+ IoCompleteRequest(Irp, IO_NO_INCREMENT);
}
+ return STATUS_PENDING;
}
break;
}