}
*Segment->Flags |= MM_SEGMENT_INDELETE;
- MiReleasePfnLock(OldIrql);
/* Flush the segment */
if (*Segment->Flags & MM_DATAFILE_SEGMENT)
{
+ MiReleasePfnLock(OldIrql);
/* Free the page table. This will flush any remaining dirty data */
MmFreePageTablesSectionSegment(Segment, FreeSegmentPage);
ULONG NrSegments;
ULONG i;
- OldIrql = MiAcquirePfnLock();
/* Delete the pointer on the file */
ASSERT(ImageSectionObject->FileObject->SectionObjectPointer->ImageSectionObject == ImageSectionObject);
ImageSectionObject->FileObject->SectionObjectPointer->ImageSectionObject = NULL;
ULONG_PTR Entry = InEntry ? *InEntry : MmGetPageEntrySectionSegment(Segment, Offset);
PFN_NUMBER Page = PFN_FROM_SSE(Entry);
BOOLEAN IsDataMap = BooleanFlagOn(*Segment->Flags, MM_DATAFILE_SEGMENT);
+ SWAPENTRY SwapEntry;
if (Entry == 0)
{
return FALSE;
}
- if (!BooleanFlagOn(Segment->Image.Characteristics, IMAGE_SCN_MEM_SHARED))
+ if (!FlagOn(Segment->Image.Characteristics, IMAGE_SCN_MEM_SHARED))
{
- /* So this must have been a read-only page. Keep it ! */
ASSERT(Segment->WriteCopy);
ASSERT(!IS_DIRTY_SSE(Entry));
ASSERT(MmGetSavedSwapEntryPage(Page) == 0);
+ /* So this must have been a read-only page. Keep it ! */
MmSetPageEntrySectionSegment(Segment, Offset, Entry);
return FALSE;
}
* So this is a page for a shared section of a DLL.
* We can keep it if it is not dirty.
*/
- SWAPENTRY SwapEntry = MmGetSavedSwapEntryPage(Page);
+ SwapEntry = MmGetSavedSwapEntryPage(Page);
if ((SwapEntry == 0) && !IS_DIRTY_SSE(Entry))
{
MmSetPageEntrySectionSegment(Segment, Offset, Entry);
_In_ PMM_SECTION_SEGMENT Segment,
_In_ LONGLONG Offset,
_In_ ULONG Length,
- _In_opt_ PLARGE_INTEGER ValidDataLength)
+ _In_opt_ PLARGE_INTEGER ValidDataLength,
+ _In_ BOOLEAN SetDirty)
{
/* Let's use a 64K granularity. */
LONGLONG RangeStart, RangeEnd;
if (Entry != 0)
{
- /* There is a page here. Or a swap entry. Or whatever... */
+ /* Dirtify it if it's a resident page and we're asked to */
+ if (SetDirty && !IS_SWAP_FROM_SSE(Entry))
+ MmSetPageEntrySectionSegment(Segment, &CurrentOffset, DIRTY_SSE(Entry));
continue;
}
for (UINT i = 0; i < BYTES_TO_PAGES(ReadLength); i++)
{
+ ULONG_PTR Entry = MAKE_SSE(Pages[i] << PAGE_SHIFT, 0);
LARGE_INTEGER CurrentOffset;
CurrentOffset.QuadPart = ChunkOffset + (i * PAGE_SIZE);
ASSERT(MM_IS_WAIT_PTE(MmGetPageEntrySectionSegment(Segment, &CurrentOffset)));
- MmSetPageEntrySectionSegment(Segment, &CurrentOffset, MAKE_SSE(Pages[i] << PAGE_SHIFT, 0));
+ if (SetDirty)
+ Entry = DIRTY_SSE(Entry);
+
+ MmSetPageEntrySectionSegment(Segment, &CurrentOffset, Entry);
}
MmUnlockSectionSegment(Segment);
PFSRTL_COMMON_FCB_HEADER FcbHeader = Segment->FileObject->FsContext;
- Status = MmMakeSegmentResident(Segment, Offset.QuadPart, PAGE_SIZE, &FcbHeader->ValidDataLength);
+ Status = MmMakeSegmentResident(Segment, Offset.QuadPart, PAGE_SIZE, &FcbHeader->ValidDataLength, FALSE);
FsRtlReleaseFile(Segment->FileObject);
ASSERT(NT_SUCCESS(Status));
}
}
+ DPRINT("One mapping less for %p\n", ImageSectionObject->FileObject->SectionObjectPointer);
InterlockedDecrement(&ImageSectionObject->MapCount);
}
else
*BaseAddress = (PVOID)ImageBase;
*ViewSize = ImageSize;
+ DPRINT("Mapped %p for section pointer %p\n", ImageSectionObject, ImageSectionObject->FileObject->SectionObjectPointer);
+
/* One more map */
InterlockedIncrement(&ImageSectionObject->MapCount);
}
return Ret;
}
+static
+BOOLEAN
+MiPurgeImageSegment(PMM_SECTION_SEGMENT Segment)
+{
+ PCACHE_SECTION_PAGE_TABLE PageTable;
+
+ MmLockSectionSegment(Segment);
+
+ /* Loop over all entries */
+ for (PageTable = RtlEnumerateGenericTable(&Segment->PageTable, TRUE);
+ PageTable != NULL;
+ PageTable = RtlEnumerateGenericTable(&Segment->PageTable, FALSE))
+ {
+ for (ULONG i = 0; i < _countof(PageTable->PageEntries); i++)
+ {
+ ULONG_PTR Entry = PageTable->PageEntries[i];
+ LARGE_INTEGER Offset;
+
+ if (!Entry)
+ continue;
+
+ if (IS_SWAP_FROM_SSE(Entry) || (SHARE_COUNT_FROM_SSE(Entry) > 0))
+ {
+ /* I/O ongoing or swap entry. Someone mapped this file as we were not looking */
+ MmUnlockSectionSegment(Segment);
+ return FALSE;
+ }
+
+ /* Regular entry */
+ ASSERT(!IS_WRITE_SSE(Entry));
+ ASSERT(MmGetSavedSwapEntryPage(PFN_FROM_SSE(Entry)) == 0);
+
+ /* Properly remove using the used API */
+ Offset.QuadPart = PageTable->FileOffset.QuadPart + (i << PAGE_SHIFT);
+ MmSetPageEntrySectionSegment(Segment, &Offset, 0);
+ MmReleasePageMemoryConsumer(MC_USER, PFN_FROM_SSE(Entry));
+ }
+ }
+
+ MmUnlockSectionSegment(Segment);
+
+ return TRUE;
+}
+
/*
* @implemented
*/
switch(FlushType)
{
case MmFlushForDelete:
+ {
+ /*
+ * FIXME: Check for outstanding write probes on Data section.
+ * How do we do that ?
+ */
+ }
+ /* Fall-through */
+ case MmFlushForWrite:
{
KIRQL OldIrql = MiAcquirePfnLock();
PMM_IMAGE_SECTION_OBJECT ImageSectionObject = SectionObjectPointer->ImageSectionObject;
- if (!ImageSectionObject || (ImageSectionObject->SegFlags & MM_SEGMENT_INDELETE))
+ DPRINT("Deleting or modifying %p\n", SectionObjectPointer);
+
+ /* Wait for concurrent creation or deletion of image to be done */
+ ImageSectionObject = SectionObjectPointer->ImageSectionObject;
+ while (ImageSectionObject && (ImageSectionObject->SegFlags & (MM_SEGMENT_INCREATE | MM_SEGMENT_INDELETE)))
{
+ MiReleasePfnLock(OldIrql);
+ KeDelayExecutionThread(KernelMode, FALSE, &TinyTime);
+ OldIrql = MiAcquirePfnLock();
+ ImageSectionObject = SectionObjectPointer->ImageSectionObject;
+ }
+
+ if (!ImageSectionObject)
+ {
+ DPRINT("No image section object. Accepting\n");
+ /* Nothing to do */
MiReleasePfnLock(OldIrql);
return TRUE;
}
{
/* We do. No way to delete it */
MiReleasePfnLock(OldIrql);
+ DPRINT("Denying. There are mappings open\n");
return FALSE;
}
InterlockedIncrement64(&ImageSectionObject->RefCount);
MiReleasePfnLock(OldIrql);
+ DPRINT("Purging\n");
+
for (ULONG i = 0; i < ImageSectionObject->NrSegments; i++)
{
- PMM_SECTION_SEGMENT Segment = &ImageSectionObject->Segments[i];
- LONGLONG Length;
-
- MmLockSectionSegment(Segment);
- /* Loop over all entries */
- LARGE_INTEGER Offset;
- Offset.QuadPart = 0;
-
- Length = Segment->Length.QuadPart;
- if (Length < Segment->RawLength.QuadPart)
- Length = Segment->RawLength.QuadPart;
-
- while (Offset.QuadPart < Length)
- {
- ULONG_PTR Entry = MmGetPageEntrySectionSegment(Segment, &Offset);
-
- /* Shared data must already be discarded, and nobody should be reading it. */
- ASSERT(!IS_SWAP_FROM_SSE(Entry));
- if (Entry != 0)
- {
- DPRINT1("Freeing page %lx for image section %p\n", PFN_FROM_SSE(Entry), ImageSectionObject);
- /* Release the page */
- ASSERT(SHARE_COUNT_FROM_SSE(Entry) == 0);
- ASSERT(!IS_WRITE_SSE(Entry));
- ASSERT(MmGetSavedSwapEntryPage(PFN_FROM_SSE(Entry)) == 0);
- MmSetPageEntrySectionSegment(Segment, &Offset, 0);
- MmReleasePageMemoryConsumer(MC_USER, PFN_FROM_SSE(Entry));
- }
- Offset.QuadPart += PAGE_SIZE;
- }
- MmUnlockSectionSegment(Segment);
+ if (!MiPurgeImageSegment(&ImageSectionObject->Segments[i]))
+ break;
}
/* Grab lock again */
MmDereferenceSegmentWithLock(&ImageSectionObject->Segments[0], OldIrql);
return TRUE;
}
- case MmFlushForWrite:
- {
- BOOLEAN Ret = TRUE;
- KIRQL OldIrql = MiAcquirePfnLock();
-
- if (SectionObjectPointer->ImageSectionObject)
- {
- PMM_IMAGE_SECTION_OBJECT ImageSectionObject = SectionObjectPointer->ImageSectionObject;
- if (!(ImageSectionObject->SegFlags & MM_SEGMENT_INDELETE))
- Ret = FALSE;
- }
-
- MiReleasePfnLock(OldIrql);
- return Ret;
- }
}
return FALSE;
}
/* There must be a segment for this call */
ASSERT(Segment);
- NTSTATUS Status = MmMakeSegmentResident(Segment, Offset, Length, ValidDataLength);
+ NTSTATUS Status = MmMakeSegmentResident(Segment, Offset, Length, ValidDataLength, FALSE);
MmDereferenceSegment(Segment);
* We got a dirty entry. This path is for the shared data,
* be-it regular file maps or shared sections of DLLs
*/
- ASSERT(!Segment->WriteCopy);
- ASSERT(FlagOn(*Segment->Flags, MM_DATAFILE_SEGMENT) || FlagOn(Segment->Image.Characteristics, IMAGE_SCN_MEM_SHARED));
+ ASSERT(FlagOn(*Segment->Flags, MM_DATAFILE_SEGMENT) ||
+ FlagOn(Segment->Image.Characteristics, IMAGE_SCN_MEM_SHARED));
/* Insert the cleaned entry back. Mark it as write in progress, and clear the dirty bit. */
Entry = MAKE_SSE(PAGE_FROM_SSE(Entry), SHARE_COUNT_FROM_SSE(Entry) + 1);
ASSERT(PageOut);
/* And this must be for a shared section in a DLL */
- ASSERT(Segment->Image.Characteristics & IMAGE_SCN_MEM_SHARED);
+ ASSERT(FlagOn(Segment->Image.Characteristics, IMAGE_SCN_MEM_SHARED));
SWAPENTRY SwapEntry = MmGetSavedSwapEntryPage(Page);
if (!SwapEntry)
projects / reactos.git / commitdiff