[BROWSEUI]
authorDavid Quintana <gigaherz@gmail.com>
Tue, 20 May 2014 09:09:08 +0000 (09:09 +0000)
committerDavid Quintana <gigaherz@gmail.com>
Tue, 20 May 2014 09:09:08 +0000 (09:09 +0000)
* Fix a couple redundant IFs.
CORE-8248 #resolve #comment Thanks for reporting.

svn path=/branches/shell-experiments/; revision=63381

dll/win32/browseui/addressband.cpp
dll/win32/browseui/addresseditbox.cpp

index d4f9892..2f5ef7c 100644 (file)
@@ -217,8 +217,7 @@ HRESULT STDMETHODCALLTYPE CAddressBand::SetSite(IUnknown *pUnkSite)
     hResult = IUnknown_QueryService(pUnkSite, SID_SShellBrowser, IID_PPV_ARG(IBrowserService, &browserService));
     if (SUCCEEDED(hResult))
     {
-        if (SUCCEEDED(hResult))
-            hResult = AtlAdvise(browserService, static_cast<IDispatch *>(this), DIID_DWebBrowserEvents, &fAdviseCookie);
+        hResult = AtlAdvise(browserService, static_cast<IDispatch *>(this), DIID_DWebBrowserEvents, &fAdviseCookie);
     }
 
     return hResult;
index 7264345..90a4b19 100644 (file)
@@ -78,8 +78,7 @@ HRESULT STDMETHODCALLTYPE CAddressEditBox::Init(HWND comboboxEx, HWND editContro
     HRESULT hResult = IUnknown_QueryService(param18, SID_SShellBrowser, IID_PPV_ARG(IBrowserService, &browserService));
     if (SUCCEEDED(hResult))
     {
-        if (SUCCEEDED(hResult))
-            hResult = AtlAdvise(browserService, static_cast<IDispatch *>(this), DIID_DWebBrowserEvents, &fAdviseCookie);
+        hResult = AtlAdvise(browserService, static_cast<IDispatch *>(this), DIID_DWebBrowserEvents, &fAdviseCookie);
     }
 
     return hResult;