[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx

CORE-14532
CORE-14857

diff --git a/dll/win32/kernel32/client/loader.c b/dll/win32/kernel32/client/loader.c
index a6f84ba..817f101 100644 (file)
--- a/dll/win32/kernel32/client/loader.c
+++ b/dll/win32/kernel32/client/loader.c
@@ -463,6 +463,7 @@ FreeLibrary(HINSTANCE hLibModule)
     if (LDR_IS_DATAFILE(hLibModule))
     {
         // FIXME: This SEH should go inside RtlImageNtHeader instead
     if (LDR_IS_DATAFILE(hLibModule))
     {
         // FIXME: This SEH should go inside RtlImageNtHeader instead

+        // See https://jira.reactos.org/browse/CORE-14857

         _SEH2_TRY
         {
             /* This is a LOAD_LIBRARY_AS_DATAFILE module, check if it's a valid one */
         _SEH2_TRY
         {
             /* This is a LOAD_LIBRARY_AS_DATAFILE module, check if it's a valid one */

diff --git a/modules/rostests/apitests/ntdll/load_notifications.c b/modules/rostests/apitests/ntdll/load_notifications.c
index 430e2fc..8543f2f 100644 (file)
--- a/modules/rostests/apitests/ntdll/load_notifications.c
+++ b/modules/rostests/apitests/ntdll/load_notifications.c
@@ -72,7 +72,7 @@ BOOL WINAPI notify_DllMain(IN HINSTANCE hDllHandle, IN DWORD dwReason, IN LPVOID
     }
     else
     {
     }
     else
     {

-        ok_int(handlers, g_DLL_DETACH);
+        ok_int(handlers, g_DLL_DETACH); // For failures, see https://jira.reactos.org/browse/CORE-14857

     }
 
     if (InterlockedCompareExchange(&g_DllMainExcept, 0xffffff, dwReason) == dwReason)
     }
 
     if (InterlockedCompareExchange(&g_DllMainExcept, 0xffffff, dwReason) == dwReason)

diff --git a/sdk/lib/rtl/image.c b/sdk/lib/rtl/image.c
index c7815b0..5629c77 100644 (file)
--- a/sdk/lib/rtl/image.c
+++ b/sdk/lib/rtl/image.c
@@ -134,6 +134,7 @@ LdrVerifyMappedImageMatchesChecksum(
 
 /*
  * @implemented
 
 /*
  * @implemented

+ * @note This needs SEH (See https://jira.reactos.org/browse/CORE-14857)

  */
 NTSTATUS
 NTAPI
  */
 NTSTATUS
 NTAPI