- avoid crash, pszExt is null when creating a link to a file without extension
authorKamil Hornicek <kamil.hornicek@reactos.org>
Sun, 21 Dec 2008 12:17:36 +0000 (12:17 +0000)
committerKamil Hornicek <kamil.hornicek@reactos.org>
Sun, 21 Dec 2008 12:17:36 +0000 (12:17 +0000)
svn path=/trunk/; revision=38230

reactos/dll/win32/shell32/shv_def_cmenu.c

index ea3662c..45705e1 100644 (file)
@@ -1202,11 +1202,9 @@ DoCreateLink(
     if (StrRetToBufW(&strFile, This->dcm.apidl[0], szPath, MAX_PATH) != S_OK)
         return E_FAIL;
 
-
     pszExt = wcsrchr(szPath, L'.');
-    pszExt[0] = 0;
 
-    if (!wcsicmp(pszExt + 1, szLnk))
+    if (pszExt && !wcsicmp(pszExt + 1, szLnk))
     {
         if (!GetUniqueFileName(szPath, pszExt + 1, szTarget, TRUE))
             return E_FAIL;
@@ -1231,7 +1229,7 @@ DoCreateLink(
         {
             return E_FAIL;
         }
-        pszExt[0] = '.';
+
         if (SUCCEEDED(IShellLinkW_SetPath(nLink, szPath)))
         {
             if (SUCCEEDED(IShellLinkW_QueryInterface(nLink, &IID_IPersistFile, (LPVOID*)&ipf)))