[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194
authorThomas Faber <thomas.faber@reactos.org>
Thu, 22 Feb 2018 10:51:07 +0000 (11:51 +0100)
committerThomas Faber <thomas.faber@reactos.org>
Thu, 22 Feb 2018 10:53:34 +0000 (11:53 +0100)
dll/win32/shell32/shellmenu/CMenuToolbars.cpp

index 2e8dbf3..c1cd0b1 100644 (file)
@@ -1321,7 +1321,11 @@ HRESULT CMenuSFToolbar::FillToolbar(BOOL clearFirst)
     {
         if (m_menuBand->_CallCBWithItemPidl(item, 0x10000000, 0, 0) == S_FALSE)
         {
-            DPA_AppendPtr(dpaSort, ILClone(item));
+            DPA_AppendPtr(dpaSort, item);
+        }
+        else
+        {
+            CoTaskMemFree(item);
         }
 
         hr = eidl->Next(1, &item, NULL);