[0.4.9][DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643)

- Fixes MSVC errors: "...\dll\win32\dbghelp\minidump.c(857) : error C4028: formal parameter 5 different from declaration", for parameters 5, 6 and 7.
- Fix spec file too.
CORE-7538

I could reproduce those warnings on MSVC2010SP1 x86.
Ftr Wine 7.0 uses the same spec for that func atm, see
https://fossies.org/linux/wine/dlls/dbghelp/dbghelp.spec (18 Jan 2022, 8523 Bytes)

fix picked from 0.4.10-dev-275-g 3766d836c701d59cedb2d014bde572a7e8b40e59

diff --git a/dll/win32/dbghelp/dbghelp.spec b/dll/win32/dbghelp/dbghelp.spec
index 2a57251..95cebca 100644 (file)
--- a/dll/win32/dbghelp/dbghelp.spec
+++ b/dll/win32/dbghelp/dbghelp.spec
@@ -30,7 +30,7 @@
 @ stdcall MakeSureDirectoryPathExists(str)
 @ stdcall MapDebugInformation(long str str long)
 @ stdcall MiniDumpReadDumpStream(ptr long ptr ptr ptr)
-@ stdcall MiniDumpWriteDump(ptr long ptr long long long long)
+@ stdcall MiniDumpWriteDump(ptr long ptr long ptr ptr ptr)
 @ stdcall SearchTreeForFile(str str ptr)
 @ stdcall SearchTreeForFileW(wstr wstr ptr)
 @ stdcall StackWalk(long long long ptr ptr ptr ptr ptr ptr)

diff --git a/sdk/include/psdk/dbghelp.h b/sdk/include/psdk/dbghelp.h
index 28eec9a..a8fdf38 100644 (file)
--- a/sdk/include/psdk/dbghelp.h
+++ b/sdk/include/psdk/dbghelp.h
@@ -901,9 +901,9 @@ MiniDumpWriteDump(
   _In_ DWORD,
   _In_ HANDLE,
   _In_ MINIDUMP_TYPE,
-  _In_opt_ const PMINIDUMP_EXCEPTION_INFORMATION,
-  _In_opt_ const PMINIDUMP_USER_STREAM_INFORMATION,
-  _In_opt_ const PMINIDUMP_CALLBACK_INFORMATION);
+  _In_opt_ PMINIDUMP_EXCEPTION_INFORMATION,
+  _In_opt_ PMINIDUMP_USER_STREAM_INFORMATION,
+  _In_opt_ PMINIDUMP_CALLBACK_INFORMATION);
 
 BOOL
 WINAPI