[NTOS:MM]
authorThomas Faber <thomas.faber@reactos.org>
Sun, 17 Nov 2013 21:58:48 +0000 (21:58 +0000)
committerThomas Faber <thomas.faber@reactos.org>
Sun, 17 Nov 2013 21:58:48 +0000 (21:58 +0000)
- Fix some MSVC warnings

svn path=/trunk/; revision=61022

reactos/ntoskrnl/mm/ARM3/pool.c
reactos/ntoskrnl/mm/ARM3/sysldr.c

index 8d01492..5478912 100644 (file)
@@ -724,8 +724,9 @@ MiAllocatePoolPages(IN POOL_TYPE PoolType,
                                  (FreeEntry->Size  << PAGE_SHIFT));
 
                 /* Remove the item from the list, depending if pool is protected */
-                MmProtectFreedNonPagedPool ?
-                    MiProtectedPoolRemoveEntryList(&FreeEntry->List) :
+                if (MmProtectFreedNonPagedPool)
+                    MiProtectedPoolRemoveEntryList(&FreeEntry->List);
+                else
                     RemoveEntryList(&FreeEntry->List);
 
                 //
@@ -738,8 +739,9 @@ MiAllocatePoolPages(IN POOL_TYPE PoolType,
                     if (i >= MI_MAX_FREE_PAGE_LISTS) i = MI_MAX_FREE_PAGE_LISTS - 1;
 
                     /* Insert the entry into the free list head, check for prot. pool */
-                    MmProtectFreedNonPagedPool ?
-                        MiProtectedPoolInsertList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List, TRUE) :
+                    if (MmProtectFreedNonPagedPool)
+                        MiProtectedPoolInsertList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List, TRUE);
+                    else
                         InsertTailList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List);
 
                     /* Is freed non paged pool protected? */
@@ -1085,8 +1087,9 @@ MiFreePoolPages(IN PVOID StartingVa)
         FreePages += FreeEntry->Size;
 
         /* Remove the item from the list, depending if pool is protected */
-        MmProtectFreedNonPagedPool ?
-            MiProtectedPoolRemoveEntryList(&FreeEntry->List) :
+        if (MmProtectFreedNonPagedPool)
+            MiProtectedPoolRemoveEntryList(&FreeEntry->List);
+        else
             RemoveEntryList(&FreeEntry->List);
     }
 
@@ -1165,8 +1168,9 @@ MiFreePoolPages(IN PVOID StartingVa)
         if (FreeEntry->Size < (MI_MAX_FREE_PAGE_LISTS - 1))
         {
             /* Remove the item from the list, depending if pool is protected */
-            MmProtectFreedNonPagedPool ?
-                MiProtectedPoolRemoveEntryList(&FreeEntry->List) :
+            if (MmProtectFreedNonPagedPool)
+                MiProtectedPoolRemoveEntryList(&FreeEntry->List);
+            else
                 RemoveEntryList(&FreeEntry->List);
 
             //
@@ -1181,8 +1185,9 @@ MiFreePoolPages(IN PVOID StartingVa)
             if (i >= MI_MAX_FREE_PAGE_LISTS) i = MI_MAX_FREE_PAGE_LISTS - 1;
 
             /* Insert the entry into the free list head, check for prot. pool */
-            MmProtectFreedNonPagedPool ?
-                MiProtectedPoolInsertList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List, TRUE) :
+            if (MmProtectFreedNonPagedPool)
+                MiProtectedPoolInsertList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List, TRUE);
+            else
                 InsertTailList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List);
         }
         else
@@ -1212,8 +1217,9 @@ MiFreePoolPages(IN PVOID StartingVa)
         if (i >= MI_MAX_FREE_PAGE_LISTS) i = MI_MAX_FREE_PAGE_LISTS - 1;
 
         /* Insert the entry into the free list head, check for prot. pool */
-        MmProtectFreedNonPagedPool ?
-            MiProtectedPoolInsertList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List, TRUE) :
+        if (MmProtectFreedNonPagedPool)
+            MiProtectedPoolInsertList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List, TRUE);
+        else
             InsertTailList(&MmNonPagedPoolFreeListHead[i], &FreeEntry->List);
     }
 
index 6134206..537d269 100644 (file)
@@ -557,8 +557,10 @@ MiProcessLoaderEntry(IN PLDR_DATA_TABLE_ENTRY LdrEntry,
     OldIrql = KeAcquireSpinLockRaiseToSynch(&PsLoadedModuleSpinLock);
 
     /* Insert or remove from the list */
-    Insert ? InsertTailList(&PsLoadedModuleList, &LdrEntry->InLoadOrderLinks) :
-             RemoveEntryList(&LdrEntry->InLoadOrderLinks);
+    if (Insert)
+        InsertTailList(&PsLoadedModuleList, &LdrEntry->InLoadOrderLinks);
+    else
+        RemoveEntryList(&LdrEntry->InLoadOrderLinks);
 
     /* Release locks */
     KeReleaseSpinLock(&PsLoadedModuleSpinLock, OldIrql);