[LOG2LINES] Optimize malloc() calls.
authorSerge Gautherie <reactos-git_serge_171003@gautherie.fr>
Sun, 26 Aug 2018 01:05:46 +0000 (03:05 +0200)
committerHermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Sat, 8 Dec 2018 16:38:16 +0000 (17:38 +0100)
sdk/tools/log2lines/options.c

index 0bcbf06..8fb9bb2 100644 (file)
@@ -96,8 +96,8 @@ int optionInit(int argc, const char **argv)
                 strcpy(opt_logFile, argv[i+1]);
                 break;
             case 'P':
                 strcpy(opt_logFile, argv[i+1]);
                 break;
             case 'P':
-                free(opt_Pipe);
-                opt_Pipe = malloc(LINESIZE);
+                if (!opt_Pipe)
+                    opt_Pipe = malloc(LINESIZE);
                 strcpy(opt_Pipe, argv[i+1]);
                 break;
             case 'z':
                 strcpy(opt_Pipe, argv[i+1]);
                 break;
             case 'z':
@@ -166,8 +166,8 @@ int optionParse(int argc, const char **argv)
             break;
         case 'R':
             optCount++;
             break;
         case 'R':
             optCount++;
-            free(opt_Revision);
-            opt_Revision = malloc(LINESIZE);
+            if (!opt_Revision)
+                opt_Revision = malloc(LINESIZE);
             sscanf(optarg, "%s", opt_Revision);
             if (strcmp(opt_Revision, "check") == 0)
                 opt_Revision_check ++;
             sscanf(optarg, "%s", opt_Revision);
             if (strcmp(opt_Revision, "check") == 0)
                 opt_Revision_check ++;