[RSHELL]

* CMenuBand: Send timer notifications for all items, so we can hide a previous submenu when the user hovers an item without submenu.
* CMenuBand: Avoid a stack overflow in some versions of windows by relying on the stored value instead of asking for it in the middle of a changed event.
CORE-7881

svn path=/branches/shell-experiments/; revision=62303

diff --git a/base/shell/rshell/CMenuBand.cpp b/base/shell/rshell/CMenuBand.cpp
index c3408dd..fe23478 100644 (file)
--- a/base/shell/rshell/CMenuBand.cpp
+++ b/base/shell/rshell/CMenuBand.cpp
@@ -676,9 +676,14 @@ LRESULT CMenuToolbarBase::SubclassProc(HWND hWnd, UINT uMsg, WPARAM wParam, LPAR
     case WM_TIMER:
         if (wParam == TIMERID_HOTTRACK)
         {
     case WM_TIMER:
         if (wParam == TIMERID_HOTTRACK)
         {

-            m_menuBand->_OnPopupSubMenu(NULL, NULL, NULL);
-            PopupItem(m_hotItem);

             KillTimer(hWnd, TIMERID_HOTTRACK);
             KillTimer(hWnd, TIMERID_HOTTRACK);

+
+            m_menuBand->_OnPopupSubMenu(NULL, NULL, NULL);
+
+            if (HasSubMenu(m_hotItem) == S_OK)
+            {
+                PopupItem(m_hotItem);
+            }

         }
     }
 
         }
     }
 


@@ -696,12 +701,9 @@ HRESULT CMenuToolbarBase::OnHotItemChange(const NMTBHOTITEM * hot)
     }
     else if (m_hotItem != hot->idNew)
     {
     }
     else if (m_hotItem != hot->idNew)
     {

-        if (HasSubMenu(hot->idNew) == S_OK)
-        {
-            DWORD elapsed = 0;
-            SystemParametersInfo(SPI_GETMENUSHOWDELAY, 0, &elapsed, 0);
-            SetTimer(m_hwnd, TIMERID_HOTTRACK, elapsed, NULL);
-        }
+        DWORD elapsed = 0;
+        SystemParametersInfo(SPI_GETMENUSHOWDELAY, 0, &elapsed, 0);
+        SetTimer(m_hwnd, TIMERID_HOTTRACK, elapsed, NULL);

 
         m_hotItem = hot->idNew;
         m_menuBand->_OnHotItemChanged(this, m_hotItem);
 
         m_hotItem = hot->idNew;
         m_menuBand->_OnHotItemChanged(this, m_hotItem);


@@ -838,7 +840,7 @@ HRESULT CMenuToolbarBase::OnCommand(WPARAM wParam, LPARAM lParam, LRESULT *theRe
 
 HRESULT CMenuToolbarBase::ChangeHotItem(DWORD dwSelectType)
 {
 
 HRESULT CMenuToolbarBase::ChangeHotItem(DWORD dwSelectType)
 {

-    int prev = SendMessage(m_hwnd, TB_GETHOTITEM, 0, 0);
+    int prev = m_hotItem;

     int index = -1;
 
     if (dwSelectType != 0xFFFFFFFF)
     int index = -1;
 
     if (dwSelectType != 0xFFFFFFFF)


@@ -896,7 +898,7 @@ HRESULT CMenuToolbarBase::ChangeHotItem(DWORD dwSelectType)
             if (btn.dwData)
             {
                 m_hotItem = btn.idCommand;
             if (btn.dwData)
             {
                 m_hotItem = btn.idCommand;

-                if (prev != index)
+                if (prev != m_hotItem)

                 {
                     SendMessage(m_hwnd, TB_SETHOTITEM, index, 0);
                     return m_menuBand->_OnHotItemChanged(this, m_hotItem);
                 {
                     SendMessage(m_hwnd, TB_SETHOTITEM, index, 0);
                     return m_menuBand->_OnHotItemChanged(this, m_hotItem);


@@ -916,7 +918,7 @@ HRESULT CMenuToolbarBase::ChangeHotItem(DWORD dwSelectType)
     }
 
     m_hotItem = -1;
     }
 
     m_hotItem = -1;

-    if (prev != index)
+    if (prev != m_hotItem)

     {
         SendMessage(m_hwnd, TB_SETHOTITEM, -1, 0);
         m_menuBand->_OnHotItemChanged(NULL, -1);
     {
         SendMessage(m_hwnd, TB_SETHOTITEM, -1, 0);
         m_menuBand->_OnHotItemChanged(NULL, -1);