[0.4.13][CRT] Do Not lock ioinfo when spawning functions (#4099) CORE-15176
authorJoachim Henze <Joachim.Henze@reactos.org>
Sun, 9 Jan 2022 08:26:36 +0000 (09:26 +0100)
committerJoachim Henze <Joachim.Henze@reactos.org>
Sun, 9 Jan 2022 08:26:36 +0000 (09:26 +0100)
This fixes CORE-15176 'Gimp 2.6.11 hangs when opening a file'.
It regressed by 0.4.9-dev-446-g bffd8201d0a822365e1950c558aaf33c26f20002

Fix picked from 0.4.15-dev-3363-g 252a7530d0dc267b1cd1743769524c88bbadc429

sdk/lib/crt/stdio/file.c

index 0793a3f..40cda33 100644 (file)
@@ -434,7 +434,7 @@ unsigned create_io_inherit_block(WORD *size, BYTE **block)
   for (fd = 0; fd < last_fd; fd++)
   {
     /* to be inherited, we need it to be open, and that DONTINHERIT isn't set */
-    fdinfo = get_ioinfo(fd);
+    fdinfo = get_ioinfo_nolock(fd);
     if ((fdinfo->wxflag & (WX_OPEN | WX_DONTINHERIT)) == WX_OPEN)
     {
       *wxflag_ptr = fdinfo->wxflag;
@@ -445,7 +445,6 @@ unsigned create_io_inherit_block(WORD *size, BYTE **block)
       *wxflag_ptr = 0;
       *handle_ptr = INVALID_HANDLE_VALUE;
     }
-    release_ioinfo(fdinfo);
     wxflag_ptr++; handle_ptr++;
   }
   return TRUE;