From: Timo Kreuzer Date: Sun, 19 Oct 2014 19:37:55 +0000 (+0000) Subject: [NTDLL_APITEST] Disable NtContinue test when runtime checks are enabled X-Git-Tag: backups/tcpip_revolution@71025~404 X-Git-Url: https://git.reactos.org/?p=reactos.git;a=commitdiff_plain;h=211e68d9b1c9fe2c001a48351b1b47883ff68440;ds=sidebyside [NTDLL_APITEST] Disable NtContinue test when runtime checks are enabled [USER32_APITEST] Disable WndProc test when runtime checks are enabled [KERNEL32_WINETEST] Zero initialize a buffer. This is necessary, since we fail all calls to GetVolumePathNamesForVolumeNameW and thus never get any data into the buffer, which can later result in a buffer-overrun, when doing a lstrlenW on it. svn path=/trunk/; revision=64831 --- diff --git a/rostests/apitests/ntdll/NtContinue.c b/rostests/apitests/ntdll/NtContinue.c index 8776bca59bf..1f619f1ffa6 100644 --- a/rostests/apitests/ntdll/NtContinue.c +++ b/rostests/apitests/ntdll/NtContinue.c @@ -123,6 +123,10 @@ void check(CONTEXT * pContext) START_TEST(NtContinue) { +#ifdef __RUNTIME_CHECKS__ + skip("This test breaks MSVC runtime checks!"); + return; +#endif /* __RUNTIME_CHECKS__ */ initrand(); /* First time */ diff --git a/rostests/apitests/user32/WndProc.c b/rostests/apitests/user32/WndProc.c index 337f36586cf..bdcff2f8d57 100644 --- a/rostests/apitests/user32/WndProc.c +++ b/rostests/apitests/user32/WndProc.c @@ -99,5 +99,9 @@ static void test_wndproc(void) START_TEST(WndProc) { +#ifdef __RUNTIME_CHECKS__ + skip("This test breaks MSVC runtime checks!"); + return; +#endif /* __RUNTIME_CHECKS__ */ test_wndproc(); } diff --git a/rostests/winetests/kernel32/volume.c b/rostests/winetests/kernel32/volume.c index fd52a2a9274..191987c8ed0 100644 --- a/rostests/winetests/kernel32/volume.c +++ b/rostests/winetests/kernel32/volume.c @@ -765,6 +765,12 @@ static void test_GetVolumePathNamesForVolumeNameW(void) WCHAR volume[MAX_PATH], buffer[MAX_PATH]; DWORD len, error; +#ifdef __REACTOS__ + /* due to failing all calls to GetVolumeNameForVolumeMountPointW, this + * buffer never gets initialized and could cause a buffer overflow later */ + volume[0] = 0; +#endif /* __REACTOS__ */ + if (!pGetVolumePathNamesForVolumeNameW || !pGetVolumeNameForVolumeMountPointW) { win_skip("required functions not found\n");