From: Thomas Bluemel <thomas@reactsoft.com>
Date: Thu, 1 Dec 2005 21:17:25 +0000 (+0000)
Subject: don't tell the user the device is working properly when the drivers aren't even installed
X-Git-Tag: backups/ros-branch-0_2_9@19949~126
X-Git-Url: https://git.reactos.org/?p=reactos.git;a=commitdiff_plain;h=3c3c3ff8f8f08ad802a67a9425640ffe1dc4c9fe

don't tell the user the device is working properly when the drivers aren't even installed

svn path=/trunk/; revision=19807
---

diff --git a/reactos/lib/devmgr/En.rc b/reactos/lib/devmgr/En.rc
index f17bd77a9cc..cc6c7af39ba 100644
--- a/reactos/lib/devmgr/En.rc
+++ b/reactos/lib/devmgr/En.rc
@@ -15,6 +15,7 @@ BEGIN
     IDS_ENABLEDEVICE "Use this device (enable)"
     IDS_DISABLEDEVICE "Do not use this device (disable)"
     IDS_UNKNOWNDEVICE "Unknown device"
+    IDS_NODRIVERLOADED "No drivers are installed for this device."
 END
 
 STRINGTABLE
diff --git a/reactos/lib/devmgr/advprop.c b/reactos/lib/devmgr/advprop.c
index 0ccd63e376d..76c8c25659a 100644
--- a/reactos/lib/devmgr/advprop.c
+++ b/reactos/lib/devmgr/advprop.c
@@ -30,8 +30,6 @@
 #define NDEBUG
 #include <debug.h>
 
-#define DPN_DEVICEUPDATE    (WM_USER + 0x1000)
-
 typedef INT_PTR (WINAPI *PPROPERTYSHEETW)(LPCPROPSHEETHEADERW);
 typedef HPROPSHEETPAGE (WINAPI *PCREATEPROPERTYSHEETPAGEW)(LPCPROPSHEETPAGEW);
 typedef BOOL (WINAPI *PDESTROYPROPERTYSHEETPAGE)(HPROPSHEETPAGE);
@@ -437,21 +435,18 @@ UpdateDevInfo(IN HWND hwndDlg,
     dap->CanDisable = FALSE;
     dap->DeviceEnabled = FALSE;
 
-    if (dap->DeviceInfoSet != INVALID_HANDLE_VALUE)
+    if (CanDisableDevice(dap->DeviceInfoData.DevInst,
+                         dap->hMachine,
+                         &bFlag))
     {
-        if (CanDisableDevice(dap->DeviceInfoData.DevInst,
-                             dap->hMachine,
-                             &bFlag))
-        {
-            dap->CanDisable = bFlag;
-        }
+        dap->CanDisable = bFlag;
+    }
 
-        if (IsDeviceEnabled(dap->DeviceInfoData.DevInst,
-                            dap->hMachine,
-                            &bFlag))
-        {
-            dap->DeviceEnabled = bFlag;
-        }
+    if (IsDeviceEnabled(dap->DeviceInfoData.DevInst,
+                        dap->hMachine,
+                        &bFlag))
+    {
+        dap->DeviceEnabled = bFlag;
     }
 
     /* enable/disable the device usage controls */
diff --git a/reactos/lib/devmgr/misc.c b/reactos/lib/devmgr/misc.c
index af80aebbd2f..2492ff91aed 100644
--- a/reactos/lib/devmgr/misc.c
+++ b/reactos/lib/devmgr/misc.c
@@ -452,6 +452,11 @@ GetDeviceStatusString(IN DEVINST DevInst,
         szBuffer[0] = L'\0';
         if (ProblemNumber == 0)
         {
+            if (!(Status & DN_DRIVER_LOADED))
+            {
+                MessageId = IDS_NODRIVERLOADED;
+            }
+
             goto UnknownProblem;
         }
         else
diff --git a/reactos/lib/devmgr/resource.h b/reactos/lib/devmgr/resource.h
index 7af977fdcdc..1fe15a4b877 100644
--- a/reactos/lib/devmgr/resource.h
+++ b/reactos/lib/devmgr/resource.h
@@ -36,6 +36,7 @@
 #define IDS_ENABLEDEVICE	0x108
 #define IDS_DISABLEDEVICE	0x109
 #define IDS_UNKNOWNDEVICE	0x10A
+#define IDS_NODRIVERLOADED	0x10B
 
 #define IDS_DEV_NO_PROBLEM			0x200
 #define IDS_DEV_NOT_CONFIGURED			0x201