From: Eric Kohl <eric.kohl@reactos.org>
Date: Sat, 22 Sep 2007 11:26:03 +0000 (+0000)
Subject: Don't use hardcoded strings in the configuration message box. Use string resources... 
X-Git-Tag: backups/win32k-stable@33466~271
X-Git-Url: https://git.reactos.org/?p=reactos.git;a=commitdiff_plain;h=847464262c6a5d1e3a191bd328ac35626de871ec;hp=761e8589829bd01ffec9fc377590a95710bf0e9a

Don't use hardcoded strings in the configuration message box. Use string resources instead.

svn path=/trunk/; revision=29137
---

diff --git a/reactos/base/applications/screensavers/starfield/lang/en-US.rc b/reactos/base/applications/screensavers/starfield/lang/en-US.rc
new file mode 100644
index 00000000000..1d2ad6d545d
--- /dev/null
+++ b/reactos/base/applications/screensavers/starfield/lang/en-US.rc
@@ -0,0 +1,8 @@
+LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
+
+STRINGTABLE DISCARDABLE
+BEGIN
+    IDS_DESCRIPTION "Starfield ScreenSaver"
+    IDS_TITLE       "About"
+    IDS_TEXT        "No options need to be set."
+END
diff --git a/reactos/base/applications/screensavers/starfield/resource.h b/reactos/base/applications/screensavers/starfield/resource.h
index dae01eed217..d19735775c6 100644
--- a/reactos/base/applications/screensavers/starfield/resource.h
+++ b/reactos/base/applications/screensavers/starfield/resource.h
@@ -1 +1,4 @@
-#define IDS_DESCRIPTION                 1
+
+#define IDS_DESCRIPTION 1
+#define IDS_TITLE       2
+#define IDS_TEXT        3
diff --git a/reactos/base/applications/screensavers/starfield/screensaver.c b/reactos/base/applications/screensavers/starfield/screensaver.c
index 846a03adaa4..0ce8d80f247 100644
--- a/reactos/base/applications/screensavers/starfield/screensaver.c
+++ b/reactos/base/applications/screensavers/starfield/screensaver.c
@@ -315,6 +315,27 @@ void ParseCommandLine(PSTR szCmdLine, int *chOption, HWND *hwndParent)
 		*hwndParent = 0;
 }
 
+void Configure(void)
+{
+	TCHAR szTitle[256];
+	TCHAR szText[256];
+
+	LoadString(hInstance,
+		   IDS_TITLE,
+		   szTitle,
+		   256);
+
+	LoadString(hInstance,
+		   IDS_TEXT,
+		   szText,
+		   256);
+
+	MessageBox(0,
+	           szText,
+	           szTitle,
+	           MB_OK | MB_ICONWARNING);
+}
+
 int WINAPI WinMain (HINSTANCE hInst,
                     HINSTANCE hPrev,
                     LPSTR lpCmdLine,
@@ -343,10 +364,7 @@ int WINAPI WinMain (HINSTANCE hInst,
 
 		case 'c':
 		default:
-			MessageBox(0,
-			           _T("No options need to be set."),
-			           _T("About"),
-			           MB_OK | MB_ICONWARNING);
+			Configure();
 			return 0;
 	}
 
diff --git a/reactos/base/applications/screensavers/starfield/starfield.rc b/reactos/base/applications/screensavers/starfield/starfield.rc
index b370dc1baab..17dcc0a43ef 100644
--- a/reactos/base/applications/screensavers/starfield/starfield.rc
+++ b/reactos/base/applications/screensavers/starfield/starfield.rc
@@ -10,10 +10,4 @@ LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
 
 #include <reactos/version.rc>
 
-
-LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
-
-STRINGTABLE DISCARDABLE
-BEGIN
-    IDS_DESCRIPTION         "Starfield ScreenSaver"
-END
+#include "lang/en-US.rc"