From: Pierre Schweitzer Date: Sat, 14 Oct 2017 21:19:12 +0000 (+0200) Subject: [KERNEL32] Use proper size for allocating buffer in GetVolumeInformationA(). This... X-Git-Tag: 0.4.8-dev~104 X-Git-Url: https://git.reactos.org/?p=reactos.git;a=commitdiff_plain;h=dc8bfeabcffeaf2bcdc6907af1313e7a7866314e [KERNEL32] Use proper size for allocating buffer in GetVolumeInformationA(). This was leading to allocate a too small buffer under certain conditions and to overrun it. This fixes JRE7 setup. This regression was brought in by r75969. CORE-13888 --- diff --git a/dll/win32/kernel32/client/file/volume.c b/dll/win32/kernel32/client/file/volume.c index e59c291b67f..90016b8e086 100644 --- a/dll/win32/kernel32/client/file/volume.c +++ b/dll/win32/kernel32/client/file/volume.c @@ -87,7 +87,7 @@ GetVolumeInformationA(IN LPCSTR lpRootPathName, /* If caller wants file system name, allocate a buffer to receive it */ if (lpFileSystemNameBuffer != NULL) { - FileSystemNameU.MaximumLength = sizeof(WCHAR) * (nVolumeNameSize + 1); + FileSystemNameU.MaximumLength = sizeof(WCHAR) * (nFileSystemNameSize + 1); FileSystemNameU.Buffer = RtlAllocateHeap(RtlGetProcessHeap(), 0, FileSystemNameU.MaximumLength); if (FileSystemNameU.Buffer == NULL)