From: Alex Ionescu Date: Tue, 22 Nov 2005 08:21:42 +0000 (+0000) Subject: - I wish svn delete would..delete the file -before- committing to that testing before... X-Git-Tag: backups/ros-branch-0_2_9@19949~469 X-Git-Url: https://git.reactos.org/?p=reactos.git;a=commitdiff_plain;h=e20d5baaa04b779ed3d335779125cd652cc49900;hp=de89ca03e4eb6e748108c0b1a7f64dfe71e2afd2 - I wish svn delete would..delete the file -before- committing to that testing before a commit would actually be useful. Fix wdmguid.c build - Update NDK text files. svn path=/trunk/; revision=19459 --- diff --git a/reactos/include/ndk/fixmes.txt b/reactos/include/ndk/fixmes.txt index 6d1e973b213..6d946357a46 100644 --- a/reactos/include/ndk/fixmes.txt +++ b/reactos/include/ndk/fixmes.txt @@ -1,8 +1,135 @@ Complete list of NDK Fixmes before 1.0 Release (Nov 25th 2005) -------------------------------------------------------------- +______________________________________________________________________________________ +[CRITICAL] - Breaking compatibility with official structures. +|pstypes.h - EPROCESS has ReactOS only fields. Includes ReactOS Internal header. +|pstypes.h - W32_CALLOUT_DATA has ReactOS only fields. +|obtypes.h - Object callbacks are ReactOS only definitions. +|obtypes.h - Object Header includes ReactOS only type. +|mmtypes.h - _MADDRESS_SPACE is ReactOS only field. +|ketypes.h - _KPROFILE needs to be updated with new definitions. +|ketypes.h - _KINTERRUPT needs to be verified with new definitions. +|haltypes.h - Loader Parameter Block is ReactOS Version, not NT. +| +[MAJOR] - Using incorrect, missing, or invalid names or definitions. +|i386/ketypes.h - _KTRAP_FRAME definition is broken. +|i386/ketypes.h - _KTSSNOIOPM is not an official type. +|rtltypes.h - PPF_ Defines don't seem to be the real names (try to find them). +|rtltypes.h - _RTL_PROCESS_BACKTRACE_INFORMATION isn't done. +|haltypes.h - Multi-Boot flags are ReactOS Only. +|extypes.h - SystemPowerInformation in SYSTEM_INFORMATION_CLASS causes conflict. +|extypes.h - _RUNDOWN_DESCRIPTOR is possibly incorrect/unofficial. +|asm.h - Selector names are not official. +|extypes.h - Class 42 (SYSTEM_POWER_INFORMATION causes conflict). +|extypes.h - Classes 13, 20, 30, 31, 49, 51, 52, 54+ are undefined. +| +[MINOR] - Related to location of functions, comments, etc. +|arch/ketypes.h - _KDPC_DATA, PP_LOOKASIDE_LIST shouldn't be there. +|zwfuncs.h - APIs are not organized. +|pstypes.h - Check if _PAGEFAULT_HISTORY shouldn't go in mmtypes.h instead. +|lpctypes.h - Consider moving _HARDERROR_MSG to extypes.h? +|lpctypes.h - Consider moving _CLIENT_DIED_MSG to pstypes.h? +|ketypes.h - Consider moving KNODE to mmtypes.h? +|ketypes.h - Consider moving NtBuildNumber to extypes.h? +|extypes.h - consider moving PORT_ALL_ACCESS to lpctypes.h +|GENERIC - Make sure that all files can be included in standalone! +|_____________________________________________________________________________________ List of ReactOS Applications compiling with the NDK +(verify, fix, and optimize their usage) -------------------------------------------------------------- - +apps\utils\ps\ps.c: #include +drivers\dd\blue\blue.c: #include +drivers\dd\bootvid\bootvid.c: #include +drivers\storage\diskdump\diskdump.c: #include +drivers\storage\diskdump\diskdump.c: #include +hal\hal\hal.c: #include +hal\hal\hal.c: #include +lib\crt\except\unwind.c: #include +lib\crt\except\unwind.c: #include +lib\crt\except\unwind.c: #include +lib\dnsapi\dnsapi\stubs.c: #include +lib\epsapi\enum\drivers.c: #include +lib\epsapi\enum\modules.c: #include +lib\epsapi\enum\processes.c: #include +lib\lsasrv\lsaport.c: #include +lib\lsasrv\lsasrv.c: #include +lib\nt\entry_point.c: #include +lib\samlib\samlib.c: #include +lib\samsrv\samsrv.c: #include +lib\smdll\query.c: #include +lib\string\mbstowcs.c: #include +lib\string\mbstowcs.c: #include +lib\string\sscanf.c: #include +lib\string\sscanf.c: #include +lib\string\wcstombs.c: #include +lib\string\wcstombs.c: #include +lib\syssetup\install.c: #include +lib\syssetup\logfile.c: #include +lib\wdmguid\wdmguid.c: #include +regtests\shared\regtests.c: #include +services\umpnpmgr\umpnpmgr.c: #include +subsys\csr\main.c: #include +subsys\ntvdm\ntvdm.c: #include +subsys\system\autochk\autochk.c: #include +subsys\system\lsass\lsass.c: #include +subsys\system\setup\setup.c: #include +subsys\system\sm\sm.c: #include +boot\freeldr\freeldr\include\freeldr.h: #include +drivers\fs\ms\msfs.h: #include +drivers\fs\np\npfs.h: #include +drivers\fs\vfat\vfat.h: #include +drivers\net\ndis\include\ndissys.h: #include +drivers\net\tcpip\include\precomp.h: #include +drivers\video\miniport\xboxvmp\xboxvmp.h: #include +drivers\video\videoprt\videoprt.h: #include +hal\halx86\include\hal.h: #include +include\drivers\diskdump\diskdump.h: #include +lib\advapi32\advapi32.h: #include +lib\crt\precomp.h: #include +lib\dbghelp\stackframe.h: #include +lib\dbghelp\stackframe.h: #include +lib\dbghelp\stackframe.h: #include +lib\dnsapi\dnsapi\precomp.h: #include +lib\fmifs\precomp.h: #include +lib\fslib\vfatlib\vfatlib.h: #include +lib\fslib\vfatxlib\vfatxlib.h: #include +lib\gdi32\include\precomp.h: #include +lib\imagehlp\precomp.h: #include +lib\imagehlp\precomp.h: #include +lib\iphlpapi\iphlpapi_private.h: #include +lib\kernel32\k32.h: #include +lib\msafd\msafd.h: #include +lib\ntdll\inc\ntdll.h: #include +lib\opengl32\teb.h: #include +lib\psapi\precomp.h: #include +lib\rtl\rtl.h: #include +lib\secur32\precomp.h: #include +lib\setupapi\setupapi_private.h: #include +lib\smlib\precomp.h: #include +lib\user32\include\user32.h: #include +lib\userenv\precomp.h: #include +lib\ws2help\ws2help.h: #include +lib\ws2_32\include\ws2_32.h: #include +lib\wshirda\wshirda.h: #include +ntoskrnl\include\ntoskrnl.h: #include +ntoskrnl\include\internal\napi.h: #include +services\dhcp\include\rosdhcp.h: #include +services\eventlog\eventlog.h: #include +services\rpcss\rpcss.h: #include +subsys\csr\csrsrv\srv.h: #include +subsys\csrss\csrss.h: #include +subsys\csrss\include\api.h: #include +subsys\csrss\win32csr\w32csr.h: #include +subsys\smss\smss.h: #include +subsys\system\cmd\precomp.h: #include +subsys\system\services\services.h: #include +subsys\system\taskmgr\precomp.h: #include +subsys\system\usetup\usetup.h: #include +subsys\system\winlogon\winlogon.h: #include +subsys\win\basesrv\basesrv.h: #include +subsys\win\winsrv\winsrv.h: #include +subsys\win32k\w32k.h: #include +subsys\win32k\include\napi.h: #include \ No newline at end of file diff --git a/reactos/include/ndk/readme.txt b/reactos/include/ndk/readme.txt index 61085e652a8..a9bbc9da795 100644 --- a/reactos/include/ndk/readme.txt +++ b/reactos/include/ndk/readme.txt @@ -2,6 +2,20 @@ Native Development Kit README NDK 1.00 ----------------------------- +0. PREABMLE + +0.1 COPYRIGHT + +The NDK is Copyright © 2005 Alex Ionescu. + +0.2 CONTACT INFORMATION + +The author, Alex Ionescu, may be reached through the following means: + +Email: alex.ionescu@reactos.com +Mail: 2246, Duvernay. H3J 2Y3. Montreal, QC. CANADA. +Phone: (514)581-7156 + 1. LICENSE 1.1 OPEN SOURCE USAGE @@ -45,8 +59,63 @@ legal action on the part of the author. If you are unsure of have any questions about the NDK License, please contact the author for further clarification. -2. USAGE - -2.1 TODO (COPY FROM WIKI) +2. ORIGINS OF NDK MATERIAL, AND ADDING YOUR OWN + +2.1 CONTRIBUTIONS AND SOURCES + +The NDK could not exist without the various contributions made by a variety of people +and sources. The following public sources of information were lawfully used: + +- GNU NTIFS.H, Revision 43 +- W32API, Version 2.5 +- Microsoft Driver Development Kit 2003 SP1 +- Microsoft Driver Development Kit 2000 +- Microsoft Driver Development Kit NT 4 +- Microsoft Driver Development Kit WinME +- Microsoft Installable File Systems Kit 2003 SP1 +- Microsoft Windows Debugger (WinDBG) 6.5.0003.7 +- Microsoft Public Symbolic Data +- Microsoft Public Windows Binaries (strings) +- OSR Technical Articles +- Undocumented windows 2000 Secrets, a Programmer's Cookbook +- Windows NT/2000 Native API Reference +- Windows NT File System Internals +- Windows Internals I - II +- Windows Internals 4th Edition + +If the information contained in these sources was copyrighted, the information was not +copied, but simply used as a basis for developing a compatible and identical definition. +No information protected by a patent or NDA was used. All information was publically +located through the Internet or purchased or licensed for lawful use. + +Additionally, the following people contributed to the NDK: + +- Eric Kohl +- Filip Navara +- Steven Edwards + +2.2 BECOMING A CONTRIBUTOR + +To contribute information to the NDK, simply contact the author with your new structure, +definition, enumeration, or prototype. Please make sure that your addition is: + +1) Actually correct! +2) Present in Windows NT 5, 5.1, 5.2 and/or 6.0 +3) Not already accessible through another public header in the DDK, IFS, WDK and/or PSDK. +4) From a publically verifiable source. The author needs to be able to search for your + addition in a public information location (book, Internet, etc) and locate this definition. +5) Not Reversed. Reversing a type is STRONGLY discouraged and a reversed type will more then likely + not be accepted, due to the fact that functionality and naming will be entirely guessed, and things + like unions are almost impossible to determine. It can also bring up possible legal ramifications + depending on your location. However, using a tool to dump the strings inside an executable + for the purpose of locating the actual name or definition of a structure (sometimes possible due + to ASSERTs or debugging strings) is considered 'fair use' and will be a likely candidate. + +If your addition satsfies these points, then please submit it, and also include whether or not +you would like to be credited for it. + +3. USAGE + +3.1 TODO (COPY FROM WIKI) ... TODO ... (COPY FROM WIKI) diff --git a/reactos/lib/wdmguid/wdmguid.c b/reactos/lib/wdmguid/wdmguid.c index 724b87dcbe1..9374a5166f1 100644 --- a/reactos/lib/wdmguid/wdmguid.c +++ b/reactos/lib/wdmguid/wdmguid.c @@ -5,6 +5,6 @@ #include "initguid.h" #include -#include +#include /* EOF */