From: Pierre Schweitzer <pierre@reactos.org>
Date: Tue, 1 Jan 2019 09:45:48 +0000 (+0100)
Subject: [TCPIP] Check buffer before dereferencing it
X-Git-Tag: 0.4.13-dev~820
X-Git-Url: https://git.reactos.org/?p=reactos.git;a=commitdiff_plain;h=f76a097a252b52154bdc0818a897200e99e2bc29;ds=sidebyside

[TCPIP] Check buffer before dereferencing it

CID 716664
---

diff --git a/drivers/network/tcpip/tcpip/ninfo.c b/drivers/network/tcpip/tcpip/ninfo.c
index cb88a2110d3..5c0952b0336 100644
--- a/drivers/network/tcpip/tcpip/ninfo.c
+++ b/drivers/network/tcpip/tcpip/ninfo.c
@@ -312,13 +312,13 @@ TDI_STATUS InfoTdiSetRoute(PIP_INTERFACE IF, PVOID Buffer, UINT BufferSize)
     IP_ADDRESS Address, Netmask, Router;
     PIPROUTE_ENTRY Route = Buffer;
 
+    if (!Buffer || BufferSize < sizeof(IPROUTE_ENTRY))
+        return TDI_INVALID_PARAMETER;
+
     AddrInitIPv4( &Address, Route->Dest );
     AddrInitIPv4( &Netmask, Route->Mask );
     AddrInitIPv4( &Router,  Route->Gw );
 
-    if (!Buffer || BufferSize < sizeof(IPROUTE_ENTRY))
-        return TDI_INVALID_PARAMETER;
-
     if (IF == Loopback)
     {
         DbgPrint("Failing attempt to add route to loopback adapter\n");