reactos.git
3 years ago[WHOAMI]
Dmitry Chapyshev [Sat, 30 Jul 2016 16:00:10 +0000 (16:00 +0000)]
[WHOAMI]
[ARP]
[TRACERT]
- Incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true".

[FREELDR]
- Variable is assigned values twice
- The 'strlen' function was called multiple times inside the body of a loop
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0

[NTOBJSHEX]
[SLAYER]
[CMICONTROL]
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0

[SHELL32]
- There is no sense in testing the pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error
- Verifying that a pointer value is not NULL is not required. The 'if (ptr != NULL)' check can be removed
- Fix copy-paste error in CMenuFocusManager::PlaceHooks()

[SRCLIENT]
- Remove unneeded check. A part of conditional expression is always false.

[DISK]
[ATAPI]
- Variable is assigned values twice

* All bugs found by PVS-Studio

svn path=/trunk/; revision=72059

3 years ago[SOLITAIRE]
Eric Kohl [Sat, 30 Jul 2016 14:09:58 +0000 (14:09 +0000)]
[SOLITAIRE]
Add Portuguese/Brazillian translation.
Patch by Lucas Raziel.
CORE-11665 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=72058

3 years ago[INF]
Eric Kohl [Sat, 30 Jul 2016 13:39:56 +0000 (13:39 +0000)]
[INF]
Update russian translation of inf strings.
Patch by amber.
CORE-11604 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=72057

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 30 Jul 2016 12:53:09 +0000 (12:53 +0000)]
[FASTFAT]
Fix a FIXME

svn path=/trunk/; revision=72056

3 years ago[BROWSEUI]
Giannis Adamopoulos [Sat, 30 Jul 2016 12:47:39 +0000 (12:47 +0000)]
[BROWSEUI]
- Move handling of DISPID_NAVIGATECOMPLETE2 event from CAddressBand to CAddressEditBox as the todo comments say it should be.
- Remove the todo entries that are complete.
- Remove IDispatch from CAddressBand as it is not really needed. Now CAddressBand takes care only of positioning and handling the button while CAddressEditBox does all the parsing and interaction with the browser.

svn path=/trunk/; revision=72055

3 years ago[NtUser]
James Tabor [Sat, 30 Jul 2016 12:32:28 +0000 (12:32 +0000)]
[NtUser]
- Fix hang while inputting mouse message. Fix CORE-9998.

svn path=/trunk/; revision=72054

3 years ago[BROWSEUI]
Giannis Adamopoulos [Sat, 30 Jul 2016 11:53:16 +0000 (11:53 +0000)]
[BROWSEUI]
- Use the _CreateInstance postfix for all functions that instantiate a class.
- Move the the CreateInstance functions of the exported classes to browseui.h where we can select uniformly which built in classes we use.

svn path=/trunk/; revision=72053

3 years ago[USER32]
Dmitry Chapyshev [Sat, 30 Jul 2016 11:31:33 +0000 (11:31 +0000)]
[USER32]
- Add missing NULL-pointer checkes in rect functions
- Small coding-style fixes

svn path=/trunk/; revision=72052

3 years ago[PCIX]
Hermès Bélusca-Maïto [Fri, 29 Jul 2016 13:44:37 +0000 (13:44 +0000)]
[PCIX]
Fix Device_SaveCurrentSettings: do not reference BarArray too soon if the index is out of bounds (in that case it means we are handling a ROM "BAR").
CID 716153, reported by Victor Martinez Calvo.
CORE-11215 #resolve

svn path=/trunk/; revision=72050

3 years ago[XDK]
Hermès Bélusca-Maïto [Fri, 29 Jul 2016 13:17:58 +0000 (13:17 +0000)]
[XDK]
- Move the PCI_COMMON_HEADER_LAYOUT next to the structures that use it.
- Add IRP flags description comments.

svn path=/trunk/; revision=72049

3 years agoFix build.
Giannis Adamopoulos [Fri, 29 Jul 2016 12:59:16 +0000 (12:59 +0000)]
Fix build.

svn path=/trunk/; revision=72048

3 years ago[SHELL32]
Giannis Adamopoulos [Fri, 29 Jul 2016 12:56:06 +0000 (12:56 +0000)]
[SHELL32]
- Factor CFSDropTarget out of CFSFolder.
- For now their code is mixed (no code was moved), until we decide where exactly is should be kept.

svn path=/trunk/; revision=72047

3 years ago[BROWSEUI] - explorerband: get the caption string from resource file instead of hardc...
Robert Naumann [Fri, 29 Jul 2016 12:05:06 +0000 (12:05 +0000)]
[BROWSEUI] - explorerband: get the caption string from resource file instead of hardcoding it

svn path=/trunk/; revision=72046

3 years ago[SHELL32]
Giannis Adamopoulos [Fri, 29 Jul 2016 12:03:20 +0000 (12:03 +0000)]
[SHELL32]
- CDefView: Add a missing error check.
CORE-11594

svn path=/trunk/; revision=72045

3 years ago[EXT2]
Pierre Schweitzer [Fri, 29 Jul 2016 11:54:08 +0000 (11:54 +0000)]
[EXT2]
Reduce driver verbosity

svn path=/trunk/; revision=72044

3 years ago[BROWSEUI]
Giannis Adamopoulos [Fri, 29 Jul 2016 10:38:22 +0000 (10:38 +0000)]
[BROWSEUI]
- CExplorerBand: TranslateAcceleratorIO should return S_FALSE when it doesn't process the message in order to let other components process it.
CORE-11709

svn path=/trunk/; revision=72043

3 years ago[EXT2]
Pierre Schweitzer [Fri, 29 Jul 2016 10:29:16 +0000 (10:29 +0000)]
[EXT2]
Upgrade the driver to release 0.68.

CORE-11714

svn path=/trunk/; revision=72042

3 years ago[SHELLL32]
Giannis Adamopoulos [Fri, 29 Jul 2016 06:21:11 +0000 (06:21 +0000)]
[SHELLL32]
- Split GenericExtractIcon_CreateInstance into CGuidItemExtractIcon_CreateInstance, CFSExtractIcon_CreateInstance and CDrivesExtractIcon_CreateInstance.

svn path=/trunk/; revision=72041

3 years ago[INF]
Sylvain Petreolle [Thu, 28 Jul 2016 17:12:31 +0000 (17:12 +0000)]
[INF]
Add data for generic container devices.

svn path=/trunk/; revision=72036

3 years ago[SHELL32_APITEST]
Thomas Faber [Thu, 28 Jul 2016 15:25:35 +0000 (15:25 +0000)]
[SHELL32_APITEST]
- Add a test for CShellLink::GetDescription/SetDescription
CORE-5272

svn path=/trunk/; revision=72035

3 years ago[SHELL32] apply similar fixes to SetWorkingDirectory, SetArguments, SetIconLocation...
Christoph von Wittich [Thu, 28 Jul 2016 15:24:44 +0000 (15:24 +0000)]
[SHELL32] apply similar fixes to SetWorkingDirectory, SetArguments, SetIconLocation and SetRelativePath

svn path=/trunk/; revision=72034

3 years ago[SHELL32]check for NULL pointer in CShellLink::SetDescription. patch by Joachim Henze...
Christoph von Wittich [Thu, 28 Jul 2016 15:12:23 +0000 (15:12 +0000)]
[SHELL32]check for NULL pointer in CShellLink::SetDescription. patch by Joachim Henze. fixes Opera 12 installer CORE-5272

svn path=/trunk/; revision=72033

3 years ago[HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655
Robert Naumann [Thu, 28 Jul 2016 13:27:33 +0000 (13:27 +0000)]
[HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655

svn path=/trunk/; revision=72032

3 years ago[DOC]
Pierre Schweitzer [Thu, 28 Jul 2016 07:39:37 +0000 (07:39 +0000)]
[DOC]
Mark BTRFS as synced

svn path=/trunk/; revision=72031

3 years ago[CONSRV]
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 23:30:53 +0000 (23:30 +0000)]
[CONSRV]
- Do not hardcode the values of some flags used with GetKeyState.
- Rework a bit the 'OnScroll' function.
- Implement mouse scrolling the console.
CORE-9900 #resolve
CORE-8394
- In mouse selection mode, allow the user to enlarge the current selection area by pressing the SHIFT key together with clicking on some point.

svn path=/trunk/; revision=72030

3 years ago[SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need...
Amine Khaldi [Wed, 27 Jul 2016 21:38:56 +0000 (21:38 +0000)]
[SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need to mention it in every single build.

svn path=/trunk/; revision=72028

3 years ago[SHELL32]
Giannis Adamopoulos [Wed, 27 Jul 2016 20:51:36 +0000 (20:51 +0000)]
[SHELL32]
- Query the drop effect from the key state. After latest wine sync we correctly get all possible effects instead of the effect of the last DragOver event.
CORE-11681

svn path=/trunk/; revision=72026

3 years ago[BTRFS]
Pierre Schweitzer [Wed, 27 Jul 2016 19:32:05 +0000 (19:32 +0000)]
[BTRFS]
Import three fixes from my local GitHub repository:
- Don't attempt to remove Vcb from list twice on shutdown
- Properly add CCB to root_file
- Init cache for root_file so that cache uninit on shutdown isn't problematic

This fixes BTRFS in ReactOS.
These fixes have already been submitted upstream (https://github.com/maharmstone/btrfs/pull/23).

CORE-11674

svn path=/trunk/; revision=72024

3 years ago[BTRFS]
Pierre Schweitzer [Wed, 27 Jul 2016 19:24:26 +0000 (19:24 +0000)]
[BTRFS]
Sync btrfs to 0.5.
This breaks BTRFS in ReactOS.

CORE-11674

svn path=/trunk/; revision=72023

3 years ago[SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local difference...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:17:35 +0000 (19:17 +0000)]
[SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local differences wrt. the synced Wine code. Per Amine request.
ROSTESTS_234

svn path=/trunk/; revision=72022

3 years ago[SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:12:35 +0000 (19:12 +0000)]
[SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out unexpectedly. We don't lose functionality wrt. what we had before r72008 (or with what Wine currently has).
CORE-11689

svn path=/trunk/; revision=72021

3 years ago[SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:05:52 +0000 (19:05 +0000)]
[SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable" test path.
ROSTESTS-234

svn path=/trunk/; revision=72020

3 years ago[KMTESTS]
Pierre Schweitzer [Wed, 27 Jul 2016 16:40:30 +0000 (16:40 +0000)]
[KMTESTS]
Add missing dependency

svn path=/trunk/; revision=72019

3 years ago[NTOS:PO]
Thomas Faber [Wed, 27 Jul 2016 11:15:52 +0000 (11:15 +0000)]
[NTOS:PO]
- Send power IRPs to the top of the device stack instead of the PDO
CORE-10110 #resolve

svn path=/trunk/; revision=72017

3 years ago[SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 00:48:41 +0000 (00:48 +0000)]
[SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging 1.9.15.
(Add also the patch "Add patch to support IDF_CHECKFIRST in SetupPromptForDisk." by DarkPlayer - 541cc8d08661980dfe80fe2bb9dd27c91879e09f)

svn path=/trunk/; revision=72009

3 years ago[SETUPAPI]
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 00:10:14 +0000 (00:10 +0000)]
[SETUPAPI]
- Transform the cached OsVersionInfo structure into a OSVERSIONINFOEXW that is then reused in SetupDiGetActualSectionToInstallExW.
- Remove few unused hardcoded strings.
- Add two TRACEs in SetupDiGetActualSectionToInstallExW to debug diverse INF file installation problems.
- parser.c: enclose the contents of the for-loop inside braces.
- Implement pSetupSetGlobalFlags and pSetupModifyGlobalFlags, see https://msdn.microsoft.com/en-us/library/bb432397(v=vs.85).aspx
- Popup an error message box in InstallHinfSectionW if an error happened and if interactive setup is allowed (through the global setup flags).

svn path=/trunk/; revision=72008

3 years ago[NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously...
Hermès Bélusca-Maïto [Tue, 26 Jul 2016 19:57:40 +0000 (19:57 +0000)]
[NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously initialized.
CORE-10182 #resolve

svn path=/trunk/; revision=72007

3 years ago[INF]: Use the correct icon for audio controller devices in the device manager. By...
Hermès Bélusca-Maïto [Tue, 26 Jul 2016 19:09:18 +0000 (19:09 +0000)]
[INF]: Use the correct icon for audio controller devices in the device manager. By Jared Smudde.
CORE-11679 #resolve #comment Committed, thanks!

svn path=/trunk/; revision=72006

3 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 26 Jul 2016 15:09:04 +0000 (15:09 +0000)]
[BROWSEUI]
- CExplorerBand: Implement showing the context menu on right click.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72004

3 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 26 Jul 2016 14:31:38 +0000 (14:31 +0000)]
[BROWSEUI]
- CExplorerBand: Expand the tree view to the current folder when a new folder is browser (either with the addressbar or by double clicking a folder).
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72003

3 years ago[NTOSKRNL_VISTA]
Pierre Schweitzer [Mon, 25 Jul 2016 20:45:48 +0000 (20:45 +0000)]
[NTOSKRNL_VISTA]
Implement KeQueryActiveProcessorCount().

CORE-11674

svn path=/trunk/; revision=72001

3 years ago[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification...
Hermès Bélusca-Maïto [Mon, 25 Jul 2016 20:24:30 +0000 (20:24 +0000)]
[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification by myself):
◾ Don't return TRUE when CB_SETITEMDATA fails.
◾ Avoid pScheme NULL dereference if allocation fails. CID 1223154
◾ Avoid overflowing the destiny buffer by using StringCchCopy() CID 510953
and:
1) Make it more readable by returning as soon as possible when an error happens.
2) Make it more readable by reducing the nested ifs-checks.
3) Remove the added string in the combobox if the sound scheme buffer mem allocation fails (pt.3 modified).
CORE-11603 #resolve #comment Thanks!

svn path=/trunk/; revision=72000

3 years ago[TOOLS]
Thomas Faber [Mon, 25 Jul 2016 19:28:40 +0000 (19:28 +0000)]
[TOOLS]
- Fix MSVC 2013+ build. Patch by Victor Matovykh.
CORE-11575 #resolve

svn path=/trunk/; revision=71998

3 years ago[SHELL32]
Thomas Faber [Mon, 25 Jul 2016 19:25:46 +0000 (19:25 +0000)]
[SHELL32]
- Add missing dependency

svn path=/trunk/; revision=71997

3 years ago[ADVAPI32] silence debug spam
Christoph von Wittich [Mon, 25 Jul 2016 11:07:44 +0000 (11:07 +0000)]
[ADVAPI32] silence debug spam

svn path=/trunk/; revision=71995

3 years ago[WIN32K:NTUSER]
Thomas Faber [Mon, 25 Jul 2016 10:45:30 +0000 (10:45 +0000)]
[WIN32K:NTUSER]
- Fix UserDrawCaptionBar debug spam

svn path=/trunk/; revision=71994

3 years ago[NTOS:CC]
Thomas Faber [Mon, 25 Jul 2016 08:48:50 +0000 (08:48 +0000)]
[NTOS:CC]
- Unconditionally acquire the VACB lock during map/pin/unpin operations and release it appropriately
CORE-11555 #resolve
CORE-11654 CORE-11504 CORE-11328 #comment This might be fixed with r71993. Could you retry please?

svn path=/trunk/; revision=71993

3 years ago[NTVDM]
Aleksandar Andrejevic [Sun, 24 Jul 2016 18:25:50 +0000 (18:25 +0000)]
[NTVDM]
Implement the VGA AC Color Select register.
Implement INT 0x10, AH = 0x10, subfunction AL = 0x13.

svn path=/trunk/; revision=71992

3 years ago[NTOS:CC]
Thomas Faber [Sun, 24 Jul 2016 17:10:30 +0000 (17:10 +0000)]
[NTOS:CC]
- Centralize VACB locking/unlocking into inline functions for easier instrumentation

svn path=/trunk/; revision=71991

3 years ago[NTVDM]
Aleksandar Andrejevic [Sun, 24 Jul 2016 15:45:50 +0000 (15:45 +0000)]
[NTVDM]
Always reset the AC latch before writing to the AC index register.
CORE-11669 #resolve #comment Should be fixed in revision r71990.

svn path=/trunk/; revision=71990

3 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 24 Jul 2016 15:24:50 +0000 (15:24 +0000)]
[EVENTVWR]
- Use helper functions for doing the filtering on the events (idea by Mark Jansen).
- Fix the states of menu items, depending on which event log/item (log file/filter; event item...) is currently selected.
- Correctly empty the event items list & cache whenever an event log/filter is closed (and avoid a crash when all logs/filters are closed and someone attempts to open an event item), during concurrent accesses. I use a reference count and AddRef/Release helpers.
- Get rid of the annoying log loading popup, and use instead the loading message displayed in the events listview as well as a progress-bar in the status bar.
CORE-11637

svn path=/trunk/; revision=71989

3 years ago[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521
Amine Khaldi [Sat, 23 Jul 2016 21:33:40 +0000 (21:33 +0000)]
[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521

svn path=/trunk/; revision=71986

3 years ago[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
Mark Jansen [Sat, 23 Jul 2016 20:35:11 +0000 (20:35 +0000)]
[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
As suggested by Thomas :)

svn path=/trunk/; revision=71985

3 years ago[MPR]
Pierre Schweitzer [Sat, 23 Jul 2016 19:52:23 +0000 (19:52 +0000)]
[MPR]
Provide ReactOS specific implementation for WNetGetConnection(), we cannot use Wine's due to Wine specific MountMgr calls.

svn path=/trunk/; revision=71984

3 years ago[SHELL32] close hKey in error case
Christoph von Wittich [Sat, 23 Jul 2016 19:39:16 +0000 (19:39 +0000)]
[SHELL32] close hKey in error case

svn path=/trunk/; revision=71983

3 years ago[NTOS:IO]
Thomas Faber [Sat, 23 Jul 2016 18:18:11 +0000 (18:18 +0000)]
[NTOS:IO]
- Avoid infinite loop in IopMountVolume. Brought to you by Vadim Galyant.
CORE-11663 #resolve

svn path=/trunk/; revision=71982

3 years ago[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE...
Mark Jansen [Sat, 23 Jul 2016 13:15:19 +0000 (13:15 +0000)]
[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE-10439

svn path=/trunk/; revision=71981

3 years ago[SHELL32] cache entries of "New" menu
Christoph von Wittich [Sat, 23 Jul 2016 12:31:30 +0000 (12:31 +0000)]
[SHELL32] cache entries of "New" menu
CORE-10439

svn path=/trunk/; revision=71980

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 23 Jul 2016 08:42:38 +0000 (08:42 +0000)]
[SHELL32]
- CDefView: Add the skeleton check that should be used to implement moving items in the CDefView. Nothing more is implemented because GetKeyState is completely unreliable.

svn path=/trunk/; revision=71979

3 years ago[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
Hermès Bélusca-Maïto [Fri, 22 Jul 2016 14:15:09 +0000 (14:15 +0000)]
[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
CORE-7645

svn path=/trunk/; revision=71978

3 years ago[ADVPACK]: Add file version information resource.
Hermès Bélusca-Maïto [Fri, 22 Jul 2016 13:19:25 +0000 (13:19 +0000)]
[ADVPACK]: Add file version information resource.
CORE-7645 #comment Please retest the installation of Visual Basic 6 runtime with revision >= 71977.

svn path=/trunk/; revision=71977

3 years ago[USETUP]
Eric Kohl [Thu, 21 Jul 2016 20:53:43 +0000 (20:53 +0000)]
[USETUP]
Keyboard Modifier LEDs not working in usetup.
Patch by Carlo Bramini.
CORE-3368 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71976

3 years ago[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE...
Mark Jansen [Thu, 21 Jul 2016 17:29:41 +0000 (17:29 +0000)]
[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE-11606 #resolve #comment Thanks!

svn path=/trunk/; revision=71975

3 years ago[SERIAL]
Thomas Faber [Wed, 20 Jul 2016 12:50:58 +0000 (12:50 +0000)]
[SERIAL]
- Properly stub SerialPower
CORE-11648

svn path=/trunk/; revision=71974

3 years ago[PARPORT]
Thomas Faber [Wed, 20 Jul 2016 12:21:11 +0000 (12:21 +0000)]
[PARPORT]
- Properly stub FdoPower and PdoPower
CORE-11648

svn path=/trunk/; revision=71973

3 years ago[PCIIDEX]
Thomas Faber [Wed, 20 Jul 2016 11:49:22 +0000 (11:49 +0000)]
[PCIIDEX]
- Add a stub for PciIdeXPowerDispatch
CORE-11648

svn path=/trunk/; revision=71972

3 years ago[SERVICES]
Eric Kohl [Tue, 19 Jul 2016 21:30:45 +0000 (21:30 +0000)]
[SERVICES]
Service logon page:
- Handle the interactive service type flag.
- Change the service configuration in the apply function.

svn path=/trunk/; revision=71971

3 years ago[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed...
Amine Khaldi [Tue, 19 Jul 2016 18:12:15 +0000 (18:12 +0000)]
[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed CORE-11511.

svn path=/trunk/; revision=71970

3 years ago[NTOS:KE]
Thomas Faber [Tue, 19 Jul 2016 12:51:49 +0000 (12:51 +0000)]
[NTOS:KE]
- Load LDT on context switch if required.
CORE-11511 #resolve

svn path=/trunk/; revision=71967

3 years ago[REGEDIT]
Hermès Bélusca-Maïto [Mon, 18 Jul 2016 22:27:17 +0000 (22:27 +0000)]
[REGEDIT]
- Minor whitespace fixes in main.c
- Use a correct info msgbox title when showing regedit command-line usage. Something to think about: translate the cmdline usage! :)

svn path=/trunk/; revision=71966

3 years ago[SERVMAN]
Eric Kohl [Mon, 18 Jul 2016 21:49:19 +0000 (21:49 +0000)]
[SERVMAN]
Service logon property page:
- Fix initialization and display bugs.
- Start work on the 'Apply' function. It doe not apply changes yet.
- Add password check messages.

svn path=/trunk/; revision=71965

3 years ago[BOOTDATA]: Disable automatic debugger startup on application crash. This allows...
Hermès Bélusca-Maïto [Mon, 18 Jul 2016 19:25:53 +0000 (19:25 +0000)]
[BOOTDATA]: Disable automatic debugger startup on application crash. This allows getting back the error popup as we used to have, and also warn the user there was indeed a problem, instead of silently start the default debugger (that I've set to an unexistant "drwtsn.exe") and fail silently, since that default debugger doesn't exist.
CORE-11508

svn path=/trunk/; revision=71964

3 years ago[USER32_WINETEST] Sync with Wine Staging 1.9.14.
Amine Khaldi [Mon, 18 Jul 2016 15:48:27 +0000 (15:48 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.14.

svn path=/trunk/; revision=71963

3 years ago[USER32] Add missing lprc check in SetRect().
Amine Khaldi [Mon, 18 Jul 2016 15:46:38 +0000 (15:46 +0000)]
[USER32] Add missing lprc check in SetRect().

svn path=/trunk/; revision=71962

3 years ago[WS2_32_WINETEST] Sync with Wine Staging 1.9.14. Made possible thanks to Peter Hater...
Amine Khaldi [Mon, 18 Jul 2016 10:44:58 +0000 (10:44 +0000)]
[WS2_32_WINETEST] Sync with Wine Staging 1.9.14. Made possible thanks to Peter Hater's changes. CORE-11368 ROSTESTS-233

svn path=/trunk/; revision=71961

3 years ago[SHELL32] Add AVI file 151. By Jared Smudde. CORE-11638
Amine Khaldi [Mon, 18 Jul 2016 10:27:56 +0000 (10:27 +0000)]
[SHELL32] Add AVI file 151. By Jared Smudde. CORE-11638

svn path=/trunk/; revision=71960

3 years ago[User32]
James Tabor [Mon, 18 Jul 2016 02:35:46 +0000 (02:35 +0000)]
[User32]
- Fix log out shutdown dialog window input. See CORE-11633 #resolve

svn path=/trunk/; revision=71959

3 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 17 Jul 2016 23:06:03 +0000 (23:06 +0000)]
[EVENTVWR]
Commit "Part 1" of my Improvements for the Event Log Viewer. See CORE-11637 description for more details (too long to stay there).

svn path=/trunk/; revision=71958

3 years ago[EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde...
Mark Jansen [Sat, 16 Jul 2016 17:49:27 +0000 (17:49 +0000)]
[EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde. CORE-11146 #resolve #comment Thanks!

svn path=/trunk/; revision=71956

3 years agoOoops! These were not meant to be committed!
Eric Kohl [Sat, 16 Jul 2016 17:41:44 +0000 (17:41 +0000)]
Ooops! These were not meant to be committed!

svn path=/trunk/; revision=71955

3 years ago[SERVICES]
Eric Kohl [Sat, 16 Jul 2016 17:39:37 +0000 (17:39 +0000)]
[SERVICES]
Check for NULL pointers before derreferecing them in ScmIsSameServiceAccount().
Patch by Victor Martinez Calvo.
CORE-11599 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71954

3 years ago[ADVAPI32]
Eric Kohl [Sat, 16 Jul 2016 16:18:17 +0000 (16:18 +0000)]
[ADVAPI32]
Remove unneeded NULL checks at CreateServiceA/W and ChangeServiceConfigW/A().
Patch by Victor Martinez Calvo.
CORE-11610 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71953

3 years ago[LSASRV]
Eric Kohl [Sat, 16 Jul 2016 14:57:33 +0000 (14:57 +0000)]
[LSASRV]
Fix cleanup in LsarRetrievePrivateData().
Modified patch by Victor Martinez Calvo.
CORE-11611 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71952

3 years ago[WS2_32]
Thomas Faber [Sat, 16 Jul 2016 07:49:30 +0000 (07:49 +0000)]
[WS2_32]
- Fix a few ws2_32:getaddrinfo test failures. Based on a patch by Peter Hater.
CORE-11368

svn path=/trunk/; revision=71951

3 years ago[KERNEL32]
Thomas Faber [Sat, 16 Jul 2016 07:08:21 +0000 (07:08 +0000)]
[KERNEL32]
- Fix GetComputerNameEx behavior with regard to NULL/non-NULL buffers and size calculation
CORE-11368

svn path=/trunk/; revision=71950

3 years ago[EXPLORER] HACK: ignore unimplemented SetBandSiteInfo. Patch by Wim Hueskes. CORE...
Mark Jansen [Fri, 15 Jul 2016 23:33:53 +0000 (23:33 +0000)]
[EXPLORER] HACK: ignore unimplemented SetBandSiteInfo. Patch by Wim Hueskes. CORE-9809 #resolve #comment Thanks!

svn path=/trunk/; revision=71949

3 years ago[PSDK]: Add two missing flags concerning custom-drawn controls.
Hermès Bélusca-Maïto [Fri, 15 Jul 2016 21:12:52 +0000 (21:12 +0000)]
[PSDK]: Add two missing flags concerning custom-drawn controls.

svn path=/trunk/; revision=71948

3 years ago[KERNEL32] Check the return buffer for NULL before initializing the unicode string...
Amine Khaldi [Fri, 15 Jul 2016 20:18:20 +0000 (20:18 +0000)]
[KERNEL32] Check the return buffer for NULL before initializing the unicode string buffer with it. By Peter Hater. CORE-11368

svn path=/trunk/; revision=71947

3 years ago[NtGdi]
James Tabor [Fri, 15 Jul 2016 20:13:33 +0000 (20:13 +0000)]
[NtGdi]
- Make SetBkColor work the same as client side.

svn path=/trunk/; revision=71946

3 years ago[EVENTVWR]: Fix transparency problems for some icons.
Hermès Bélusca-Maïto [Thu, 14 Jul 2016 18:58:05 +0000 (18:58 +0000)]
[EVENTVWR]: Fix transparency problems for some icons.

svn path=/trunk/; revision=71944

3 years ago[BOOTLIB]
Pierre Schweitzer [Thu, 14 Jul 2016 13:04:08 +0000 (13:04 +0000)]
[BOOTLIB]
Fix checksum computation

CID #1363451

svn path=/trunk/; revision=71941

3 years ago[BOOTLIB]
Pierre Schweitzer [Thu, 14 Jul 2016 12:58:29 +0000 (12:58 +0000)]
[BOOTLIB]
Fix out of bounds read.

CID #1363549

svn path=/trunk/; revision=71940

3 years ago[BOOTMGR]
Pierre Schweitzer [Thu, 14 Jul 2016 12:46:31 +0000 (12:46 +0000)]
[BOOTMGR]
Don't use uninit var.

CID #1363650

svn path=/trunk/; revision=71939

3 years ago[BOOTLIB]
Pierre Schweitzer [Thu, 14 Jul 2016 12:40:17 +0000 (12:40 +0000)]
[BOOTLIB]
Don't deal with uninit ptr.

CID #1363698

svn path=/trunk/; revision=71938

3 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 14 Jul 2016 12:21:57 +0000 (12:21 +0000)]
[NTOSKRNL]
Assert that the allocated buffers are not leaked.

CID #1248416

svn path=/trunk/; revision=71937

3 years ago[MUP]
Pierre Schweitzer [Thu, 14 Jul 2016 12:07:05 +0000 (12:07 +0000)]
[MUP]
Don't deal with uninit ptr.

CID #1322222

svn path=/trunk/; revision=71936

4 years ago[ACPPAGE] Remove unused var. CID 1363705
Mark Jansen [Wed, 13 Jul 2016 18:44:51 +0000 (18:44 +0000)]
[ACPPAGE] Remove unused var. CID 1363705

svn path=/trunk/; revision=71934

4 years ago[RAPPS_NEW] Use the actual buffer size instead of hardcoding a random number. CID...
Mark Jansen [Wed, 13 Jul 2016 18:33:42 +0000 (18:33 +0000)]
[RAPPS_NEW] Use the actual buffer size instead of hardcoding a random number. CID 1363551

svn path=/trunk/; revision=71933

4 years ago[ACLAYER] Use the return of StringCbPrintfW instead of ignoring it. CID 1363460-63...
Mark Jansen [Wed, 13 Jul 2016 18:10:37 +0000 (18:10 +0000)]
[ACLAYER] Use the return of StringCbPrintfW instead of ignoring it. CID 1363460-63, 65-70, 76, 78, 85, 88, 90

svn path=/trunk/; revision=71932

4 years ago[APPHELP] Dereference after null check (default_dir). CID 1363509
Mark Jansen [Wed, 13 Jul 2016 18:02:16 +0000 (18:02 +0000)]
[APPHELP] Dereference after null check (default_dir). CID 1363509

svn path=/trunk/; revision=71931