4 months ago[MOUNTMGR] Properly look for device and break when found
Serge Gautherie [Sat, 5 Oct 2019 20:44:25 +0000 (22:44 +0200)]
[MOUNTMGR] Properly look for device and break when found

Also use same pattern in MountMgrCreatePointWorker().

Addendum to a7f97cc70f62f6805e71b28eba51f52b942d22b4.

4 months ago[MOUNTMGR] QueryPointsFromMemory(): Do not leak DeviceName.Buffer
Serge Gautherie [Sat, 5 Oct 2019 23:01:31 +0000 (01:01 +0200)]
[MOUNTMGR] QueryPointsFromMemory(): Do not leak DeviceName.Buffer

Follow-up to 7601011f4ed578ae4a15a55298ebbe96fe3a1129.

4 months ago[FREELDR] Retrieve the correct ACPI RSDP table address. (#1951) 1951/head
Mark Harmstone [Wed, 2 Oct 2019 11:43:30 +0000 (12:43 +0100)]
[FREELDR] Retrieve the correct ACPI RSDP table address. (#1951)

Use either the RSDT (ACPI 1.0) or the XSDT (ACPI >1.0).
This fixes ACPI issues with Vista on VirtualBox.

4 months ago[FREELDR] Load the Firmware Errata file specified in the registry. (#1951)
Mark Harmstone [Mon, 9 Sep 2019 19:09:57 +0000 (20:09 +0100)]
[FREELDR] Load the Firmware Errata file specified in the registry. (#1951)

On Windows <= 2003 (and current ReactOS), this is the "InfName" value
in the "HKEY_LOCAL_MACHINE\CurrentControlSet\Control\BiosInfo\" key.
(The default file name found there is 'biosinfo.inf'.)

On Vista+, this is the "InfName" value in the
"HKEY_LOCAL_MACHINE\CurrentControlSet\Control\Errata\" key.
(The default file name found there is 'errata.inf'.)

For 1st-stage setup, the file is specified in the "InfName" value of
the "BiosInfo" section in the TXTSETUP.SIF file.

Co-authored-by: Hermès Bélusca-Maïto <>
4 months ago[FREELDR] Insert DLLs into load order before what references them. (#1951)
Mark Harmstone [Thu, 3 Oct 2019 18:54:49 +0000 (19:54 +0100)]
[FREELDR] Insert DLLs into load order before what references them. (#1951)

4 months ago[FREELDR] Set LDRP_DRIVER_DEPENDENT_DLL where necessary. (#1951)
Mark Harmstone [Thu, 3 Oct 2019 18:36:43 +0000 (19:36 +0100)]
[FREELDR] Set LDRP_DRIVER_DEPENDENT_DLL where necessary. (#1951)

4 months ago[FREELDR] Fix bug in Btrfs filename lookups. (#1951)
Mark Harmstone [Mon, 9 Sep 2019 18:39:58 +0000 (19:39 +0100)]
[FREELDR] Fix bug in Btrfs filename lookups. (#1951)

4 months ago[MOUNTMGR] Properly look for symlink and break when found
Pierre Schweitzer [Sat, 5 Oct 2019 19:29:38 +0000 (21:29 +0200)]
[MOUNTMGR] Properly look for symlink and break when found

This fixes a bug where MountMgr was returning first found entry
on query even when not matching the requested device.

4 months ago[HALXBOX] Implement shutdown, reboot, and power cycle routines
Stanislav Motylkov [Fri, 4 Oct 2019 19:04:51 +0000 (22:04 +0300)]
[HALXBOX] Implement shutdown, reboot, and power cycle routines


4 months ago[HALXBOX][CMAKE] Merge generic module with xbox module for modification
Stanislav Motylkov [Fri, 4 Oct 2019 17:42:16 +0000 (20:42 +0300)]
[HALXBOX][CMAKE] Merge generic module with xbox module for modification

4 months agoShell Find Improvements to make Search Item general and Show Sub-directories (#1927)
Doug Lyons [Sat, 5 Oct 2019 14:32:49 +0000 (09:32 -0500)]
Shell Find Improvements to make Search Item general and Show Sub-directories (#1927)

* Shell Find Improvement to make Search Item general by adding asterisks before and after before search and show sub-directories in find listing. CORE-16152

4 months ago[D3DCOMPILER_43] Addendum to last commit CORE-14955 & CORE-15652
Joachim Henze [Thu, 3 Oct 2019 19:16:39 +0000 (21:16 +0200)]
[D3DCOMPILER_43] Addendum to last commit CORE-14955 & CORE-15652

GCC Linux build had no issues with the last commit but
MSVC x86 & x64 v18.0.31101.0 choked on it with
error C4133: 'function' : incompatible types - from 'D3D_PRIMITIVE *' to 'DWORD *'
and similar.

I could not retest with that exact version of MSVC, but the mentioned problems
vanished for me when compiling locally with MSVC 16.0.40219.1 x86.
Fingers crossed, that this makes the builders happy again!

4 months ago[D3D8][D3D9][DDRAW][D3DCOMPILER_43][WINED3D] Revert to Wine Staging 3.3
Joachim Henze [Thu, 3 Oct 2019 16:38:29 +0000 (18:38 +0200)]
[D3D8][D3D9][DDRAW][D3DCOMPILER_43][WINED3D] Revert to Wine Staging 3.3

Avoid regressions CORE-14955 "Ddraw fullscreen crashes" and CORE-15652

This brings us back to before guilty commit 0.4.10-dev-55-g

and therefore downgrades
to WineStaging 3.3.
Also downgrades related header sdk/include/reactos/wine/wined3d.h
and for the first time also media/doc/README.WINE

Same versions of these dlls we had in every ros rls since 0.4.10rls.
Amine Khaldi agreed to perform this revert also for master now.

Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
 DxDiag crashed when switching to fullscreen (CORE-14955),
 Diablo II crashed immediately (CORE-15652),
 Monster-Truck-Madness 2 demo crashed after main menu

Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.

squashed commit of 0.4.13-RC-2-g
and 0.4.13-RC-3-g

4 months ago[MEDIA][FONTS] Replace 'Verdana' fonts CORE-16400 (#1948)
Katayama Hirofumi MZ [Thu, 3 Oct 2019 13:36:05 +0000 (22:36 +0900)]
[MEDIA][FONTS] Replace 'Verdana' fonts CORE-16400 (#1948)

- Replace "Verdana", "Verdana Bold", "Verdana Bold Italic" and "Verdana Italic" fonts by duplicating "DejaVu Sans" fonts and renaming them.
- Replace LICENSE file.

I made these font files by using FontForge. Their family name is "Verdana". Their display names are "Verdana", "Verdana Bold", "Verdana Bold Italic" and "Verdana Italic". Their font filenames are verdana.ttf, verdanab.ttf, verdanaz.ttf and verdanai.ttf. The Underline Positions are hacked by adding an integer value for workaround of FontForge's bug.

4 months ago[FREELDR] Stop asking people to report bugs on
Pierre Schweitzer [Thu, 3 Oct 2019 00:54:27 +0000 (02:54 +0200)]
[FREELDR] Stop asking people to report bugs on

That should be merged to 0.4.13

4 months agoUpdated release version on readme
Federico Pellegatta [Wed, 2 Oct 2019 09:01:07 +0000 (11:01 +0200)]
Updated release version on readme

4 months ago[KERNEL32] Fix FIXME by calling appropriate function in GetNativeSystemInfo()
Pierre Schweitzer [Wed, 2 Oct 2019 08:52:00 +0000 (10:52 +0200)]
[KERNEL32] Fix FIXME by calling appropriate function in GetNativeSystemInfo()

4 months ago[SDK] Define RtlGetNativeSystemInformation()
Pierre Schweitzer [Wed, 2 Oct 2019 08:50:59 +0000 (10:50 +0200)]
[SDK] Define RtlGetNativeSystemInformation()

4 months ago[NTDLL_WINETESTS] Fix the test so that it works on W2K3
Pierre Schweitzer [Tue, 1 Oct 2019 08:10:52 +0000 (10:10 +0200)]
[NTDLL_WINETESTS] Fix the test so that it works on W2K3

It's an addendum to ad547c9

4 months ago[SDK] Raise KERNEL_VERSION_PATCH_LEVEL to 14 in the version.cmake 0.4.14-dev
Joachim Henze [Mon, 30 Sep 2019 16:15:39 +0000 (18:15 +0200)]
[SDK] Raise KERNEL_VERSION_PATCH_LEVEL to 14 in the version.cmake

4 months ago[NTOS:MM] i386: Fix '_MI_NO_EXECUTE' typo
Serge Gautherie [Mon, 23 Sep 2019 20:20:27 +0000 (22:20 +0200)]
[NTOS:MM] i386: Fix '_MI_NO_EXECUTE' typo

Addendum to 65dbfc286818e18095b7cc0c85f63cde6b3e629d.

4 months ago[SDK] Make our MEMORY_SECTION_NAME definitions consistent.
Pierre Schweitzer [Sun, 29 Sep 2019 12:18:11 +0000 (14:18 +0200)]
[SDK] Make our MEMORY_SECTION_NAME definitions consistent.
I choose the definition which is also used by Wine & Chromium.


4 months ago[NTOSKRNL] Simplify buffer definition in MiQueryMemorySectionName().
Pierre Schweitzer [Sun, 29 Sep 2019 12:16:44 +0000 (14:16 +0200)]
[NTOSKRNL] Simplify buffer definition in MiQueryMemorySectionName().
Also take into account the UNICODE_STRING structure while computing whole size
This is based on Thomas' patch.


4 months ago[NTDLL_WINETESTS] Section name query test is broken on W2K3 and will lead to a crash
Pierre Schweitzer [Sun, 29 Sep 2019 12:13:55 +0000 (14:13 +0200)]
[NTDLL_WINETESTS] Section name query test is broken on W2K3 and will lead to a crash
Comment out the test for now and add a more "appropriate" test code for now

4 months ago[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403
Thomas Faber [Sun, 8 Sep 2019 13:40:46 +0000 (15:40 +0200)]
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403

Fixes one of many crashes in shell32_winetest:shlfolder.

4 months ago[USBPORT] USBPORT_InvalidateEndpointHandler(): Properly enumerate endpoints
Serge Gautherie [Tue, 24 Sep 2019 05:15:06 +0000 (07:15 +0200)]
[USBPORT] USBPORT_InvalidateEndpointHandler(): Properly enumerate endpoints

4 months ago[FREELDR] Optimize and refactor the FAT driver.
Victor Perevertkin [Thu, 18 Jul 2019 23:57:11 +0000 (02:57 +0300)]
[FREELDR] Optimize and refactor the FAT driver.
Do not read the whole cluster chain for file on opening.
This removes restriction for opening files which span
within a large amount of clusters (>65k). That happened because
FrLdrTempAlloc cannot allocate more than about 256 KiB of memory.

Adjacent clusters for file are now read using one disk driver call.

4 months ago[FREELDR] Add FAT caching to FAT filesystem driver.
Victor Perevertkin [Tue, 9 Jul 2019 14:22:28 +0000 (17:22 +0300)]
[FREELDR] Add FAT caching to FAT filesystem driver.
This significantly increases the reading speed

4 months ago[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385
Thomas Faber [Sun, 22 Sep 2019 14:48:04 +0000 (16:48 +0200)]
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385

4 months ago[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385
Thomas Faber [Sun, 22 Sep 2019 14:36:01 +0000 (16:36 +0200)]
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385

4 months ago[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385
Thomas Faber [Sun, 22 Sep 2019 14:38:06 +0000 (16:38 +0200)]
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385

Addendum to c2b476bd776.

4 months ago[HAL] Update the PCI hardware IDs database.
Hermès Bélusca-Maïto [Sat, 28 Sep 2019 16:52:59 +0000 (18:52 +0200)]
[HAL] Update the PCI hardware IDs database.

Extracted from the pci.ids database at from 2019-09-28 03:15:02 .
Maintained by Albert Pool, Martin Mares, Michal Vaner, and other volunteers from the PCI ID Project.

4 months ago[HAL] Fix more bugs in HalpDebugPciDumpBus (#1939)
Stanislav Motylkov [Sat, 28 Sep 2019 16:30:56 +0000 (19:30 +0300)]
[HAL] Fix more bugs in HalpDebugPciDumpBus (#1939)

- Don't match device id outside current vendor id list.
- Don't match subsystem id outside current device id list.
- Refactor some magic constants.

Addendum to 894635b.

4 months ago[HDAUDBUS] Build a device instance ID from Codec & node number. CORE-13702 1941/head
Thomas Faber [Fri, 27 Sep 2019 11:13:49 +0000 (13:13 +0200)]
[HDAUDBUS] Build a device instance ID from Codec & node number. CORE-13702

4 months ago[NTOSKRNL] Implement NtQuerySystemInformation(SystemLogicalProcessorInformation)
Pierre Schweitzer [Fri, 27 Sep 2019 18:36:34 +0000 (20:36 +0200)]
[NTOSKRNL] Implement NtQuerySystemInformation(SystemLogicalProcessorInformation)

4 months ago[CONFIGURE] Add support for latest MSVC toolchain (#1940)
William Kent [Thu, 26 Sep 2019 21:49:52 +0000 (17:49 -0400)]
[CONFIGURE] Add support for latest MSVC toolchain (#1940)

4 months ago[BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search functi...
Shy Zedaka [Thu, 26 Sep 2019 20:18:59 +0000 (23:18 +0300)]
[BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search function to Hebrew, and Some Other changes. (#1938)

4 months ago[HDAUDBUS] Fix timeouts for hardware register operations. CORE-15874 1899/head
Thomas Faber [Sat, 7 Sep 2019 08:38:42 +0000 (10:38 +0200)]
[HDAUDBUS] Fix timeouts for hardware register operations. CORE-15874

Most needed to be multiplied by 10 to match Haiku's behavior.
In one case, the broken timeout was offset by a higher number of loop
iterations, which is now  restored.

This should fix failures on real hardware that result in the
"unable to exit reset" print, and avoid a possible subsequent Pnp
manager crash.

Compare with the following (both snooze and KeStallExecutionProcessor use microseconds):

4 months ago[NTOS:PNP] When traversing the device tree, keep a reference to the current device... 1560/head
Thomas Faber [Sun, 5 May 2019 05:26:57 +0000 (07:26 +0200)]
[NTOS:PNP] When traversing the device tree, keep a reference to the current device. CORE-15874

4 months ago[APPHELP_APITEST] Make the db test succeed on 2k3 1910/head
Mark Jansen [Sun, 15 Sep 2019 16:38:24 +0000 (18:38 +0200)]
[APPHELP_APITEST] Make the db test succeed on 2k3

4 months ago[APPHELP_APITEST] Make the apphelp test succeed on 2k3
Mark Jansen [Sun, 15 Sep 2019 15:11:32 +0000 (17:11 +0200)]
[APPHELP_APITEST] Make the apphelp test succeed on 2k3

4 months ago[POWERCFG] Fix the Indentation. No code changes!
Eric Kohl [Wed, 25 Sep 2019 08:51:55 +0000 (10:51 +0200)]
[POWERCFG] Fix the Indentation. No code changes!

4 months ago[Win32SS] Support Module Versioning.
James Tabor [Tue, 24 Sep 2019 22:40:18 +0000 (17:40 -0500)]
[Win32SS] Support Module Versioning.

Set the appropriate flags supporting versions of software modules.
Fix arguments for getting desktop DC.

4 months ago[SNDVOL32] Fix a typo in the bass and treble slider code
Eric Kohl [Tue, 24 Sep 2019 21:28:17 +0000 (23:28 +0200)]
[SNDVOL32] Fix a typo in the bass and treble slider code

4 months ago[UTILMAN] Add Russian translation (#1934)
Oleg Dubinskiy [Tue, 24 Sep 2019 15:35:30 +0000 (18:35 +0300)]
[UTILMAN] Add Russian translation (#1934)

+ Update Copyright translation and the hotkey shortcut for the Cancel button.
Co-Authored-By: Stanislav Motylkov <>
4 months agoFix line spacing of Baltic MS Sans Serif (ssee1257.fon)
Katayama Hirofumi MZ [Tue, 24 Sep 2019 09:01:59 +0000 (18:01 +0900)]
Fix line spacing of Baltic MS Sans Serif (ssee1257.fon)

Line spacing to 6px.
Version 0.1.1

4 months ago[HAL] Fix parser bugs in HalpDebugPciDumpBus (#1895)
Stanislav Motylkov [Mon, 23 Sep 2019 21:46:23 +0000 (00:46 +0300)]
[HAL] Fix parser bugs in HalpDebugPciDumpBus (#1895)

- Match subclass properly, don't match third subclass.
- Don't match subclass from next class, add ClassEnd boundary.
- Use class name if subclass name not available.
- Gracefully return "Unknown" if no class name found.

4 months ago[MSXML3R] XML/XSL file description localization (#1926)
Lee Schroeder [Mon, 23 Sep 2019 21:30:53 +0000 (14:30 -0700)]
[MSXML3R] XML/XSL file description localization (#1926)

Add localization for the file description of both XML and XSL file formats.
Please check for copypasta errors!


Co-Authored-By: Stanislav Motylkov <>
4 months ago[TRANSLATION] Russian translation for browseui (#1928)
Abdulganiev Rafael [Mon, 23 Sep 2019 21:28:46 +0000 (01:28 +0400)]
[TRANSLATION] Russian translation for browseui (#1928)

Co-Authored-By: Stanislav Motylkov <>
4 months ago[INF] Create missing registry keys on TCPIP install
Eric Kohl [Mon, 23 Sep 2019 19:04:29 +0000 (21:04 +0200)]
[INF] Create missing registry keys on TCPIP install

Create missing subkeys in order to prevent errors on adapter enumeration.


4 months ago[NTOS:KE] Fix 'Sert' typo, in a comment (#1929)
Serge Gautherie [Sun, 22 Sep 2019 23:13:07 +0000 (01:13 +0200)]
[NTOS:KE] Fix 'Sert' typo, in a comment (#1929)

4 months ago[COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
Joachim Henze [Sun, 22 Sep 2019 19:17:10 +0000 (21:17 +0200)]
[COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093

Most likely not correct, as it breaks comctl32:buttonv6 tests,68147

But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

I committed the same workaround already into 0.4.12-RC-30-g

CORE-13278 was once introduced/unhidden by SVN 73806 ==

CORE-16093 was once introduced/unhidden by SVN 74149 ==

4 months ago[BROWSEUI] RC de-DE of Search feature & Folderoptions caption CORE-16392
Joachim Henze [Sun, 22 Sep 2019 17:11:39 +0000 (19:11 +0200)]
[BROWSEUI] RC de-DE of Search feature & Folderoptions caption CORE-16392

4 months ago[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385
Thomas Faber [Fri, 20 Sep 2019 10:19:34 +0000 (12:19 +0200)]
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385

4 months ago[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385
Thomas Faber [Tue, 10 Sep 2019 10:24:11 +0000 (12:24 +0200)]
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385

4 months ago[LABEL] Fix MSVC build.
Thomas Faber [Sun, 22 Sep 2019 14:12:03 +0000 (16:12 +0200)]
[LABEL] Fix MSVC build.

4 months ago[LABEL] Prompt the user to confirm the deletion of a volume label
Eric Kohl [Sun, 22 Sep 2019 13:31:19 +0000 (15:31 +0200)]
[LABEL] Prompt the user to confirm the deletion of a volume label

4 months ago[LABEL][CMD] Convert the label command to a standalone executable
Eric Kohl [Sun, 22 Sep 2019 12:50:37 +0000 (14:50 +0200)]
[LABEL][CMD] Convert the label command to a standalone executable


4 months ago[SHELL32_APITEST] Fix PIDL leaks.
Thomas Faber [Tue, 10 Sep 2019 10:12:02 +0000 (12:12 +0200)]

4 months ago[BROWSEUI] Fix a PIDL leak.
Thomas Faber [Tue, 10 Sep 2019 10:11:34 +0000 (12:11 +0200)]
[BROWSEUI] Fix a PIDL leak.

4 months ago[SHLWAPI] Import Wine commit c8175e6c7a7 (Fix Stat() method for file streams) by...
Thomas Faber [Sun, 8 Sep 2019 09:22:22 +0000 (11:22 +0200)]
[SHLWAPI] Import Wine commit c8175e6c7a7 (Fix Stat() method for file streams) by Nikolay Sivov.

Fixes crash in shlwapi_winetest:istream.

4 months ago[SHELL32] Handle BYREF variants in CFolderItems::Item.
Thomas Faber [Sun, 8 Sep 2019 09:10:29 +0000 (11:10 +0200)]
[SHELL32] Handle BYREF variants in CFolderItems::Item.

Fixes crash in shell32_winetest:shelldispatch.

See also:

4 months ago[WS2_32_APITEST] Try to make the number of WSAAsync tests constant.
Thomas Faber [Sun, 8 Sep 2019 06:44:09 +0000 (08:44 +0200)]
[WS2_32_APITEST] Try to make the number of WSAAsync tests constant.

4 months ago[MOUNTMGR] HasDriveLetter(): Simplify code by using a for() loop
Serge Gautherie [Sun, 22 Sep 2019 08:25:09 +0000 (10:25 +0200)]
[MOUNTMGR] HasDriveLetter(): Simplify code by using a for() loop

4 months ago[PSDK] Add missing declaration of WTSGetActiveConsoleSessionId() (#1920)
Bișoc George [Sat, 21 Sep 2019 16:51:28 +0000 (18:51 +0200)]
[PSDK] Add missing declaration of WTSGetActiveConsoleSessionId() (#1920)

This allows this function to be used.

4 months ago[CODEOWNERS] Add some entries, fix some others
Mark Jansen [Sat, 21 Sep 2019 15:40:51 +0000 (17:40 +0200)]
[CODEOWNERS] Add some entries, fix some others
Also delete a now obsolete comment

4 months ago[USETUP] Improve Japanese translation (#1918)
Katayama Hirofumi MZ [Sat, 21 Sep 2019 14:07:07 +0000 (23:07 +0900)]
[USETUP] Improve Japanese translation (#1918)

4 months ago[OPENGLCFG] Fix crash if no drivers (#1919)
Carlo Bramini [Sat, 21 Sep 2019 13:58:38 +0000 (15:58 +0200)]
[OPENGLCFG] Fix crash if no drivers (#1919)

Actually, it crashes here on Windows XP.

4 months ago[User32|Tests] Sync Port Wine Combo Controls.
James Tabor [Sat, 21 Sep 2019 13:47:56 +0000 (08:47 -0500)]
[User32|Tests] Sync Port Wine Combo Controls.

Need to cross check these changes with WINE ComCtl32 before you PANIC

Not in order:
Piotr Caban : Remove unneeded RECT parameter from CBPaintText helper.
              Don't invalidate ComboBox on CB_SETCURSEL message.
Don't invalidate ComboBox on LBN_SELCHANGE and
              Add more CB_SETCURSEL tests on ComboBox.
              Redraw combo text field even if it's empty.
Let ComboBox edit control handle the redraw even if
Don't do the painting if combobox is not visible in

Dmitry Timoshkov : Don't force a combobox repaint on WM_SIZE.

This breaks z-order based painting and causes side effects
applications that during the WM_PAINT processing reference
             data associated with a not fully initialized window.
Ref :

Fabian Maurer : Set listbox popup height correctly and add tests.

                Properly set dropdown height.

             Now that user32 and comctl32 combo are separated,
             this won't lead to a regression anymore
             Ref :
             Info by Sebastian Lackner Ref:

Nikolay Sivov : Remove some misleading TODOs and confusing comments.

4 months ago[ATTRIB][CMD] Convert the 'attrib' command into a standalone executable
Eric Kohl [Sat, 21 Sep 2019 09:39:01 +0000 (11:39 +0200)]
[ATTRIB][CMD] Convert the 'attrib' command into a standalone executable


4 months ago[WIN32SS][NTUSER] Fix hit test position of popup menu
Katayama Hirofumi MZ [Sat, 21 Sep 2019 09:21:17 +0000 (18:21 +0900)]
[WIN32SS][NTUSER] Fix hit test position of popup menu

The submenu of desktop popup menu was erroneously shown at first right click.
- Fix the hit test position that was modified by window style change.

4 months agoOOPS - Nothing to see there :P
Hermès Bélusca-Maïto [Sat, 21 Sep 2019 02:38:47 +0000 (04:38 +0200)]
OOPS - Nothing to see there :P

Revert commit 16a35353.

4 months ago[UBTRFS] Addendum to 255ef2c3: Add missing exports expected by mkbtrfs.
Hermès Bélusca-Maïto [Sat, 21 Sep 2019 02:35:01 +0000 (04:35 +0200)]
[UBTRFS] Addendum to 255ef2c3: Add missing exports expected by mkbtrfs.
CORE-16383 CORE-16354

4 months agoWIP testing ISO
Hermès Bélusca-Maïto [Thu, 12 Sep 2019 14:44:53 +0000 (16:44 +0200)]
WIP testing ISO

4 months ago[TRANSLATION] Polish translation update (#1916)
Adam Słaboń [Fri, 20 Sep 2019 19:51:47 +0000 (21:51 +0200)]
[TRANSLATION] Polish translation update (#1916)

Added translation for netstat, utilman and netplwiz. Updated translation of find, reg, rapps, regedit, sndvol32, usetup, hivesys, mmsys, openglcfg, powercfg, sysdm, shellext, browseui, devmgr, msgina, netcfgx, shell32, syssetup, shortcuts and vcdcontroltool.

4 months ago[OPENGLCFG] Add italian translation. (#1915)
Carlo Bramini [Fri, 20 Sep 2019 19:51:33 +0000 (21:51 +0200)]
[OPENGLCFG] Add italian translation. (#1915)

4 months ago[COMCTL32] Updown Suppress the NM_RELEASEDCAPTURE notification CORE-14365
Joachim Henze [Fri, 20 Sep 2019 18:13:09 +0000 (20:13 +0200)]
[COMCTL32] Updown Suppress the NM_RELEASEDCAPTURE notification CORE-14365

This fixes a strange toggle-back-effect in 'Zeckensacks Glide Wrapper 0.84c'
by importing Wine commit
Thanks to patches author Akihiro Sagawa <>

4 months ago[USERINIT] Limit expanded Combobox height for LiveCD
Joachim Henze [Fri, 20 Sep 2019 16:18:19 +0000 (18:18 +0200)]
[USERINIT] Limit expanded Combobox height for LiveCD

v6 comboboxes default to displaying up to 30entries and
give a bad user experience in LiveCD
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g

Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.

Similar commit for bootcd CORE-16252
went into 0.4.13-dev-740-g

4 months ago[THEMES] Add italian translations (#1913)
Carlo Bramini [Fri, 20 Sep 2019 12:33:56 +0000 (14:33 +0200)]
[THEMES] Add italian translations (#1913)

* Include italian translation

* Include italian translation

* Add italian translation

* Add italian translation

4 months ago[IPCONFIG] Improve the 'Autoconfiguration Enabled' information
Eric Kohl [Fri, 20 Sep 2019 07:24:49 +0000 (09:24 +0200)]
[IPCONFIG] Improve the 'Autoconfiguration Enabled' information

- Show 'Autoconfiguration Enabled' only if DHCP is enabled for the adapter.
- Retrieve and display the autoconfiguration state.

4 months ago[EXPLORER] Mitigate CORE-15760 'system menu may close unexpectedly'
Joachim Henze [Thu, 19 Sep 2019 22:11:10 +0000 (00:11 +0200)]
[EXPLORER] Mitigate CORE-15760 'system menu may close unexpectedly'

Looks like a race condition of the async part of SetForegroundWindow().


I intend to merge that back into 0.4.12RC as well.

4 months ago[FREELDR] Hack: Boot ReactOS even when a cdrom-drive does not report a proper geometry
Eric Kohl [Thu, 19 Sep 2019 21:24:43 +0000 (23:24 +0200)]
[FREELDR] Hack: Boot ReactOS even when a cdrom-drive does not report a proper geometry

We need to find a way to retrieve the LBA sector count of a drive, not only its CHS geometry.

4 months ago[NETPLWIZ] Add Italian translation. (#1912)
Carlo Bramini [Thu, 19 Sep 2019 19:58:00 +0000 (21:58 +0200)]
[NETPLWIZ] Add Italian translation. (#1912)

4 months ago[CABMAN] Third addendum to 7afc888: Also use the the old code in the Trucate() method...
Eric Kohl [Thu, 19 Sep 2019 13:36:18 +0000 (15:36 +0200)]
[CABMAN] Third addendum to 7afc888: Also use the the old code in the Trucate() method on Linux

4 months ago[CABMAN] Second addendum to 7afc888: Use the old code to make Linux happy.
Eric Kohl [Thu, 19 Sep 2019 13:25:23 +0000 (15:25 +0200)]
[CABMAN] Second addendum to 7afc888: Use the old code to make Linux happy.

Sorry for the noise, but I do not have a Linux machine to test the build. :-/

4 months ago[CABMAN] Addendum to 7afc8882: Use PATH_MAX instead of MAX_PATH
Eric Kohl [Thu, 19 Sep 2019 13:07:57 +0000 (15:07 +0200)]
[CABMAN] Addendum to 7afc8882: Use PATH_MAX instead of MAX_PATH

4 months ago[CABMAN] Do not use tmpfile() because it does not work well on Windows XP
Eric Kohl [Thu, 19 Sep 2019 12:56:50 +0000 (14:56 +0200)]
[CABMAN] Do not use tmpfile() because it does not work well on Windows XP

- Use tempnam() and fopen() instead.
- Prevent the use of file names with a leading slash or backslash.
- Also prevent the use of file names with a trailing dot.
- Remove temporary files after use.

4 months ago[FREELDR] Rename the PE loader functions 'PeLdr*' instead of 'WinLdr*'.
Hermès Bélusca-Maïto [Thu, 19 Sep 2019 00:47:29 +0000 (02:47 +0200)]
[FREELDR] Rename the PE loader functions 'PeLdr*' instead of 'WinLdr*'.

4 months ago[SDK:NT] Remove Win32-isms.
Hermès Bélusca-Maïto [Thu, 19 Sep 2019 00:38:34 +0000 (02:38 +0200)]
[SDK:NT] Remove Win32-isms.

5 months ago[FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems.
Hermès Bélusca-Maïto [Wed, 18 Sep 2019 00:42:56 +0000 (02:42 +0200)]
[FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems.

5 months ago[FREELDR] Addendum / actual fix for ef76709b
Hermès Bélusca-Maïto [Tue, 17 Sep 2019 23:06:15 +0000 (01:06 +0200)]
[FREELDR] Addendum / actual fix for ef76709b

According to the Advanced RISC Computing Specification v1.2, for partitions,
StartingAddress and EndingAddress are the start and end positions of the
partition in terms of byte offsets from the start of the disk.
CurrentAddress is the current offset into (i.e. relative to) the partition.

Fix also the FAT filesystem in accordance.

- FIXME fix: Retrieve the size of the disk in number of sectors in DiskOpen().
- Add extra validity checks in the DiskSeek() functions.
- Explicitly call PcDisk* functions in machpc.c and pcdisk.c, and
  XboxDisk* functions in machxbox.c (the code in these files is not
  called cross-platform).

CORE-16216 CORE-16248

5 months ago[FREELDR] Other enhancements.
Hermès Bélusca-Maïto [Tue, 17 Sep 2019 21:04:39 +0000 (23:04 +0200)]
[FREELDR] Other enhancements.

- Modify DiskReportError() to use an internal "display counter", so that
  imbricated DiskReportError(FALSE) ... DiskReportError(TRUE) can behave
  as expected.
- Merge LoadAndBootDrive(), LoadAndBootPartition(),
  LoadAndBootBootSector() into one LoadAndBootDevice() function + its
  helpers (in progress...).

5 months ago[FREELDR] Minor code improvements + 1 bug-fix.
Hermès Bélusca-Maïto [Tue, 17 Sep 2019 20:24:47 +0000 (22:24 +0200)]
[FREELDR] Minor code improvements + 1 bug-fix.

- "FrldrBootPath" -> "FrLdrBootPath";
- Get rid of GetFreeLoaderVersionString() and use FrLdrVersionString
  directly instead;
- Rephrase some comments;
- Reduce indent level in LoadOperatingSystem() and EditOperatingSystemEntry().

Bug fix:
- Fix DissectArcPath() for "ramdisk(0)" case.

5 months ago[BROWSEUI] Translate search function into French
Pierre Schweitzer [Tue, 17 Sep 2019 21:06:34 +0000 (23:06 +0200)]
[BROWSEUI] Translate search function into French


5 months ago[LSA][SECUR32] Check for untrusted clients
Eric Kohl [Tue, 17 Sep 2019 10:58:11 +0000 (12:58 +0200)]
[LSA][SECUR32] Check for untrusted clients

Calls  to LsapCallAuthenticationPackage are routed to LsaApCallPackageUntrusted instead of LsaApCallPackage for  untrusted clients.

5 months ago[MSV1_0] Implement LsaApCallPackageUntrusted()
Eric Kohl [Tue, 17 Sep 2019 10:46:49 +0000 (12:46 +0200)]
[MSV1_0] Implement LsaApCallPackageUntrusted()

An untrusted client is only allowed to change passwords

5 months ago[SYSDM] Store the profile path in the PROFILEDATA struct for deleting and copying...
Eric Kohl [Mon, 16 Sep 2019 06:51:08 +0000 (08:51 +0200)]
[SYSDM] Store the profile path in the PROFILEDATA struct for deleting and copying the profiles

Brock Mammen [Thu, 12 Sep 2019 13:53:24 +0000 (08:53 -0500)]

5 months ago[COM_APITEST] Remove duplicate interface
Brock Mammen [Thu, 12 Sep 2019 13:52:26 +0000 (08:52 -0500)]
[COM_APITEST] Remove duplicate interface

5 months ago[SHELLFIND] Add missing dependency to CMakeLists.txt
Brock Mammen [Sat, 31 Aug 2019 00:54:50 +0000 (19:54 -0500)]
[SHELLFIND] Add missing dependency to CMakeLists.txt