Pierre Schweitzer [Sat, 6 Oct 2018 10:08:25 +0000 (12:08 +0200)]
[KMTESTS:CC] A pin BCB has a node type code
Eric Kohl [Sat, 6 Oct 2018 09:11:07 +0000 (11:11 +0200)]
[MSPORTS] When the LPT port number gets changed, update the PortName and FriendlyName values in the registry.
Pierre Schweitzer [Fri, 5 Oct 2018 19:25:28 +0000 (21:25 +0200)]
[KMTESTS:CC] Fix a typo
Pierre Schweitzer [Fri, 5 Oct 2018 19:17:38 +0000 (21:17 +0200)]
[NTOSKRNL] Implement support for PIN_IF_BCB flag
Pierre Schweitzer [Fri, 5 Oct 2018 19:14:13 +0000 (21:14 +0200)]
[NTOSKRNL] When pinning data, try to find an already pinned BCB
If found, attempt to lock it and return it.
This fixes a lot of CcPinRead tests (and seems to speed up a bit ReactOS)
Pierre Schweitzer [Fri, 5 Oct 2018 19:01:02 +0000 (21:01 +0200)]
[NTOSKRNL] When mapping data, try to find if there's already a BCB
If so, return such BCB instead of creating a new one. This will
allow (at some point) to be more consistent in case of concurrent
mapping.
This fixes a few CcMapData tests.
Pierre Schweitzer [Fri, 5 Oct 2018 17:43:10 +0000 (19:43 +0200)]
[NTOSKRNL] Move the PinCount out of the VACB to the BCB
Given current ReactOS implementation, a VACB can be pinned
several times, with different BCB. In next commits, a single
BCB will be able to be pinned several times. That would
lead to severe inconsistencies in counting and thus corruption.
Eric Kohl [Fri, 5 Oct 2018 13:09:27 +0000 (15:09 +0200)]
[DEVMGR] Hackfix CORE-5643
Eric Kohl [Fri, 5 Oct 2018 09:40:55 +0000 (11:40 +0200)]
[SERVICES] Ignore the case when we compare account names
Pierre Schweitzer [Fri, 5 Oct 2018 08:49:11 +0000 (10:49 +0200)]
[NTOSKRNL] On open, verify and validate the hint device object if any
Pierre Schweitzer [Fri, 5 Oct 2018 08:45:21 +0000 (10:45 +0200)]
[NTOSKRNL] Implement IopCheckTopDeviceHint()
Pierre Schweitzer [Fri, 5 Oct 2018 08:39:50 +0000 (10:39 +0200)]
[NTOSKRNL] In IoGetRelatedDeviceObject(), validate hint is on the stack before returning it
Pierre Schweitzer [Fri, 5 Oct 2018 08:36:52 +0000 (10:36 +0200)]
[NTOSKRNL] Implement IopVerifyDeviceObjectOnStack()
Eric Kohl [Fri, 5 Oct 2018 07:41:50 +0000 (09:41 +0200)]
[SERVICES] Revert
f6d81f22 because it breaks the advapi32 LockServiceDatabase test.
Eric Kohl [Fri, 5 Oct 2018 06:41:23 +0000 (08:41 +0200)]
[SERVICES] Fix timeout when a service is stopped
RSetServiceStatus: Send the stop command for the dispatcher thread from a separate thread.
Fixes CORE-15064
Pierre Schweitzer [Thu, 4 Oct 2018 20:24:52 +0000 (22:24 +0200)]
[NTOSKRNL] A bit of cleanup in Io*FilterContext()
Pierre Schweitzer [Thu, 4 Oct 2018 17:30:11 +0000 (19:30 +0200)]
[NTOSKRNL] Implement IoChangeFileObjectFilterContext()
Pierre Schweitzer [Thu, 4 Oct 2018 17:19:24 +0000 (19:19 +0200)]
[NTOSKRNL] Implement IoGetFileObjectFilterContext()
Serge Gautherie [Sun, 16 Sep 2018 15:13:51 +0000 (17:13 +0200)]
[KMTESTS:TCPIP] Add an "Associate address IRP completed" trace
Serge Gautherie [Sun, 16 Sep 2018 15:38:38 +0000 (17:38 +0200)]
[KMTESTS:TCPIP] ReturnAddress: Expect NT5 result, not NT6+ one
ROSTESTS-268
Pierre Schweitzer [Thu, 4 Oct 2018 09:13:15 +0000 (11:13 +0200)]
[DEVMGR] Update French translation
Pierre Schweitzer [Thu, 4 Oct 2018 08:42:13 +0000 (10:42 +0200)]
[NTOSKRNL] Quickly check for alignment in NtRead/WriteFile
This quick check based on bits and operation is for 2^ based
sector sizes (most of the cases) and will perform faster than
the modulo operation which is still used in fallback in case
the sector size wouldn't be a power of 2.
Pierre Schweitzer [Thu, 4 Oct 2018 08:27:35 +0000 (10:27 +0200)]
[NTOSKRNL] Use captured variable to check parameters in NtRead/WriteFile
Eric Kohl [Thu, 4 Oct 2018 08:20:12 +0000 (10:20 +0200)]
[MSPORTS] Check and show which parallel port is in use.
Pierre Schweitzer [Thu, 4 Oct 2018 05:56:23 +0000 (07:56 +0200)]
[NTOSKRNL] On read/write, also check buffer respects device alignment requirements
Pierre Schweitzer [Thu, 4 Oct 2018 05:53:12 +0000 (07:53 +0200)]
[NTOSKRNL] When checking for byte offset alignment, tolerate some magic values
Eric Kohl [Wed, 3 Oct 2018 23:16:17 +0000 (01:16 +0200)]
[NTOSKRNL] NtReadFile/NtWriteFile: If a file has been opened for non-cached access, Length and ByteOffset must be sector size aligned.
This fixed two ntdll apitests.
Pierre Schweitzer [Wed, 3 Oct 2018 20:55:23 +0000 (22:55 +0200)]
[NTOSKRNL] In IopQueryNameInternal(), enclose output copy in a SEH statement
Pierre Schweitzer [Wed, 3 Oct 2018 19:28:11 +0000 (21:28 +0200)]
[NTOSKRNL] Call IoCreateFileSpecifyDeviceObjectHint with the hint if it was specified
Mark Jansen [Wed, 3 Oct 2018 17:34:14 +0000 (19:34 +0200)]
[LDR] Include dllname in snap failure DPRINT.
CORE-15135
Pierre Schweitzer [Wed, 3 Oct 2018 15:08:42 +0000 (17:08 +0200)]
[NTOSKRNL] In IoQueryFileDosDeviceName(), in case of an error, return appropriate status
Pierre Schweitzer [Wed, 3 Oct 2018 11:56:18 +0000 (13:56 +0200)]
[NTOSKRNL] Implement DOS name query in IopQueryNameInternal()
Pierre Schweitzer [Wed, 3 Oct 2018 11:52:05 +0000 (13:52 +0200)]
[NTOSKRNL] Allow FileNameInformation not to be implemented in storage stack
Pierre Schweitzer [Wed, 3 Oct 2018 11:50:16 +0000 (13:50 +0200)]
[NTOSKRNL] In IopQueryNameInternal() don't copy name if it's not valid
Pierre Schweitzer [Wed, 3 Oct 2018 09:56:21 +0000 (11:56 +0200)]
[NTOSKRNL] Implement IoQueryFileDosDeviceName()
Pierre Schweitzer [Wed, 3 Oct 2018 09:45:08 +0000 (11:45 +0200)]
[NTOSKRNL] Stub support for querying DOS name when parsing FO name
Pierre Schweitzer [Wed, 3 Oct 2018 08:21:39 +0000 (10:21 +0200)]
[NTOSKRNL] Use faster internal helper to query name
This only applies if we're called from kernel mode
with a synchronous file.
Pierre Schweitzer [Wed, 3 Oct 2018 08:15:30 +0000 (10:15 +0200)]
[NTOSKRNL] Rename IopQueryNameFile to IopQueryNameInternal
Mark Jansen [Mon, 1 Oct 2018 22:50:34 +0000 (00:50 +0200)]
[FONT][WIN32SS] Include the style name in the registry key.
Thanks to Doug Lyons for pinpointing the issue.
CORE-14044
Bișoc George [Tue, 2 Oct 2018 15:44:00 +0000 (17:44 +0200)]
[NEWDEV] Fix a truncated text on device driver name
Katayama Hirofumi MZ [Tue, 2 Oct 2018 19:53:04 +0000 (04:53 +0900)]
[FONTS] Fix underline/underscore position of Tahoma (#892)
Because of FontForge's bug, the underline position value of Tahoma and Tahoma Bold was wrongly set (#789, #809). This commit fixes those values.
CORE-15079
Eric Kohl [Tue, 2 Oct 2018 15:57:32 +0000 (17:57 +0200)]
[NETCFGX] Network property page: Add support for enum type options, the 'Optional' setting and the 'TextLimit' and 'Uppercase' settings for edit type options.
Pierre Schweitzer [Tue, 2 Oct 2018 11:34:59 +0000 (13:34 +0200)]
[USETUP] Add missing line jump
Thomas Faber [Tue, 2 Oct 2018 07:55:07 +0000 (09:55 +0200)]
[NTOS:IO] Implement IopAcquireFileObjectLock and use it to fix IopLockFileObject
Eric Kohl [Mon, 1 Oct 2018 19:15:24 +0000 (21:15 +0200)]
[NETCFGX] Network property page: Implement reading of configured settings. Editing and writing is not implemented yet.
Pierre Schweitzer [Mon, 1 Oct 2018 11:47:06 +0000 (13:47 +0200)]
[NTOSKRNL] Respect PFN cache attribute when required
This fixes noisy DPRINT1 being printed while reading
or writing files with NFS.
Mark Jansen [Mon, 1 Oct 2018 18:47:01 +0000 (20:47 +0200)]
[DMUSIC] Fix the build for vs 2010
Mark Jansen [Mon, 24 Sep 2018 21:59:57 +0000 (23:59 +0200)]
[RTL] actctx: When probing a dll for a manifest, use the first manifest id present,
instead of always searching for CREATEPROCESS_MANIFEST_RESOURCE_ID.
CORE-9519
Amine Khaldi [Mon, 1 Oct 2018 11:57:42 +0000 (12:57 +0100)]
[ITSS_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:57:08 +0000 (12:57 +0100)]
[ITSS] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:56:32 +0000 (12:56 +0100)]
[INETMIB1] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:55:57 +0000 (12:55 +0100)]
[INETCOMM_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:55:17 +0000 (12:55 +0100)]
[INETCOMM] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:54:28 +0000 (12:54 +0100)]
[IMM32_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:53:21 +0000 (12:53 +0100)]
[IMM32] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:52:44 +0000 (12:52 +0100)]
[IMAADP32.ACM] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:52:10 +0000 (12:52 +0100)]
[IEFRAME] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:51:35 +0000 (12:51 +0100)]
[HHCTRL.OCX] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:50:59 +0000 (12:50 +0100)]
[GDIPLUS_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:50:25 +0000 (12:50 +0100)]
[GDIPLUS] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:49:44 +0000 (12:49 +0100)]
[FUSION] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:49:09 +0000 (12:49 +0100)]
[CRYPTUI] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:48:33 +0000 (12:48 +0100)]
[CRYPT32_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:47:51 +0000 (12:47 +0100)]
[CRYPT32] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:47:02 +0000 (12:47 +0100)]
[CREDUI_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:46:19 +0000 (12:46 +0100)]
[CREDUI] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:45:40 +0000 (12:45 +0100)]
[COMDLG32_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Mon, 1 Oct 2018 11:44:53 +0000 (12:44 +0100)]
[COMDLG32] Sync with Wine Staging 3.17. CORE-15127
Pierre Schweitzer [Mon, 1 Oct 2018 09:04:26 +0000 (11:04 +0200)]
[DMUSIC] Fix build?
Amine Khaldi [Sun, 30 Sep 2018 23:27:20 +0000 (00:27 +0100)]
[ATL100_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:26:43 +0000 (00:26 +0100)]
[ATL] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:26:09 +0000 (00:26 +0100)]
[ADVPACK_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:25:34 +0000 (00:25 +0100)]
[ADVPACK] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:24:54 +0000 (00:24 +0100)]
[QEDIT] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:24:18 +0000 (00:24 +0100)]
[MSDMO] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:23:40 +0000 (00:23 +0100)]
[DPLAYX_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:23:02 +0000 (00:23 +0100)]
[DPLAYX] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:22:26 +0000 (00:22 +0100)]
[DMUSIC] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:21:34 +0000 (00:21 +0100)]
[DINPUT_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:20:57 +0000 (00:20 +0100)]
[DINPUT] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:20:18 +0000 (00:20 +0100)]
[D3DXOF] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:19:39 +0000 (00:19 +0100)]
[D3DX9_36] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:19:01 +0000 (00:19 +0100)]
[D3DCOMPILER_43] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:18:08 +0000 (00:18 +0100)]
[INETCPL] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:17:02 +0000 (00:17 +0100)]
[XCOPY_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:16:20 +0000 (00:16 +0100)]
[XCOPY] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:15:34 +0000 (00:15 +0100)]
[WMIC] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:14:52 +0000 (00:14 +0100)]
[TASKKILL] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:13:56 +0000 (00:13 +0100)]
[REG] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:13:11 +0000 (00:13 +0100)]
[WSCRIPT_WINETEST] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 23:11:58 +0000 (00:11 +0100)]
[CSCRIPT][WSCRIPT] Sync with Wine Staging 3.17. CORE-15127
Amine Khaldi [Sun, 30 Sep 2018 22:57:08 +0000 (23:57 +0100)]
[XDK][PSDK][WINE] Unify ARRAY_SIZE definition for Wine modules. CORE-15127
Hermès Bélusca-Maïto [Sun, 30 Sep 2018 19:22:50 +0000 (21:22 +0200)]
[SHELL32] Fixes and improvements for PickIconDlg().
- Deal with expanded paths only when loading icons. If the user specifies
an unexpanded path to a module containing icons, this unexpanded path
is returned to the caller!
- Perform the dialog cleanup in WM_DESTROY message handler.
- When pressing ENTER/OK in the dialog box, retrieve the selected icon and
close the dialog *ONLY WHEN* the user actually has selected an icon.
If the user modified manually the module path, pressing ENTER/OK instead
reloads the icons list.
Hermès Bélusca-Maïto [Sun, 30 Sep 2018 18:07:29 +0000 (20:07 +0200)]
[SHELL32] Code formatting only.
Eric Kohl [Sun, 30 Sep 2018 15:22:29 +0000 (17:22 +0200)]
[BOOTDATA] Register the CriticalDeviceCoInstaller as a class co-installer for critical device classes
Eric Kohl [Sun, 30 Sep 2018 15:18:28 +0000 (17:18 +0200)]
[SYSETUP] Implement the CriticalDeviceCoInstaller
The CriticalDeviceCoInstaller adds devices of registered classes to the critical device database.
Thomas Faber [Sun, 16 Sep 2018 13:25:27 +0000 (15:25 +0200)]
[BTRFS] Fix IRP leak.
This leaked at least one IRP for every write, making it the largest leak when
running with BTRFS as the system volume.
Thanks to Victor Perevertkin.
Submitted upstream thanks to Pierre:
https://github.com/maharmstone/btrfs/pull/106
Pierre Schweitzer [Sun, 30 Sep 2018 08:55:07 +0000 (10:55 +0200)]
[NPFS] Magic--;
Pierre Schweitzer [Sun, 30 Sep 2018 08:53:12 +0000 (10:53 +0200)]
[NTOSKRNL] Fix remaining access computation on open
Pierre Schweitzer [Sun, 30 Sep 2018 08:49:13 +0000 (10:49 +0200)]
[NTOSKRNL] Implement access check for secure open