Pierre Schweitzer [Sat, 24 Nov 2018 21:25:32 +0000 (22:25 +0100)]
[TCPIP] Properly display local information for established connections
Eric Kohl [Sat, 24 Nov 2018 14:12:09 +0000 (15:12 +0100)]
[MC] Add message 5300-5381 to netmsg.dll.
Pierre Schweitzer [Sat, 24 Nov 2018 21:00:09 +0000 (22:00 +0100)]
[RDBSS] Fix a typo
Spotted by Hermès
Pierre Schweitzer [Sat, 24 Nov 2018 20:36:00 +0000 (21:36 +0100)]
[NETSTAT] Add support for displaying UDP connections owning process
Our netstat can basically look like this now:
https://twitter.com/HeisSpiter/status/
1066430887208919040
Pierre Schweitzer [Sat, 24 Nov 2018 20:30:28 +0000 (21:30 +0100)]
[SDK] Add GetExtendedUdpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 20:25:59 +0000 (21:25 +0100)]
[IPHLPAPI] Reimplement GetUdpTable() using GetExtendedUdpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 20:22:42 +0000 (21:22 +0100)]
[IPHLPAPI] Implement GetExtendedUdpTable()
We only support IPv4 and UDP_TABLE_BASIC, UDP_TABLE_OWNER_PID
for now
CORE-5126
Pierre Schweitzer [Sat, 24 Nov 2018 20:12:44 +0000 (21:12 +0100)]
[IPHLPAPI] Implement getOwnerUdoTable(), to get UDP connections with owner PID
Pierre Schweitzer [Sat, 24 Nov 2018 20:09:17 +0000 (21:09 +0100)]
[TCPIP] Implement enumerating UDP connections with owner PID
Pierre Schweitzer [Sat, 24 Nov 2018 20:04:20 +0000 (21:04 +0100)]
[NETSTAT] Add support for displaying TCP connections owning process
Pierre Schweitzer [Sat, 24 Nov 2018 19:41:16 +0000 (20:41 +0100)]
[IPHLPAPI] Reimplement GetTcpTable() using GetExtendedTcpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 19:34:20 +0000 (20:34 +0100)]
[IPHLPAPI] Don't leak memory
Pierre Schweitzer [Sat, 24 Nov 2018 19:32:55 +0000 (20:32 +0100)]
[IPHLPAPI] Implement the IPv4 TCP_TABLE_OWNER_PID_* cases in GetExtendedTcpTable()
Pierre Schweitzer [Sat, 24 Nov 2018 19:23:29 +0000 (20:23 +0100)]
[IPHLPAPI] Implement getOwnerTcpTable(), to get TCP connections with owner PID
Pierre Schweitzer [Sat, 24 Nov 2018 19:22:00 +0000 (20:22 +0100)]
[TCPIP] Implement enumerating TCP connections with owner PID
Pierre Schweitzer [Sat, 24 Nov 2018 19:21:19 +0000 (20:21 +0100)]
[TCPIP] Store creator PID in ADDRESS_FILE
Pierre Schweitzer [Sat, 24 Nov 2018 18:04:04 +0000 (19:04 +0100)]
[IPHLPAPI] Implement the IPv4 TCP_TABLE_BASIC_* cases in GetExtendedTcpTable()
Eric Kohl [Sat, 24 Nov 2018 12:51:50 +0000 (13:51 +0100)]
[MC] Add messages 3802-3969 and 5700-5729 to netmsg.dll.
Hermès Bélusca-Maïto [Sat, 24 Nov 2018 01:39:58 +0000 (02:39 +0100)]
[SETUPLIB] Improve the Freeldr timeout INI setting hack-fix. Dedicated to Mark Jansen ;-) CORE-15193
Pierre Schweitzer [Fri, 23 Nov 2018 21:49:53 +0000 (22:49 +0100)]
[TCPIP] When enumerating sockets, retrieve their state and return it
This fixes netstat not having any state when enumerating connections.
Basically, now, our netstat produces stuff like:
https://twitter.com/HeisSpiter/status/
1065871999266955264
Pierre Schweitzer [Fri, 23 Nov 2018 21:48:34 +0000 (22:48 +0100)]
[IP] Add a TCPGetSocketStatus() wrapper around LibTCPGetSocketStatus()
Pierre Schweitzer [Fri, 23 Nov 2018 21:39:14 +0000 (22:39 +0100)]
[LWIP] Implement a LibTCPGetSocketStatus() function in our LwIP glue
It is used to query a socket state (established, closed, and so on).
Luo Yufan [Fri, 23 Nov 2018 15:24:47 +0000 (23:24 +0800)]
[TRANSLATION] Update Simplified Chinese translation. (#1057)
Joachim Henze [Fri, 23 Nov 2018 01:25:28 +0000 (02:25 +0100)]
[SHELL32] Improve CORE-15295 IDD_FILE_PROPERTIES
addendum to 0.4.11-dev-673-g
04e1263921c0a4ee9b5ec10bb02884146fcca47a
Actually this control must not statically consume width of 170.
There are two different versions of that dialog.
One has a "change"-button. In this case the edit must be only 100 wide.
In case we have the version without the change button, we resize it to have
170 width (same as its neighbor).
This commit is shared work of
Stanislav Motylkov, Giannis Adamopoulos and Joachim Henze.
Commit supersedes PR#1056.
Pierre Schweitzer [Thu, 22 Nov 2018 20:50:21 +0000 (21:50 +0100)]
[TCPIP] Fix returned IP address when querying TCP connections
This gives something like that now: https://twitter.com/HeisSpiter/status/
1065706156331606017 :-)
CORE-15363
Hermès Bélusca-Maïto [Thu, 22 Nov 2018 00:00:07 +0000 (01:00 +0100)]
[README] Now that we got rid of ViewVC (see https://reactos.org/pipermail/ros-dev/2018-November/018970.html), update the SVN archive repo URL.
Stanislav Motylkov [Wed, 21 Nov 2018 21:07:54 +0000 (00:07 +0300)]
[SYSDM][DXDIAG][SYSTEMINFO] Include only one user-mode DMI library (#1054)
Include only one user-mode DMI library. Addendum to
baf2c0c.
Stanislav Motylkov [Wed, 21 Nov 2018 20:49:15 +0000 (23:49 +0300)]
[DRWTSN32] Add SMBIOS data to the system information (#1017)
[DMILIB][UDMIHELP] Allow functions to be linked with C++ code.
Denis Malikov [Tue, 13 Nov 2018 15:52:18 +0000 (22:52 +0700)]
[KERNEL32] FlsAlloc - fiber local storage list was not initialized before using
William Kent [Tue, 20 Nov 2018 18:38:52 +0000 (13:38 -0500)]
[MC] Fix syntax errors in errcodes.mc
This was causing the MSVC build to fail.
Adam Stachowicz [Tue, 20 Nov 2018 22:59:18 +0000 (23:59 +0100)]
Update README.md (#1051)
Powered by markdownlint ;)
Pierre Schweitzer [Tue, 20 Nov 2018 21:12:47 +0000 (22:12 +0100)]
[IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections
This fixes the API not to return the current TCP connections while
enumerating them (and thus, netstat not displaying them).
It seems we return garbage for now though
William Kent [Mon, 19 Nov 2018 16:34:08 +0000 (11:34 -0500)]
Add support for latest VS2017 (15.0) compiler (#1050)
Latest VS 2017 CL.EXE compiler (version 19.16...) wasn't being correctly detected by the configure.cmd script.
Serge Gautherie [Mon, 19 Nov 2018 01:06:48 +0000 (02:06 +0100)]
[NETSHELL] Fix '0' typo, in a text
Eric Kohl [Sun, 18 Nov 2018 22:58:12 +0000 (23:58 +0100)]
[MC] Add messages 3710-3790 to netmsg.dll.
Hermès Bélusca-Maïto [Sun, 18 Nov 2018 18:07:23 +0000 (19:07 +0100)]
[SETUPLIB][USETUP] Additional partition validity checks.
Always perform the partition validity checks when creating new
primary/extended/logical partitions, and also when a new partition
is automatically created when unpartitioned space is selected for
ReactOS installation.
CORE-12246
Hermès Bélusca-Maïto [Sun, 18 Nov 2018 20:05:32 +0000 (21:05 +0100)]
[OLE32] The CoDisconnectContext() stub added in
6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.
Hermès Bélusca-Maïto [Sun, 18 Nov 2018 19:58:31 +0000 (20:58 +0100)]
[FILEBROWSER] Remove a duplicated include. Noticed by Manuel Oppermann (see ros-dev ML).
Hermès Bélusca-Maïto [Sun, 18 Nov 2018 19:57:23 +0000 (20:57 +0100)]
[CHKDSK] Fix italian translation, by Marco Savelli (addendum to
cfff74da).
Pierre Schweitzer [Sun, 18 Nov 2018 19:51:54 +0000 (20:51 +0100)]
[TCPIP] Properly handle listening sockets
We first check if a socket is listening before
checking whether it has connections. This allows
properly returning listening address.
Furthermore, if it's listening, properly return
status so that it displays nice in netstat.
Result: https://twitter.com/HeisSpiter/status/
1064245622323200000 :-)
Pierre Schweitzer [Sun, 18 Nov 2018 17:56:36 +0000 (18:56 +0100)]
[IPHLPAPI] Properly count UDP entries
Fixes crash when running netstat -a with
no TCP connections but with UDP connections
CORE-5401
Pierre Schweitzer [Sun, 18 Nov 2018 15:21:24 +0000 (16:21 +0100)]
[TCPIP] Implement returning UDP connections
CORE-5401
Pierre Schweitzer [Sun, 18 Nov 2018 15:17:50 +0000 (16:17 +0100)]
[TCPIP] Implement returning TCP connections
CORE-5401
Pierre Schweitzer [Sun, 18 Nov 2018 15:06:44 +0000 (16:06 +0100)]
[IPHLPAPI] Implement getNumUdpEntries() and getUdpTable()
CORE-5401
Pierre Schweitzer [Sun, 18 Nov 2018 15:00:54 +0000 (16:00 +0100)]
[IPHLPAPI] Implement getNumTcpEntries() and getTcpTable()
CORE-5401
Pierre Schweitzer [Sun, 18 Nov 2018 14:57:58 +0000 (15:57 +0100)]
[TDILIB] Make tdiGetSetOfThings() return useful status
Eric Kohl [Sun, 18 Nov 2018 15:18:52 +0000 (16:18 +0100)]
[MC] Add messages 3000-3049, 3660-3695 and 5500-5517 to netmsg.dll.
Denis Malikov [Sun, 18 Nov 2018 14:32:07 +0000 (21:32 +0700)]
[OLE32] Add stub for CoDisconnectContext function (#1044)
Giannis Adamopoulos [Sun, 18 Nov 2018 10:06:04 +0000 (12:06 +0200)]
[NETSHELL] Add some notes about how it can be tested in windows
Giannis Adamopoulos [Wed, 14 Nov 2018 20:38:39 +0000 (22:38 +0200)]
[NETSHELL] CNetConnectionPropertyUi: Add a comment about how windows write the settings
Giannis Adamopoulos [Mon, 12 Nov 2018 22:36:52 +0000 (00:36 +0200)]
[NETSHELL] Move the implementation of the Disable button of the status dialog to CNetConnection::Disconnect
Giannis Adamopoulos [Mon, 12 Nov 2018 22:09:46 +0000 (00:09 +0200)]
[NETSHELL] CNetConUiObject: Implement the Connect and Disconnect context menu items
Giannis Adamopoulos [Mon, 12 Nov 2018 22:08:18 +0000 (00:08 +0200)]
[NETSHELL] Optionally use the system's CLSID_ConnectionManager
Use a central compile option like we do in the rest of the shell so that when testing in windows we can switch using the one in the current dll or the one registered in the system.
Note that not only CLSID_ConnectionManager isn't implemented in netshell, it can't even be instantiated as CLSCTX_INPROC_SERVER because it is implemented by the netman service
Giannis Adamopoulos [Mon, 12 Nov 2018 20:52:57 +0000 (22:52 +0200)]
[NETSHELL] Rewrite how pidls are created and accessed.
What we did before was completely wrong as we stored pointers in the pidl.
Giannis Adamopoulos [Mon, 12 Nov 2018 14:46:45 +0000 (16:46 +0200)]
[NETSHELL] Use smart pointers and IID_PPV_ARG
Giannis Adamopoulos [Mon, 12 Nov 2018 11:23:38 +0000 (13:23 +0200)]
[NETSHELL] Use ATL
Giannis Adamopoulos [Fri, 16 Nov 2018 11:24:03 +0000 (13:24 +0200)]
[NETSHELL] Add missing license headers
Since one of the first files in the module (shfldr_netconnect.c) used the LGPL2.1+ license, all the other files have the same license
Eric Kohl [Sun, 18 Nov 2018 09:54:28 +0000 (10:54 +0100)]
[MC] Add messages 3301-3421 to netmsg.dll and renamed messages 3500-3547.
Pierre Schweitzer [Sat, 17 Nov 2018 21:01:13 +0000 (22:01 +0100)]
[MPR] Drop a nasty ReactOS specific hack
That hack (cf. previous commit) was used to restore all
the saved connections. But, because it was implemented
in the wrong place, each time the MPR DLL was attached,
it was trying to restore connections.
With that commit and the previous one, now, ReactOS has
a correct behavior (it tries to bring back connections
only at session opening) and will reduce "workload" for
applications attaching MPR dll.
CORE-15310
Pierre Schweitzer [Sat, 17 Nov 2018 20:58:04 +0000 (21:58 +0100)]
[WINLOGON] Restore saved connections on session opening
This avoids using a nasty hack in MPR.
CORE-15310
Pierre Schweitzer [Sat, 17 Nov 2018 20:55:57 +0000 (21:55 +0100)]
[MPR] Implement remembered connection enumeration
Submitted upstream
CORE-15310
Bișoc George [Sat, 17 Nov 2018 20:27:33 +0000 (21:27 +0100)]
[OSK] Implement the welcome box (#1007)
In Windows XP, both in On-Screen Keyboard and in Magnify there is a welcome box which is shown upon startup of the application. This feature is already implemented for Magnify in ReactOS which however in On-Screen Keyboard is still unimplemented.
Eric Kohl [Sat, 17 Nov 2018 20:12:47 +0000 (21:12 +0100)]
[MC] Add messages 3051-3099 and 5600-5602. This completes the SERVICE and SERVICE2 message ranges from lmsvc.h.
Pierre Schweitzer [Sat, 17 Nov 2018 16:36:18 +0000 (17:36 +0100)]
[NTOSKRNL] ExfReleaseRundownProtectionCacheAware*() functions don't return anything
Pierre Schweitzer [Sat, 17 Nov 2018 15:41:09 +0000 (16:41 +0100)]
[NTOSKRNL] Implement ExfReInitializeRundownProtectionCacheAware()
We're done with cache-aware rundown protections!
Pierre Schweitzer [Sat, 17 Nov 2018 15:38:36 +0000 (16:38 +0100)]
[NTOSKRNL] Implement ExfRundownCompletedCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 15:33:22 +0000 (16:33 +0100)]
[NTOSKRNL] Replace ExGetRunRefForCurrentProcessor() by a more generic function
Pierre Schweitzer [Sat, 17 Nov 2018 15:28:17 +0000 (16:28 +0100)]
[NTOSKRNL] Implement ExfWaitForRundownProtectionReleaseCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 14:49:50 +0000 (15:49 +0100)]
[NTOSKRNL] Properly align runrefs on SMP in ExInitializeRundownProtectionCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 14:45:29 +0000 (15:45 +0100)]
[NTOSKRNL] Properly align allocation on SMP in ExAllocateCacheAwareRundownProtection()
Pierre Schweitzer [Sat, 17 Nov 2018 14:36:08 +0000 (15:36 +0100)]
[NTOSKRNL] Implement ExfAcquireRundownProtectionCacheAwareEx(), ExfReleaseRundownProtectionCacheAwareEx()
Pierre Schweitzer [Sat, 17 Nov 2018 14:33:52 +0000 (15:33 +0100)]
[NTOSKRNL] Simplify implementation of ExfAcquireRundownProtectionCacheAware(), ExfReleaseRundownProtectionCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 14:32:10 +0000 (15:32 +0100)]
[NTOSKRNL] Implement ExGetRunRefForCurrentProcessor() to get runref for a proc
Pierre Schweitzer [Sat, 17 Nov 2018 14:25:26 +0000 (15:25 +0100)]
[NTOSKRNL] Implement ExfAcquireRundownProtectionCacheAware(), ExfReleaseRundownProtectionCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 14:03:43 +0000 (15:03 +0100)]
[NTOSKRNL] Implement ExSizeOfRundownProtectionCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 14:01:05 +0000 (15:01 +0100)]
[NTOSKRNL] Implement ExInitializeRundownProtectionCacheAware()
Pierre Schweitzer [Sat, 17 Nov 2018 13:48:24 +0000 (14:48 +0100)]
[NTOSKRNL] Implement ExAllocateCacheAwareRundownProtection() and ExFreeCacheAwareRundownProtection()
Bișoc George [Sat, 17 Nov 2018 14:16:36 +0000 (15:16 +0100)]
[CHKDSK] Implement translation files for Romanian & Italian (#961)
Bernhard Feichtinger [Fri, 16 Nov 2018 22:26:58 +0000 (23:26 +0100)]
[MODULES] Add a convenient option to transfer files into a new installation (#877)
Purpose:
When doing a PXE BootCD installation, you may be left without networking, usb and a cd drive.
This adds an easy way to include a few or more files to the installation which are then present on the disk after the installation and which does not require any change to ReactOS source code/build script files (and no manual editing of boot/bootdata/packages/reactos.dff.in).
Proposed changes:
Adds a new modules/3rdparty folder which lets the files end up in C:\ReactOS\3rdParty ready for use.
Bișoc George [Fri, 16 Nov 2018 22:09:15 +0000 (23:09 +0100)]
[SHELL32] Print out the error code (#973)
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
Ștefan Fulea [Fri, 16 Nov 2018 22:05:51 +0000 (00:05 +0200)]
[MSPAINT] Fix scrollbar presence on canvas/view fitting (#878)
* [MSPAINT] Fix scrollbar presence on canvas/view fitting
This is a small fix for a scrollbar related edge case functionality exhibited in mspaint (and in a lesser degree also elsewhere in instances of) scrollbar controlled content. As known, the scrollbars presence is given by the size ratio between the accommodating outer frame and the scroll-controlled contents inside it, and it works for the most part. There is, however, a case where the presence of both toolbars is kept even when the contents would fit the frame (if not for the scrollbars themselves that increase the size of the contents' area). Please take the current commit as a demo fix and a provisional correction for mspaint (as I think that the proper fix should reside in common controls).
* [MSPAINT] Fix a small mistake and improve readability in UpdateScrollbox()
Although with no visible impact on testing, I've used a wrong constant related to vertical scrollbox width in one instance (SM_CXHSCROLL instead of SM_CXVSCROLL), and this fixes it. Also, prefer using constants, to improve a bit readability and performance (by avoiding repeated function calls).
Eric Kohl [Fri, 16 Nov 2018 21:21:55 +0000 (22:21 +0100)]
[MC] Add messages 3190-3299. The first NELOG range is done.
Eric Kohl [Fri, 16 Nov 2018 21:00:15 +0000 (22:00 +0100)]
[PSDK] Add missing NELOG-codes to lmerrlog.h
Pierre Schweitzer [Fri, 16 Nov 2018 21:02:46 +0000 (22:02 +0100)]
[ACGENRAL] Don't leak memory on failure in InitIgnoreFreeLibrary()
CID
1441306
Pierre Schweitzer [Fri, 16 Nov 2018 20:52:38 +0000 (21:52 +0100)]
[COMCTL32] Don't leak memory in CB_ThemedPaint()
CID
1441313
Pierre Schweitzer [Fri, 16 Nov 2018 20:42:42 +0000 (21:42 +0100)]
[WIN32SS] Don't leak memory on failure in IntGdiWidenPath().
CID
1441350
Pierre Schweitzer [Fri, 16 Nov 2018 20:36:07 +0000 (21:36 +0100)]
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List().
CID
1441357
Pierre Schweitzer [Fri, 16 Nov 2018 20:28:42 +0000 (21:28 +0100)]
[WIN32SS] Avoid an user-after-free in FontFamilyFillInfo().
CID
1441367
Pierre Schweitzer [Fri, 16 Nov 2018 20:22:50 +0000 (21:22 +0100)]
[COMCTL32] Don't leak memory in PB_ThemedPaint()
CID
1441373
Pierre Schweitzer [Fri, 16 Nov 2018 20:12:10 +0000 (21:12 +0100)]
[NTOSKRNL] Properly check for negative values in IoCheckEaBufferValidity()
CID
1441355,
1441382
Pierre Schweitzer [Fri, 16 Nov 2018 19:00:30 +0000 (20:00 +0100)]
[SYSSETUP] Fix error message in ApplyRegistryValues()
CID
1441398
Pierre Schweitzer [Fri, 16 Nov 2018 18:35:36 +0000 (19:35 +0100)]
[FASTFAT] Properly return failure in vfatFindDirSpace()
CID
1441394
Ercan Ersoy [Fri, 16 Nov 2018 15:59:09 +0000 (18:59 +0300)]
[TRANSLATION] Add/update Turkish translations. (#1043)
Add or update Turkish translations for: CHKDSK, DISKPART, FORMAT, SUBST and WINLOGON.
Katayama Hirofumi MZ [Fri, 16 Nov 2018 00:32:41 +0000 (09:32 +0900)]
[SYSTEMINFO] Fix Chinese resource to fix MSVC2010 build (#1041)
Eric Kohl [Thu, 15 Nov 2018 21:38:35 +0000 (22:38 +0100)]
[MC] Add messages 3150-3186 and 3530-3547 to netmsg.dll.
Giannis Adamopoulos [Thu, 15 Nov 2018 19:24:56 +0000 (21:24 +0200)]
[SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file
CORE-15353
Pako Smith [Thu, 15 Nov 2018 13:15:23 +0000 (16:15 +0300)]
[TRACERT] Fix Coverity #
1434258 "Out-of-Bounds access" (#1038)
Pako Smith [Thu, 15 Nov 2018 10:57:41 +0000 (13:57 +0300)]
[CMD] Fix Coverity #715934 "Copy-paste error" (#1040)
Fix linked-list pointer comparison.
Eric Kohl [Wed, 14 Nov 2018 21:30:19 +0000 (22:30 +0100)]
[MC] Add messages 3100-3141 and 3516-3529 to netmsg.dll.
Luo Yufan [Wed, 14 Nov 2018 12:42:21 +0000 (20:42 +0800)]
[TRANSLATION]Update Simplified Chinese translation. (#1032)