Hermès Bélusca-Maïto [Thu, 2 Nov 2017 22:52:33 +0000 (23:52 +0100)]
[COMCTL32] comctl32/propsheet: Fix redrawing of the static text elements.
Partial revert of SVN r74136 (
b1b4279): enforce the correct "color" for
the background of the static text elements: indeed, using a "transparent"
background kept instead the old window color, which was not correctly
repainted, unless you enforced a repaint by, e.g. moving away then back
the window, or moved something else on top of it.
Tested and approved by 'reactosfanboy'.
Was detected as a regression in the wizard of DVDWrite Now 1.5.12
Formatter GUI.
CORE-13929
CORE-12912
Pierre Schweitzer [Thu, 2 Nov 2017 22:03:08 +0000 (23:03 +0100)]
[RDBSS] Fix a bug in RxQueryNameInfo(): don't only return name length, but also the whole structure. Avoids corruption
Benedikt Freisen [Wed, 1 Nov 2017 13:59:01 +0000 (14:59 +0100)]
[MSPAINT] Base dialog implementations on CDialogImpl
- Wrap implementation of Mirror/Rotate, Stretch/Skew and Attributes dialog in subclasses of CDialogImpl
- Turn global variables from code that was moved into member functions into member variables
- Add global instances of all three dialog classes
- Use <global instance>.DoModal(...) instead of one-line wrappers
- Replace some TCHAR arrays with CStrings
Manuel Bachmann [Thu, 2 Nov 2017 18:55:03 +0000 (19:55 +0100)]
[SHELL32] Fix multiple selection of desktop icons
This fixes the following issue : when selecting multiple icons
on the desktop, and then right-clicking; the Properties sheet
would immediately be displayed, conflicting with the context
menu.
Giannis Adamopoulos [Thu, 2 Nov 2017 17:50:03 +0000 (19:50 +0200)]
[BROWSEUI] Add a todo comment block in CISFBand.cpp and CBandSite.cpp regarding some problems and missing features when using the quick launch toolbar. These two lists are not complete but cover most important problems of quick launch. There is no need to create bug reports for these.
Mark Jansen [Sun, 22 Oct 2017 20:25:03 +0000 (22:25 +0200)]
[ATL] Initial implementation of CAtlExeModuleT.
CORE-13908
Pierre Schweitzer [Wed, 1 Nov 2017 14:12:08 +0000 (15:12 +0100)]
[RDBSS] More capture
Pierre Schweitzer [Wed, 1 Nov 2017 10:45:43 +0000 (11:45 +0100)]
[RDBSS] Start defining the RxCapture* macros and start using them (to be continued)
Pierre Schweitzer [Wed, 1 Nov 2017 10:20:28 +0000 (11:20 +0100)]
[RXCE] Implement RxInitializeDebugSupport()
Pierre Schweitzer [Wed, 1 Nov 2017 10:05:32 +0000 (11:05 +0100)]
[RDBSS] Implement RxCheckFcbStructuresForAlignment()
Giannis Adamopoulos [Mon, 30 Oct 2017 15:39:12 +0000 (17:39 +0200)]
[EXPLORER] -Rewrite taskbar settings routines and dialog
- Rewrite the taskbar settings and start menu settings property sheets.
- All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later.
- Implement toggling lock, autohide and always on top. The rest will be implemented later.
Pierre Schweitzer [Tue, 31 Oct 2017 22:03:16 +0000 (23:03 +0100)]
[RDBSS] Implement RxQueryNameInfo() and RxConjureOriginalName()
Pierre Schweitzer [Tue, 31 Oct 2017 20:34:36 +0000 (21:34 +0100)]
[RXCE] Implement RxAcquireExclusiveFcbResourceInMRx()
Amine Khaldi [Tue, 31 Oct 2017 14:44:39 +0000 (15:44 +0100)]
[SERIAL] Fix Serial{Get,Clear}PerfStats() to become proper PKSYNCHRONIZE_ROUTINE routines and get rid of the related casts. Brought to you by Thomas Faber. CORE-11799 (#94)
Amine Khaldi [Tue, 31 Oct 2017 14:19:49 +0000 (15:19 +0100)]
[XDK][DDK] Take the gcc path for __assert_annotation{A,W} and __CREATE_NTOS_DATA_IMPORT_ALIAS when compiling with clang-cl. Include kdfuncs.h before rtlfuncs.h to have DbgPrint() defined before using it. CORE-11799 (#94)
Amine Khaldi [Tue, 31 Oct 2017 13:44:07 +0000 (14:44 +0100)]
[LIB/ATL] Take the gcc code path for the unused macros when compiling with clang. CORE-11799 (#94)
Eric Kohl [Tue, 31 Oct 2017 13:09:04 +0000 (14:09 +0100)]
[STORPORT] Check status code of the call to PortFdoConnectInterrupt().
CORE-13866
Amine Khaldi [Tue, 31 Oct 2017 13:10:03 +0000 (14:10 +0100)]
[LIBXML2] Do not rely on nan() when compiling with clang. CORE-11799 (#94)
Amine Khaldi [Tue, 31 Oct 2017 12:54:41 +0000 (13:54 +0100)]
[XDK/NTBASEDEF] Use __builtin_offsetof to define FIELD_OFFSET when compiling with clang-cl. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 21:51:00 +0000 (22:51 +0100)]
[CRT/INTRIN] Use the gcc intrinsic equivalents when compiling with clang-cl and skip the ones that are already supported/built-in. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 21:45:42 +0000 (22:45 +0100)]
[ACPICA] Take the gcc code path for host configuration when compiling with clang. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 21:43:47 +0000 (22:43 +0100)]
[INCLUDE/REACTOS][LOCALMON][LOCALSPL][SPOOLSS] Add some missing VOIDs. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 21:38:29 +0000 (22:38 +0100)]
[LIBSAMPLERATE] Define exit() as __debugbreak(). CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:54:54 +0000 (21:54 +0100)]
[NMIDEBUG] Do not take the msvc codepath in NmiClearFlag(). CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:53:00 +0000 (21:53 +0100)]
[SHELL32] Properly set case -714 as TBN_DRAGOUT. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:51:30 +0000 (21:51 +0100)]
[BOOT/ENVIRON] Define the INT8 type as signed char. CORE-11799 (#94)
Amine Khaldi [Mon, 30 Oct 2017 20:48:49 +0000 (21:48 +0100)]
[SERIALUI] Set the stdcall calling convention for CommDlgProc() and make it return INT_PTR. CORE-11799 (#94)
Thomas Faber [Fri, 27 Oct 2017 10:32:26 +0000 (12:32 +0200)]
[SHELL32][REGEDIT][MSCONFIG_NEW] Correctly check for presence of list view sort header.
Marian Schubert [Sun, 29 Oct 2017 20:38:05 +0000 (21:38 +0100)]
[NET] Add missing newlines to net utility output (#91)
Password last set and Password changeable lines were missing newlines.
Pierre Schweitzer [Sun, 29 Oct 2017 19:34:49 +0000 (20:34 +0100)]
[KERNEL32] Fix a FIXME in WaitNamedPipeW(): allow waiting on a remote pipe
Pierre Schweitzer [Sun, 29 Oct 2017 14:03:12 +0000 (15:03 +0100)]
[RTL] Revert
b3b2a23 which introduced a regression.
Spotted by Jérome
Pierre Schweitzer [Sun, 29 Oct 2017 13:48:41 +0000 (14:48 +0100)]
[KERNEL32] In GetLogicalDrives(), if NtQueryInformationProcess() call succeed, but return drive map is empty, make sure returned error is success.
Patch by Alex Ionescu
Samuel Serapion [Fri, 20 Oct 2017 18:00:32 +0000 (14:00 -0400)]
CID
1206831 Dereference after null check
BytesRead is an optional out parameter and must be checked before being written to.
Serge Gautherie [Sat, 28 Oct 2017 15:02:24 +0000 (17:02 +0200)]
[MOUNTMGR][NTOSKRNL] ZwWriteFile() calls: Use explicit NULL instead of ambiguous 0. CORE-13910
Alexander Shaposhnikov [Sat, 28 Oct 2017 20:44:17 +0000 (23:44 +0300)]
[RAPPS] Prevent download dialog placeholder from displaying
CORE-13915
Giannis Adamopoulos [Sat, 28 Oct 2017 19:09:44 +0000 (22:09 +0300)]
[EXPLORER] CSysPagerWnd: Notify the CTrayWindow to reposition its children only when the number of the icons shown in the notification area changes.
Giannis Adamopoulos [Sat, 28 Oct 2017 16:23:49 +0000 (19:23 +0300)]
[EXPLORER] Simplify how autohide is implemented
Do not change m_TrayRects when m_AutoHideOffset is changed. m_AutoHideOffset will be taken into account only while WM_WINDOWPOSCHANGING is processed
Amine Khaldi [Sat, 28 Oct 2017 14:19:17 +0000 (15:19 +0100)]
[NTOS] Add missing brackets. Comment out some unused statements. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 14:04:18 +0000 (15:04 +0100)]
[BROWSEUI][DEVMGR][EXPLORER][NTGDI][NTOBJSHEX][NTVDM][SETUPAPI] Remove/comment out some unused variables. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 13:43:14 +0000 (14:43 +0100)]
[SPOOLSV] Add some missing VOIDs. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 13:06:01 +0000 (14:06 +0100)]
[GLU32] Add TrimRegion destructor when compiling with clang-cl. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 12:56:32 +0000 (13:56 +0100)]
[OPENGL32] Set the stdcall calling convention for wglGetDHGLRC(). CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 12:52:44 +0000 (13:52 +0100)]
[UDFS] Do not take some of the msvc codepaths when compiling with clang-cl due to issues such as inline assembly support. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 12:46:11 +0000 (13:46 +0100)]
[NTDLL][NTUSER][SPOOLSS][WINSPOOL] Add some missing VOIDs. CORE-11799 (#94)
Amine Khaldi [Sat, 28 Oct 2017 12:34:43 +0000 (13:34 +0100)]
[CRT/INTRIN] Use __forceinline for __INTRIN_INLINE in the clang case. CORE-11799 (#94)
zefklop [Sat, 28 Oct 2017 08:28:27 +0000 (10:28 +0200)]
[CRT] fix bug in _rotr implementation
Amine Khaldi [Fri, 27 Oct 2017 22:55:59 +0000 (23:55 +0100)]
[INCLUDE/WINE] Use __builtin_ffs in the clang-cl build. CORE-11799 (#94)
Amine Khaldi [Fri, 27 Oct 2017 22:51:44 +0000 (23:51 +0100)]
[SHELL32] Remove some unused members and comment out some unused Wine code. CORE-11799 (#94)
Amine Khaldi [Fri, 27 Oct 2017 22:47:30 +0000 (23:47 +0100)]
[MSAFD] Properly define SockAsyncThread() and avoid the cast. CORE-11799 (#94)
Amine Khaldi [Fri, 27 Oct 2017 22:42:40 +0000 (23:42 +0100)]
[SHSVCS] Add missing VOID. CORE-11799 (#94)
Alexander Shaposhnikov [Fri, 27 Oct 2017 18:25:24 +0000 (21:25 +0300)]
[RAPPS] Removed redundant static_cast
Alexander Shaposhnikov [Sat, 21 Oct 2017 21:52:49 +0000 (00:52 +0300)]
[RAPPS] Make CConfigParser a temp object.
Alexander Shaposhnikov [Sat, 21 Oct 2017 21:00:50 +0000 (00:00 +0300)]
[RAPPS] Replace pointer array with object array in parts related to app DL.
Serge Gautherie [Wed, 25 Oct 2017 11:57:27 +0000 (13:57 +0200)]
[NTOSKRNL][ROSSYM] ZwReadFile() calls: Use explicit NULL instead of ambiguous 0. CORE-13910
Giannis Adamopoulos [Fri, 27 Oct 2017 06:38:34 +0000 (09:38 +0300)]
[VERSION.CMAKE] Bump the version to 0.4.8-dev
Alexander Shaposhnikov [Thu, 26 Oct 2017 22:29:28 +0000 (01:29 +0300)]
CONTRIBUTING.md: Add legal notice
David Quintana [Thu, 26 Oct 2017 20:33:16 +0000 (22:33 +0200)]
[EXPLORER] Update start menu banner to match our new versioning scheme for the master branch
Timo Kreuzer [Sun, 22 Oct 2017 12:56:52 +0000 (14:56 +0200)]
[NTOSKRNL] Fix out-of-bounds access (CID-
1401083) and potencial memory leak in FsRtlIsNameInExpressionPrivate
Timo Kreuzer [Wed, 11 Oct 2017 12:20:57 +0000 (14:20 +0200)]
[NTOSKRNL] Fix our-of-bounds access and memory leak (CID-
1401178,
1401177) in FsRtlIsDbcsInExpression
Giannis Adamopoulos [Thu, 26 Oct 2017 18:39:32 +0000 (21:39 +0300)]
[SHELL32] CDefView: Fix a leak of an HMENU. This fix is thanks to Joachim Henze who found the bug and quickly found the guilty revision. CORE-13911
Giannis Adamopoulos [Mon, 23 Oct 2017 15:56:57 +0000 (18:56 +0300)]
[ACPPAGE] Convert CLayerUIPropPage to use CPropertyPageImpl
Giannis Adamopoulos [Mon, 23 Oct 2017 20:41:47 +0000 (23:41 +0300)]
Add CPropertyPageImpl that allows us to make property pages object oriented
Giannis Adamopoulos [Mon, 23 Oct 2017 15:56:35 +0000 (18:56 +0300)]
[ATL] Add CHAIN_MSG_MAP macro
Katayama Hirofumi MZ [Wed, 25 Oct 2017 09:10:36 +0000 (18:10 +0900)]
[WIN32SS] fix font extent.
CORE-13840
Ged Murphy [Wed, 25 Oct 2017 09:39:55 +0000 (10:39 +0100)]
[KMTEST] Initial usermode support for testing FS mini-filters (#81)
* [KMTEST] Initial usermode support for testing FS mini-filters
- Add base routines to wrap the win32 'Filter' APis
- Add support routines to be used when testing FS filter drivers
- Move KmtCreateService to a private routine so it can be shared with KmtFltCreateService
- Completely untested at the mo, so likely contains bugs at this point
Eric Kohl [Mon, 23 Oct 2017 21:21:58 +0000 (23:21 +0200)]
[STORPORT] Get the interrupt from the resource list, connect it and call the miniports HwInterrupt routine.
CORE-13866
Serge Gautherie [Mon, 23 Oct 2017 19:18:27 +0000 (21:18 +0200)]
CORE-13048. [I8042PRT] keyboard.c: Restore 1 "Irql =" (which was lost in r30000). (#63)
[I8042PRT] Restore 1 "Irql =" (which was lost in r30000). CORE-13048
Alexander Shaposhnikov [Mon, 23 Oct 2017 16:28:15 +0000 (19:28 +0300)]
[CONFIGURE] Add -VS_VER flag (#86)
This flag can override the detected version of VS.
Usage example: `configure.cmd vssolution -VS_VER 14`
Pierre Schweitzer [Mon, 23 Oct 2017 15:25:19 +0000 (17:25 +0200)]
[KERNEL32] Fix MSVC build
Pierre Schweitzer [Mon, 23 Oct 2017 15:08:50 +0000 (17:08 +0200)]
[KERNEL32] Implement NpGetUserNamep()
Amine Khaldi [Sat, 21 Oct 2017 13:36:29 +0000 (14:36 +0100)]
[NTDLL_WINETEST] Sync with Wine Staging 2.16. CORE-13762
Amine Khaldi [Sat, 21 Oct 2017 13:28:54 +0000 (14:28 +0100)]
[INCLUDE/WINE] Update winternl.h. CORE-13762
Amine Khaldi [Sat, 21 Oct 2017 12:57:10 +0000 (13:57 +0100)]
[REGEDIT_WINETEST] Sync with Wine Staging 2.16. CORE-13762
Amine Khaldi [Sat, 21 Oct 2017 12:29:32 +0000 (13:29 +0100)]
[QEDIT_WINETEST] Sync with Wine Staging 2.16. CORE-13762
Amine Khaldi [Sat, 21 Oct 2017 12:24:28 +0000 (13:24 +0100)]
[PSAPI_WINETEST] Sync with Wine Staging 2.16. CORE-13762
Amine Khaldi [Sat, 21 Oct 2017 12:19:43 +0000 (13:19 +0100)]
[OPENGL32_WINETEST] Sync with Wine Staging 2.16. CORE-13762
Samuel Serapion [Fri, 20 Oct 2017 15:03:07 +0000 (11:03 -0400)]
[CRT] Use MAX_PATH for buffer meant to contain an arbitrary path
The cFileName member of WIN32_FIND_DATA is an array of MAX_PATH(260). Using strcpy/wcscpy with the target buffer being smaller is potentially bad. Corresponds to CID
1401198 and
1401195.
Pierre Schweitzer [Mon, 23 Oct 2017 12:36:18 +0000 (14:36 +0200)]
[KERNEL32] Fix a FIXME in GetNamedPipeHandleStateW and stub a private function for a left unimplemented function
Pierre Schweitzer [Mon, 23 Oct 2017 11:39:44 +0000 (13:39 +0200)]
[KERNEL32] Check Basep8BitStringToDynamicUnicodeString() return and only call -W in case of success
CID
1419330
Pierre Schweitzer [Mon, 23 Oct 2017 10:36:43 +0000 (12:36 +0200)]
[KERNEL32] Check NtQueryInformationFile succeed before using its return. Also fix coding style
CID 512966
Pierre Schweitzer [Mon, 23 Oct 2017 08:30:27 +0000 (10:30 +0200)]
[FFS] Don't leak on failure
CID
1363596
Pierre Schweitzer [Mon, 23 Oct 2017 08:25:40 +0000 (10:25 +0200)]
[FFS] Don't leak memory on volume mount
CID
1363583
Pierre Schweitzer [Mon, 23 Oct 2017 08:21:32 +0000 (10:21 +0200)]
[FFS] Don't allocate (and leak :-)) an unused event
CID
1363607
Giannis Adamopoulos [Sun, 22 Oct 2017 21:32:52 +0000 (00:32 +0300)]
[EXPLORER] Reduce the spam due to the broken CBandSite in browseui
Pierre Schweitzer [Sun, 22 Oct 2017 20:51:02 +0000 (22:51 +0200)]
[REISERFS] Don't leak on failure
CID
1363597
Pierre Schweitzer [Sun, 22 Oct 2017 20:40:21 +0000 (22:40 +0200)]
[REISERFS] Don't leak on failure
CID
1363593
Pierre Schweitzer [Sun, 22 Oct 2017 20:30:22 +0000 (22:30 +0200)]
[REISERFS] Don't allocate (and leak :-)) an unused event
CID
1363603
Mark Jansen [Fri, 20 Oct 2017 22:25:36 +0000 (00:25 +0200)]
[ATL] Implement CDialogImpl
CORE-13903
Giannis Adamopoulos [Sun, 22 Oct 2017 15:59:01 +0000 (18:59 +0300)]
[BROWSEUI] CBandSiteMenu: Use CSimpleArray and CComHeapPtr.
Giannis Adamopoulos [Fri, 20 Oct 2017 16:41:01 +0000 (19:41 +0300)]
[BROWSEUI] Improve CBandSiteBase::OnWinEvent to forward messages correctly to the child bands.
Giannis Adamopoulos [Fri, 20 Oct 2017 13:23:17 +0000 (16:23 +0300)]
[BROWSEUI] Add a hack and abuse ISFB_STATE_QLINKSMODE to make the quick launch band to be aligned to left and show no text
Giannis Adamopoulos [Fri, 20 Oct 2017 13:21:13 +0000 (16:21 +0300)]
[BROWSEUI] CISFBand: Misc fixes
- Slightly improve the implementation of IShellFolderBand
- Show both folders and files in the toolbar
- Use the name of the folder shown as the name of the band
Giannis Adamopoulos [Fri, 20 Oct 2017 13:17:10 +0000 (16:17 +0300)]
[BROWSEUI] CBandSiteMenu: Implement the Desktop, Quick Launch and New Toolbar menu items
Giannis Adamopoulos [Fri, 20 Oct 2017 13:08:52 +0000 (16:08 +0300)]
[BROWSEUI] CBandSiteMenu: Fix two broken loops
Giannis Adamopoulos [Fri, 20 Oct 2017 13:04:15 +0000 (16:04 +0300)]
[BROWSEUI] Enable the menu items for the toolbars submenu of the CBandSiteMenu. Also add a new string which will be used in the next commit.
Giannis Adamopoulos [Fri, 20 Oct 2017 13:02:13 +0000 (16:02 +0300)]
[BROWSEUI] Rename CISFBand_CreateInstance and add a CISFBand_CreateInstance macro that makes easy to switch between the system implementation or the local one.
Giannis Adamopoulos [Fri, 20 Oct 2017 12:53:16 +0000 (15:53 +0300)]
[PSDK] Add some missing definitions from IShellFolderBand
Timo Kreuzer [Sun, 22 Oct 2017 15:31:42 +0000 (17:31 +0200)]
[STORPORT] Fix x64 build
Timo Kreuzer [Thu, 19 Oct 2017 08:18:19 +0000 (10:18 +0200)]
[REACTOS] Fix x64 build
- SIZE_T -> ULONG in KsecGatherEntropyData
- Add missing ZwQueryInformationProcess() prototype for x64 build of btrfs
- Fix ml.exe path for VS 2017 Community Edition
- Add missing Handle32ToHandle to basetsd.h
Timo Kreuzer [Sat, 7 Oct 2017 14:11:52 +0000 (16:11 +0200)]
[NDK] Add tests for TEB