Thomas Faber [Tue, 26 Nov 2013 14:26:31 +0000 (14:26 +0000)]
[KMTESTS:RTL]
- Fix a warning
svn path=/trunk/; revision=61099
Thomas Faber [Tue, 26 Nov 2013 13:45:33 +0000 (13:45 +0000)]
[NTOS]
- FORCEINLINE belongs before the return type (-Wold-style-declaration)
svn path=/trunk/; revision=61098
Eric Kohl [Mon, 25 Nov 2013 16:00:40 +0000 (16:00 +0000)]
[NETAPI32]
Refactor BuildUserInfoBuffer: Move the user info buffer inside of BuildUserInfoBuffer. This simplifies its callers.
svn path=/trunk/; revision=61097
Thomas Faber [Mon, 25 Nov 2013 12:30:03 +0000 (12:30 +0000)]
[CMAKE]
- Enable -Wtype-limits in GCC builds
svn path=/trunk/; revision=61096
Timo Kreuzer [Mon, 25 Nov 2013 00:18:33 +0000 (00:18 +0000)]
[NTOSKRNL]
Windows / ReactOS uses a software protection field called protection mask, which is stored inside invalid (Software) PTEs to provide information about the desired protection, when a page is made valid by the page fault handler. The mask consists of the values 0-7 specifying the read/write/execute rights, 0 being inaccessible aka MM_ZERO_ACCESS, plus 2 flag-like bits, for uncached and writecombine memory respectively. Both flags together don't make sense, so this combination is used to mark guard pages. Since all these flags only make sense when used together with a proper access (i.e. not MM_ZERO_ACCESS), the combination of these flags together with MM_ZERO_ACCESS was given special meaning: MM_DECOMMIT, which equals MM_GUARDPAGE | MM_ZERO_ACCESS is for decommitted pages, that are not yet erased to zero, MM_NOACCESS, which is the mask for pages that are mapped with PAGE_NOACCESS (this is to make sure that a software PTE of a committed page is never completely 0, which it could be, when MM_ZERO_ACCESS was used), and finally MM_OUTSWAPPED_KSTACK for outswapped kernel stacks. See also https://www.reactos.org/wiki/Techwiki:Memory_Protection_constants.
The next thing to know is that the number of PTEs that are not null is counted for each PDE. So once a page gets committed, a software PTE is written and the reference count is incremented. When the page is made valid by the fault handler, the count is not changed, when the page is decommitted, the MM_DECOMMIT software PTE is written and again the PTE stays non-null and nothing is changed. Only when the range is cleaned up totally, the PTEs get erased and the reference count is decremented. Now it happened that our page fault handler missed to validate the access rights of protection constants. The problem that came up with this is a major one: since a decommitted page is a software PTE with MM_DECOMMIT as the protection mask (which we remember has the MM_GUARDPAGE bit set), the fault handler considered faults on decommitted PTEs as faults on guard pages and simply removed the guard page flag, leaving a completely empty PTE behind! So the decommitted page got erased without decrementing the reference count. This lead to CORE-7445.
- Add protection flags (MM_GUARDPAGE, MM_WRITECOMBINE, MM_OUTSWAPPED_KSTACK)
- Instead of writing 0 to a PTE, use MI_WRITE_INVALID_PTE with MmZeroPte
- Implement MiIsAccessAllowed that checks for read/write/execute access and use it in MiAccessCheck
- Add some more ASSERTs
CORE-7445 #resolve
svn path=/trunk/; revision=61095
Giannis Adamopoulos [Sun, 24 Nov 2013 21:42:28 +0000 (21:42 +0000)]
[shell32]
- define STR_FILE_SYS_BIND_DATA in the public headers and use it in IFileSystemBindDataImpl and CFSFolder. Now we use the same string to store the IFileSystemBindDataImpl in the bind context.
- Fix CFSFolder::ParseDisplayName to properly parse paths with a IBindCtx
- Should fix creating pidls that represent files that don't exist and fix SHChangeNotify tests that hanged for a whole minute in our test suite
svn path=/trunk/; revision=61094
Thomas Faber [Sun, 24 Nov 2013 20:04:45 +0000 (20:04 +0000)]
[RTL]
- Allow parsing manifest files larger than 32 kB. Fix a DPRINT. Patch by David Quintana.
CORE-7642 #resolve
svn path=/trunk/; revision=61093
Eric Kohl [Sun, 24 Nov 2013 17:24:44 +0000 (17:24 +0000)]
[MSGINA]
- Add a disabled "Change Password" button to the Security dialog.
- Add the "Change Password" dialog and a basic dialog function.
svn path=/trunk/; revision=61092
Thomas Faber [Sun, 24 Nov 2013 16:22:17 +0000 (16:22 +0000)]
[NPFS]
- Fix a use after free in NpFsdCreate
svn path=/trunk/; revision=61091
Timo Kreuzer [Sun, 24 Nov 2013 16:18:50 +0000 (16:18 +0000)]
[NTOSKRNL]
Remove deprecated and unused functions MmDisableVirtualMapping and MmRawDeleteVirtualMapping
svn path=/trunk/; revision=61090
Timo Kreuzer [Sun, 24 Nov 2013 15:54:03 +0000 (15:54 +0000)]
[NTOSKRNL]
Try to fix the failed assertions in testbot
svn path=/trunk/; revision=61089
Timo Kreuzer [Sun, 24 Nov 2013 12:51:45 +0000 (12:51 +0000)]
[NTOSKRNL]
Make use of MiQueryPageTableReferences
svn path=/trunk/; revision=61088
Thomas Faber [Sun, 24 Nov 2013 09:26:24 +0000 (09:26 +0000)]
[NTOS:MM]
- Add missing \n to DPRINT in MmGetPhysicalAddress
svn path=/trunk/; revision=61087
Timo Kreuzer [Sat, 23 Nov 2013 22:34:20 +0000 (22:34 +0000)]
[NTOSKRNL]
- Use MI_IS_MAPPED_PTE instead of unportable bit fiddling
- Use MiDecrementPageTableReferences instead of manually messing with MmWorkingSetList, which is not portable
- Make MmGetPhysicalAddress portable
svn path=/trunk/; revision=61086
Eric Kohl [Sat, 23 Nov 2013 22:08:48 +0000 (22:08 +0000)]
[FORMATTING]
Fix indentation. No code changes!
svn path=/trunk/; revision=61085
Eric Kohl [Sat, 23 Nov 2013 18:36:05 +0000 (18:36 +0000)]
[FORMATTING]
Fix indentation. No code changes!
svn path=/trunk/; revision=61084
Timo Kreuzer [Sat, 23 Nov 2013 01:42:33 +0000 (01:42 +0000)]
Revert a change from the previous version. MI_WRITE_VALID_PTE only works on invalid PTEs. Thanks to Thomas for noticing.
svn path=/trunk/; revision=61083
Timo Kreuzer [Sat, 23 Nov 2013 00:43:06 +0000 (00:43 +0000)]
[NTOSKRNL]
- Add hacks to MmMapViewInSessionSpace and MmUnmapViewInSessionSpace to check for legacy (non ARM3) sections (image sections) and (un)map them in system space instead.
- Fix MmCommitSessionMappedView (it wasn't resetting the PointerPte to the start, when processing the PTE range a second time)
- Remove an ASSERT that didn't allow unmapping session space mappings, since that works (see CORE-6729)
- Change a write to a PTE to using MI_WRITE_VALID_PTE
svn path=/trunk/; revision=61081
Hermès Bélusca-Maïto [Fri, 22 Nov 2013 22:59:19 +0000 (22:59 +0000)]
[REGEDIT]
- Fix few French resources.
- Support F2 key for renaming keys/values.
Patch by Edijs Kolesnikovics
CORE-7615 #resolve #comment Committed in revision 61080. Thanks!
svn path=/trunk/; revision=61080
James Tabor [Fri, 22 Nov 2013 18:45:58 +0000 (18:45 +0000)]
- Move ATI from stub file. Applications like Magnifier uses it but it seems to return an error.
svn path=/trunk/; revision=61079
James Tabor [Fri, 22 Nov 2013 17:07:02 +0000 (17:07 +0000)]
- Fix condition when window is null while in event. See CORE-7635.
svn path=/trunk/; revision=61078
Timo Kreuzer [Fri, 22 Nov 2013 15:23:18 +0000 (15:23 +0000)]
[NTOSKRNL]
Fix / improve NtQueryDefaultLocale, NtSetDefaultLocale, NtQueryDefaultUILanguage and NtSetDefaultUILanguage
svn path=/trunk/; revision=61077
Timo Kreuzer [Fri, 22 Nov 2013 12:51:40 +0000 (12:51 +0000)]
[NTOSKRNL]
Skip all images that were loaded using MmLoadSystemImage in MiFindInitializationCode. Drivers loaded by Mm are handled in MmFreeDriverInitialization (which we currently run for boot loaded images as well, so duplicated work...). But now at least session loaded images are NOT processed this way. Because even though they can have INIT sections, they don't neccessarily like it when stuff gets removed, especially win32k doesn't like it when it's .rsrc section is being discarded due to it's section flags!
svn path=/trunk/; revision=61076
Timo Kreuzer [Fri, 22 Nov 2013 12:23:11 +0000 (12:23 +0000)]
[NTOSKRNL]
Check the PTE as well in MmArmAccessFault, when we are at high IRQL and fail if it's not valid. Otherwise we just end up in an endless loop.
svn path=/trunk/; revision=61075
Timo Kreuzer [Fri, 22 Nov 2013 12:14:47 +0000 (12:14 +0000)]
[NTOSKRNL]
Fix MmGetSessionLocaleId and implement MmSetSessionLocaleId
svn path=/trunk/; revision=61074
Timo Kreuzer [Fri, 22 Nov 2013 12:10:20 +0000 (12:10 +0000)]
[NTOSKRNL]
Fix an off-by-one error in an ASSERT in MiDecrementReferenceCount (MmHighestPhysicalPage itself is still a valid PFN)
svn path=/trunk/; revision=61073
Timo Kreuzer [Fri, 22 Nov 2013 11:48:51 +0000 (11:48 +0000)]
[NTOSKRNL/WIN32K]
Always call the win32 process callout from PsConvertToGuiThread and handle the case where we alrady have an allocated win32 process there. (The original win32k sometimes allocates a win32 process, but doesn't initialize it, so it needs to be called again to do so)
svn path=/trunk/; revision=61072
Timo Kreuzer [Fri, 22 Nov 2013 11:36:22 +0000 (11:36 +0000)]
[VIDEOPRT]
Handle IOCTL_VIDEO_USE_DEVICE_IN_SESSION
svn path=/trunk/; revision=61071
Dmitry Gorbachev [Thu, 21 Nov 2013 20:44:49 +0000 (20:44 +0000)]
[NTOSKRNL]
Trick GCC into not optimizing out RtlMoveMemory.
svn path=/trunk/; revision=61066
Giannis Adamopoulos [Thu, 21 Nov 2013 11:34:56 +0000 (11:34 +0000)]
forgot to commit this
svn path=/trunk/; revision=61065
Giannis Adamopoulos [Thu, 21 Nov 2013 11:28:53 +0000 (11:28 +0000)]
[explorer_new]
- call ShellDDEInit, FileIconInit and WinList_Init while initializing
- Calling ShellDDEInit fixes cases like pressing Explore in a folder context menu from a file open dialog (before this it just hanged)
- We also need to call FileIconInit in order to initialize the shell icons properly. Before this Shell_GetImageLists called FileIconInit in case it was not called
- Calling WinList_Init should make CLSID_ShellWindows work but it fails for now. CLSID_ShellWindows is needed in cases like opening a second time My computer from desktop should activates the existing My computer window and it is also needed for SHOpenFolderAndSelectItems in order to work
svn path=/trunk/; revision=61064
Timo Kreuzer [Wed, 20 Nov 2013 23:50:42 +0000 (23:50 +0000)]
{NTOSKRNL]
Properly implement MmGetSessionById, MmAttachSession, MmDetachSession and MmQuitNextSession. Implement more session cleanup code and make sure a session is not killed while a process is attached to it. There used to be a bug, where removing a process from the session list caused pool corruption, which was because we called MiSessionRemoveProcess twice: once from PspExitThread, when the last thread exited and another time from PspDeleteProcess, when the reaper thread deleted the process object. This was, because the flag that said the process was in a session was not cleared properly. This is now fixed and inserting and removing processes into the session's list works fine. Also protect it properly with a spinlock.
svn path=/trunk/; revision=61061
Timo Kreuzer [Wed, 20 Nov 2013 21:57:51 +0000 (21:57 +0000)]
[I8042PRT]
Hackplement support for IOCTL_KEYBOARD_QUERY_ATTRIBUTES
svn path=/trunk/; revision=61060
Timo Kreuzer [Wed, 20 Nov 2013 21:52:50 +0000 (21:52 +0000)]
[NTOSKRNL]
Implement ObDeleteCapturedInsertInfo
svn path=/trunk/; revision=61059
Timo Kreuzer [Tue, 19 Nov 2013 23:36:57 +0000 (23:36 +0000)]
[DXG]
Fix DxDdSuspendDirectDraw prototype.
svn path=/trunk/; revision=61054
Timo Kreuzer [Tue, 19 Nov 2013 23:30:58 +0000 (23:30 +0000)]
[KEYBOARDLEYOUTS]
Keyboard layout files have special requirements to the section layout of the dell. That is because MS win32k devs didn't write proper code and that is why the original win32k first parses all sections, looks for the .data section, checks if everything is valid and then truncates a pointer in a table to 16 bit and uses this as an offset into the section. Of course that does ONLY work, if the section is the first section AND that pointer happens to be less than 64k off from the start of the section AND the image base is 64k aligned. To achieve this, add a new module type kbdlayout that does all the neccessary things. On MSVC we merge the sections with a linker command, on GCC we use a custom linker script.
svn path=/trunk/; revision=61053
Timo Kreuzer [Tue, 19 Nov 2013 23:09:13 +0000 (23:09 +0000)]
[NTOSKRNK]
Implement ExpWin32SessionCallout, which attaches to the session that the object (desktop or window station) belongs to before invoking any callbacks. The session side of support for this is currently hardcoded to support only a single session. To make this properly work, all callbacks that go through this function have the same function pointer type now, fix this in win32k accordingly.
svn path=/trunk/; revision=61052
Hermès Bélusca-Maïto [Tue, 19 Nov 2013 21:20:13 +0000 (21:20 +0000)]
[REGEDIT]
Disable Delete/Rename menu options for root nodes ("My Computer" and HKEY_* keys).
Patch by Edijs Kolesnikovics.
CORE-7602 #resolve #comment Committed in revision 61051, thanks :)
svn path=/trunk/; revision=61051
Timo Kreuzer [Tue, 19 Nov 2013 21:13:31 +0000 (21:13 +0000)]
[NTOSKRNL]
Move session routines into session.c. No code change.
svn path=/trunk/; revision=61050
Giannis Adamopoulos [Tue, 19 Nov 2013 20:53:16 +0000 (20:53 +0000)]
[shell32]
- Implement cut and paste shortcut
- Patch by Huw Campbell
- CORE-7548
svn path=/trunk/; revision=61049
Giannis Adamopoulos [Tue, 19 Nov 2013 19:05:17 +0000 (19:05 +0000)]
[shell32]
- Append class members with m_ in CDefView class
svn path=/trunk/; revision=61048
Thomas Faber [Tue, 19 Nov 2013 10:18:02 +0000 (10:18 +0000)]
[NOTEPAD]
- Preserve modification flag when toggling the "Word Wrap" option. Patch by Edijs Kolesnikovičs.
CORE-7589 #resolve
svn path=/trunk/; revision=61047
Eric Kohl [Mon, 18 Nov 2013 22:16:16 +0000 (22:16 +0000)]
[EVENTLOG]
ElfrClearELFW: Fail, if the log file is a backup file.
svn path=/trunk/; revision=61046
Dmitry Gorbachev [Mon, 18 Nov 2013 22:00:12 +0000 (22:00 +0000)]
[NTOSKRNL]
Do not call RtlCopyMemory (i.e. memcpy/memmove) with NULL pointer, which
gives undefined behavior.
svn path=/trunk/; revision=61045
Thomas Faber [Mon, 18 Nov 2013 20:24:18 +0000 (20:24 +0000)]
[RAPPS]
- Fix info display on selection change. Patch by Carlo Bramini.
CORE-6139 #resolve
svn path=/trunk/; revision=61043
Thomas Faber [Mon, 18 Nov 2013 19:02:56 +0000 (19:02 +0000)]
[D3DCOMPILER_43]
- Fix MSVC warnings (yes I know these are generated files. It's a flex bug)
svn path=/trunk/; revision=61042
Timo Kreuzer [Mon, 18 Nov 2013 17:47:37 +0000 (17:47 +0000)]
[NTOSKRNL]
Implement PoQueueShutdownWorkItem, PoRequestShutdownEvent, PoRequestShutdownWait, PopProcessShutDownLists. One step closer to ... proper shutdown.
svn path=/trunk/; revision=61041
Timo Kreuzer [Mon, 18 Nov 2013 17:23:04 +0000 (17:23 +0000)]
[NTOSKRNK]
Implement KiCallbackReturnHandler
svn path=/trunk/; revision=61040
Timo Kreuzer [Mon, 18 Nov 2013 15:21:53 +0000 (15:21 +0000)]
[NTOSKRNL]
Implement RtlpCloseHandleCallback, closing the handle table, and use it as callback for ExSweepHandleTable in RtlpDestroyAtomHandleTable. Without a callback ExSweepHandleTable simply crashes, so obviously we never clean up any atom tables, possibly because the window station is never closed.
svn path=/trunk/; revision=61039
Timo Kreuzer [Mon, 18 Nov 2013 14:43:28 +0000 (14:43 +0000)]
[BOOTDATA]
Add registry key for winsrv configuration and a a few additional entrys for the VBE driver configuration.
svn path=/trunk/; revision=61038
Timo Kreuzer [Mon, 18 Nov 2013 14:27:01 +0000 (14:27 +0000)]
[NTOSKRNL]
Implement ObSetHandleAttributes. Rename the ObIsKernelHandle macro to ObpIsKernelHandle to avoid ambiguities (ObIsKernelHandle is a public Vista+ API). Check for NtCurrentProcess and NtCurrentThread in ObpIsKernelHandle, since those are always non-kernel handles.
svn path=/trunk/; revision=61037
Thomas Faber [Mon, 18 Nov 2013 10:46:20 +0000 (10:46 +0000)]
[D3DX9_36]
- Add missing dependency on d3d_idl_headers
- Add missing port.h include (fix MSVC warnings). CORE-7538
svn path=/trunk/; revision=61035
Timo Kreuzer [Mon, 18 Nov 2013 00:35:32 +0000 (00:35 +0000)]
[GDI32]
Fix MSVC warnings
svn path=/trunk/; revision=61032
Thomas Faber [Mon, 18 Nov 2013 00:22:53 +0000 (00:22 +0000)]
[WINE]
- We have <unistd.h> and <sys/time.h>, that doesn't depend on _MSC_VER.
svn path=/trunk/; revision=61031
Thomas Faber [Mon, 18 Nov 2013 00:04:15 +0000 (00:04 +0000)]
[CMAKE]
- Enable C4115 (struct defined in function parameter list) and fix its occurrences
svn path=/trunk/; revision=61030
Thomas Faber [Sun, 17 Nov 2013 23:38:31 +0000 (23:38 +0000)]
[CMAKE]
- Make C4113 (function pointer parameter lists differ) an error. CORE-7538
- Properly ignore "export of deleting destructor" warning in msvcrt
svn path=/trunk/; revision=61029
Timo Kreuzer [Sun, 17 Nov 2013 22:43:23 +0000 (22:43 +0000)]
[SPEC2DEF]
Remove a spurious %
svn path=/trunk/; revision=61028
Timo Kreuzer [Sun, 17 Nov 2013 22:31:15 +0000 (22:31 +0000)]
[SPEC2DEF]
Fix MSVC build as well
svn path=/trunk/; revision=61027
Eric Kohl [Sun, 17 Nov 2013 22:30:55 +0000 (22:30 +0000)]
[EVENTLOG]
LogfInitializeExisting: Do not try to write to a file that has been opened as a backup file. It has been opened read-only.
svn path=/trunk/; revision=61026
Timo Kreuzer [Sun, 17 Nov 2013 22:24:02 +0000 (22:24 +0000)]
[CMAKE/SPEC2DEF]
Fix build.
svn path=/trunk/; revision=61025
Timo Kreuzer [Sun, 17 Nov 2013 22:11:04 +0000 (22:11 +0000)]
[SPEC2DEF]
Rewrite the code for generating def files. Remove useless switches. Seperate code for GCC and MSVC for easier maintainability. Make use of the new dlltool feature implemented by Kai Tietz, that allows to specify the name of an import/export. It is now possible to both export stdcall and fastcall decorated symbols as well as import from them.
svn path=/trunk/; revision=61024
Thomas Faber [Sun, 17 Nov 2013 22:10:42 +0000 (22:10 +0000)]
[USER32]
- Fix MSVC warnings
svn path=/trunk/; revision=61023
Thomas Faber [Sun, 17 Nov 2013 21:58:48 +0000 (21:58 +0000)]
[NTOS:MM]
- Fix some MSVC warnings
svn path=/trunk/; revision=61022
Thomas Faber [Sun, 17 Nov 2013 19:45:32 +0000 (19:45 +0000)]
[CMAKE]
- Make warning C4229 (modifiers on data are ignored) an error
svn path=/trunk/; revision=61020
Thomas Faber [Sun, 17 Nov 2013 19:14:24 +0000 (19:14 +0000)]
[BASESRV][SVCHOST]
- Fix callback calling conventions
svn path=/trunk/; revision=61019
Johannes Anderwald [Sun, 17 Nov 2013 19:14:08 +0000 (19:14 +0000)]
[DEVMGR]
- Implement device resource page
svn path=/trunk/; revision=61018
Johannes Anderwald [Sun, 17 Nov 2013 14:51:06 +0000 (14:51 +0000)]
- stop enumeration of mixer controls when there is more than one item
- fixes vmware audio driver hangs
- needs more work
- patch by David Quintana
CORE-7488 #resolve #comment thanks for the patch
svn path=/trunk/; revision=61017
Sylvain Petreolle [Sun, 17 Nov 2013 14:21:08 +0000 (14:21 +0000)]
[OOPS]
Arch, when you fix a DPRINT, don't turn it into DPRINT1.
svn path=/trunk/; revision=61016
Sylvain Petreolle [Sun, 17 Nov 2013 14:11:08 +0000 (14:11 +0000)]
[RTL]
Fix crashing DPRINT into LdrFindResource_U.
Thanks to ThFabba for the tip.
svn path=/trunk/; revision=61015
Timo Kreuzer [Sat, 16 Nov 2013 18:40:24 +0000 (18:40 +0000)]
[VIDEOPRT/WINSERV] Move mapping the BIOS memory from winsrv to videoprt, where it belongs.
[VIDEOPRT] Implement some registry support routines to create new style (XP+) registry keys. Handle IOCTL_VIDEO_INIT_WIN32K_CALLBACKS in videoprt, reorganize the code to dispatch ioctls. Simplify failure path in IntVideoPortFindAdapter
svn path=/trunk/; revision=61013
Timo Kreuzer [Sat, 16 Nov 2013 18:31:44 +0000 (18:31 +0000)]
[DXG]
Add all function stubs. (win32k from windows 2k3 is nasty and indexes the function table directly instead of looking up the entries...)
svn path=/trunk/; revision=61012
Timo Kreuzer [Sat, 16 Nov 2013 18:27:26 +0000 (18:27 +0000)]
[RTL]
Fix RtlWriteRegistryValue, it closed the handle passed to it instead of checking for RTL_REGISTRY_HANDLE flag.
[NTOSKRNL]
Fix PnpRootCreateDevice, which was relying on the broken RtlWriteRegistryValue by aborting, when it *succeeded* to create a registry key, instead of when it failed.
Also use kernel handles and ObCloseHandle.
svn path=/trunk/; revision=61011
Sylvain Petreolle [Sat, 16 Nov 2013 17:19:18 +0000 (17:19 +0000)]
[NEWDEV]
tabs -> spaces
svn path=/trunk/; revision=61010
Timo Kreuzer [Sat, 16 Nov 2013 15:25:44 +0000 (15:25 +0000)]
[NTOSKRNL]
Don't use KiTrapReturnNoSegmentsRet8, when single stepping is active. Fixes debugging with WinDbg
svn path=/trunk/; revision=61009
Thomas Faber [Sat, 16 Nov 2013 15:00:11 +0000 (15:00 +0000)]
[DDK][XDK]
- Do not evaluate the ASSERT macro's parameter before stringifying it
CORE-7588 #resolve
svn path=/trunk/; revision=61008
Thomas Faber [Sat, 16 Nov 2013 12:02:17 +0000 (12:02 +0000)]
[NDK]
- Add RtlEraseUnicodeString
ROSTESTS-126
svn path=/trunk/; revision=61007
Timo Kreuzer [Sat, 16 Nov 2013 10:33:56 +0000 (10:33 +0000)]
[WIN32K]
Fix inserting LDEVOBJs into the list. Hopefully fixes CORE-7574
svn path=/trunk/; revision=61006
Eric Kohl [Sat, 16 Nov 2013 09:07:37 +0000 (09:07 +0000)]
[SAMSRV]
SamrDeleteUser: Prepare the removal of a user from groups and aliases.
svn path=/trunk/; revision=61005
Timo Kreuzer [Fri, 15 Nov 2013 23:45:11 +0000 (23:45 +0000)]
[BOOTDATA]
Add registry keys for win32k GRE initialization and Win32 config
svn path=/trunk/; revision=61004
Timo Kreuzer [Fri, 15 Nov 2013 23:38:59 +0000 (23:38 +0000)]
[BOOTDATA]
Add global RIP flags for native win32k
svn path=/trunk/; revision=61003
Thomas Faber [Fri, 15 Nov 2013 21:37:46 +0000 (21:37 +0000)]
[SERVICES]
- Fix syntax errors in asynchronous pipe I/O code
ROSTESTS-56
svn path=/trunk/; revision=61002
Hermès Bélusca-Maïto [Fri, 15 Nov 2013 21:03:01 +0000 (21:03 +0000)]
[SERVICES]
... and for 61001st commit: Fix the ANSI version of the server-side of ChangeServiceConfig2A API, which broke at converting SERVICE_FAILURE_ACTIONS ANSI structures into UNICODE ones.
Fixes the VMWare Tools Installer; blame Sylvain if it doesn't ;)
Based on a patch by Sylvain Petreolle.
CORE-7539 #comment Fixed in revision 61001, thanks !
svn path=/trunk/; revision=61001
Jérôme Gardou [Fri, 15 Nov 2013 17:34:13 +0000 (17:34 +0000)]
[WIN32SS]
- Fix an assert in new cursoricon implementation
- Fix CreateIconIndirect behaviour regarding bits per pixel and bitmap dimensions
- Fix LookupIconIdFromDirectoryEx behaviour to fulfill last commited tests
CORE-7575 #comment LookupIconDirectoryEx and CreateIconIndirect now works as per tests
svn path=/trunk/; revision=60999
Thomas Faber [Fri, 15 Nov 2013 12:13:25 +0000 (12:13 +0000)]
[CMAKE]
- Revert MSVC build to /W3
svn path=/trunk/; revision=60998
Thomas Faber [Fri, 15 Nov 2013 11:55:35 +0000 (11:55 +0000)]
[CMAKE]
- Temporarily raise MSVC warning level to 4 to get an inventory of the warnings we produce
svn path=/trunk/; revision=60997
Jérôme Gardou [Thu, 14 Nov 2013 23:11:23 +0000 (23:11 +0000)]
[USER32_APITEST]
- Add tests for LookupIconIdFromDirectoryEx
- Add a workaround in GetIconInfo tests for a ReactOS bug in EnumDisplaySettings
- Add tests for EnumDisplaySettings demonstrating the bug.
- Add some traces to better follow the test run
svn path=/trunk/; revision=60994
Thomas Faber [Thu, 14 Nov 2013 21:44:47 +0000 (21:44 +0000)]
[PSDK]
- Fix (nt)intsafe.h signed to unsigned conversions. Based on a patch by Timo.
CORE-7578 #resolve
svn path=/trunk/; revision=60993
James Tabor [Thu, 14 Nov 2013 17:29:24 +0000 (17:29 +0000)]
- Isolate driver name for sysparams test crash, one more try. CORE-7574
svn path=/trunk/; revision=60992
Thomas Faber [Thu, 14 Nov 2013 09:19:16 +0000 (09:19 +0000)]
[KMTESTS:RTL]
- Add RtlIntSafe test for ntintsafe.h functions
CORE-7578
svn path=/trunk/; revision=60991
Timo Kreuzer [Wed, 13 Nov 2013 23:31:36 +0000 (23:31 +0000)]
[NTDDVDEO]
Add some missing definitions
svn path=/trunk/; revision=60986
Thomas Faber [Wed, 13 Nov 2013 22:07:54 +0000 (22:07 +0000)]
[NTOS:MM]
- Fix bugcheck and unreadable DPRINTs in failure case of MiResolveImageReferences
CORE-7571 #resolve
svn path=/trunk/; revision=60983
Timo Kreuzer [Wed, 13 Nov 2013 21:32:16 +0000 (21:32 +0000)]
[VIDEOPRT][FORMATTING]
Apply proper indentation.
svn path=/trunk/; revision=60982
Thomas Faber [Wed, 13 Nov 2013 21:00:27 +0000 (21:00 +0000)]
[CLASSPNP]
- Fix warnings
svn path=/trunk/; revision=60981
Jérôme Gardou [Wed, 13 Nov 2013 20:14:00 +0000 (20:14 +0000)]
[OOPS++]
- Fix build, now!
Running out of excuses.
svn path=/trunk/; revision=60980
Jérôme Gardou [Wed, 13 Nov 2013 20:10:10 +0000 (20:10 +0000)]
[OOPS]
- Fix build.
That wouldn't be me commiting otherwise.
svn path=/trunk/; revision=60979
Jérôme Gardou [Wed, 13 Nov 2013 20:06:01 +0000 (20:06 +0000)]
[WIN32SS]
- Commit everything I got on new cursor/icon implementation
- Implement loading animated cursors (no display yet)
- Get rid of this m:n relation between cursors and processes. (ie. proper implementation of LR_SHARED)
- Get rid of the global linked list of cursors (ditto)
- Use atoms instead of copying the module name into the object. (aka stop using non paged pool for nothing)
- Misc fixes
svn path=/trunk/; revision=60978
James Tabor [Wed, 13 Nov 2013 18:33:15 +0000 (18:33 +0000)]
- Isolate driver name for sysparams test crash. CORE-7574
svn path=/trunk/; revision=60976
James Tabor [Wed, 13 Nov 2013 17:21:41 +0000 (17:21 +0000)]
- Wine had some fixups added since this was last synced. CORE-???? & CORE-7574.
svn path=/trunk/; revision=60974
Jérôme Gardou [Wed, 13 Nov 2013 16:45:22 +0000 (16:45 +0000)]
[USETUP]
- Fix some format specifiers.
svn path=/trunk/; revision=60973
Thomas Faber [Wed, 13 Nov 2013 12:36:05 +0000 (12:36 +0000)]
[CLASSPNP]
- Remove unused variables
svn path=/trunk/; revision=60971