Oleg Dubinskiy [Wed, 24 Jul 2019 17:56:33 +0000 (20:56 +0300)]
[DSOUND_NEW] Remove unused dsound_convert.c file (#1748)
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:45:55 +0000 (01:45 +0900)]
[USER32_APITEST][INCLUDE] Add MessageStateAnalyzer testcase (#1732)
I want to visualize the message stream and verify the states of each message. ROSTESTS-328
- Add a testcase named MessageStateAnalyzer into user32_apitest.
- Also fix type casts in <windowsx.h>.
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:40:33 +0000 (01:40 +0900)]
[USER32][NTUSER] Fix menu arrow drawing (of DrawFrameControl) (#1752)
CORE-13211
user32!DrawFrameControl drawed invalid menu arrow when the width is shorter than the height.
- Use the squared rectangle.
- Draw it in the transparent background mode.
- Save the old background mode of HDC.
This PR will fix UltraISO's bug.
Katayama Hirofumi MZ [Wed, 24 Jul 2019 06:39:10 +0000 (15:39 +0900)]
[MEDIA][FONTS] RAPPS checkmark fix (#1751)
The checkmarks of RAPPS were strange. This PR will fix the checkmark ("b") of 12px bitmap glyph of Marlett.ttf font file. CORE-14872
Katayama Hirofumi MZ [Tue, 23 Jul 2019 12:55:38 +0000 (21:55 +0900)]
[MEDIA][FONTS] Add copyright notice of TransGaming Technologies
With some font error fixed. CORE-16226
Katayama Hirofumi MZ [Tue, 23 Jul 2019 07:03:30 +0000 (16:03 +0900)]
[MEDIA][FONTS] Renewal of Marlett.ttf (#1749)
Renewal of Marlett.ttf font file. CORE-16226, CORE-14872
- Based on Ged Murphy's Marlett.ttf (See https://github.com/reactos/reactos/blob/
527f2f90577662e8eba1b1b62f958c39b3cd4358/media/fonts/Marlett.ttf).
- Erase the centered triangles.
- Adjustment of glyphs.
- Clarify the copyright ownership.
- Tested with 3 test programs (RadioAndCheck, PixelPerfectGlyph and MarlettCompare).
Doug-Lyons [Sat, 22 Jun 2019 16:23:11 +0000 (11:23 -0500)]
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. (#1684)
CORE-16123
- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
their non-volatile counterparts.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Bișoc George [Wed, 19 Jun 2019 15:51:11 +0000 (17:51 +0200)]
[UMPNPMGR] Implement registry functions for SuppressUI and SuppressNewHWUI handling. (#1683)
CORE-15897
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Eric Kohl [Sun, 21 Jul 2019 16:56:02 +0000 (18:56 +0200)]
[SRVSVC][WKSSVC] Set the stop pending status before stopping the services and stop the RPC listener on shutdown as well.
Eric Kohl [Sun, 21 Jul 2019 16:51:33 +0000 (18:51 +0200)]
[WMISERV][WUAUSERV] Stop the service if the stop event creation fails.
Erdem Ersoy [Sun, 21 Jul 2019 15:49:12 +0000 (18:49 +0300)]
[TRANSLATIONS] Update Turkish translations (#1650)
Translations for Solitaire, Spider, WinMine, Notepad, Wordpad & Write, MSPaint, MPlay32, SndRec32, WinHlp32, SndVol32, TaskMgr and Calc.
Benjamin Aerni [Sat, 13 Jul 2019 06:42:10 +0000 (23:42 -0700)]
[W32TIME] Use a reasonable fallback of 9 hours. (#1724)
CORE-16181
This allows preventing spamming the time servers if the registry entry
becomes corrupted or missing. Also, disallow a setting of less than
2 minutes for the same reasons, and instead use the fallback of 9 hours.
Oleg Dubinskiy [Fri, 19 Jul 2019 13:32:07 +0000 (16:32 +0300)]
[DSOUND_NEW] Completely fix gcc compilation (addendum to
25e98eb). (#1740)
CORE-16128
Bișoc George [Sun, 21 Jul 2019 14:52:25 +0000 (16:52 +0200)]
[OSK] Use new coordinates on keyboard layout changing (#1745)
CORE-16214
Katayama Hirofumi MZ [Sun, 21 Jul 2019 12:39:05 +0000 (21:39 +0900)]
[WIN32SS][GDI] Assume pso->sizlBitmap.cy positiveness (#1743)
We assume pso->sizlBitmap.cy is positive. CORE-15995
Because pso->sizlBitmap.cy is certificated as a positive value after initialization in SURFACE_AllocSurface, so we can safely omit abs and labs (absolute) function calls for it.
Michael Maltsev [Mon, 3 Jun 2019 09:35:58 +0000 (12:35 +0300)]
[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094
Katayama Hirofumi MZ [Sun, 21 Jul 2019 06:17:02 +0000 (15:17 +0900)]
[MEDIA][FONTS] Shrink Marlett.ttf file size
Katayama Hirofumi MZ [Sun, 21 Jul 2019 03:59:06 +0000 (12:59 +0900)]
[FONTS][NTGDI] Change Marlett.ttf charset and delete charset hacks
Hermès Bélusca-Maïto [Sat, 20 Jul 2019 23:06:54 +0000 (01:06 +0200)]
[MSCONFIG][ROSAPPS] Remove explicit MINGW_HAS_SECURE_API since it is already enabled globally. CORE-16224
Hermès Bélusca-Maïto [Sat, 20 Jul 2019 22:47:58 +0000 (00:47 +0200)]
[WIN32K:NTGDI] Improve allocated resources cleanup in failure paths of IntGdiLoadFontsFromMemory().
- Use an auxiliary list where we add the new enumerated faces, for easy
roll-back in case a failure happens during font loading. Only at the
very end when font loading has been successfully done, the auxiliary
list is appended to the corresponding global or per-proceess font list.
- Perform actual cleanup in case of failures.
- Introduce CleanupFontEntryEx() helper to simplify cleanup in
IntGdiLoadFontsFromMemory() in failure paths; implement
CleanupFontEntry() around it.
Additions:
- Perform string buffer NULL check in IntGdiAddFontResource().
- Reorder memory unmapping and section object dereferencing in
IntGdiAddFontResource().
- Move DuplicateUnicodeString() upwards.
- Mark explicitly the Marlett font handling hacks.
Eric Kohl [Sat, 20 Jul 2019 20:48:17 +0000 (22:48 +0200)]
[SRVSVC] Make the server service stoppable.
Eric Kohl [Sat, 20 Jul 2019 20:43:39 +0000 (22:43 +0200)]
[WKSSVC] Make the workstation service stoppable.
Eric Kohl [Sat, 20 Jul 2019 17:27:22 +0000 (19:27 +0200)]
[WUAUSERV] Make the wuauserv service startable and stoppable.
Katayama Hirofumi MZ [Sat, 20 Jul 2019 14:47:29 +0000 (23:47 +0900)]
[WIN32SS][NTGDI] Support raster fonts (*.fnt and *.fon) (#1739)
Add raster font (*.fnt and *.fon files) support. CORE-16165
- Add IntGetCharSet() function to get the charset by index and/or the number of charsets.
- Make IntGdiLoadFontsFromMemory() a non-recursive function.
- IntGetOutlineTextMetrics() accepts raster fonts.
- Improve CharMap handling (especially TT_PLATFORM_APPLE_UNICODE).
- Write the raster font file info to the registry.
- Don't request font size for raster fonts in IntRequestFontSize() function.
Eric Kohl [Sat, 20 Jul 2019 13:50:35 +0000 (15:50 +0200)]
[WMISVC] Accept stop and shutdown commands when the service is running.
Timo Kreuzer [Wed, 1 May 2019 07:44:33 +0000 (09:44 +0200)]
[GEN_BASEADDRESS] Add framebuf.dll and framebuf_new.dll to exclude ist in gen_baseaddress.py
Timo Kreuzer [Mon, 29 Apr 2019 15:00:18 +0000 (17:00 +0200)]
[TOOLS] Make gen_baseaddress.py python 3 compatible
Timo Kreuzer [Mon, 29 Apr 2019 14:07:06 +0000 (16:07 +0200)]
[CMAKE] Update base addresses
Timo Kreuzer [Sun, 28 Apr 2019 18:23:35 +0000 (20:23 +0200)]
[NTOSKRNL] Replace overlapping strcopy with memmove
Fixes 4 GCC 8 warnings of the kind:
ntoskrnl/kdbg/kdb_cli.c:3015:21: error: 'strcpy' accessing 1 byte at offsets 0 and [0,
2147483647] may overlap 1 byte at offset 0 [-Werror=restrict]
strcpy(p2, p2 + j);
^~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 16:27:22 +0000 (18:27 +0200)]
[CRT] Use sprintf_s instead of sprintf
Fixes GCC 8 warning:
sdk/lib/crt/misc/i10output.c:83:25: error: '%d' directive writing between 1 and 11 bytes into a region of size 6 [-Werror=format-overflow=]
sprintf(format, "%%.%dle", prec);
^~
sdk/lib/crt/misc/i10output.c:83:21: note: directive argument in the range [-
2147483648,
2147483646]
sprintf(format, "%%.%dle", prec);
^~~~~~~~~
sdk/lib/crt/misc/i10output.c:83:5: note: 'sprintf' output between 6 and 16 bytes into a destination of size 8
sprintf(format, "%%.%dle", prec);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 18:38:25 +0000 (20:38 +0200)]
[VFATLIB] Use RtlStringCbPrintfA instead of sprintf
Fixes GCC 8 warning:
sdk/lib/fslib/vfatlib/check/boot.c:173:27: error: '%02x' directive writing between 2 and 8 bytes into a region of size between 0 and 15 [-Werror=format-overflow=]
sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
^~~~
sdk/lib/fslib/vfatlib/check/boot.c:173:16: note: directive argument in the range [0,
2147483647]
sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
^~~~~~~~~~~~~~~~
sdk/lib/fslib/vfatlib/check/boot.c:173:3: note: 'sprintf' output between 8 and 31 bytes into a destination of size 20
sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(unsigned)(p - (uint8_t *) b), *p, *q);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 16:07:51 +0000 (18:07 +0200)]
[OLEAUT32] Use snprintf instead of sprintf
Fixes GCC 8 warning:
dll/win32/oleaut32/oleaut.c:876:39: error: '%s' directive writing up to 99 bytes into a region of size between 92 and 291 [-Werror=format-overflow=]
sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
^~ ~~~
dll/win32/oleaut32/oleaut.c:876:5: note: 'sprintf' output between 18 and 316 bytes into a destination of size 300
sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 15:48:58 +0000 (17:48 +0200)]
[FREELDR] Use RtlStringCbPrintfA instead of sprintf
Fixes GCC 8 warnings like:
boot/freeldr/freeldr/disk/scsiport.c:806:31: error: 'partition(0)' directive writing 12 bytes into a region of size between 1 and 64 [-Werror=format-overflow=]
sprintf(PartitionName, "%spartition(0)", ArcName);
^~~~~~~~~~~~
boot/freeldr/freeldr/disk/scsiport.c:806:5: note: 'sprintf' output between 13 and 76 bytes into a destination of size 64
sprintf(PartitionName, "%spartition(0)", ArcName);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 13:50:08 +0000 (15:50 +0200)]
[FASTFAT] Copy an entire field, instead of half-copying it with RtlCopyMemory
Fixes GCC 8 warning:
sdk/include/crt/mingw32/intrin_x86.h:76:12: error: 'memmove' offset [21, 40] from the object at 'DirContext' is out of the bounds of referenced subobject 'Attrib' with type 'unsigned char' at offset 19 [-Werror=array-bounds]
return memmove(dest, source, num);
^~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 12:49:31 +0000 (14:49 +0200)]
[FRAMEDYN] Fix broken asm (.code64 is for x64 only)
Timo Kreuzer [Sat, 27 Apr 2019 16:58:08 +0000 (18:58 +0200)]
[KERNEL32] Improve path name handling
Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
strncat(PathBuffer, "\\twain_32.dll", 13);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 16:53:59 +0000 (18:53 +0200)]
[MSPAINT] Don't use SIZEOF on a pointer
Fixes GCC 8 warning:
base/applications/mspaint/definitions.h:16:31: error: division 'sizeof (LPWSTR {aka wchar_t*}) / sizeof (WCHAR {aka wchar_t})' does not compute the number of array elements [-Werror=sizeof-pointer-div]
#define SIZEOF(a) (sizeof(a) / sizeof((a)[0]))
~~~~~~~~~~^~~~~~~~~~~~~~~~
base/applications/mspaint/main.cpp:134:55: note: in expansion of macro 'SIZEOF'
lstrcpyn(pon->lpOFN->lpstrFile, Path, SIZEOF(pon->lpOFN->lpstrFile));
^~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 16:42:21 +0000 (18:42 +0200)]
[MSGINA] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.
Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "User32 ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 14:05:40 +0000 (16:05 +0200)]
[ADVAPI32] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.
Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "Advapi ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Mon, 3 Jun 2019 07:14:21 +0000 (09:14 +0200)]
[PSDK] Remove default value for BSTR parameter in msxml2.idl
Fixes GCC 8 warning:
In file included from base/applications/msconfig_new/xmldomparser.hpp:26,
from base/applications/msconfig_new/toolspage.cpp:11:
sdk/include/psdk/msxml2.h:12705:20: error: ISO C++ forbids converting a string constant to 'BSTR' {aka 'wchar_t*'} [-Werror=write-strings]
BSTR uri = L"x") = 0;
^~~~
Timo Kreuzer [Mon, 3 Jun 2019 07:07:36 +0000 (09:07 +0200)]
[PSDK][CRT] Add some casts to make GCC 8 happy
Timo Kreuzer [Sat, 27 Apr 2019 20:16:49 +0000 (22:16 +0200)]
[PSDK] Add DECLSPEC_SELECTANY to GUIDs to make GCC 8 happy
Timo Kreuzer [Mon, 29 Apr 2019 07:56:29 +0000 (09:56 +0200)]
[CMAKE] Globally enable secure CRT functions
"This is what Windows does" (tm)
Timo Kreuzer [Sun, 28 Apr 2019 20:05:32 +0000 (22:05 +0200)]
[CRT] Remove _wctime_s from time.h
Timo Kreuzer [Mon, 29 Apr 2019 08:02:13 +0000 (10:02 +0200)]
[CMAKE] Define _GLIBCXX_HAVE_BROKEN_VSWPRINTF to fix build with GLIBCXX and our c++ headers
Timo Kreuzer [Sun, 28 Apr 2019 20:17:19 +0000 (22:17 +0200)]
[CMAKE] Disable some overly sensitive warnings
-Wno-unused-const-variable
-Wno-unused-local-typedefs
-Wno-deprecated
Thomas Faber [Sun, 14 Jul 2019 09:01:36 +0000 (11:01 +0200)]
[ACPICA] Update to version
20190703. CORE-16202
Shy Zedaka [Fri, 19 Jul 2019 15:08:33 +0000 (18:08 +0300)]
[TRANSLATION] Hebrew Translation for Services (#1741)
Stanislav Motylkov [Thu, 18 Jul 2019 21:09:59 +0000 (00:09 +0300)]
[FREELDR] Abstract VGA BIOS specific code (#1736)
* [FREELDR] Abstract VGA BIOS specific code
WinLdrSetupSpecialDataPointers() uses INT 10h video interrupts, but they are not available on Xbox, so make them machine-specific.
CORE-16204 CORE-16210
* [FREELDR] Abstract getting extended BIOS data area
WinLdrSetupSpecialDataPointers() uses INT 15h AH=C1h to get extended BIOS data area, but it's not available on Xbox, so make it machine-specific.
CORE-16204 CORE-16210
Stanislav Motylkov [Thu, 18 Jul 2019 20:50:48 +0000 (23:50 +0300)]
[FREELDR] Abstract floppy drive detection code (#1735)
Make floppy detection code machine-specific, because Xbox CMOS cannot be used to detect floppies. Based on a patch by Matt Borgerson.
CORE-16204 CORE-16207
Co-authored-by: Matt Borgerson <contact@mborgerson.com>
Stanislav Motylkov [Mon, 15 Jul 2019 21:36:54 +0000 (00:36 +0300)]
[FREELDR] Fix memory initialization on Xbox
- Refactor and use PC memory map init functions
- This fixes filesystem detection and probably some other problems
Based on a patch by Matt Borgerson.
CORE-16204 CORE-16206
Co-authored-by: Matt Borgerson <contact@mborgerson.com>
Stanislav Motylkov [Mon, 15 Jul 2019 19:40:10 +0000 (22:40 +0300)]
[FREELDR] Whitespace improvements - no code changes
Stanislav Motylkov [Thu, 18 Jul 2019 20:49:11 +0000 (23:49 +0300)]
[FREELDR] hwdisk: Add sanity checks to avoid infinite loop (#1731)
CORE-16204 CORE-16205
Joachim Henze [Tue, 16 Jul 2019 20:51:42 +0000 (22:51 +0200)]
[BOOTDATA][SETUP] Fix regression CORE-16200 font rendering
By removing font substitution for 'Microsoft Sans Serif'.
Thanks to the patches author Katayama Hirofumi MZ.
This is a partial revert of the guilty rev
master guilty 0.4.13-dev-9-g
811faed421a798659af3cb3f09369af84fc4edf0
RC guilty 0.4.12-RC-13-g
8d3def0529e7e1bb9095713d46f5fbb64df0d299
VBox test result:
https://reactos.org/testman/compare.php?ids=68497,68499
The same fix has been applied before to 0.4.12-RC-44-g
ca0e00e8af009679351747150605857be580c538
Katayama Hirofumi MZ [Mon, 15 Jul 2019 14:03:06 +0000 (23:03 +0900)]
[SDK][INCLUDE] Add WM_WTSSESSION_CHANGE message (#1730)
- Add WM_WTSSESSION_CHANGE messages to <winuser.h>.
- Add WTS_* constant macros.
Bișoc George [Mon, 15 Jul 2019 13:59:06 +0000 (15:59 +0200)]
[OSK] Implement "Always on Top" feature (#1729)
Katayama Hirofumi MZ [Mon, 15 Jul 2019 11:32:53 +0000 (20:32 +0900)]
[SDK][INCLUDE] Add WM_INPUT_DEVICE_CHANGE and WM_INPUT (#1728)
- Add WM_INPUT_DEVICE_CHANGE and WM_INPUT messages.
- Add the relevant constant values.
Katayama Hirofumi MZ [Mon, 15 Jul 2019 10:59:38 +0000 (19:59 +0900)]
[SDK][INCLUDE] Add MENUGETOBJECTINFO structure (#1727)
- Add MENUGETOBJECTINFO structure to <winuser.h> header.
- Add MNGOF_TOPGAP and MNGOF_BOTTOMGAP constant macros.
Katayama Hirofumi MZ [Mon, 15 Jul 2019 10:58:34 +0000 (19:58 +0900)]
[SDK][INCLUDE] Add HANDLE_WM_* macros to <windowsx.h> (#1726)
- Add the following macros into <windowsx.h> header: HANDLE_WM_COPYDATA, HANDLE_WM_DEVICECHANGE, HANDLE_WM_DISPLAYCHANGE, HANDLE_WM_HOTKEY, and HANDLE_WM_MOUSEWHEEL.
- Fix HANDLE_WM_CONTEXTMENU macro.
Jose Carlos Jesus [Sun, 14 Jul 2019 22:07:50 +0000 (23:07 +0100)]
[TRANSLATION] Add Portuguese (neutral) translation. (#1702)
Add Portuguese (neutral) translation for intl.cpl, main.cpl, msgina.dll, msports.dll, welcome.exe and rundll32.exe, and fix the one in mshtml.dll .
Hermès Bélusca-Maïto [Sun, 14 Jul 2019 18:07:09 +0000 (20:07 +0200)]
[NTOS:INBV] Fix the bitmaps' palette and recompress them in RLE. (#1649)
They don't need to have a zeroed-out palette now that we can
automatically reset it from within the code.
Co-authored-by: Yaroslav Kibysh <yanet.prod@gmail.com>
Hermès Bélusca-Maïto [Sun, 7 Jul 2019 21:15:53 +0000 (23:15 +0200)]
[NTOS:INBV] Express some coordinates in terms of screen size. (#1649)
Yaroslav Kibysh [Tue, 11 Jun 2019 19:27:25 +0000 (22:27 +0300)]
[NTOS:INBV] Implement BitBltPalette() and BitBltAligned() and use them for aligning bitmaps. (#1649)
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Hermès Bélusca-Maïto [Sat, 13 Jul 2019 22:04:19 +0000 (00:04 +0200)]
[NTOS:MM] Add a MmChangeKernelResourceSectionProtection() helper. (#1649)
This allows setting the memory protection of the kernel's resource
section as will. MmMakeKernelResourceSectionWritable() is re-implemented
around this helper.
Hermès Bélusca-Maïto [Sat, 6 Jul 2019 22:33:06 +0000 (00:33 +0200)]
[NTOS:INBV] Classify the bitmap resources. (#1649)
See "How to change Windows XP boot logo" at
http://www.reversing.be/article.php?story=
20061209171938444
as well as the "Boot Editor for WinXP" program for more details.
Hermès Bélusca-Maïto [Sun, 14 Jul 2019 20:17:50 +0000 (22:17 +0200)]
[UMPNPMGR] Fix build.
Eric Kohl [Sun, 14 Jul 2019 19:50:06 +0000 (21:50 +0200)]
[UMPNPMGR] PNP_GetDeviceStatus: Move the code that retrieves the status of a device into a separate function so that we can use in other functions.
Timo Kreuzer [Sun, 26 May 2019 13:06:32 +0000 (15:06 +0200)]
[ACPICA] Fix MSVC x64 build
See CORE-16082
Victor Perevertkin [Sat, 13 Jul 2019 22:58:53 +0000 (01:58 +0300)]
[DOCS] Add myself to CODEOWNERS file
Serge Gautherie [Sat, 13 Jul 2019 22:32:23 +0000 (00:32 +0200)]
[NTOS:MM] Fix MmGetFileNameForAddress() callers. (#1723)
MmGetFileNameForAddress() calls RtlCreateUnicodeString().
This also fixes a leak in MiQueryMemorySectionName().
Timo Kreuzer [Sun, 30 Jun 2019 14:12:58 +0000 (16:12 +0200)]
[DOCS] Replace MAINTAINERS file with CODEOWNERS
Eric Kohl [Sat, 13 Jul 2019 12:26:57 +0000 (14:26 +0200)]
[SETUPAPI] Implement CM_Delete_DevNode_Key_Ex()
CM_REGISTRY_USER is not supported yet.
Katayama Hirofumi MZ [Fri, 12 Jul 2019 00:50:38 +0000 (09:50 +0900)]
[MEDIA][FONTS] Add Turkish MS Sans Serif (sserifet.fon) CORE-16166
Katayama Hirofumi MZ [Thu, 11 Jul 2019 07:09:24 +0000 (16:09 +0900)]
[MEDIA][FONTS] Add Greek MS Sans Serif (sserifeg.fon) CORE-16166
Thomas Faber [Sat, 20 Apr 2019 08:49:13 +0000 (10:49 +0200)]
[NTOS:PNP] Reduce the default buffer size in EnumerateDevices. CORE-15882
Thomas Faber [Sat, 20 Apr 2019 08:48:43 +0000 (10:48 +0200)]
[NTOS:PNP] Handle arbitrary subkey name lengths in EnumerateDevices. CORE-15882
This also makes it necessary to fix a bug in the previous code:
ZwEnumerateKey will not account for space for a null terminator, so to
ensure we have space, we must allocate the additional WCHAR, but not
include it in the buffer size passed to the function.
Mark Jansen [Tue, 9 Jul 2019 20:52:17 +0000 (22:52 +0200)]
[SHELL32] Fix SHCreateDirectoryExW showing an error on success
CORE-15145
Katayama Hirofumi MZ [Tue, 9 Jul 2019 03:56:09 +0000 (12:56 +0900)]
[MEDIA][FONTS] Add Cyrillic MS Sans Serif (sserifer.fon)
Eric Kohl [Sun, 7 Jul 2019 22:08:22 +0000 (00:08 +0200)]
[SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we are using DEVINST anywhere else.
Eric Kohl [Sun, 7 Jul 2019 21:46:25 +0000 (23:46 +0200)]
[SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window text to PNP_RegisterNotification().
Joachim Henze [Sun, 7 Jul 2019 18:50:30 +0000 (20:50 +0200)]
[WIN32SS][FREETYPE] Fix performance regression FreeBASIC console output CORE-16177
By restoring historic state of GreExtTextOutW() / IntExtTextOutW()
This reverts guilty rev 0.4.12-dev-190-g
d6cfeaef5105dc6db2f12682bc48f17f9caacdcc
as well as some follow ups that dealt with new errors popping up afterwards.
The revert got ack of Katayama Hirofumi MZ.
Test VBox on master: https://reactos.org/testman/compare.php?ids=68471,68475
Test KVM on master: https://reactos.org/testman/compare.php?ids=68472,68476
Analog revert was applied before to 0.4.12-RC-42-g
021f498cb2bf50ea210696431786d24536da2691
Bișoc George [Mon, 24 Jun 2019 16:45:52 +0000 (18:45 +0200)]
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688)
CORE-12313
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Hermès Bélusca-Maïto [Sun, 7 Jul 2019 13:57:01 +0000 (15:57 +0200)]
[SHELL32] Recycle-Bin: Minor code enhancements.
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
Thomas Faber [Sun, 7 Jul 2019 14:06:25 +0000 (16:06 +0200)]
[CMAKE] Disable INIT section ld scripts for now. CORE-16183 ROSBE-154
Bișoc George [Sun, 7 Jul 2019 12:47:44 +0000 (14:47 +0200)]
[SHELL32] Enable the "Apply" button when user takes action on the edit box control (#1720)
CORE-12312
Eric Kohl [Sun, 7 Jul 2019 11:41:00 +0000 (13:41 +0200)]
[SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be the service name
Doug Lyons [Sun, 7 Jul 2019 08:59:11 +0000 (10:59 +0200)]
[W32TIME] Implement w32time service. CORE-13001
Doug Lyons [Sat, 10 Feb 2018 21:43:21 +0000 (15:43 -0600)]
[TIMEDATE] Allow editing the time server combo box. CORE-13001
Doug Lyons [Sat, 10 Feb 2018 21:47:04 +0000 (15:47 -0600)]
[TIMEDATE] Handle manual time server entry. CORE-13001
Doug Lyons [Sat, 21 Apr 2018 06:13:27 +0000 (08:13 +0200)]
[TIMEDATE] Use w32time compatible registry settings. CORE-13001
Thomas Faber [Sun, 3 Jun 2018 14:28:57 +0000 (16:28 +0200)]
[W32TIME] Implement a rudimentary version of W32TimeSyncNow. CORE-13001
Thomas Faber [Sun, 3 Jun 2018 13:35:42 +0000 (15:35 +0200)]
[TIMEDATE] Avoid the use of DisplayWin32Error in time sync utility functions. CORE-13001
Thomas Faber [Sun, 3 Jun 2018 10:33:24 +0000 (12:33 +0200)]
[TIMEDATE] Separate time sync functions out into their own file. CORE-13001
This is in preparation for the w32time service, and based on
work by Doug Lyons.
Thomas Faber [Sun, 7 Jul 2019 06:22:16 +0000 (08:22 +0200)]
[NDIS] INIT/PAGE sections must be uppercase.
Thomas Faber [Fri, 5 Jul 2019 15:38:04 +0000 (17:38 +0200)]
[PCI] The INIT section must be uppercase.
Thomas Faber [Sat, 29 Jun 2019 17:24:28 +0000 (19:24 +0200)]
[CMAKE] Ensure the INIT section is placed at the end of a module. CORE-14683
For MSVC, marking the section as discardable will do this automatically.
For GCC, we use a linker script that places it after the .reloc section
(which should be the last "real" section, check ld --verbose output for the
default linker script).
This fixes what seems to be a regression from r55835 (!).
Katayama Hirofumi MZ [Sun, 7 Jul 2019 00:05:10 +0000 (09:05 +0900)]
[USER32] Switch to only one window (Alt+Tab) (#1718)
Fix app switcher (Alt+Tab)'s behavior when there is only one app window. CORE-16176
Mark Jansen [Thu, 4 Jul 2019 21:06:51 +0000 (23:06 +0200)]
[CRT] Remove mingwm10.dll usage in tls support code
CORE-15491
Serge Gautherie [Fri, 21 Jun 2019 12:04:01 +0000 (14:04 +0200)]
[NTOS:MM] Fix MmSizeOfSystemCacheInPages value on AMD64
And add 'ASSERT(MmSystemCacheEnd == ...);'.
Addendum to
d56a24908908b574852091af0b8bd9dca7bc1165.
CORE-14259
Serge Gautherie [Sat, 6 Jul 2019 07:39:03 +0000 (09:39 +0200)]
[FLOPPY_NEW] Fix MSVC builds