Eric Kohl [Sat, 27 Sep 2008 17:37:34 +0000 (17:37 +0000)]
- Disable [handle] and [context_handle] attributes in order not to break ReactOS when WIDL is updated to Wine-0.9.59.
- Fix typos in svcctl.idl.
svn path=/trunk/; revision=36550
Gregor Schneider [Sat, 27 Sep 2008 16:56:14 +0000 (16:56 +0000)]
Don't read and copy 32 Bit blocks, but only 24 Bit according to
24BPP_Put_/Get_Pixel.
Fixes NtGdiAlphaBlend in 24 Bit mode, see bug #3708.
svn path=/trunk/; revision=36548
Stefan Ginsberg [Sat, 27 Sep 2008 16:24:50 +0000 (16:24 +0000)]
- Add PsGetThreadTeb prototype
svn path=/trunk/; revision=36542
Stefan Ginsberg [Fri, 26 Sep 2008 22:11:10 +0000 (22:11 +0000)]
- Fix a couple of bugcodes with incorrect MessageId
- Add SYSTEM_THREAD_EXCEPTION_NOT_HANDLED make use of it
svn path=/trunk/; revision=36541
Eric Kohl [Fri, 26 Sep 2008 20:25:47 +0000 (20:25 +0000)]
Fix lock handle typecasts.
svn path=/trunk/; revision=36540
Aleksey Bragin [Fri, 26 Sep 2008 11:48:54 +0000 (11:48 +0000)]
- Remove an excessive ASSERT (there is a real one below in the function).
svn path=/trunk/; revision=36534
Aleksey Bragin [Fri, 26 Sep 2008 09:42:15 +0000 (09:42 +0000)]
- Apply Art's bitmap patch from the branch, and change the other 2 functions similarly (bit set & clear).
svn path=/trunk/; revision=36533
Christoph von Wittich [Fri, 26 Sep 2008 05:05:59 +0000 (05:05 +0000)]
set eol-style:native
svn path=/trunk/; revision=36532
Christoph von Wittich [Fri, 26 Sep 2008 05:03:14 +0000 (05:03 +0000)]
set eol-style:native
svn path=/trunk/; revision=36531
Christoph von Wittich [Fri, 26 Sep 2008 04:55:25 +0000 (04:55 +0000)]
set eol-style:native
svn path=/trunk/; revision=36530
Christoph von Wittich [Fri, 26 Sep 2008 04:51:32 +0000 (04:51 +0000)]
set eol-style:native
svn path=/trunk/; revision=36529
Timo Kreuzer [Thu, 25 Sep 2008 22:44:36 +0000 (22:44 +0000)]
Simplify and fix InitMetrics. Fixes Coverity error 33.
svn path=/trunk/; revision=36523
Timo Kreuzer [Thu, 25 Sep 2008 22:17:51 +0000 (22:17 +0000)]
Some cleanup
svn path=/trunk/; revision=36522
Timo Kreuzer [Thu, 25 Sep 2008 22:04:20 +0000 (22:04 +0000)]
Update SM_XXX constants
svn path=/trunk/; revision=36521
KJK::Hyperion [Thu, 25 Sep 2008 19:44:38 +0000 (19:44 +0000)]
Only apply C++ compiler flags to the C++ compiler. Fixes useless build warnings.
svn path=/trunk/; revision=36520
Timo Kreuzer [Thu, 25 Sep 2008 19:26:09 +0000 (19:26 +0000)]
Allocate size of structure, not size of pointer to the structure. Fixes Coverity errors 767, 768, 769, 770
svn path=/trunk/; revision=36519
Stefan Ginsberg [Thu, 25 Sep 2008 18:49:27 +0000 (18:49 +0000)]
- CmpOpenHiveFiles: If "Extension" is false then we won't have allocated any buffer, so there will never be a buffer to free
- Fix for Coverity Error CID: 29
svn path=/trunk/; revision=36518
Christoph von Wittich [Thu, 25 Sep 2008 18:10:23 +0000 (18:10 +0000)]
formatting fix
svn path=/trunk/; revision=36514
Christoph von Wittich [Thu, 25 Sep 2008 17:53:05 +0000 (17:53 +0000)]
set eol-style:native
svn path=/trunk/; revision=36513
James Tabor [Thu, 25 Sep 2008 15:39:33 +0000 (15:39 +0000)]
- Add Defer Window Position Handle type for multiple-window ? position structure.
svn path=/trunk/; revision=36510
Stefan Ginsberg [Thu, 25 Sep 2008 14:39:38 +0000 (14:39 +0000)]
- Implement and export PsIsSystemProcess and add it to the NDK
svn path=/trunk/; revision=36509
Stefan Ginsberg [Thu, 25 Sep 2008 14:29:11 +0000 (14:29 +0000)]
- Implement IoGetPagingIoPriority and fix its export
svn path=/trunk/; revision=36508
Stefan Ginsberg [Thu, 25 Sep 2008 14:25:22 +0000 (14:25 +0000)]
- Add WmiQueryTraceInformation, WmiTraceMessage and WmiTraceMessageVa stubs and exports
svn path=/trunk/; revision=36507
Aleksey Bragin [Thu, 25 Sep 2008 11:24:51 +0000 (11:24 +0000)]
- Fix one more totally "out of ideas how to create sections" MmCreateSection usage. Not only the MaximumSize is mandatory for file-backed sections, but an allocation type must be specified (SEC_COMMIT, and it's not the same as some humble "0" passed there as a value).
- Fix ReactOS's MmCreateDataFileSection to ignore 0 value in the MaximumSize (it has an additional check for MaximumSize being non-NULL, but this should be removed in future).
svn path=/trunk/; revision=36506
Cameron Gutman [Thu, 25 Sep 2008 00:01:39 +0000 (00:01 +0000)]
- Try again to fix build
svn path=/trunk/; revision=36499
Cameron Gutman [Wed, 24 Sep 2008 23:48:28 +0000 (23:48 +0000)]
- Fix build
svn path=/trunk/; revision=36498
Cameron Gutman [Wed, 24 Sep 2008 23:39:17 +0000 (23:39 +0000)]
Merge aicom-network-fixes up to r36496
- We now call the MiniportCheckForHang handler every two seconds
- We reset the miniport if it has detected a hang
- Added some IRQL checks
svn path=/trunk/; revision=36497
Stefan Ginsberg [Wed, 24 Sep 2008 19:13:08 +0000 (19:13 +0000)]
- MiQueryVirtualMemory shouldn't be called for kernel memory, so remove the special case code for a kernel address space. Also fixes a case where we would dereference an uninitialized pointer.
- Fix for Coverity Error CID: 773
svn path=/trunk/; revision=36494
Stefan Ginsberg [Wed, 24 Sep 2008 18:47:24 +0000 (18:47 +0000)]
- Remove deprecated macro
svn path=/trunk/; revision=36493
Stefan Ginsberg [Wed, 24 Sep 2008 17:32:14 +0000 (17:32 +0000)]
- Add ObpValidateAccessMask stub (only returns success for now) and call it from ObInsertObject
- Fix for Coverity Error CID: 9
svn path=/trunk/; revision=36491
Stefan Ginsberg [Wed, 24 Sep 2008 17:16:25 +0000 (17:16 +0000)]
- HalpXboxReadSector: Fail if we are out of memory instead of dereferencing null
- Fix for Coverity error CID: 464
svn path=/trunk/; revision=36490
Stefan Ginsberg [Wed, 24 Sep 2008 17:11:35 +0000 (17:11 +0000)]
- IoFlushAdapterBuffers: "AdapterObject" is not an optional parameter, it is vital to identify the DMA adapter. Remove the check which confused Coverity and ASSERTify this instead.
- Fix for Coverity error CID: 155
svn path=/trunk/; revision=36489
Christoph von Wittich [Wed, 24 Sep 2008 16:57:29 +0000 (16:57 +0000)]
more correct fix
svn path=/trunk/; revision=36488
Stefan Ginsberg [Wed, 24 Sep 2008 16:37:35 +0000 (16:37 +0000)]
- IopGetDiskInformation: Fail if we are out of memory instead of dereferencing null
- Fix for Coverity error CID: 469
- Also fix a (potential) memory leak
svn path=/trunk/; revision=36487
Stefan Ginsberg [Wed, 24 Sep 2008 16:19:52 +0000 (16:19 +0000)]
- Only dereference the KCB if we know it exists
- Fix for Coverity error CID: 279
svn path=/trunk/; revision=36486
Christoph von Wittich [Wed, 24 Sep 2008 15:42:33 +0000 (15:42 +0000)]
check for value > 0 before using it as array index
Fix for Coverity error CID: 438
svn path=/trunk/; revision=36485
Stefan Ginsberg [Wed, 24 Sep 2008 15:27:54 +0000 (15:27 +0000)]
- 64 bit fixes for Mm routines: Use SIZE_T and ULONG_PTR where appropriate
- Note: MSDN is wrong about Nt/ZwAllocateVirtualMemory's ZeroBits. It really is a ULONG_PTR.
svn path=/trunk/; revision=36484
Stefan Ginsberg [Wed, 24 Sep 2008 15:04:59 +0000 (15:04 +0000)]
- FsRtlBalanceReads: Fail if we are out of memory instead of dereferencing null
- Fix for Coverity error CID: 465
svn path=/trunk/; revision=36483
Stefan Ginsberg [Wed, 24 Sep 2008 14:53:28 +0000 (14:53 +0000)]
- RawQueryFsSizeInfo: Fail if we are out of memory instead of dereferencing null
svn path=/trunk/; revision=36482
Stefan Ginsberg [Wed, 24 Sep 2008 14:01:43 +0000 (14:01 +0000)]
- Fix some non-x86 FLOATOBJ_*
svn path=/trunk/; revision=36481
Art Yerkes [Wed, 24 Sep 2008 13:35:37 +0000 (13:35 +0000)]
Fix leaks reported by coverity 612-615. In each case, it'd be safe to free
NULL, and failure to allocate isn't the only dropthrough case, leading to
conversion buffer leaks.
svn path=/trunk/; revision=36480
Art Yerkes [Wed, 24 Sep 2008 12:56:30 +0000 (12:56 +0000)]
Fix my copypasta spotted by (coverity 1294)
svn path=/trunk/; revision=36479
Daniel Reimer [Wed, 24 Sep 2008 11:22:08 +0000 (11:22 +0000)]
Bug 3726: Translate file: netshell by Lars Martin Hambro
Bug 3729: Italian translation update by Paolo Devoti
Bug 3738: slovak translations and fixes by Mario Kacmar
Bug 3741: Korean translation of Taskmgr by Sengyu Kim
svn path=/trunk/; revision=36472
Timo Kreuzer [Wed, 24 Sep 2008 11:17:33 +0000 (11:17 +0000)]
- remove old test code
svn path=/trunk/; revision=36471
Aleksey Bragin [Wed, 24 Sep 2008 10:06:08 +0000 (10:06 +0000)]
- Create a VdmpInitialize function for NtVdmControl's initialize command.
- Remove NtEarlyVdmInitialize hack and csrss IVT/BDA copying hack, instead, copy the first page of physical memory to the beginning of process's virtual address space like NT does.
svn path=/trunk/; revision=36459
Aleksey Bragin [Wed, 24 Sep 2008 08:17:15 +0000 (08:17 +0000)]
Juriy Sidorov <jura@cp-lab.com>
- Fix existing font substitutions.
- Add FreeMono as substitution for Courier and Courier New.
- Optimize font substitution tables and make them easy to maintain.
See issue #3483 for more details.
svn path=/trunk/; revision=36451
Aleksey Bragin [Wed, 24 Sep 2008 08:12:41 +0000 (08:12 +0000)]
- Make SmCreateUserProcess accept two flags: the old "wait for" one, and a new "reserve 1Mb" one. NT reserves lower 1MB of address space when starting a subsystem process. ReactOS should too, however right now this change is disabled (leads to boot problems).
svn path=/trunk/; revision=36450
Andrew Munger [Wed, 24 Sep 2008 07:52:19 +0000 (07:52 +0000)]
Remove a overzealous check. MSDN says to avoid calling with NumberOfBytes == 0, but it is valid.
Addresses bug 3715.
svn path=/trunk/; revision=36449
Aleksey Bragin [Tue, 23 Sep 2008 20:44:31 +0000 (20:44 +0000)]
- Fix ~4.4 million handle limit bug due to memory corruption. ReactOS can now create 16 million handles as expected (thanks Alex).
svn path=/trunk/; revision=36439
Stefan Ginsberg [Tue, 23 Sep 2008 19:54:13 +0000 (19:54 +0000)]
- Attempt satisfy Alex
svn path=/trunk/; revision=36436
Ged Murphy [Tue, 23 Sep 2008 19:02:32 +0000 (19:02 +0000)]
Don't risk a negative array subscript. Fixes our one and only REVERSE_NEGATIVE error
Fix for Coverity error CID: 766
svn path=/trunk/; revision=36435
Christoph von Wittich [Tue, 23 Sep 2008 18:44:58 +0000 (18:44 +0000)]
return correct value in SETUPAPI_GetCurrentHwProfile
Fix for Coverity error CID: 782
svn path=/trunk/; revision=36434
Gregor Brunmar [Tue, 23 Sep 2008 17:01:40 +0000 (17:01 +0000)]
D3D9:
* More init values when creating a texture
svn path=/trunk/; revision=36429
Stefan Ginsberg [Tue, 23 Sep 2008 14:15:56 +0000 (14:15 +0000)]
- Add basic tracing to CmpReferenceKeyControlBlock, CmpDereferenceKeyControlBlock and CmpDereferenceKeyControlBlockWithLock
svn path=/trunk/; revision=36428
Aleksey Bragin [Tue, 23 Sep 2008 12:41:02 +0000 (12:41 +0000)]
- In success cases of NtAllocateVirtualMemory, return the real (page rounded!) base address and region size, not the possibly unaligned pointer and length which were passed to the function. These cases were hit when a region of memory was previously reserved, then a commit request came with unaligned base address and length, which match that previously reserved region after aligning.
svn path=/trunk/; revision=36427
Aleksey Bragin [Tue, 23 Sep 2008 11:45:40 +0000 (11:45 +0000)]
[FORMATTING]
- Reformat to the kernel coding style.
svn path=/trunk/; revision=36426
Aleksey Bragin [Tue, 23 Sep 2008 10:47:10 +0000 (10:47 +0000)]
[FORMATTING]
- Apply standard header.
svn path=/trunk/; revision=36425
Art Yerkes [Tue, 23 Sep 2008 10:17:27 +0000 (10:17 +0000)]
Didn't notice that bufferSize is used by RegQueryValueEx. Now we count in
bytes with bufferSize and count in chars just in the subscript.
Noticed by Christoph_Vw
svn path=/trunk/; revision=36424
Art Yerkes [Tue, 23 Sep 2008 09:36:23 +0000 (09:36 +0000)]
Initialize DbgLoadOptions from the start. It would be unitialized if a bootcd
was made without having the right section in txtsetup.sif.
svn path=/trunk/; revision=36423
Art Yerkes [Tue, 23 Sep 2008 09:28:44 +0000 (09:28 +0000)]
Count the end of the szApplicationName in the right units. (coverity 551).
svn path=/trunk/; revision=36422
Art Yerkes [Tue, 23 Sep 2008 09:09:16 +0000 (09:09 +0000)]
Fix a legitimate overrun in _widths (coverity 575), and try not to be as
clever.
svn path=/trunk/; revision=36421
Art Yerkes [Tue, 23 Sep 2008 08:58:19 +0000 (08:58 +0000)]
This bug could've caused mayhem in the icon cache. (coverity 790).
svn path=/trunk/; revision=36420
Art Yerkes [Tue, 23 Sep 2008 08:43:49 +0000 (08:43 +0000)]
Fix possible overrun of the last byte of dbuf (coverity 552).
svn path=/trunk/; revision=36419
Christoph von Wittich [Tue, 23 Sep 2008 08:04:57 +0000 (08:04 +0000)]
overrun of static array
Fix for Coverity error CID: 529
svn path=/trunk/; revision=36418
Aleksey Bragin [Tue, 23 Sep 2008 08:04:23 +0000 (08:04 +0000)]
- The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive.
- Fix for Coverity error CID: 280
svn path=/trunk/; revision=36417
Christoph von Wittich [Tue, 23 Sep 2008 07:50:59 +0000 (07:50 +0000)]
overrun of static array
Fix for Coverity error CID: 532
svn path=/trunk/; revision=36416
Christoph von Wittich [Tue, 23 Sep 2008 07:44:15 +0000 (07:44 +0000)]
overrun of static array
Fix for Coverity error CID: 552
svn path=/trunk/; revision=36415
Aleksey Bragin [Tue, 23 Sep 2008 07:40:40 +0000 (07:40 +0000)]
- Preinitialize ValueData with NULL.
- Fix for Coverity error CID: 772.
svn path=/trunk/; revision=36414
Christoph von Wittich [Tue, 23 Sep 2008 07:38:00 +0000 (07:38 +0000)]
overrun of static array
Fix for Coverity error CID: 546 + 547.
svn path=/trunk/; revision=36413
Christoph von Wittich [Tue, 23 Sep 2008 07:33:44 +0000 (07:33 +0000)]
overrun of static array
Fix for Coverity error CID: 548.
svn path=/trunk/; revision=36412
Christoph von Wittich [Tue, 23 Sep 2008 07:05:18 +0000 (07:05 +0000)]
don't free memory which is not allocated yet
Fix for Coverity error CID: 789.
svn path=/trunk/; revision=36411
Christoph von Wittich [Tue, 23 Sep 2008 06:55:05 +0000 (06:55 +0000)]
fix heap corruption when lpStringToFind is NULL
Fix for Coverity error CID: 775.
svn path=/trunk/; revision=36410
Art Yerkes [Tue, 23 Sep 2008 05:58:51 +0000 (05:58 +0000)]
some detritus exposed by coverity.
svn path=/trunk/; revision=36409
James Tabor [Mon, 22 Sep 2008 15:49:38 +0000 (15:49 +0000)]
Add UpdateLayeredWindowIndirect to def and cleanup and add a new type in dce.h.
svn path=/trunk/; revision=36405
Christoph von Wittich [Mon, 22 Sep 2008 14:29:28 +0000 (14:29 +0000)]
sync riched20 with wine 1.1.5
svn path=/trunk/; revision=36404
Christoph von Wittich [Mon, 22 Sep 2008 14:20:27 +0000 (14:20 +0000)]
sync oleaut32 with wine 1.1.5
svn path=/trunk/; revision=36403
Christoph von Wittich [Mon, 22 Sep 2008 12:18:12 +0000 (12:18 +0000)]
fix some memory leaks (patch by Ged)
svn path=/trunk/; revision=36402
Stefan Ginsberg [Mon, 22 Sep 2008 11:46:51 +0000 (11:46 +0000)]
- Remove deprecated output
svn path=/trunk/; revision=36401
Christoph von Wittich [Mon, 22 Sep 2008 11:38:51 +0000 (11:38 +0000)]
the time has COM
import stdole32.tlb from wine
svn path=/trunk/; revision=36400
James Tabor [Mon, 22 Sep 2008 00:52:24 +0000 (00:52 +0000)]
- Add UPDATELAYEREDWINDOWINFO structure and UpdateLayeredWindowIndirect and types to psdk.
- Move UpdateLayeredWindow to def and change it to UpdateLayeredWindowIndirect.
svn path=/trunk/; revision=36398
Eric Kohl [Sun, 21 Sep 2008 21:18:42 +0000 (21:18 +0000)]
Sync to Wine-0.9.58
- Rob Shearman <rob@codeweavers.com> Thu, 14 Feb 2008
widl: Remove unused headers.
- Rob Shearman <rob@codeweavers.com> Thu, 14 Feb 2008
widl: Guard the inclusion of unistd.h.
- Rob Shearman <rob@codeweavers.com> Tue, 19 Feb 2008
Add the nounistd option to all lex source files.
- Alexandre Julliard <julliard@winehq.org> Tue, 19 Feb 2008
Avoid the nounistd option that doesn't exist on older flex, define YY_NO_UNISTD_H...
- Dan Hipschman <dsh@linux.ucla.edu> Thu, 21 Feb 2008
widl: Allow is_string_type to work for typedef'd types.
- Gerald Pfeifer <gerald@pfeifer.com> Fri, 22 Feb 2008
widl: Include <unistd.h> for prototype of unlink().
- Dan Hipschman <dsh@linux.ucla.edu> Wed, 19 Mar 2008
widl: Ignore libraries in imported IDL files.
- Dan Hipschman <dsh@linux.ucla.edu> Thu, 20 Mar 2008
widl: Make structures with FC_ENUM16 fields complex.
svn path=/trunk/; revision=36394
Eric Kohl [Sun, 21 Sep 2008 19:57:05 +0000 (19:57 +0000)]
Define TRUE only if it hasn't been defined before
svn path=/trunk/; revision=36390
Colin Finck [Sun, 21 Sep 2008 17:01:55 +0000 (17:01 +0000)]
Forgot these files, sorry...
svn path=/trunk/; revision=36385
Colin Finck [Sun, 21 Sep 2008 15:24:30 +0000 (15:24 +0000)]
Sync msi with Wine 1.1.5
svn path=/trunk/; revision=36384
Eric Kohl [Sun, 21 Sep 2008 15:19:52 +0000 (15:19 +0000)]
EnumDependentServicesA/W and EnumServicesStatusA/W don't fix up pointers if the service manager returns an error.
This fixes bug #3737.
Patch by Michael Martin aka bugboy <martinmnet@hotmail.com>.
svn path=/trunk/; revision=36383
Cameron Gutman [Sun, 21 Sep 2008 14:43:43 +0000 (14:43 +0000)]
- Merge aicom-network-fixes up to r36381
svn path=/trunk/; revision=36382
Christoph von Wittich [Sun, 21 Sep 2008 14:12:52 +0000 (14:12 +0000)]
fix another typo...
svn path=/trunk/; revision=36378
Eric Kohl [Sun, 21 Sep 2008 13:55:53 +0000 (13:55 +0000)]
[FORMATTING] No code changes!
svn path=/trunk/; revision=36377
Christoph von Wittich [Sun, 21 Sep 2008 13:24:00 +0000 (13:24 +0000)]
sync jscript with wine 1.1.5
svn path=/trunk/; revision=36376
Christoph von Wittich [Sun, 21 Sep 2008 13:05:48 +0000 (13:05 +0000)]
this hack wasn't supposed to be committed
svn path=/trunk/; revision=36375
Christoph von Wittich [Sun, 21 Sep 2008 13:03:20 +0000 (13:03 +0000)]
sync msxml3 with wine 1.1.5
svn path=/trunk/; revision=36374
Colin Finck [Sun, 21 Sep 2008 13:00:40 +0000 (13:00 +0000)]
Wow, WriteConfigurationFile() in rbuild never worked since it was added in r13496 over 3 years ago! :-)
Thus, the generated "roscfg.h" was always empty, but for whatever reason modules started to include it.
I removed all dependencies on this file and the function itself from rbuild.
svn path=/trunk/; revision=36373
Cameron Gutman [Sun, 21 Sep 2008 12:41:26 +0000 (12:41 +0000)]
- Merge aicom-network-fixes up to r36371
svn path=/trunk/; revision=36372
Gregor Brunmar [Sun, 21 Sep 2008 12:25:38 +0000 (12:25 +0000)]
D3D9:
* Added stubs for IDirect3DTexture9 methods
* Implemented IDirect3DTexture9::GetDevice()
* Moved device locking to the D3D9BaseObject instead of in each child object
svn path=/trunk/; revision=36370
Christoph von Wittich [Sun, 21 Sep 2008 12:12:37 +0000 (12:12 +0000)]
fix two nice typo's
(array subscript was above array bounds)
svn path=/trunk/; revision=36369
Christoph von Wittich [Sun, 21 Sep 2008 12:00:07 +0000 (12:00 +0000)]
sync msiexec with wine 1.1.5
svn path=/trunk/; revision=36368
Aleksey Bragin [Sun, 21 Sep 2008 11:34:04 +0000 (11:34 +0000)]
- FileOffset is 32bit long, not 64bit, so no reason in additional casting.
- Fix a ULONG -> BOOLEAN conversion warning.
svn path=/trunk/; revision=36367
Christoph von Wittich [Sun, 21 Sep 2008 06:52:54 +0000 (06:52 +0000)]
fix wrong casts
svn path=/trunk/; revision=36366
Christoph von Wittich [Sun, 21 Sep 2008 06:42:21 +0000 (06:42 +0000)]
fix brackets
svn path=/trunk/; revision=36365
Eric Kohl [Sat, 20 Sep 2008 20:28:23 +0000 (20:28 +0000)]
[FORMATTING] No code changes!
svn path=/trunk/; revision=36357