reactos.git
4 years ago[BROWSEUI]
Giannis Adamopoulos [Sun, 5 Feb 2017 13:41:45 +0000 (13:41 +0000)]
[BROWSEUI]
-CExplorerBand: Commit the last part of the work submitted by Sylvain Deverre. Sorry for not committing all this time. Unfortunately some parts were changed and some parts don't work well and we need to debug it a bit.
CORE-10838

svn path=/trunk/; revision=73706

4 years ago[SHELL32] -CDesktopBrowser: Implement handling FCIDM_DESKBROWSER_REFRESH.
Giannis Adamopoulos [Sun, 5 Feb 2017 12:35:47 +0000 (12:35 +0000)]
[SHELL32] -CDesktopBrowser: Implement handling FCIDM_DESKBROWSER_REFRESH.

svn path=/trunk/; revision=73705

4 years ago[SHELL32] -The only change I did in the previous patch was buggy.
Giannis Adamopoulos [Sun, 5 Feb 2017 12:27:53 +0000 (12:27 +0000)]
[SHELL32] -The only change I did in the previous patch was buggy.

svn path=/trunk/; revision=73704

4 years ago[SHELL32]
Giannis Adamopoulos [Sun, 5 Feb 2017 12:15:59 +0000 (12:15 +0000)]
[SHELL32]
- Implement View tab in Folder options dialog.
CORE-12540
Patch by Katayama Hirofumi MZ with a tiny improvement by me to refresh explorer in a better way.

svn path=/trunk/; revision=73703

4 years ago[BROWSEUI] - CShellBrowser: Implement Refresh menu item in the View menu.
Giannis Adamopoulos [Sun, 5 Feb 2017 11:01:24 +0000 (11:01 +0000)]
[BROWSEUI] - CShellBrowser: Implement Refresh menu item in the View menu.

svn path=/trunk/; revision=73702

4 years ago[FATTEN][KBDTOOL][RSYM]
Thomas Faber [Sun, 5 Feb 2017 10:46:29 +0000 (10:46 +0000)]
[FATTEN][KBDTOOL][RSYM]
- Fix clang warnings

svn path=/trunk/; revision=73701

4 years ago[BOOTLIB]
Thomas Faber [Sun, 5 Feb 2017 10:45:50 +0000 (10:45 +0000)]
[BOOTLIB]
- Add missing asm dependency

svn path=/trunk/; revision=73700

4 years ago[CONTROL]
Kamil Hornicek [Sun, 5 Feb 2017 10:28:42 +0000 (10:28 +0000)]
[CONTROL]
- Use strsafe functions. CID 515200

svn path=/trunk/; revision=73699

4 years ago[ZLIB]
Thomas Faber [Sun, 5 Feb 2017 10:28:40 +0000 (10:28 +0000)]
[ZLIB]
- Update to 1.2.11
CORE-12753 #resolve

svn path=/trunk/; revision=73698

4 years ago[HHPCOMP]
Thomas Faber [Sun, 5 Feb 2017 09:58:22 +0000 (09:58 +0000)]
[HHPCOMP]
- Avoid implicit function declarations

svn path=/trunk/; revision=73697

4 years ago[TOOLS]
Thomas Faber [Sun, 5 Feb 2017 09:51:33 +0000 (09:51 +0000)]
[TOOLS]
- Add /EHsc for all C++ sources under MSVC instead of doing it per-file

svn path=/trunk/; revision=73696

4 years ago[ZLIBHOST]
Thomas Faber [Sun, 5 Feb 2017 09:42:43 +0000 (09:42 +0000)]
[ZLIBHOST]
- We only need the minimal Z_SOLO functionality. Avoids some compiler warnings.

svn path=/trunk/; revision=73695

4 years ago[BOOTLIB]
Thomas Faber [Sun, 5 Feb 2017 08:50:40 +0000 (08:50 +0000)]
[BOOTLIB]
- Remove an unused variable aka fix GCC build

svn path=/trunk/; revision=73694

4 years ago[ROSLOAD]: Implement most of OslMain, which will try to initialize BootLib in Virtual...
Alex Ionescu [Sun, 5 Feb 2017 06:02:11 +0000 (06:02 +0000)]
[ROSLOAD]: Implement most of OslMain, which will try to initialize BootLib in Virtual Protected Mode (mostly unimplemented).
[BOOTLIB]: Fix GCC build.
Bootmgr now correctly switches execution into rosload, which must now be implemented.

svn path=/trunk/; revision=73693

4 years ago[BOOTLIB]: Implement BlFwGetParameters.
Alex Ionescu [Sun, 5 Feb 2017 05:35:44 +0000 (05:35 +0000)]
[BOOTLIB]: Implement BlFwGetParameters.
[BOOTLIB]: Implement ImgpCopyApplicationBootDevice except for partition devices;
[BOOTLIB]: Implement ImgpInitializeBootApplicationParameters.
[BOOTLIB]: Fix bug in BlMmGetMemoryMap.
[BOOTLIB]: Simplify MmMdCopyList.

svn path=/trunk/; revision=73692

4 years ago[BOOTLIB]: Implement BlMmGetMemoryMap.
Alex Ionescu [Sun, 5 Feb 2017 01:54:52 +0000 (01:54 +0000)]
[BOOTLIB]: Implement BlMmGetMemoryMap.
[BOOTLIB]: Implement MmMdCountList, MmMdInitializeList, MmMdCopyList
[BOOTLIB]: Bugfixes.

svn path=/trunk/; revision=73691

4 years agofix reactos_support_code MSVC build.
Sylvain Petreolle [Sun, 5 Feb 2017 01:03:45 +0000 (01:03 +0000)]
fix reactos_support_code MSVC build.

svn path=/trunk/; revision=73690

4 years ago[BOOTLIB]: Fix from hermes for BlReplaceBootOptions
Alex Ionescu [Sun, 5 Feb 2017 00:05:19 +0000 (00:05 +0000)]
[BOOTLIB]: Fix from hermes for BlReplaceBootOptions
[BOOTLIB]: More WIP transfer code.

svn path=/trunk/; revision=73689

4 years ago[BOOTLIB][CRT]
Thomas Faber [Sat, 4 Feb 2017 23:50:32 +0000 (23:50 +0000)]
[BOOTLIB][CRT]
- Fix GCC build

svn path=/trunk/; revision=73688

4 years ago[BOOTLIB]: Begin adding support for transferring to newly loaded i386 image.
Alex Ionescu [Sat, 4 Feb 2017 21:59:52 +0000 (21:59 +0000)]
[BOOTLIB]: Begin adding support for transferring to newly loaded i386 image.

svn path=/trunk/; revision=73687

4 years ago[HIVECLS|MSPAINT] Add Edit menu item for bitmaps. CORE-12679 #resolve
Mark Jansen [Sat, 4 Feb 2017 21:26:59 +0000 (21:26 +0000)]
[HIVECLS|MSPAINT] Add Edit menu item for bitmaps. CORE-12679 #resolve

svn path=/trunk/; revision=73686

4 years ago[BOOTLIB]: Super cool that y'all went and fixed typos in the codebase, but fixing...
Alex Ionescu [Sat, 4 Feb 2017 20:45:02 +0000 (20:45 +0000)]
[BOOTLIB]: Super cool that y'all went and fixed typos in the codebase, but fixing UEFI Official Specification Headers in our source tree is a bit much. Please submit a pull request to EDK-II if you'd like.

svn path=/trunk/; revision=73685

4 years ago[BOOTMGR]: ThFabba making me jealous. Fix a logic bug that Coverity *didn't* find...
Alex Ionescu [Sat, 4 Feb 2017 19:45:38 +0000 (19:45 +0000)]
[BOOTMGR]: ThFabba making me jealous. Fix a logic bug that Coverity *didn't* find. Ha. I'm better.
[BOOTLIB]: Apply the "Fuck You Binutils" hack only for ld-generated files, to unbreak MSVC UEFI boot.

svn path=/trunk/; revision=73684

4 years ago[FASTFAT]
Pierre Schweitzer [Sat, 4 Feb 2017 19:37:40 +0000 (19:37 +0000)]
[FASTFAT]
vfatMakeFCBFromDirEntry(), use appropriate tag on free.
Dedicated to Thomas :-)

svn path=/trunk/; revision=73683

4 years ago[CONFIGURE]: Better fix thanks to gigaherz.
Alex Ionescu [Sat, 4 Feb 2017 18:55:47 +0000 (18:55 +0000)]
[CONFIGURE]: Better fix thanks to gigaherz.

svn path=/trunk/; revision=73682

4 years ago[LIBUSB]
Thomas Faber [Sat, 4 Feb 2017 18:36:13 +0000 (18:36 +0000)]
[LIBUSB]
- Avoid pointless assignment in CDMAMemoryManager::Initialize. CID 515285

svn path=/trunk/; revision=73681

4 years ago[CONFIGURE]: Hack-support VS15 (VS 2017)
Alex Ionescu [Sat, 4 Feb 2017 17:59:32 +0000 (17:59 +0000)]
[CONFIGURE]: Hack-support VS15 (VS 2017)

svn path=/trunk/; revision=73680

4 years ago[FASTFAT]
Pierre Schweitzer [Sat, 4 Feb 2017 17:54:38 +0000 (17:54 +0000)]
[FASTFAT]
In vfatMakeFCBFromDirEntry(), handle vfatFCBInitializeCacheFromVolume() failure

svn path=/trunk/; revision=73679

4 years ago[FASTFAT]
Pierre Schweitzer [Sat, 4 Feb 2017 17:52:39 +0000 (17:52 +0000)]
[FASTFAT]
Drop a hack that seems no longer needed

svn path=/trunk/; revision=73678

4 years ago[BOOTLIB]
Thomas Faber [Sat, 4 Feb 2017 17:41:14 +0000 (17:41 +0000)]
[BOOTLIB]
- Zero the correct structure in EtfsOpen. CID 1341378

svn path=/trunk/; revision=73677

4 years ago[SYSDM]
Thomas Faber [Sat, 4 Feb 2017 17:27:49 +0000 (17:27 +0000)]
[SYSDM]
- Fix wrong sizeof expression in DeleteHardwareProfile. CID 1322188

svn path=/trunk/; revision=73676

4 years ago[BOOTLIB]
Thomas Faber [Sat, 4 Feb 2017 17:00:26 +0000 (17:00 +0000)]
[BOOTLIB]
- Fix operator precedence in call to MmMdAddDescriptorToList. CID 1341191.

svn path=/trunk/; revision=73675

4 years ago[STOBJECT]
Sylvain Petreolle [Sat, 4 Feb 2017 16:12:15 +0000 (16:12 +0000)]
[STOBJECT]
Add a partial French translation.
Remove hardcoded string.
CORE-12490 #resolve

svn path=/trunk/; revision=73674

4 years ago[STOBJECT]
Sylvain Petreolle [Sat, 4 Feb 2017 15:35:16 +0000 (15:35 +0000)]
[STOBJECT]
Fix syntax of power resources.
CORE-12490

svn path=/trunk/; revision=73673

4 years ago[SHELL32] -Remove two annoying prints. A FIXME comment is more than enough.
Giannis Adamopoulos [Sat, 4 Feb 2017 15:12:25 +0000 (15:12 +0000)]
[SHELL32] -Remove two annoying prints. A FIXME comment is more than enough.

svn path=/trunk/; revision=73672

4 years ago[BROWSEUI] - Remove useless print.
Giannis Adamopoulos [Fri, 3 Feb 2017 22:15:13 +0000 (22:15 +0000)]
[BROWSEUI] - Remove useless print.

svn path=/trunk/; revision=73671

4 years ago[SETUPAPI]
Kamil Hornicek [Thu, 2 Feb 2017 19:48:38 +0000 (19:48 +0000)]
[SETUPAPI]
- fix a mix up, caught by Mark

svn path=/trunk/; revision=73670

4 years ago[SETUPAPI]
Kamil Hornicek [Thu, 2 Feb 2017 19:41:19 +0000 (19:41 +0000)]
[SETUPAPI]
- remove logically dead code in SetupDiGetClassImageIndex, CID 500046
- prevent null pointer dereference in SetupDiGetClassDevPropertySheetsA, CID 500676
- use strsafe functions in SETUP_CreateDevicesListFromEnumerator, CID 514263
- fix a check and adjust the logic in SetupDiLoadClassIcon to remove dead code and possible null pointer dereference CID 1250279, CID 1250287

svn path=/trunk/; revision=73669

4 years ago[CALC]
Kamil Hornicek [Thu, 2 Feb 2017 11:07:01 +0000 (11:07 +0000)]
[CALC]
- Fix a(n) (im)possible buffer overrun. Just a defensive measure in case some future work on calc would trigger this. CID 716050

svn path=/trunk/; revision=73668

4 years ago[NTOS]
Thomas Faber [Wed, 1 Feb 2017 23:01:00 +0000 (23:01 +0000)]
[NTOS]
- Remove a useless declaration.
CORE-12729 #resolve

svn path=/trunk/; revision=73666

4 years ago[TRANSLATIONS] Addendum to r73662, fix the build.
Mark Jansen [Wed, 1 Feb 2017 22:45:04 +0000 (22:45 +0000)]
[TRANSLATIONS] Addendum to r73662, fix the build.

svn path=/trunk/; revision=73665

4 years ago[SHELL32] -CDefView: Calculate correctly the position of the cursor over the icon...
Giannis Adamopoulos [Wed, 1 Feb 2017 21:43:20 +0000 (21:43 +0000)]
[SHELL32] -CDefView: Calculate correctly the position of the cursor over the icon. Call ImageList_DragEnter only after we are sure that DragEnter will succeed.

svn path=/trunk/; revision=73664

4 years ago[MSPORTS]
Kamil Hornicek [Wed, 1 Feb 2017 18:36:40 +0000 (18:36 +0000)]
[MSPORTS]
- Check for failure when calling SetupDiGetActualSectionToInstallW so we don't pass garbage to SetupInstallFromInfSectionW. CID 715920

svn path=/trunk/; revision=73663

4 years ago[TRANSLATIONS]
Kamil Hornicek [Wed, 1 Feb 2017 14:45:59 +0000 (14:45 +0000)]
[TRANSLATIONS]
- fix, update and add some czech translations + two tiny "improvements" in english ones

In case anyone wants to continue - these modules lack czech resources completely:
(and I suggest doing getuname first)
clip comp doskey eventcreate mode taskkill tree whoami wmic xcopy ipconfig net clb diskpart acppage fontext browseui getuname iernonce lsasrv modemui msports rasdlg samsrv tapiui localmon

svn path=/trunk/; revision=73662

4 years ago[SHELL32] - CDefView: Implement rudimentary support for drag icons. For now we only...
Giannis Adamopoulos [Wed, 1 Feb 2017 14:22:45 +0000 (14:22 +0000)]
[SHELL32] - CDefView: Implement rudimentary support for drag icons. For now we only show the icon of the first item (no caption or other icons yet).

svn path=/trunk/; revision=73661

4 years ago[SHELL32] Implement support for IID_IDropTarget in CDesktopFolder::GetUIObjectOf...
Giannis Adamopoulos [Wed, 1 Feb 2017 13:31:55 +0000 (13:31 +0000)]
[SHELL32] Implement support for IID_IDropTarget in CDesktopFolder::GetUIObjectOf and CDrivesFolder::GetUIObjectOf. Fixes dragging items to the icons of My documents, Recycle bin or drive.

svn path=/trunk/; revision=73660

4 years ago[WELCOME]: Addendum to r73656: The application title is also customizable!
Hermès Bélusca-Maïto [Wed, 1 Feb 2017 03:51:40 +0000 (03:51 +0000)]
[WELCOME]: Addendum to r73656: The application title is also customizable!
Change also the name of some helper functions.

svn path=/trunk/; revision=73658

4 years ago[WELCOME]: Follow-up to r73590: Load a "welcome.ini" configuration file inside the...
Hermès Bélusca-Maïto [Wed, 1 Feb 2017 03:12:56 +0000 (03:12 +0000)]
[WELCOME]: Follow-up to r73590: Load a "welcome.ini" configuration file inside the path of the welcome.exe application, if present, that specifies few default values to use for the interface, as well as the path (possibly relative) to a subdirectory containing ini files specifying localized resources for the interface.
[BOOTDATA]: Add a default "welcome.ini" file to the build, only for hybrid-cds. The ini files containing the localized resources are automatically converted to UTF-16 prior to inclusion in the hybridcd.

svn path=/trunk/; revision=73656

4 years ago[CMAKE]: Fix the dependencies for the hybridcd.
Hermès Bélusca-Maïto [Wed, 1 Feb 2017 02:18:30 +0000 (02:18 +0000)]
[CMAKE]: Fix the dependencies for the hybridcd.

svn path=/trunk/; revision=73654

4 years ago[ISOMBR]: Pad isombr.S to the size expected by the 'isohybrid' tool.
Hermès Bélusca-Maïto [Tue, 31 Jan 2017 22:08:19 +0000 (22:08 +0000)]
[ISOMBR]: Pad isombr.S to the size expected by the 'isohybrid' tool.

svn path=/trunk/; revision=73651

4 years ago[BOOTLIB]
Thomas Faber [Tue, 31 Jan 2017 13:15:29 +0000 (13:15 +0000)]
[BOOTLIB]
- Correctly check for floppy devices in BlockIoEfiGetDeviceInformation. CID 1341189.

svn path=/trunk/; revision=73643

4 years ago[MSPAINT]
Thomas Faber [Tue, 31 Jan 2017 12:53:39 +0000 (12:53 +0000)]
[MSPAINT]
- Add missing break in CMainWindow::OnCommand/IDM_FORMATICONBAR. CID 1322024.

svn path=/trunk/; revision=73642

4 years ago[LIBWINE]
Thomas Faber [Tue, 31 Jan 2017 12:46:37 +0000 (12:46 +0000)]
[LIBWINE]
- Fix broken indentation (-Wmisleading-indentation)

svn path=/trunk/; revision=73641

4 years ago[ACPI]
Thomas Faber [Mon, 30 Jan 2017 19:20:54 +0000 (19:20 +0000)]
[ACPI]
- Fix some broken indentation (and GCC6 -Wmisleading-indentation warnings with it)

svn path=/trunk/; revision=73637

4 years ago[FREELDR]
Thomas Faber [Mon, 30 Jan 2017 13:50:10 +0000 (13:50 +0000)]
[FREELDR]
- Correctly check for vertical retrace in PcVideoSync. CID 513066.

svn path=/trunk/; revision=73636

4 years ago[DHCPCSVC]
Thomas Faber [Mon, 30 Jan 2017 13:43:21 +0000 (13:43 +0000)]
[DHCPCSVC]
- Addendum to r69652: Avoid some more "Operands don't affect result" warnings. CID 515151, 515152, 515153

svn path=/trunk/; revision=73635

4 years ago[PSDK]
Thomas Faber [Mon, 30 Jan 2017 13:33:46 +0000 (13:33 +0000)]
[PSDK]
- Remove incorrect bit masking from IsRecognizedPartition & IsContainerPartition. CID 1341188.

svn path=/trunk/; revision=73634

4 years ago[FRAMEDYN]
Thomas Faber [Mon, 30 Jan 2017 13:15:41 +0000 (13:15 +0000)]
[FRAMEDYN]
- Fix integer overflow checks. CID 110198112483801248381

svn path=/trunk/; revision=73633

4 years ago[NDK]
Thomas Faber [Mon, 30 Jan 2017 11:45:51 +0000 (11:45 +0000)]
[NDK]
- Add missing lpctypes.h include in lpcfuncs.h
- Fix some file header comments

svn path=/trunk/; revision=73632

4 years ago[PING]: Convert ping to use ConStreams. Also fix file redirection.
Hermès Bélusca-Maïto [Sun, 29 Jan 2017 20:29:28 +0000 (20:29 +0000)]
[PING]: Convert ping to use ConStreams. Also fix file redirection.
CORE-12122 #resolve

svn path=/trunk/; revision=73626

4 years ago[CMD]: The 'type' command can open & display files opened with write access.
Hermès Bélusca-Maïto [Sun, 29 Jan 2017 17:45:34 +0000 (17:45 +0000)]
[CMD]: The 'type' command can open & display files opened with write access.

svn path=/trunk/; revision=73623

4 years ago[TREE]: Rework the utility (use explicit UNICODE, use WIN32 types, remove useless...
Hermès Bélusca-Maïto [Sun, 29 Jan 2017 16:51:23 +0000 (16:51 +0000)]
[TREE]: Rework the utility (use explicit UNICODE, use WIN32 types, remove useless dependency to user32...), and add support for console ConUtils streams.
CORE-12677 #resolve

svn path=/trunk/; revision=73622

4 years ago[FREELDR]
Hermès Bélusca-Maïto [Sun, 29 Jan 2017 15:43:12 +0000 (15:43 +0000)]
[FREELDR]
- Simplify the implementation of the 'DiskGetBootPath' function;
- Cache the retrived freeldr boot path (corresponding to a given 'FrldrBootDrive' number);
- Introduce a 'DiskIsCdRomDrive' function to attempt to fix CORE-12692 .

svn path=/trunk/; revision=73621

4 years ago[CALC]
Thomas Faber [Sun, 29 Jan 2017 14:25:28 +0000 (14:25 +0000)]
[CALC]
- Do not push memory stores onto the operation stack since they can't be acted upon. Based on a patch by Katayama Hirofumi MZ.
CORE-12325 #resolve

svn path=/trunk/; revision=73620

4 years ago[SHELL32]: Fix build on *sane* compilers (wth, is that an assignment without the...
Hermès Bélusca-Maïto [Sun, 29 Jan 2017 13:48:39 +0000 (13:48 +0000)]
[SHELL32]: Fix build on *sane* compilers (wth, is that an assignment without the equal sign, or a called constructor, missing its parentheses?!).

svn path=/trunk/; revision=73619

4 years ago[FREELDR]: Part 3 of my local changes merging:
Hermès Bélusca-Maïto [Sun, 29 Jan 2017 02:35:28 +0000 (02:35 +0000)]
[FREELDR]: Part 3 of my local changes merging:
- Remove the DiskVtbl functions (machxbox.c) of the XBOX and share them instead with those of the PC, since they are basically the same.
  They just however differ by which 'DiskGetPartitionEntry' function they use. To cope with this, 'DiskGetPartitionEntry' becomes a pointer
  to either the default function 'DiskGetMbrPartitionEntry' (which indeed assumes a MBR-layout, see partition.c), or the special function
  'XboxDiskGetPartitionEntry' in the case of partitionless XBOX disks.
  Note that, by the way, partition.c should in the future support GPT-layout disks as well...
- The boot devices pre-initialization code can also be shared as well, thus getting rid of 'XboxInitializeBootDevices', because we note that
  this is exactly what the (old) XBOX version of 'DetectBiosDisks' did at its beginning.
- But then, we can also share 'DetectBiosDisks' XBOX code with its PC version, and also *fix* the PC code version as well!
  'DetectSystem' and 'DetectBiosDisks' are therefore merged *as they should be*. Thanks to the boot devices pre-initialization code that has
  run before the hardware detection, 'DetectBiosDisks' can just use the cached information.
- Now we correctly initialize the PC root HW system configuration key: we first create it, then, after the bios disks (floppies + HDDs) are enumerated
  we set the BIOS INT13h disk data to the system key's configuration data.

svn path=/trunk/; revision=73618

4 years ago[FREELDR]
Thomas Faber [Sun, 29 Jan 2017 00:00:22 +0000 (00:00 +0000)]
[FREELDR]
- Correctly check for buffer overflow in DetectPnpBios. Patch by Serge Gautherie.
CORE-12623 #resolve

svn path=/trunk/; revision=73617

4 years ago[FREELDR]: More local changes merging, part 2/x:
Hermès Bélusca-Maïto [Sat, 28 Jan 2017 23:47:35 +0000 (23:47 +0000)]
[FREELDR]: More local changes merging, part 2/x:
- Move the HW detection code specific to the PC architecture from hardware.c to machpc.c, keeping in hardware.c the code that is shared between PC and XBOX.
- Move what remained of i386disk.c into pcdisk.c (specific to PC architecture) + code formatting.
- Move what remained of xboxhw.c into machxbox.c (specific to XBOX architecture); we discover that some code related to disk management is actually shared with PC architecture (in hwdisk.c): hwdisk.c therefore contains disk-management routines common to both PC & XBOX.
- xboxdisk.c: Code formatting only.
- Cleanup in disk.c/disk.h

svn path=/trunk/; revision=73616

4 years ago[EXPLORER] Re-save the start menu banner so that we can display it again (and touch...
Mark Jansen [Sat, 28 Jan 2017 23:05:04 +0000 (23:05 +0000)]
[EXPLORER] Re-save the start menu banner so that we can display it again (and touch the .rc so it will be used).

svn path=/trunk/; revision=73615

4 years ago[SHELL32] - CDefView: When dragging an item it shouldn't interact with itself. So...
Giannis Adamopoulos [Sat, 28 Jan 2017 21:43:53 +0000 (21:43 +0000)]
[SHELL32] - CDefView: When dragging an item it shouldn't interact with itself. So you can move a folder in itself. Highlight the item that we are dragging over if it can accept the item that is being dragged.

svn path=/trunk/; revision=73614

4 years ago[CMAKE]
Thomas Faber [Sat, 28 Jan 2017 21:41:12 +0000 (21:41 +0000)]
[CMAKE]
- Add missing target-level dependency when passing a target to add_rostests_file

svn path=/trunk/; revision=73613

4 years ago[EXPLORER]
David Quintana [Sat, 28 Jan 2017 21:11:39 +0000 (21:11 +0000)]
[EXPLORER]
* Recreated the start menu banner as a SVG file in Inkscape.
* Deleted old PSD (Photoshop) files.
* Replaced the explorer banner BMP with one exported by Inkscape from the SVG file.
The end result is slightly sharper text, but otherwise identical.

svn path=/trunk/; revision=73612

4 years agoFix build.
Hermès Bélusca-Maïto [Sat, 28 Jan 2017 20:11:38 +0000 (20:11 +0000)]
Fix build.

svn path=/trunk/; revision=73611

4 years ago[FREELDR]: Gently merge my local changes, part 1/x:
Hermès Bélusca-Maïto [Sat, 28 Jan 2017 20:06:03 +0000 (20:06 +0000)]
[FREELDR]: Gently merge my local changes, part 1/x:
- Adjust the prototype of DiskGetBootPath;
- Add back 1 HW helper function.

svn path=/trunk/; revision=73610

4 years ago[FREELDR]
Thomas Faber [Sat, 28 Jan 2017 13:55:50 +0000 (13:55 +0000)]
[FREELDR]
- Add missing checks for allocation failure in DetectSerialPointerPeripheral and DetectPS2Mouse. Patch by Serge Gautherie.
CORE-12623

svn path=/trunk/; revision=73608

4 years ago[NTOS:MM]
Thomas Faber [Sat, 28 Jan 2017 13:08:19 +0000 (13:08 +0000)]
[NTOS:MM]
- Support MmSpecialPoolTag == '*' to mean all tags. By Serge Gautherie.
CORE-12711 #resolve

svn path=/trunk/; revision=73607

4 years ago[FREELDR]
Hermès Bélusca-Maïto [Fri, 27 Jan 2017 14:43:41 +0000 (14:43 +0000)]
[FREELDR]
- Use 'DiskReadBufferSize' instead of hardcoded values in hwdisk.c
- Transform reactos_arc_disk_info into a ARC_DISK_SIGNATURE_EX structure, so that its conversion into a ARC list in winldr.c becomes a bit simpler.
- In winldr.c:
  * In case we fail to either open the SYSTEM hive or scan it, bail out with an error message, instead of trying to continue loading ROS.
  * Fix an old comment related to ACPI;
- In memory.c/h: Do some cleanup (in particular, just use the MachXXX macros instead of also defining functions with the same names as the macros, and which just redirect into the virtual table).

svn path=/trunk/; revision=73606

4 years ago[HIDPARSE][HIDPARSER][LIBUSB][USBHUB] Merge USB stack improvements by Vardan Mikayely...
Amine Khaldi [Fri, 27 Jan 2017 11:09:36 +0000 (11:09 +0000)]
[HIDPARSE][HIDPARSER][LIBUSB][USBHUB] Merge USB stack improvements by Vardan Mikayelyan in GSoC.

svn path=/trunk/; revision=73605

4 years ago[STORAHCI] Merge Storport Miniport driver by Aman Priyadarshi in GSoC.
Amine Khaldi [Fri, 27 Jan 2017 10:11:30 +0000 (10:11 +0000)]
[STORAHCI] Merge Storport Miniport driver by Aman Priyadarshi in GSoC.

svn path=/trunk/; revision=73604

4 years ago[SHELL32]: Replace some animations with RLE-8 compressed ones; courtesy Jared Smudde...
Hermès Bélusca-Maïto [Fri, 27 Jan 2017 01:07:47 +0000 (01:07 +0000)]
[SHELL32]: Replace some animations with RLE-8 compressed ones; courtesy Jared Smudde. Thanks!
CORE-11643

svn path=/trunk/; revision=73601

4 years ago[SDK] -rosctrls.h: Add GetItemPosition and SetItemPosition methods in CListView.
Giannis Adamopoulos [Thu, 26 Jan 2017 17:03:35 +0000 (17:03 +0000)]
[SDK] -rosctrls.h: Add GetItemPosition and SetItemPosition methods in CListView.

svn path=/trunk/; revision=73600

4 years ago[SHELL32] -CDefView: Implement moving icons around. Note that the positions are never...
Giannis Adamopoulos [Thu, 26 Jan 2017 16:48:52 +0000 (16:48 +0000)]
[SHELL32] -CDefView: Implement moving icons around. Note that the positions are never stored so a refresh returns them to their initial position.

svn path=/trunk/; revision=73599

4 years ago[FREELDR]: Fix GCCLin compilation (#if'd 0 an unused static function; I keep it there...
Hermès Bélusca-Maïto [Wed, 25 Jan 2017 22:50:46 +0000 (22:50 +0000)]
[FREELDR]: Fix GCCLin compilation (#if'd 0 an unused static function; I keep it there still in case it can become useful later).

svn path=/trunk/; revision=73597

4 years ago[XDK]: Do not always redefine the ASSERT(MSG) macros with the NT_xxx ones, especially...
Hermès Bélusca-Maïto [Wed, 25 Jan 2017 22:43:04 +0000 (22:43 +0000)]
[XDK]: Do not always redefine the ASSERT(MSG) macros with the NT_xxx ones, especially for the FreeLdr/... bootloader (where we don't use WinDbg for debugging, yet), because in this case the int 0x2c is hardly informative. We fall back to the good old RtlAssert which displays an assertion failure string in the default debug output port (e.g. serial), and then does an int 0x03.

[FREELDR]
- "static"-ify some printing helper functions;
- hide the textmode cursor before blue-screening;
- disable interrupts before hanging forever.

svn path=/trunk/; revision=73596

4 years ago[ISOHYBRID]
Colin Finck [Tue, 24 Jan 2017 22:53:20 +0000 (22:53 +0000)]
[ISOHYBRID]
Import the isohybrid tool from http://repo.or.cz/syslinux.git/tree/138e850fab106b5235178848b3e0d33e25f4d3a2:/utils

I had to add a lot of glue code (getopt, err/errx/warn/warnx) to get it to compile under all our build platforms Windows, Linux and macOS.
GPT/Mac partition support is disabled at the moment (look for REACTOS_ISOHYBRID_EFI_MAC_SUPPORT), that would need a portable libuuid.
A fix for correctly opening ISOs as binary and not text-mode has been implemented and already sent upstream.

ISOs are not being patched automatically yet due to CORE-12692

CORE-12648

svn path=/trunk/; revision=73595

4 years ago[BOOTSECT]
Colin Finck [Tue, 24 Jan 2017 22:45:37 +0000 (22:45 +0000)]
[BOOTSECT]
Overhaul our ISO boot sector:
- Add another entry point for hybrid booting (called by isombr) and the hybrid signature needed for isohybrid.
- Import latest isolinux.asm "API" from http://repo.or.cz/syslinux.git/blob/8bbb10b70905339b7ca6b58d6833b6a95ab03dae:/core/isolinux.asm (latest version to date) and http://repo.or.cz/syslinux.git/blob/9141c603930ef23da1e08e487a0c26750fbb4fbe:/core/isolinux.asm (latest version that came with all functions in ASM).
  Among other things, this brings us getlinsec_ebios (for reading setupldr.sys in hybrid/MBR mode) and BrokenAwardHack (for working around broken Award BIOSes)
- Fix upstream getlinsec_ebios to load files >64K.
- Load the HDD boot sector directly to 0x7C00 instead of trackbuf. This way, we don't have to load it again when the user decides to boot from HDD.
- Check for the 0xAA55 signature to decide if the HDD contains a valid MBR. This was done differently and inconsistently for isoboot and isobtrt.
- Adapt the file and comment style to ReactOS guidelines. Add meaningful comments to our main code. Remove stuff that was just taken from isolinux.asm, but makes no sense for our version.
- Remove DEBUG_MESSAGES ifdef. There is no chance they can ever fit into the 2K sector with all the added features. Debugging can still happen using Bochs or adding specific messages.

Tested with Bochs, QEMU, VMware, VirtualBox and four real computers.
Many thanks to Hermès for all the helpful suggestions and additional investigations! :)

CORE-12648

svn path=/trunk/; revision=73594

4 years ago[SUBST] improve/fix German translation. Patch by "Joefish". CORE-12654 #resolve
Robert Naumann [Tue, 24 Jan 2017 22:22:58 +0000 (22:22 +0000)]
[SUBST] improve/fix German translation. Patch by "Joefish". CORE-12654 #resolve

svn path=/trunk/; revision=73593

4 years ago[HELP] Small grammar correction. Based on parch by Doug Lyons. CORE-12669 #resolve
Robert Naumann [Tue, 24 Jan 2017 22:18:24 +0000 (22:18 +0000)]
[HELP] Small grammar correction. Based on parch by Doug Lyons. CORE-12669 #resolve

svn path=/trunk/; revision=73592

4 years ago[SHELL32]
Giannis Adamopoulos [Tue, 24 Jan 2017 16:35:36 +0000 (16:35 +0000)]
[SHELL32]
- CDefaultContextMenu: Fix the implementation of the QueryContextMenu to respect how IContextMenu should function. Don't ignore idCmdFirst and idCmdLast parameters. Return a correct HRESULT. For now I'm not sure how 0 cmd ids should be handled and if the standard menu items should also be affected by these parameters.

svn path=/trunk/; revision=73591

4 years ago[WELCOME]
Hermès Bélusca-Maïto [Tue, 24 Jan 2017 14:42:07 +0000 (14:42 +0000)]
[WELCOME]
- Start implementing the possibility of customizing the Welcome.exe utility using configuration INI files (e.g. what we would do for FOSDEM, CLT, etc...)
- Resources cleanup.

svn path=/trunk/; revision=73590

4 years ago[i8042prt]: Yet another hack for Dell Latitude E4310 for touchpad.
Hermès Bélusca-Maïto [Tue, 24 Jan 2017 00:58:52 +0000 (00:58 +0000)]
[i8042prt]: Yet another hack for Dell Latitude E4310 for touchpad.
CORE-12434

svn path=/trunk/; revision=73589

4 years ago[FREELDR]
Eric Kohl [Sun, 22 Jan 2017 15:03:11 +0000 (15:03 +0000)]
[FREELDR]
Add VESA DDC detection and EDID read code. Work in progress.

svn path=/trunk/; revision=73587

4 years ago[CDFS]
Jérôme Gardou [Sun, 22 Jan 2017 11:55:29 +0000 (11:55 +0000)]
[CDFS]
 - Reduce stack usage by manipulating UNICODE_STRINGS we are given instead of copying it a gazillion times
 - Do not assume said strings are null-terminated

svn path=/trunk/; revision=73586

4 years ago[ADVAPI32]
Eric Kohl [Sat, 21 Jan 2017 11:57:43 +0000 (11:57 +0000)]
[ADVAPI32]
Add I_ScIsSecurityProcess() stub.

svn path=/trunk/; revision=73585

4 years ago[PSDK]: Add the declarations for IsNetDrive, DriveType and RealDriveType functions...
Hermès Bélusca-Maïto [Thu, 19 Jan 2017 19:39:53 +0000 (19:39 +0000)]
[PSDK]: Add the declarations for IsNetDrive, DriveType and RealDriveType functions (from shell32).

svn path=/trunk/; revision=73584

4 years ago[SHELL32]: Follow-ups to r73579 and r73580: use PathYetAnotherMakeUniqueName.
Hermès Bélusca-Maïto [Wed, 18 Jan 2017 23:47:38 +0000 (23:47 +0000)]
[SHELL32]: Follow-ups to r73579 and r73580: use PathYetAnotherMakeUniqueName.
CORE-12684

svn path=/trunk/; revision=73583

4 years ago[SHELL32]: Code formatting only.
Hermès Bélusca-Maïto [Wed, 18 Jan 2017 23:44:46 +0000 (23:44 +0000)]
[SHELL32]: Code formatting only.

svn path=/trunk/; revision=73582

4 years ago[SHELL32]: Remove trailing whitespace.
Hermès Bélusca-Maïto [Wed, 18 Jan 2017 21:03:46 +0000 (21:03 +0000)]
[SHELL32]: Remove trailing whitespace.

svn path=/trunk/; revision=73581

4 years agoFix a bug introduced in r73579.
Hermès Bélusca-Maïto [Wed, 18 Jan 2017 12:59:35 +0000 (12:59 +0000)]
Fix a bug introduced in r73579.
CORE-12684

svn path=/trunk/; revision=73580

4 years ago[SHELL32]: Fix the "CNewMenu.cpp:432: Unexpected failure 80070002." debug line that...
Hermès Bélusca-Maïto [Wed, 18 Jan 2017 12:48:50 +0000 (12:48 +0000)]
[SHELL32]: Fix the "CNewMenu.cpp:432: Unexpected failure 80070002." debug line that appears when one tries to create a new file using the explorer (note: did not happen for new directories).
CORE-12684 #resolve #comment Fixed in r73579.

svn path=/trunk/; revision=73579