Thomas Faber [Sun, 7 Aug 2016 14:24:45 +0000 (14:24 +0000)]
[FASTFAT]
- Update FCB hashes after changing the path name
CORE-11377
svn path=/trunk/; revision=72147
Dmitry Chapyshev [Sun, 7 Aug 2016 13:07:23 +0000 (13:07 +0000)]
[INPUT]
- Create an empty project for re-working keyboard layouts management
svn path=/trunk/; revision=72146
Pierre Schweitzer [Sun, 7 Aug 2016 12:29:48 +0000 (12:29 +0000)]
[FASTFAT]
After renaming a directory, rename any children FCB that would still exist in the FSD. This will allow next directory opening to properly work and open correct data.
This defeats corruption on directory renaming.
Unfortunately, this solution is not ideal and our driver should be reworked so that it quits using a hash table and it quits storing the whole path in the FCBs.
Deep thanks to Wim Hueskes and Thomas Faber for their help debugging the issue!
CORE-11377
svn path=/trunk/; revision=72145
Thomas Faber [Sun, 7 Aug 2016 07:00:56 +0000 (07:00 +0000)]
[NTOS:CC]
- Define CcPfEnablePrefetcher
CORE-11799
svn path=/trunk/; revision=72144
Dmitry Chapyshev [Sat, 6 Aug 2016 20:48:33 +0000 (20:48 +0000)]
[KBSWITCH]
- Use strsafe functions
- Use Shell Hooks in dll for detecting keyboard layout switching
- Fix bug in loading kbsdll
* Detection switch keyboard layout is now working in Windovs, but does not work in ReactOS (WH_SHELL not work in win32k)
svn path=/trunk/; revision=72143
Dmitry Chapyshev [Sat, 6 Aug 2016 17:43:57 +0000 (17:43 +0000)]
[WIN32K]
- Detect Alt+Shift hotkeys and send input language change request message to window
* Switching the keyboard layout works now. The code needs to be improved
svn path=/trunk/; revision=72142
Eric Kohl [Sat, 6 Aug 2016 17:07:59 +0000 (17:07 +0000)]
[LSASRV]
Move ServiceInit() into a separate file.
svn path=/trunk/; revision=72141
Hermès Bélusca-Maïto [Sat, 6 Aug 2016 16:21:02 +0000 (16:21 +0000)]
[EVENTVWR]
Don't hardcode a fixed size for the memory buffer holding the event details data to be copied into the clipboard, but instead compute it using the real lengths of the different strings. Use also StringCbPrintfW instead.
svn path=/trunk/; revision=72140
Eric Kohl [Sat, 6 Aug 2016 15:07:41 +0000 (15:07 +0000)]
[LSASRV]
Implement LsarAddAccountRigths and fix some bugs along the way:
- LsarGetSystemAccessAccount: Fix an uninitialized varable.
- LsarOpenAccount, LsarCreateAccount: Make these functions wrappers around the real implementation in LsarpCreateAccount and LsarpOpenAccount.
- LsarEnumerateAccountRights: Fix the use of the wrong array index.
- LsarAddAccountRights: Implement it.
- LsarpLookupPrivilegeValue: Return a pointer to an LUID instead of an NTSTATUS. It is much earier to use it this way.
- LsapLookupAccountRightValue: Implement it.
svn path=/trunk/; revision=72139
Thomas Faber [Sat, 6 Aug 2016 15:04:08 +0000 (15:04 +0000)]
[NTOS:MM][USER32]
- Correctly handle/avoid C99-style inline semantics
CORE-11794
svn path=/trunk/; revision=72138
Thomas Faber [Sat, 6 Aug 2016 12:58:32 +0000 (12:58 +0000)]
[WS2_32_NEW]
- Fix always true conditions in ComputeQuerySetSize
CORE-11799
svn path=/trunk/; revision=72137
Pierre Schweitzer [Sat, 6 Aug 2016 12:25:47 +0000 (12:25 +0000)]
[FASTFAT]
Properly check for opened handles in subdirectories when we're about to rename a directory.
This helps reducing corruption where some renaming operations were allowed whereas they shouldn't have been.
CORE-11377
CORE-11426
svn path=/trunk/; revision=72136
Thomas Faber [Sat, 6 Aug 2016 12:15:16 +0000 (12:15 +0000)]
[SYSDM]
- Less ambiguously check the return value of DialogBoxParam
CORE-11794
svn path=/trunk/; revision=72135
Thomas Faber [Sat, 6 Aug 2016 12:07:54 +0000 (12:07 +0000)]
[WIN32K:NTUSER]
- Add some missing VOIDs
CORE-11799
svn path=/trunk/; revision=72134
Amine Khaldi [Sat, 6 Aug 2016 10:35:53 +0000 (10:35 +0000)]
[INCLUDE/CRT] Correct _wctime and _wctime_s when _USE_32BIT_TIME_T is defined. CORE-11799
svn path=/trunk/; revision=72133
Amine Khaldi [Sat, 6 Aug 2016 10:18:08 +0000 (10:18 +0000)]
[CRT] Correct some types. CORE-11799
svn path=/trunk/; revision=72132
Amine Khaldi [Sat, 6 Aug 2016 09:53:47 +0000 (09:53 +0000)]
[WIN32DLLS] We don't need mingwex for these modules anymore. CORE-11799
svn path=/trunk/; revision=72131
Amine Khaldi [Sat, 6 Aug 2016 09:34:39 +0000 (09:34 +0000)]
[NTOS:MM] Add some missing VOIDs. CORE-11799
svn path=/trunk/; revision=72130
Amine Khaldi [Sat, 6 Aug 2016 09:32:45 +0000 (09:32 +0000)]
[DIRECTX/WINE] We don't need mingwex for these anymore. CORE-11799
svn path=/trunk/; revision=72129
Amine Khaldi [Sat, 6 Aug 2016 09:11:08 +0000 (09:11 +0000)]
[NTOS:PNPMGR] Mark IopReportTargetDeviceChangeAsyncWorker as stdcall and remove the PWORKER_THREAD_ROUTINE cast. CORE-11799
svn path=/trunk/; revision=72128
Thomas Faber [Sat, 6 Aug 2016 09:07:03 +0000 (09:07 +0000)]
[NTOS:MM]
- Correctly check for overflow in PeFmtCreateSection
CORE-11794
svn path=/trunk/; revision=72127
Pierre Schweitzer [Sat, 6 Aug 2016 08:57:47 +0000 (08:57 +0000)]
[FASTFAT]
Don't mess with parentless FCB.
Dedicated to Thomas :-).
CORE-11377
CORE-11426
svn path=/trunk/; revision=72126
Pierre Schweitzer [Sat, 6 Aug 2016 08:32:17 +0000 (08:32 +0000)]
[FASTFAT]
Addendum to r72124
svn path=/trunk/; revision=72125
Pierre Schweitzer [Sat, 6 Aug 2016 08:30:30 +0000 (08:30 +0000)]
[FASTFAT]
Track child FCB in parent FCB to allow browsing them in case it's needed.
This allows fixing a FIXME and offering better performances when renaming a directory.
CORE-11377
CORE-11426
svn path=/trunk/; revision=72124
Amine Khaldi [Sat, 6 Aug 2016 08:26:54 +0000 (08:26 +0000)]
[CALC] We don't need mingwex anymore. CORE-11799
svn path=/trunk/; revision=72123
Amine Khaldi [Sat, 6 Aug 2016 08:18:11 +0000 (08:18 +0000)]
[NTDLL] Add missing VOID. CORE-11799
svn path=/trunk/; revision=72122
Thomas Faber [Sat, 6 Aug 2016 07:57:51 +0000 (07:57 +0000)]
[ARP]
- Do not return failure after successful operations
CORE-11794
svn path=/trunk/; revision=72121
Thomas Faber [Sat, 6 Aug 2016 07:08:52 +0000 (07:08 +0000)]
[CMD][UXTHEME]
- Clarify misleading indentation
CORE-11794
svn path=/trunk/; revision=72120
Thomas Faber [Sat, 6 Aug 2016 06:52:41 +0000 (06:52 +0000)]
[CRT]
- Apply Wine commit
b7f6362d (msvcrt: Use the correct object type for __non_rtti_object exceptions.) by Alexandre Julliard
CORE-11794
svn path=/trunk/; revision=72119
Thomas Faber [Fri, 5 Aug 2016 21:33:54 +0000 (21:33 +0000)]
[CRT]
- Remove pointless inline
CORE-11794
svn path=/trunk/; revision=72118
Hermès Bélusca-Maïto [Fri, 5 Aug 2016 17:45:34 +0000 (17:45 +0000)]
[COMCTL32]: Addendum to r72116: Add the __REACTOS__ ifdefs to ease wine syncing, and update the patch in accordance.
CORE-11532
svn path=/trunk/; revision=72117
Giannis Adamopoulos [Fri, 5 Aug 2016 17:16:22 +0000 (17:16 +0000)]
[COMCTL32]
- rebar: actually pass the hittest flag to the NM_NCHITTEST notification.
CORE-11532
svn path=/trunk/; revision=72116
Hermès Bélusca-Maïto [Fri, 5 Aug 2016 11:54:48 +0000 (11:54 +0000)]
[FASTFAT_NEW]: Fix add_pch command usage.
svn path=/trunk/; revision=72115
Pierre Schweitzer [Fri, 5 Aug 2016 10:58:09 +0000 (10:58 +0000)]
[NET/USE]
Always delete remembered connections on /delete
ROSAPPS-303
svn path=/trunk/; revision=72114
Pierre Schweitzer [Fri, 5 Aug 2016 10:48:01 +0000 (10:48 +0000)]
[FASTFAT]
Refactor vfatMakeFCBFromDirEntry() and vfatUpdateFCB() so that they share code. It will help avoiding wild FCB modifications on renaming.
CORE-11377
svn path=/trunk/; revision=72113
Giannis Adamopoulos [Fri, 5 Aug 2016 09:06:30 +0000 (09:06 +0000)]
[EXPLORER]
- Fix subclassing the tasks toolbar which was broken in r65274.
CORE-11532
svn path=/trunk/; revision=72111
Mark Jansen [Thu, 4 Aug 2016 19:15:21 +0000 (19:15 +0000)]
[ATL][ATL_APITEST] Add implementation + tests for most functions from CPoint, CSize, CRect. CORE-11747 #resolve
Not all functions are implemented, the ones that are not implemented are left in a comment in the header.
svn path=/trunk/; revision=72110
Mark Jansen [Thu, 4 Aug 2016 19:11:50 +0000 (19:11 +0000)]
[INCLUDE/WINE] Update test.h with debug functions for POINT and SIZE.
svn path=/trunk/; revision=72109
Pierre Schweitzer [Thu, 4 Aug 2016 12:27:59 +0000 (12:27 +0000)]
[MPR]
Check for the right capability.
Already sent upstream.
CORE-11757
svn path=/trunk/; revision=72108
Pierre Schweitzer [Thu, 4 Aug 2016 12:25:51 +0000 (12:25 +0000)]
[MPR]
Add a missing break
svn path=/trunk/; revision=72107
Hermès Bélusca-Maïto [Wed, 3 Aug 2016 20:02:28 +0000 (20:02 +0000)]
[SHELL32]: Fix copypasta bug.
svn path=/trunk/; revision=72105
Christoph von Wittich [Wed, 3 Aug 2016 17:59:53 +0000 (17:59 +0000)]
[BROWSEUI] set min width for addressband to 100. patch by Katayama Hirofumi MZ CORE-11766
svn path=/trunk/; revision=72103
James Tabor [Wed, 3 Aug 2016 17:41:22 +0000 (17:41 +0000)]
[NtUser]
- Fix regression from r66350. See CORE-11324 for more details.
svn path=/trunk/; revision=72102
Thomas Faber [Wed, 3 Aug 2016 17:10:59 +0000 (17:10 +0000)]
[NTOS:SE]
- Remove unnecessary null checks & fix up cleanup in SepCreateToken and SepDuplicateToken. Based on a patch by Víctor Martínez Calvo
CORE-11768 #resolve
svn path=/trunk/; revision=72101
Giannis Adamopoulos [Wed, 3 Aug 2016 15:55:58 +0000 (15:55 +0000)]
Fix gcc build
svn path=/trunk/; revision=72100
Giannis Adamopoulos [Wed, 3 Aug 2016 15:52:27 +0000 (15:52 +0000)]
[SHELL32]
- CDesktopBrowser: Convert to an ATL CWindow class, remove unused fields and cleanup.
svn path=/trunk/; revision=72099
Pierre Schweitzer [Wed, 3 Aug 2016 14:42:49 +0000 (14:42 +0000)]
[NET/USE]
In case an automatic drive letter assignment was asked (net use * REMOTE), print the mapping that was performed on success.
ROSAPPS-303
svn path=/trunk/; revision=72098
Pierre Schweitzer [Wed, 3 Aug 2016 14:41:23 +0000 (14:41 +0000)]
[MPR]
Return the correct local name in case of automatic redirection.
Alreaedy sent upstream.
CORE-11757
svn path=/trunk/; revision=72097
Pierre Schweitzer [Wed, 3 Aug 2016 12:54:46 +0000 (12:54 +0000)]
[FASTFAT]
Fixes suggested by Thomas:
- Don't dereference cached data after unpinning
- Pin big enough data to read direntries
CORE-11377
svn path=/trunk/; revision=72096
Hermès Bélusca-Maïto [Tue, 2 Aug 2016 16:02:54 +0000 (16:02 +0000)]
[WIN32K]
- Deduplicate NtUserScrollWindowEx / IntScrollWindowEx by making NtUserScrollWindowEx properly call IntScrollWindowEx instead.
- Fix potential memory leaks in failure paths in IntScrollWindowEx.
svn path=/trunk/; revision=72093
Christoph von Wittich [Tue, 2 Aug 2016 14:52:08 +0000 (14:52 +0000)]
[BROWSEUI] pass a full pidl to ILGetDisplayNameEx CORE-11458
svn path=/trunk/; revision=72092
Pierre Schweitzer [Tue, 2 Aug 2016 11:46:31 +0000 (11:46 +0000)]
[MPR]
Properly set local name in case of redirection for *A function calls.
Alreaedy sent upstream.
CORE-11757
svn path=/trunk/; revision=72091
Pierre Schweitzer [Tue, 2 Aug 2016 10:21:24 +0000 (10:21 +0000)]
[MPR]
Misc fixes.
Already sent upstream (d'oh!)
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72090
Pierre Schweitzer [Tue, 2 Aug 2016 10:12:37 +0000 (10:12 +0000)]
[HACKSSIGN]
Drop hackssign app. It's now obsolete.
You served us well :-).
ROSAPPS-303
svn path=/trunk/; revision=72089
Pierre Schweitzer [Tue, 2 Aug 2016 10:10:25 +0000 (10:10 +0000)]
[NET]
Implement the "net use" usage of the net command.
This allows connecting remote resources to local system with assigning them a local name, to enumerate such connected resources and to delete them.
This obsoletes the hackssign application.
The implementation is a bit... raw. It is mainly here to demonstrate what's doable in ReactOS now. And to help using features we were lacking up to now.
For instance, you can make use of 'net use * \\vmware-host\Shared Folders\{YOURSHARE}' to assign a local letter to your VMware shared folders.
ROSAPPS-303
svn path=/trunk/; revision=72088
Pierre Schweitzer [Tue, 2 Aug 2016 10:04:19 +0000 (10:04 +0000)]
[MPR]
Implement connected resources enumeration
To be sent upstream.
Patch 6/6
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72087
Pierre Schweitzer [Tue, 2 Aug 2016 09:57:24 +0000 (09:57 +0000)]
[MPR]
Set the CONNECT_LOCALDRIVE on successful local redirection
To be sent upstream.
Patch 5/6
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72086
Pierre Schweitzer [Tue, 2 Aug 2016 09:54:51 +0000 (09:54 +0000)]
[MPR]
Implement WNetCancelConnectionA(), WNetCancelConnectionW(), WNetCancelConnection2A()
Already sent upstream.
Patch 4/6
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72085
Pierre Schweitzer [Tue, 2 Aug 2016 09:53:54 +0000 (09:53 +0000)]
[MPR]
Implement WNetCancelConnection2W()
Already sent upstream.
Patch 3/6
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72084
Pierre Schweitzer [Tue, 2 Aug 2016 09:51:09 +0000 (09:51 +0000)]
[MPR]
Implement provider automatic selection for WNetUseConnection. That means you don't need anylonger to provider the network provider handling the remote name to establish a connection to the resource.
Already sent upstream.
Patch 2/6
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72083
Pierre Schweitzer [Tue, 2 Aug 2016 09:49:20 +0000 (09:49 +0000)]
[MPR]
Time to react (again!).
Implement automatic local name redirection for new connection. This implements the behavior of the CONNECT_REDIRECT flag of WNetUseConnection.
Already sent upstream.
Patch 1/6
CORE-11757
ROSAPPS-303
svn path=/trunk/; revision=72082
Amine Khaldi [Tue, 2 Aug 2016 09:16:16 +0000 (09:16 +0000)]
[TRANSLATIONS] Russian translation update by Sergey Stopkin and co, with some fixes by me. CORE-11752
svn path=/trunk/; revision=72081
James Tabor [Tue, 2 Aug 2016 04:05:16 +0000 (04:05 +0000)]
[NtUser]
- Fix crash while mouse cursor is moving over stress test window (RegEdit). This fixes VLC too. Tested SeaMonkey and it did not crash. See CORE-9169 and CORE-9836.
svn path=/trunk/; revision=72080
Hermès Bélusca-Maïto [Mon, 1 Aug 2016 23:29:55 +0000 (23:29 +0000)]
[EVENTVWR]
- Reorganize the header inclusions; add a PCH.
- Transform the event details dialog into a control that can be embedded:
* in a resizable dialog,
* or in a pane below the window listing the events.
CORE-11637
svn path=/trunk/; revision=72079
Hermès Bélusca-Maïto [Mon, 1 Aug 2016 23:01:58 +0000 (23:01 +0000)]
[NOTEPAD]: Fix danish menu shortcuts.
svn path=/trunk/; revision=72078
Jérôme Gardou [Mon, 1 Aug 2016 22:16:58 +0000 (22:16 +0000)]
[KDGDB]
- Turn this thing into something useful
- Pretend we are only one process to GDB (making it a kernel-only debugger...) until the GDB team sorts this out
- This is a kernel debugger stub you know. You didn't seriously pretend that recursive functions would be fine, did you ?
[NTOS:KD64]
- Fix build
Pix or it din't happen : https://jira.reactos.org/secure/attachment/36322/source_level_debugging_ros.png
svn path=/trunk/; revision=72077
James Tabor [Mon, 1 Aug 2016 19:13:48 +0000 (19:13 +0000)]
[NtUser]
- Fix a recursion issue while processing posted messages. Related to CORE-10471. Dedicated to Thomas Faber for Free before Use testing.
- Pass extra information along with posted messages.
- Trigger an event when cursor position has changed.
svn path=/trunk/; revision=72076
James Tabor [Mon, 1 Aug 2016 18:15:45 +0000 (18:15 +0000)]
- Remove trace.
svn path=/trunk/; revision=72075
James Tabor [Mon, 1 Aug 2016 18:15:00 +0000 (18:15 +0000)]
[User32]
- Use correct value for win:test_mdi. Use post instead of send, fix message sequence.
- Minor code changes.
svn path=/trunk/; revision=72074
Christoph von Wittich [Mon, 1 Aug 2016 14:37:27 +0000 (14:37 +0000)]
[SHELL32] remove obsolete FIXME. was fixed in r68015
svn path=/trunk/; revision=72073
Dmitry Chapyshev [Mon, 1 Aug 2016 14:26:12 +0000 (14:26 +0000)]
[USERENV]
- Create separate function for setup session manager variables
- Fixed a regression in msi package winetest after r72066
svn path=/trunk/; revision=72072
Pierre Schweitzer [Mon, 1 Aug 2016 12:05:13 +0000 (12:05 +0000)]
[VFATLIB]
Don't leak memory
svn path=/trunk/; revision=72071
Dmitry Chapyshev [Mon, 1 Aug 2016 11:29:01 +0000 (11:29 +0000)]
[SHELL32]
- Fixed memory leak
[DNSLIB]
- Fixed uninitialized variable
[USERENV]
- Fixed typo
svn path=/trunk/; revision=72070
Pierre Schweitzer [Mon, 1 Aug 2016 06:14:45 +0000 (06:14 +0000)]
[NTFS]
Don't attempt to read beyond stream size.
Patch by Trevor Thompson.
CORE-11707
svn path=/trunk/; revision=72067
Dmitry Chapyshev [Sun, 31 Jul 2016 13:46:23 +0000 (13:46 +0000)]
[USERENV]
- Implement GetUserSid() (based on GetUserSidFromToken())
- Remove GetUserSidFromToken() and use new exported function
- Move SID functions to sid.c
- SetUserEnvironmentVariable should not fail, if can't get the short path. Instead, a long path
- Setup environment variables from Session Manager
* This fixes all winetests for userenv.dll (+20 passed tests)
svn path=/trunk/; revision=72066
James Tabor [Sun, 31 Jul 2016 13:00:27 +0000 (13:00 +0000)]
[NtUser]
- Remove unused data.
svn path=/trunk/; revision=72065
Mark Jansen [Sun, 31 Jul 2016 11:59:15 +0000 (11:59 +0000)]
[BROWSEUI] Correct the 'Is this legal' url as suggested by Ken Rochard. Also rewrite the function to remove todo's, and make it localizable. CORE-11721 #resolve #comment Thanks!
svn path=/trunk/; revision=72063
Pierre Schweitzer [Sun, 31 Jul 2016 10:13:39 +0000 (10:13 +0000)]
[REISERFS]
Reduce verbosity
svn path=/trunk/; revision=72062
Mark Jansen [Sat, 30 Jul 2016 19:07:43 +0000 (19:07 +0000)]
[ATL][ATL_APITEST] Implement / Improve CString, based upon the code that was already there. CORE-11579 #resolve
Add code + tests for:
Conversion of A->W and W->A, equality operators, MakeLower, MakeUpper, Find, FindOneOf, ReverseFind, Compare, Mid, Left, Right, Format, Replace, Trim, TrimLeft, TrimRight.
svn path=/trunk/; revision=72061
Hermès Bélusca-Maïto [Sat, 30 Jul 2016 16:20:41 +0000 (16:20 +0000)]
[SCSIPORT]: Port Dmitry's fix from r72059 to our scsiport driver too. I'm wondering how "difficult" it would be to have some kind of scsiport library to be shared between the driver and freeldr's.
svn path=/trunk/; revision=72060
Dmitry Chapyshev [Sat, 30 Jul 2016 16:00:10 +0000 (16:00 +0000)]
[WHOAMI]
[ARP]
[TRACERT]
- Incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true".
[FREELDR]
- Variable is assigned values twice
- The 'strlen' function was called multiple times inside the body of a loop
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0
[NTOBJSHEX]
[SLAYER]
[CMICONTROL]
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0
[SHELL32]
- There is no sense in testing the pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error
- Verifying that a pointer value is not NULL is not required. The 'if (ptr != NULL)' check can be removed
- Fix copy-paste error in CMenuFocusManager::PlaceHooks()
[SRCLIENT]
- Remove unneeded check. A part of conditional expression is always false.
[DISK]
[ATAPI]
- Variable is assigned values twice
* All bugs found by PVS-Studio
svn path=/trunk/; revision=72059
Eric Kohl [Sat, 30 Jul 2016 14:09:58 +0000 (14:09 +0000)]
[SOLITAIRE]
Add Portuguese/Brazillian translation.
Patch by Lucas Raziel.
CORE-11665 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=72058
Eric Kohl [Sat, 30 Jul 2016 13:39:56 +0000 (13:39 +0000)]
[INF]
Update russian translation of inf strings.
Patch by amber.
CORE-11604 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=72057
Pierre Schweitzer [Sat, 30 Jul 2016 12:53:09 +0000 (12:53 +0000)]
[FASTFAT]
Fix a FIXME
svn path=/trunk/; revision=72056
Giannis Adamopoulos [Sat, 30 Jul 2016 12:47:39 +0000 (12:47 +0000)]
[BROWSEUI]
- Move handling of DISPID_NAVIGATECOMPLETE2 event from CAddressBand to CAddressEditBox as the todo comments say it should be.
- Remove the todo entries that are complete.
- Remove IDispatch from CAddressBand as it is not really needed. Now CAddressBand takes care only of positioning and handling the button while CAddressEditBox does all the parsing and interaction with the browser.
svn path=/trunk/; revision=72055
James Tabor [Sat, 30 Jul 2016 12:32:28 +0000 (12:32 +0000)]
[NtUser]
- Fix hang while inputting mouse message. Fix CORE-9998.
svn path=/trunk/; revision=72054
Giannis Adamopoulos [Sat, 30 Jul 2016 11:53:16 +0000 (11:53 +0000)]
[BROWSEUI]
- Use the _CreateInstance postfix for all functions that instantiate a class.
- Move the the CreateInstance functions of the exported classes to browseui.h where we can select uniformly which built in classes we use.
svn path=/trunk/; revision=72053
Dmitry Chapyshev [Sat, 30 Jul 2016 11:31:33 +0000 (11:31 +0000)]
[USER32]
- Add missing NULL-pointer checkes in rect functions
- Small coding-style fixes
svn path=/trunk/; revision=72052
Hermès Bélusca-Maïto [Fri, 29 Jul 2016 13:44:37 +0000 (13:44 +0000)]
[PCIX]
Fix Device_SaveCurrentSettings: do not reference BarArray too soon if the index is out of bounds (in that case it means we are handling a ROM "BAR").
CID 716153, reported by Victor Martinez Calvo.
CORE-11215 #resolve
svn path=/trunk/; revision=72050
Hermès Bélusca-Maïto [Fri, 29 Jul 2016 13:17:58 +0000 (13:17 +0000)]
[XDK]
- Move the PCI_COMMON_HEADER_LAYOUT next to the structures that use it.
- Add IRP flags description comments.
svn path=/trunk/; revision=72049
Giannis Adamopoulos [Fri, 29 Jul 2016 12:59:16 +0000 (12:59 +0000)]
Fix build.
svn path=/trunk/; revision=72048
Giannis Adamopoulos [Fri, 29 Jul 2016 12:56:06 +0000 (12:56 +0000)]
[SHELL32]
- Factor CFSDropTarget out of CFSFolder.
- For now their code is mixed (no code was moved), until we decide where exactly is should be kept.
svn path=/trunk/; revision=72047
Robert Naumann [Fri, 29 Jul 2016 12:05:06 +0000 (12:05 +0000)]
[BROWSEUI] - explorerband: get the caption string from resource file instead of hardcoding it
svn path=/trunk/; revision=72046
Giannis Adamopoulos [Fri, 29 Jul 2016 12:03:20 +0000 (12:03 +0000)]
[SHELL32]
- CDefView: Add a missing error check.
CORE-11594
svn path=/trunk/; revision=72045
Pierre Schweitzer [Fri, 29 Jul 2016 11:54:08 +0000 (11:54 +0000)]
[EXT2]
Reduce driver verbosity
svn path=/trunk/; revision=72044
Giannis Adamopoulos [Fri, 29 Jul 2016 10:38:22 +0000 (10:38 +0000)]
[BROWSEUI]
- CExplorerBand: TranslateAcceleratorIO should return S_FALSE when it doesn't process the message in order to let other components process it.
CORE-11709
svn path=/trunk/; revision=72043
Pierre Schweitzer [Fri, 29 Jul 2016 10:29:16 +0000 (10:29 +0000)]
[EXT2]
Upgrade the driver to release 0.68.
CORE-11714
svn path=/trunk/; revision=72042
Giannis Adamopoulos [Fri, 29 Jul 2016 06:21:11 +0000 (06:21 +0000)]
[SHELLL32]
- Split GenericExtractIcon_CreateInstance into CGuidItemExtractIcon_CreateInstance, CFSExtractIcon_CreateInstance and CDrivesExtractIcon_CreateInstance.
svn path=/trunk/; revision=72041
Sylvain Petreolle [Thu, 28 Jul 2016 17:12:31 +0000 (17:12 +0000)]
[INF]
Add data for generic container devices.
svn path=/trunk/; revision=72036
Thomas Faber [Thu, 28 Jul 2016 15:25:35 +0000 (15:25 +0000)]
[SHELL32_APITEST]
- Add a test for CShellLink::GetDescription/SetDescription
CORE-5272
svn path=/trunk/; revision=72035