Stanislav Motylkov [Tue, 30 Jul 2019 21:01:23 +0000 (00:01 +0300)]
[CONFIGURE] Add MSVC compiler 19.22.27905 (VS Community 2019) (#1774)
Katayama Hirofumi MZ [Tue, 30 Jul 2019 13:05:11 +0000 (22:05 +0900)]
[SETUP] Sort font substitutes (#1770)
Sort the font substitute setting lists in base/setup/lib/muifonts.h .
Katayama Hirofumi MZ [Tue, 30 Jul 2019 10:09:23 +0000 (19:09 +0900)]
[SETUP] Delete 'Comic Sans MS' font substitutes (#1769)
Enable real 'Comic Sans MS' font by deleting the 'Comic Sans MS' font substitutes. CORE-16251
Katayama Hirofumi MZ [Tue, 30 Jul 2019 09:15:56 +0000 (18:15 +0900)]
[WIN32SS][NTGDI] Fix and improve font dumping (#1768)
Fix and improve font dumping. CORE-16245
- FontGDI->FontObj is not a pointer.
- "%s" does null check, so we remove redundant null checks.
- Add FaceName and StyleName dumping.
Hermès Bélusca-Maïto [Mon, 29 Jul 2019 22:57:22 +0000 (00:57 +0200)]
[FREELDR] Improve some *GetFileInformation() traces.
Stanislav Motylkov [Mon, 29 Jul 2019 22:27:36 +0000 (01:27 +0300)]
[FREELDR] Fix remaining hwdisk and FATX bugs (#1766)
- DiskGetFileInformation() should return relative addresses -- relative to the beginning of the "device" (partition, or disk) in question.
- FatXSearchDirectoryBufferForFile() should assign file attributes.
- Minor code style improvements in FatOpenVolume().
CORE-16216 CORE-16248
Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
Tibor Lajos Füzi [Mon, 29 Jul 2019 19:55:24 +0000 (21:55 +0200)]
[KBDHU] Fix Hungarian keyboard layout. (#1765)
CORE-15567
jimtabor [Mon, 29 Jul 2019 18:02:07 +0000 (13:02 -0500)]
[NtGDI] Fix one size region test.
See CORE-16246, the clip region may be the same size but more complex
than the callers simple region.
Stanislav Motylkov [Mon, 29 Jul 2019 12:25:54 +0000 (15:25 +0300)]
[FREELDR] Implement proper partition type detection and handling (#1762)
- This allows to detect and dynamically handle different partitioning schemes.
- Implemented detection of MBR, GPT, Xbox-BRFR, and partitionless disks.
- Currently only MBR and Xbox-BRFR partitions are handled and tested.
CORE-9841 CORE-15768 CORE-16216 CORE-16248
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 23:38:10 +0000 (01:38 +0200)]
[USER32] Fix build after
51d031cc ; addendum to
f21871fb (r69249) and
cf98f01e (r72650). CORE-10194
Eric Kohl [Sun, 28 Jul 2019 22:10:26 +0000 (00:10 +0200)]
[MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:32:14 +0000 (00:32 +0200)]
[USER32] Use the correct __REACTOS__ define.
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:31:56 +0000 (00:31 +0200)]
[NDK] Use the correct __REACTOS__ define.
Jose Carlos Jesus [Sun, 28 Jul 2019 22:20:40 +0000 (23:20 +0100)]
[NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments (#1761)
Hermès Bélusca-Maïto [Sun, 28 Jul 2019 22:20:07 +0000 (00:20 +0200)]
[PSDK] ks.h : Fix some IOCTL values, caught by Ben Nottelling.
Eric Kohl [Sun, 28 Jul 2019 20:37:17 +0000 (22:37 +0200)]
[W32TIME] Use an event to stop the service
CORE-16180
Stanislav Motylkov [Sun, 28 Jul 2019 16:20:53 +0000 (19:20 +0300)]
[FREELDR] Trivial improvements (#1757)
* [FREELDR] Fix uninitialized string in DiskGetBootPath()
CORE-16216 CORE-16248
* [FREELDR] xboxdisk: Add comment and fix code style
Hermès Bélusca-Maïto [Sat, 1 Jun 2019 22:23:02 +0000 (00:23 +0200)]
[DLLs] Fix .spec files regarding OLE-specific exports.
- Do not use hardcoded ordinals, add missing '-private'.
Except for MSXML3, OLE32 and RSAENH, see commit
bff824b2 for more details.
- SHSVCS: The 6 first exports are nonamed with ordinals. Replace exported
commented stubs by actual exported stubs instead.
Co-Authored-By: Timo Kreuzer <timo.kreuzer@reactos.org>
Hermès Bélusca-Maïto [Sat, 1 Jun 2019 22:11:18 +0000 (00:11 +0200)]
[SPEC2DEF] Check whether OLE-specific exports do not have assigned ordinals, as they should be.
The check is done at the same time as when we check also that these
exports are marked PRIVATE or not.
This permits us to check for the same conditions as MS' LINK.EXE, but
here on GCC builds as well.
See the following pages for more details:
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4104
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4222
In this last page (LNK4222), the specified list of exports is incomplete.
Manual tests showed that the very same list as for LNK4104 is checked.
Eric Kohl [Sun, 28 Jul 2019 12:57:46 +0000 (14:57 +0200)]
[MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete.
jimtabor [Sat, 27 Jul 2019 19:15:42 +0000 (14:15 -0500)]
[GDI32] Allow functions to access printing support.
Reapplying lost committed code.
jimtabor [Sat, 27 Jul 2019 19:13:14 +0000 (14:13 -0500)]
[GDI32] Add more to Local DC structure.
Make the two structures identical. These are used for printing and
enhanced metafile support.
Eric Kohl [Sat, 27 Jul 2019 17:59:32 +0000 (19:59 +0200)]
[PSDK] Add missing UnregisterDeviceNotification() to winuser.h.
Eric Kohl [Sat, 27 Jul 2019 14:54:15 +0000 (16:54 +0200)]
[AUDIOSVC] Fix the coding style. No code changes!
Oleg Dubinskiy [Fri, 28 Jun 2019 13:45:32 +0000 (16:45 +0300)]
[USETUP] Use "L" key instead of "D" for deleting partitions at 1st setup stage
Timo Kreuzer [Sun, 26 May 2019 11:37:31 +0000 (13:37 +0200)]
[REACTOS] Fix warning C4146: unary minus operator applied to unsigned type, result still unsigned
Joachim Henze [Sat, 27 Jul 2019 08:00:42 +0000 (10:00 +0200)]
[WIN32SS] Addendum to font alignment CORE-16133
addendum to 0.4.13-dev-707-g
0e4db883e5727569b5c3a35da3a6f8c5e921bbf3
Jim Tabor intended to structurally use flTextAlign over
lTextAlign internally within IntExtTextOutW().
He initially committed these changes in 0.4.12-dev-805-g
3377fe184efa77e7c4971c2ac70ed33ab12f0724
But we unintentionally lost these changes via 0.4.13-dev-370-g
8f482af0a876d269cca64288f114eb1fe1180ef0
Many thanks to Doug Lyons who helped a lot with fixing CORE-16133.
Katayama Hirofumi MZ [Sat, 27 Jul 2019 05:53:06 +0000 (14:53 +0900)]
[MEDIA][FONTS] Add Comic Sans MS fonts (comic.ttf, comicbd.ttf) (#1754)
Add Comic Sans MS font files. CORE-16237
Add "Comic Relief" fonts by Jeff Davis under SIL Open Font License in the name of "Comic Sans MS". We cannot choose Comic Sans MS currently but it's font engine's bug.
Hermès Bélusca-Maïto [Fri, 26 Jul 2019 12:53:03 +0000 (14:53 +0200)]
[WINHLP32] All the lang resource files are in UTF-8.
Katayama Hirofumi MZ [Fri, 26 Jul 2019 12:45:11 +0000 (21:45 +0900)]
[USER32_APITEST] Add #include 'precomp.h' in MessageStateAnalyzer
Katayama Hirofumi MZ [Fri, 26 Jul 2019 12:30:36 +0000 (21:30 +0900)]
[USER32_APITEST] Move <strsafe.h> #inclusion
Katayama Hirofumi MZ [Fri, 26 Jul 2019 10:13:00 +0000 (19:13 +0900)]
[WIN32SS][NTGDI] text/font vertical alignment patch CORE-16133
Based on Doug Lyons' patch. It partially fix CORE-16246 and CORE-16133.
Selection area is not fixed yet.
Serge Gautherie [Wed, 24 Jul 2019 17:59:07 +0000 (19:59 +0200)]
[CODEOWNERS] Add UniATA (#1689)
Shy Zedaka [Wed, 24 Jul 2019 17:56:48 +0000 (20:56 +0300)]
[TRANSLATION] Hebrew Translations For Setup (#1750)
Oleg Dubinskiy [Wed, 24 Jul 2019 17:56:33 +0000 (20:56 +0300)]
[DSOUND_NEW] Remove unused dsound_convert.c file (#1748)
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:45:55 +0000 (01:45 +0900)]
[USER32_APITEST][INCLUDE] Add MessageStateAnalyzer testcase (#1732)
I want to visualize the message stream and verify the states of each message. ROSTESTS-328
- Add a testcase named MessageStateAnalyzer into user32_apitest.
- Also fix type casts in <windowsx.h>.
Katayama Hirofumi MZ [Wed, 24 Jul 2019 16:40:33 +0000 (01:40 +0900)]
[USER32][NTUSER] Fix menu arrow drawing (of DrawFrameControl) (#1752)
CORE-13211
user32!DrawFrameControl drawed invalid menu arrow when the width is shorter than the height.
- Use the squared rectangle.
- Draw it in the transparent background mode.
- Save the old background mode of HDC.
This PR will fix UltraISO's bug.
Katayama Hirofumi MZ [Wed, 24 Jul 2019 06:39:10 +0000 (15:39 +0900)]
[MEDIA][FONTS] RAPPS checkmark fix (#1751)
The checkmarks of RAPPS were strange. This PR will fix the checkmark ("b") of 12px bitmap glyph of Marlett.ttf font file. CORE-14872
Katayama Hirofumi MZ [Tue, 23 Jul 2019 12:55:38 +0000 (21:55 +0900)]
[MEDIA][FONTS] Add copyright notice of TransGaming Technologies
With some font error fixed. CORE-16226
Katayama Hirofumi MZ [Tue, 23 Jul 2019 07:03:30 +0000 (16:03 +0900)]
[MEDIA][FONTS] Renewal of Marlett.ttf (#1749)
Renewal of Marlett.ttf font file. CORE-16226, CORE-14872
- Based on Ged Murphy's Marlett.ttf (See https://github.com/reactos/reactos/blob/
527f2f90577662e8eba1b1b62f958c39b3cd4358/media/fonts/Marlett.ttf).
- Erase the centered triangles.
- Adjustment of glyphs.
- Clarify the copyright ownership.
- Tested with 3 test programs (RadioAndCheck, PixelPerfectGlyph and MarlettCompare).
Doug-Lyons [Sat, 22 Jun 2019 16:23:11 +0000 (11:23 -0500)]
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. (#1684)
CORE-16123
- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
their non-volatile counterparts.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Bișoc George [Wed, 19 Jun 2019 15:51:11 +0000 (17:51 +0200)]
[UMPNPMGR] Implement registry functions for SuppressUI and SuppressNewHWUI handling. (#1683)
CORE-15897
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Eric Kohl [Sun, 21 Jul 2019 16:56:02 +0000 (18:56 +0200)]
[SRVSVC][WKSSVC] Set the stop pending status before stopping the services and stop the RPC listener on shutdown as well.
Eric Kohl [Sun, 21 Jul 2019 16:51:33 +0000 (18:51 +0200)]
[WMISERV][WUAUSERV] Stop the service if the stop event creation fails.
Erdem Ersoy [Sun, 21 Jul 2019 15:49:12 +0000 (18:49 +0300)]
[TRANSLATIONS] Update Turkish translations (#1650)
Translations for Solitaire, Spider, WinMine, Notepad, Wordpad & Write, MSPaint, MPlay32, SndRec32, WinHlp32, SndVol32, TaskMgr and Calc.
Benjamin Aerni [Sat, 13 Jul 2019 06:42:10 +0000 (23:42 -0700)]
[W32TIME] Use a reasonable fallback of 9 hours. (#1724)
CORE-16181
This allows preventing spamming the time servers if the registry entry
becomes corrupted or missing. Also, disallow a setting of less than
2 minutes for the same reasons, and instead use the fallback of 9 hours.
Oleg Dubinskiy [Fri, 19 Jul 2019 13:32:07 +0000 (16:32 +0300)]
[DSOUND_NEW] Completely fix gcc compilation (addendum to
25e98eb). (#1740)
CORE-16128
Bișoc George [Sun, 21 Jul 2019 14:52:25 +0000 (16:52 +0200)]
[OSK] Use new coordinates on keyboard layout changing (#1745)
CORE-16214
Katayama Hirofumi MZ [Sun, 21 Jul 2019 12:39:05 +0000 (21:39 +0900)]
[WIN32SS][GDI] Assume pso->sizlBitmap.cy positiveness (#1743)
We assume pso->sizlBitmap.cy is positive. CORE-15995
Because pso->sizlBitmap.cy is certificated as a positive value after initialization in SURFACE_AllocSurface, so we can safely omit abs and labs (absolute) function calls for it.
Michael Maltsev [Mon, 3 Jun 2019 09:35:58 +0000 (12:35 +0300)]
[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094
Katayama Hirofumi MZ [Sun, 21 Jul 2019 06:17:02 +0000 (15:17 +0900)]
[MEDIA][FONTS] Shrink Marlett.ttf file size
Katayama Hirofumi MZ [Sun, 21 Jul 2019 03:59:06 +0000 (12:59 +0900)]
[FONTS][NTGDI] Change Marlett.ttf charset and delete charset hacks
Hermès Bélusca-Maïto [Sat, 20 Jul 2019 23:06:54 +0000 (01:06 +0200)]
[MSCONFIG][ROSAPPS] Remove explicit MINGW_HAS_SECURE_API since it is already enabled globally. CORE-16224
Hermès Bélusca-Maïto [Sat, 20 Jul 2019 22:47:58 +0000 (00:47 +0200)]
[WIN32K:NTGDI] Improve allocated resources cleanup in failure paths of IntGdiLoadFontsFromMemory().
- Use an auxiliary list where we add the new enumerated faces, for easy
roll-back in case a failure happens during font loading. Only at the
very end when font loading has been successfully done, the auxiliary
list is appended to the corresponding global or per-proceess font list.
- Perform actual cleanup in case of failures.
- Introduce CleanupFontEntryEx() helper to simplify cleanup in
IntGdiLoadFontsFromMemory() in failure paths; implement
CleanupFontEntry() around it.
Additions:
- Perform string buffer NULL check in IntGdiAddFontResource().
- Reorder memory unmapping and section object dereferencing in
IntGdiAddFontResource().
- Move DuplicateUnicodeString() upwards.
- Mark explicitly the Marlett font handling hacks.
Eric Kohl [Sat, 20 Jul 2019 20:48:17 +0000 (22:48 +0200)]
[SRVSVC] Make the server service stoppable.
Eric Kohl [Sat, 20 Jul 2019 20:43:39 +0000 (22:43 +0200)]
[WKSSVC] Make the workstation service stoppable.
Eric Kohl [Sat, 20 Jul 2019 17:27:22 +0000 (19:27 +0200)]
[WUAUSERV] Make the wuauserv service startable and stoppable.
Katayama Hirofumi MZ [Sat, 20 Jul 2019 14:47:29 +0000 (23:47 +0900)]
[WIN32SS][NTGDI] Support raster fonts (*.fnt and *.fon) (#1739)
Add raster font (*.fnt and *.fon files) support. CORE-16165
- Add IntGetCharSet() function to get the charset by index and/or the number of charsets.
- Make IntGdiLoadFontsFromMemory() a non-recursive function.
- IntGetOutlineTextMetrics() accepts raster fonts.
- Improve CharMap handling (especially TT_PLATFORM_APPLE_UNICODE).
- Write the raster font file info to the registry.
- Don't request font size for raster fonts in IntRequestFontSize() function.
Eric Kohl [Sat, 20 Jul 2019 13:50:35 +0000 (15:50 +0200)]
[WMISVC] Accept stop and shutdown commands when the service is running.
Timo Kreuzer [Wed, 1 May 2019 07:44:33 +0000 (09:44 +0200)]
[GEN_BASEADDRESS] Add framebuf.dll and framebuf_new.dll to exclude ist in gen_baseaddress.py
Timo Kreuzer [Mon, 29 Apr 2019 15:00:18 +0000 (17:00 +0200)]
[TOOLS] Make gen_baseaddress.py python 3 compatible
Timo Kreuzer [Mon, 29 Apr 2019 14:07:06 +0000 (16:07 +0200)]
[CMAKE] Update base addresses
Timo Kreuzer [Sun, 28 Apr 2019 18:23:35 +0000 (20:23 +0200)]
[NTOSKRNL] Replace overlapping strcopy with memmove
Fixes 4 GCC 8 warnings of the kind:
ntoskrnl/kdbg/kdb_cli.c:3015:21: error: 'strcpy' accessing 1 byte at offsets 0 and [0,
2147483647] may overlap 1 byte at offset 0 [-Werror=restrict]
strcpy(p2, p2 + j);
^~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 16:27:22 +0000 (18:27 +0200)]
[CRT] Use sprintf_s instead of sprintf
Fixes GCC 8 warning:
sdk/lib/crt/misc/i10output.c:83:25: error: '%d' directive writing between 1 and 11 bytes into a region of size 6 [-Werror=format-overflow=]
sprintf(format, "%%.%dle", prec);
^~
sdk/lib/crt/misc/i10output.c:83:21: note: directive argument in the range [-
2147483648,
2147483646]
sprintf(format, "%%.%dle", prec);
^~~~~~~~~
sdk/lib/crt/misc/i10output.c:83:5: note: 'sprintf' output between 6 and 16 bytes into a destination of size 8
sprintf(format, "%%.%dle", prec);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 18:38:25 +0000 (20:38 +0200)]
[VFATLIB] Use RtlStringCbPrintfA instead of sprintf
Fixes GCC 8 warning:
sdk/lib/fslib/vfatlib/check/boot.c:173:27: error: '%02x' directive writing between 2 and 8 bytes into a region of size between 0 and 15 [-Werror=format-overflow=]
sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
^~~~
sdk/lib/fslib/vfatlib/check/boot.c:173:16: note: directive argument in the range [0,
2147483647]
sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
^~~~~~~~~~~~~~~~
sdk/lib/fslib/vfatlib/check/boot.c:173:3: note: 'sprintf' output between 8 and 31 bytes into a destination of size 20
sprintf(buf, "%s%u:%02x/%02x", first ? "" : ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(unsigned)(p - (uint8_t *) b), *p, *q);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 16:07:51 +0000 (18:07 +0200)]
[OLEAUT32] Use snprintf instead of sprintf
Fixes GCC 8 warning:
dll/win32/oleaut32/oleaut.c:876:39: error: '%s' directive writing up to 99 bytes into a region of size between 92 and 291 [-Werror=format-overflow=]
sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
^~ ~~~
dll/win32/oleaut32/oleaut.c:876:5: note: 'sprintf' output between 18 and 316 bytes into a destination of size 300
sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 15:48:58 +0000 (17:48 +0200)]
[FREELDR] Use RtlStringCbPrintfA instead of sprintf
Fixes GCC 8 warnings like:
boot/freeldr/freeldr/disk/scsiport.c:806:31: error: 'partition(0)' directive writing 12 bytes into a region of size between 1 and 64 [-Werror=format-overflow=]
sprintf(PartitionName, "%spartition(0)", ArcName);
^~~~~~~~~~~~
boot/freeldr/freeldr/disk/scsiport.c:806:5: note: 'sprintf' output between 13 and 76 bytes into a destination of size 64
sprintf(PartitionName, "%spartition(0)", ArcName);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 13:50:08 +0000 (15:50 +0200)]
[FASTFAT] Copy an entire field, instead of half-copying it with RtlCopyMemory
Fixes GCC 8 warning:
sdk/include/crt/mingw32/intrin_x86.h:76:12: error: 'memmove' offset [21, 40] from the object at 'DirContext' is out of the bounds of referenced subobject 'Attrib' with type 'unsigned char' at offset 19 [-Werror=array-bounds]
return memmove(dest, source, num);
^~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sun, 28 Apr 2019 12:49:31 +0000 (14:49 +0200)]
[FRAMEDYN] Fix broken asm (.code64 is for x64 only)
Timo Kreuzer [Sat, 27 Apr 2019 16:58:08 +0000 (18:58 +0200)]
[KERNEL32] Improve path name handling
Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
strncat(PathBuffer, "\\twain_32.dll", 13);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 16:53:59 +0000 (18:53 +0200)]
[MSPAINT] Don't use SIZEOF on a pointer
Fixes GCC 8 warning:
base/applications/mspaint/definitions.h:16:31: error: division 'sizeof (LPWSTR {aka wchar_t*}) / sizeof (WCHAR {aka wchar_t})' does not compute the number of array elements [-Werror=sizeof-pointer-div]
#define SIZEOF(a) (sizeof(a) / sizeof((a)[0]))
~~~~~~~~~~^~~~~~~~~~~~~~~~
base/applications/mspaint/main.cpp:134:55: note: in expansion of macro 'SIZEOF'
lstrcpyn(pon->lpOFN->lpstrFile, Path, SIZEOF(pon->lpOFN->lpstrFile));
^~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 16:42:21 +0000 (18:42 +0200)]
[MSGINA] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.
Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "User32 ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Sat, 27 Apr 2019 14:05:40 +0000 (16:05 +0200)]
[ADVAPI32] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.
Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "Advapi ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Timo Kreuzer [Mon, 3 Jun 2019 07:14:21 +0000 (09:14 +0200)]
[PSDK] Remove default value for BSTR parameter in msxml2.idl
Fixes GCC 8 warning:
In file included from base/applications/msconfig_new/xmldomparser.hpp:26,
from base/applications/msconfig_new/toolspage.cpp:11:
sdk/include/psdk/msxml2.h:12705:20: error: ISO C++ forbids converting a string constant to 'BSTR' {aka 'wchar_t*'} [-Werror=write-strings]
BSTR uri = L"x") = 0;
^~~~
Timo Kreuzer [Mon, 3 Jun 2019 07:07:36 +0000 (09:07 +0200)]
[PSDK][CRT] Add some casts to make GCC 8 happy
Timo Kreuzer [Sat, 27 Apr 2019 20:16:49 +0000 (22:16 +0200)]
[PSDK] Add DECLSPEC_SELECTANY to GUIDs to make GCC 8 happy
Timo Kreuzer [Mon, 29 Apr 2019 07:56:29 +0000 (09:56 +0200)]
[CMAKE] Globally enable secure CRT functions
"This is what Windows does" (tm)
Timo Kreuzer [Sun, 28 Apr 2019 20:05:32 +0000 (22:05 +0200)]
[CRT] Remove _wctime_s from time.h
Timo Kreuzer [Mon, 29 Apr 2019 08:02:13 +0000 (10:02 +0200)]
[CMAKE] Define _GLIBCXX_HAVE_BROKEN_VSWPRINTF to fix build with GLIBCXX and our c++ headers
Timo Kreuzer [Sun, 28 Apr 2019 20:17:19 +0000 (22:17 +0200)]
[CMAKE] Disable some overly sensitive warnings
-Wno-unused-const-variable
-Wno-unused-local-typedefs
-Wno-deprecated
Thomas Faber [Sun, 14 Jul 2019 09:01:36 +0000 (11:01 +0200)]
[ACPICA] Update to version
20190703. CORE-16202
Shy Zedaka [Fri, 19 Jul 2019 15:08:33 +0000 (18:08 +0300)]
[TRANSLATION] Hebrew Translation for Services (#1741)
Stanislav Motylkov [Thu, 18 Jul 2019 21:09:59 +0000 (00:09 +0300)]
[FREELDR] Abstract VGA BIOS specific code (#1736)
* [FREELDR] Abstract VGA BIOS specific code
WinLdrSetupSpecialDataPointers() uses INT 10h video interrupts, but they are not available on Xbox, so make them machine-specific.
CORE-16204 CORE-16210
* [FREELDR] Abstract getting extended BIOS data area
WinLdrSetupSpecialDataPointers() uses INT 15h AH=C1h to get extended BIOS data area, but it's not available on Xbox, so make it machine-specific.
CORE-16204 CORE-16210
Stanislav Motylkov [Thu, 18 Jul 2019 20:50:48 +0000 (23:50 +0300)]
[FREELDR] Abstract floppy drive detection code (#1735)
Make floppy detection code machine-specific, because Xbox CMOS cannot be used to detect floppies. Based on a patch by Matt Borgerson.
CORE-16204 CORE-16207
Co-authored-by: Matt Borgerson <contact@mborgerson.com>
Stanislav Motylkov [Mon, 15 Jul 2019 21:36:54 +0000 (00:36 +0300)]
[FREELDR] Fix memory initialization on Xbox
- Refactor and use PC memory map init functions
- This fixes filesystem detection and probably some other problems
Based on a patch by Matt Borgerson.
CORE-16204 CORE-16206
Co-authored-by: Matt Borgerson <contact@mborgerson.com>
Stanislav Motylkov [Mon, 15 Jul 2019 19:40:10 +0000 (22:40 +0300)]
[FREELDR] Whitespace improvements - no code changes
Stanislav Motylkov [Thu, 18 Jul 2019 20:49:11 +0000 (23:49 +0300)]
[FREELDR] hwdisk: Add sanity checks to avoid infinite loop (#1731)
CORE-16204 CORE-16205
Joachim Henze [Tue, 16 Jul 2019 20:51:42 +0000 (22:51 +0200)]
[BOOTDATA][SETUP] Fix regression CORE-16200 font rendering
By removing font substitution for 'Microsoft Sans Serif'.
Thanks to the patches author Katayama Hirofumi MZ.
This is a partial revert of the guilty rev
master guilty 0.4.13-dev-9-g
811faed421a798659af3cb3f09369af84fc4edf0
RC guilty 0.4.12-RC-13-g
8d3def0529e7e1bb9095713d46f5fbb64df0d299
VBox test result:
https://reactos.org/testman/compare.php?ids=68497,68499
The same fix has been applied before to 0.4.12-RC-44-g
ca0e00e8af009679351747150605857be580c538
Katayama Hirofumi MZ [Mon, 15 Jul 2019 14:03:06 +0000 (23:03 +0900)]
[SDK][INCLUDE] Add WM_WTSSESSION_CHANGE message (#1730)
- Add WM_WTSSESSION_CHANGE messages to <winuser.h>.
- Add WTS_* constant macros.
Bișoc George [Mon, 15 Jul 2019 13:59:06 +0000 (15:59 +0200)]
[OSK] Implement "Always on Top" feature (#1729)
Katayama Hirofumi MZ [Mon, 15 Jul 2019 11:32:53 +0000 (20:32 +0900)]
[SDK][INCLUDE] Add WM_INPUT_DEVICE_CHANGE and WM_INPUT (#1728)
- Add WM_INPUT_DEVICE_CHANGE and WM_INPUT messages.
- Add the relevant constant values.
Katayama Hirofumi MZ [Mon, 15 Jul 2019 10:59:38 +0000 (19:59 +0900)]
[SDK][INCLUDE] Add MENUGETOBJECTINFO structure (#1727)
- Add MENUGETOBJECTINFO structure to <winuser.h> header.
- Add MNGOF_TOPGAP and MNGOF_BOTTOMGAP constant macros.
Katayama Hirofumi MZ [Mon, 15 Jul 2019 10:58:34 +0000 (19:58 +0900)]
[SDK][INCLUDE] Add HANDLE_WM_* macros to <windowsx.h> (#1726)
- Add the following macros into <windowsx.h> header: HANDLE_WM_COPYDATA, HANDLE_WM_DEVICECHANGE, HANDLE_WM_DISPLAYCHANGE, HANDLE_WM_HOTKEY, and HANDLE_WM_MOUSEWHEEL.
- Fix HANDLE_WM_CONTEXTMENU macro.
Jose Carlos Jesus [Sun, 14 Jul 2019 22:07:50 +0000 (23:07 +0100)]
[TRANSLATION] Add Portuguese (neutral) translation. (#1702)
Add Portuguese (neutral) translation for intl.cpl, main.cpl, msgina.dll, msports.dll, welcome.exe and rundll32.exe, and fix the one in mshtml.dll .
Hermès Bélusca-Maïto [Sun, 14 Jul 2019 18:07:09 +0000 (20:07 +0200)]
[NTOS:INBV] Fix the bitmaps' palette and recompress them in RLE. (#1649)
They don't need to have a zeroed-out palette now that we can
automatically reset it from within the code.
Co-authored-by: Yaroslav Kibysh <yanet.prod@gmail.com>
Hermès Bélusca-Maïto [Sun, 7 Jul 2019 21:15:53 +0000 (23:15 +0200)]
[NTOS:INBV] Express some coordinates in terms of screen size. (#1649)
Yaroslav Kibysh [Tue, 11 Jun 2019 19:27:25 +0000 (22:27 +0300)]
[NTOS:INBV] Implement BitBltPalette() and BitBltAligned() and use them for aligning bitmaps. (#1649)
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Hermès Bélusca-Maïto [Sat, 13 Jul 2019 22:04:19 +0000 (00:04 +0200)]
[NTOS:MM] Add a MmChangeKernelResourceSectionProtection() helper. (#1649)
This allows setting the memory protection of the kernel's resource
section as will. MmMakeKernelResourceSectionWritable() is re-implemented
around this helper.
Hermès Bélusca-Maïto [Sat, 6 Jul 2019 22:33:06 +0000 (00:33 +0200)]
[NTOS:INBV] Classify the bitmap resources. (#1649)
See "How to change Windows XP boot logo" at
http://www.reversing.be/article.php?story=
20061209171938444
as well as the "Boot Editor for WinXP" program for more details.
Hermès Bélusca-Maïto [Sun, 14 Jul 2019 20:17:50 +0000 (22:17 +0200)]
[UMPNPMGR] Fix build.