Katayama Hirofumi MZ [Thu, 13 Feb 2020 17:03:35 +0000 (02:03 +0900)]
[NFSD][TELNETD][LIBTIRPC][MAN] Don't hardcode C:\ReactOS (#2334)
CORE-14747
Stanislav Motylkov [Thu, 13 Feb 2020 13:02:11 +0000 (16:02 +0300)]
[HALXBOX][BOOTDATA][INF] Give the Xbox HAL its own personality (#2338)
CORE-16216
Katayama Hirofumi MZ [Thu, 13 Feb 2020 02:26:40 +0000 (11:26 +0900)]
[SDK][INCLUDE] Improve <comctl32_undoc.h> more
Katayama Hirofumi MZ [Thu, 13 Feb 2020 01:06:44 +0000 (10:06 +0900)]
[SDK][INCLUDE] comctl32_undoc.h: Fix MRUBINARYCMDPROC
Katayama Hirofumi MZ [Thu, 13 Feb 2020 00:16:59 +0000 (09:16 +0900)]
[SDK][INCLUDE] Fix and improve comctl32_undoc.h
Colin Finck [Wed, 12 Feb 2020 18:59:23 +0000 (19:59 +0100)]
Fix build
Doug Lyons [Wed, 12 Feb 2020 18:52:34 +0000 (12:52 -0600)]
[WINSPOOL] Implement GetPrinterDriverA and a helper function UnicodeToAnsiInPlace (#2317)
Katayama Hirofumi MZ [Wed, 12 Feb 2020 10:29:56 +0000 (19:29 +0900)]
[SYSSETUP] Make Workstation default product option (#2332)
We set ReactOS Workstation as the default product option. That means we retargeted this project to Windows XP. Unattended Setup is supported.
CORE-13795
Katayama Hirofumi MZ [Wed, 12 Feb 2020 03:14:15 +0000 (12:14 +0900)]
[SHELL32] Use background context if no item selected on File menu
CORE-9467
Katayama Hirofumi MZ [Wed, 12 Feb 2020 02:06:54 +0000 (11:06 +0900)]
[ZIPFLDR] Show 'Click Next to extract' on initial status
Katayama Hirofumi MZ [Wed, 12 Feb 2020 00:18:24 +0000 (09:18 +0900)]
Shell Folders: Reject invalid characters (#2328)
Reject invalid input filename characters by using shell32!SHLimitInputEdit function and IItemNameLimits interface. Improve SHLimitInputEdit to sanitize paste.
CORE-11701
Katayama Hirofumi MZ [Wed, 12 Feb 2020 00:03:14 +0000 (09:03 +0900)]
[SYSSETUP] Plan A: Also write ReportAsWorkstation value (#2326)
Write the ReportAsWorkstation value of the registry key HKLM\SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version.
The reason is shown at CORE-6611.
CORE-13795
Serge Gautherie [Tue, 11 Feb 2020 16:36:12 +0000 (17:36 +0100)]
[SHELL32] DoGetProductType(): Check RegQueryValueExW() dwType (#2331)
Katayama Hirofumi MZ [Tue, 11 Feb 2020 11:59:14 +0000 (20:59 +0900)]
[WIN32SS][NTUSER] Fix ScrollWindowEx SW_SCROLLCHILDREN (#2327)
Based on the patch of I_Kill_Bugs of JIRA user. CORE-16687, CORE-12114
Katayama Hirofumi MZ [Tue, 11 Feb 2020 05:10:38 +0000 (14:10 +0900)]
[SHELL32] Fix and improve SHLimitInputEdit
Use CallWindowProcW to call the subclass window procedure.
Use Wide functions explicitly.
CORE-11701
Eric Kohl [Tue, 11 Feb 2020 04:40:59 +0000 (05:40 +0100)]
[MMSYS] Select a property page by command line, for expample 'control mmsys.cpl,,1'
Katayama Hirofumi MZ [Tue, 11 Feb 2020 04:11:58 +0000 (13:11 +0900)]
[SHELL32] DoGetProductType should check "LanmanNT" value.
CORE-13795
Katayama Hirofumi MZ [Tue, 11 Feb 2020 02:27:55 +0000 (11:27 +0900)]
[USER32_APITEST] Strengthen ScrollWindowEx for SW_SCROLLCHILDREN (#2324)
Improve ScrollWindowEx testcase for investigation of SW_SCROLLCHILDREN flag.
CORE-16687, CORE-12114
Stanislav Motylkov [Mon, 10 Feb 2020 22:20:12 +0000 (01:20 +0300)]
[CMAKE][BOOTDATA] Properly load Xbox video miniport driver in LiveCD (#2325)
Surprisingly this also happens to "fix" random "Invalid Opcode" exceptions in XQEMU.
(But I think it's more like a coincidence... --hbelusca)
CORE-16627 CORE-16216
Hervé Poussineau [Mon, 10 Feb 2020 20:31:28 +0000 (21:31 +0100)]
[ISAPNP] Implement IRP_MN_QUERY_CAPABILITIES + IRP_MN_QUERY_ID
Hervé Poussineau [Mon, 10 Feb 2020 20:30:07 +0000 (21:30 +0100)]
[ISAPNP] Also read serial numbers of devices
Hervé Poussineau [Mon, 10 Feb 2020 20:29:28 +0000 (21:29 +0100)]
[ISAPNP] Store VendorId/ProdId in the usual form
Hervé Poussineau [Sat, 8 Feb 2020 21:02:30 +0000 (22:02 +0100)]
[ISAPNP] When skipping a wrong tag in configuration, skip the length of this tag
Eric Kohl [Mon, 10 Feb 2020 08:47:59 +0000 (09:47 +0100)]
[ACCESS] Select a property page by command line, for example 'control access.cpl,,2'
Katayama Hirofumi MZ [Mon, 10 Feb 2020 06:57:30 +0000 (15:57 +0900)]
[SHELL32] Initial implement SHLimitInputEdit (#2323)
Popup balloon window is not implemented yet.
CORE-11701
Katayama Hirofumi MZ [Mon, 10 Feb 2020 02:10:42 +0000 (11:10 +0900)]
[SHELL32][SYSSETUP] Add Product Options page to ReactOS Setup (#2315)
- Add "Product Options" wizard page into ReactOS Setup.
- Implement CSIDL_Type_InMyDocuments CSIDL type.
- If the product type is workstation, then some special folders will be in My Documents.
CORE-13795
Thomas Faber [Sun, 9 Feb 2020 20:15:50 +0000 (21:15 +0100)]
[LIBJPEG] Update to version 9d. CORE-16686
Thomas Faber [Sun, 9 Feb 2020 19:56:36 +0000 (20:56 +0100)]
[MBEDTLS] Update to version 2.7.13. CORE-16686
jimtabor [Sun, 9 Feb 2020 17:28:19 +0000 (11:28 -0600)]
[NtGDI] Use Vis Region for New Clip Region
Interesting results while using VBOX-GA.
Rolling back to Vis, wine throwback. See CORE-16680.
Timo Kreuzer [Mon, 13 Jan 2020 12:41:24 +0000 (13:41 +0100)]
[CRT] Import wine exception handling code
The code is mostly unchanged. This includes the following changes:
* Move all wine code to crt/wine to keep it separated from our own code
* Add a minimal winternl.h
* Remove the asm macros from wine/config.h
* Include wine/asm.h where required
* Fix the names of the exported functions (GCC uses thiscall now and no wrappers are used anymore)
Timo Kreuzer [Mon, 13 Jan 2020 15:30:33 +0000 (16:30 +0100)]
[SDK] Improve x64 definition of DISPATCHER_CONTEXT
Katayama Hirofumi MZ [Sun, 9 Feb 2020 14:49:44 +0000 (23:49 +0900)]
[SHELL32_APITEST] SHLimitInputEdit: Fix C4509 warning (#2321)
CORE-11701
Eric Kohl [Sun, 9 Feb 2020 13:19:13 +0000 (14:19 +0100)]
[MSPORTS] Notify the installer of changes to the configuration of serial or parallel ports
Eric Kohl [Sun, 9 Feb 2020 12:10:00 +0000 (13:10 +0100)]
[CONTROL] Show the 'computer name' page of the system control panel by running 'control ports'.
Eric Kohl [Sun, 9 Feb 2020 12:07:13 +0000 (13:07 +0100)]
[SYSDM] Implement the selection of a property page by command line
Thomas Faber [Sun, 9 Feb 2020 09:20:48 +0000 (10:20 +0100)]
[CRT] Only write to the output buffer when necessary in _strlwr. CORE-16667
Like
e884290d292, this is also a hack and is missing locale awareness.
Oleg Dubinskiy [Fri, 31 Jan 2020 12:01:46 +0000 (14:01 +0200)]
[NDK][RTL] Implement RtlGetUnloadEventTrace. CORE-16671
Thomas Faber [Fri, 31 Jan 2020 22:03:57 +0000 (23:03 +0100)]
[HAL] Use a spin lock for the DMA adapter list. CORE-16611
This is necessary because HalPutDmaAdapter can be called at DISPATCH_LEVEL.
Katayama Hirofumi MZ [Sun, 9 Feb 2020 05:42:26 +0000 (14:42 +0900)]
[CPL][APPWIZ] Add InitCommonControls calls (#2316)
CORE-16669
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:28:20 +0000 (00:28 +0100)]
[CONSRV] Additions for the GUI frontend.
- Fix the text-copy code to handle fullwidth characters.
- Move the caret painting code to its own function.
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:32:53 +0000 (00:32 +0100)]
[CONSRV] Simplify parts of code in the line-input module.
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:30:50 +0000 (00:30 +0100)]
[CONSRV] Disable the old code for scrolling via keyboard shortcuts as it is buggy. To be fixed later...
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:27:01 +0000 (00:27 +0100)]
[CONSRV] Minor code cleanup.
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:24:21 +0000 (00:24 +0100)]
[CONSRV] Fix the definitions of the Console[Input|Output]UnicodeToAnsiChar() and Console[Input|Output]AnsiToUnicodeChar() macros.
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:18:40 +0000 (00:18 +0100)]
[CONSRV] Rephrase/complete some comments.
Hermès Bélusca-Maïto [Sat, 8 Feb 2020 23:13:30 +0000 (00:13 +0100)]
[SDK] wincon.h: Use explicit _WIN32_WINNT_* values. Add some missing flags.
Mark Jansen [Sat, 11 Jan 2020 23:13:24 +0000 (00:13 +0100)]
[SDK] Silence a GCC warning on RtlAssert
Mark Jansen [Wed, 8 Jan 2020 22:26:06 +0000 (23:26 +0100)]
[ATL][ATL_APITEST] Test + implement CHeapPtrList
Mark Jansen [Wed, 8 Jan 2020 22:20:41 +0000 (23:20 +0100)]
[ATL_APITEST] Add standalone CComHeapPtr project
Mark Jansen [Sat, 11 Jan 2020 13:38:08 +0000 (14:38 +0100)]
[ATL] Rename CHeapPtr data member, since it is public
Mark Jansen [Sun, 5 Jan 2020 01:23:04 +0000 (02:23 +0100)]
[ROSTESTS] Fix result being evaluated twice,
and in the process fix gcc signed/unsigned errors
Mark Jansen [Sat, 4 Jan 2020 23:51:13 +0000 (00:51 +0100)]
[ROSTESTS] Update test helpers to allow custom file/line info
Mark Jansen [Sat, 4 Jan 2020 20:23:53 +0000 (21:23 +0100)]
[PSDK] Add FileDescriptor.dwFlags constants
Mark Jansen [Thu, 21 Nov 2019 21:35:52 +0000 (22:35 +0100)]
[SDK] Move HIDA helper functions to shellutils.h
Thomas Faber [Sat, 1 Feb 2020 11:40:38 +0000 (12:40 +0100)]
[MMIXER] Fix overzealous asserts. CORE-16611
MAXPNAMELEN is the size of the array, so if wcslen returns MAXPNAMELEN-1,
the null terminator fits and everything is okay.
Thomas Faber [Sat, 1 Feb 2020 11:40:23 +0000 (12:40 +0100)]
[MMIXER] Safely handle MMixerGetDeviceNameWithComponentId failure in MMixerInitializeFilter. CORE-16611
Thomas Faber [Sat, 1 Feb 2020 11:35:41 +0000 (12:35 +0100)]
[MMIXER] Fix memory leak in MMixerGetDeviceNameWithComponentId. CORE-16611
Thomas Faber [Sat, 1 Feb 2020 12:09:11 +0000 (13:09 +0100)]
[PORTCLS] Handle failure return from QueryPowerChangeState. CORE-16611
Thomas Faber [Sat, 1 Feb 2020 12:06:15 +0000 (13:06 +0100)]
[PORTCLS] Return STATUS_PENDING after calling IoMarkIrpPending. CORE-16611
Thomas Faber [Sat, 1 Feb 2020 12:03:37 +0000 (13:03 +0100)]
[PORTCLS] Don't unnecessarily wait for lower drivers to complete power IRPs. CORE-16611
Also use PoCallDriver to forward power IRPs.
Thomas Faber [Sun, 8 Sep 2019 13:23:32 +0000 (15:23 +0200)]
[CRT] Only write to the output buffer when necessary in _strupr. CORE-16667
Fixes crash in msvcrt_winetest:string.
This is a hack and is supposed to be specific to the C locale.
Thomas Faber [Wed, 5 Feb 2020 09:23:22 +0000 (10:23 +0100)]
[NTOS:MM] Use POOL_BILLED_PROCESS_INVALID constant.
Aaron Dewes [Sat, 8 Feb 2020 11:55:53 +0000 (12:55 +0100)]
Update german translation (#2291)
* Update German translations
* Update translation again
* More translations
* Some fixes in the german translation
* Some more fixes
* Little translation tweak
* Updates to 2nd review
* Little update
* Add back keyboard accel for IDS_OPENFILELOCATION.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Hervé Poussineau [Fri, 7 Feb 2020 22:48:22 +0000 (23:48 +0100)]
[ISAPNP] Correctly calculate checksum
See appendix B.2 of "Plug and Play ISA Specification 1.0a"
Guntha [Fri, 7 Feb 2020 18:21:21 +0000 (19:21 +0100)]
[ZIPFLDR] Extraction is now in its own thread (#2261)
Extraction happens now in its own thread, allowing for cancelling in the middle of extraction or moving the window during the extraction.
File extraction was previously happening in the main thread, freezing the whole window until the end. Now when the user clicks "Next", a new thread is created and the extraction starts from there, allowing to move the window during the extraction, or to cancel the extraction in the middle. (Note: after clicking "Cancel", extraction continues until the current file is extracted).
CORE-14934
Hermès Bélusca-Maïto [Fri, 7 Feb 2020 18:07:22 +0000 (19:07 +0100)]
[USER32] Update the translations of IDS_ASK_TERMINATE.
Assis Duarte [Fri, 7 Feb 2020 17:59:32 +0000 (14:59 -0300)]
[USER32] Update Brazilian-Portuguese translation (#2283)
Tibor Lajos Füzi [Fri, 7 Feb 2020 17:12:20 +0000 (18:12 +0100)]
[TRANSLATION] Update Hungarian translation of userenv (#2293)
Masanori Ogino [Fri, 7 Feb 2020 17:09:38 +0000 (02:09 +0900)]
[OPENGL32][MESA] Describe the current status (#2309)
Since
5f2bebf7, the Mesa library in dll/opengl/ has been downgraded from 8.0.4 to 2.6,
while the related documents were not updated to reflect the change.
Masanori Ogino [Fri, 7 Feb 2020 17:07:56 +0000 (02:07 +0900)]
[GLU32] Sync with glu 9.0.1 (#2314)
Hermès Bélusca-Maïto [Fri, 7 Feb 2020 17:03:15 +0000 (18:03 +0100)]
[CPL][INPUT] Fix french typography error.
Katayama Hirofumi MZ [Fri, 7 Feb 2020 16:28:50 +0000 (01:28 +0900)]
[CPL][INPUT] Translate IDS_REBOOT_NOW into Japanese
Katayama Hirofumi MZ [Fri, 7 Feb 2020 16:27:14 +0000 (01:27 +0900)]
[CPL][INPUT] Translate IDS_REBOOT_NOW into French
CORE-16601
Katayama Hirofumi MZ [Fri, 7 Feb 2020 12:45:59 +0000 (21:45 +0900)]
[SETUPAPI] Add Japanese translation
Serge Gautherie [Thu, 6 Feb 2020 18:10:21 +0000 (19:10 +0100)]
[WINSPOOL] printers.c: Demote 3 ERR() to TRACE(), Fix 1 copypasta (#2311)
Doug Lyons [Thu, 6 Feb 2020 18:02:46 +0000 (12:02 -0600)]
[WINSPOOL] Implement GetPrinterA based on GetPrinterW (#2308)
Serge Gautherie [Wed, 5 Feb 2020 22:48:26 +0000 (23:48 +0100)]
[NTOS:MM] Stop using PD_COUNT, PDE_COUNT and PTE_COUNT (#2294)
Directly use PPE_PER_PAGE, PDE_PER_PAGE, PTE_PER_PAGE constants from hardware-specific MM headers instead
Bișoc George [Wed, 5 Feb 2020 18:54:33 +0000 (19:54 +0100)]
[TIMEDATE] Do not display a message box when NTP sync fails (#2305)
This PR merely checks if the string is empty and displaying (only) a debug information to the debugger, at disposal of displaying a message box. I might implement such dynamic resource string to the CPL later in a next PR.
CORE-16654
Jose Carlos Jesus [Fri, 31 Jan 2020 11:09:00 +0000 (11:09 +0000)]
[FORMATING] Fix indentation of startmnucust
On branch CodeFormat
Changes to be committed:
modified: base/shell/explorer/startmnucust.cpp
For a better visualization and understanding of the code
Bișoc George [Sat, 1 Feb 2020 21:47:32 +0000 (22:47 +0100)]
[SHELL32] Display the ReactOS version to the About dialog programmatically (#2276)
The current control parameters don't fit well with the version string since ReactOS migrated from SVN to Git. However, modifying the resource parameters doesn't fix the problem as well because the string itself is dynamic (as it can change in words specially the build architecture if the version build is AMD64 or x86 for example).
CORE-16571
Hermès Bélusca-Maïto [Sun, 22 Sep 2019 23:53:25 +0000 (01:53 +0200)]
[INCLUDE:HOST] Revert a bug that has been sneaked in by Arch Blackmann in
9e9ba41f (r36910) :P
The "TypeOffset" thing was just an informative comment to tell that the
data that follows after the IMAGE_BASE_RELOCATION header is an arbitrary
array of WORDs describing packed (Type + Offset)s.
Having the header structure containing that spurious "TypeOffset" was
breaking all the code that was basing on expected size of the
IMAGE_BASE_RELOCATION structure in order to apply relocations (typically
this would mean that the first 2 relocations described by it would not
be applied).
Hopefully this bug only hit the host-tools, and not the OS itself :)
Serge Gautherie [Sat, 1 Feb 2020 01:47:18 +0000 (02:47 +0100)]
[CODEOWNERS] Add 'Printing' entry
Thomas Faber [Thu, 30 Jan 2020 23:25:53 +0000 (00:25 +0100)]
[USBHUB] Only break into the debugger in the case that is actually unimplemented. CORE-16394
James Tabor [Fri, 31 Jan 2020 23:38:47 +0000 (17:38 -0600)]
[Printing] Part of GDI Support
Fix ups and added support to prevent GDI from crashing. These functions
will be required for GDI.
Part 1 of print support.
Colin Finck [Fri, 31 Jan 2020 17:47:53 +0000 (18:47 +0100)]
[FORMATTING] Fix indentation of winspool/printers.c
No code changes
Doug Lyons [Fri, 31 Jan 2020 17:42:55 +0000 (11:42 -0600)]
[WINSPOOL] Add Implementation of EnumPrintersA (#2273)
Katayama Hirofumi MZ [Thu, 30 Jan 2020 06:05:50 +0000 (15:05 +0900)]
[SHELLEXT][ZIPFLDR] Be case sensitive (#2292)
The filenames in a zip folder were all lowercase. Now the filenames are case sensitive.
Katayama Hirofumi MZ [Wed, 29 Jan 2020 23:32:21 +0000 (08:32 +0900)]
[SHELLEXT][ZIPFLDR] Use CStringA::FormatMessage (#2287)
Simplify our code.
Mark Jansen [Fri, 24 Jan 2020 19:43:06 +0000 (20:43 +0100)]
[SDK] Add some missing propsheet fields + validate struct sizes
Mark Jansen [Fri, 24 Jan 2020 19:09:07 +0000 (20:09 +0100)]
[CMLIB] Use UNIMPLEMENTED_ONCE in HvHiveWillShrink
Mark Jansen [Fri, 24 Jan 2020 19:08:20 +0000 (20:08 +0100)]
[WIN32SS] Demote a trace message
Mark Jansen [Fri, 24 Jan 2020 19:07:38 +0000 (20:07 +0100)]
[SYSSETUP] Zero out propsheet data fields
This prevents +propsheet logging accessing uninitialized data
Mark Jansen [Fri, 24 Jan 2020 19:07:24 +0000 (20:07 +0100)]
[NEWDEV] Zero out propsheet data fields
This prevents +propsheet logging accessing uninitialized data
Mark Jansen [Mon, 20 Jan 2020 20:43:19 +0000 (21:43 +0100)]
[FONTEXT] Add detail view columns to font folder
CORE-16476
Dmitry Borisov [Wed, 29 Jan 2020 15:49:31 +0000 (21:49 +0600)]
[FREELDR] Properly set keyboard flags in hardware detection (#2288)
See https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/ns-wdm-_cm_keyboard_device_data
Katayama Hirofumi MZ [Wed, 29 Jan 2020 13:29:11 +0000 (22:29 +0900)]
[SDK][ATL] Make ThrowMemoryException protected
Katayama Hirofumi MZ [Wed, 29 Jan 2020 13:16:58 +0000 (22:16 +0900)]
[SDK][ATL] Implement CStringT::FormatMessage (#2286)
CStringT::FormatMessage in ATL is a method to build a formatted string.
CORE-16666
Mark Jansen [Sun, 26 Jan 2020 22:40:04 +0000 (23:40 +0100)]
[BROWSEUI] Fix infinite recursion in autocomplete control
import wine commits 9c2217 and 644358, slightly tweaked to fit our code
Katayama Hirofumi MZ [Tue, 28 Jan 2020 17:29:16 +0000 (02:29 +0900)]
[CPL][APPWIZ] Consider PSN_SETACTIVE
- Correctly respond even if the user clicked "Back" button.
- Accept environment variables.
CORE-16534
Katayama Hirofumi MZ [Tue, 28 Jan 2020 14:31:09 +0000 (23:31 +0900)]
[CPL][APPWIZ] Use display name for shortcut label (#2284)
CORE-16534