Baruch Rutman [Thu, 13 Jun 2019 22:43:44 +0000 (01:43 +0300)]
[LPK] Fix for CORE-16115. (#1654)
Proposed changes:
- Use the total extent (width) and font metrics (height) as values
to put in the lpSize variable instead of calling ScriptString_pSize()
in the LpkGetTextExtentExPoint() function.
- Use GetTextExtentExPointWPri in more cases as another effort to get the data.
- Trailing whitespace fixes.
Baruch Rutman [Thu, 23 May 2019 19:59:30 +0000 (22:59 +0300)]
[LPK] Update Wine BiDi code. (#1651)
Imports the changes from
https://github.com/wine-mirror/wine/commit/
ef07087f47177e847c249d44f3f4918d1fd9a5ec
Joachim Henze [Fri, 14 Jun 2019 21:21:37 +0000 (23:21 +0200)]
[MSI] Fix regression CORE-14646
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.
The regression was introduced to ros by 0.4.8-dev-739-g
f8b992f2d31aaea06dd6a360ad19165d56c331dc
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445
Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.
I also committed the same fix to
0.4.12-RC-32-g152ee20.
Yaroslav Kibysh [Mon, 10 Jun 2019 08:36:59 +0000 (11:36 +0300)]
[MSTSC] Center window at start
Eric Kohl [Thu, 13 Jun 2019 12:16:25 +0000 (14:16 +0200)]
[NETCFGX] InstallNetDevice: Run the default device installer before making class-specific changes.
Eric Kohl [Thu, 13 Jun 2019 00:35:16 +0000 (02:35 +0200)]
[IPCONFIG] Indentation and coding style fixes. No code changes!
Giannis Adamopoulos [Mon, 31 Dec 2018 00:28:18 +0000 (02:28 +0200)]
[COMCTL32] imagelist: Make the exported functions use the internal IImageList2
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.
This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
Eric Kohl [Wed, 12 Jun 2019 16:04:50 +0000 (18:04 +0200)]
[IPCONFIG] Show the Description and Physical Address for disconnected network adapters.
Eric Kohl [Wed, 12 Jun 2019 15:48:35 +0000 (17:48 +0200)]
[IPCONFIG] Fix crash on 'ipconfig /all'
Ipconfig should not display invalid 'Lease Obtained' and 'Lease Expires' times because it did not yet receive any DHCP configuration.
Fixes CORE-11837
Eric Kohl [Wed, 12 Jun 2019 11:46:13 +0000 (13:46 +0200)]
[NTOSKRNL][USETUP][UMPNPMGR] Pass user response data to NtPlugPlayControl(PlugPlayControlUserResponse).
- Windows requires 16 bytes of response data.
- Add the PLUGPLAY_CONTROL_USER_RESPONSE_DATA type.
- Usetup and Umpnpmgr must fail if NtPlugPlayControl(PlugPlayControlUserResponse) does not return STATUS_SUCCESS.
Yaroslav Kibysh [Mon, 10 Jun 2019 07:36:24 +0000 (10:36 +0300)]
[SHORTCUTS] Update Ukrainian shortcuts. (#1639)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:34:38 +0000 (10:34 +0300)]
[ROSAPPS] Update Ukranian shortcuts. (#1638)
Hermès Bélusca-Maïto [Tue, 11 Jun 2019 20:36:10 +0000 (22:36 +0200)]
Fix build (forgot a comma ;)
Hermès Bélusca-Maïto [Tue, 11 Jun 2019 20:29:34 +0000 (22:29 +0200)]
[NTOS] IoSetHardErrorOrVerifyDevice(): Check whether the IRP is not associated with any thread.
Pierre Schweitzer [Tue, 11 Jun 2019 19:18:22 +0000 (21:18 +0200)]
[NTOSKRNL] Rework ObpDeleteSymbolicLinkName and ObpCreateSymbolicLinkName
So that they handle LUID mappings and process device maps.
Get rid of the ObpParseSymbolicLinkToIoDeviceObject helper and introduce a
new helper ObpProcessDosDeviceSymbolicLink that will do the same things
but also handle name creation/deletion as well as device map handling.
All this is based on previous code (hence the same comments :-)).
What's left to do now is to add support for device maps in ObpLookupObjectName
Eric Kohl [Tue, 11 Jun 2019 14:32:44 +0000 (16:32 +0200)]
[UMPNPMGR] PNP_SetHwProf is not implemented in Windows XP and returns CR_CALL_NOT_IMPLEMENTED.
Pierre Schweitzer [Tue, 11 Jun 2019 10:50:49 +0000 (12:50 +0200)]
[BTRFS] Fix MSVC build
CORE-16111
Pierre Schweitzer [Tue, 11 Jun 2019 10:43:43 +0000 (12:43 +0200)]
[BTRFS] Fix MSVC build
CORE-16111
Pierre Schweitzer [Tue, 11 Jun 2019 10:35:19 +0000 (12:35 +0200)]
[BTRFS] Upgrade to 1.3
CORE-16111
Eric Kohl [Tue, 11 Jun 2019 04:58:42 +0000 (06:58 +0200)]
[NETCFGX] Improvements to the TCP/IP settings dialog.
- Separate the gateway settings from the DHCP settings.
- Enable Edit and Delete buttons only if an item in a list box has been selected.
CORE-9908
Victor Perevertkin [Mon, 10 Jun 2019 23:50:43 +0000 (02:50 +0300)]
[USBSTOR] Properly handle IRP_MN_QUERY_DEVICE_RELATIONS(BusRelations) for FDO.
This fixes Driver Verifier warnings
Victor Perevertkin [Mon, 10 Jun 2019 22:42:28 +0000 (01:42 +0300)]
[USBSTOR] Register dumb IRP_MJ_SYSTEM_CONTROL handler.
This satisfies Driver Verifier
Victor Perevertkin [Mon, 10 Jun 2019 22:40:43 +0000 (01:40 +0300)]
[USBSTOR] Improve handling of IRP_MN_QUERY_DEVICE_TEXT for PDOs
CORE-15883
Victor Perevertkin [Mon, 10 Jun 2019 22:31:44 +0000 (01:31 +0300)]
[USBSTOR] Do not leak fields of DeviceExtensions upon device removal
Victor Perevertkin [Sat, 27 Apr 2019 21:44:55 +0000 (00:44 +0300)]
[DISK] Disable IsFloppyDevice check.
It wrongly marks USB flash drives as a floppy device
Victor Perevertkin [Sat, 27 Apr 2019 20:29:45 +0000 (23:29 +0300)]
[USBSTOR] Weaken the type checks of a device.
This adds usb-cdrom support to usbstor.sys
Victor Perevertkin [Sat, 13 Apr 2019 12:48:14 +0000 (15:48 +0300)]
[USBSTOR] Refactor device reset and pipe reset code.
Return correct status codes from completion routines.
Reject requests while the device is being reset
Victor Perevertkin [Wed, 10 Apr 2019 00:22:03 +0000 (03:22 +0300)]
[USBSTOR] Do not try to retry a failed request
for all cases except receiving a USBD_STATUS_STALL_PID status.
This decision should be made by higher-level driver (and classpnp drivers do it)
Victor Perevertkin [Mon, 1 Apr 2019 00:03:40 +0000 (03:03 +0300)]
[USBSTOR] Issue a SCSI Request Sense after receiving
a CSW with failed status. CORE-15884
Based on Vadim Galyant's patches to usbstor
Victor Perevertkin [Sun, 31 Mar 2019 23:33:35 +0000 (02:33 +0300)]
[USBSTOR] Keep CBW and CSW inside an IRP context.
Remove obsolete fields from the IRP context structure.
Victor Perevertkin [Sun, 31 Mar 2019 22:07:55 +0000 (01:07 +0300)]
[USBSTOR] Refactor request issue code.
Pipe handle selection now made more correctly.
Simplified an MDL allocation for a request.
Victor Perevertkin [Sun, 31 Mar 2019 20:03:33 +0000 (23:03 +0300)]
[USBSTOR] Better handle CBW/CSW transfer errors
and set SrbStatus correctly.
Victor Perevertkin [Sun, 31 Mar 2019 14:20:27 +0000 (17:20 +0300)]
[USBSTOR] Better validate SCSI IRPs.
Patch by Vadim Galyant
Victor Perevertkin [Sun, 31 Mar 2019 13:52:04 +0000 (16:52 +0300)]
[USBSTOR] Rework the routines for sending internal SCSI requests.
Now for each request SenseBuffer is correctly set
and 3 attempts are made to be sure the STALL state is cleared and
the error is in something else.
Remove the usage of UFI_INQUIRY_DATA structure in favor of "standard"
INQUIRYDATA structure from scsi.h
Based in Vadim Galyant's patches to usbstor
Victor Perevertkin [Wed, 27 Mar 2019 23:45:32 +0000 (02:45 +0300)]
[USBSTOR] Do not create a new Irp for USB requests - use the original one
from higher-level driver instead.
Refactored CSWCompletionRoutine for correct handling different CSW
statuses, more work to be done here.
Victor Perevertkin [Tue, 26 Mar 2019 11:26:06 +0000 (14:26 +0300)]
[USBSTOR] Do not attempt additional processing of SCSI requests.
Now the driver sends all requests transparently.
Inspired by Vadim Galyant's patches to usbstor
Victor Perevertkin [Sun, 24 Mar 2019 20:01:43 +0000 (23:01 +0300)]
[FORMATTING][USBSTOR] Remove Captain Obvious and line-wasting comments.
Now the driver conforms with our current Coding Style.
No functional changes
Pierre Schweitzer [Mon, 10 Jun 2019 19:16:41 +0000 (21:16 +0200)]
[NTOSKRNL] Fix ObpLUIDDeviceMapsEnabled initialization
Eric Kohl [Mon, 10 Jun 2019 18:27:45 +0000 (20:27 +0200)]
[NETCFGX] Do not update the TCP/IP properties when the cancels the advanced properties dialog.
CORE-9908
Pierre Schweitzer [Mon, 10 Jun 2019 17:01:04 +0000 (19:01 +0200)]
[NETPLWIZ] Add French translation
Eric Kohl [Mon, 10 Jun 2019 15:22:11 +0000 (17:22 +0200)]
[NETSHELL] Network connections can't be renamed
Enable the 'Rename' and 'Delete' menu items for Administrators.
CORE-15348
Yaroslav Kibysh [Mon, 10 Jun 2019 08:20:17 +0000 (11:20 +0300)]
[CONSOLE] Update Ukrainian translation. (#1643)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:52:23 +0000 (10:52 +0300)]
[MSGINA] Update Ukrainian translation. (#1642)
Hermès Bélusca-Maïto [Mon, 10 Jun 2019 14:57:59 +0000 (16:57 +0200)]
[CMD] Fix typo in Norwegian translation.
Yaroslav Kibysh [Mon, 10 Jun 2019 07:49:34 +0000 (10:49 +0300)]
[CMD] Update Ukrainian translation. (#1641)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:40:49 +0000 (10:40 +0300)]
[RAPPS] Update Ukrainian translation. (#1640)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:24:52 +0000 (10:24 +0300)]
[SHELL32] Update Ukrainian translation. (#1637)
Pierre Schweitzer [Mon, 10 Jun 2019 13:36:14 +0000 (15:36 +0200)]
[MSGINA] Update French translation
Joachim Henze [Mon, 10 Jun 2019 13:33:31 +0000 (15:33 +0200)]
[WIN32SS][NTUSER] Addendum to
0.4.12-dev-956-g0197c4f CORE-15893
Aims PixelPerfection for a regression that was introduced by
0.4.12-dev-954-g
1f619b27814f3bbf9673754a69bcae50c89fed19
and then improved already by
0.4.12-dev-956-g
0197c4f875d3332dbc4656a6360e3c7e9def2ed5
The tweaking got ack of Jim Tabor. Test results:
https://reactos.org/testman/compare.php?ids=68026,68029
Pierre Schweitzer [Mon, 10 Jun 2019 12:54:55 +0000 (14:54 +0200)]
[NTOSKRNL] Taggify some allocs
Pierre Schweitzer [Mon, 10 Jun 2019 12:49:50 +0000 (14:49 +0200)]
[NTOSKRNL] Implement SepCleanupLUIDDeviceMapDirectory
This will clean up all the links (drive letters) created
by an user on session deletion once LUID device maps are
in use
Pierre Schweitzer [Mon, 10 Jun 2019 10:30:49 +0000 (12:30 +0200)]
[NTOSKRNL] On session last reference removal, dereference LUID device map
Pierre Schweitzer [Mon, 3 Jun 2019 06:12:16 +0000 (08:12 +0200)]
[NTOSKRNL] Implement NtSetInformationProcess:ProcessDeviceMap
Eric Kohl [Sun, 9 Jun 2019 20:42:10 +0000 (22:42 +0200)]
[MSGINA] Add missing logon restriction messages.
Hermès Bélusca-Maïto [Sun, 9 Jun 2019 17:05:24 +0000 (19:05 +0200)]
[FASTFAT] Adjust the 'UnCleanCount', followng commit
9c3c0d12.
Hermès Bélusca-Maïto [Sun, 9 Jun 2019 15:56:06 +0000 (17:56 +0200)]
[FASTFAT] Minor cleanup of the main header file.
Serge Gautherie [Sun, 9 Jun 2019 13:57:45 +0000 (15:57 +0200)]
[SHELL32] SHCreateShellFolderView(): Fix parameter validation order. (#1632)
Fixes one modification from commit
ae2a85d0.
CORE-16098
Eric Kohl [Sun, 9 Jun 2019 13:25:13 +0000 (15:25 +0200)]
[NETAPI32] Ignore usriX_logon_hours and usriX_units_per_week if usriX_logon_hours is NULL.
Eric Kohl [Sun, 9 Jun 2019 12:50:07 +0000 (14:50 +0200)]
[NETAPI32] Do not try to set usriX_max_storage. Just ignore it.
Eric Kohl [Sat, 8 Jun 2019 18:41:53 +0000 (20:41 +0200)]
[NTOS:IO] Implement the PlugPlayControl.PlugPlayControlEnumerateDevice request
Drivers for Intel Pro/1000 NICs seem to install properly.
Serge Gautherie [Thu, 6 Jun 2019 22:14:40 +0000 (00:14 +0200)]
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. (#1622)
Addendum to
fdfef818. CORE-11711
Hermès Bélusca-Maïto [Sat, 8 Jun 2019 17:43:02 +0000 (19:43 +0200)]
[SHELL32] Fix some NULL-pointers validation.
- In the exported SHCreateDefaultContextMenu() and
IDataObject_Constructor() functions (called amongst others by
the exported CIDLData_CreateFromIDArray() function).
- In the exported SHCreateShellFolderView() function.
- In CDefView::GetItemObject(), where data was written to *ppvOut before
ppvOut was being checked for NULL.
Yaroslav Kibysh [Fri, 7 Jun 2019 12:06:52 +0000 (15:06 +0300)]
[BROWSEUI] Update Ukrainian translation. (#1626)
Yaroslav Kibysh [Fri, 7 Jun 2019 11:52:14 +0000 (14:52 +0300)]
[NEWDEV] Update Ukrainian translation. (#1625)
Yaroslav Kibysh [Fri, 7 Jun 2019 11:44:11 +0000 (14:44 +0300)]
[EXPLORER] Update Ukrainian translation. (#1624)
Yaroslav Kibysh [Fri, 7 Jun 2019 11:00:49 +0000 (14:00 +0300)]
[SHELL32] Update Ukrainian translation. (#1623)
Hermès Bélusca-Maïto [Sat, 8 Jun 2019 15:29:31 +0000 (17:29 +0200)]
[README] Fix the phrasing. Addendum to
8bfab2d4.
Eric Kohl [Thu, 6 Jun 2019 17:12:44 +0000 (19:12 +0200)]
[SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List.
Eric Kohl [Thu, 6 Jun 2019 17:08:43 +0000 (19:08 +0200)]
[SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr.
Eric Kohl [Thu, 6 Jun 2019 16:15:52 +0000 (18:15 +0200)]
[UMPNPMGR] Implement PNP_GetClassInstance().
Ender Ossel [Thu, 6 Jun 2019 16:01:48 +0000 (18:01 +0200)]
Add an Alpha note for new users in the README (#1270)
Serge Gautherie [Mon, 3 Jun 2019 23:14:31 +0000 (01:14 +0200)]
[ROSTESTS] Add missing '\n' to a few skip()
Hermès Bélusca-Maïto [Thu, 6 Jun 2019 14:33:44 +0000 (16:33 +0200)]
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559)
CORE-11711
Serge Gautherie [Thu, 9 May 2019 05:03:49 +0000 (07:03 +0200)]
[BROWSEUI_APITEST] Add a test for SHEnumClassesOfCategories. (#1559)
CORE-11711
Serge Gautherie [Thu, 9 May 2019 05:03:49 +0000 (07:03 +0200)]
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. (#1559)
Joachim Henze [Thu, 6 Jun 2019 00:24:20 +0000 (02:24 +0200)]
[WIN32SS][FREETYPE] Avoid performance regression CORE-16020
by reverting essential parts of "Font rotation at arbitrary angles"
which was once committed in several steps:
Initial commit (PR#1207)
0.4.12-dev-243-g
f757a135192c02a3c41d8da47eb9dba21d34ebd1
broke font rendering for GTK apps CORE-15623
Second commit (PR#1238)
0.4.12-dev-558-g
64987cf2731f9762d0316274bf7877a9bd3d88ba
restored font rendering in GTK apps but introduced slowdown CORE-16020
Katayama agreed to the temporal revert and will try to come up later
with a performance optimized version.
We revert in 0.4.12-RC and 0.4.13-dev.
The revert will cause failure-increases in gdi32:TextTransform
https://reactos.org/testman/compare.php?ids=67898,67901
Serge Gautherie [Wed, 5 Jun 2019 23:53:53 +0000 (01:53 +0200)]
[BOOTLIB] Check DBG with #if, not #ifdef (#1621)
Serge Gautherie [Wed, 5 Jun 2019 23:51:46 +0000 (01:51 +0200)]
[LWIP] Fix src/core/init.c a bit (#1620)
Cherry-pick
http://git.savannah.nongnu.org/cgit/lwip.git/commit/src/core/init.c?id=
c0b534e5318baf870e2152c70d4d11a3a86181f3
Serge Gautherie [Wed, 5 Jun 2019 23:50:55 +0000 (01:50 +0200)]
[MBEDTLS] Use '#ifndef __REACTOS__', instead of '#if DBG & 0' (#1619)
- Don't use '|' on a '#if'
- Remove a personal comment.
Serge Gautherie [Wed, 5 Jun 2019 23:50:24 +0000 (01:50 +0200)]
[DXSDK] Improve dxerr?.h a bit (#1617)
*Use '||', instead of '|', on a '#if'.
*Synchronize some white spaces and blank lines.
Serge Gautherie [Wed, 5 Jun 2019 23:49:52 +0000 (01:49 +0200)]
[NCFTP] Check _DEBUG with #ifdef, not #if (#1616)
Serge Gautherie [Wed, 5 Jun 2019 23:49:18 +0000 (01:49 +0200)]
[NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615)
Serge Gautherie [Wed, 5 Jun 2019 16:37:07 +0000 (18:37 +0200)]
[ADVAPI32:REG] Remove some useless casts (#1614)
Serge Gautherie [Wed, 5 Jun 2019 16:15:02 +0000 (18:15 +0200)]
[USER32] RegisterClipboardFormatA(): Enable a SetLastError() (#1612)
Eric Kohl [Wed, 5 Jun 2019 08:23:55 +0000 (10:23 +0200)]
[MC] Add syntax and help texts for the NET SHARE command.
Serge Gautherie [Fri, 31 May 2019 14:29:16 +0000 (16:29 +0200)]
[LOCALSPL] Check DBG with #if, not #ifdef
Addendum to r74433.
Serge Gautherie [Wed, 15 May 2019 23:26:32 +0000 (01:26 +0200)]
[NTOS:MM] PeFmtCreateSection(): Improve AMD64 image failure case
Addendum to
98638cc2dfdde460ae49941c76dd51f1b796a001.
CORE-15981
Serge Gautherie [Tue, 4 Jun 2019 14:56:33 +0000 (16:56 +0200)]
Misc addendum to CORE-14271 (#1529)
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.
Also, add a FIXME.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RegisterClipboardFormatA/W() a bit
No functional change.
* [UDFS] Simplify SeSinglePrivilegeCheck() return value check
No functional change.
Addendum to
CORE-14271
Mas Ahmad Muhammad [Sun, 2 Jun 2019 11:55:07 +0000 (18:55 +0700)]
[RAPPS] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sun, 2 Jun 2019 11:54:12 +0000 (18:54 +0700)]
[EXPLORER] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:28:40 +0000 (05:28 +0700)]
[FORMAT] Update Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:19:59 +0000 (05:19 +0700)]
[RUNDLL32] Update Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:18:11 +0000 (05:18 +0700)]
[SUBST] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:08:13 +0000 (05:08 +0700)]
[SERVICES] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:03:51 +0000 (05:03 +0700)]
[RUNONCE] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 20:01:26 +0000 (03:01 +0700)]
[FONTVIEW] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 19:50:12 +0000 (02:50 +0700)]
[MSPAINT] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 14:21:21 +0000 (21:21 +0700)]
[OSK] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 12:28:34 +0000 (19:28 +0700)]
[REGEDIT] Update Indonesian translation. (#1598)
Eric Kohl [Tue, 4 Jun 2019 08:05:20 +0000 (10:05 +0200)]
[NET] Implement adding and deleting of network shares.