Pierre Schweitzer [Mon, 29 Dec 2014 21:22:49 +0000 (21:22 +0000)]
[RAMDISK]
Wait for 1 min max but don't limit the number of acquire, ie: swap inverted args.
This fixes ASSERT on use.
Spotted by Hervé
svn path=/trunk/; revision=65898
Hermès Bélusca-Maïto [Mon, 29 Dec 2014 21:12:06 +0000 (21:12 +0000)]
[RAPPS]
Finish Japanese translation, fix by Ai Asano and reported by Marco Maria Emanuele Bartucci.
CORE-8983 #resolve #comment Fixed, thanks!
svn path=/trunk/; revision=65897
Pierre Schweitzer [Mon, 29 Dec 2014 20:41:15 +0000 (20:41 +0000)]
[RAMDISK]
Define the GUID_BUS_TYPE_RAMDISK GUID
svn path=/trunk/; revision=65896
Pierre Schweitzer [Mon, 29 Dec 2014 18:00:50 +0000 (18:00 +0000)]
[RAMDISK]
Implement RamdiskQueryId() which is used in case of IRP_MJ_PNP + IRP_MN_QUERY_ID
svn path=/trunk/; revision=65895
Aleksandar Andrejevic [Mon, 29 Dec 2014 16:20:00 +0000 (16:20 +0000)]
[WHOAMI]
Use ANSI when printing to the console. Fix the logic of LookupPrivilegeDisplayNameW.
Patch by Ismael Ferreras Morezuelas.
CORE-8965 #resolve #comment Committed in revision r65894. Thanks!
svn path=/trunk/; revision=65894
Timo Kreuzer [Mon, 29 Dec 2014 14:25:30 +0000 (14:25 +0000)]
[GDI32]
Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helpers. Fixes 1931 wine tests.
svn path=/trunk/; revision=65893
Timo Kreuzer [Mon, 29 Dec 2014 14:16:16 +0000 (14:16 +0000)]
[WIN32K]
Simplify and fix calculation of biCompression in GreGetDIBitsInternal
svn path=/trunk/; revision=65892
Hermès Bélusca-Maïto [Mon, 29 Dec 2014 13:56:28 +0000 (13:56 +0000)]
[WIN32K]
- Add global user heap (un)map helper functions that will be used in other portions of code.
- For consistency purpose also add the note about the mapping in desktop.c (see r65863 for what I mean).
- Temporarily add many trace messages.
svn path=/trunk/; revision=65891
Hervé Poussineau [Mon, 29 Dec 2014 13:16:07 +0000 (13:16 +0000)]
[NTOS:IO] Add some debug prints for remove locks
svn path=/trunk/; revision=65890
Timo Kreuzer [Mon, 29 Dec 2014 13:12:29 +0000 (13:12 +0000)]
[GDI32]
In Escape() make use of GdiGetDcAttr(), GreatLordish -> English and fix copy-pasta in comments, improve formatting, remove some code that (attention euphemism) wasn't exactly correct.
svn path=/trunk/; revision=65889
Timo Kreuzer [Mon, 29 Dec 2014 13:12:23 +0000 (13:12 +0000)]
[GDI32]
Fix some parameters in the spec file
svn path=/trunk/; revision=65888
Timo Kreuzer [Mon, 29 Dec 2014 13:12:15 +0000 (13:12 +0000)]
[WINE]
Add LOGBRUSH16 and LOGPEN16 to wingdi16.h
svn path=/trunk/; revision=65887
Timo Kreuzer [Mon, 29 Dec 2014 13:12:10 +0000 (13:12 +0000)]
[WIN32K]
Implement GdiGetEMFRestorDc case in NtGdiGetDCDword
svn path=/trunk/; revision=65886
Timo Kreuzer [Mon, 29 Dec 2014 13:12:05 +0000 (13:12 +0000)]
[WIN32K]
- Implement GreCreateCompatibleDC, allowing to pass in a boolean value, specifying the DC type (normal or "alternative" DC, aka metafile DC)
- Properly implement NtGdiCreateMetafileDC around GreCreateCompatibleDC
svn path=/trunk/; revision=65885
Timo Kreuzer [Mon, 29 Dec 2014 13:11:59 +0000 (13:11 +0000)]
[WIN32K]
- Implement NtGdiGetObjectBitmapHandle
- Set BR_IS_DIBPALCOLORS in IntGdiCreateDIBBrush
svn path=/trunk/; revision=65884
Timo Kreuzer [Mon, 29 Dec 2014 13:11:54 +0000 (13:11 +0000)]
[GDI32]
In DeleteObject handle ALTDC type, factor out GdiDeleteBrushOrPen, improve code a bit
svn path=/trunk/; revision=65883
Timo Kreuzer [Mon, 29 Dec 2014 13:11:48 +0000 (13:11 +0000)]
[GDI32]
Improve client object code
svn path=/trunk/; revision=65882
Timo Kreuzer [Mon, 29 Dec 2014 13:11:40 +0000 (13:11 +0000)]
[GDI32]
Improve GetROP2and SetROP2
svn path=/trunk/; revision=65881
Timo Kreuzer [Mon, 29 Dec 2014 13:11:35 +0000 (13:11 +0000)]
[GDI32]
- Do not call BitBlt from StretchBlt when extension matches, this is handled in win32k
- Use GdiGetDcAttr
svn path=/trunk/; revision=65880
Timo Kreuzer [Mon, 29 Dec 2014 13:11:31 +0000 (13:11 +0000)]
[GDI32]
Improve code in painting.c:
- Add annotations
- Use consitent formatting
- Use better parameter/variable names
svn path=/trunk/; revision=65879
Timo Kreuzer [Mon, 29 Dec 2014 13:11:27 +0000 (13:11 +0000)]
[GDI32]
Move PatBlt, GetROP2 and SetROP2 to appropriate source files
svn path=/trunk/; revision=65878
Timo Kreuzer [Mon, 29 Dec 2014 13:11:07 +0000 (13:11 +0000)]
[GDI32]
Add anotations to arc.c, replace an instance of the ugly gfx_worker with an RCAST() macro
svn path=/trunk/; revision=65877
Amine Khaldi [Mon, 29 Dec 2014 12:56:47 +0000 (12:56 +0000)]
[TRANSLATIONS] Chinese (zh-CN) translation update by Henry Tang Ih. CORE-8935
svn path=/trunk/; revision=65876
Timo Kreuzer [Mon, 29 Dec 2014 12:28:56 +0000 (12:28 +0000)]
[PSDK]
Fix copypasta from r65873
svn path=/trunk/; revision=65875
Giannis Adamopoulos [Mon, 29 Dec 2014 12:24:03 +0000 (12:24 +0000)]
[SHELL32]
* Give focus to the def view control when CDesktopBrowser gets focus.
CORE-8980
svn path=/trunk/; revision=65874
Timo Kreuzer [Mon, 29 Dec 2014 12:01:23 +0000 (12:01 +0000)]
[PSDK]
Improve some prototypes in wingdi.h
svn path=/trunk/; revision=65873
Hervé Poussineau [Mon, 29 Dec 2014 09:07:01 +0000 (09:07 +0000)]
[RAMDISK] Explicit the relation type check
svn path=/trunk/; revision=65872
Hervé Poussineau [Mon, 29 Dec 2014 09:06:58 +0000 (09:06 +0000)]
[RAMDISK] White space fixes
svn path=/trunk/; revision=65871
Pierre Schweitzer [Sun, 28 Dec 2014 22:48:08 +0000 (22:48 +0000)]
[NTOSKRNL]
Use the PIP_REGISTRY_DATA() for DevicePropertyInstallState case in IoGetDeviceProperty()
svn path=/trunk/; revision=65870
Pierre Schweitzer [Sun, 28 Dec 2014 22:37:55 +0000 (22:37 +0000)]
[RAMDISK]
Implement support for IOCTL_DISK_CHECK_VERIFY, IOCTL_STORAGE_CHECK_VERIFY, IOCTL_STORAGE_CHECK_VERIFY2, IOCTL_CDROM_CHECK_VERIFY
svn path=/trunk/; revision=65869
Hervé Poussineau [Sun, 28 Dec 2014 22:33:17 +0000 (22:33 +0000)]
[NTOS:IOMGR] When booting from a ramdisk, always assign drive letter X: to it
The only incomplete part to boot the LiveCD from PXE is some support in ramdisk.sys
svn path=/trunk/; revision=65868
Hervé Poussineau [Sun, 28 Dec 2014 22:33:11 +0000 (22:33 +0000)]
[NTOS:PNPMGR] Implement IoGetDeviceProperty/DevicePropertyInstallState case
svn path=/trunk/; revision=65867
Hervé Poussineau [Sun, 28 Dec 2014 22:15:34 +0000 (22:15 +0000)]
[FREELDR] Add missing dependency (required by scsiport.c)
svn path=/trunk/; revision=65866
Hervé Poussineau [Sun, 28 Dec 2014 22:15:08 +0000 (22:15 +0000)]
[WHOAMI] Better error message when we're unable to find the logon SID
svn path=/trunk/; revision=65865
Pierre Schweitzer [Sun, 28 Dec 2014 21:29:32 +0000 (21:29 +0000)]
[NTOSKRNL]
Add missing specifiers
svn path=/trunk/; revision=65864
Hermès Bélusca-Maïto [Sun, 28 Dec 2014 20:50:35 +0000 (20:50 +0000)]
[WIN32K]
A bit of code reorganization:
- move a maximum of typedefs into their corresponding headers,
- move user heap functionality into a dedicated header,
- add a note in some functions that the first heap mapping entry in the W32 process info structure is dedicated for the global user heap mapping,
- remove extra-parenthesis in casts.
svn path=/trunk/; revision=65863
Pierre Schweitzer [Sun, 28 Dec 2014 18:31:06 +0000 (18:31 +0000)]
[NTOSKRNL]
- In case of AssignSecurityDescriptor operation in IopGetSetSecurityObject(), put the security descriptor in cache before attempting the assignement
- In IopUnloadDevice(), don't attempt to free the security descriptor, let this to Ob by just derefencing it. Spotted & fixed by Thomas.
This unregresses VMware Tools installation.
CORE-7991
svn path=/trunk/; revision=65862
Hermès Bélusca-Maïto [Sun, 28 Dec 2014 15:28:00 +0000 (15:28 +0000)]
[WIN32K]
Split init code into GDI part and USER part. Don't use Eng* functions to initialize the InputIdleEvent.
Part 2/x
svn path=/trunk/; revision=65861
Pierre Schweitzer [Sun, 28 Dec 2014 13:15:14 +0000 (13:15 +0000)]
[NTOSKRNL]
Also lock IopSecurityResource during access check in IopParseDevice
svn path=/trunk/; revision=65860
Thomas Faber [Sun, 28 Dec 2014 13:05:48 +0000 (13:05 +0000)]
[MSI]
- Apply Wine commit
f41ac94e (msi: Include the terminating null in the buffer size for decoded stream names.) by Hans Leidekker. Fixes a stack buffer overflow when installing VMware Tools.
svn path=/trunk/; revision=65859
Hermès Bélusca-Maïto [Sun, 28 Dec 2014 13:00:28 +0000 (13:00 +0000)]
[WIN32K]: Rework a bit the initialization code to modularize it a bit (some parts to be reused in other places). Part 1/x
svn path=/trunk/; revision=65858
Pierre Schweitzer [Sun, 28 Dec 2014 12:57:58 +0000 (12:57 +0000)]
[NTOSKRNL]
Acquire IopSecurityResource exclusive when required. Spotted by Thomas.
svn path=/trunk/; revision=65857
Pierre Schweitzer [Sun, 28 Dec 2014 10:05:29 +0000 (10:05 +0000)]
[NTOSKRNL]
- Implement IopGetDeviceAttachmentBase() which allows getting the base device of the device stack given any device object in it
- Implement IopGetDevicePDO() which returns the physical device object of the device stack given any device object in it
- Implement IopSetDeviceSecurityDescriptor() which will swap the old security descriptor of a device object with a new provided one
- Implement IopSetDeviceSecurityDescriptors() which will swap the old security descriptor with a new provided one in all the device objects from the lowest provided to the uppest provided one.
- Fix a fixme in IopGetSetSecurityObject(), the operation SetSecurityDescriptor is now fully implemented for both PDO & DO.
This is required by VMware driver vmci.sys.
Even though, the installation doesn't get any better; it just changes the BSOD, we now face a memory corruption (in SE).
CORE-7991
svn path=/trunk/; revision=65856
Eric Kohl [Sun, 28 Dec 2014 09:16:41 +0000 (09:16 +0000)]
[USETUP]
Update the on-disk partition tables immediately after modifying the in-memory tables.
svn path=/trunk/; revision=65855
Aleksey Bragin [Sat, 27 Dec 2014 22:19:36 +0000 (22:19 +0000)]
[RAPPS]
- Add another tiny text-editor Akelpad, which works "good enough" in ReactOS.
Suggested by sergeygraf@yandex.ru, patch created by rechitskiy@reactos.org
svn path=/trunk/; revision=65854
Hervé Poussineau [Sat, 27 Dec 2014 19:57:42 +0000 (19:57 +0000)]
[ADVAPI/LSASRV] Implement LookupPrivilegeDisplayNameA, LookupPrivilegeDisplayNameW, LsaLookupPrivilegeDisplayName, LsarLookupPrivilegeDisplayName
Also partly implement LsarpLookupPrivilegeDisplayName (currently, privilege description is the same as privilege name)
svn path=/trunk/; revision=65853
Hermès Bélusca-Maïto [Sat, 27 Dec 2014 19:16:05 +0000 (19:16 +0000)]
[WIN32K]
- Put GDI initialization function(s) in a dedicated file.
- Whitespace fixes...
svn path=/trunk/; revision=65852
David Quintana [Sat, 27 Dec 2014 14:04:32 +0000 (14:04 +0000)]
[FRAMEDYN]
* Actually use the right declaration. Fixes MSVC builds.
svn path=/trunk/; revision=65851
Pierre Schweitzer [Sat, 27 Dec 2014 13:46:00 +0000 (13:46 +0000)]
[NTOSKRNL]
Rename IopSecurityFile() to IopGetSetSecurityObject()
svn path=/trunk/; revision=65850
Pierre Schweitzer [Sat, 27 Dec 2014 13:33:14 +0000 (13:33 +0000)]
[FRAMEDYN]
Partly implement the Provider class from WMI.
This allows VMware Tools installer to complain a bit less about imports not found.
The installation still fails and still ends with a BSOD though.
CORE-7991
svn path=/trunk/; revision=65849
Daniel Reimer [Sat, 27 Dec 2014 13:00:03 +0000 (13:00 +0000)]
[RAPPS]
Add WINE Mono to RAPPS
CORE-8871 #resolve #comment Added to RApps DB.
svn path=/trunk/; revision=65848
Eric Kohl [Sat, 27 Dec 2014 12:33:59 +0000 (12:33 +0000)]
[USETUP]
- Re-enable the partition size check and display a warning if the install partition is too small.
- Update the required install partition size to 550MB.
svn path=/trunk/; revision=65847
Eric Kohl [Sat, 27 Dec 2014 10:15:32 +0000 (10:15 +0000)]
[USETUP]
AddPartitionToDisk: Initialize DiskEntry pointer for existing partition entries.
svn path=/trunk/; revision=65846
James Tabor [Sat, 27 Dec 2014 06:59:29 +0000 (06:59 +0000)]
[Win32ss]
- Add header for Ime information. Setup support for Ime types and hot keys.
- Finish keyboard processing changes and call Imm process key for callback to user mode.
svn path=/trunk/; revision=65845
James Tabor [Sat, 27 Dec 2014 06:33:48 +0000 (06:33 +0000)]
[w32knapi]
- Add Imm.h.
svn path=/trunk/; revision=65844
James Tabor [Sat, 27 Dec 2014 04:18:17 +0000 (04:18 +0000)]
[Include]
- Add mod switch for SAS hotkey support.
- Add ImmProcessKey return flags, works the same as ImmProcessHotKey for WinCE.
svn path=/trunk/; revision=65843
James Tabor [Sat, 27 Dec 2014 03:00:09 +0000 (03:00 +0000)]
[Win32k]
- Move IME from stubs into its own file. Add flags and types to main header.
- Later, how to add Ime.h from mingw (tested it and works) and not effect VC++ ? VC SDK has Ime.h.
- Getting ready for Window Class update based on current wine tests.
svn path=/trunk/; revision=65842
Hermès Bélusca-Maïto [Fri, 26 Dec 2014 20:55:30 +0000 (20:55 +0000)]
Whitespace fix.
svn path=/trunk/; revision=65841
Amine Khaldi [Fri, 26 Dec 2014 14:33:14 +0000 (14:33 +0000)]
[DXDIAG] Fix tab content redraw problem. By Lee Schroeder. CORE-8734
svn path=/trunk/; revision=65840
Amine Khaldi [Fri, 26 Dec 2014 14:18:02 +0000 (14:18 +0000)]
[FONTVIEW][MPLAY32][MSPAINT][TASKMGR] Chinese (zh-CN) translation update by Henry Tang Ih. CORE-8935
svn path=/trunk/; revision=65839
Amine Khaldi [Fri, 26 Dec 2014 14:06:23 +0000 (14:06 +0000)]
[WINLOGON][USER32] SetLogonNotifyWindow has only one parameter. Spotted by Giannis Adamopoulos. CORE-8174
svn path=/trunk/; revision=65838
Eric Kohl [Fri, 26 Dec 2014 14:06:19 +0000 (14:06 +0000)]
[NOTEPAD]
Fix check mark of the status bar menu item.
Fix is based on mudheads patch.
CORE-8297 #resolve
svn path=/trunk/; revision=65837
Eric Kohl [Fri, 26 Dec 2014 13:11:57 +0000 (13:11 +0000)]
[SYSDM]
Fix startup and recovery option dialog issues.
Patch by Ricardo Hanke.
Thanks a lot!
CORE-8952 #resolve
svn path=/trunk/; revision=65836
Hermès Bélusca-Maïto [Fri, 26 Dec 2014 12:06:43 +0000 (12:06 +0000)]
[WIN32K]: Anecdotal formatting/renaming changes before reusing this code in other parts of wijn32k.
svn path=/trunk/; revision=65835
Pierre Schweitzer [Fri, 26 Dec 2014 11:40:17 +0000 (11:40 +0000)]
[DXDIAG]
Update French translation
svn path=/trunk/; revision=65834
Hervé Poussineau [Fri, 26 Dec 2014 11:38:43 +0000 (11:38 +0000)]
[FREELDR] Support custom SystemPath and ramdisk in setup phase
We can now start ReactOS installation via PXE boot.
svn path=/trunk/; revision=65833
Hervé Poussineau [Fri, 26 Dec 2014 11:38:39 +0000 (11:38 +0000)]
[FREELDR] Merge setupldr_pe and freeldr_pe
svn path=/trunk/; revision=65832
Hervé Poussineau [Fri, 26 Dec 2014 11:38:35 +0000 (11:38 +0000)]
[NTFS] Be verbose only on unimplemented FSCTL requests we're supposed to handle
svn path=/trunk/; revision=65831
Hervé Poussineau [Fri, 26 Dec 2014 11:38:31 +0000 (11:38 +0000)]
[NTOS:CC] Fix some debug prints
svn path=/trunk/; revision=65830
Pierre Schweitzer [Fri, 26 Dec 2014 11:02:47 +0000 (11:02 +0000)]
[CHARMAP]
Fix the following issues:
- Skip rotated font (font name starting with "@" char)
- Fix a comment (misspelled "Richedit")
- Fix enlarged preview font in font name is long (it truncated font name in 31 chars when copying)
- Fix 2 magic values (255 here is not meaningful, and it doesn't even entirely showing Unicode Plane 0)
Patch by Roy Tam.
CORE-8966 #resolve #comment Thanks. Commited in r65829.
svn path=/trunk/; revision=65829
James Tabor [Fri, 26 Dec 2014 00:44:36 +0000 (00:44 +0000)]
- Patch by Aric Stewart : Pass WM_IME_CONTROL messages to the IME.
svn path=/trunk/; revision=65828
Thomas Faber [Thu, 25 Dec 2014 23:10:47 +0000 (23:10 +0000)]
[WIN32K:NTUSER]
- Don't forget to ProbeForWrite in NtUserProcessConnect
- Use SEH in NtUserSetInformationThread:UserThreadCsrApiPort
svn path=/trunk/; revision=65827
Pierre Schweitzer [Thu, 25 Dec 2014 22:01:29 +0000 (22:01 +0000)]
[WHOAMI]
Add French translation
It's totally broken though because the util directly writes Unicode to console. That should be fixed (see CORE-8965).
svn path=/trunk/; revision=65826
Hermès Bélusca-Maïto [Thu, 25 Dec 2014 15:50:07 +0000 (15:50 +0000)]
[USER32]
- CreateSystemThreads' parameter is unused, and the parameter of ONEPARAM_ROUTINE_CREATESYSTEMTHREADS win32k system call is set to TRUE when creating system threads in "remote processes", i.e. not CSRSS.
- Few code formatting fixes.
CORE-8949
svn path=/trunk/; revision=65825
Hermès Bélusca-Maïto [Thu, 25 Dec 2014 15:27:31 +0000 (15:27 +0000)]
[WIN32K]: Change the enum id name for something meaningful (here: PROC == process and not procedure).
svn path=/trunk/; revision=65824
Hermès Bélusca-Maïto [Thu, 25 Dec 2014 15:03:48 +0000 (15:03 +0000)]
[USER32]: Fix whitespace. Everybody knows that our user32/win32k modules are the best examples of good programming, indentation rules and so on...
svn path=/trunk/; revision=65823
David Quintana [Wed, 24 Dec 2014 17:00:53 +0000 (17:00 +0000)]
[RSHELL]
* Add a copy of CBandSite to rshell, so we can debug it in windows with our explorer.
svn path=/trunk/; revision=65822
David Quintana [Wed, 24 Dec 2014 16:14:10 +0000 (16:14 +0000)]
[BROWSEUI]
* Do not make browseui an NT6 dll just because it has a missing include and it needs a few previously undocumented constants. We can just define them in an undoc header.
svn path=/trunk/; revision=65821
Hermès Bélusca-Maïto [Wed, 24 Dec 2014 15:48:37 +0000 (15:48 +0000)]
[WIN32K]
Fix NtUserProcessConnect to use the process handle we give to it, instead of the "current process"... This should fix the user32 CSR connection that I was failing to fix in previous revisions...
CORE-8949
svn path=/trunk/; revision=65820
Hermès Bélusca-Maïto [Wed, 24 Dec 2014 15:25:42 +0000 (15:25 +0000)]
[NETSHELL]
Fix flags usage for LoadImage / CopyImage, that made network tray applet icons uglily being downscaled from 32px versions instead of their 16px counterparts.
svn path=/trunk/; revision=65819
James Tabor [Wed, 24 Dec 2014 00:18:03 +0000 (00:18 +0000)]
- Fix, always something, thank you Thomas.
svn path=/trunk/; revision=65818
Hermès Bélusca-Maïto [Tue, 23 Dec 2014 21:17:24 +0000 (21:17 +0000)]
[WIN32K]
Reintroduce CSR support for kernel mode, based on code from Ge that was wiped out in revision 58770, and by ntdll CSR code. Is needed for kernel to user-mode CSR callbacks.
For readers, I remind you the big callback picture in the Win32 subsystem:
- In Windows NT 3.1 and 3.51, USER and GDI was modeled against client/server model (USER32.DLL and WINSRV.DLL, and GDI32.DLL and GDISRV.DLL), all running in user mode (using the CSR API).
- Starting Windows NT 4.0 (and up), some USER and GDI parts were moved into kernel mode (in the WIN32K.SYS driver) to speedup communication. We get:
* GDI32.DLL as the client, doing win32k system calls (kernel-mode system calls to win32k),
* and USER32.DLL, WINSRV.DLL and WIN32K.SYS working in tandem, USER32.DLL being the client and {WINSRV.DLL, WIN32K.SYS} being the server.
USER32.DLL can do win32k system calls or CSR calls to WINSRV.DLL (client to server calls). For server-to-server calls, we have WINSRV.DLL
doing win32k system calls, or WIN32K.SYS doing CSR calls back to WINSRV.DLL . Also, there is the possibility for WIN32K.SYS to make user-mode
callbacks to USER32.DLL.
svn path=/trunk/; revision=65817
Hermès Bélusca-Maïto [Tue, 23 Dec 2014 20:35:42 +0000 (20:35 +0000)]
[NTDLL]: Whitespace fixes. No code changes.
svn path=/trunk/; revision=65816
James Tabor [Tue, 23 Dec 2014 19:05:44 +0000 (19:05 +0000)]
[NtUser]
- Crash while in recursion through hook calls. Move fast calls to api. Placed safe guards for removing message queue structures. Lock threads while calling hooks. Just add paranoid code to prevent recursion freeing that will crash the kernel at some point. Fixes OpenMPT crashes, see CORE-8819. This might improve the same issues with CORE-6734.
svn path=/trunk/; revision=65815
Amine Khaldi [Tue, 23 Dec 2014 19:01:02 +0000 (19:01 +0000)]
[KDVBOX] Properly handle the ASM source file.
svn path=/trunk/; revision=65814
Timo Kreuzer [Tue, 23 Dec 2014 17:48:16 +0000 (17:48 +0000)]
[KDVBOX]
Implement a virtualkd compatible kernel debugger transport DLL. I started this, because I didn't manage to get the original one working, but it turned out, the original one works, you only need to use the correct virtualkd version. Anyway, it's there now. A virtualkd version that works with VBox 4.3.16+ can be found here: http://forum.sysprogs.com/viewtopic.php?f=4&t=3370 or here: http://public.avast.com/~hnanicek/VirtualKd.zip
The folder is called kdvm, since I thought about adding support for VMWare as well, but here the original one probably works as well.
Also fix my email address in some files.
svn path=/trunk/; revision=65813
Hermès Bélusca-Maïto [Tue, 23 Dec 2014 17:11:00 +0000 (17:11 +0000)]
[SHORTCUTS]
Fix Explorer shortcut icon. Patch by Jared.
CORE-8955 #resolve #comment Fixed in r65812, thanks!
svn path=/trunk/; revision=65812
Hermès Bélusca-Maïto [Tue, 23 Dec 2014 16:42:59 +0000 (16:42 +0000)]
[USER32]
Reenable some disabled tests, while disabling some other calls, namely:
- code in ClientThreadStartup (that was moved in ClientThreadSetupHelper that is hackilly now called in Init() from DllMain),
- code in User32CallClientThreadSetupFromKernel,
- add two flag manual resets in Init() and the forced call to ClientThreadSetupHelper,
- and moreover the whole CSR call in DllMain, that seems to sometimes cause some user32 internal global pointers to remain NULL where they should not (more specifically some "pdi" thing).
Obviously all these problems need to be understood (why some things do not become initialized when they should, etc...). See r65799, revert r65810, and CORE-8949.
svn path=/trunk/; revision=65811
Hermès Bélusca-Maïto [Tue, 23 Dec 2014 14:31:28 +0000 (14:31 +0000)]
[USER32]: Add yet another magic hack to temporarily reenable bots (ofc. mention in the code that this is a hack). See r65799 for more details, and CORE-8949.
svn path=/trunk/; revision=65810
Amine Khaldi [Tue, 23 Dec 2014 11:25:42 +0000 (11:25 +0000)]
[TRANSLATIONS] Russian translation update by Kudratov Olimjon. CORE-8947
svn path=/trunk/; revision=65809
Amine Khaldi [Tue, 23 Dec 2014 11:01:17 +0000 (11:01 +0000)]
[BOOTDATA] Add some default settings for crash control to hivesys.inf. By Ricardo Hanke. CORE-8953
svn path=/trunk/; revision=65808
Amine Khaldi [Tue, 23 Dec 2014 10:53:07 +0000 (10:53 +0000)]
[SHDOCVW] Bring exports closer to native.
CORE-8936 CORE-8174
svn path=/trunk/; revision=65807
Amine Khaldi [Tue, 23 Dec 2014 10:50:10 +0000 (10:50 +0000)]
[SHLWAPI] Fix inverted StopWatch forwards. Accepted upstream. CORE-8954
svn path=/trunk/; revision=65806
David Quintana [Tue, 23 Dec 2014 01:55:48 +0000 (01:55 +0000)]
[EXPLORER]
* Fix count of visible buttons getting out of sync when removing buttons. Fixes empty space at the end of the notification toolbar.
CORE-8840 #resolve #comment This should be fixed as of r65805.
svn path=/trunk/; revision=65805
David Quintana [Tue, 23 Dec 2014 01:31:36 +0000 (01:31 +0000)]
[EXPLORER]
* Improve an older change that I commited by mistake, with the improvbements based on a patch by Giannis.
* In Windows, fixes the taskbar having a size grip with the taskbar is themed and locked.
* In ReactOS, the size grip never seems to disappear, contrary to Giannis' concerns in the issue.
* Because of the above, I decided to commit the changes, and let the sizing edge inconsistency be a followup to the issue.
CORE-6966 #resolve #comment A modified version of the patch was commited in r65804. Thanks.
svn path=/trunk/; revision=65804
David Quintana [Tue, 23 Dec 2014 01:13:05 +0000 (01:13 +0000)]
[EXPLORER]
* Handle WM_CONTEXTMENU in the notification area so it does not spread upwards to the taskbar window.
* In theory, only one of the two handlers would be necessary, and it is true when testing in Windows, but in ReactOS, the handler in CSysPagerWnd was not enough. This may be worth a look by the win32k experts to see if it's a bug, or Windows was correcting my error.
CORE-8870 #resolve #comment Should be fixed in r65803. Thanks for reporting.
svn path=/trunk/; revision=65803
Sylvain Petreolle [Mon, 22 Dec 2014 23:44:25 +0000 (23:44 +0000)]
[WHOAMI]
Fix warning into the russian file.
svn path=/trunk/; revision=65802
Pierre Schweitzer [Mon, 22 Dec 2014 23:00:22 +0000 (23:00 +0000)]
[FASTFAT]
So far, totally disable VPB swapout on dismount. It appears to have brought more issues than it actually solves.
A more accurate implementation will be required.
CORE-8928 #comment Can you please retry with r65801
svn path=/trunk/; revision=65801
Pierre Schweitzer [Mon, 22 Dec 2014 22:55:07 +0000 (22:55 +0000)]
[SHELL32]
Update French translation
svn path=/trunk/; revision=65800
Hermès Bélusca-Maïto [Mon, 22 Dec 2014 21:23:00 +0000 (21:23 +0000)]
In absence of patchbot, let's test patch directly on... trunk!! Yeah!! Let's break trunk! (or not, we'll see...)
[USER32][USERSRV][WIN32K]
- Flag CSRSS threads as such.
- Each time a win32 thread is "created" (or a win32k system call is done) a PsConvertToGuiThread call is done, that makes a Win32ThreadCallout which calls UserCreateThreadInfo. We should call back ClientThreadSetup to set client-side info.
- Introduce a ClientThreadSetupHelper function to try to understand what happens when doing direct calls to ClientThreadSetup and via win32k callbacks.
- Reenable CSR call in user32::DllMain but add shame hacks in Init(..) to force NtUserProcessConnect callbacks (yet they should not be done there): see the code comment associated for more details.
- Temporarily disable ClientThreadSetupHelper call in ClientThreadSetup because it makes things fail, like console input thread failing and so on...
- ... and in ClientThreadSetupHelper, some correct code is commented out because it currently breaks other things (like menu initialization etc...), and HACKS ARE ADDED!! (see especially the "if (gpsi)" one, that should not exist, but if removed we fail sometimes in MenuInit because gpsi becomes NULL for some reason, if some other code that makes redundant calls to NtUserProcessConnect, is uncommented).
To sum up I tried to scaffold the thing as it should be, but with disabled code to not break everything.
CORE-8949 #comment Revision 65799 committed the patch v1.
svn path=/trunk/; revision=65799