reactos.git
5 years ago[MSVCRT] export _except_handler4_common
Denis Malikov [Sun, 18 Nov 2018 17:02:22 +0000 (00:02 +0700)]
[MSVCRT] export _except_handler4_common

5 years ago[LOG2LINES] Use translate_line() for command line input too
Serge Gautherie [Sat, 22 Dec 2018 01:12:46 +0000 (02:12 +0100)]
[LOG2LINES] Use translate_line() for command line input too

NB: Last step would be to re-use translate_files()...

5 years ago[NTDLL][RTL] Implement RtlGetFullPathName_UEx
Andrew Boyarshin [Mon, 26 Nov 2018 12:50:40 +0000 (19:50 +0700)]
[NTDLL][RTL] Implement RtlGetFullPathName_UEx

5 years ago[APPHELP] Prevent a nullptr dereference 1216/head
Mark Jansen [Thu, 3 Jan 2019 21:17:54 +0000 (22:17 +0100)]
[APPHELP] Prevent a nullptr dereference

5 years ago[SHIMENG] Prevent a nullptr dereference
Mark Jansen [Thu, 3 Jan 2019 21:17:01 +0000 (22:17 +0100)]
[SHIMENG] Prevent a nullptr dereference

5 years ago[APPCOMPAT] Move sdbtagid.h and sdbtypes.h to a shared location
Mark Jansen [Thu, 3 Jan 2019 21:11:13 +0000 (22:11 +0100)]
[APPCOMPAT] Move sdbtagid.h and sdbtypes.h to a shared location

5 years ago[SHIMENG] Ignore shims that are loading
Mark Jansen [Thu, 22 Nov 2018 23:18:17 +0000 (00:18 +0100)]
[SHIMENG] Ignore shims that are loading

5 years ago[APPHELP] Fix a typo in the logging
Mark Jansen [Thu, 22 Nov 2018 23:08:58 +0000 (00:08 +0100)]
[APPHELP] Fix a typo in the logging

5 years ago[SHIMLIB] c++ compatibility
Mark Jansen [Thu, 22 Nov 2018 21:20:21 +0000 (22:20 +0100)]
[SHIMLIB] c++ compatibility

5 years ago[REACTOS] Fix misc 64 bit issues (#783)
Timo Kreuzer [Sat, 5 Jan 2019 09:50:11 +0000 (10:50 +0100)]
[REACTOS] Fix misc 64 bit issues (#783)

* [WIN32K] Fix handle calculation in DbgGdiHTIntegrityCheck
* [NOTEPAD] Fix MSVC warnings
* [PSDK] Simplify *PROC definitions in windef.h
* [VIDEOPRT] Don't try to use NtVdmControl on x64
* [FREELDR] Fix some macros
* [CRT] Make qsort 64 bit compatible
* [NTOS] Use #ifndef _WIN64 instead of #ifdef _M_IX86 around C_ASSERTs
* [FAST486] Fix 64 bit warnings and change DWORD to ULONG, so it can be used in kernel mode
* [APPHELP_APITEST] Fix 64 bit issue

5 years ago[MPG123] Update to version 1.25.10. CORE-15280
Thomas Faber [Sat, 1 Dec 2018 17:43:56 +0000 (18:43 +0100)]
[MPG123] Update to version 1.25.10. CORE-15280

5 years ago[MBEDTLS] Update to version 2.7.6. CORE-15280
Thomas Faber [Wed, 31 Oct 2018 15:00:34 +0000 (16:00 +0100)]
[MBEDTLS] Update to version 2.7.6. CORE-15280

Note: this disables the MBEDTLS_DEPRECATED_REMOVED configuration value,
because we require the now-deprecated MD5 & SHA functions for bcrypt.

5 years ago[LIBPNG] Update to version 1.6.35. CORE-15280
Thomas Faber [Mon, 29 Oct 2018 17:15:10 +0000 (18:15 +0100)]
[LIBPNG] Update to version 1.6.35. CORE-15280

5 years ago[OSK] Fix a sentence in Italian resource (#1219)
Bișoc George [Fri, 4 Jan 2019 22:14:16 +0000 (23:14 +0100)]
[OSK] Fix a sentence in Italian resource (#1219)

Addendum to 76002778 (see the comment left).

5 years ago[TRANSLATION] Improve Chinese translation of VCDControlTool. (#1217)
Luo Yufan [Fri, 4 Jan 2019 20:20:50 +0000 (04:20 +0800)]
[TRANSLATION] Improve Chinese translation of VCDControlTool. (#1217)

5 years ago[APISETS] Remove default kernel32 import library, since stubs no longer need it 1182/head
Mark Jansen [Sun, 23 Dec 2018 21:39:10 +0000 (22:39 +0100)]
[APISETS] Remove default kernel32 import library, since stubs no longer need it

5 years ago[VERIFIER] Remove stub special case, since our normal 'stub' code no longer links...
Mark Jansen [Sun, 23 Dec 2018 21:37:45 +0000 (22:37 +0100)]
[VERIFIER] Remove stub special case, since our normal 'stub' code no longer links against kernel32

5 years ago[WINSRV] ConSrvConnect: Always store the control dispatcher routine
Giannis Adamopoulos [Fri, 4 Jan 2019 17:38:36 +0000 (19:38 +0200)]
[WINSRV] ConSrvConnect: Always store the control dispatcher routine
This shouldn't be used only for console applications but can potentially be used by any application to receive shutdown notifications.
MSDN provides more information in the documentation for SetConsoleCtrlHandler. Our services.exe also expect to receive shutdown notifications in this way.

5 years ago[WINSRV] usersrv: Fix a wrong debug print
Giannis Adamopoulos [Fri, 4 Jan 2019 17:28:19 +0000 (19:28 +0200)]
[WINSRV] usersrv: Fix a wrong debug print

5 years ago[WINSRV] usersrv: Don't terminate processes with no top level windows
Giannis Adamopoulos [Thu, 3 Jan 2019 12:29:11 +0000 (14:29 +0200)]
[WINSRV] usersrv: Don't terminate processes with no top level windows
Consrv will handle these.

5 years ago[WINSRV] usersrv: remove wrong dead code and fix indentation
Giannis Adamopoulos [Thu, 3 Jan 2019 12:20:22 +0000 (14:20 +0200)]
[WINSRV] usersrv: remove wrong dead code and fix indentation

5 years ago[WINSRV] consrv: Implement terminating console processes on shutdown
Giannis Adamopoulos [Thu, 3 Jan 2019 12:26:57 +0000 (14:26 +0200)]
[WINSRV] consrv: Implement terminating console processes on shutdown
Also stub handling non-console, non-gui processes.

5 years ago[WINSRV] usersrv: Simplify sanity checks in UserClientShutdown
Giannis Adamopoulos [Thu, 3 Jan 2019 23:22:44 +0000 (01:22 +0200)]
[WINSRV] usersrv: Simplify sanity checks in UserClientShutdown
UserClientShutdown will never be called for csrss so we don't need to have a check for that. The existing check was broken and wasn't doing anything anyway.
Handle processing winlogon by doing nothing so that consrv won't be bothered about it.

5 years ago[MOUNTMGR] Fix buffer length checking
Pierre Schweitzer [Thu, 3 Jan 2019 22:10:31 +0000 (23:10 +0100)]
[MOUNTMGR] Fix buffer length checking

Found by Vadim Galiant.

CORE-15549

5 years ago[LDR] Ensure we start with a valid pointer 1201/head
Mark Jansen [Fri, 28 Dec 2018 18:27:32 +0000 (19:27 +0100)]
[LDR] Ensure we start with a valid pointer

5 years ago[LDR] Actually allocate what is asked for
Mark Jansen [Fri, 28 Dec 2018 18:27:09 +0000 (19:27 +0100)]
[LDR] Actually allocate what is asked for

5 years ago[LDR] Don't dereference a possible nullptr on a malformed forwarded import
Mark Jansen [Fri, 28 Dec 2018 18:26:32 +0000 (19:26 +0100)]
[LDR] Don't dereference a possible nullptr on a malformed forwarded import

5 years ago[LDR] Don't dereference a possible nullptr
Mark Jansen [Fri, 28 Dec 2018 18:25:43 +0000 (19:25 +0100)]
[LDR] Don't dereference a possible nullptr

5 years ago[OSK] Update translation files (#1189)
Bișoc George [Thu, 3 Jan 2019 21:28:03 +0000 (22:28 +0100)]
[OSK] Update translation files (#1189)

Translate the welcome dialog resource for Italian and Romanian.

5 years ago[APPWIZ] Russian and Ukrainian Translations Update (#1215)
Yaroslav Kibysh [Thu, 3 Jan 2019 21:20:40 +0000 (23:20 +0200)]
[APPWIZ] Russian and Ukrainian Translations Update (#1215)

5 years agoAddendum to 60f018ae: Remove obsolete DPRINTs and fix a DPRINT.
Eric Kohl [Thu, 3 Jan 2019 19:59:20 +0000 (20:59 +0100)]
Addendum to 60f018ae: Remove obsolete DPRINTs and fix a DPRINT.

5 years ago[RXCE] Fix leftover
Pierre Schweitzer [Thu, 3 Jan 2019 15:59:45 +0000 (16:59 +0100)]
[RXCE] Fix leftover

5 years ago[USER32] Let App Switcher activate only one window (#1214)
Katayama Hirofumi MZ [Thu, 3 Jan 2019 15:34:58 +0000 (00:34 +0900)]
[USER32] Let App Switcher activate only one window (#1214)

5 years ago[RDBSS] Fix pointer value assignation.
Hermès Bélusca-Maïto [Thu, 3 Jan 2019 14:47:29 +0000 (15:47 +0100)]
[RDBSS] Fix pointer value assignation.

5 years ago[RXCE] Fix 64 bit build
Timo Kreuzer [Thu, 3 Jan 2019 13:27:15 +0000 (14:27 +0100)]
[RXCE] Fix 64 bit build

5 years ago[ACPI] Add code to retrieve packet type data from ACPI methods. This will enable...
Eric Kohl [Wed, 2 Jan 2019 22:29:12 +0000 (23:29 +0100)]
[ACPI] Add code to retrieve packet type data from ACPI methods. This will enable the cmbatt driver to retrieve _BIF (battery information) or _BST (battery status) data. Also fix the buffer size calculation for integer and string data.

5 years ago[TCPIP] Don't trust the TEB
Pierre Schweitzer [Wed, 2 Jan 2019 22:01:24 +0000 (23:01 +0100)]
[TCPIP] Don't trust the TEB

And trust the Russian hackers to exploit that.

5 years ago[WIN32SS] Try to recover display when changing the display mode fails for whatever...
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:55:40 +0000 (20:55 +0100)]
[WIN32SS] Try to recover display when changing the display mode fails for whatever reason.

This helps when e.g. changing the resolution on the Dell Latitude D531,
which reports that it supports large resolutions (e.g. 1920x1440x32 and
others larger than 1024x768x32) but fails to apply these.
This usually happens because PDEVOBJ_pSurface(), and more precisely
ppdev->pldev->pfn.EnableSurface(), fails for these resolutions.

- PDEVOBJ_bSwitchMode(): Set the new video mode, or restore the original
  one in case of failure + release the allocated ppdevTmp if previous
  calls fail. Also unlock in reverse order of locking order.

- UserChangeDisplaySettings(): In case PDEVOBJ_pSurface() fails (but has
  reverted the original video mode), we still need to refresh the
  display since the display may have been messed up.

5 years ago[WIN32SS:NTUSER] Remove some hardcoded buffer sizes + number of chars vs. bytes mixup.
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:53:42 +0000 (20:53 +0100)]
[WIN32SS:NTUSER] Remove some hardcoded buffer sizes + number of chars vs. bytes mixup.

5 years ago[WIN32SS:NTUSER] Minor whitespace formatting.
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:51:46 +0000 (20:51 +0100)]
[WIN32SS:NTUSER] Minor whitespace formatting.

5 years ago[FRAMEBUF] Correctly check the return value of the EngDeviceIoControl() call and...
Hermès Bélusca-Maïto [Tue, 1 Jan 2019 19:44:24 +0000 (20:44 +0100)]
[FRAMEBUF] Correctly check the return value of the EngDeviceIoControl() call and return adequate value in DrvAssertMode().

5 years ago[NTUSER] Fix a few tests related to desktops and window stations
Giannis Adamopoulos [Wed, 2 Jan 2019 14:50:35 +0000 (16:50 +0200)]
[NTUSER] Fix a few tests related to desktops and window stations
- NtUserOpenInputDesktop: Don't crash if there is no input desktop yet
- NtUserOpenInputDesktop: Fail if the process doesn't belong to the interactive window station
- NtUserCreateWindowStation: Clear error on success
- DesktopWindowProc: Use UserOpenInputDesktop to get a handle to the input desktop

5 years ago[RDBSS][RXCE] Implement IRP cancellation
Pierre Schweitzer [Wed, 2 Jan 2019 14:01:38 +0000 (15:01 +0100)]
[RDBSS][RXCE] Implement IRP cancellation

CORE-15441

5 years ago[TRANSLATION] Spanish translations (#944)
Julio Carchi [Wed, 2 Jan 2019 11:01:44 +0000 (06:01 -0500)]
[TRANSLATION] Spanish translations (#944)

5 years ago[NTOSKRNL] Add a raw implementation of !irpfind in kdbg
Pierre Schweitzer [Tue, 1 Jan 2019 20:58:18 +0000 (21:58 +0100)]
[NTOSKRNL] Add a raw implementation of !irpfind in kdbg

This is far from perfect, and totally doesn't match the
WinDBG way of doing it. Instead of browsing pool to find
matching 'IRP' tags, we just browse all the processes
to find the queued IRP. This requires the IRPs to be queued,
obviously, and will make us miss the leaked IRPs, for instance.

Proper way to do it would be to implement !poolfind and then
rely on its implementation to find our IRPs.

Perhaps later ;-)

5 years ago[TRANSLATION] Hindi translation of browseui, comctl32 and shell32 (#1209)
Arnav Bhatt [Tue, 1 Jan 2019 18:43:42 +0000 (00:13 +0530)]
[TRANSLATION] Hindi translation of browseui, comctl32 and shell32 (#1209)

5 years ago[LDR] Introduce a private heap for the loader. 1204/head
Mark Jansen [Sun, 14 Oct 2018 21:16:36 +0000 (23:16 +0200)]
[LDR] Introduce a private heap for the loader.
This ensures we can still do stuff when the process heap is corrupted.

5 years ago[BATTC] Fixed an oops!
Eric Kohl [Tue, 1 Jan 2019 12:48:43 +0000 (13:48 +0100)]
[BATTC] Fixed an oops!

5 years ago[BATTC] Some tiny fixes
Eric Kohl [Tue, 1 Jan 2019 12:13:20 +0000 (13:13 +0100)]
[BATTC] Some tiny fixes

- Add missing parameter to a DPRINT.
- Print pointers using %p instead of %x.
- Move all executable code behind a functions initial DPRINT.
- Do not use non-trivial initializers.
- Check for NULL instead of using !.
- Add missing parentheses.

5 years ago[BATTC] Fix indentation. No code changes!
Eric Kohl [Tue, 1 Jan 2019 11:58:53 +0000 (12:58 +0100)]
[BATTC] Fix indentation. No code changes!

5 years ago[TCPIP] Check buffer before dereferencing it
Pierre Schweitzer [Tue, 1 Jan 2019 09:45:48 +0000 (10:45 +0100)]
[TCPIP] Check buffer before dereferencing it

CID 716664

5 years ago[SETUP] Silence some noisy DPRINT1
Pierre Schweitzer [Tue, 1 Jan 2019 08:57:26 +0000 (09:57 +0100)]
[SETUP] Silence some noisy DPRINT1

5 years agoHappy New Year 2019 everybody!
Hermès Bélusca-Maïto [Mon, 31 Dec 2018 23:00:00 +0000 (00:00 +0100)]
Happy New Year 2019 everybody!

5 years ago[TRANSLATION] Update Chinese translation. (#1212)
Luo Yufan [Mon, 31 Dec 2018 20:47:58 +0000 (04:47 +0800)]
[TRANSLATION] Update Chinese translation. (#1212)

5 years ago[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of service device instances.
Eric Kohl [Mon, 31 Dec 2018 20:37:48 +0000 (21:37 +0100)]
[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of service device instances.

5 years ago[CONTRIBUTING] Add a notice for how to set your real name/mail (#1197)
Bișoc George [Mon, 31 Dec 2018 20:31:32 +0000 (21:31 +0100)]
[CONTRIBUTING] Add a notice for how to set your real name/mail (#1197)

Instead of posting the links each time, they'll be posted on README for future notice.

5 years ago[MPLAY32] Accept paths with double quotes from command-line (#1210)
Stanislav Motylkov [Mon, 31 Dec 2018 20:29:58 +0000 (23:29 +0300)]
[MPLAY32] Accept paths with double quotes from command-line (#1210)

CORE-15525

5 years ago[WIN32K] Deny deviceless calls to EngDeviceIoControl
Pierre Schweitzer [Mon, 31 Dec 2018 19:33:59 +0000 (20:33 +0100)]
[WIN32K] Deny deviceless calls to EngDeviceIoControl

This fixes BSOD happening in ntoskrnl coming from win32k under certain
conditions with 3rd party display drivers (such as VBox or VMware)

5 years ago[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for the enume...
Eric Kohl [Mon, 31 Dec 2018 15:14:04 +0000 (16:14 +0100)]
[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for the enumeration of services instances.

5 years ago[ZLIB] Import upstream commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:
Hervé Poussineau [Mon, 31 Dec 2018 13:23:14 +0000 (14:23 +0100)]
[ZLIB] Import upstream commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:

Fix CLEAR_HASH macro to be usable as a single statement.
As it is used in deflateParams().

5 years ago[TCPIP] Don't assume the TEB is always defined
Pierre Schweitzer [Mon, 31 Dec 2018 12:59:58 +0000 (13:59 +0100)]
[TCPIP] Don't assume the TEB is always defined

Fixes the crash in kmtest:TcpIpConnect test.

5 years ago[UMPNPMGR] PNP_GetDeviceList/PNP_GetDeviceListSize: Move device relations code into...
Eric Kohl [Mon, 31 Dec 2018 10:20:30 +0000 (11:20 +0100)]
[UMPNPMGR] PNP_GetDeviceList/PNP_GetDeviceListSize: Move device relations code into separate functions.

5 years ago[RTL] Fix RtlNewSecurityGrantedAccess improperly zeroing output buffer
Hervé Poussineau [Mon, 31 Dec 2018 10:11:43 +0000 (11:11 +0100)]
[RTL] Fix RtlNewSecurityGrantedAccess improperly zeroing output buffer

5 years ago[IPHLPAPI] Add support for service tags in GetOwnerModuleFromTcp/UdpEntry
Pierre Schweitzer [Mon, 31 Dec 2018 10:08:28 +0000 (11:08 +0100)]
[IPHLPAPI] Add support for service tags in GetOwnerModuleFromTcp/UdpEntry

If a service tag is set in owner information, then, we'll query advapi32 and
thus services to get the service name instead of the image name

5 years ago[TCPIP] Return the SubProcessTag when enumerating connections with owner class
Pierre Schweitzer [Mon, 31 Dec 2018 09:35:40 +0000 (10:35 +0100)]
[TCPIP] Return the SubProcessTag when enumerating connections with owner class

5 years ago[TCPIP] Save the SubProcessTag when an ADDRESS_FILE is created
Pierre Schweitzer [Mon, 31 Dec 2018 09:21:14 +0000 (10:21 +0100)]
[TCPIP] Save the SubProcessTag when an ADDRESS_FILE is created

5 years ago[SDK] Add PsGetCurrentThreadTeb() to the DDK
Pierre Schweitzer [Sun, 30 Dec 2018 21:47:36 +0000 (22:47 +0100)]
[SDK] Add PsGetCurrentThreadTeb() to the DDK

5 years ago[ADVAPI32_APITEST] Add tests showing that first field of OwningModuleInfo is the tag
Pierre Schweitzer [Sun, 30 Dec 2018 21:36:54 +0000 (22:36 +0100)]
[ADVAPI32_APITEST] Add tests showing that first field of OwningModuleInfo is the tag

Also, show that querying owner information about a connection owned by a service
returns the service name, and not the image nor its path.

Obviously, that fails in ReactOS.

5 years ago[FONT][WIN32SS] Partially implement font/text rotation (#1207)
Katayama Hirofumi MZ [Mon, 31 Dec 2018 09:56:43 +0000 (18:56 +0900)]
[FONT][WIN32SS] Partially implement font/text rotation (#1207)

Partially implement font/text rotation by LOGFONT.lfEscapement and improve the rendering image. If the angle was not a multiple of 90 degrees, then the background won't be filled. CORE-11848, CORE-15319

5 years ago[TRANSLATION] Update Chinese translation. (#1205)
Luo Yufan [Mon, 31 Dec 2018 09:47:37 +0000 (17:47 +0800)]
[TRANSLATION] Update Chinese translation. (#1205)

[NET][DISKPART][WINLOGON][ACCESS][APPWIZ][DESK][JOY][MMSYS][POWERCFG][SYSDM][NETCFGX][NETID][SAMSRV][TAPIUI][INF] Update Chinese translation.

5 years ago[APPWIZ] Do not hardcode the strings (#1208)
Bișoc George [Mon, 31 Dec 2018 07:42:53 +0000 (08:42 +0100)]
[APPWIZ] Do not hardcode the strings (#1208)

Let's make those message strings translatable.

5 years ago[SERVICES] Properly check again PID
Pierre Schweitzer [Sun, 30 Dec 2018 20:25:48 +0000 (21:25 +0100)]
[SERVICES] Properly check again PID

This fixes services not being found.
With that commit and the previous one, I_QueryTagInformation is now fully
functionnal and properly returns service name for a specific tag

5 years ago[SERVICES] pszName is a string, mark it so
Pierre Schweitzer [Sun, 30 Dec 2018 20:23:36 +0000 (21:23 +0100)]
[SERVICES] pszName is a string, mark it so

This fixes returning string with RI_ScQueryServiceTagInfo

5 years ago[ADVAPI32] When starting or sending a control to a service, set the tag in the TEB
Pierre Schweitzer [Sun, 30 Dec 2018 19:45:11 +0000 (20:45 +0100)]
[ADVAPI32] When starting or sending a control to a service, set the tag in the TEB

This now allows tracking the threads of the services thanks to their tag.

This fixes the failing test in advapi32:ServiceEnv

5 years ago[ADVAPI32] Stop pretending our advapi32 is NT6+
Pierre Schweitzer [Sun, 30 Dec 2018 19:36:20 +0000 (20:36 +0100)]
[ADVAPI32] Stop pretending our advapi32 is NT6+

This is wrong and messes up with internal structures (such as TEB).
For the two needed functions which are "NT6+", they were exported
with NT6, but already existed in W2K3 SP2.

This might fix random bugs

CORE-15526

5 years ago[SERVICES] On service start control message, send the service tag
Pierre Schweitzer [Sun, 30 Dec 2018 17:44:32 +0000 (18:44 +0100)]
[SERVICES] On service start control message, send the service tag

5 years ago[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of all device instances.
Eric Kohl [Sun, 30 Dec 2018 16:14:43 +0000 (17:14 +0100)]
[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of all device instances.

5 years ago[FREELDR] Explicitly call RamDiskInitialize() in RamDiskLoadVirtualFile().
Hermès Bélusca-Maïto [Sun, 30 Dec 2018 14:21:19 +0000 (15:21 +0100)]
[FREELDR] Explicitly call RamDiskInitialize() in RamDiskLoadVirtualFile().

5 years ago[USETUP] Fix the strings given to the printf-like functions (addendum to a3168373).
Hermès Bélusca-Maïto [Sun, 30 Dec 2018 14:15:31 +0000 (15:15 +0100)]
[USETUP] Fix the strings given to the printf-like functions (addendum to a3168373).

5 years ago[CDFS] Addendum to 5429771b, 6c733856 and 3c64b4cb (r75579): When the CDFS driver...
Hermès Bélusca-Maïto [Sun, 30 Dec 2018 13:59:08 +0000 (14:59 +0100)]
[CDFS] Addendum to 5429771b6c733856 and 3c64b4cb (r75579): When the CDFS driver is used as a fixed disk FS,
the type of device it should return must not be FILE_DEVICE_CD_ROM, but must be the actual underlying one!

This fixes recognizing *removable* USB keys as disks and not CD-ROMs.

CORE-13184

5 years ago[NTOS] Fix a NULL-pointer access bug.
Hermès Bélusca-Maïto [Sun, 30 Dec 2018 13:45:29 +0000 (14:45 +0100)]
[NTOS] Fix a NULL-pointer access bug.

5 years ago[NTOS] Don't use TAG_IO_NAME when calling ExFreePoolWithTag() for freeing FileObject...
Hermès Bélusca-Maïto [Sun, 30 Dec 2018 13:02:54 +0000 (14:02 +0100)]
[NTOS] Don't use TAG_IO_NAME when calling ExFreePoolWithTag() for freeing FileObject->FileName.Buffer .

This may look strange, since this buffer is originally allocated using
the TAG_IO_NAME tag. However, it happens that file-system drivers are
allowed to re-allocate this buffer: this is what the MS' open-sourced
CDFS driver does, see e.g. CdCommonCreate() and CdNormalizeFileNames()
in cdfs/create.c .

This fixes a pool tag mismatch 'mNoI' != 'nFdC' BSOD when resources
are freed when closing a file that has been opened with a relative name
on a CDFS-mounted volume.

5 years ago[NTOS] Code formatting only.
Hermès Bélusca-Maïto [Sun, 30 Dec 2018 12:40:09 +0000 (13:40 +0100)]
[NTOS] Code formatting only.

5 years ago[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for a list...
Eric Kohl [Sun, 30 Dec 2018 13:42:12 +0000 (14:42 +0100)]
[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for a list of all device instances.

5 years ago[SERVICES] Implement ScmGenerateServiceTag and call it on service creation
Pierre Schweitzer [Sun, 30 Dec 2018 13:09:54 +0000 (14:09 +0100)]
[SERVICES] Implement ScmGenerateServiceTag and call it on service creation

This allows assigning an unique ServiceTag to each Win32 service

5 years ago[SERVICES] Implement ScmGetServiceNameFromTag
Pierre Schweitzer [Sun, 30 Dec 2018 12:31:08 +0000 (13:31 +0100)]
[SERVICES] Implement ScmGetServiceNameFromTag

5 years ago[SERVICES] Implement RI_ScQueryServiceTagInfo
Pierre Schweitzer [Sun, 30 Dec 2018 11:25:18 +0000 (12:25 +0100)]
[SERVICES] Implement RI_ScQueryServiceTagInfo

5 years ago[ADVAPI32] Implement I_ScQueryServiceTagInfo
Pierre Schweitzer [Sun, 30 Dec 2018 11:12:40 +0000 (12:12 +0100)]
[ADVAPI32] Implement I_ScQueryServiceTagInfo

5 years ago[ADVAPI32] Implement I_QueryTagInformation
Pierre Schweitzer [Sun, 30 Dec 2018 10:52:37 +0000 (11:52 +0100)]
[ADVAPI32] Implement I_QueryTagInformation

5 years ago[SERVICES] Define the RI_ScQueryServiceTagInfo RPC call
Pierre Schweitzer [Sun, 30 Dec 2018 10:45:08 +0000 (11:45 +0100)]
[SERVICES] Define the RI_ScQueryServiceTagInfo RPC call

All the definitions are taken from ProcessHacker:
https://github.com/processhacker/processhacker/blob/master/phnt/include/subprocesstag.h

5 years ago[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of device instances for a...
Eric Kohl [Sun, 30 Dec 2018 11:55:31 +0000 (12:55 +0100)]
[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of device instances for a given enumerator.

5 years ago[NDK][NTOS] Add global definition of INIT_FUNCTION/INIT_SECTION (#779)
Timo Kreuzer [Sun, 30 Dec 2018 11:19:11 +0000 (12:19 +0100)]
[NDK][NTOS] Add global definition of INIT_FUNCTION/INIT_SECTION (#779)

* Add an NDK header to define INIT_FUNCTION/INIT_SECTION globally
* Use _declspec(allocate(x)) and _declspec(code_seg(x)) on MSVC versions that support it
* Use INIT_FUNCTION on functions only and INIT_SECTION on data only (required by MSVC)
* Place INIT_FUNCTION before the return type (required by MSVC)
* Make sure declarations and implementations share the same modifiers (required by MSVC)
* Add a global linker option to suppress warnings about defined but unused INIT section
* Merge INIT section into .text in freeldr

5 years ago[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for given...
Eric Kohl [Sat, 29 Dec 2018 23:39:08 +0000 (00:39 +0100)]
[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for given enumerators and take care of the terminating double Unicode null character.

5 years ago[WIN32K:NTUSER] Reference menus owned by a popup menu. CORE-15504 1200/head
Thomas Faber [Fri, 28 Dec 2018 12:39:23 +0000 (13:39 +0100)]
[WIN32K:NTUSER] Reference menus owned by a popup menu. CORE-15504

5 years ago[UMPNPMGR] PNP_GetDeviceList / PNP_GetDeviceListSize: Implement the buffer size calcu...
Eric Kohl [Sat, 29 Dec 2018 21:08:35 +0000 (22:08 +0100)]
[UMPNPMGR] PNP_GetDeviceList / PNP_GetDeviceListSize: Implement the buffer size calculation and device instance enumeration for a given enumerator and device name.

5 years ago[ADVAPI32_APITEST] Unknown field isn't that unknown and should contain "1"
Pierre Schweitzer [Sat, 29 Dec 2018 21:09:52 +0000 (22:09 +0100)]
[ADVAPI32_APITEST] Unknown field isn't that unknown and should contain "1"

See processhacker source code (as reference)

5 years ago[CABMAN] Fix a problem with creating temp files on some Windows system
Timo Kreuzer [Tue, 3 Apr 2018 19:25:04 +0000 (21:25 +0200)]
[CABMAN] Fix a problem with creating temp files on some Windows system

5 years ago[FONT][WIN32SS] Re-add casts for gcc
Mark Jansen [Sat, 29 Dec 2018 19:03:06 +0000 (20:03 +0100)]
[FONT][WIN32SS] Re-add casts for gcc

5 years ago[FONT][WIN32SS] Remove casts
Mark Jansen [Sat, 29 Dec 2018 18:46:37 +0000 (19:46 +0100)]
[FONT][WIN32SS] Remove casts

5 years ago[FONT][WIN32SS] Hold the freetype lock while accessing freetype data
Mark Jansen [Sat, 29 Dec 2018 18:46:14 +0000 (19:46 +0100)]
[FONT][WIN32SS] Hold the freetype lock while accessing freetype data